profile
viewpoint

celery/kombu 1987

Messaging library for Python.

brendanzab/algebra 54

Abstract algebra for Rust (still very much a WIP!)

flaper87/cdr_mongodb 30

MongoDB CDR backend for Asterisk

flaper87/asterisk-zmq-manager 8

An asterisk manager that speaks json and it's based on zmq.

aparo/Pydev-Django-Extension 6

It's a Pydev extension to integrate a django.

flaper87/bugsquasher 4

A pluggable tool for squashing bugs and tracking down issues

aparo/nosqlkit 3

NoSqlKit for python is a multi NoSQL engine ORM

d0ugal/mistral-ansible-actions 3

Mistral Actions for calling Ansible

delete branch lswith/probot-require-label

delete branch : adjust-log-level

delete time in 15 hours

issue closedlogstash-plugins/logstash-output-elasticsearch

pipeline value is sent to elasticsearch even when the value is an empty string

We have configured our logstash pipeline to do this at the end of the filter section:

   if ! [@metadata][pipeline] {
     mutate {
           add_field => {"[@metadata][pipeline]" => ""}
       }
     }

And then in the elasticsearch output:

   if [type] == "beats" {
     elasticsearch {
...
       pipeline => "%{[@metadata][pipeline]}"
...
     }
   }

This results in the following error thrown by the eleasticsearch output:

{
         "input" => {
        "type" => "log"
    },
         "agent" => {
            "hostname" => "a0fe929361c6",
                "name" => "flaper87-filebeat-test",
                  "id" => "1d58ef10-b92e-4b12-9c9a-8152ec78901d",
        "ephemeral_id" => "b9b71472-8e7d-4bf4-bb31-ac8eab60081f",
                "type" => "filebeat",
             "version" => "7.6.2"
    },
    "@timestamp" => 2020-08-13T06:28:55.998Z,
           "ecs" => {
        "version" => "1.4.0"
    },
           "log" => {
          "file" => {
            "path" => "/filebeat/logs/my-log-file.log"
        },
        "offset" => 64
    },
     "@metadata" => {
           "version" => "7.6.2",
          "pipeline" => "",
              "beat" => "filebeat",
              "type" => "_doc",
        "ip_address" => "10.128.15.207"
    },
      "@version" => "1",
          "host" => {
        "name" => "flaper87-filebeat-test"
    },
          "type" => "beats",
       "message" => "testing",
        "fields" => {
        "cluster" => "non-k8s"
    },
          "tags" => [
        [0] "local"
    ]
}
[2020-08-13T06:28:58,863][ERROR][logstash.outputs.elasticsearch][elasticsearch] Encountered a retryable error. Will Retry with exponential backoff  {:code=>400, :url=>"https://ccbf29977a6ce7ac1bb01e41c9ff9316.us-west-2.aws.found.io:9243/_bulk"}
[2020-08-13T06:29:00,985][ERROR][logstash.outputs.elasticsearch][elasticsearch] Encountered a retryable error. Will Retry with exponential backoff  {:code=>400, :url=>"https://ccbf29977a6ce7ac1bb01e41c9ff9316.us-west-2.aws.found.io:9243/_bulk"}
[2020-08-13T06:29:05,051][ERROR][logstash.outputs.elasticsearch][elasticsearch] Encountered a retryable error. Will Retry with exponential backoff  {:code=>400, :url=>"https://ccbf29977a6ce7ac1bb01e41c9ff9316.us-west-2.aws.found.io:9243/_bulk"}

I would have expected the elasticsearch-output to not send the pipeline "value" as part of the request, which I am assuming is what it is doing.

closed time in a day

flaper87

issue commentlogstash-plugins/logstash-output-elasticsearch

pipeline value is sent to elasticsearch even when the value is an empty string

This was fixed and pushed to the repo: https://github.com/logstash-plugins/logstash-output-elasticsearch/commit/8804933e2b15d867a049319e52ee61223552b6be

Tag pushed: https://github.com/logstash-plugins/logstash-output-elasticsearch/tree/v10.7.0

flaper87

comment created time in a day

delete branch flaper87/logstash-output-elasticsearch

delete branch : issue/961

delete time in a day

pull request commentlogstash-plugins/logstash-output-elasticsearch

Don't set the pipeline param if the sprintf returns an empty value

This was cherry-picked and pushed to the repo: https://github.com/logstash-plugins/logstash-output-elasticsearch/commit/8804933e2b15d867a049319e52ee61223552b6be

flaper87

comment created time in a day

push eventflaper87/logstash-output-elasticsearch

Flavio Percoco

commit sha 8804933e2b15d867a049319e52ee61223552b6be

Don't set the pipeline parameter if the value resolves to an empty string bump to 10.7.0 Co-authored-by: João Duarte <jsvd@users.noreply.github.com>

view details

Flavio Percoco

commit sha 24a3ef37c8e67ee3df6474afd82ab7184a71c7b8

document this behavior

view details

push time in a day

Pull request review commentlswith/probot-require-label

Adjust log levels to avoid flooding main probot's logs

 module.exports = async (app: Application) => {       logger.debug("Config exists");       logger.debug(config);       await handle(context, eventType!, 30000).catch(err => {-        logger.error(err);+        logger.warn(err);

This is because I am seeing a bunch of errors like:

{"name":"event","hostname":"XXXXXX","pid":38,"id":"5aa48700-dcd8-11ea-9da4-144379c1db2e","owner":"XXXX","repo":"XXXX","issue":64422,"app":"probot-require-label","level":"ERROR","err":{"message":"Couldn't remove label: needs:Team for issue: 64422, error: HttpError: Label does not exist","name":"Error","stack":"Error: Couldn't remove label: needs:Team for issue: 64422, error: HttpError: Label does not exist\n    at /botelastic/node_modules/probot-require-label/lib/handler.js:126:51"},"msg":"Couldn't remove label: needs:Team for issue: 64422, error: HttpError: Label does not exist","time":"2020-08-12T20:14:01.048Z","v":0}

The above error is not super useful for people operating a probot instance. I wish there was a way to alert the consumers of the bot about this rather than logging it in stdout

flaper87

comment created time in a day

create barnchlswith/probot-require-label

branch : adjust-log-level

created branch time in a day

push eventflaper87/logstash-output-elasticsearch

Flavio Percoco

commit sha 445a401c558a3e6bff03f4c05a2539c104777680

document this behavior

view details

push time in a day

push eventflaper87/logstash-output-elasticsearch

Flavio Percoco

commit sha f3fe4bcc9eff691ba53e5532f4f99bf586b144f2

Update lib/logstash/outputs/elasticsearch/common.rb Co-authored-by: João Duarte <jsvd@users.noreply.github.com>

view details

push time in a day

Pull request review commentlogstash-plugins/logstash-output-elasticsearch

Don't set the pipeline param if the sprintf returns an empty value

 def event_action_tuple(event)       params[:_type] = get_event_type(event) if use_event_type?(nil)        if @pipeline-        params[:pipeline] = event.sprintf(@pipeline)+        value = event.sprintf(@pipeline)+        if value+          params[:pipeline] = value+        end

ha, you can tell I'm used to python since I thought "" would evaluate to false. thanks for the suggestion.

flaper87

comment created time in a day

push eventflaper87/logstash-output-elasticsearch

Flavio Percoco

commit sha 6df0bbaebf19a920986e891558d2e70e61079f8f

Add unit tests

view details

push time in a day

create barnchflaper87/logstash-output-elasticsearch

branch : issue/961

created branch time in a day

issue openedlogstash-plugins/logstash-output-elasticsearch

pipeline value is sent to elasticsearch even when the value is an empty string

We have configured our logstash pipeline to do this at the end of the filter section:

   if ! [@metadata][pipeline] {
     mutate {
           add_field => {"[@metadata][pipeline]" => ""}
       }
     }

And then in the elasticsearch output:

   if [type] == "beats" and "k8s-stats" in [tags] {
     elasticsearch {
...
       pipeline => "%{[@metadata][pipeline]}"
...
     }
   }

This results in the following error thrown by the eleasticsearch output:

{
         "input" => {
        "type" => "log"
    },
         "agent" => {
            "hostname" => "a0fe929361c6",
                "name" => "flaper87-filebeat-test",
                  "id" => "1d58ef10-b92e-4b12-9c9a-8152ec78901d",
        "ephemeral_id" => "b9b71472-8e7d-4bf4-bb31-ac8eab60081f",
                "type" => "filebeat",
             "version" => "7.6.2"
    },
    "@timestamp" => 2020-08-13T06:28:55.998Z,
           "ecs" => {
        "version" => "1.4.0"
    },
           "log" => {
          "file" => {
            "path" => "/filebeat/logs/my-log-file.log"
        },
        "offset" => 64
    },
     "@metadata" => {
           "version" => "7.6.2",
          "pipeline" => "",
              "beat" => "filebeat",
              "type" => "_doc",
        "ip_address" => "10.128.15.207"
    },
      "@version" => "1",
          "host" => {
        "name" => "flaper87-filebeat-test"
    },
          "type" => "beats",
       "message" => "testing",
        "fields" => {
        "cluster" => "non-k8s"
    },
          "tags" => [
        [0] "local"
    ]
}
[2020-08-13T06:28:58,863][ERROR][logstash.outputs.elasticsearch][elasticsearch] Encountered a retryable error. Will Retry with exponential backoff  {:code=>400, :url=>"https://ccbf29977a6ce7ac1bb01e41c9ff9316.us-west-2.aws.found.io:9243/_bulk"}
[2020-08-13T06:29:00,985][ERROR][logstash.outputs.elasticsearch][elasticsearch] Encountered a retryable error. Will Retry with exponential backoff  {:code=>400, :url=>"https://ccbf29977a6ce7ac1bb01e41c9ff9316.us-west-2.aws.found.io:9243/_bulk"}
[2020-08-13T06:29:05,051][ERROR][logstash.outputs.elasticsearch][elasticsearch] Encountered a retryable error. Will Retry with exponential backoff  {:code=>400, :url=>"https://ccbf29977a6ce7ac1bb01e41c9ff9316.us-west-2.aws.found.io:9243/_bulk"}

I would have expected the elasticsearch-output to not send the pipeline "value" as part of the request, which I am assuming is what it is doing.

created time in a day

startedpanr/hugo-theme-terminal

started time in 12 days

push eventflaper87/stale

Waldir Pimenta

commit sha 5441c59ca424ba4c2d81077b7372d4def874e30c

Make default comment friendlier and actionable

view details

Waldir Pimenta

commit sha 68cc7e55a436cb67f5c779da4c1bcdbb54109f58

Update tests to match new default comment

view details

tako

commit sha 0e854e927a97800d532184e7be1c2e14572acfe6

Bugfix onlyLabels

view details

dependabot[bot]

commit sha b296a6a07926057c96224ab5df70bb51269bdaf6

Bump js-yaml from 3.12.1 to 3.13.1 Bumps [js-yaml](https://github.com/nodeca/js-yaml) from 3.12.1 to 3.13.1. - [Release notes](https://github.com/nodeca/js-yaml/releases) - [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md) - [Commits](https://github.com/nodeca/js-yaml/compare/3.12.1...3.13.1) Signed-off-by: dependabot[bot] <support@github.com>

view details

Jason Etcovitch

commit sha 2f6d58df196d77bef6bcf86223cc508fe2231791

Add ci.yml to use Actions for CI

view details

Waldir Pimenta

commit sha 05ae766958e481bfa297dbdad0ea74803eb638be

Re-add note about issue closure

view details

Jason Etcovitch

commit sha 44d5e5264de37737e7a7419be23d3975ead5a9aa

Merge pull request #162 from waldyrious/patch-1 Make default comment friendlier and actionable (fixes #67)

view details

dependabot[bot]

commit sha 73e79f2a2c5b2ee3136c6c2242bcfd5405a8ddb3

Bump eslint-utils from 1.3.1 to 1.4.2 Bumps [eslint-utils](https://github.com/mysticatea/eslint-utils) from 1.3.1 to 1.4.2. - [Release notes](https://github.com/mysticatea/eslint-utils/releases) - [Commits](https://github.com/mysticatea/eslint-utils/compare/v1.3.1...v1.4.2) Signed-off-by: dependabot[bot] <support@github.com>

view details

Jason Etcovitch

commit sha f9341503d84d6bd585c04c01148f4bd45a62a516

Merge pull request #231 from probot/actions-ci Use Actions for CI

view details

dependabot[bot]

commit sha 51390d4cb8b864c17bed5cb88debbca5d5e2389f

Bump mixin-deep from 1.3.1 to 1.3.2 Bumps [mixin-deep](https://github.com/jonschlinkert/mixin-deep) from 1.3.1 to 1.3.2. - [Release notes](https://github.com/jonschlinkert/mixin-deep/releases) - [Commits](https://github.com/jonschlinkert/mixin-deep/compare/1.3.1...1.3.2) Signed-off-by: dependabot[bot] <support@github.com>

view details

tcely

commit sha 102f8f8ea05596dc6c3fd4079727b98d16a9f128

fix(package): joi -> @hapi/joi (#210)

view details

Jason Etcovitch

commit sha cd1e7623c6971731d4c19846d62b4dd383616171

Merge pull request #213 from takose/bugfix-onlyLabels Bugfix onlyLabels

view details

dependabot[bot]

commit sha 73eac0516966d420cef4b26dc010feaf3f031bc8

Bump acorn from 5.7.3 to 5.7.4 Bumps [acorn](https://github.com/acornjs/acorn) from 5.7.3 to 5.7.4. - [Release notes](https://github.com/acornjs/acorn/releases) - [Commits](https://github.com/acornjs/acorn/compare/5.7.3...5.7.4) Signed-off-by: dependabot[bot] <support@github.com>

view details

Joshua Whetton

commit sha 97ba9cc7f7f86464e521e1492e18d50c60510b48

Rewording and spacing corrections Rewording the description under _How are issues and pull requests considered stale?_ and cleaned up a wild double-space.

view details

James M. Greene

commit sha a11311e72e861c1b6c87fc3c0fa4bfe733bb070c

Double-check issue state is not closed before acting Fixes #263

view details

James M. Greene

commit sha 3fe6a572c55053b94c1e864f70d43d8f60b616f7

Add tests to ensure locked issues are not acted on

view details

dependabot[bot]

commit sha d9bc6550bcc016b742224dad1b0bd1eb1396ef08

Bump https-proxy-agent from 2.2.1 to 2.2.4 (#275) Bumps [https-proxy-agent](https://github.com/TooTallNate/node-https-proxy-agent) from 2.2.1 to 2.2.4. - [Release notes](https://github.com/TooTallNate/node-https-proxy-agent/releases) - [Commits](https://github.com/TooTallNate/node-https-proxy-agent/compare/2.2.1...2.2.4) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

Jason Etcovitch

commit sha 32fdff543139290927502b0f696512902df3883a

Merge pull request #269 from JamesMGreene/ensure-open-issues Double-check issue state is not closed before acting

view details

James M. Greene

commit sha dfd6b5f799e9bde815a8faefa82cc2e3c3023890

Merge branch 'master' into ensure-unlocked-tests * master: Bump https-proxy-agent from 2.2.1 to 2.2.4 (#275) Double-check issue state is not closed before acting Bump acorn from 5.7.3 to 5.7.4

view details

Jason Etcovitch

commit sha 72cd69e17a470e2c176d0f75dd240897b86bec76

Merge pull request #271 from JamesMGreene/ensure-unlocked-tests Add tests to ensure locked issues are not acted on

view details

push time in 18 days

pull request commentlogstash-plugins/logstash-output-riemann

upgrade riemann-client to 0.2.6

Does the newer version of the riemann client library use the timeout internally? or is that something we should add here?

colinsurprenant

comment created time in a month

pull request commentalexliesenfeld/httpmock

Improve httpmock's standalone capabilities

that sounds fantastic! I am happy to wait 🙏

Feel free to close this PR too ☺️

flaper87

comment created time in 2 months

pull request commentalexliesenfeld/httpmock

Improve httpmock's standalone capabilities

@alexliesenfeld Arguably, this may not fit in the goals you have for this project. Let me elaborate on my use-case and see if you have a better idea on how to do this:

I have a set of projects that would benefit from having a "mock server" available where they can define their own mocked APIs, run their queries, etc. I would like this mock server to always be running and to have some APIs persisted as it would help testing the integration of a more complex architecture. Real scenario:

I have a Kubernetes cluster that uses nginx-ingress. The logs coming from nginx ingres are collected using filebeat and then sent to a Logstash instance that parses these events and stores, does some operations, and then eventually stores them somewhere.

I'd like to write tests that would create the mocked API endpoints in httpmock, and use it as a backend for the nginx-ingress in order to test the whole workflow.

Instead of setting it up everytime, I would like httpmock to be always active and accessible not only by me but also other folks in the team. The delete_all call would make this impossible as we may delete each other's endpoints.

I could probably also write my own code that doesn't use this macro but I would rather not, especially considering that it would be possible to allow for my use-case by simply adding this option. Although, I realize that the implications of adding an option like this is rarely "simple" in the long run.

Let me know what you think, hope I was clear enough.

flaper87

comment created time in 2 months

PR opened alexliesenfeld/httpmock

Improve httpmock's standalone capabilities

This PR does a couple of things:

  • Allow for keeping mocks after runs by setting the HTTPMOCK_KEEP_MOCKS variable
  • Allow for serving all existing mocks by accessing __mocks/
+37 -6

0 comment

5 changed files

pr created time in 2 months

push eventflaper87/httpmock

Flavio Percoco

commit sha 0ddc4f8d652a4631ccc84d0765562c32e366796f

Add Debug derive to ActiveMock

view details

Flavio Percoco

commit sha 99f18f053104bc8aa1b4c1d8c1cce027d5a21121

Add HTTPMOCK_KEEP_MOCKS env variable With this variable httpmock won't delete all mocks during the setup/cleanup steps. This is useful when using httpmock as a standalone, shared, service to test multiple services. More importantly, it helps preserving mocks accross runs for later use

view details

Flavio Percoco

commit sha c74f8e445125214fbb4dc07b94bd5fa751cc4164

Add read_all route to show all mocks by accessing __mocks

view details

Flavio Percoco

commit sha 75cca75d9e7ce287124e417d5ebea7e181f9a375

Make trailing / optional for the __mocks endpoint

view details

push time in 2 months

fork flaper87/httpmock

HTTP mocking library for Rust.

fork in 2 months

issue commentjazzband/prettytable

New PyPI release?

Ping @flaper87

I'll let @jezdez decide what the best next step is here. I've not been following this project for a bit or the jazzband processes for that matter.

I've done the steps in #22 that are required to pass this on.

I'll now remove myself as a maintainer of this project on pypi to reduce confusion and set expectations right. 😊🤗

hugovk

comment created time in 2 months

more