profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/fk/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Florian Kissling fk @gatsbyjs Frankfurt am Main, Germany http://6230.org/ Guru Meditation #0282010003 • he/him

fk/masonite 32

A Tumblr theme.

fk/custom-control-panel-theme 5

An alternative "Control Panel"-theme for Liferay

fk/compass-rgbapng 2

Compass plugin for providing cross-browser compatible RGBA support by creating transparent PNGs on the fly for browsers that don't support RGBA. Uses the pure Ruby ChunkyPNG library for hassle free install and deployment.

fk/gatsby-mail 2

A Gatsby email *application*

fk/gatsby 1

⚛️📄🚀 Blazing fast React.js static site generator

fk/isotope 1

An exquisite jQuery plugin for magical layouts. Enables filtering, sorting, and dynamic layouts.

fk/jQuery-One-FB-Like 1

A fork of Jake Rutter's jQuery Facebook-Like plugin.

fk/asfasdfasdf 0

Typography driven, feature-rich blogging theme with minimal aesthetics. Includes tags/categories support and extensive features for code blocks such as live preview, line numbers, and line highlighting.

fk/bu-tumblr 0

Isomorphic BU Tumblr

fk/cdnjs 0

Our goal is to operate this CDN in a peer reviewed fashion.

pull request commentcontentful/starter-gatsby-blog

Update to Gatsby v3, new `gatsby-plugin-image`; design rinse

Just took another look, and realized that one more thing I want to suggest changing before this is ready for another look is the naming of the script that aliases gatsby develop – that currently is called dev, which keeps tripping me up quite a bit. Is that a Contentful convention, or would you be OK with changing that to develop?

fk

comment created time in 9 hours

Pull request review commentcontentful/starter-gatsby-blog

Update to Gatsby v3, new `gatsby-plugin-image`; design rinse

 import React from 'react' import { Link } from 'gatsby'-import Img from 'gatsby-image'+import { GatsbyImage } from 'gatsby-plugin-image' -import styles from './article-preview.module.css'+import Container from './container'+import Tags from './tags'+import * as styles from './article-preview.module.css' -export default ({ article }) => (-  <div className={styles.preview}>-    <Img alt="" fluid={article.heroImage.fluid} />-    <h3 className={styles.previewTitle}>-      <Link to={`/blog/${article.slug}`}>{article.title}</Link>-    </h3>-    <small>{article.publishDate}</small>-    <p-      dangerouslySetInnerHTML={{-        __html: article.description.childMarkdownRemark.html,-      }}-    />-  </div>-)+const ArticlePreview = ({ posts }) => {+  if (!posts) return null+  if (!Array.isArray(posts)) return null++  return (+    <Container>+      <ul className={styles.articleList}>+        {posts.map((post) => {+          return (+            <li key={post.slug}>+              <Link to={`/blog/${post.slug}`} className={styles.link}>

Adjusted to just link image and title in e3bb4e3.

fk

comment created time in a day

PullRequestReviewEvent

push eventfk/starter-gatsby-blog

Florian Kissling

commit sha e3bb4e3da15f436466d36384a1f2f2191bb7cea7

a11y: Link just image and post title

view details

push time in a day

pull request commentcontentful/starter-gatsby-blog

Update to Gatsby v3, new `gatsby-plugin-image`; design rinse

Tried to make the change myself but I don't have permission to commit

Just invited you to my fork as a collaborator (and happy to do that for others)!

fk

comment created time in a day

PullRequestReviewEvent

Pull request review commentcontentful/starter-gatsby-blog

Update to Gatsby v3, new `gatsby-plugin-image`; design rinse

 import React from 'react' import { Link } from 'gatsby'-import Img from 'gatsby-image'+import { GatsbyImage } from 'gatsby-plugin-image' -import styles from './article-preview.module.css'+import Container from './container'+import Tags from './tags'+import * as styles from './article-preview.module.css' -export default ({ article }) => (-  <div className={styles.preview}>-    <Img alt="" fluid={article.heroImage.fluid} />-    <h3 className={styles.previewTitle}>-      <Link to={`/blog/${article.slug}`}>{article.title}</Link>-    </h3>-    <small>{article.publishDate}</small>-    <p-      dangerouslySetInnerHTML={{-        __html: article.description.childMarkdownRemark.html,-      }}-    />-  </div>-)+const ArticlePreview = ({ posts }) => {+  if (!posts) return null+  if (!Array.isArray(posts)) return null++  return (+    <Container>+      <ul className={styles.articleList}>+        {posts.map((post) => {+          return (+            <li key={post.slug}>+              <Link to={`/blog/${post.slug}`} className={styles.link}>

I changed things from exactly what you suggest to this, and am hereby calling out my own ignorance. Thank you, Megan – will adjust! :v: 🙏

fk

comment created time in a day

push eventfk/starter-gatsby-blog

Florian Kissling

commit sha 2597f3108354723e6c0f31241c150be9d6e76c57

Drop Bluebird/Promise in favor of async/await * use `reporter` to inform about errors * add bits of inline documentation * all following the official Gatsby Blog Starter (https://github.com/gatsbyjs/gatsby/blob/master/starters/blog/gatsby-node.js)

view details

push time in a day

Pull request review commentcontentful/starter-gatsby-blog

Update to Gatsby v3, new `gatsby-plugin-image`; design rinse

 import React from 'react' import { Link } from 'gatsby'-import Img from 'gatsby-image'+import { GatsbyImage } from 'gatsby-plugin-image' -import styles from './article-preview.module.css'+import Container from './container'+import Tags from './tags'+import * as styles from './article-preview.module.css' -export default ({ article }) => (-  <div className={styles.preview}>-    <Img alt="" fluid={article.heroImage.fluid} />-    <h3 className={styles.previewTitle}>-      <Link to={`/blog/${article.slug}`}>{article.title}</Link>-    </h3>-    <small>{article.publishDate}</small>-    <p-      dangerouslySetInnerHTML={{-        __html: article.description.childMarkdownRemark.html,-      }}-    />-  </div>+const ArticlePreview = ({ posts }) => (+  <Container>+    <ul className={styles.articleList}>+      {posts.map(({ node }) => {+        return (+          <li key={node.slug}>+            <Link to={`/blog/${node.slug}`} className={styles.link}>+              <GatsbyImage alt="" image={node.heroImage.traced} />+              <h2 className={styles.title}>{node.title}</h2>+              <p+                dangerouslySetInnerHTML={{+                  __html: node.description.childMarkdownRemark.html,+                }}+              />+              <div className={styles.meta}>+                <small className="meta">{node.publishDate}</small>+                <Tags tags={node.tags} />+              </div>+            </Link>+          </li>+        )+      })}+    </ul>+  </Container>

Guarding against "no posts" now since d36c5be/dc0f2e5.

fk

comment created time in a day

PullRequestReviewEvent

push eventfk/starter-gatsby-blog

Florian Kissling

commit sha dc0f2e512cf8171051ef70c9f0f18a6f5006bcad

D'oh

view details

push time in a day

push eventfk/starter-gatsby-blog

Florian Kissling

commit sha d36c5be40b16fdf607d21d83975c5c101e3933ef

Guard against posts being falsy

view details

push time in a day

push eventfk/starter-gatsby-blog

Florian Kissling

commit sha d484d0d683f03546e3f9075829e91d3b1262351e

Add comment, add `Thumbs.db`

view details

Florian Kissling

commit sha 9f79588aff40d1bbadeca263f21dc56c69b92309

gitignore: really ignore .env variables

view details

Florian Kissling

commit sha 6a5894d1dbc27a32ec1729ffe56b866b3491776c

Comment casing OCD

view details

push time in 2 days

Pull request review commentcontentful/starter-gatsby-blog

Update to Gatsby v3, new `gatsby-plugin-image`; design rinse

 img {  h1, h2,-h3 {-  font-size: 2em;-  font-weight: normal;+h3,+h4,+h5,+h6 {+  font-weight: var(--semibold);+  line-height: var(--dense); }  a {   color: currentColor;+  text-decoration: none; } -.wrapper {-  width: calc(100% - 10vmin);-  margin: 0 auto;-  padding: 5vmin 0;+a:hover {+  color: var(--primary); } -/**- * article grid- */-.article-list {-  margin: 0;-  padding: 0;-  list-style: none;-  display: grid;-  grid-template-columns: repeat(auto-fit, minmax(200px, 1fr));-  grid-gap: 5vmin;+a.active {+  font-weight: var(--bold); } -/**- *- */-.section-headline {-  padding: 0 0 0.4em 0;-  margin: 0 0 5vmin 0;-  border-bottom: 1px solid #ddd;+tt,+code,+kbd {+  background: var(--black-fade-5);+  padding-bottom: 0.2em;+  padding-top: 0.2em; } -/**- *- */-.list-inline {-  margin: 0;-  padding: 0;-  list-style: none;+tt,+code,+kbd {+  font-family: var(--font-monospace);+  font-size: 90%;+}++tt,+code {+  background-color: var(--black-fade-5);+  border-radius: var(--radius-sm);+  font-weight: var(--medium);+  padding: 0.2em 0; } -  .list-inline li {-    display: inline-block;-  }+code:before,+code:after,+tt:before,+tt:after {+  content: ' ';+  letter-spacing: -0.2em;+}++pre,+code {+  font-family: var(--font-monospace);+}

Done in 65f5a25.

fk

comment created time in 2 days

PullRequestReviewEvent

push eventfk/starter-gatsby-blog

Florian Kissling

commit sha 65f5a2568ff3fd822291cc5321c71018ccbf23a1

mv base.css -> global.css

view details

push time in 2 days

Pull request review commentcontentful/starter-gatsby-blog

Update to Gatsby v3, new `gatsby-plugin-image`; design rinse

 import React from 'react'-import { graphql } from 'gatsby'-import { Helmet } from 'react-helmet'+import { Link, graphql } from 'gatsby' import get from 'lodash/get'-import Img from 'gatsby-image'-import Layout from '../components/layout' -import heroStyles from '../components/hero.module.css'+import Seo from '../components/seo'+import Layout from '../components/layout'+import Hero from '../components/hero'+import Tags from '../components/tags'+import * as styles from './blog-post.module.css'  class BlogPostTemplate extends React.Component {   render() {     const post = get(this.props, 'data.contentfulBlogPost')-    const siteTitle = get(this.props, 'data.site.siteMetadata.title')+    const previous = get(this.props, 'data.previous')+    const next = get(this.props, 'data.next')      return (       <Layout location={this.props.location}>-        <div style={{ background: '#fff' }}>-          <Helmet title={`${post.title} | ${siteTitle}`} />-          <div className={heroStyles.hero}>-            <Img-              className={heroStyles.heroImage}-              alt={post.title}-              fluid={post.heroImage.fluid}-            />-          </div>-          <div className="wrapper">-            <h1 className="section-headline">{post.title}</h1>-            <p-              style={{-                display: 'block',-              }}-            >-              {post.publishDate}-            </p>+        <Seo+          title={post.title}+          description={post.description.childMarkdownRemark.excerpt}+          image={`http:${post.heroImage.resize.src}`}+        />+        <Hero+          image={post.heroImage.gatsbyImageData}+          title={post.title}+          content={post.description.childMarkdownRemark.excerpt}+        />+        <div className={styles.container}>+          <span className={styles.meta}>+            {post.author.name} &middot;{' '}+            <time dateTime={post.rawDate}>{post.publishDate}</time> –{' '}+            {post.body.childMarkdownRemark.timeToRead} minute read+          </span>+          <div className={styles.article}>             <div+              className={styles.body}               dangerouslySetInnerHTML={{                 __html: post.body.childMarkdownRemark.html,               }}             />+            <Tags tags={post.tags} />+            {(previous || next) && (+              <nav>+                <ul className={styles.articleNavigation}>+                  <li>+                    {previous && (

Fixed in bc2f69b.

fk

comment created time in 2 days

PullRequestReviewEvent

push eventfk/starter-gatsby-blog

Florian Kissling

commit sha bc2f69b8cd7393ec9aac567c2479e296c0fc8145

Don't render `previous/next <li>` if empty

view details

push time in 2 days

pull request commentcontentful/starter-gatsby-blog

Update to Gatsby v3, new `gatsby-plugin-image`; design rinse

Thanks for the review, @davidfateh! I'll address your comments (and a couple things in the same ballpark) in the next couple hours.

fk

comment created time in 2 days

Pull request review commentcontentful/starter-gatsby-blog

Update to Gatsby v3, new `gatsby-plugin-image`; design rinse

 import React from 'react'-import { graphql } from 'gatsby'-import { Helmet } from 'react-helmet'+import { Link, graphql } from 'gatsby' import get from 'lodash/get'-import Img from 'gatsby-image'-import Layout from '../components/layout' -import heroStyles from '../components/hero.module.css'+import Seo from '../components/seo'+import Layout from '../components/layout'+import Hero from '../components/hero'+import Tags from '../components/tags'+import * as styles from './blog-post.module.css'  class BlogPostTemplate extends React.Component {   render() {     const post = get(this.props, 'data.contentfulBlogPost')-    const siteTitle = get(this.props, 'data.site.siteMetadata.title')+    const previous = get(this.props, 'data.previous')+    const next = get(this.props, 'data.next')      return (       <Layout location={this.props.location}>-        <div style={{ background: '#fff' }}>-          <Helmet title={`${post.title} | ${siteTitle}`} />-          <div className={heroStyles.hero}>-            <Img-              className={heroStyles.heroImage}-              alt={post.title}-              fluid={post.heroImage.fluid}-            />-          </div>-          <div className="wrapper">-            <h1 className="section-headline">{post.title}</h1>-            <p-              style={{-                display: 'block',-              }}-            >-              {post.publishDate}-            </p>+        <Seo+          title={post.title}+          description={post.description.childMarkdownRemark.excerpt}+          image={`http:${post.heroImage.resize.src}`}+        />+        <Hero+          image={post.heroImage.gatsbyImageData}+          title={post.title}+          content={post.description.childMarkdownRemark.excerpt}+        />+        <div className={styles.container}>+          <span className={styles.meta}>+            {post.author.name} &middot;{' '}+            <time dateTime={post.rawDate}>{post.publishDate}</time> –{' '}+            {post.body.childMarkdownRemark.timeToRead} minute read+          </span>+          <div className={styles.article}>             <div+              className={styles.body}               dangerouslySetInnerHTML={{                 __html: post.body.childMarkdownRemark.html,               }}             />+            <Tags tags={post.tags} />+            {(previous || next) && (+              <nav>+                <ul className={styles.articleNavigation}>+                  <li>+                    {previous && (

:+1: Agreed that we should catch this (and that), will adjust. :v:

fk

comment created time in 2 days

PullRequestReviewEvent

startedgucong3000/postcss-jsx

started time in 2 days

issue commentgatsbyjs/gatsby

gatsby-plugin-image images are flickering/blinking

👋 I can confirm what @steverandy and @DanielHirunrusme are reporting – not seeing the flickering on v1.1.0 – behavior seems to have been introduced somewhere in between the latter and v1.2.0.

chrisworman-pela

comment created time in 4 days

startedgooglefonts/atkinson-hyperlegible

started time in 4 days

push eventgatsbyjs/store.gatsbyjs.org

Florian Kissling

commit sha 4008a66ad6b24d09bb5ccb74e2348593d38f6723

More NL OCD

view details

push time in 4 days

push eventgatsbyjs/store.gatsbyjs.org

Florian Kissling

commit sha edf95e560b88d02bde5135817531a06ec13b3f0f

Add `borders.grid` and start using it

view details

push time in 4 days

push eventgatsbyjs/store.gatsbyjs.org

Florian Kissling

commit sha ce20a0b9365cb34443bd3ceea5b07bc33a6ae9c1

Bump gatsby, gatsby-plugin-image

view details

Florian Kissling

commit sha 778c1130df28857f779cd3fd7afd7c121b7f2379

Add `fonts.serif`

view details

Florian Kissling

commit sha 6dfa5ec5832e61f261014b39d313fcb1d22d73c2

Use Inter, finally

view details

Florian Kissling

commit sha 3986401dbbd252597da31148e10b4017b7fba37d

Grab from `fontSizes`

view details

Florian Kissling

commit sha 38ef4be656f6966b52c758e5cea535109b22f435

Remove `brand` color from `SizeChartTable` `th`

view details

Florian Kissling

commit sha 9fc9912a8e9e7dfde6375bc63869b43471f9ede9

Calmer "Back to all products" link

view details

Florian Kissling

commit sha 2ccf2c558c30ca207bf6a7bcc0bbdeae54f11ca5

NL OCD

view details

push time in 4 days

push eventgatsbyjs/store.gatsbyjs.org

Florian Kissling

commit sha 2a12c455eeda49c4b6e566319c5b8999a7ea139e

Add `fontWeights` to `styles`, begin using them

view details

push time in 4 days

push eventgatsbyjs/store.gatsbyjs.org

Florian Kissling

commit sha 7759fd5805c7ac3b8ec2bb58119679c53e19879d

Bump emotion, rm stray last `gatsby-image` import

view details

Florian Kissling

commit sha 5f546bb5fd5526919e84f6672e8cc42f80e063b8

Remove seemingly obsolete `apiKey` option … `gatsby-source-shopify` says it doesn't know it.

view details

push time in 4 days