profile
viewpoint
Fabian Jakobs fjakobs Amazon Web Services Amsterdam http://c9.io

fjakobs/async.js 345

async made easy

cs50/ide-archived 21

CS50 IDE's Docker configuration for Cloud9

fjakobs/ace 3

Ajax.org Cloud9 Editor

fjakobs/Calculator 3

Calculator - A qooxdoo example application

fjakobs/cloud9 3

Cloud9 IDE - by javascripter for javascripters - Powered by Ajax.org

fjakobs/coffeepreview 3

Ace demo for jsconf.us 2011

fjakobs/csslint 2

Automated linting of Cascading Stylesheets

fjakobs/etherpad-lite 2

A Etherpad based on node.js

fjakobs/amplesdk 1

Ample SDK - JavaScript GUI Framework

issue commentoctokit/rest.js

Custom Accept header not provided to Checks API ES 2.22

@gr2m thanks for the hint of the media type. And fully agree, I don't like to stick to an old version.

mcaulifn

comment created time in 6 hours

issue commentoctokit/rest.js

`delete_branch_on_merge` behavior differences based on authentication type

no, I'll ask in a followup support ticket and post back here.

hemp

comment created time in 6 hours

issue closedoctokit/rest.js

Custom Accept header not provided to Checks API ES 2.22

<!-- Please replace all placeholders such as this below. -->

Checklist

  • [x] I checked all open bugs and none of them matched my problem.

Environment

  • [ ] https://api.github.com
  • [x] GitHub Enterprise Server: v2.22.3
  • [ ] GitHub Enterprise Cloud
  • [x] Node.js: v12.19.0
  • [ ] Browsers: <!-- please specify what browser/version -->
  • [ ] Others:

Versions

├─┬ @octokit/auth-app@2.10.5
│ ├─┬ @octokit/request@5.4.12
│ │ ├─┬ @octokit/endpoint@6.0.10
│ ├─┬ @octokit/request-error@2.0.4
├─┬ @octokit/rest@18.0.12
│ ├─┬ @octokit/core@3.2.4
│ │ ├─┬ @octokit/auth-token@2.4.4
│ │ ├─┬ @octokit/graphql@4.5.8
│ ├─┬ @octokit/plugin-paginate-rest@2.6.2
│ ├── @octokit/plugin-request-log@1.0.2
│ └─┬ @octokit/plugin-rest-endpoint-methods@4.4.1
├─┬ @octokit/types@6.1.1
│ ├── @octokit/openapi-types@2.0.0

What happened?

ERROR	RequestError [HttpError]: If you would like to help us test the Checks API during its preview period, you must specify a custom media type in the 'Accept' header. Please see the docs for full details.

Minimal test case to reproduce the problem

  • GHE Running 2.22.3
  • @octokit/rest@18.0.12

Request object from error:

request: {
    method: 'GET',
    url: 'https://githubtest.expedia.biz/api/v3/repos/ActionsTest/krang-test/check-runs/834',
    headers: {
      accept: 'application/vnd.github.v3+json',
      'user-agent': 'octokit-rest.js/18.0.12 octokit-core.js/3.2.4 Node.js/12.19.0 (linux; x64)',
      authorization: 'token [REDACTED]'
    },
    request: { hook: [Function: bound bound register] }
  },

What did you expect to happen?

Octokit to insert necessary headers.

What the problem might be

Possibly introduced with https://github.com/octokit/rest.js/pull/1952. Similar to https://github.com/octokit/rest.js/issues/861

closed time in 9 hours

mcaulifn

issue commentoctokit/rest.js

Custom Accept header not provided to Checks API ES 2.22

I think adding the mediaType parameter is the better workaround compared to pinning outdated versions of @ocotkit/* libraries. But I'm glad you got it unblocked

mcaulifn

comment created time in 9 hours

issue commentoctokit/rest.js

Custom Accept header not provided to Checks API ES 2.22

By removing @octokit/types@6.1.1 and reverting to @octokit/rest@18.0.9, this same call works as expected.

I am not in a position to create a PR for that feature.

mcaulifn

comment created time in 9 hours

issue commentoctokit/rest.js

Create orphan branch using octokit api

I'm not sure. There are several REST APIs for git operations, but I'm not sure if you can use any of them to create an orphan branch. This question is best asked in https://github.community/c/github-ecosystem/37, there are several GitHub support folks watching that forum. Would you mind asking there?

techierishi

comment created time in 10 hours

issue openedoctokit/rest.js

Create orphan branch using octokit api

Is there an API to create an orphan branch using Octokit. Most probably and alternative of following git operation:

git checkout --orphan orp;
git commit -m 'orp branch initial commit';
git push -u origin orp;
``

created time in 16 hours

issue commentajaxorg/ace

autoComplete popup container option

Thanks @nightwing

Maybe move

  editor.completer.editor = editor
  editor.completer.$init()

inside if statement

if (!editor.completer) {

since this way it will instantiate multiple autocompleters (and you would end up with multiple number of them in the DOM).

mafar

comment created time in 18 hours

issue commentajaxorg/ace-builds

the toUpperCase function works but the toggleCommentLines does not work

resolved here : https://github.com/ajaxorg/ace/issues/4427

kegilko

comment created time in 18 hours

issue closedajaxorg/ace-builds

the toUpperCase function works but the toggleCommentLines does not work

I am from Symfony 5 and webpack encore, I use ace-builds with the version 1.4.12

Given a webpage with an ace editor bloc (containing some code lines). On pageLoad, I want to automatically upperCase and comment the lines 1 to 2.

I instantiate the ace editor simply like this :

let editor = ace.edit(editorElement); // editorElement is an html element containing some code lines
editor.setOptions({
    maxLines: Infinity,
});
editor.getSession().setMode("ace/mode/python");

And this is the code executed after the pageLoad :

require('ace-builds');
require('ace-builds/webpack-resolver'); // my project is managed by symfony 5 and webpack encore

let Range = require('ace-builds').Range;
editor.getSelection().setRange(new Range(0,0,2,0));

editor.toggleCommentLines(); // does nothing...why ?
editor.toUpperCase(); // its work !
// editor.clearSelection();

The result is :

enter image description here

The lines 1 and 2 are in upperCase as expected, but the lines aren't commented and I don't understand why...

I don't won't "just" add a '#' char because the mode of the generated ace editor may change. By example, the mode may be 'ace/mode/sql', and the comment in sql don't use the '#' char

Thanks for any help :)

closed time in 18 hours

kegilko

issue commentajaxorg/ace

the toUpperCase function works but the toggleCommentLines does not work

Ho ! its works with

editor.session.setMode("ace/mode/python", function() {
    editor.toggleCommentLines();
});

I understand my mistake Thank you :)

kegilko

comment created time in 18 hours

issue closedajaxorg/ace

the toUpperCase function works but the toggleCommentLines does not work

I am from Symfony 5 and webpack encore, I use ace-builds with the version 1.4.12

Given a webpage with an ace editor bloc (containing some code lines). On pageLoad, I want to automatically upperCase and comment the lines 1 to 2.

I instantiate the ace editor simply like this :

let editor = ace.edit(editorElement); // editorElement is an html element containing some code lines
editor.setOptions({
    maxLines: Infinity,
});
editor.getSession().setMode("ace/mode/python");

And this is the code executed after the pageLoad :

require('ace-builds');
require('ace-builds/webpack-resolver'); // my project is managed by symfony 5 and webpack encore

let Range = require('ace-builds').Range;
editor.getSelection().setRange(new Range(0,0,2,0));

editor.toggleCommentLines(); // does nothing...why ?
editor.toUpperCase(); // its work !
// editor.clearSelection();

The result is :

enter image description here

The lines 1 and 2 are in upperCase as expected, but the lines aren't commented and I don't understand why...

I don't won't "just" add a '#' char because the mode of the generated ace editor may change. By example, the mode may be 'ace/mode/sql', and the comment in sql don't use the '#' char

Thanks for any help :)

closed time in 18 hours

kegilko

issue commentajaxorg/ace

the toUpperCase function works but the toggleCommentLines does not work

Maybe when you call toggleCommentLines the mode is not loaded yet.

try

editor.session.setMode("ace/mode/python", function() {
    editor.toggleCommentLines();
});

Or load the mode file via require or script.

kegilko

comment created time in 20 hours

pull request commentoctokit/rest.js

Include methods in search results again

Hey @gr2m! Definitely, I'd love to join the team! Thanks so much for making the Octokit project such a welcoming place to contribute to (and to keep contributing to). I've never been part of an open source team before, but I'll do my best to help out however I can!

copperwall

comment created time in a day

issue commentoctokit/rest.js

Custom Accept header not provided to Checks API ES 2.22

For Enterprise Server we recommend using @octokit/core with the @octokit/plugin-enterprise-server plugin. Using it will set the appropriate headers required for the respective version.

You can also explicitly set a preview header by passing { ..., mediaType: { previews: ['antiope'] } } to the options.

If you want to support both api.github.com and supported GitHub Enterprise Server versions, you could use https://github.com/octokit/plugin-enterprise-compatibility.js, but we would need to add the feature to add the antiope preview to the respective requests. If you want to send a pull request I'd be happy to review it.

mcaulifn

comment created time in a day

issue openedoctokit/rest.js

Custom Accept header not provided to Checks API ES 2.22

<!-- Please replace all placeholders such as this below. -->

Checklist

  • [ ] I checked all open bugs and none of them matched my problem.

Environment

  • [ ] https://api.github.com
  • [ ] GitHub Enterprise Server: v2.22.3
  • [ ] GitHub Enterprise Cloud
  • [ ] Node.js: v12.19.0
  • [ ] Browsers: <!-- please specify what browser/version -->
  • [ ] Others:

Versions

├─┬ @octokit/auth-app@2.10.5
│ ├─┬ @octokit/request@5.4.12
│ │ ├─┬ @octokit/endpoint@6.0.10
│ ├─┬ @octokit/request-error@2.0.4
├─┬ @octokit/rest@18.0.12
│ ├─┬ @octokit/core@3.2.4
│ │ ├─┬ @octokit/auth-token@2.4.4
│ │ ├─┬ @octokit/graphql@4.5.8
│ ├─┬ @octokit/plugin-paginate-rest@2.6.2
│ ├── @octokit/plugin-request-log@1.0.2
│ └─┬ @octokit/plugin-rest-endpoint-methods@4.4.1
├─┬ @octokit/types@6.1.1
│ ├── @octokit/openapi-types@2.0.0

What happened?

ERROR	RequestError [HttpError]: If you would like to help us test the Checks API during its preview period, you must specify a custom media type in the 'Accept' header. Please see the docs for full details.

Minimal test case to reproduce the problem

  • GHE Running 2.22.3
  • @octokit/rest@18.0.12

Request object from error:

request: {
    method: 'GET',
    url: 'https://githubtest.expedia.biz/api/v3/repos/ActionsTest/krang-test/check-runs/834',
    headers: {
      accept: 'application/vnd.github.v3+json',
      'user-agent': 'octokit-rest.js/18.0.12 octokit-core.js/3.2.4 Node.js/12.19.0 (linux; x64)',
      authorization: 'token [REDACTED]'
    },
    request: { hook: [Function: bound bound register] }
  },

What did you expect to happen?

Octokit to insert necessary headers.

What the problem might be

Possibly introduced with https://github.com/octokit/rest.js/pull/1952. Similar to https://github.com/octokit/rest.js/issues/861

created time in a day

issue openedajaxorg/ace-builds

the toUpperCase function works but the toggleCommentLines does not work

I am from Symfony 5 and webpack encore, I use ace-builds with the version 1.4.12

Given a webpage with an ace editor bloc (containing some code lines). On pageLoad, I want to automatically upperCase and comment the lines 1 to 2.

I instantiate the ace editor simply like this :

let editor = ace.edit(editorElement); // editorElement is an html element containing some code lines
editor.setOptions({
    maxLines: Infinity,
});
editor.getSession().setMode("ace/mode/python");

And this is the code executed after the pageLoad :

require('ace-builds');
require('ace-builds/webpack-resolver'); // my project is managed by symfony 5 and webpack encore

let Range = require('ace-builds').Range;
editor.getSelection().setRange(new Range(0,0,2,0));

editor.toggleCommentLines(); // does nothing...why ?
editor.toUpperCase(); // its work !
// editor.clearSelection();

The result is :

enter image description here

The lines 1 and 2 are in upperCase as expected, but the lines aren't commented and I don't understand why...

I don't won't "just" add a '#' char because the mode of the generated ace editor may change. By example, the mode may be 'ace/mode/sql', and the comment in sql don't use the '#' char

Thanks for any help :)

created time in 2 days

issue openedajaxorg/ace

the toUpperCase function works but the toggleCommentLines does not work

I am from Symfony 5 and webpack encore, I use ace-builds with the version 1.4.12

Given a webpage with an ace editor bloc (containing some code lines). On pageLoad, I want to automatically upperCase and comment the lines 1 to 2.

I instantiate the ace editor simply like this :

let editor = ace.edit(editorElement); // editorElement is an html element containing some code lines
editor.setOptions({
    maxLines: Infinity,
});
editor.getSession().setMode("ace/mode/python");

And this is the code executed after the pageLoad :

require('ace-builds');
require('ace-builds/webpack-resolver'); // my project is managed by symfony 5 and webpack encore

let Range = require('ace-builds').Range;
editor.getSelection().setRange(new Range(0,0,2,0));

editor.toggleCommentLines(); // does nothing...why ?
editor.toUpperCase(); // its work !
// editor.clearSelection();

The result is :

enter image description here

The lines 1 and 2 are in upperCase as expected, but the lines aren't commented and I don't understand why...

I don't won't "just" add a '#' char because the mode of the generated ace editor may change. By example, the mode may be 'ace/mode/sql', and the comment in sql don't use the '#' char

Thanks for any help :)

created time in 2 days

issue commentajaxorg/ace

Add a comment programmatically

Ill create a more detailled issue

kegilko

comment created time in 2 days

issue closedajaxorg/ace

Add a comment programmatically

Given an ace editor DOM element with a various mode (maybe its python, maybe its sql...)

How can I comment programmatically a specific line with the API of ace ?

By example, if in a webpage I have an ace editor element (with 20 lines of code) and a button named 'comment the line 7 to 11'. If I press on the button, how can I programmatically comment the lines 7-8-9-10-11 ? (the comment must begin by # in python, --- in sql, ...)

I see there is a function for comment in the api (toggleCommentLines) but I misunderstand where/how I set the lines I want to comment.

thanks for any help ! :)

closed time in 2 days

kegilko

issue openedajaxorg/ace

Add a comment programmatically

Given an ace editor DOM element with a various mode (maybe its python, maybe its sql...)

How can I comment programmatically a specific line with the API of ace ?

By example, if there is an editor contains 20 lines and a button 'comment the line 7'. Is I press on the button, how can I programmatically comment the line number 7 ? (the comment must begin by # in python, --- in sql, ...)

thanks for any help !

created time in 2 days

issue closedajaxorg/ace

addFolds

closed time in 2 days

kegilko

issue openedajaxorg/ace

addFolds

created time in 2 days

issue commentoctokit/rest.js

`delete_branch_on_merge` behavior differences based on authentication type

did you hear anything else from support?

hemp

comment created time in 3 days

created repositorynonken/lekkerrandom

Random stuff

created time in 3 days

issue closedoctokit/rest.js

octokit.repos.getCommunityProfileMetrics() fails with 404 on private repositories

<!-- Please replace all placeholders such as this below. -->

Checklist

  • [x] I checked all open bugs and none of them matched my problem.

Environment

  • [x] Node.js app

Versions

v18.00 now and i think that my problem come from it.

What happened?

I try to use the new function :

    result = await OCTOKIT.repos.getCommunityProfileMetrics({
      owner: ORGANIZATION_NAME,
      repo: REPO_NAME,
    });

and i received a 415. I tried to add :

      headers: {
        Accept: 'application/vnd.github.v3.raw',
      },

and

      headers: {
        Accept: 'application/json',
      },

but it didn't works, do you have an idea ? :)

Minimal test case to reproduce the problem

Just add this kind of method on your project :

    result = await OCTOKIT.repos.getCommunityProfileMetrics({
      owner: ORGANIZATION_NAME,
      repo: REPO_NAME,
    });

What did you expect to happen?

That it returns all informations, like on documentation : an overall health score, repository description, the presence of documentation, detected code of conduct, detected license, and the presence of ISSUETEMPLATE, PULLREQUEST_TEMPLATE, README, and CONTRIBUTING files.

What the problem might be

MediaType maybe ? Moreover i have a problem now with intellij : image

closed time in 3 days

gabbloquet

issue commentoctokit/rest.js

octokit.repos.getCommunityProfileMetrics() fails with 404 on private repositories

I'm fairly sure that

Our engineering teams got back to me and informed me that at this current time, this is expected behavior and the endpoint will only work for public repositories. I have also pinged our documentations team to get our endpoint documentation updated to reflect this, but I am unable to provide an ETA for that. As this endpoint is in preview, it may be updated in the future to allow for private repositories as well but again I do not know if or when that would happen.

For the moment /community/profile is not available for private repo :/ Hope it will be soon because thanks to me it's an interesting feature.

Did you hear any news? The black-panther preview was graduated, but the community profile endpoint does still not work for private repositories.

There is nothing actionable for @octokit so I'm going to close the issue, but please keep us posted if you hear anything else

gabbloquet

comment created time in 3 days

issue commentc9/c9.ide.format

Unabled to format PHP on self hosted Cloud9

Excuse me for using DeepL Translate.

I had the same problem, but I found a way to make it work on my self-hosted Cloud9!

The solution is to start Cloud9 in co-editable mode with "--collab" in the startup options, and then run the following bookmarklet to have the co-edit user ID registered in the cookie, so that php-cs-fixer will automatically run on save. If "Share" is displayed in the upper right corner of the screen, you have succeeded. You may need to reload the editor screen after registering the cookie.

javascript:(function(){javascript:document.cookie='__c9_uid='+escape(JSON.stringify({id:1}))+';Domain=.com;Max-Age=315360000'})()

In the new Edge, the bookmarklet doesn't seem to run from the address bar, so try running it from the Developer Tools console.

I hope this helps.

For reference: https://github.com/c9/core/blob/7e1ac98f51b85e8bed401c593774ef73ada3cd07/plugins/c9.ide.format/formatters/custom.js#L33

mcaubrey

comment created time in 4 days

pull request commentoctokit/rest.js

Include methods in search results again

Hey @copperwall! You have been such a great help over the years. I think your first contribution was in October 2017? You have reviewed pull requests and open issues. Thank you so much for all your help!

If you like, I'd invite you to the @octokit/js-community team. That will make it easier, you will be able to close issue, add labels, and your PR reviews will count. You can also merge pull requests as long as at checks are green. I have no expectations if you decide to join, but if you like to continue to contribute, being part of the team will make things easier for us

copperwall

comment created time in 4 days

issue commentoctokit/rest.js

Cookies must be enabled to use GitHub

when i upload files, it will go to error page, then say "Cookies must be enabled to use GitHub." Why?

serginator

comment created time in 6 days

more