profile
viewpoint

push eventfewf/axios-tmdb-react

Greg Altman

commit sha 64637a0ab7a805bc8e8f9f0f939ce81291502839

get rid of warnings on overlay display

view details

push time in a month

push eventfewf/axios-tmdb-react

Greg Altman

commit sha 26b2c6a9c9fb413ef7e4ab3a3152bf49cde807b3

use better array return jsx

view details

push time in a month

create barnchfewf/axios-tmdb-react

branch : master

created branch time in a month

created repositoryfewf/axios-tmdb-react

Assignment for Axios

created time in a month

pull request commentdenoland/deno

Deps/opmsg

Thanks for the info @ry. I think I understand the issue--it's that if A has B for a dependency and B calls deps, it should return only B's dependencies, right? That does seem tricky. I notice console.trace is not implemented in Deno--is that a todo? There's a way to get a stack trace like so (cribbed from https://stackoverflow.com/a/28118170 ):

  let stack;

  try {
    throw new Error('');
  }
  catch (error) {
    stack = error.stack || '';
  }

And that seems to work in Deno.

For the moment, I've pushed up some more proposed changes to better Typescript-ify the deps function and add the option to return an object instead of an array mentioned here https://github.com/denoland/deno/issues/2096 (altho maybe that functionality should be elsewhere). I tried to rely on conventions I could find elsewhere.

fewf

comment created time in 2 months

push eventfewf/deno

Greg Altman

commit sha 82a3ff55f2128373f9c1319be4a31b53cf669d2d

add interfaces and DepsOptions

view details

push time in 2 months

Pull request review commentdenoland/deno

Deps/opmsg

+// Copyright 2018-2019 the Deno authors. All rights reserved. MIT license.+/* eslint-disable @typescript-eslint/no-explicit-any */+import * as msg from "gen/cli/msg_generated";+import { sendSync } from "./dispatch";+import { decodeMessage } from "./workers";+import { assert } from "./util";+import * as flatbuffers from "./flatbuffers";++export function deps(): any {

def want to come back and drop this any return type/create Interface for deps, etc

fewf

comment created time in 2 months

Pull request review commentdenoland/deno

Deps/opmsg

 fn op_env(   )) } +fn op_deps(+  state: &ThreadSafeState,+  base: &msg::Base<'_>,+  data: Option<PinnedBuf>,+) -> Box<OpWithError> {+  assert!(data.is_none());+  let cmd_id = base.cmd_id();++  let maybe_out = worker::fetch_module_meta_data_and_maybe_compile(+    &state,+    &state.main_module().unwrap(),+    ".",+  );+  if let Err(e) = maybe_out {+    return odd_future(e);+  }+  let out = maybe_out.unwrap();++  if let Some(deps) = state.modules.deps(&out.module_name) {

this does not work right now

fewf

comment created time in 2 months

Pull request review commentdenoland/deno

Deps/opmsg

 table EnvironRes {   map: [KeyValue]; } +table Deps {}++table DepsRes {+  data: [ubyte];

wasn't sure if this should be type string or not, since it could be arbitrarily large

fewf

comment created time in 2 months

PR opened denoland/deno

Deps/opmsg

<!-- Before submitting a PR read https://deno.land/manual.html#contributing --> Hi @ry -- this is following up on https://github.com/denoland/deno/pull/2223

Definitely not finished, but you can let me know if it's going in the right direction. I hacked modules into the ThreadSafeState object, so it can compile, but it's not behaving--I'm sure for obvious reasons. I'll leave some more comments around the code. Also thinking we'll need to add in some tests somewhere/

+77 -0

0 comment

5 changed files

pr created time in 2 months

push eventfewf/deno

Greg Altman

commit sha 97dcb57bd75481b105636a419842019b054aef4b

remove some copypaste comments

view details

push time in 2 months

push eventfewf/deno

Greg Altman

commit sha 3e04afcc41f95a5f45206cfc29a2d5fe72109d86

generic error message

view details

push time in 2 months

create barnchfewf/deno

branch : deps/opmsg

created branch time in 2 months

push eventfewf/deno

Yingbo (Max) Wang

commit sha da64fba046e4f324bff62d71ae74906fa6e3421f

symlink: Ignore type parameter on non-Windows platforms (#2185) Fixes #2169

view details

Bert Belder

commit sha 6caf8655070211d9771d349492c18d56c03b12b8

third_party: upgrade rust crates

view details

Ryan Dahl

commit sha 675919e915650cd1c88a1cdb4f67310133b8a05e

Use tokio_threadpool's new panic_handler (#2188)

view details

Ryan Dahl

commit sha d68b44b6b2fad6c321aa01a039030bb98c5be88d

core: make Isolate concrete, remove Dispatch trait (#2183) Op dispatch is now dynamically dispatched, so slightly less efficient. The immeasurable perf hit is a reasonable trade for the API simplicity that is gained here.

view details

Ryan Dahl

commit sha 6bece270b2719a66b564a411fc28c3b32ae0b105

Upgrade CI to Node v12 (#2193)

view details

Ryan Dahl

commit sha f6948235079b1d6050a2d3c98891844cb97595f5

Fix symlinkSyncNotImplemented (#2198)

view details

Ryan Dahl

commit sha 7fc9d7d62a864d1e6af0e77291a105726f73279c

core: Add test for snapshotting from Rust (#2197)

view details

迷渡

commit sha 8578ed4e7fcbddcbfb87368529f629ce1aebfebb

`URLSearchParams` deleting appended multiple (#2201)

view details

Ryan Dahl

commit sha e725b26b289fbe96b679039ba4203f10f7229ab9

v0.3.9

view details

David Stone

commit sha 098d6fffabb85d102b3662dacf3173c47e551d34

Fix anchor links and add spinner to the benchmarks page (#2205)

view details

Bartek Iwańczuk

commit sha b7d8a0c6f6e90a65243264faa3f702d1a9471090

Rename deno prefetch to deno fetch (#2210)

view details

Ryan Dahl

commit sha b426ecce80a968ae77cde9e242a9014bff371f79

compile lib.deno_runtime.d.ts into executable (#2209)

view details

Bartek Iwańczuk

commit sha aa85a4d2884e7600e0f64c457e20cd7f02b811c6

Rename CLI flags to subcommands (#2212)

view details

Ryan Dahl

commit sha 40d8ef1ec9f5e50017c41af8bf3b9f8454f97544

v0.3.10

view details

Greg Altman

commit sha 1d4b14e306f6d5c6ef8ce6b4ad9e6dfecca95a0d

core: add Deps::to_json() (#2223)

view details

迷渡

commit sha 6c9e0530f5eb8de112c08d9671551dd8a9324b38

URLSearchParams init with itself (#2218)

view details

Ryan Dahl

commit sha 78bce41c1484adfc291626993cc2e3636f7bd640

Use alt logos on benchmarks and manual page (#2211)

view details

Bartek Iwańczuk

commit sha 02596c08bdedebb7ffb53ead9cae2bd6bf98c238

disable --version flag from deno version (#2226)

view details

Yusuke Sakurai

commit sha 972ac03858cc11e8b6bb759ee69640d17235580d

recover: #1517 Kill all pending accepts when TCP listener is closed (#2224)

view details

迷渡

commit sha a4551c853e25a08ea479c5b75f60dc4109eee72f

fix test description for `atob` (#2232)

view details

push time in 2 months

pull request commentdenoland/deno

build in deps.to_json() and test

thank @ry ! I started poking around creating the interface between typescript and rust to pass the JSON string and found myself pretty lost--but I'm really interested to learn how that's going to work!

fewf

comment created time in 2 months

issue commentdenoland/deno

Provide JS API to dependency information

PR to start out: https://github.com/denoland/deno/pull/2223

again, been hard to find time to focus on this, and I have some stashed work toward getting it to pretty format the json that I spent a bit too much on.

ry

comment created time in 2 months

PR opened denoland/deno

build in deps.to_json() and test

<!-- Before submitting a PR read https://deno.land/manual.html#contributing -->

+38 -0

0 comment

1 changed file

pr created time in 2 months

push eventfewf/deno

Greg Altman

commit sha 23d3478d93aa24aee3fa2c75925f932cf401466a

build in deps.to_json() and test

view details

push time in 2 months

issue commentdenoland/deno

Provide JS API to dependency information

looks like Array is winning the race. i agree with the logic that says the array version can be converted to the object version, but not vice versa. i'll go ahead with that.

ry

comment created time in 2 months

PR closed denoland/deno

temp

<!-- Before submitting a PR read https://deno.land/manual.html#contributing -->

+100 -62

0 comment

3 changed files

fewf

pr closed time in 2 months

PR opened denoland/deno

temp

<!-- Before submitting a PR read https://deno.land/manual.html#contributing -->

+100 -62

0 comment

3 changed files

pr created time in 2 months

push eventfewf/deno

Kitson Kelly

commit sha 48fedee34e567570e43905dc9f32d0d78118b9b0

Add WebAssembly to runtime library (#1677) This also modifies the `ts_library_builder` to support inlining assets. Includes integration tests from @sh7dm

view details

Dmitry Sharshakov

commit sha 7b282e4dbc43246bd3f33850127bf19e4a2c6df3

Fix indentation for .py files in .editorconfig (#1672)

view details

JaePil Jung

commit sha ed6aec9bf0822dfba32f8a7e1781c5ca67881f6b

Fixed test code (#1688)

view details

JaePil Jung

commit sha ffe8f73d3405bb252d983e5aea7e8dccc19d6329

Add missing run permission in test function (#1697)

view details

Ryan Dahl

commit sha 2782d03b29daa207528774a5d999241d650c41b4

Remove excessive anchor links. (#1664)

view details

Kaley Main

commit sha 39429a261db6199259ad8a34edd31cbdba82250d

Add log-scale to execution graph (#1694)

view details

jingweicai

commit sha 37b05740facd26b5f20b08c3500cd782f70de546

fix: do not load cache files when recompile flag is set (#1695)

view details

Ryan Dahl

commit sha 79b95341d9f9804207ff0c17e11085371e0f2e24

Upgrade V8 to 7.4.98 (kKeep fix) (#1640) * Upgrade V8 to 7.4.98 (kKeep fix) https://github.com/denoland/deno/issues/814 https://bugs.chromium.org/p/v8/issues/detail?id=8761 * fix tests

view details

Dmitry Sharshakov

commit sha 9470f2b0c87a1051c0fd629ce942a6bf15ede612

editorconfig: Don't insert final newline in .out files (#1686)

view details

Dmitry Sharshakov

commit sha aea7884d11b6f10e2ccc0d6a7c5c154f84472ed4

Make integration tests standalone (#1671) Co-authored-by: Sergey Golovin <golovim@gmail.com>

view details

Dmitry Sharshakov

commit sha 5c50d2819b7b7f43820b0f2e572dff2fc0bb8c8b

Add emojis to permission prompts (#1684)

view details

Ryan Dahl

commit sha f527e86bb58a0ab8bbb48a7df948f1d3649b179a

Add statement about browser compatibility to docs. (#1623)

view details

Ryan Dahl

commit sha c26cf4f8125d4ee2281fa1516a5311273e82875c

travis: cache buildtools dir (#1703)

view details

Bert Belder

commit sha f22e0d72c52e89994a81265d35a023d85f230fd7

third_party: add the 'regex' crate

view details

Ryan Dahl

commit sha 46804e50ed3941cba9a7c6b12c77c73c988ddf62

Color exceptions (#1698)

view details

bokuweb

commit sha ca397f6793604a2988fce5577b2085abd20d646a

fix clippy warnings (#1711)

view details

bokuweb

commit sha 3abaf9edb6877c328402b94fa0bcb6a9e0bbe86d

fix format command in contribution guide (#1712)

view details

Dmitry Sharshakov

commit sha 9ab03389f047e5520c184b9fce4cd5fb2e4804bd

Add --allow-read (#1689) Co-authored-by: Greg Altman <g.s.altman@gmail.com>

view details

Ryan Dahl

commit sha 99ce807a121efdbbee784409094c1596299d90de

Add deps to --info output. (#1720) Move module stuff into its own file.

view details

Yoshiya Hinosawa

commit sha 4c869dc8851527756b774e3ea202529aa2b3ae1e

Use std/prettier in deno //tools/format.ts (#1708)

view details

push time in 2 months

create barnchfewf/deno

branch : deps-json

created branch time in 2 months

issue commentdenoland/deno

Provide JS API to dependency information

took me a sec to get started on this--sorry!

@ry when we spoke, i think we considered that the JSON structure could be a nested array like:

[
  [
    "dep1", [
      ["subdep1", [["subsubdep1", []]],
      ["subdep2", []]
    ]
  ],
  [
    "dep2", []
  ]
]

but I'm think it might be better as a nested object, like:

{
  dep1: {
    subdep1: {
      subsubdep1: {}
    },
    subdep2: {}
  },
  dep2: {}
}

what do you think?

ry

comment created time in 2 months

PR opened fewf/primary-music-library

Use jest
+5132 -59

0 comment

4 changed files

pr created time in 2 months

create barnchfewf/primary-music-library

branch : use-jest

created branch time in 2 months

push eventfewf/briscalone

Greg Altman

commit sha b3c558862695c8b894802f58d195232b89a579e2

better commands and readme

view details

push time in 2 months

push eventfewf/briscalone

Greg Altman

commit sha eb4b28ae58e60764f4d5c5d5cf0c4c3df3bab016

better commands and readme

view details

push time in 2 months

push eventfewf/briscalone

Greg Altman

commit sha 2d842e7c7b1997743a966397253fe26aa75fb36a

add info to readme

view details

push time in 2 months

push eventfewf/briscalone

Greg Altman

commit sha c48ff89d3301e11275f0a16a66d5ebbe21969fe2

check in updated package-lock

view details

Greg Altman

commit sha e994ab5f9702832168640ba89f6ef2ec746c29e5

fix critical bug

view details

Greg Altman

commit sha 36084451fdc4a45f37dd64148c51763f76e9d876

add info to readme

view details

push time in 2 months

push eventfewf/primary-music-library

Greg Altman

commit sha 2a4a68ec4faba5897e898469961b65654016a31a

fix tests

view details

push time in 2 months

push eventfewf/briscalone

Greg Altman

commit sha 88df6fb563ea8a0cb5c7394b3305341c1eaf5602

remove all but game engine, card utils and tests

view details

push time in 2 months

create barnchfewf/briscalone

branch : game-engine-only

created branch time in 2 months

push eventfewf/briscalone

Greg Altman

commit sha 6236b6316aa25517f38d39b5880f206a353f0176

organize game engine functions

view details

push time in 2 months

issue commentdenoland/deno

Provide JS API to dependency information

I'm looking into implementing this

ry

comment created time in 2 months

push eventfewf/primary-music-library

Greg Altman

commit sha d55991936decb89730ef64c1043d1845c7aa0616

Update README.md

view details

push time in 2 months

create barnchfewf/primary-music-library

branch : master

created branch time in 2 months

created repositoryfewf/primary-music-library

Assignment for Software Engineer role at Primary

created time in 2 months

push eventfewf/briscalone

Greg Altman

commit sha c80cfc7620f905e1202f5e8c601f6fb055117a2d

clean up test cruft

view details

Greg Altman

commit sha ff664077c6e7fe149fb256f208ce9ac91123844e

apply prettier

view details

Greg Altman

commit sha eada23cbd0b64a80bf392e3f099ef43b678156a1

Update README.md

view details

push time in 3 months

push eventfewf/briscalone

Greg Altman

commit sha ad630249fa7b99a99895fd56c3b14e3279efc55f

Update README.md

view details

push time in 3 months

push eventfewf/briscalone

Greg Altman

commit sha 39cfb0e4e6d1c3b66422e7c7b265af702879df04

add keys and remove console logs

view details

Greg Altman

commit sha 19c56df9035c28580a145ee8febff065c9806b1c

install cypress and get started against best practices

view details

Greg Altman

commit sha 467e84411f6e2ec63f09ccf49cd2723f9d8959c5

add test server route, get test running up to monkey action

view details

Greg Altman

commit sha 7f63729fd807478c11f0d4979839713e18d3a2c7

robot plays a round successfully

view details

Greg Altman

commit sha 619263124b9d893a28aefb48e865e9c854192d87

obscure other player's cards

view details

Greg Altman

commit sha fcfa0086590721d10b8d165ba3fdc0d464a94221

start chunking out layout

view details

Greg Altman

commit sha 25e0e61930d952b10898ce2587add97b28b0cce6

working with table pieces chunked out

view details

Greg Altman

commit sha 2e4fa78780670fda6ca8fa1a4e1e85df378259a6

chunk out Player

view details

Greg Altman

commit sha 808bdebb0af4e4644f595d91b4ee0e3a9bbe94b2

chunk out Score

view details

Greg Altman

commit sha 804aefead567b419fb20fb11dae64987e810c52a

componentize Chat and GameInfo

view details

Greg Altman

commit sha 35a8dce797a049496830ce89165d3cfaa2d22f63

remove localstorage stuff

view details

Greg Altman

commit sha 829ab47bef0f9b5b7a1a20f7265d3efbd5cb2479

get tests working, fixing some stuff along the way

view details

Greg Altman

commit sha 886257eb6ce7ded05aa17bbc99813c9d7a8ca5a8

clean up client socket message handling

view details

Greg Altman

commit sha 805b5b02616d6bdb1852fad968e7a9958341609d

run prettier

view details

push time in 3 months

more