PR closed denoland/deno

temp

<!-- Before submitting a PR read https://deno.land/manual.html#contributing -->

+100 -62

0 comment

3 changed files

fewf

pr closed time in 8 hours

PR opened denoland/deno

temp

<!-- Before submitting a PR read https://deno.land/manual.html#contributing -->

+100 -62

0 comment

3 changed files

pr created time in 8 hours

push eventfewf/deno

Kitson Kelly

commit sha 48fedee34e567570e43905dc9f32d0d78118b9b0

Add WebAssembly to runtime library (#1677) This also modifies the `ts_library_builder` to support inlining assets. Includes integration tests from @sh7dm

view details

Dmitry Sharshakov

commit sha 7b282e4dbc43246bd3f33850127bf19e4a2c6df3

Fix indentation for .py files in .editorconfig (#1672)

view details

JaePil Jung

commit sha ed6aec9bf0822dfba32f8a7e1781c5ca67881f6b

Fixed test code (#1688)

view details

JaePil Jung

commit sha ffe8f73d3405bb252d983e5aea7e8dccc19d6329

Add missing run permission in test function (#1697)

view details

Ryan Dahl

commit sha 2782d03b29daa207528774a5d999241d650c41b4

Remove excessive anchor links. (#1664)

view details

Kaley Main

commit sha 39429a261db6199259ad8a34edd31cbdba82250d

Add log-scale to execution graph (#1694)

view details

jingweicai

commit sha 37b05740facd26b5f20b08c3500cd782f70de546

fix: do not load cache files when recompile flag is set (#1695)

view details

Ryan Dahl

commit sha 79b95341d9f9804207ff0c17e11085371e0f2e24

Upgrade V8 to 7.4.98 (kKeep fix) (#1640) * Upgrade V8 to 7.4.98 (kKeep fix) https://github.com/denoland/deno/issues/814 https://bugs.chromium.org/p/v8/issues/detail?id=8761 * fix tests

view details

Dmitry Sharshakov

commit sha 9470f2b0c87a1051c0fd629ce942a6bf15ede612

editorconfig: Don't insert final newline in .out files (#1686)

view details

Dmitry Sharshakov

commit sha aea7884d11b6f10e2ccc0d6a7c5c154f84472ed4

Make integration tests standalone (#1671) Co-authored-by: Sergey Golovin <golovim@gmail.com>

view details

Dmitry Sharshakov

commit sha 5c50d2819b7b7f43820b0f2e572dff2fc0bb8c8b

Add emojis to permission prompts (#1684)

view details

Ryan Dahl

commit sha f527e86bb58a0ab8bbb48a7df948f1d3649b179a

Add statement about browser compatibility to docs. (#1623)

view details

Ryan Dahl

commit sha c26cf4f8125d4ee2281fa1516a5311273e82875c

travis: cache buildtools dir (#1703)

view details

Bert Belder

commit sha f22e0d72c52e89994a81265d35a023d85f230fd7

third_party: add the 'regex' crate

view details

Ryan Dahl

commit sha 46804e50ed3941cba9a7c6b12c77c73c988ddf62

Color exceptions (#1698)

view details

bokuweb

commit sha ca397f6793604a2988fce5577b2085abd20d646a

fix clippy warnings (#1711)

view details

bokuweb

commit sha 3abaf9edb6877c328402b94fa0bcb6a9e0bbe86d

fix format command in contribution guide (#1712)

view details

Dmitry Sharshakov

commit sha 9ab03389f047e5520c184b9fce4cd5fb2e4804bd

Add --allow-read (#1689) Co-authored-by: Greg Altman <g.s.altman@gmail.com>

view details

Ryan Dahl

commit sha 99ce807a121efdbbee784409094c1596299d90de

Add deps to --info output. (#1720) Move module stuff into its own file.

view details

Yoshiya Hinosawa

commit sha 4c869dc8851527756b774e3ea202529aa2b3ae1e

Use std/prettier in deno //tools/format.ts (#1708)

view details

push time in 8 hours

create barnchfewf/deno

branch : deps-json

created branch time in 8 hours

issue commentdenoland/deno

Provide JS API to dependency information

took me a sec to get started on this--sorry!

@ry when we spoke, i think we considered that the JSON structure could be a nested array like:

[
  [
    "dep1", [
      ["subdep1", [["subsubdep1", []]],
      ["subdep2", []]
    ]
  ],
  [
    "dep2", []
  ]
]

but I'm think it might be better as a nested object, like:

{
  dep1: {
    subdep1: {
      subsubdep1: {}
    },
    subdep2: {}
  },
  dep2: {}
}

what do you think?

ry

comment created time in 10 hours

PR opened fewf/primary-music-library

Use jest
+5132 -59

0 comment

4 changed files

pr created time in a day

create barnchfewf/primary-music-library

branch : use-jest

created branch time in a day

push eventfewf/briscalone

Greg Altman

commit sha b3c558862695c8b894802f58d195232b89a579e2

better commands and readme

view details

push time in a day

push eventfewf/briscalone

Greg Altman

commit sha eb4b28ae58e60764f4d5c5d5cf0c4c3df3bab016

better commands and readme

view details

push time in a day

push eventfewf/briscalone

Greg Altman

commit sha 2d842e7c7b1997743a966397253fe26aa75fb36a

add info to readme

view details

push time in a day

push eventfewf/briscalone

Greg Altman

commit sha c48ff89d3301e11275f0a16a66d5ebbe21969fe2

check in updated package-lock

view details

Greg Altman

commit sha e994ab5f9702832168640ba89f6ef2ec746c29e5

fix critical bug

view details

Greg Altman

commit sha 36084451fdc4a45f37dd64148c51763f76e9d876

add info to readme

view details

push time in a day

push eventfewf/primary-music-library

Greg Altman

commit sha 2a4a68ec4faba5897e898469961b65654016a31a

fix tests

view details

push time in a day

push eventfewf/briscalone

Greg Altman

commit sha 88df6fb563ea8a0cb5c7394b3305341c1eaf5602

remove all but game engine, card utils and tests

view details

push time in 6 days

create barnchfewf/briscalone

branch : game-engine-only

created branch time in 6 days

push eventfewf/briscalone

Greg Altman

commit sha 6236b6316aa25517f38d39b5880f206a353f0176

organize game engine functions

view details

push time in 6 days

issue commentdenoland/deno

Provide JS API to dependency information

I'm looking into implementing this

ry

comment created time in 9 days

push eventfewf/primary-music-library

Greg Altman

commit sha d55991936decb89730ef64c1043d1845c7aa0616

Update README.md

view details

push time in 9 days

create barnchfewf/primary-music-library

branch : master

created branch time in 9 days

created repositoryfewf/primary-music-library

Assignment for Software Engineer role at Primary

created time in 9 days

push eventfewf/briscalone

Greg Altman

commit sha c80cfc7620f905e1202f5e8c601f6fb055117a2d

clean up test cruft

view details

Greg Altman

commit sha ff664077c6e7fe149fb256f208ce9ac91123844e

apply prettier

view details

Greg Altman

commit sha eada23cbd0b64a80bf392e3f099ef43b678156a1

Update README.md

view details

push time in 20 days

push eventfewf/briscalone

Greg Altman

commit sha ad630249fa7b99a99895fd56c3b14e3279efc55f

Update README.md

view details

push time in 21 days

push eventfewf/briscalone

Greg Altman

commit sha 39cfb0e4e6d1c3b66422e7c7b265af702879df04

add keys and remove console logs

view details

Greg Altman

commit sha 19c56df9035c28580a145ee8febff065c9806b1c

install cypress and get started against best practices

view details

Greg Altman

commit sha 467e84411f6e2ec63f09ccf49cd2723f9d8959c5

add test server route, get test running up to monkey action

view details

Greg Altman

commit sha 7f63729fd807478c11f0d4979839713e18d3a2c7

robot plays a round successfully

view details

Greg Altman

commit sha 619263124b9d893a28aefb48e865e9c854192d87

obscure other player's cards

view details

Greg Altman

commit sha fcfa0086590721d10b8d165ba3fdc0d464a94221

start chunking out layout

view details

Greg Altman

commit sha 25e0e61930d952b10898ce2587add97b28b0cce6

working with table pieces chunked out

view details

Greg Altman

commit sha 2e4fa78780670fda6ca8fa1a4e1e85df378259a6

chunk out Player

view details

Greg Altman

commit sha 808bdebb0af4e4644f595d91b4ee0e3a9bbe94b2

chunk out Score

view details

Greg Altman

commit sha 804aefead567b419fb20fb11dae64987e810c52a

componentize Chat and GameInfo

view details

Greg Altman

commit sha 35a8dce797a049496830ce89165d3cfaa2d22f63

remove localstorage stuff

view details

Greg Altman

commit sha 829ab47bef0f9b5b7a1a20f7265d3efbd5cb2479

get tests working, fixing some stuff along the way

view details

Greg Altman

commit sha 886257eb6ce7ded05aa17bbc99813c9d7a8ca5a8

clean up client socket message handling

view details

Greg Altman

commit sha 805b5b02616d6bdb1852fad968e7a9958341609d

run prettier

view details

push time in 21 days

push eventsmaltman-wedding/smaltman-wedding.github.com

Greg Altman

commit sha 3f702947df633c84bb5fee7600d395dd9dafb706

alter 4:30 verbiage

view details

push time in 2 months

push eventsmaltman-wedding/smaltman-wedding.github.com

Greg Altman

commit sha 062a651bfc8ced5c6c3d138ce0accea0fd69dd73

Updates

view details

push time in 2 months

push eventsmaltman-wedding/smaltman-wedding.github.com

Greg Altman

commit sha eb85df4cc45f6e9d912e984b111109b859ff9dbb

Updates

view details

push time in 2 months

create barnchfewf/briscalone

branch : other-approach

created branch time in 2 months

issue commentdenoland/deno

--info output not an Advanced format

can we close this @ry ?

kishorevaishnav

comment created time in 2 months

Pull request review commentdenoland/deno

Pretty print deps

 impl Modules { pub struct Deps {   pub name: String,   pub deps: Option<Vec<Deps>>,-  depth: usize,+  prefix: String,+  is_last: bool, }  impl Deps {   pub fn new(modules: &Modules, module_name: &str) -> Deps {     let mut seen = HashSet::new();     let id = modules.get_id(module_name).unwrap();-    Self::helper(&mut seen, 0, modules, id)+    Self::helper(&mut seen, "".to_string(), true, modules, id)   }    fn helper(     seen: &mut HashSet<deno_mod>,-    depth: usize,+    prefix: String,+    is_last: bool,     modules: &Modules,     id: deno_mod,   ) -> Deps {     let name = modules.get_name(id).unwrap().to_string();     if seen.contains(&id) {       Deps {         name,-        depth,+        prefix,         deps: None,+        is_last,       }     } else {       seen.insert(id);       let child_ids = modules.get_children(id).unwrap();+      let child_count = child_ids.iter().count();       let deps = child_ids         .iter()-        .map(|dep_id| Self::helper(seen, depth + 1, modules, *dep_id))-        .collect();+        .enumerate()+        .map(|(index, dep_id)| {+          let new_is_last = index == child_count - 1;+          let mut new_prefix = prefix.clone();+          new_prefix.push(if is_last { ' ' } else { '│' });+          new_prefix.push(' ');+          Self::helper(seen, new_prefix, new_is_last, modules, *dep_id)+        }).collect();       Deps {         name,-        depth,+        prefix,         deps: Some(deps),+        is_last,       }     }   } }  impl fmt::Display for Deps {   fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {-    for _i in 0..self.depth {-      write!(f, "| ")?;+    let mut has_children = false;+    if let Some(ref deps) = self.deps {

not sure if there's a more straightforward way of doing basically obj.array && obj.array.length > 0 here

fewf

comment created time in 2 months

push eventfewf/deno

Greg Altman

commit sha 54af5512a92b2a1b8c482d98024fe211884f8847

eliminate need for Dep.has_children, fix dupe issue

view details

push time in 2 months

push eventfewf/deno

push time in 2 months

push eventfewf/deno

Greg Altman

commit sha b2b6c28616d3585a23a20fcebec32344f40623e2

is this what tests want?

view details

push time in 2 months

pull request commentdenoland/deno

Pretty print deps

Hoping for some help interpreting the test failures. Travis Tests seem to be failing on ./tools/lint.py but I can't figure out where the lint problem is occurring. And then I'm very unclear about what's going on in the AppVeyor test.

fewf

comment created time in 2 months

push eventfewf/deno

Greg Altman

commit sha 74d73a903e45b28a77870217c461adacbc910927

make sure that has_children is accurate

view details

Greg Altman

commit sha 1ab6c2613aa66f869befb0ab06d60f3d6cc6b49b

fix test output

view details

Greg Altman

commit sha 2d15c35068162345946e3fe8c4564011575b81c8

make test a little more interesting

view details

push time in 2 months

pull request commentdenoland/deno

Pretty print deps

One issue that I need to address. Right now if there's a dep that has children and which has already been seen, it prints a as if it's going to list those children, but because it's been seen, it doesn't print them.

fewf

comment created time in 2 months

issue commentdenoland/deno

--info output not an Advanced format

I've got a PR for this started. Thanks @luvies for drawing my attention to how to do the pretty printing in JavaScript, as I basically ported that to Rust. I need to finish up with tests, but in the meantime, I'd appreciate any feedback on my Rust or in the implementation.

kishorevaishnav

comment created time in 2 months

PR opened denoland/deno

Pretty print deps

<!-- Before submitting a PR read https://deno.land/manual.html#contributing --> addresses https://github.com/denoland/deno/issues/1746

still needs tests, and I'd love code review on my Rust, since I'm very new to the language.

+45 -11

0 comment

1 changed file

pr created time in 2 months

create barnchfewf/deno

branch : pretty-print-deps

created branch time in 2 months

issue commentdenoland/deno

--info output not an Advanced format

I'm looking into this

kishorevaishnav

comment created time in 2 months

fork fewf/deno_std

deno standard modules

https://deno.land/x/

fork in 3 months

Pull request review commentsh7dm/deno

don't specify write permission where it's irrelevant

 function assertSameContent(files: FileInfo[]) {   assertEqual(counter, 2); } -testPerm({ write: true, read: true }, function readDirSyncSuccess() {+testPerm({ read: true }, function readDirSyncSuccess() {   const files = deno.readDirSync("tests/");   assertSameContent(files); }); -testPerm({ write: true, read: false }, function readDirSyncPerm() {+testPerm({ read: false }, function readDirSyncPerm() {

that's a good point, it's not necessary. the only justification I can think of is that it declares to the next person reading the code which permission is lacking.

fewf

comment created time in 3 months

pull request commentdenoland/deno

Add fs read permission (don't squash)

I have a fix for what @J2P caught in a PR into this branch https://github.com/sh7dm/deno/pull/2 .

I think it could be misleading that after giving permission to a prompt that says Deno requests read access to {filename}. Grant?, I've now given permission to the script to read all of my filesystem. (This applies to the write permission prompt too). To resolve this, granting permission through the prompt could give a one-time permission to the script, or the prompt could read something like "Deno requests read access to your filesystem. Grant?"

sh7dm

comment created time in 3 months

PR opened sh7dm/deno

don't specify write permission where it's irrelevant

<!-- https://github.com/denoland/deno/blob/master/.github/CONTRIBUTING.md -->

+4 -4

0 comment

1 changed file

pr created time in 3 months

push eventfewf/deno

JaePil Jung

commit sha 66cea3906733955c6c1fb223d0bf42eb6bc456b4

Fixed chart width to responsive (#1670)

view details

Masashi Hirano

commit sha e2d76278bfe8e51c2914bb126a5d98c59be2de3a

Replace macros to check nullptr (#1674) This replaces CHECK_EQ/CHECK_NE with CHECK_NULL/CHECK_NOT_NULL to check nullptr. These macros are implemented in V8. Refs: https://github.com/denoland/deno_third_party/blob/master/v8/src/base/logging.h#L312

view details

Jimmy Moon

commit sha 748b0f9c9d267dddf6f59c9d2ca8728bc76e630f

Remove duplicated links in website (#1668)

view details

Kitson Kelly

commit sha 48fedee34e567570e43905dc9f32d0d78118b9b0

Add WebAssembly to runtime library (#1677) This also modifies the `ts_library_builder` to support inlining assets. Includes integration tests from @sh7dm

view details

Dmitry Sharshakov

commit sha 7b282e4dbc43246bd3f33850127bf19e4a2c6df3

Fix indentation for .py files in .editorconfig (#1672)

view details

JaePil Jung

commit sha ed6aec9bf0822dfba32f8a7e1781c5ca67881f6b

Fixed test code (#1688)

view details

JaePil Jung

commit sha ffe8f73d3405bb252d983e5aea7e8dccc19d6329

Add missing run permission in test function (#1697)

view details

Dmitry Sharshakov

commit sha 31014971e097915beac4863561484679cfa1c7d7

Merge pull request #1 from fewf/read-permissions-tests add tests and add permissions checks to op_open

view details

Dmitry Sharshakov

commit sha aaf4882eb83f625d16412af915f7c63505586ef5

Merge branch 'master' into read-permission

view details

sh7dm

commit sha 2ba9e8821385e03f31dd2166c6892429db85a503

Fix test_format

view details

Greg Altman

commit sha d032ab1ff9975b5cb9295c52f0ab5b9a58d7ca7a

don't specify write permission where it's irrelevant

view details

push time in 3 months

Pull request review commentdenoland/deno

Add fs read permission (don't squash)

 function assertSameContent(files: FileInfo[]) {   assertEqual(counter, 2); } -test(function readDirSyncSuccess() {+testPerm({ write: true, read: true }, function readDirSyncSuccess() {

good catch

sh7dm

comment created time in 3 months

pull request commentsh7dm/deno

add tests and add permissions checks to op_open

awesome--done @sh7dm

fewf

comment created time in 3 months

push eventfewf/deno

Greg Altman

commit sha 64e5c4e9fd09f6ffb03b64fb7390b99ff3d63521

pylint

view details

push time in 3 months

pull request commentsh7dm/deno

add tests and add permissions checks to op_open

Thanks for checking it out @sh7dm ! I formatted the code. What errors need to be fixed? Thanks for the help, this is my first contribution.

fewf

comment created time in 3 months

push eventfewf/deno

Greg Altman

commit sha b35031b204e5a2ac883fa9c7ca3c9a0acb54017f

format code

view details

push time in 3 months

issue commentdenoland/deno

Add --allow-read

I've closed my PR in favor of @sh7dm . I did continue to do some more work towards fixing this issue, which I have in a PR into @sh7dm 's branch: https://github.com/sh7dm/deno/pull/1 . Hope this can be used and sorry if I stepped on anyone's toes--very excited to be working on this project!

ry

comment created time in 3 months

PR closed denoland/deno

Add allow read

<!-- https://github.com/denoland/deno/blob/master/.github/CONTRIBUTING.md --> fixes https://github.com/denoland/deno/issues/1225 some duplicate work on https://github.com/denoland/deno/pull/1689

+82 -6

1 comment

4 changed files

fewf

pr closed time in 3 months

push eventfewf/deno

Greg Altman

commit sha 2cf790901bffc3627c391428869dfa331fa3aa44

alter tests for all read ops except op_open

view details

Greg Altman

commit sha 726971d5b1ebd935f82f295c7d4c6a8c6f0aa11e

add allow-read to flags, set it to true in allow-all

view details

Greg Altman

commit sha b8f4462eb9e1e0ae73c304eb6f5e95e0e6b706cf

add read checks to op_open

view details

Greg Altman

commit sha a82f50884dd66e2275f5eb568af98dde2e1af126

add in no-permissions test and fix remaining tests

view details

push time in 3 months

push eventfewf/deno

Greg Altman

commit sha a02f7d02330428c3bb8ed7c20164bc02f584c96e

alter tests for all read ops except op_open

view details

push time in 3 months

PR opened sh7dm/deno

alter tests for all read ops except op_open

<!-- https://github.com/denoland/deno/blob/master/.github/CONTRIBUTING.md -->

+183 -48

0 comment

7 changed files

pr created time in 3 months

create barnchfewf/deno

branch : read-permissions-tests

created branch time in 3 months

issue commentdenoland/deno

Add --allow-read

Naw, that makes sense. I was thinking very maximally at first.

ry

comment created time in 3 months

issue commentdenoland/deno

Add --allow-read

Thanks @kitsonk this was just a case of bad timing as I started looking into this yesterday just as a way to familiarize myself with Deno, so I'm fine to step off of it.

ry

comment created time in 3 months

issue commentdenoland/deno

Add --allow-read

Hi all--new Deno'er here. It looks like @sh7dm and I have duplicated some work on this, but not a ton. There are some open questions I've had as I started on this.

What's a read operation? Both my PR and @sh7dm treat the following Ops as needing Read Access:

  • op_open
  • op_read_file
  • op_copy_file
  • op_stat
  • op_read_dir
  • op_read_link

whereas in mine, I include also:

  • op_remove
  • op_cwd
  • op_rename
  • op_symlink

Can anyone give an authoritative/exhaustive list of what Ops should ask for read access?

@sh7dm let me know if you want to merge our branches and split up the remaining work on this.

Thanks!

ry

comment created time in 3 months

PR opened denoland/deno

Add allow read

<!-- https://github.com/denoland/deno/blob/master/.github/CONTRIBUTING.md --> fixes https://github.com/denoland/deno/issues/1225 some duplicate work on https://github.com/denoland/deno/pull/1689

+82 -6

0 comment

4 changed files

pr created time in 3 months

push eventfewf/deno

Greg Altman

commit sha 6670e8414f095dcb2cd29af5af95802a267f397a

add cwd to check_read ops

view details

push time in 3 months

create barnchfewf/deno

branch : add-allow-read

created branch time in 3 months

fork fewf/deno

A new way to JavaScript

https://deno.land/

fork in 3 months

push eventsmaltman-wedding/smaltman-wedding.github.com

Greg Altman

commit sha b09a2252d436e087143136b0a8f4258301cd2061

Updates

view details

push time in 3 months

create barnchsmaltman-wedding/smaltman-wedding.github.com

branch : develop

created branch time in 3 months

push eventfewf/briscalone

Greg Altman

commit sha 906bda95516b190a22a3ba418f45d734e8985903

add server ping

view details

Greg Altman

commit sha d946ffa49bf53a37bbe225430455341d61a1b9ac

ignore pings on clientside

view details

push time in 3 months

push eventsmaltman-wedding/smaltman-wedding.github.com

Greg Altman

commit sha 5ad4a5e4b95496e268645abd6998a1ee40304eda

Updates

view details

push time in 3 months

push eventsmaltman-wedding/smaltman-wedding.github.com

Greg Altman

commit sha b3e1792749247ee73e3c97ab9ad00c5bd7043885

Updates

view details

push time in 3 months

push eventsmaltman-wedding/smaltman-wedding.github.com

Greg Altman

commit sha 87961d44491fe3c1248a1cda5bb012daef8ee9da

Create CNAME

view details

push time in 3 months

push eventsmaltman-wedding/smaltman-wedding.github.com

Greg Altman

commit sha 3b4aa5dc6c202dab866e1800759fccc154a6332c

Updates

view details

push time in 3 months

push eventsmaltman-wedding/smaltman-wedding.github.com

Greg Altman

commit sha 33e2f3350d573e828256ef60c724d33e533b656c

Updates

view details

push time in 3 months

push eventsmaltman-wedding/smaltman-wedding.github.com

Greg Altman

commit sha 45509d7c2c9a7a7a8b355a8e299e75b33ebd3dea

Updates

view details

push time in 3 months

push eventsmaltman-wedding/smaltman-wedding.github.com

Greg Altman

commit sha a68e3c23b918a52ec50a11b0c76db04d4d8abd9a

Updates

view details

push time in 3 months

push eventfewf/briscalone

Greg Altman

commit sha 6d90c3bacbe3db81c3ebdb6a8e61753046231240

layout fixies

view details

Greg Altman

commit sha e7ba2dc67c6df151cb7e983278ed60b09573e25d

fix rejoin chat, kinda

view details

push time in 3 months

more