profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/fawind/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

fawind/picasso 11

🎨 Artsy New Tab pages for the masses

fawind/mongochain 7

PoC of a decentralized datastore

fawind/lucidtask 6

Minimal to-do application

fawind/.dotfiles 5

Collection of my config files

fawind/big-data-notebook 5

Python notebook with solutions for the lecture Big Data Analytics

fawind/nyc-subway-optimization 5

Optimize the NYC subway based on taxi rides

fawind/overleaf-commander 5

Omni-searchbar for Overleaf.com

AlexImmer/run-dmc 4

Solution repository of DMC-16 finalist team

fawind/notes 4

App for writing "wysiwyg" markdown notes

push eventpalantir/gradle-baseline

Fabian Windheuser

commit sha 6a6deb21f8989dffdadc58e3d74438d3a2f8b0dc

Set preferProjectModules as default resolution strategy

view details

push time in 4 days

create barnchpalantir/gradle-baseline

branch : fw/prefer-project-modules

created branch time in 4 days

pull request commentpalantir/gradle-baseline

[tests only] Migrate tests off JCenter to Maven Central

I thought we had an excavator for this but maybe its skipping or not finding occurences in groovy code? Will do some digging!

carterkozak

comment created time in 4 days

PullRequestReviewEvent
PullRequestReviewEvent

startedswaywm/sway

started time in 5 days

push eventpalantir/conjure-typescript

damianrusak

commit sha 2a910c3d43f72d49cd1b7e6a60cdf14b939c90c9

add "module" to reservedKeywords (#167) * add "module" to reservedKeywords * Add changelog * Update changelog Co-authored-by: Damian Rusak <drusak@palantir.com>

view details

push time in 5 days

PR merged palantir/conjure-typescript

add "module" to reservedKeywords

Before this PR

Using the word module in a type union in Conjure can cause issues - while this isn’t a reserved keyword in JavaScript (the language), it is reserved in the CommonJS module format:

module.exports = {
    helloWorld: "Hello, world!"
};

In practice having a symbol named module is likely to cause problems with Webpack. It effectively shadows code generated by Webpack. Here’s an illustration:

image

After this PR

module is properly "escaped" to module_ in generated typescript function to construct an object of a type from a union:

function module_(obj)

==COMMIT_MSG== Added the word module to reservedKeywords. ==COMMIT_MSG==

Possible downsides?

<!-- Please describe any way users could be negatively affected by this PR. -->

+7 -0

15 comments

2 changed files

damianrusak

pr closed time in 5 days

PullRequestReviewEvent

pull request commentpalantir/conjure-typescript

add "module" to reservedKeywords

Discussed internally and all agree that this is a good change. Currently having a field called module can work or fail based on the order of how your code is bundled. Will cut this as a major ref to indicate the potential break however internally, we are mostly clear.

eh seems the changelog bot didn't take... ;)

Unfortunately, changelog bot doesn't work with forks :(. Will take a look and bring this over the line!

damianrusak

comment created time in 5 days

push eventdamianrusak/conjure-typescript

Fabian Windheuser

commit sha 77c4d89a68e971335fef3bde7cde4f954d983db1

Update changelog

view details

push time in 5 days

push eventdamianrusak/conjure-typescript

Fabian Windheuser

commit sha 22d4329fd4e73799e37acd1adc15850f902784bb

Add changelog

view details

push time in 5 days

PR merged palantir/gradle-external-publish-plugin

Excavator: Format Java files no changelog
excavator is a bot for automating changes across repositories.

Changes produced by the roomba/format check.

To enable or disable this check, please contact the maintainers of Excavator.

+13 -27

0 comment

3 changed files

svc-excavator-bot

pr closed time in 5 days

push eventpalantir/gradle-external-publish-plugin

Excavator Bot

commit sha d7c3a48b31ffb587000e8aef4263d5ef1a0d56ed

Excavator: Format Java files (#68)

view details

push time in 5 days

PR closed palantir/gradle-external-publish-plugin

Reviewers
Excavator: Format Java files no changelog
excavator is a bot for automating changes across repositories.

Changes produced by the roomba/format check.

To enable or disable this check, please contact the maintainers of Excavator.

+13 -27

1 comment

3 changed files

svc-excavator-bot

pr closed time in 5 days

pull request commentpalantir/gradle-external-publish-plugin

Excavator: Format Java files

Closing with https://github.com/palantir/gradle-external-publish-plugin/pull/68

svc-excavator-bot

comment created time in 5 days

PullRequestReviewEvent

pull request commentpalantir/conjure-typescript

add "module" to reservedKeywords

Hmm, I'm not sure how lax we should be with compile breaks -- although it will probably only affect a few selected consumers. I'll reach out and would like to get a second opinion from someone on the frontend-infra on this.

To double check, what is the current practical implication? You're blocked from using conjure apis that have such types?

damianrusak

comment created time in 5 days

pull request commentpalantir/conjure-typescript

add "module" to reservedKeywords

How does this affect existing users that have types including the word union? Will this be a compile break for them?

damianrusak

comment created time in 5 days

PullRequestReviewEvent

pull request commentpalantir/gradle-baseline

Run `gradle-baseline-java` integration tests

What's the actual change there that runs the tests now compared to before? The addition of org.junit.vintage:junit-vintage-engine?

carterkozak

comment created time in 6 days

PR opened palantir/conjure-typescript

Fix published dist file structure merge when ready autorelease

Before this PR

Projects depending on conjure-typescript are breaking with:

java.lang.IllegalStateException: Couldn't find expected file after extracting archive /home/circleci/.gradle/caches/modules-2/files-2.1/com.palantir.conjure.typescript/conjure-typescript/4.8.0/<checksum>/conjure-typescript-4.8.0.tgz:
task ':extractConjureTypeScript'
property 'executable'

This is because we messed up the directory structure of the published dist in https://github.com/palantir/conjure-typescript/pull/168.

Expected is:

conjure-typescript-4.8.0.tgz
  |-conjure-typescript-4.8.0
    |-bin
      |-[...]

However we published:

conjure-typescript-4.8.0.tgz
  |-bin
    |-[...]

After this PR

==COMMIT_MSG== Fix published dist file structure ==COMMIT_MSG==

+4 -2

0 comment

1 changed file

pr created time in 8 days

create barnchpalantir/conjure-typescript

branch : fw/fix-publish-dist

created branch time in 8 days

PullRequestReviewEvent

delete branch palantir/gradle-baseline

delete branch : fw/remove-scalastyle

delete time in 10 days

PR closed palantir/gradle-baseline

Reviewers
Remove baseline-scalastyle plugin do not merge

Before this PR

We were using the ngbinh/gradle-scalastyle-plugin for scalastyle integration which has not been updated for multiple years. In addition to that, the original scalastyle plugin has also not been maintained in a while (https://github.com/scalastyle/scalastyle/issues/360).

The plugin is also blocking the Gradle 7 adoption of our scala repos due to incompatibilities.

Note that there are some more recently maintained forks (e.g. alisiikh/gradle-scalastyle-plugin and beautiful-scala/scalastyle). However internally, only a few projects are using it and we are getting limited value out of scalastyle.

Hence we are dropping scalastyle plugin for now.

After this PR

==COMMIT_MSG== Remove baseline-scalastyle plugin ==COMMIT_MSG==

  • Marking this as a break because consumers could apply the plugin explicitly. However I couldn't find any explicit usage in Palantir owner repos.
  • As a follow up, I'll update the "update-baseline" excavator to also remove the scalastyle config when updating to this version.

cc @robert3005, @rshkv

+5 -407

2 comments

13 changed files

fawind

pr closed time in 10 days

Pull request review commentpalantir/gradle-baseline

Remove baseline-scalastyle plugin

-/*- * (c) Copyright 2018 Palantir Technologies Inc. All rights reserved.- *- * Licensed under the Apache License, Version 2.0 (the "License");- * you may not use this file except in compliance with the License.- * You may obtain a copy of the License at- *- *     http://www.apache.org/licenses/LICENSE-2.0- *- * Unless required by applicable law or agreed to in writing, software- * distributed under the License is distributed on an "AS IS" BASIS,- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.- * See the License for the specific language governing permissions and- * limitations under the License.- */--package com.palantir.baseline.plugins;--import com.google.common.collect.ImmutableList;-import com.google.common.collect.ImmutableMap;-import groovy.util.Node;-import groovy.xml.QName;-import java.nio.file.Paths;-import org.codehaus.groovy.runtime.InvokerHelper;-import org.github.ngbinh.scalastyle.ScalaStylePlugin;-import org.github.ngbinh.scalastyle.ScalaStyleTask;-import org.gradle.api.Project;-import org.gradle.api.plugins.Convention;-import org.gradle.api.plugins.JavaPluginConvention;-import org.gradle.api.tasks.ScalaSourceSet;-import org.gradle.api.tasks.SourceSet;-import org.gradle.api.tasks.TaskCollection;-import org.gradle.api.tasks.scala.ScalaCompile;-import org.gradle.plugins.ide.idea.model.IdeaModel;--public final class BaselineScalastyle extends AbstractBaselinePlugin {-    private static final String SCALA_TARGET_VERSION = "jvm-1.8";--    @Override-    public void apply(Project project) {-        this.project = project;-        project.getPluginManager().withPlugin("scala", plugin -> {

You're right. Only skimmed this class :/

Let's continue with your PR: https://github.com/palantir/gradle-baseline/pull/1912

fawind

comment created time in 10 days

PullRequestReviewEvent

pull request commentpalantir/gradle-baseline

Remove baseline-scalastyle plugin

Tagging 'do-not-merge' as I want to get the excavator lined up before merging.

fawind

comment created time in 10 days

PR opened palantir/gradle-baseline

Remove baseline-scalastyle plugin

Before this PR

We were using the ngbinh/gradle-scalastyle-plugin for scalastyle integration which has not been updated for multiple years. In addition to that, the original scalastyle plugin has also not been maintained in a while (https://github.com/scalastyle/scalastyle/issues/360).

The plugin is also blocking the Gradle 7 adoption of our scala repos due to incompatibilities.

Note that there are some more recently maintained forks (e.g. alisiikh/gradle-scalastyle-plugin and beautiful-scala/scalastyle). However internally, only a few projects are using it and we are getting limited value out of scalastyle.

Hence we are dropping scalastyle plugin for now.

After this PR

==COMMIT_MSG== Remove baseline-scalastyle plugin ==COMMIT_MSG==

  • Marking this as a break because consumers could apply the plugin explicitly. However I couldn't find any explicit usage in Palantir owner repos.
  • As a follow up, I'll update the "update-baseline" excavator to also remove the scalastyle config when updating to this version.

cc @robert3005, @rshkv

+0 -407

0 comment

12 changed files

pr created time in 10 days