profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/falsefalse/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Ilya Furman falsefalse Toptal Doot doot!

falsefalse/sublime-ejs 32

EJS templates syntax definitions for SublimeText2

falsefalse/terminalcopyonselect 8

A SIMBL plugin for Terminal.app which enable us to copy on selection.

falsefalse/geoip-server 3

Serve MaxMind geo data with expressjs

falsefalse/boost-theme-test 1

rails 2.2.2 + rails-dev-boost + theme_support don't work well :(

falsefalse/coffee-script-tmbundle 1

A TextMate Bundle for CoffeeScript

falsefalse/js-raw-cube 1

Test project, some playing with 3D on canvas

falsefalse/mobile-fest 1

Test project for dostuffmedia.com

falsefalse/sdl-grid 1

Test task, draw a grid without any libs help, time limit is 3 hours

falsefalse/Sublime-JSHint 1

Javascript Lint for Sublime Text editor via node.js (JSHint build system and python plugin)

falsefalse/chai-karma-snapshot 0

Chai Plugin for Snapshot Testing with Karma

pull request commenttoptal/picasso

style(Modal): fix modal content overflow issue

:tada: Last commit is successfully deployed :tada:

Demo is available on:

Your davinci-bot :rocket:

pudek357

comment created time in 3 hours

push eventtoptal/picasso

Huy Tran

commit sha 5a52d57f2c53fb24820a81080677f4b7854aeb78

fix(picasso-forms): validation on submit (#2101)

view details

toptal-davinci-bot

commit sha 56e19049a634b4cdab1f805d6d326240bea230d7

chore(release): publish [skip ci] - @toptal/picasso-forms@4.2.1

view details

Rafał Kwaśniewski

commit sha acf6c6d355c988adbe1e513459f405a23467f87d

Merge branch 'master' into SPT-1712-SPT-1708-fix-modal-content-overflow-issue

view details

push time in 3 hours

pull request commenttoptal/picasso

style(Modal): fix modal content overflow issue

:tada: Last commit is successfully deployed :tada:

Demo is available on:

Your davinci-bot :rocket:

pudek357

comment created time in 3 hours

push eventtoptal/picasso

Rafał Kwaśniewski

commit sha abcb0b50d57e092a4e5e8921e8e930dc7539fe52

style: cleaning & use variable in background linear

view details

push time in 3 hours

pull request commenttoptal/picasso

style(Modal): fix modal content overflow issue

:tada: Last commit is successfully deployed :tada:

Demo is available on:

Your davinci-bot :rocket:

pudek357

comment created time in 3 hours

pull request commenttoptal/picasso

style(Modal): fix modal content overflow issue

<!-- 1 failure: The commit - d353... 0 warning:

DangerID: danger-id-Danger; -->

<table> <thead> <tr> <th width="50"></th> <th width="100%" data-danger-table="true">Fails</th> </tr> </thead> <tbody><tr> <td>:no_entry_sign:</td> <td>

The commit - d353f6b9d500bacdf2f9d149d0d14fd42b76b099 doesn't conform the conventional commit guidelines.

Errors:

Message
subject may not be empty
type may not be empty

💡 For a guidance on how to fix this problem please refer to https://www.conventionalcommits.org

💡 Or you can check our documentation </td> </tr> </tbody> </table>

<p align="right"> Generated by :no_entry_sign: <a href="https://danger.systems/js">dangerJS</a> against d353f6b9d500bacdf2f9d149d0d14fd42b76b099 </p>

pudek357

comment created time in 3 hours

push eventtoptal/picasso

Dmitry Maklygin

commit sha d353f6b9d500bacdf2f9d149d0d14fd42b76b099

tbs

view details

push time in 4 hours

pull request commenttoptal/picasso

fix(tooltip): show tooltip on both label and control

:tada: Last commit is successfully deployed :tada:

Demo is available on:

Your davinci-bot :rocket:

MrBra1nwash

comment created time in 4 hours

push eventtoptal/picasso

Denys Yalomist

commit sha d960705472be746205762769dd900b0677248114

fix(tooltip): show tooltip on both label and control

view details

push time in 4 hours

pull request commenttoptal/picasso

fix(tooltip): show tooltip on both label and control

I've noticed, that in the disabled state a tooltip still appears. Picasso | Checkbox 2021-06-17 15-42-45

I think it is expected behavior because we can use it when we want to tell the user why it is disabled. Whether the tooltip should be displayed is up to the consumer of the component

MrBra1nwash

comment created time in 4 hours

Pull request review commenttoptal/picasso

fix(tooltip): show tooltip on both label and control

 export interface Props   value?: string } -export const Checkbox = forwardRef<HTMLButtonElement, Props>(function Checkbox(-  props,-  ref-) {-  const {-    label,-    id,-    className,-    style,-    disabled,-    requiredDecoration,-    onChange,-    value,-    checked,-    indeterminate,-    titleCase,-    ...rest-  } = props+const CheckboxWrapper: FC<{ className: string }> = ({+  className,+  children+}) => (+  <Container as='span' flex inline className={className}>+    {children}+  </Container>+) -  const classes = useStyles()-  const rootClasses = {-    root: classes.root,-    disabled: classes.disabled-  }-  // eslint-disable-next-line @typescript-eslint/no-unused-vars-  const { color, ...checkboxAttributes } = rest+export const Checkbox = forwardRef<HTMLButtonElement | HTMLLabelElement, Props>(+  function Checkbox (props, ref) {+    const {+      label,+      id,+      className,+      style,+      disabled,+      requiredDecoration,+      onChange,+      value,+      checked,+      indeterminate,+      titleCase,+      ...rest+    } = props++    const classes = useStyles()+    const rootClasses = {+      root: classes.root,+      disabled: classes.disabled+    }+    // eslint-disable-next-line @typescript-eslint/no-unused-vars+    const { color, ...checkboxAttributes } = rest++    console.log('checkboxAttributes', checkboxAttributes)

🙈 Thanks, fixed.

MrBra1nwash

comment created time in 4 hours

pull request commenttoptal/picasso

style(Modal): fix modal content overflow issue

:tada: Last commit is successfully deployed :tada:

Demo is available on:

Your davinci-bot :rocket:

pudek357

comment created time in 5 hours

Pull request review commenttoptal/picasso

style(Modal): fix modal content overflow issue

-import { createStyles } from '@material-ui/core'+import { createStyles, hexToRgb, Theme } from '@material-ui/core'  const WRAPPER_PADDING = '2em'+const SHADE_HEIGHT = '80px' -const shadeStyles = {-  left: 0,-  right: 0,+const shadeCommonStyles = {   zIndex: 1,   position: 'absolute' as const,-  pointerEvents: 'none' as const,-  height: 80+  pointerEvents: 'none' as const+}++const shadeStyles = {+  ...shadeCommonStyles,+  right: WRAPPER_PADDING,+  left: WRAPPER_PADDING,+  height: `calc(${SHADE_HEIGHT} + ${WRAPPER_PADDING})`+}++const shadePseudoStyles = {+  ...shadeCommonStyles,+  right: 0,+  left: 0,+  content: '""'+}++const shadePseudoBeforeStyles = {+  ...shadePseudoStyles,+  height: WRAPPER_PADDING+}++const shadePseudoAfterStyles = {+  ...shadePseudoStyles,+  height: SHADE_HEIGHT } -export default () =>-  createStyles({+export default ({ palette }: Theme) => {+  const BACKGROUND_STARTING_COLOR = palette.background.default+  const BACKGROUND_FINISHING_COLOR = hexToRgb(`${palette.common.black}0`)++  return createStyles({     modalContent: {+      padding: WRAPPER_PADDING,       overflow: 'auto',       flex: '1 1 auto'     },     wrapper: {-      padding: WRAPPER_PADDING,       display: 'flex',       position: 'relative',       flex: '1 1 auto',       overflowY: 'hidden'     },     topShade: {       ...shadeStyles,-      top: WRAPPER_PADDING,-      background: `linear-gradient(180deg, white 0%, rgba(255,255,255,0) 5rem)`+      top: 0,+      '&:before': {+        ...shadePseudoBeforeStyles,+        backgroundColor: BACKGROUND_STARTING_COLOR,+        top: 0+      },+      '&:after': {+        ...shadePseudoAfterStyles,+        top: WRAPPER_PADDING,+        background: `linear-gradient(180deg, ${BACKGROUND_STARTING_COLOR} 0%, ${BACKGROUND_FINISHING_COLOR} 5rem)`+      }     },     bottomShade: {       ...shadeStyles,-      bottom: WRAPPER_PADDING,-      background: `linear-gradient(0deg, white 0%, rgba(255,255,255,0) 5rem)`+      bottom: 0,+      '&:before': {+        ...shadePseudoBeforeStyles,+        backgroundColor: BACKGROUND_STARTING_COLOR,+        bottom: 0+      },+      '&:after': {+        ...shadePseudoAfterStyles,+        bottom: WRAPPER_PADDING,+        background: `linear-gradient(0deg, ${BACKGROUND_STARTING_COLOR} 0%, ${BACKGROUND_FINISHING_COLOR} 5rem)`

Yeah, it's possible to do it with only one pseudo-element, I've pushed changes.

But we need this one pseudo-element as linear background and full color background has different purposes, please see video: https://user-images.githubusercontent.com/4816942/122399773-4dfe5880-cfa5-11eb-85c2-406bc606202d.mp4

pudek357

comment created time in 5 hours

push eventtoptal/picasso

Rafał Kwaśniewski

commit sha b2914ec3b8bdedb3de42469ffcb36f12134c40c5

style: use only before pseudo element

view details

push time in 5 hours

Pull request review commenttoptal/picasso

fix(tooltip): show tooltip on both label and control

 export interface Props   value?: string } -export const Checkbox = forwardRef<HTMLButtonElement, Props>(function Checkbox(-  props,-  ref-) {-  const {-    label,-    id,-    className,-    style,-    disabled,-    requiredDecoration,-    onChange,-    value,-    checked,-    indeterminate,-    titleCase,-    ...rest-  } = props+const CheckboxWrapper: FC<{ className: string }> = ({+  className,+  children+}) => (+  <Container as='span' flex inline className={className}>+    {children}+  </Container>+) -  const classes = useStyles()-  const rootClasses = {-    root: classes.root,-    disabled: classes.disabled-  }-  // eslint-disable-next-line @typescript-eslint/no-unused-vars-  const { color, ...checkboxAttributes } = rest+export const Checkbox = forwardRef<HTMLButtonElement | HTMLLabelElement, Props>(+  function Checkbox (props, ref) {+    const {+      label,+      id,+      className,+      style,+      disabled,+      requiredDecoration,+      onChange,+      value,+      checked,+      indeterminate,+      titleCase,+      ...rest+    } = props++    const classes = useStyles()+    const rootClasses = {+      root: classes.root,+      disabled: classes.disabled+    }+    // eslint-disable-next-line @typescript-eslint/no-unused-vars+    const { color, ...checkboxAttributes } = rest++    console.log('checkboxAttributes', checkboxAttributes)

console

MrBra1nwash

comment created time in 5 hours

pull request commenttoptal/picasso

fix(tooltip): show tooltip on both label and control

I've noticed, that in the disabled state a tooltip still appears. Picasso | Checkbox 2021-06-17 15-42-45

MrBra1nwash

comment created time in 5 hours

push eventtoptal/granite

Andrius Chamentauskas

commit sha fb3a120b4c205cbdd602a4cb2559c3f7ef0a6dd7

Simplify translations scoping for local I18n keys

view details

push time in a day

pull request commenttoptal/picasso

fix(tooltip): show tooltip on both label and control

:tada: Last commit is successfully deployed :tada:

Demo is available on:

Your davinci-bot :rocket:

MrBra1nwash

comment created time in a day

PR opened toptal/picasso

Reviewers
fix(tooltip): show tooltip on both label and control

FX-1874

Description

The tooltip for the radio and checkbox with the label was positioned incorrectly and was not visible if we hover over the label. It was always centered relatively on radio or checkbox. Now it is either in the center of the button or in the center of the button and label. The problems that I solved here:

  1. Pass only one ref to the child component. In case we have label pass ref to the label, otherwise, pass it to the button(checkbox or radio)
  2. Pass listeners (onMouseLeave, onMouseOver) from Tooltip to the label
  3. Created two examples in Radio and Checkbox components instead of Tooltip, because changes were done in these components

How to test

  • Go to Radio and Checkbox story
  • Scroll down to the With tooltip example
  • Tooltip should be centered

Screenshots

Screenshot 2021-06-16 at 17 25 23 Screenshot 2021-06-16 at 17 25 16

Review

<details> <summary>PR commands</summary> <br />

List of available commands:

  • @toptal-bot run all - Run whole pipeline
  • @toptal-bot run build - Check build
  • @toptal-bot run visual - Run visual tests
  • @toptal-bot run deploy:documentation - Deploy documentation
  • @toptal-bot run package:alpha-release - Release alpha version

</details>

+225 -166

0 comment

9 changed files

pr created time in a day

PR opened toptal/granite

Simplify translations scoping for local I18n keys
  • Introduces Granite::Action.i18n_scopes which returns scopes for Action
  • Granite::Controller now also uses i18n_scopes from action but also merges them with projector_name and projector_name.action_name.
  • Granite::Projector delegates translations to view context.
  • Granite::Translations.scope_translation_args now takes a list of scopes and key and joins all scopes with the key.
  • Added more specs for translations

Review

Pre-merge checklist

  • [ ] The PR relates to a single subject with a clear title and description in grammatically correct, complete sentences.
  • [ ] Verify that feature branch is up-to-date with master (if not - rebase it).
  • [ ] Double check the quality of commit messages.
  • [ ] Squash related commits together.
+110 -190

0 comment

16 changed files

pr created time in a day

push eventtoptal/granite

Andrius Chamentauskas

commit sha 514b7a04b444d9400a4706ea9b7fb33fea9de49c

Extract Granite::Util to granite & use it in BasePrecondition (#51)

view details

Andrius Chamentauskas

commit sha 9c206321234f6a999fb585ac2c7a519cfce3f400

Simplify translations scoping for local I18n keys

view details

push time in a day

create barnchtoptal/granite

branch : refactor_translations

created branch time in a day

pull request commenttoptal/picasso

fix(Slider): overlapping labels on range slider

:tada: Last commit is successfully deployed :tada:

Demo is available on:

Your davinci-bot :rocket:

krasai

comment created time in a day

push eventtoptal/picasso

Piotr Krasuski

commit sha 8282a88e89da28c4007043148a0e60fe3e9c6f59

fix: change tooltip placement for range slider

view details

push time in a day

pull request commenttoptal/picasso

fix(picasso-forms): validation on submit

:tada: Last commit is successfully deployed :tada:

Demo is available on:

Your davinci-bot :rocket:

hweeTan

comment created time in a day

Pull request review commenttoptal/picasso

fix(picasso-forms): validation on submit

 const getValidationErrors = (   formValues: any,   form: FormApi<any> ): SubmissionErrors | void => {-  let errors: SubmissionErrors+  let errors: SubmissionErrors = {}

Yup, my bad. I just pushed the fix. Thanks

hweeTan

comment created time in a day

push eventtoptal/picasso

Tran Tan Huy

commit sha 089a422ce201077d89932e485401d290d62d5267

fix: onSubmit not calling when there is no error

view details

push time in a day

Pull request review commenttoptal/picasso

fix(picasso-forms): validation on submit

 const getValidationErrors = (   formValues: any,   form: FormApi<any> ): SubmissionErrors | void => {-  let errors: SubmissionErrors+  let errors: SubmissionErrors = {}

wouldn't it makes an impact on https://github.com/toptal/picasso/pull/2101/files#diff-db61986b77e5fb9711e3f36a3b93e93aff4a7f69bdb492d2ebf78b42ccc2e778R118 ?

hweeTan

comment created time in a day