profile
viewpoint

VictoriaMetrics/helm-charts 40

Helm charts for VictoriaMetrics

percona/pmm-agent 20

pmm-agent for PMM 2.x.

percona/pmm-admin 9

pmm-admin for PMM 2.x.

f41gh7/vcd-csi 2

virtual cloud director Container Storage Interface for kubernetes

f41gh7/airflow 0

Apache Airflow

f41gh7/awesome-operators 0

A resource tracking a number of Operators out in the wild.

f41gh7/calico 0

Cloud native connectivity and network policy

f41gh7/ci_hkd 0

ci/cd deploy image with helm, kubectl, docker,docker-compose,ansible

f41gh7/community-operators 0

The canonical source for Kubernetes Operators that appear on OperatorHub.io, OpenShift Container Platform and OKD.

f41gh7/confd 0

Manage Calico BGP configuration files using templates and data from the Calico datastore

push eventpercona/pmm-managed

Alexey Palazhchenko

commit sha 7cf021a4768a54771e38534c45188cbf80627a74

Drop the default value for push_metrics (#545) * Drop the default value for push_metrics * Fix tests

view details

Alexey Palazhchenko

commit sha 85459abc452472c051f1070374d89dba2073c9be

PMM-6909 Rename IA table (#546)

view details

Nurlan Moldomurov

commit sha fe65690017da7163344be552ba1846f614aa1053

Merge branch 'PMM-2.0' into PMM-6863-cleanup-db-cluster-objects

view details

push time in 3 hours

Pull request review commentpercona/pmm-managed

PMM-6909 Rule templates API

+package models++import (+	"database/sql/driver"+	"time"++	"github.com/percona-platform/saas/pkg/common"+	"gopkg.in/reform.v1"+)++//go:generate reform++//reform:ia_templates

🚫 [golangci-lint] <sub>reported by reviewdog :dog:</sub><br>comment on exported type Template should be of the form "Template ..." (with optional leading article) (golint)

artemgavrilov

comment created time in 13 hours

push eventpercona/pmm-managed

Alexey Palazhchenko

commit sha d772df635211fe3198bc3a13bf99ceb3bf8cebc3

PMM-6909 Rename table

view details

push time in 13 hours

push eventPercona-Lab/pmm-submodules

PMM Jenkins

commit sha a76bc9d71a790a43704346e16cbaf18da6e7d474

rewind submodules

view details

push time in 13 hours

push eventpercona/pmm-managed

Alexey Palazhchenko

commit sha 85459abc452472c051f1070374d89dba2073c9be

PMM-6909 Rename IA table (#546)

view details

Alexey Palazhchenko

commit sha 6fca2f6860726be804881302020fbb9cbf811914

Merge branch 'PMM-2.0' into PMM-6909-rule-template-api

view details

push time in 13 hours

push eventpercona/pmm-managed

Alexey Palazhchenko

commit sha 85459abc452472c051f1070374d89dba2073c9be

PMM-6909 Rename IA table (#546)

view details

push time in 13 hours

delete branch percona/pmm-managed

delete branch : PMM-6909-rename-tables

delete time in 13 hours

PR merged percona/pmm-managed

Reviewers
PMM-6909 Rename IA table
+6 -6

0 comment

3 changed files

AlekSi

pr closed time in 13 hours

PR opened percona/pmm-managed

PMM-6909 Rename IA table
+6 -6

0 comment

3 changed files

pr created time in 13 hours

create barnchpercona/pmm-managed

branch : PMM-6909-rename-tables

created branch time in 13 hours

Pull request review commentpercona/pmm-managed

PMM-6969 rules api model

+// pmm-managed+// Copyright (C) 2017 Percona LLC+//+// This program is free software: you can redistribute it and/or modify+// it under the terms of the GNU Affero General Public License as published by+// the Free Software Foundation, either version 3 of the License, or+// (at your option) any later version.+//+// This program is distributed in the hope that it will be useful,+// but WITHOUT ANY WARRANTY; without even the implied warranty of+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the+// GNU Affero General Public License for more details.+//+// You should have received a copy of the GNU Affero General Public License+// along with this program. If not, see <https://www.gnu.org/licenses/>.++package models++import (+	"time"++	"github.com/percona/pmm/api/managementpb"+	iav1beta1 "github.com/percona/pmm/api/managementpb/ia"+)++//go:generate reform++// TODO merge alertRule and Rule++// alertRule represents an IA rule to be stored in the database.+//reform:alert_rules+type alertRule struct {+	Template     *[]byte   `reform:"template"`+	ID           string    `reform:"id,pk"`+	Summary      string    `reform:"summary"`+	Disabled     bool      `reform:"disabled"`+	Params       *[]byte   `reform:"params"`+	For          string    `reform:"for"`+	Severity     string    `reform:"severity"`+	CustomLabels *[]byte   `reform:"custom_labels"`+	Filters      *[]byte   `reform:"filters"`+	Channels     *[]byte   `reform:"channels"`+	CreatedAt    time.Time `reform:"created_at"`+	UpdatedAt    time.Time `reform:"updated_at"`+}++// Rule represents alertRule configuration.+type Rule struct {

🚫 [golangci-lint] <sub>reported by reviewdog :dog:</sub><br>struct of size 192 bytes could be of size 184 bytes (maligned)

palash25

comment created time in 14 hours

Pull request review commentpercona/pmm-managed

PMM-6969 rules api model

+// pmm-managed+// Copyright (C) 2017 Percona LLC+//+// This program is free software: you can redistribute it and/or modify+// it under the terms of the GNU Affero General Public License as published by+// the Free Software Foundation, either version 3 of the License, or+// (at your option) any later version.+//+// This program is distributed in the hope that it will be useful,+// but WITHOUT ANY WARRANTY; without even the implied warranty of+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the+// GNU Affero General Public License for more details.+//+// You should have received a copy of the GNU Affero General Public License+// along with this program. If not, see <https://www.gnu.org/licenses/>.++package models++import (+	"encoding/json"+	"time"++	"github.com/golang/protobuf/ptypes"+	iav1beta1 "github.com/percona/pmm/api/managementpb/ia"+	"github.com/pkg/errors"+	"google.golang.org/grpc/codes"+	"google.golang.org/grpc/status"+	reform "gopkg.in/reform.v1"+)++// SaveRule persists alert rule.+func SaveRule(q *reform.Querier, r *Rule) error {+	if err := ValidateRule(r); err != nil {+		return err+	}++	nc, err := ruleToAlertRule(r)+	if err != nil {+		return err+	}++	err = q.Insert(nc)+	if err != nil {+		return errors.Wrap(err, "failed to create alert rule")+	}++	return nil+}++// UpdateRule updates existing alert rule.+func UpdateRule(q *reform.Querier, r *Rule) error {

🚫 [golangci-lint] <sub>reported by reviewdog :dog:</sub><br>func UpdateRule is unused (unused)

palash25

comment created time in 14 hours

Pull request review commentpercona/pmm-managed

PMM-6969 rules api model

+// pmm-managed+// Copyright (C) 2017 Percona LLC+//+// This program is free software: you can redistribute it and/or modify+// it under the terms of the GNU Affero General Public License as published by+// the Free Software Foundation, either version 3 of the License, or+// (at your option) any later version.+//+// This program is distributed in the hope that it will be useful,+// but WITHOUT ANY WARRANTY; without even the implied warranty of+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the+// GNU Affero General Public License for more details.+//+// You should have received a copy of the GNU Affero General Public License+// along with this program. If not, see <https://www.gnu.org/licenses/>.++package models++import (+	"encoding/json"+	"time"++	"github.com/golang/protobuf/ptypes"+	iav1beta1 "github.com/percona/pmm/api/managementpb/ia"+	"github.com/pkg/errors"+	"google.golang.org/grpc/codes"+	"google.golang.org/grpc/status"+	reform "gopkg.in/reform.v1"+)++// SaveRule persists alert rule.+func SaveRule(q *reform.Querier, r *Rule) error {+	if err := ValidateRule(r); err != nil {+		return err+	}++	nc, err := ruleToAlertRule(r)+	if err != nil {+		return err+	}++	err = q.Insert(nc)+	if err != nil {+		return errors.Wrap(err, "failed to create alert rule")+	}++	return nil+}++// UpdateRule updates existing alert rule.+func UpdateRule(q *reform.Querier, r *Rule) error {+	if err := ValidateRule(r); err != nil {+		return errors.Wrap(err, "channel validation failed")+	}++	nc, err := ruleToAlertRule(r)+	if err != nil {+		return err+	}++	err = q.Update(nc)+	if err != nil {+		return errors.Wrap(err, "failed to create alert rule")+	}++	return nil+}++// RemoveRule removes alert rule with specified id.+func RemoveRule(q *reform.Querier, id string) error {

🚫 [golangci-lint] <sub>reported by reviewdog :dog:</sub><br>func RemoveRule is unused (unused)

palash25

comment created time in 14 hours

Pull request review commentpercona/pmm-managed

PMM-6969 rules api model

+// pmm-managed+// Copyright (C) 2017 Percona LLC+//+// This program is free software: you can redistribute it and/or modify+// it under the terms of the GNU Affero General Public License as published by+// the Free Software Foundation, either version 3 of the License, or+// (at your option) any later version.+//+// This program is distributed in the hope that it will be useful,+// but WITHOUT ANY WARRANTY; without even the implied warranty of+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the+// GNU Affero General Public License for more details.+//+// You should have received a copy of the GNU Affero General Public License+// along with this program. If not, see <https://www.gnu.org/licenses/>.++package ia++import "github.com/percona/pmm-managed/models"++// aletringService is a subset of methods of ia.Service used by this package.+// We use it instead of real type for testing and to avoid dependency cycle.+type aletringService interface {

🚫 [golangci-lint] <sub>reported by reviewdog :dog:</sub><br>aletringService is unused (deadcode)

palash25

comment created time in 14 hours

Pull request review commentpercona/pmm-managed

PMM-6969 rules api model

+// pmm-managed+// Copyright (C) 2017 Percona LLC+//+// This program is free software: you can redistribute it and/or modify+// it under the terms of the GNU Affero General Public License as published by+// the Free Software Foundation, either version 3 of the License, or+// (at your option) any later version.+//+// This program is distributed in the hope that it will be useful,+// but WITHOUT ANY WARRANTY; without even the implied warranty of+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the+// GNU Affero General Public License for more details.+//+// You should have received a copy of the GNU Affero General Public License+// along with this program. If not, see <https://www.gnu.org/licenses/>.++package models++import (+	"time"++	"github.com/percona/pmm/api/managementpb"+	iav1beta1 "github.com/percona/pmm/api/managementpb/ia"+)++//go:generate reform++// TODO merge alertRule and Rule++// alertRule represents an IA rule to be stored in the database.+//reform:alert_rules+type alertRule struct {+	Template     *[]byte   `reform:"template"`+	ID           string    `reform:"id,pk"`+	Summary      string    `reform:"summary"`+	Disabled     bool      `reform:"disabled"`+	Params       *[]byte   `reform:"params"`+	For          string    `reform:"for"`+	Severity     string    `reform:"severity"`+	CustomLabels *[]byte   `reform:"custom_labels"`+	Filters      *[]byte   `reform:"filters"`+	Channels     *[]byte   `reform:"channels"`+	CreatedAt    time.Time `reform:"created_at"`+	UpdatedAt    time.Time `reform:"updated_at"`+}++// Rule represents alertRule configuration.+type Rule struct {+	Template     *iav1beta1.Template    `json:"template"`+	ID           string                 `json:"id"`+	Summary      string                 `json:"summary"`+	Disabled     bool                   `json:"disabled"`+	Params       []*iav1beta1.RuleParam `json:"params"`+	For          time.Duration          `json:"for"`+	Severity     managementpb.Severity  `json:"severity"`+	CustomLabels map[string]string      `json:"custom_labels"`+	Filters      []*Filter              `json:"filters"`+	Channels     []*iav1beta1.Channel   `json:"channels"`+	CreatedAt    time.Time              `json:"created_at"`+	UpdatedAt    time.Time              `json:"updated_at"`+}++// TODO BeforeInsert, BeforeUpdate, AfterFind

🚫 [golangci-lint] <sub>reported by reviewdog :dog:</sub><br>models/rule.go:63: Line contains TODO/BUG/FIXME: "TODO BeforeInsert, BeforeUpdate, AfterFi..." (godox)

palash25

comment created time in 14 hours

Pull request review commentpercona/pmm-managed

PMM-6969 rules api model

+// pmm-managed+// Copyright (C) 2017 Percona LLC+//+// This program is free software: you can redistribute it and/or modify+// it under the terms of the GNU Affero General Public License as published by+// the Free Software Foundation, either version 3 of the License, or+// (at your option) any later version.+//+// This program is distributed in the hope that it will be useful,+// but WITHOUT ANY WARRANTY; without even the implied warranty of+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the+// GNU Affero General Public License for more details.+//+// You should have received a copy of the GNU Affero General Public License+// along with this program. If not, see <https://www.gnu.org/licenses/>.++package models++import (+	"time"++	"github.com/percona/pmm/api/managementpb"+	iav1beta1 "github.com/percona/pmm/api/managementpb/ia"+)++//go:generate reform++// TODO merge alertRule and Rule

🚫 [golangci-lint] <sub>reported by reviewdog :dog:</sub><br>models/rule.go:28: Line contains TODO/BUG/FIXME: "TODO merge alertRule and Rule" (godox)

palash25

comment created time in 14 hours

push eventpercona/pmm-managed

Alexey Palazhchenko

commit sha 7cf021a4768a54771e38534c45188cbf80627a74

Drop the default value for push_metrics (#545) * Drop the default value for push_metrics * Fix tests

view details

Alexey Palazhchenko

commit sha 7113f2dd40f821b2dc9d12cc1bb3f2ce8b6a311a

Merge branch 'PMM-2.0' into makefile-fix

view details

push time in 14 hours

push eventpercona/pmm-managed

JiriCtvrtka

commit sha d7bd47a3e97e09a0d1109b77df033231bff811e6

PMM-7026 Revert for PT MySQL summary. (#537) * PMM-7026 One more revert. * PMM-7026 Deps.

view details

Nikolay

commit sha 5c346555a062ad79000a35f2b474eec461966f0f

PMM-6921 VMAgent changes for old versions (#530) * PMM-6921 changes vmAgent creation flow, now it adds, when client autheticates at pmm-server, vmagent creation for pmm-server is disabled * adds validation for metrics_mode for old pmm-agents, changes validation for alerting rules, now it checked with vmalert * adds warning message, removing vmagent after client downgrade, disabling push_metrics for old agents * adds transaction for pmm-agent register, adds warn message to victoriametrics scrape config check * adds scrape config validation with vmdb Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@percona.com>

view details

Artem Gavrilov

commit sha 521511832f77cd2047c3c4ef01b54f3b595e87ba

PMM-6968 Notification channels API (#532) * PMM-6968 Add notificaion channel models and DB related methods * PMM-6968 Implement notification channels API * PMM-6968 Add missing license headers * Hit CI * PMM-6968 Linter fixes * PMM-6968 Enable notifications rest API * PMM-6968 Add PageDuty support * PMM-6968 Add validation error type * PMM-6968 Add missing license header * PMM-6968 Refactor errors * PMM-6869 Refactor persistent layer for notification channels * PMM-6869 Remove debug code, reformat * PMM-6968 Fix typo * PMM-6968 Refactoring * PMM-6968 Refactoring * PMM-6968 Fix validation, add test cases * PMM-6968 Update pmm dep, refactoring * PMM-6968 Fix ListChannels * PMM-6968 Fix transactions * PMM-6968 Refactoring * PMM-6968 Return channel in response of AddChannel * PMM-6968 Refactoring * PMM-6968 Add test case * PMM-6968 Update API * PMM-6968 Refactoring (#540) * PMM-6968 Pass DB to services * PMM-6968 Remove IA service * PMM-6968 Refactor * PMM-6968 Refactoring * PMM-6968 Refactoring * PMM-6968 Fix CI * PMM-6968 Avoid copy&pasting JSON type * PMM-6968 Remove TODOs * PMM-6968 Always use transactions * PMM-6968 Avoid renaming package * PMM-6968 Add omitemptys * PMM-6968 Add timestamps Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@percona.com>

view details

Alexey Palazhchenko

commit sha f1ca1f026e3b24c761c6fa69535c29b9eff84f5a

PMM-7024 Vendor go-bindata (#535) Let's vendor it now to reduce the number of merge conflicts later.

view details

Artem Gavrilov

commit sha 13446ee657ded921b337c69943fbb8240172ecd2

SAAS-450 Update to yaml v3 (#518) * Replace yaml.v2 lib with yaml.v3 * SAAS-450 Update promconfig * Drop yaml.v2 remnant Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@percona.com>

view details

Alexey Palazhchenko

commit sha 1b79357f4ef7037243e532c07d3cb8f6ceee7ee4

Merge prometheus package into victoriametrics (#542)

view details

Alexey Palazhchenko

commit sha d249973ed102c42f45b44b682a189af431e99330

Extract vmalert package (#543) * Extract vmalert package * Fix docline

view details

Alexey Palazhchenko

commit sha 7cf021a4768a54771e38534c45188cbf80627a74

Drop the default value for push_metrics (#545) * Drop the default value for push_metrics * Fix tests

view details

Alexey Palazhchenko

commit sha c2bf17497bd4b9b5b386371dd8030e34d90379ca

PMM-6969 Remove ia service

view details

Alexey Palazhchenko

commit sha 4d476a71cc2e92145d139257e9f48b7227dfb15a

Merge branch 'PMM-2.0' into PMM-6969-rules-api # Conflicts: # main.go # models/database.go # services/management/ia/rules_service.go

view details

push time in 14 hours

pull request commentPercona-Lab/pmm-submodules

PMM-6863 Cleanup db cluster objects

server docker - perconalab/pmm-server-fb:PR-1260-799f10c client docker - perconalab/pmm-client-fb:PR-1260-799f10c client - https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm2-client/pmm2-client-PR-1260-799f10c.tar.gz Create Staging Instance: https://pmm.cd.percona.com/job/aws-staging-start/parambuild/?DOCKER_VERSION=perconalab/pmm-server-fb:PR-1260-799f10c&CLIENT_VERSION=https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm2-client/pmm2-client-PR-1260-799f10c.tar.gz

askomorokhov

comment created time in 14 hours

push eventPercona-Lab/pmm-submodules

Andrii Skomorokhov

commit sha 799f10ccf0e6c2e1c548dbefbe6becb767949713

PMM-6863 Up deps.

view details

push time in 15 hours

push eventPercona-Lab/pmm-submodules

PMM Jenkins

commit sha 18adc80a4b61baa94d6e62a80d531648c812f644

rewind submodules

view details

push time in 15 hours

push eventpercona/pmm-managed

Alexey Palazhchenko

commit sha 7cf021a4768a54771e38534c45188cbf80627a74

Drop the default value for push_metrics (#545) * Drop the default value for push_metrics * Fix tests

view details

Alexey Palazhchenko

commit sha e8fa7b19731d68df51c1001430829ef271d2fc62

Merge branch 'PMM-2.0' into PMM-6909-rule-template-api

view details

push time in 15 hours

push eventpercona/pmm-managed

Alexey Palazhchenko

commit sha 7cf021a4768a54771e38534c45188cbf80627a74

Drop the default value for push_metrics (#545) * Drop the default value for push_metrics * Fix tests

view details

push time in 15 hours

delete branch percona/pmm-managed

delete branch : remove-default

delete time in 15 hours

PR merged percona/pmm-managed

Reviewers
Drop the default value for push_metrics
+28 -23

0 comment

2 changed files

AlekSi

pr closed time in 15 hours

push eventpercona/pmm-managed

Alexey Palazhchenko

commit sha 4031203414f20cba9ce2c66f158e761dd1808ddd

Fix tests

view details

push time in 15 hours

PR opened percona/pmm-managed

Drop the default value for push_metrics
+6 -1

0 comment

1 changed file

pr created time in 16 hours

create barnchpercona/pmm-managed

branch : remove-default

created branch time in 16 hours

PR opened VictoriaMetrics/operator

In PrometheusConverter include ownerReferences in created objects

I've noticed that removing a PrometheusRule doesn't make the corresponding VMRule deleted immediately as I've expected. As it seemed easy to code (just adding some ownerReferences) I've decided to have some fun and add it myself. For consistency I've updated other converters as well. Apart from e2e tests I've deployed it on some 'real' cluster and tested PrometheusRule behaviour - worked as expected.

During tests I've encountered that issue with typo in prober discovery so I've fixed it as well.

Can such a feature be added? I haven't found any related information in documentation or discussion in issues (although I haven't searched a lot).

I'm not sure if this should be enabled by default. From my point of view it should, but I imagine it might break someone else's deployment (someone might, even unconsciously, rely on the fact that converted objects persist after original ones are removed). I can add some EnablePrometheusConverterOwnerReferences setting to the configuration and pass it down to converters.

+283 -77

0 comment

4 changed files

pr created time in a day

PR opened percona/pmm-managed

PMM-6874 Add template rule converter

PMM-XXXX

  • [ ] Build: https://github.com/Percona-Lab/pmm-submodules/pull/0

  • [ ] Links to other linked pull requests (optional).


  • [ ] Tests passed.
  • [ ] Feature build pass.
  • [ ] (Re)requested review.
  • [ ] Fix conflicts with target branch.
  • [ ] Update API dependency.
  • [ ] Update jira ticket description if needed.
  • [ ] Attach screenshots/console output to confirm new behavior to jira ticket, if applicable.
+173 -0

0 comment

2 changed files

pr created time in a day

more