profile
viewpoint

evilpie/add-custom-search-engine 49

Add a custom search engine to the list of available search engines in Firefox

dherman/tc39-codex-wiki 48

New and improved TC39 wiki, built with codex

evilpie/crafting-rust-interpreters 28

Interpreter written in rust mainly based on http://www.craftinginterpreters.com/

evilpie/404-bookmarks 9

Firefox extension to find and remove expired bookmarks.

evilpie/filepath 2

Get the filesystem path of a file

evilpie/coffee-script 1

Unfancy JavaScript

evilpie/compat-table 1

ECMAScript 5 compatibility table

evilpie/disasmx86.js 1

A simple x86 disassembler in JavaScript

evilpie/domesday 1

Domesday is a FLOSS tool that can be used by a community to create a directory of members.

issue commentmozilla-mobile/fenix

[Bug] "Save to collection" button in tabs tray too bright in dark mode

I tried to figure out how to make that change myself, but I didn't really get far. I think I might need to add a new <style> to styles.xml for this specific button, but I don't really understand how it selects which color to use. I am not necessarily interested in learning Android development. @ekager would you consider just doing this instead?

evilpie

comment created time in 2 days

push eventevilpie/add-custom-search-engine

d-a10

commit sha 9d30aa76ed93a9f394cddb1d4a91420154f87327

Update search.html It doesn't necessarily have to say this but the way it's currently written suggests you're introducing something new when you're really just finishing the process. I was confused by this and thought the plugin had lost functionality and found others online with the same issue. Alternately it could say "1 more step! Adding the new search engine via the URL bar"

view details

d-a10

commit sha 1946376882908724124468af3c7778de0ea44892

updated message

view details

Tom Schuster

commit sha 2d883969960c8c7732e340c6434f4e7e0f9afe29

Merge pull request #27 from d-a10/patch-1 Update search.html

view details

push time in 5 days

PR merged evilpie/add-custom-search-engine

Update search.html

It doesn't necessarily have to say this but the way it's currently written suggests you're introducing something new when you're really just finishing the process. I was confused by this and thought the plugin had lost functionality and found others online with the same issue.

Alternately it could say "1 more step! Adding the new search engine via the URL bar"

+1 -1

2 comments

1 changed file

d-a10

pr closed time in 5 days

pull request commentmdn/browser-compat-data

Mark HTMLInputElement.p.moz* methods non-standard

These methods are marked as [ChromeOnly] so they should probably be marked as removed for Firefox as well. https://searchfox.org/mozilla-central/source/dom/webidl/HTMLInputElement.webidl#157

sideshowbarker

comment created time in 5 days

push eventevilpie/RustPython

Tom Schuster

commit sha 9f24797bc8f16ef98e418549f1dd6782c80a4840

basic loop support

view details

push time in 11 days

pull request commentRustPython/RustPython

Basic block support in JIT

I decided to add basic loop support. We really only needed to handle the case where multiple jump instructions point to the same target, as well as targets before the jump.

evilpie

comment created time in 11 days

push eventevilpie/RustPython

Kangzhi Shi

commit sha 21a9e05abcc6263c812852dc139f697de28b4c96

Reimplement bytes fromhex

view details

Kangzhi Shi

commit sha d14b0cf93baa408038c5efda85ef04b144421e8b

bytes fromhex CPython compatible

view details

Jeong YunWon

commit sha ba82e31c8d093a71d14ff8dbafbaa0c9dbdd6cc4

cargo update

view details

Noah

commit sha 5ffabb404f3237ad15cd2a58f0e727f665c7fdaa

Merge pull request #2282 from qingshi163/dev2 Reimplement bytes fromhex

view details

Noah

commit sha 61ded76298e0607ef89ded94b651b2bda4a306f1

Merge pull request #2286 from youknowone/cargo-update cargo update

view details

Jeong YunWon

commit sha 19ed4f85e72b665abd74b13c05f6b7b49ae9f78a

clean up vm::builtins

view details

Jeong YunWon

commit sha e823d95ce53105e4176c1f1c08e4e8196de6214d

split vm::builtins::iter utility functions to vm::iterator

view details

Jeong YunWon

commit sha 5a2e9a065e3f1708a07183215f3fe5f40222cf07

Merge pull request #2285 from youknowone/builtins Clean up vm::builtins

view details

Kangzhi Shi

commit sha c3484c612c7a94ea272e382fe2f9412deabc6c8f

fix buffer resizable non-thread safe

view details

Kangzhi Shi

commit sha c2d46b9df31c979abf0e32afee0f464abcf12dee

remove comment

view details

Kangzhi Shi

commit sha 64f4282edeb251b503f0f22bb3c4ead26220f205

fix error type

view details

Jeong YunWon

commit sha fc0c8e331d9f7e0ad32cab4ea0a57d081bb01396

Merge pull request #2288 from qingshi163/dev5 fix buffer resizable non-thread safe

view details

Tom Schuster

commit sha 023bf6c3ba82e131dbf5bbef2463676eeb94a81d

Basic block support in JIT

view details

Tom Schuster

commit sha 80d168cc745cb6317f3580e440d2e1892034f1f3

Implement Unary minus/plus

view details

Tom Schuster

commit sha abf5ab467b4398849c0ca060d2efedef686e2f73

implement bool conversion for float

view details

Tom Schuster

commit sha 70b05cf620d911a5dcac3db024c8920810badc7a

bool support

view details

Tom Schuster

commit sha 682107ce818521d580e8c16c6a0e445ee6eebc08

factor out LoadConst

view details

Tom Schuster

commit sha d8875cb660220c9359ae6e91805c20c45b3b6513

constant boolean

view details

Tom Schuster

commit sha 7b345d060c2683b58669a0779af7398018c2b616

Add bool tests

view details

Tom Schuster

commit sha c4d4432666664ed18e1f78122f015aeda8c77e52

JumpIfTrue

view details

push time in 11 days

issue commentRustPython/RustPython

Running `cargot test` under `jit` leads to error

I am using cargo test --features jit -p rustpython-jit at the top level instead.

jviereck

comment created time in 12 days

pull request commentRustPython/RustPython

Basic block support in JIT

I'm wondering: If the current bytecode format proves to be too limiting, would it not make sense to just... change it? (Easy for me to say since I wouldn't be the one implementing those changes in the VM).

I guess we will have to see. I haven't really thought about how to replace these conditional pop instructions yet. Considering how relatively simple the actual interpreter loop is, changing the bytecode might be the simplest way forward.

RustPython is relatively young so backwards compatibility with pre-compiled bytecode is probably not a concern. That's one thing RustPython can do but CPython can't. With that in mind, I think it would make sense to have a byte code format specifically designed to be easy to JIT compile.

:+1:

Regarding JIT, perhaps some lessons can be learned from Julia, especially in the use of type inference and optional type annotations to generate better code. We know the return values of all built-ins, so even just type inference without any other type annotations should be helpful. Furthermore, in Julia, if an any (unannotated) value is bound to a type-annotated variable, a runtime type-check is made to assert that the value is compatible. Any further uses of that variable generate better code. Perhaps we could use the optional Python type annotations in a similar way? Would this require changes in the bytecode (to e.g. encode type information differently)?

As someone with many years of experience working on a JavaScript VM I am skeptical of type inference for dynamic languages. Of course the trade-offs are probably different and typical JS code is different from Python and again different from Julia as well. There is a big difference between having most variables type annotated and untyped Python code. I think which one to optimize for is going to have a rather large impact.

Anyway I am probably not going to pursue any of these things deeply. I am mostly interested in experimenting with cranelift and typed annotated code is definitely a lot easier to work with.

evilpie

comment created time in 15 days

issue commentnt1m/livemarks

Hide links already read

Version 3.0 is now live

hyde-stevenson

comment created time in 16 days

startedtc39/proposal-item-method

started time in 16 days

issue commentmozilla-mobile/fenix

Can't bypass TLS 1.0/1.1 error as in Desktop

This still seems to be happening: https://www.reddit.com/r/firefox/comments/j9qsxt/pressing_the_bottom_2_buttons_does_nothing_have/

Can also use https://tls-v1-0.badssl.com:1010/ for testing.

julienw

comment created time in 16 days

push eventevilpie/RustPython

Tom Schuster

commit sha 863e185df8ac1a9077818443b960a52c202c4665

bool support

view details

Tom Schuster

commit sha 78fdeedfa8703d88761a9a9bb01b1aca5b7bdcc1

factor out LoadConst

view details

Tom Schuster

commit sha f22f3a0843945b428e126eb1342312c4597572b1

constant boolean

view details

Tom Schuster

commit sha cda61b42c955a63794f86e6c76e846843e0adf11

Add bool tests

view details

Tom Schuster

commit sha bade10dd2c18f5046df7fbe40f955caa8103c3b4

JumpIfTrue

view details

Tom Schuster

commit sha f8cb2524b0b9a922f498299b6037fa4db87c15cf

cargo fmt

view details

push time in 16 days

pull request commentRustPython/RustPython

Basic block support in JIT

Rebased. Please let me know if you need some changes before this can be merged. I don't want to fork too much.

evilpie

comment created time in 16 days

push eventevilpie/RustPython

Jeong YunWon

commit sha 0a8f1e14a87120a4813e3eae38af26a7d0c1cfdc

TypeProcotol::class() -> TypeProtocol::clone_class()

view details

Jeong YunWon

commit sha a089c9b6d3b0f390144d508389db7ea318e4c431

TypeProcotol::lease_class() -> TypeProtocol::class()

view details

Jeong YunWon

commit sha 68c907d9a2a3a2862a163ee5a00e122640962c29

Merge pull request #2274 from youknowone/clone-class TypeProtocol::lease_class() as default class()

view details

Jeong YunWon

commit sha 83f6dd70602a20afb2d6a411ccd2d69587a1b13c

PyFuncArgs from Args

view details

Jeong YunWon

commit sha 4640be4c0d2b857a6ea67b58a290bc44be865286

PyFuncArgs Kwargs defaults to IndexMap

view details

Jeong YunWon

commit sha 597b7bd098535e58d045c7f3ec5c362f732ee3be

PyFuncArgs::{new, with_kwargs_names}

view details

Jeong YunWon

commit sha 0d7738c7082b58bc9bc1505df949b0581673d2ac

PyFuncArgs from rust tuple

view details

Jeong YunWon

commit sha b0445396f4d284a1deb89ab441cb97fee6f22ccf

compactize invoke args

view details

Jeong YunWon

commit sha 4da1b62c18e73130a31fe3451ac6d5af971c6f09

PyFuncArgs -> FuncArgs which does not represent a single python object

view details

Jeong YunWon

commit sha 708da5790bf7d6f5ad2ea1cae1b95aed51d4f64c

Merge pull request #2250 from youknowone/funcargs PyFuncArgs from rust tuple

view details

Steve Shi

commit sha 2d9b1d06494096f10bcb49bf1db42c0de1a5810c

Implement bytes.hex() with optional sep

view details

Jeong YunWon

commit sha 13bde3d7b479dad8e83d29c532cd38f6ab5e6cce

vm::obj -> vm::builtins (broken)

view details

Jeong YunWon

commit sha 9e6dfca9e90f8011e647a4a29b7e8b01fce5738b

Fix build with new builtins path

view details

Kangzhi Shi

commit sha a3243da0d62adebce32b9ca58511ad7266c36630

test_bytes remove @skip for successed test

view details

Noah

commit sha 9142bfb9b5e0568e1b851b4be3715706983a973c

Merge pull request #2283 from qingshi163/dev3 test_bytes remove @skip for successed test

view details

Jeong YunWon

commit sha ca9326f95da5e412768e46729b7ade0568f76dea

expose bulitins items on builtins module and hide submodules

view details

Jeong YunWon

commit sha b2c0a69386ce1da2ddbb32360baf065eae0d812f

Merge pull request #2281 from youknowone/builtins vm::obj -> vm::builtins and expose types right under builtins rather than each objxxx submodules

view details

Tom Schuster

commit sha 7d106ef1190ed7475958e523b4e3c710498b14e9

Basic block support in JIT

view details

Tom Schuster

commit sha a2256602de7f3d035de91ba7c1056ef7a7064677

Implement Unary minus/plus

view details

Tom Schuster

commit sha 458c92b2900909a3d6e0742a51fe7004a27ac7f0

implement bool conversion for float

view details

push time in 16 days

push eventnt1m/livemarks

transifex-integration[bot]

commit sha ac7c08fe68b286ab1a2235f2b741906f07ff6e31

Translate /_locales/en/messages.json in zh_TW (#278) translation completed for the source file '/_locales/en/messages.json' on the 'zh_TW' language. Co-authored-by: transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com>

view details

push time in 17 days

PR merged nt1m/livemarks

Translate '/_locales/en/messages.json' in 'zh_TW'

The translations for the following file are now complete:

Parameter Value
Source file '/_locales/en/messages.json'
Translation file '_locales/zh_TW/messages.json'
Language code 'zh_TW'
Transifex project slug livemarks
Transifex resource slug messages-json--master
Transifex event translation_completed
+0 -0

0 comment

0 changed file

transifex-integration[bot]

pr closed time in 17 days

issue closednt1m/livemarks

Should livemarks use the sidebar api ?

If the sidebarAction api is used, livemarks will not be in the "Recently Bookmarked" folder nor in the suggestions of the research bar. It may also use custom icons instead of a prefix for the pages read etc.

closed time in 17 days

baloone

issue commentnt1m/livemarks

Should livemarks use the sidebar api ?

No. There are various other RSS extensions for Firefox that could this. We specifically want to replace live bookmarks, which were/are special kind of bookmarks.

baloone

comment created time in 17 days

create barnchevilpie/RustPython

branch : loop

created branch time in 17 days

push eventevilpie/RustPython

Tom Schuster

commit sha 71af539fe5d7403df1fd9c1a5d2b9b5a12a6f972

bool support

view details

Tom Schuster

commit sha f53ab3f257b0aa68194330e11eb031e20fd6b4f8

factor out LoadConst

view details

Tom Schuster

commit sha 94b0d9b73adc5d6ba1dd2855514a489a4a809486

constant boolean

view details

Tom Schuster

commit sha 65b0939ae7d69ed08062547e3976b51e505181f3

Add bool tests

view details

Tom Schuster

commit sha 27a856631d3a1c3f3fbb069d9254b2e45596aff8

JumpIfTrue

view details

Tom Schuster

commit sha 260406635874b3ca37e347516aa259195b8a6214

cargo fmt

view details

push time in 17 days

push eventevilpie/RustPython

Tom Schuster

commit sha 62d9e03b2d51c7f2aad1c5caa395156e888e6291

JumpIfTrue

view details

Tom Schuster

commit sha 8bac9a567741a759c01ed6121f262a4a75ca8521

cargo fmt

view details

push time in 17 days

push eventevilpie/RustPython

Tom Schuster

commit sha 2087638302ddd7ead0a734fda254a31f3faad66e

bool support

view details

Tom Schuster

commit sha 65839720f991e11fdeacd92303283edd82e44405

factor out LoadConst

view details

Tom Schuster

commit sha 5b5ef16039d763a65561cc1fdbaf98dd62561950

constant boolean

view details

Tom Schuster

commit sha df919c18078779251b2ad0a17f689b88231eb598

Add bool tests

view details

push time in 17 days

fork evilpie/simplejit-demo

JIT compiler and runtime for a toy language, using Cranelift

fork in 17 days

push eventevilpie/RustPython

Tom Schuster

commit sha ba7e5028e6221f825a15ca8ec777d7ced0d0fadc

implement bool conversion for float

view details

push time in 18 days

push eventevilpie/RustPython

Tom Schuster

commit sha 1fde4d14fe8a9dcbc07c295c86ba014e15e348a8

Implement Unary minus/plus

view details

push time in 18 days

pull request commentRustPython/RustPython

Basic block support in JIT

I am not sure yet how well this approach will hold up, but it's a start.

The bytecode format has a number of things that make it a bit annoying to compile.

  • A ReturnValue instruction inside an if is still followed by a Jump that will never be executed
  • I am not sure yet how we would even handle JumpIfFalseOrPop, we basically would need two different virtual stacks to emulate the maybe popping behavior.
evilpie

comment created time in 18 days

push eventevilpie/RustPython

Tom Schuster

commit sha 3c6d996ba642588554c972b53c3a0a27bfb3e645

Basic block support in JIT

view details

push time in 18 days

issue closedRustPython/RustPython

Compile error when running jit tests

I am trying to run the jit tests. For that I went into the jit directory and ran cargo test. I get the following compilation error:

error[E0599]: no method named `insert` found for struct `std::collections::HashMap<(std::string::String, std::vec::Vec<syn::Attribute>), proc_macro2::TokenStream>` in the current scope
  --> derive/src/util.rs:30:40
   |
30 |         if let Some(existing) = self.0.insert((name, cfgs), tokens) {
   |                                        ^^^^^^ method not found in `std::collections::HashMap<(std::string::String, std::vec::Vec<syn::Attribute>), proc_macro2::TokenStream>`
   |
   = note: the method `insert` exists but the following trait bounds were not satisfied:
           `(std::string::String, std::vec::Vec<syn::Attribute>): std::cmp::Eq`
           `(std::string::String, std::vec::Vec<syn::Attribute>): std::hash::Hash`

error[E0599]: no method named `entry` found for struct `std::collections::HashMap<(std::string::String, std::vec::Vec<syn::Attribute>), (std::option::Option<proc_macro2::Ident>, std::option::Option<proc_macro2::Ident>)>` in the current scope
   --> derive/src/pyclass.rs:464:30
    |
464 |         let entry = self.map.entry((name.clone(), cfgs)).or_default();
    |                              ^^^^^ method not found in `std::collections::HashMap<(std::string::String, std::vec::Vec<syn::Attribute>), (std::option::Option<proc_macro2::Ident>, std::option::Option<proc_macro2::Ident>)>`
    |
    = note: the method `entry` exists but the following trait bounds were not satisfied:
            `(std::string::String, std::vec::Vec<syn::Attribute>): std::cmp::Eq`
            `(std::string::String, std::vec::Vec<syn::Attribute>): std::hash::Hash`

error: aborting due to 2 previous errors

For more information about this error, try `rustc --explain E0599`.
error: could not compile `rustpython-derive`.

To learn more, run the command again with --verbose.

I don't see any issue when building RustPython with cargo build --features jit.

rustc 1.47.0 (18bf6b4f0 2020-10-07)

closed time in 18 days

evilpie

issue commentRustPython/RustPython

Compile error when running jit tests

Ah cargo test --verbose --features jit -p rustpython-jit works

evilpie

comment created time in 18 days

push eventevilpie/RustPython

Tom Schuster

commit sha f7f1b96398f9277fa2a1123c859adc1393f21b63

Basic block support in JIT

view details

push time in 18 days

issue openedRustPython/RustPython

Compile error when running jit tests

I am trying to run the jit tests. For that I went into the jit directory and ran cargo test. I get the following compilation error:

error[E0599]: no method named `insert` found for struct `std::collections::HashMap<(std::string::String, std::vec::Vec<syn::Attribute>), proc_macro2::TokenStream>` in the current scope
  --> derive/src/util.rs:30:40
   |
30 |         if let Some(existing) = self.0.insert((name, cfgs), tokens) {
   |                                        ^^^^^^ method not found in `std::collections::HashMap<(std::string::String, std::vec::Vec<syn::Attribute>), proc_macro2::TokenStream>`
   |
   = note: the method `insert` exists but the following trait bounds were not satisfied:
           `(std::string::String, std::vec::Vec<syn::Attribute>): std::cmp::Eq`
           `(std::string::String, std::vec::Vec<syn::Attribute>): std::hash::Hash`

error[E0599]: no method named `entry` found for struct `std::collections::HashMap<(std::string::String, std::vec::Vec<syn::Attribute>), (std::option::Option<proc_macro2::Ident>, std::option::Option<proc_macro2::Ident>)>` in the current scope
   --> derive/src/pyclass.rs:464:30
    |
464 |         let entry = self.map.entry((name.clone(), cfgs)).or_default();
    |                              ^^^^^ method not found in `std::collections::HashMap<(std::string::String, std::vec::Vec<syn::Attribute>), (std::option::Option<proc_macro2::Ident>, std::option::Option<proc_macro2::Ident>)>`
    |
    = note: the method `entry` exists but the following trait bounds were not satisfied:
            `(std::string::String, std::vec::Vec<syn::Attribute>): std::cmp::Eq`
            `(std::string::String, std::vec::Vec<syn::Attribute>): std::hash::Hash`

error: aborting due to 2 previous errors

For more information about this error, try `rustc --explain E0599`.
error: could not compile `rustpython-derive`.

To learn more, run the command again with --verbose.

I don't see any issue when building RustPython with cargo build --features jit.

rustc 1.47.0 (18bf6b4f0 2020-10-07)

created time in 18 days

create barnchevilpie/RustPython

branch : basic_block

created branch time in 18 days

PR opened RustPython/RustPython

Basic block support in JIT
+155 -13

0 comment

6 changed files

pr created time in 18 days

startedbytecodealliance/wasmtime

started time in 19 days

issue commentnt1m/livemarks

Hide links already read

#242 added an option to open all unread links via the context menu.

hyde-stevenson

comment created time in 19 days

issue closednt1m/livemarks

eslint does not run

Using https://github.com/nt1m/livemarks/commit/3f28bca05c12853171f269afb3bb16e36842f5a2 and running

npm run lint

produces

/home/tom/projects/livemarks/.eslintrc.js 1:1 error 'module' is not defined no-undef

not sure why it's trying to lint its own configuration file.

closed time in 19 days

evilpie

issue commentnt1m/livemarks

eslint does not run

https://github.com/nt1m/livemarks/commit/fd47524d924b30ec7720fc9f039800b36086b362 fixes this. I don't understand why this suddenly stopped working.

evilpie

comment created time in 19 days

push eventnt1m/livemarks

Tom Schuster

commit sha 00d2115be7528ff22693c33c63c1259e12fc1e3d

Enforce no |var| usage and remove unused debug levels in content script

view details

Tom Schuster

commit sha fd47524d924b30ec7720fc9f039800b36086b362

Fix |npm run lint| and require semicolons

view details

push time in 19 days

push eventnt1m/livemarks

Tom Schuster

commit sha 70cd9cf9eba127bbb1de43902445b3721dd4efa2

Some cleanup on top of #285

view details

push time in 19 days

pull request commentnt1m/livemarks

Add option to open all unread pages in tabs

Thank you!

baloone

comment created time in 19 days

push eventnt1m/livemarks

Mohamed H

commit sha e72eb550a2f2aeb92d59befcb93fa0e162a8dae0

Add option to open all unread pages in tabs (#285)

view details

push time in 19 days

PR merged nt1m/livemarks

Reviewers
Add option to open all unread pages in tabs

I removed the option to mark all pages as read without opening them from my last pull request. I also added a github action to run the linter on every push.

+40 -13

1 comment

3 changed files

baloone

pr closed time in 19 days

issue openedmozilla/readability

Readability is not reliably detected on royalroad.com

For example this page works: https://www.royalroad.com/fiction/34798/melas/chapter/535107/chapter-1-prologue-murdered This one however doesn't: https://www.royalroad.com/fiction/30321/unbound/chapter/563337/chapter-one-hundred-and-three-103

Opening about:reader?url=https://www.royalroad.com/fiction/30321/unbound/chapter/563337/chapter-one-hundred-and-three-103 manually looks fine

Firefox 83.0a1 (Build ID 20201009041754)

created time in 19 days

issue commenttc39/proposal-item-method

Web compatibility issue with Magic360

There is another issue with flickr.com: https://bugzilla.mozilla.org/show_bug.cgi?id=1669867

evilpie

comment created time in 20 days

startedMatthiasSchinzel/sysmon

started time in 20 days

issue commentmozilla-mobile/fenix

[Bug] Downloaded files don't appear anywhere file manager or other apps can work with

Probably a duplicate of #8754. You can try Nightly and see if it is fixed for you.

joshtriplett

comment created time in 21 days

issue openedtc39/proposal-item-method

Web compatibilty issue with Yui2

We just enabled String.prototype.item in Firefox Nightly and broke http://bugzilla.mozilla.org. We are going to backout this patch for that reason.

The problem seems to be in the obsolete Yui2 library: https://github.com/yui/yui2/blob/master/build/dom/dom.js#L789. It now assumes that strings are some kind of array/collections object.

created time in 21 days

Pull request review commentnt1m/livemarks

Add option to open all unread pages in tabs

   "reloadLiveBookmark": {     "message": "Reload Live Bookmark"   },+  "openAllUnreadPages": {+    "message": "Open all unread pages in tabs"

I think maybe we should s/pages/feeds/ or s/page/live bookmarks/.

baloone

comment created time in 22 days

PullRequestReviewEvent

Pull request review commentnt1m/livemarks

Add option to open all unread pages in tabs

 const LivemarkUpdater = {  const ContextMenu = {   async init() {-    const createReloadItem = async () => {+    const getUnreadChildren = async (id) => {+      const p = await Settings.getReadPrefix();+      const feed = [...await browser.bookmarks.getChildren(id)]+        .filter((e,i,arr) => !arr.slice(i).some(e => e.type==="separator"))+        .filter(e => !PrefixUtils.hasPrefix(p, e.title));

Doesn't that mean it won't work for people who have prefixes disabled?

baloone

comment created time in 22 days

PullRequestReviewEvent

Pull request review commentnt1m/livemarks

Add option to open all unread pages in tabs

 const LivemarkUpdater = {  const ContextMenu = {   async init() {-    const createReloadItem = async () => {+    const getUnreadChildren = async (id) => {+      const p = await Settings.getReadPrefix();+      const feed = [...await browser.bookmarks.getChildren(id)]

I think instead of this complicated filter expression you could use code like here: https://github.com/nt1m/livemarks/blob/0e7d1ecdc6e71e79e7707d8ef0ef86f3c818ba59/background/background.js#L150

baloone

comment created time in 22 days

PullRequestReviewEvent

pull request commentnt1m/livemarks

Add option to open all unread pages in tabs

Thanks for the pull request! Can you please remove the unrelated workflow and lint changes from the commit. There are also various cases where you aren't following the local coding style, especially in regards to spaces.

baloone

comment created time in 22 days

issue closednt1m/livemarks

Livemarks fails to load this feed: https://www.cnews.cz/hardware/feed/

I tried to use this feed https://www.cnews.cz/hardware/feed/ in Livemarks, but Livemarks fails to load it. It is strange because in the past it worked.

Thank you in advance for your attention.

closed time in a month

klopcz

issue commentnt1m/livemarks

Livemarks fails to load this feed: https://www.cnews.cz/hardware/feed/

The XML of this feed is invalid.

XML Parsing Error: prefix not bound to a namespace Location: https://www.cnews.cz/hardware/feed/ Line Number 47, Column 3:

It's using <media:thumbnail ..>, but the rss tag is missing xmlns:media like <rss version="2.0" xmlns:media="http://search.yahoo.com/mrss/">. (https://www.rssboard.org/media-rss)

klopcz

comment created time in a month

issue closedevilpie/add-custom-search-engine

Custom search engine is not available in FF Top Sites

I added a custom search engine using this add-on. It shows up properly in preference and search bar. My purpose is to add this search engine to FF Top Sites. But when I click the "Add Search Engine" menu located at its upper right corner, the custom search engine doesn't appear in the selection list. Any idea what's wrong?

This is with the latest version of FF (81.0) on ubuntu. Not sure if it's a bug with the add-on or FF Top Sites. Restarting FF doesn't help. Thanks for any suggestions.

closed time in a month

rayx

issue commentevilpie/add-custom-search-engine

Custom search engine is not available in FF Top Sites

Ah thanks, I had never noticed this dialog before. I just tested this myself and it doesn't show up there for me either, even for search engines that show up in the search bar otherwise. I suggest you report a bug to Mozilla.

rayx

comment created time in a month

issue openednt1m/livemarks

eslint does not run

Using https://github.com/nt1m/livemarks/commit/3f28bca05c12853171f269afb3bb16e36842f5a2 and running

npm run lint

produces

/home/tom/projects/livemarks/.eslintrc.js 1:1 error 'module' is not defined no-undef

not sure why it's trying to lint its own configuration file.

created time in a month

push eventnt1m/livemarks

renovate[bot]

commit sha 3f28bca05c12853171f269afb3bb16e36842f5a2

Update dependency eslint-plugin-mozilla to v2.8.0 (#262) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

push time in a month

PR merged nt1m/livemarks

Update dependency eslint-plugin-mozilla to v2.8.0

This PR contains the following updates:

Package Type Update Change
eslint-plugin-mozilla (source) dependencies minor 2.7.0 -> 2.8.0

Renovate configuration

:date: Schedule: At any time (no schedule defined).

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

+1 -1

0 comment

1 changed file

renovate[bot]

pr closed time in a month

pull request commentevilpie/add-custom-search-engine

Update search.html

Thanks for the pull request. I didn't realize that this message could confusing. And sorry for not responding sooner, I don't check github notifications regularly.

I think

Lastly, add the new search engine via the URL bar as a big text is maybe a bit ugly.

Maybe we could do something like

Almost done just two more steps

  1. Open the "Page actions" menu
  2. Click "Add Search Engine"
d-a10

comment created time in a month

push eventnt1m/livemarks

renovate[bot]

commit sha ab8fa930dad7ea89e82396560aa18923c8c8dfa5

Update dependency eslint-plugin-no-unsanitized to v3.1.3 (#281) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

push time in a month

PR merged nt1m/livemarks

Update dependency eslint-plugin-no-unsanitized to v3.1.3

This PR contains the following updates:

Package Type Update Change
eslint-plugin-no-unsanitized dependencies patch 3.1.2 -> 3.1.3

Release Notes

<details> <summary>mozilla/eslint-plugin-no-unsanitized</summary>

v3.1.3

Compare Source

</details>


Renovate configuration

:date: Schedule: At any time (no schedule defined).

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

+1 -1

0 comment

1 changed file

renovate[bot]

pr closed time in a month

issue commentevilpie/add-custom-search-engine

Custom search engine is not available in FF Top Sites

the custom search engine doesn't appear in the selection list.

What does that mean exactly? Maybe you could provide some screenshots? The search bar on about:newtab uses your default search engine.

rayx

comment created time in a month

issue openedtc39/proposal-item-method

Web compatibilty issue with Magic360

We have had the item method on Arrays in Firefox Nightly and just found our first web compatibility issue with the Magic 360 library: https://www.magictoolbox.com/magic360/examples/

https://bugzilla.mozilla.org/show_bug.cgi?id=1668342

created time in a month

push eventevilpie/cacheir-tools

Tom Schuster

commit sha 22ff7a1a9a3e30fc3689ce387820cef0e0ceb639

Add python tool to split up Ion logs The normal ion log JSON files can become too big for iongraph to handle.

view details

push time in a month

issue commentmozilla-mobile/fenix

[Bug] Cannot complete request on twitter

Probably just the Fenix version of https://bugzilla.mozilla.org/show_bug.cgi?id=1665368

andreicristianpetcu

comment created time in a month

issue commentmozilla-mobile/fenix

[Bug] Adding search provider shows "Error connecting to X"

I suspect so. I tried querying runnaroo.com with wget. This failed with 403 forbidden, unless I set an explicit User-Agent header.

Does the fetch for the search engine validation use the normal Firefox user agent string?

TyDraniu

comment created time in a month

pull request commentmdn/browser-compat-data

Update <iframe sandbox=allow-downloads> for Firefox and Chrome

Rebased on top #6696 and added Firefox for Android. Please merge

evilpie

comment created time in a month

push eventevilpie/browser-compat-data

Queen Vinyl Darkscratch

commit sha f2bd98a7fa8abad593b09b55e6cefbb3c1396a6e

Set IE to false for all ServiceWorker-specific APIs (#6673)

view details

Oriol Brufau

commit sha 5da7ab5b42cd9b667b0f7dd2a9fb56cb9d0e2d28

CSS ::marker animations and transitions not supported in WebKit (#6677) WebKit implemented an earlier version of the spec which didn't include animations and transitions. See https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/style/PropertyCascade.cpp#L73

view details

Kristóf Poduszló

commit sha d9f061ad615891ba461a57e4f884489fd44e3725

fix(css): alternative names for `column-gap` (#6579)

view details

Queen Vinyl Darkscratch

commit sha af4fb4307e0812ba51ed9cb9c9277f4a749f59a1

mdn-bcd-collector: set null -> false for APIs for IE (#6675)

view details

Ru Singh

commit sha 21c1b2a10351d141abd4ac6b951a7cc8f716a111

datalist doesn't work starting Firefox for Android v67 (#6685) * datalist doesn't work starting Firefox for Android v67 * up to v80 stable as of this proposal * also affects v81 beta (but left out of proposal as we should track only stable releases) * bug is being tracker here - https://bugzilla.mozilla.org/show_bug.cgi?id=1535985 * shorten url as per test check * reword note and specify correct version for regression Co-authored-by: Queen Vinyl Darkscratch <vinyldarkscratch@gmail.com> Co-authored-by: Queen Vinyl Darkscratch <vinyldarkscratch@gmail.com>

view details

Kristóf Poduszló

commit sha e29192ea81fb30cea24892944b168ba1b95abb5a

fix(css): unprefix content size values for Safari (#6657)

view details

Raphael Kubo da Costa

commit sha c7d7bd9a85a1f7bd1c3ea8ebd4f560d44b6cde3d

Update Edge browser data. (#6693) Edge 85 was promoted to the stable channel in August: https://docs.microsoft.com/en-us/deployedge/microsoft-edge-relnote-stable-channel#version-85056441-august-27 Version 86 is in the beta channel and the canary channel has Edge 87.

view details

Raphael Kubo da Costa

commit sha cebfcde32778ff0bac76f0105dea13a8e639c7c1

Add release information for WakeLockSentinel.released (#6694) This was added to the spec in [1], and to Blink in [2], which is present since Chromium 87. [1] https://github.com/w3c/screen-wake-lock/pull/279 [2] https://chromium-review.googlesource.com/c/chromium/src/+/2379740

view details

dependabot-preview[bot]

commit sha 43dd43bc5f4eb0310dc973b1cab2abc1dfd938d6

Bump ajv from 6.12.4 to 6.12.5 (#6678) Bumps [ajv](https://github.com/ajv-validator/ajv) from 6.12.4 to 6.12.5. - [Release notes](https://github.com/ajv-validator/ajv/releases) - [Commits](https://github.com/ajv-validator/ajv/compare/v6.12.4...v6.12.5) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

Anton

commit sha 5caf7f0dd109fe3069945a57d24e9e247ab70d35

Firerfox Android supports replaceAll (#6676)

view details

Philip Jägenstedt

commit sha 420f16b16e525bb016f053a35973343f52b5fd9c

Fix the names of the IE11 fullscreen events (#6684) While the event handler attributes are all-lowercase, even event types are not. Tested with this code: ```html <!doctype html> <button>go fullscreen</button> <pre></pre> <script> var button = document.querySelector('button'); button.onclick = function() { document.body.msRequestFullscreen(); } var pre = document.querySelector("pre"); document.addEventListener("MSFullscreenChange", function (event) { pre.textContent = event.type; }); </script> ``` Using "msfullscreenchange" as the event type doesn't work there. This reverts part of https://github.com/mdn/browser-compat-data/pull/6511.

view details

Daniel D. Beck

commit sha b81487b43b190fc56cf4b58d24c0f1128d09f14f

Add Firefox for Android 81 (#6696)

view details

Tom Schuster

commit sha 38a434440217ed6c916a399acc338f1d9bda5718

Fixes #6667 <iframe sandbox=allow-downloads> I manually tested in Firefox 82 and Chrome 85, but used the following references for 81 and 83 respectively. https://bugzilla.mozilla.org/show_bug.cgi?id=1558394 https://www.chromestatus.com/feature/5706745674465280

view details

push time in a month

push eventnt1m/livemarks

renovate[bot]

commit sha 3bcd19669d089969c2621320bd337c1732a83bb6

Update dependency eslint to v7.9.0 (#274) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

push time in 2 months

PR merged nt1m/livemarks

Update dependency eslint to v7.9.0

This PR contains the following updates:

Package Type Update Change
eslint (source) dependencies minor 7.7.0 -> 7.9.0

Release Notes

<details> <summary>eslint/eslint</summary>

v7.9.0

Compare Source

  • 3ca2700 Fix: Corrected notice for invalid (:) plugin names (#​13473) (Josh Goldberg)
  • fc5783d Docs: Fix leaky anchors in v4 migration page (#​13635) (Timo Tijhof)
  • f1d07f1 Docs: Provide install commands for Yarn (#​13661) (Nikita Baksalyar)
  • 29d1cdc Fix: prefer-destructuring removes comments (refs #​13678) (#​13682) (Milos Djermanovic)
  • b4da0a7 Docs: fix typo in working with plugins docs (#​13683) (啸生)
  • 6f87db7 Update: fix id-length false negatives on Object.prototype property names (#​13670) (Milos Djermanovic)
  • 361ac4d Fix: NonOctalDecimalIntegerLiteral is decimal integer (fixes #​13588) (#​13664) (Milos Djermanovic)
  • f260716 Docs: update outdated link (#​13677) (klkhan)
  • 5138c91 Docs: add missing eslint directive comments in no-await-in-loop (#​13673) (Milos Djermanovic)
  • 17b58b5 Docs: clarify correct example in no-return-await (fixes #​13656) (#​13657) (Milos Djermanovic)
  • 9171f0a Chore: fix typo (#​13660) (Nitin Kumar)
  • 6d9f8fb Sponsors: Sync README with website (ESLint Jenkins)
  • 97b0dd9 Sponsors: Sync README with website (ESLint Jenkins)
  • deab125 Sponsors: Sync README with website (ESLint Jenkins)
  • bf2e367 Sponsors: Sync README with website (ESLint Jenkins)
  • 8929208 Sponsors: Sync README with website (ESLint Jenkins)

v7.8.1

Compare Source

v7.8.0

Compare Source

</details>


Renovate configuration

:date: Schedule: At any time (no schedule defined).

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

+1 -1

0 comment

1 changed file

renovate[bot]

pr closed time in 2 months

pull request commentmdn/browser-compat-data

Fixes #6667 <iframe sandbox=allow-downloads>

Btw. The lint doesn't accept Firefox for Android version 81: html.elements.iframe.sandbox-allow-downloads - version_added: "81" is NOT a valid version number for firefox_android

evilpie

comment created time in 2 months

PR opened mdn/browser-compat-data

Fixes #6667 <iframe sandbox=allow-downloads>

I manually tested in Firefox 82 and Chrome 85, but used the following references for 81 and 83 respectively.

https://bugzilla.mozilla.org/show_bug.cgi?id=1558394 https://www.chromestatus.com/feature/5706745674465280

+48 -0

0 comment

1 changed file

pr created time in 2 months

create barnchevilpie/browser-compat-data

branch : allow-downloads

created branch time in 2 months

issue closednt1m/livemarks

Livemarks don't work in Firefox 79.0

I beg your pardon for my inexperience, it's my first time in GitHub I'm a simple user and I want to report a bug as stated in extension management

This extension worked (Great!) in previous versions of Firefox, but with the update to Firefox 79.0 it no more works. I tried on 2 different PCs, Windows 7 32-bit and Windows 10 64-bit, and the behaviour is the same: with the extension already installed, go to the page containing the RSS (e.g. https://www.ansa.it/sito/notizie/topnews/topnews_rss.xml ), appears the page to add the Live bookmark:

moz-extension://dcfe3de4-7c70-40bc-b851-7de9703fcbd6/pages/subscribe/subscribe.html?https%3A%2F%2Fwww.ansa.it%2Fsito%2Fnotizie%2Ftopnews%2Ftopnews_rss.xml

click on the Add button and the live bookmark is well functioning. It works very well until you restart the browser. After the restart of Firefox the extension no more works: it is simply a bookmark, containing links to the pages that there were before of restarting the browser. No ability of refresh, and not even the refresh icon contained in the bookmark window. If you re-add the live bookmark (a new bookmark is created) the working is the same: the new-added bookmark works, the old-added bookmark don't work. Restarting the browser, both (new-added and old-added) are no working. And so on. Until the upgrade to Firefox 79.0 the extension worked great in both PCs (w7 and w10)

Add-on version Add-on version: 2.8

Describe the bug A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior A clear and concise description of what you expected to happen.

Extra context Any extra context you may have about the bug (feed URLs, screenshots, etc.)

closed time in 2 months

SandroYZ

issue openedmdn/browser-compat-data

sandbox=allow-downloads

Document <iframe sandbox=allow-downloads>. I will open a PR later, but I can't provide accurate data for anything non-Firefox.

https://bugzilla.mozilla.org/show_bug.cgi?id=1558394 https://www.chromestatus.com/feature/5706745674465280

created time in 2 months

issue commentmozilla-mobile/fenix

[Bug] downloaded media files are not indexed to MediaStorage

Is there a list of affected devices? It seems to be a common complaint on reddit: (sample from the last few days)

  • https://www.reddit.com/r/firefox/comments/inhm77/android_v801_downloaded_images_dont_imediately/
  • https://www.reddit.com/r/firefox/comments/imkufg/wherere_my_downloads/
  • https://www.reddit.com/r/firefox/comments/imnoww/where_are_my_downloads_android/
  • https://www.reddit.com/r/firefox/comments/inzeho/image_downloads_in_firefox_android_arent_showing/
  • https://www.reddit.com/r/firefox/comments/inuifd/issue_with_downloading_videos_with_firefox_for/
djdisodo

comment created time in 2 months

push eventnt1m/livemarks

transifex-integration[bot]

commit sha e4205b691e95a6f08b0dbadf398486780783e35e

Translate /_locales/en/messages.json in pl (#275) translation completed for the source file '/_locales/en/messages.json' on the 'pl' language. Co-authored-by: transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com>

view details

push time in 2 months

PR merged nt1m/livemarks

Translate '/_locales/en/messages.json' in 'pl'

The translations for the following file are now complete:

Parameter Value
Source file '/_locales/en/messages.json'
Translation file '_locales/pl/messages.json'
Language code 'pl'
Transifex project slug livemarks
Transifex resource slug messages-json--master
Transifex event translation_completed
+0 -0

1 comment

0 changed file

transifex-integration[bot]

pr closed time in 2 months

PullRequestEvent

PR closed nt1m/livemarks

Translate '/_locales/en/messages.json' in 'pl'

The translations for the following file are now complete:

Parameter Value
Source file '/_locales/en/messages.json'
Translation file '_locales/pl/messages.json'
Language code 'pl'
Transifex project slug livemarks
Transifex resource slug messages-json--master
Transifex event translation_completed
+0 -0

1 comment

0 changed file

transifex-integration[bot]

pr closed time in 2 months

pull request commentnt1m/livemarks

Translate '/_locales/en/messages.json' in 'pl'

I don't understand why this bot keeps submitting empty pull requests.

transifex-integration[bot]

comment created time in 2 months

issue commentmozilla-mobile/fenix

"Copy link" for non-http url image link

Duplicate and fixed in Nightly.

ffftwo

comment created time in 2 months

issue commentmozilla-mobile/fenix

[Bug] Unable to copy magnet links

Should have been fixed by https://github.com/mozilla-mobile/android-components/issues/8297 by @rocketsroger. :+1:

lokesh-krishna

comment created time in 2 months

push eventevilpie/cacheir-tools

Tom Schuster

commit sha 48c373c75ac5b635704e8a3defa07a599868ff5e

Better truncation

view details

push time in 2 months

issue commentmozilla-mobile/fenix

[Bug]today nighlty still crashing a lot

Duplicate of #14624 / https://bugzilla.mozilla.org/show_bug.cgi?id=1662830

ale82to

comment created time in 2 months

push eventevilpie/browser-compat-data

Tom Schuster

commit sha eaeda5aabe789f41e611d439e97ec3af35e92865

Update tabs.json

view details

push time in 2 months

PR opened mdn/browser-compat-data

Reviewers
tabs.saveAsPDF() is now supported on maOS

https://bugzilla.mozilla.org/show_bug.cgi?id=1653354#c7

A checklist to help your pull request get merged faster:

  • [ ] Summarize your changes
  • [ ] Data: link to resources that verify support information (such as browser's docs, changelogs, source control, bug trackers, and tests)
  • [ ] Data: if you tested something, describe how you tested with details like browser and version
  • [ ] Review the results of the linter and fix problems reported (If you need help, please ask in a comment!)
  • [ ] Link to related issues or pull requests, if any
+10 -4

0 comment

1 changed file

pr created time in 2 months

push eventevilpie/browser-compat-data

Tom Schuster

commit sha 0df51b88ebcde26cb1459c4d42796605d3f53dc5

tabs.saveAsPDF() is now supported on maOS https://bugzilla.mozilla.org/show_bug.cgi?id=1653354#c7

view details

push time in 2 months

issue commentmozilla-mobile/fenix

[Bug] Revoked certificate from badSSL is accepted when it should be rejected

I was looking at this: https://crt.sh/?id=1988442812. I don't actually know how to query OneCRL directly.

kbrosnan

comment created time in 2 months

issue commentmozilla-mobile/fenix

[Bug] Revoked certificate from badSSL is accepted when it should be rejected

From my understanding no mobile browser does OCSP checking because of the connection overhead. I am however not sure why this domain is not in OneCRL, which we hopefully support on mobile. I think @april might know.

kbrosnan

comment created time in 2 months

push eventnt1m/livemarks

transifex-integration[bot]

commit sha dd2365b5b251305e058365631efe6a0552046cd5

Translate /_locales/en/messages.json in de (#273) translation completed for the source file '/_locales/en/messages.json' on the 'de' language. Co-authored-by: transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com>

view details

push time in 2 months

PR merged nt1m/livemarks

Translate '/_locales/en/messages.json' in 'de'

The translations for the following file are now complete:

Parameter Value
Source file '/_locales/en/messages.json'
Translation file '_locales/de/messages.json'
Language code 'de'
Transifex project slug livemarks
Transifex resource slug messages-json--master
Transifex event translation_completed
+6 -6

1 comment

1 changed file

transifex-integration[bot]

pr closed time in 2 months

push eventevilpie/amazon-mediasession

Tom Schuster

commit sha 2cc648000ad406bd19f076c8cd3c92a083e3203e

new version

view details

push time in 2 months

push eventevilpie/amazon-mediasession

Tom Schuster

commit sha 6410b990e783949dbe4025aec03e558f808a827b

artwork support

view details

push time in 2 months

more