profile
viewpoint

push eventevenstensberg/lecture-notes

evenstensberg

commit sha 4f96d74ae63ce591a0e21a9507d67a4ace1695b6

chore: 😇

view details

push time in 12 hours

push eventevenstensberg/evenstensberg

evenstensberg

commit sha 16787e3caf4f738c54d41749b56c28263c969ba4

chore: me trying to be normal

view details

push time in 19 hours

push eventevenstensberg/lecture-notes

evenstensberg

commit sha 9dbd723c9690fb85e641220175edd507813d49d6

chore: do stuff

view details

push time in a day

push eventwebpack/webpack-cli

jamesgeorge007

commit sha dc3a5e64fd94a26338f7ba1bc36fc100ddbb4f9d

fix: typo fix version-multi-args-test

view details

Even Stensberg

commit sha 4b9a78906dddfe2d088695ff0ca0cdf5f2a8b8a5

Merge pull request #1056 from jamesgeorge007/hotfix/fix-typo chore: fix minor typo

view details

push time in 2 days

PR merged webpack/webpack-cli

chore: fix minor typo PR: CI-ok PR: reviewed-approved PR: small

<!-- Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. -->

What kind of change does this PR introduce? typo fix <!-- E.g. a bugfix, feature, refactoring, build related change, etc… -->

Did you add tests for your changes? N/A

If relevant, did you update the documentation? N/A

Summary Fixed minor typo.

<!-- Explain the motivation for making this change. What existing problem does the pull request solve? --> <!-- Try to link to an open issue for more information. -->

Does this PR introduce a breaking change? Nope <!-- If this PR introduces a breaking change, please describe the impact and a migration path for existing applications. -->

Other information N/A

+1 -1

1 comment

1 changed file

jamesgeorge007

pr closed time in 2 days

push eventwebpack/webpack-cli

jamesgeorge007

commit sha 7c273dc3ad786ba4b806ab55ddabc6be19f253dd

feat: minor tweak exec-in-directory test util

view details

Even Stensberg

commit sha 14064e87c14f529ee1554a2d13f59e5146d01b87

Merge pull request #1057 from jamesgeorge007/feat/minor-tweak chore: minor tweak

view details

push time in 2 days

PR merged webpack/webpack-cli

chore: minor tweak PR: CI-ok PR: reviewed-approved PR: small

<!-- Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. -->

What kind of change does this PR introduce? refactoring <!-- E.g. a bugfix, feature, refactoring, build related change, etc… -->

Did you add tests for your changes? Nope

If relevant, did you update the documentation? N/A

Summary Minor tweak to the existing code block.

<!-- Explain the motivation for making this change. What existing problem does the pull request solve? --> <!-- Try to link to an open issue for more information. -->

Does this PR introduce a breaking change? Nope <!-- If this PR introduces a breaking change, please describe the impact and a migration path for existing applications. -->

Other information N/A

+1 -2

1 comment

1 changed file

jamesgeorge007

pr closed time in 2 days

push eventevenstensberg/lecture-notes

evenstensberg

commit sha b9b0f0129a5c01a4df32593665bd0d4e8a7e7827

chore: 2

view details

push time in 3 days

create barnchevenstensberg/lecture-notes

branch : master

created branch time in 3 days

created repositoryevenstensberg/lecture-notes

just notes

created time in 3 days

push eventwebpack/webpack-cli

Hari Krishnan A

commit sha b3dc27e8b9d93221ef57ff013018a532254dc989

feat: Update README.md Included Table of Contents

view details

Even Stensberg

commit sha 6eca706f48a7337eb5dce40578438ea3d4c0db00

Merge pull request #1054 from harikrishnana2021/feat/update-readme Update README.md

view details

push time in 3 days

PR merged webpack/webpack-cli

Update README.md PR: CI-ok PR: reviewed-approved PR: small

Included Table of Contents

<!-- Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. -->

What kind of change does this PR introduce? <!-- E.g. a bugfix, feature, refactoring, build related change, etc… --> feature Did you add tests for your changes? no If relevant, did you update the documentation? yes Summary inserted Table of Contents <!-- Explain the motivation for making this change. What existing problem does the pull request solve? --> <!-- Try to link to an open issue for more information. -->

Does this PR introduce a breaking change? <!-- If this PR introduces a breaking change, please describe the impact and a migration path for existing applications. -->

Other information

+2 -0

3 comments

1 changed file

harikrishnana2021

pr closed time in 3 days

issue commentwebpack/webpack-cli

Using require in config throws "webpack not installed, consider installing it..."

Could you make a repository with reproduction of the issue? @BradWebflex

lirlocker

comment created time in 3 days

pull request commentwebpack/webpack-cli

Support `export default` from configuration files.

We could push a new alpha sure, but not yet

izaakschroeder

comment created time in 3 days

issue commentwebpack/webpack-cli

Add help for core commands

Yep we should do that if invoked with command syntax

anshumanv

comment created time in 3 days

Pull request review commentwebpack/webpack-cli

tests: add tests for entry defaults, try to set better defaults

 class webpackCLI extends GroupHelper {      checkDefaults(groupResult) {         const { options } = groupResult;-        if (!options.entry) {-            this.shouldUseMem = true;+        if(options.entry && options.entry === './index.js') {

We gotta check for index too, but we will treat it as a directory, so if the user supplies index, we will look for the index directory and a filename under that dir. If the filename isn't present, we will set index/bundle.js

evenstensberg

comment created time in 3 days

Pull request review commentwebpack/webpack-cli

tests: add tests for entry defaults, try to set better defaults

  *  Based on: https://github.com/GoogleChrome/lighthouse/blob/master/build/changelog-generator/  */ 'use strict';+/* eslint-disable @typescript-eslint/explicit-function-return-type */

Linter threw here so I don't think so

evenstensberg

comment created time in 3 days

push eventwebpack/webpack-cli

Rishabh Chawla

commit sha dc4c89cfc63e4e9eb8011ab7c27f98ba58c3185c

chore: update console logs to webpack-logs

view details

Even Stensberg

commit sha 82da480915fb011e395948b146453656cb4aec16

Merge pull request #1049 from rishabh3112/chore/update-logs chore: replace console logs with webpack log

view details

push time in 3 days

PR merged webpack/webpack-cli

chore: replace console logs with webpack log PR: CI-ok PR: reviewed-approved PR: small

<!-- Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. -->

What kind of change does this PR introduce? refactoring <!-- E.g. a bugfix, feature, refactoring, build related change, etc… -->

Did you add tests for your changes? No, May need to though If relevant, did you update the documentation? NA Summary use webpack log for displaying error <!-- Explain the motivation for making this change. What existing problem does the pull request solve? --> <!-- Try to link to an open issue for more information. -->

Does this PR introduce a breaking change? No <!-- If this PR introduces a breaking change, please describe the impact and a migration path for existing applications. -->

Other information No

+4 -4

1 comment

1 changed file

rishabh3112

pr closed time in 3 days

push eventwebpack/webpack-cli

Izaak Schroeder

commit sha 0f23d03e6832a8571ed65044a50271f5fe253671

feat: Support `export default` from configuration files. This changes adds a `require` wrapper to the `config` group that allows it to detect and return the default export of ES modules. This is useful when your configuration is a TS(X) file or something that is being transpiled by babel.

view details

Even Stensberg

commit sha 5b084e3dd7a7cab56be4e1acde7c6a2fcc96ad36

Merge pull request #1052 from izaakschroeder/esm-import Support `export default` from configuration files.

view details

push time in 5 days

PR merged webpack/webpack-cli

Support `export default` from configuration files. PR: CI-ok PR: reviewed-approved

What kind of change does this PR introduce?

Feature.

Did you add tests for your changes?

Nope 😢 Tested it locally? Not sure how to add tests or what tests one would like to see.

If relevant, did you update the documentation?

Not necessary hopefully, since I imagine people want ES modules as config files to just work™.

Summary

This changes adds a require wrapper to the config group that allows it to detect and return the default export of ES modules. This is useful when your configuration is a TS(X) file or something that is being transpiled by babel.

Does this PR introduce a breaking change?

Nope!

Other information

If one could possibly publish webpack-cli@4.0.0-alpha-6 with these changes that would be 👌

+11 -3

2 comments

1 changed file

izaakschroeder

pr closed time in 5 days

push eventwebpack/webpack-cli

Even Stensberg

commit sha fa658b8214baa3fa11579dd6218de56437db0650

chore: Update lib/bootstrap.js Co-Authored-By: James George <jamesgeorge998001@gmail.com>

view details

push time in 5 days

PR opened webpack/webpack-cli

tests: add tests for entry defaults, try to set better defaults

What kind of change does this PR introduce? Adds tests for entries, test if ./src/index.js is present and set that default if it exists.

Did you add tests for your changes? Yes bby If relevant, did you update the documentation? N/A Summary Adds tests, improves code

Does this PR introduce a breaking change? N/A Other information

Keep in mind 1 of the cases fails, because we cannot override mixed arguments yet, I'll try to get that to work. For instance:

webpack-cli --entry index.js entry index2.js will fail because we have duplicate keys. Same goes for the opposite scenario or if we have webpack-cli --entry index.js --entry index2.js

in case of using -- twice, we can convert those two into an array, which will be the best case, but for mixed arguments I think we need to decide to override the first key and set a notation that mixing conventions is not encouraged.

+84 -19

0 comment

10 changed files

pr created time in 6 days

create barnchwebpack/webpack-cli

branch : tests/entry-defaults

created branch time in 6 days

issue commentwebpack/webpack-cli

TypeError: Cannot read property 'length' of undefined

Do you have a proposed way of using the schema with the new api? Not getting a message from validating the schema as of:

const validateSchema = require("webpack").validateSchema;
const ValidationError = require("webpack").validate;

const webpackConfigurationValidationErrors = validateSchema(webpackConfigurationSchema, options);
if (webpackConfigurationValidationErrors.length) {
       const error = ValidationError(webpackConfigurationValidationErrors);
        console.error(error.message);
	process.exit(-1);
}
wind4gis

comment created time in 6 days

push eventwebpack/webpack-cli

NoScripter

commit sha 90868f2c83e000ac42f93162e4b3ea2485e9da9a

chore: only output message on error

view details

Even Stensberg

commit sha cb216fc04964e066233dc3b4545f2d9dc1d9f458

Merge pull request #1048 from noscripter/patch-1 chore: only output message on error

view details

push time in 6 days

PR merged webpack/webpack-cli

chore: only output message on error PR: CI-ok PR: reviewed-approved PR: small

<!-- Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. -->

What kind of change does this PR introduce? <!-- E.g. a bugfix, feature, refactoring, build related change, etc… -->

Did you add tests for your changes?

If relevant, did you update the documentation?

Summary

<!-- Explain the motivation for making this change. What existing problem does the pull request solve? --> <!-- Try to link to an open issue for more information. -->

Does this PR introduce a breaking change? <!-- If this PR introduces a breaking change, please describe the impact and a migration path for existing applications. -->

Other information

+1 -1

1 comment

1 changed file

noscripter

pr closed time in 6 days

issue commentwebpack/webpack-cli

TypeError: Cannot read property 'length' of undefined

@sokra can we have that?

wind4gis

comment created time in 7 days

IssuesEvent

issue commentwebpack/webpack-cli

TypeError: Cannot read property 'length' of undefined

yes, options might be null / undefined, so the error is from validating the schema. Do you think you can figure out when the options obj is nil @ryanspice ?

wind4gis

comment created time in 7 days

push eventwebpack/webpack-cli

evenstensberg

commit sha e4c1f6d291ef082e5b0ba7151499877ef62b28c0

tests: fix output test and code

view details

push time in 7 days

issue commentwebpack/webpack-cli

Prettify err in case the supplied flag(s) is/are unknown

Yep we definitely need to do this

anshumanv

comment created time in 7 days

delete branch webpack/webpack-cli

delete branch : tests/entries

delete time in 7 days

push eventwebpack/webpack-cli

evenstensberg

commit sha ddb0cce82bc550da9a335f85380272c7406926a5

misc: fix infra & add failing test

view details

Even Stensberg

commit sha c52001fda95ddff4c796280de68a83db8b4ba267

Merge pull request #1047 from webpack/tests/entries misc: fix infra & add failing test

view details

push time in 7 days

PR merged webpack/webpack-cli

misc: fix infra & add failing test PR: unreviewed

What kind of change does this PR introduce? Fixes upgrade of deps, linting rules are now 💯 , and added a test case for entry point (which now fails). PR is good to merge after code is lgtm.

Did you add tests for your changes? Yea If relevant, did you update the documentation? N/A Summary N/A

Does this PR introduce a breaking change? N/A

Other information

+145 -117

0 comment

19 changed files

evenstensberg

pr closed time in 7 days

delete branch webpack/webpack-cli

delete branch : fix/deps

delete time in 7 days

push eventwebpack/webpack-cli

evenstensberg

commit sha da8fce23894315fc9921c51dfb58d77fbf35e8c9

feat: use jspluginswebpack

view details

evenstensberg

commit sha 38524ec7930b58ba1b03cded85f2e7200a84f44b

chore: rebase

view details

evenstensberg

commit sha b5fcf784829eded844c30be196eb434dd16e8f5e

chore: rebase

view details

Even Stensberg

commit sha 48d84dd1cb46e0aa552594ebed5dcd20dd04b775

Merge pull request #1038 from webpack/fix/deps feat: use JS Webpack Plugin

view details

push time in 7 days

PR merged webpack/webpack-cli

feat: use JS Webpack Plugin PR: reviewed-approved PR: unreviewed

What kind of change does this PR introduce? Feature Did you add tests for your changes? yes If relevant, did you update the documentation? N/A Summary Adds a 0CJS wrapper when no-config is found

Does this PR introduce a breaking change? No

Other information N/A

+967 -112

3 comments

4 changed files

evenstensberg

pr closed time in 7 days

push eventwebpack/webpack-cli

dependabot[bot]

commit sha 29de664f105d46736f06dbab534f7f559545b632

chore(deps): bump lodash in /packages/webpack-scaffold Bumps [lodash](https://github.com/lodash/lodash) from 4.17.11 to 4.17.15. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/compare/4.17.11...4.17.15) Signed-off-by: dependabot[bot] <support@github.com>

view details

dependabot[bot]

commit sha 7fe5fd486843928e5607658c4f5293180500059f

chore(deps): bump lodash from 4.17.11 to 4.17.15 in /packages/utils Bumps [lodash](https://github.com/lodash/lodash) from 4.17.11 to 4.17.15. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/compare/4.17.11...4.17.15) Signed-off-by: dependabot[bot] <support@github.com>

view details

dependabot[bot]

commit sha b3d7013805bfeb7679596748afc317a6376dd99b

chore(deps): bump lodash from 4.17.11 to 4.17.15 in /packages/serve Bumps [lodash](https://github.com/lodash/lodash) from 4.17.11 to 4.17.15. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/compare/4.17.11...4.17.15) Signed-off-by: dependabot[bot] <support@github.com>

view details

dependabot[bot]

commit sha 95146fe8c15fecdd15cb29aeec5b1e30417cc6d6

chore(deps): bump lodash from 4.17.11 to 4.17.15 in /packages/init Bumps [lodash](https://github.com/lodash/lodash) from 4.17.11 to 4.17.15. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/compare/4.17.11...4.17.15) Signed-off-by: dependabot[bot] <support@github.com>

view details

dependabot[bot]

commit sha a8ecb31387a3d090dc455cafc002d6907fd37301

chore(deps): bump lodash in /packages/generate-plugin Bumps [lodash](https://github.com/lodash/lodash) from 4.17.11 to 4.17.15. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/compare/4.17.11...4.17.15) Signed-off-by: dependabot[bot] <support@github.com>

view details

dependabot[bot]

commit sha 87f9e9b8da834e5cf6dfd79c97b7947556db7a29

chore(deps): bump lodash in /packages/generate-loader Bumps [lodash](https://github.com/lodash/lodash) from 4.17.11 to 4.17.15. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/compare/4.17.11...4.17.15) Signed-off-by: dependabot[bot] <support@github.com>

view details

Anshuman Verma

commit sha 1e10979a1ff18d7f177184df2b6780dbf166866c

chore(cli): fix var name to make more sense fix var name

view details

Anshuman Verma

commit sha 94a1ce06ddd150a4ebf6ae54dfb8b4e8767e935d

chore(help): refactor help for more cleaner code refactor help

view details

jamesgeorge007

commit sha 0505d052ec41942efcf0b5f42f4ceed5cd9449d8

feat: refactor

view details

jamesgeorge007

commit sha 76671cb9b6b9e753c7872a31a836bbd69d9c4ce1

fix: use includes instead

view details

Even Stensberg

commit sha ce1ce277db9adc2bec50f8280dd9fc62ee23055b

Merge pull request #1039 from anshumanv/1036 chore(cli): fix var name to correct meaning

view details

Even Stensberg

commit sha b985c8e016177c6b6292e828c1bf1a2a1de95874

Merge pull request #1042 from anshumanv/ref/help chore(help): refactor help for more cleaner code

view details

Even Stensberg

commit sha 0499a22677ade2e7c757c63744af64e463df9d83

Merge pull request #1043 from jamesgeorge007/feat/minor-refactor feat(stats): refactor code

view details

Even Stensberg

commit sha 4ae4cd6f44088145e9e86ff810e13de7a4d600e7

Merge pull request #1034 from webpack/dependabot/npm_and_yarn/packages/generate-loader/lodash-4.17.15 chore(deps): bump lodash from 4.17.11 to 4.17.15 in /packages/generate-loader

view details

Even Stensberg

commit sha bbebe871345f1747d5ff87e30a04719a8006f3f6

Merge pull request #1033 from webpack/dependabot/npm_and_yarn/packages/init/lodash-4.17.15 chore(deps): bump lodash from 4.17.11 to 4.17.15 in /packages/init

view details

Even Stensberg

commit sha 9ec90ff2aee8c84662de28b5af4f8120600dee64

Merge pull request #1031 from webpack/dependabot/npm_and_yarn/packages/serve/lodash-4.17.15 chore(deps): bump lodash from 4.17.11 to 4.17.15 in /packages/serve

view details

Even Stensberg

commit sha 30ef5e2d88fa5d1d380a10d064184edd5951860e

Merge pull request #1032 from webpack/dependabot/npm_and_yarn/packages/generate-plugin/lodash-4.17.15 chore(deps): bump lodash from 4.17.11 to 4.17.15 in /packages/generate-plugin

view details

Even Stensberg

commit sha d8f853c3b1cbf0d3a3c5ff17a05674d275723cce

Merge pull request #1030 from webpack/dependabot/npm_and_yarn/packages/utils/lodash-4.17.15 chore(deps): bump lodash from 4.17.11 to 4.17.15 in /packages/utils

view details

Even Stensberg

commit sha a037d3f172806be62f54c5d2ae3e9ffa93756dd8

Merge pull request #1029 from webpack/dependabot/npm_and_yarn/packages/webpack-scaffold/lodash-4.17.15 chore(deps): bump lodash from 4.17.11 to 4.17.15 in /packages/webpack-scaffold

view details

evenstensberg

commit sha 02d653faba89a3114c715362547864f6b9eb291f

chore: update deps

view details

push time in 7 days

delete branch webpack/webpack-cli

delete branch : tests/entry

delete time in 7 days

PR closed webpack/webpack-cli

[WIP] tests: initial entry test PR: CI-not-ok PR: unreviewed

What kind of change does this PR introduce? tests

Did you add tests for your changes? Yapp If relevant, did you update the documentation? N/A Summary Initial Entry test

Does this PR introduce a breaking change? No

Other information N/A

+2004 -29656

1 comment

34 changed files

evenstensberg

pr closed time in 7 days

PR opened webpack/webpack-cli

misc: fix infra & add failing test

What kind of change does this PR introduce? Fixes upgrade of deps, linting rules are now 💯 , and added a test case for entry point (which now fails). PR is good to merge after code is lgtm.

Did you add tests for your changes? Yea If relevant, did you update the documentation? N/A Summary N/A

Does this PR introduce a breaking change? N/A

Other information

+145 -117

0 comment

19 changed files

pr created time in 7 days

create barnchwebpack/webpack-cli

branch : tests/entries

created branch time in 7 days

push eventwebpack/webpack-cli

evenstensberg

commit sha f8ed0c62cc32d76af7fe0f32d8ebb01639c7e30c

chore: update lockfiles

view details

push time in 7 days

PR closed webpack/webpack-cli

chore(vulns): fix existing vulns in the project PR: conflict PR: reviewed-approved

fix vuln deps Fixes #1044 <!-- Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. -->

What kind of change does this PR introduce? fix vuln deps

Did you add tests for your changes? Yes

If relevant, did you update the documentation? NA

Summary Fix vuln deps, all fixed!

<!-- Explain the motivation for making this change. What existing problem does the pull request solve? --> <!-- Try to link to an open issue for more information. -->

Does this PR introduce a breaking change? No <!-- If this PR introduces a breaking change, please describe the impact and a migration path for existing applications. -->

Other information NA

+212 -304

3 comments

2 changed files

anshumanv

pr closed time in 7 days

pull request commentwebpack/webpack-cli

chore(vulns): fix existing vulns in the project

Had to do a larger update, this is fixed now

anshumanv

comment created time in 7 days

push eventwebpack/webpack-cli

evenstensberg

commit sha 8b75e1c7565bc3b121a45a0f7078b5e0774d5cdf

chore: update deps

view details

push time in 7 days

push eventwebpack/webpack-cli

evenstensberg

commit sha 02d653faba89a3114c715362547864f6b9eb291f

chore: update deps

view details

push time in 7 days

push eventwebpack/webpack-cli

dependabot[bot]

commit sha 29de664f105d46736f06dbab534f7f559545b632

chore(deps): bump lodash in /packages/webpack-scaffold Bumps [lodash](https://github.com/lodash/lodash) from 4.17.11 to 4.17.15. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/compare/4.17.11...4.17.15) Signed-off-by: dependabot[bot] <support@github.com>

view details

Even Stensberg

commit sha a037d3f172806be62f54c5d2ae3e9ffa93756dd8

Merge pull request #1029 from webpack/dependabot/npm_and_yarn/packages/webpack-scaffold/lodash-4.17.15 chore(deps): bump lodash from 4.17.11 to 4.17.15 in /packages/webpack-scaffold

view details

push time in 7 days

delete branch webpack/webpack-cli

delete branch : dependabot/npm_and_yarn/packages/webpack-scaffold/lodash-4.17.15

delete time in 7 days

PR merged webpack/webpack-cli

chore(deps): bump lodash from 4.17.11 to 4.17.15 in /packages/webpack-scaffold PR: CI-ok PR: reviewed-approved PR: small dependencies

⚠️ Dependabot is rebasing this PR ⚠️

If you make any changes to it yourself then they will take precedence over the rebase.


Bumps lodash from 4.17.11 to 4.17.15. <details> <summary>Commits</summary>

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

2 comments

1 changed file

dependabot[bot]

pr closed time in 7 days

push eventwebpack/webpack-cli

dependabot[bot]

commit sha 7fe5fd486843928e5607658c4f5293180500059f

chore(deps): bump lodash from 4.17.11 to 4.17.15 in /packages/utils Bumps [lodash](https://github.com/lodash/lodash) from 4.17.11 to 4.17.15. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/compare/4.17.11...4.17.15) Signed-off-by: dependabot[bot] <support@github.com>

view details

Even Stensberg

commit sha d8f853c3b1cbf0d3a3c5ff17a05674d275723cce

Merge pull request #1030 from webpack/dependabot/npm_and_yarn/packages/utils/lodash-4.17.15 chore(deps): bump lodash from 4.17.11 to 4.17.15 in /packages/utils

view details

push time in 7 days

delete branch webpack/webpack-cli

delete branch : dependabot/npm_and_yarn/packages/utils/lodash-4.17.15

delete time in 7 days

PR merged webpack/webpack-cli

chore(deps): bump lodash from 4.17.11 to 4.17.15 in /packages/utils PR: CI-ok PR: reviewed-approved PR: small dependencies

Bumps lodash from 4.17.11 to 4.17.15. <details> <summary>Commits</summary>

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

2 comments

1 changed file

dependabot[bot]

pr closed time in 7 days

push eventwebpack/webpack-cli

dependabot[bot]

commit sha a8ecb31387a3d090dc455cafc002d6907fd37301

chore(deps): bump lodash in /packages/generate-plugin Bumps [lodash](https://github.com/lodash/lodash) from 4.17.11 to 4.17.15. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/compare/4.17.11...4.17.15) Signed-off-by: dependabot[bot] <support@github.com>

view details

Even Stensberg

commit sha 30ef5e2d88fa5d1d380a10d064184edd5951860e

Merge pull request #1032 from webpack/dependabot/npm_and_yarn/packages/generate-plugin/lodash-4.17.15 chore(deps): bump lodash from 4.17.11 to 4.17.15 in /packages/generate-plugin

view details

push time in 7 days

delete branch webpack/webpack-cli

delete branch : dependabot/npm_and_yarn/packages/generate-plugin/lodash-4.17.15

delete time in 7 days

PR merged webpack/webpack-cli

chore(deps): bump lodash from 4.17.11 to 4.17.15 in /packages/generate-plugin PR: CI-ok PR: reviewed-approved dependencies

Bumps lodash from 4.17.11 to 4.17.15. <details> <summary>Commits</summary>

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+8237 -724

2 comments

1 changed file

dependabot[bot]

pr closed time in 7 days

push eventwebpack/webpack-cli

dependabot[bot]

commit sha b3d7013805bfeb7679596748afc317a6376dd99b

chore(deps): bump lodash from 4.17.11 to 4.17.15 in /packages/serve Bumps [lodash](https://github.com/lodash/lodash) from 4.17.11 to 4.17.15. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/compare/4.17.11...4.17.15) Signed-off-by: dependabot[bot] <support@github.com>

view details

Even Stensberg

commit sha 9ec90ff2aee8c84662de28b5af4f8120600dee64

Merge pull request #1031 from webpack/dependabot/npm_and_yarn/packages/serve/lodash-4.17.15 chore(deps): bump lodash from 4.17.11 to 4.17.15 in /packages/serve

view details

push time in 7 days

delete branch webpack/webpack-cli

delete branch : dependabot/npm_and_yarn/packages/serve/lodash-4.17.15

delete time in 7 days

PR merged webpack/webpack-cli

chore(deps): bump lodash from 4.17.11 to 4.17.15 in /packages/serve PR: CI-ok PR: reviewed-approved dependencies

Bumps lodash from 4.17.11 to 4.17.15. <details> <summary>Commits</summary>

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+6440 -196

2 comments

1 changed file

dependabot[bot]

pr closed time in 7 days

PR merged webpack/webpack-cli

chore(deps): bump lodash from 4.17.11 to 4.17.15 in /packages/init PR: CI-ok PR: reviewed-approved dependencies

Bumps lodash from 4.17.11 to 4.17.15. <details> <summary>Commits</summary>

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+6952 -86

2 comments

1 changed file

dependabot[bot]

pr closed time in 7 days

push eventwebpack/webpack-cli

dependabot[bot]

commit sha 95146fe8c15fecdd15cb29aeec5b1e30417cc6d6

chore(deps): bump lodash from 4.17.11 to 4.17.15 in /packages/init Bumps [lodash](https://github.com/lodash/lodash) from 4.17.11 to 4.17.15. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/compare/4.17.11...4.17.15) Signed-off-by: dependabot[bot] <support@github.com>

view details

Even Stensberg

commit sha bbebe871345f1747d5ff87e30a04719a8006f3f6

Merge pull request #1033 from webpack/dependabot/npm_and_yarn/packages/init/lodash-4.17.15 chore(deps): bump lodash from 4.17.11 to 4.17.15 in /packages/init

view details

push time in 7 days

delete branch webpack/webpack-cli

delete branch : dependabot/npm_and_yarn/packages/init/lodash-4.17.15

delete time in 7 days

delete branch webpack/webpack-cli

delete branch : dependabot/npm_and_yarn/packages/generate-loader/lodash-4.17.15

delete time in 7 days

push eventwebpack/webpack-cli

dependabot[bot]

commit sha 87f9e9b8da834e5cf6dfd79c97b7947556db7a29

chore(deps): bump lodash in /packages/generate-loader Bumps [lodash](https://github.com/lodash/lodash) from 4.17.11 to 4.17.15. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/compare/4.17.11...4.17.15) Signed-off-by: dependabot[bot] <support@github.com>

view details

Even Stensberg

commit sha 4ae4cd6f44088145e9e86ff810e13de7a4d600e7

Merge pull request #1034 from webpack/dependabot/npm_and_yarn/packages/generate-loader/lodash-4.17.15 chore(deps): bump lodash from 4.17.11 to 4.17.15 in /packages/generate-loader

view details

push time in 7 days

PR merged webpack/webpack-cli

chore(deps): bump lodash from 4.17.11 to 4.17.15 in /packages/generate-loader PR: CI-ok PR: reviewed-approved dependencies

Bumps lodash from 4.17.11 to 4.17.15. <details> <summary>Commits</summary>

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+8237 -724

2 comments

1 changed file

dependabot[bot]

pr closed time in 7 days

pull request commentwebpack/webpack-cli

chore(vulns): fix existing vulns in the project

rebae & we're good

anshumanv

comment created time in 7 days

push eventwebpack/webpack-cli

jamesgeorge007

commit sha 0505d052ec41942efcf0b5f42f4ceed5cd9449d8

feat: refactor

view details

jamesgeorge007

commit sha 76671cb9b6b9e753c7872a31a836bbd69d9c4ce1

fix: use includes instead

view details

Even Stensberg

commit sha 0499a22677ade2e7c757c63744af64e463df9d83

Merge pull request #1043 from jamesgeorge007/feat/minor-refactor feat(stats): refactor code

view details

push time in 7 days

PR merged webpack/webpack-cli

feat(stats): refactor code PR: CI-ok PR: reviewed-approved PR: small

<!-- Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. -->

What kind of change does this PR introduce? refactoring <!-- E.g. a bugfix, feature, refactoring, build related change, etc… -->

Did you add tests for your changes? Nope

If relevant, did you update the documentation? N/A

Summary Refactor code resulting in a much concise version.

<!-- Explain the motivation for making this change. What existing problem does the pull request solve? --> <!-- Try to link to an open issue for more information. -->

Does this PR introduce a breaking change? N/A <!-- If this PR introduces a breaking change, please describe the impact and a migration path for existing applications. -->

Other information N/A

+1 -1

1 comment

1 changed file

jamesgeorge007

pr closed time in 7 days

push eventwebpack/webpack-cli

Anshuman Verma

commit sha 94a1ce06ddd150a4ebf6ae54dfb8b4e8767e935d

chore(help): refactor help for more cleaner code refactor help

view details

Even Stensberg

commit sha b985c8e016177c6b6292e828c1bf1a2a1de95874

Merge pull request #1042 from anshumanv/ref/help chore(help): refactor help for more cleaner code

view details

push time in 7 days

PR merged webpack/webpack-cli

chore(help): refactor help for more cleaner code PR: CI-ok PR: reviewed-approved PR: small

refactor help

<!-- Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. -->

What kind of change does this PR introduce? some refactoring to the help class <!-- E.g. a bugfix, feature, refactoring, build related change, etc… -->

Did you add tests for your changes? Yes

If relevant, did you update the documentation? NA

Summary

  • remove unused fns
  • destructured repeated fn to make it more readable

<!-- Explain the motivation for making this change. What existing problem does the pull request solve? --> <!-- Try to link to an open issue for more information. -->

Does this PR introduce a breaking change? No

<!-- If this PR introduces a breaking change, please describe the impact and a migration path for existing applications. -->

Other information

+5 -7

1 comment

1 changed file

anshumanv

pr closed time in 7 days

push eventwebpack/webpack-cli

Anshuman Verma

commit sha 1e10979a1ff18d7f177184df2b6780dbf166866c

chore(cli): fix var name to make more sense fix var name

view details

Even Stensberg

commit sha ce1ce277db9adc2bec50f8280dd9fc62ee23055b

Merge pull request #1039 from anshumanv/1036 chore(cli): fix var name to correct meaning

view details

push time in 7 days

PR merged webpack/webpack-cli

chore(cli): fix var name to correct meaning PR: CI-ok PR: reviewed-approved PR: small

fix var name

<!-- Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. -->

What kind of change does this PR introduce? <!-- E.g. a bugfix, feature, refactoring, build related change, etc… -->

Did you add tests for your changes? yes

If relevant, did you update the documentation? NA

Summary Follow up of - https://github.com/webpack/webpack-cli/pull/1036 Fixed the remaining instances. <!-- Explain the motivation for making this change. What existing problem does the pull request solve? --> <!-- Try to link to an open issue for more information. -->

Does this PR introduce a breaking change? No <!-- If this PR introduces a breaking change, please describe the impact and a migration path for existing applications. -->

Other information NA

+2 -2

1 comment

1 changed file

anshumanv

pr closed time in 7 days

push eventwebpack/webpack-cli

Anshuman Verma

commit sha 68b1bbe8f93685727ef5973b81dbe73e3fe0c3c7

fix(deps): add missing cz-customizable dep to allow committing add missing dep ISSUES CLOSED: #1040

view details

Even Stensberg

commit sha 3fca9cbef03d8e24d1923825a2b3e96736d818a1

Merge pull request #1041 from anshumanv/1040 fix(deps): add missing cz-customizable dep to allow committing

view details

evenstensberg

commit sha 38524ec7930b58ba1b03cded85f2e7200a84f44b

chore: rebase

view details

push time in 7 days

push eventwebpack/webpack-cli

Anshuman Verma

commit sha 68b1bbe8f93685727ef5973b81dbe73e3fe0c3c7

fix(deps): add missing cz-customizable dep to allow committing add missing dep ISSUES CLOSED: #1040

view details

Even Stensberg

commit sha 3fca9cbef03d8e24d1923825a2b3e96736d818a1

Merge pull request #1041 from anshumanv/1040 fix(deps): add missing cz-customizable dep to allow committing

view details

push time in 7 days

PR merged webpack/webpack-cli

fix(deps): add missing cz-customizable dep to allow committing PR: CI-ok PR: reviewed-approved

add missing dep

ISSUES CLOSED: #1040

<!-- Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. -->

What kind of change does this PR introduce? added back the missing dep

Did you add tests for your changes? Yep

If relevant, did you update the documentation? NA

Summary Added the missing dep to commit.

<!-- Explain the motivation for making this change. What existing problem does the pull request solve? --> <!-- Try to link to an open issue for more information. -->

Does this PR introduce a breaking change? No <!-- If this PR introduces a breaking change, please describe the impact and a migration path for existing applications. -->

Other information

+2368 -2401

1 comment

2 changed files

anshumanv

pr closed time in 7 days

issue closedwebpack/webpack-cli

[infra] - cz-customizable is missing in deps but being used

Describe the bug https://github.com/webpack/webpack-cli/blob/da6d76ca214e1f20bab85a34aa353b11d2cd53cb/package.json#L110

We're using the package from node_modules but it's not present in dev deps as it should be.

What is the current behavior? Missing package.

To Reproduce do a fresh clone and try committing

Expected behavior commit needs to go through once the package is installed

Screenshots NA

Please paste the results of webpack-cli info here, and mention other relevant information

Additional context NA

closed time in 7 days

anshumanv

pull request commentwebpack/webpack-cli

feat: use JS Webpack Plugin

Not necessarily the problem we’re trying to solve

evenstensberg

comment created time in 7 days

issue commentwebpack/webpack-cli

[NEXT] Declaring Conventions with Intent

From our slack:

For the init feature, does it make sense to make this a CRA like thing? I'm thinking that people could choose to opt out of webpack, but we wrap it around a plugin like > @jantimon has proposed here: https://github.com/namics/webpack-config-plugins Whereas we can ask in init: Do you want to hide your configuration file as a plugin? And then you can choose to eject through webpack-cli init eject ?

....

This way, we can help the initial user, and we can hide the complexity. The plugin system is preferably what we need to do to reduce maint burden

evenstensberg

comment created time in 7 days

PR opened webpack/webpack-cli

feat: use JS Webpack Plugin

What kind of change does this PR introduce? Feature

Did you add tests for your changes? yes If relevant, did you update the documentation? N/A Summary Adds a 0CJS wrapper when no-config is found

Does this PR introduce a breaking change? No

Other information N/A

+905 -84

0 comment

4 changed files

pr created time in 7 days

create barnchwebpack/webpack-cli

branch : fix/deps

created branch time in 7 days

issue closedwebpack/webpack-cli

TypeError: Cannot read property 'length' of undefined

Describe the bug

A 💯 way to do this is to provide your configuration via a GitHub gist and/or to use markdown when describing which commands you used when the error occurred! Be precise and clear in your description of the bug.

What is the current behavior? when I run webpack --mode development(or production), the webpack-cli shows TypeError: Cannot read property 'length' of undefined on the line node_modules\webpack-cli\bin\cli.js:93. my computer is win10

This is where you elaborate on the current behavior of the cli, how it behaves normally differing from the previous version/build you did.

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

1.just create a folder on win10 2.npm i -S webpack@next 3.npm i -S webpack-cli@latest 4.write "dev": "webpack --mode development" in package.json 5.npm run dev

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem. image

Please paste the results of webpack-cli info here, and mention other relevant information image

Additional context Add any other context about the problem here like linking to an similar issue you might think is the cause.

closed time in 7 days

wind4gis

release webpack/webpack-cli

v3.3.7

released time in 7 days

created tagwebpack/webpack-cli

tagv3.3.7

Webpack's Command Line Interface

created time in 7 days

push eventwebpack/webpack-cli

evenstensberg

commit sha 9487ee52dbb84d63bb9b6c158ced8b458da6289b

chore: v3.3.7

view details

push time in 7 days

push eventwebpack/webpack-cli

evenstensberg

commit sha fb31cc47003c959d2a323cce3ae09678c0d7bb34

fix: resolve opts when no-config

view details

Even Stensberg

commit sha 635bfa33f254426c3751e054aede26321a42335f

chore: lock deps Co-Authored-By: Emanuele <my.burning@gmail.com>

view details

Even Stensberg

commit sha 97d5c75071fd2fecca6555674d911dae40331d52

chore: lock deps Co-Authored-By: Emanuele <my.burning@gmail.com>

view details

evenstensberg

commit sha 43fc03394dbfd65cb742f68374ff9e59b49fc3a9

chore: update lockfile & pass nil

view details

evenstensberg

commit sha 45b9127e520a2ecfa1349b83b077ef762f0a217c

chore: resolve differently

view details

Even Stensberg

commit sha b20ecd3b2edddcc77ee96e70a88e9c9197ec99a1

Merge pull request #1024 from webpack/fix/no-config-mode fix: resolve opts when no-config & fix vulns

view details

push time in 7 days

delete branch webpack/webpack-cli

delete branch : fix/no-config-mode

delete time in 7 days

PR merged webpack/webpack-cli

fix: resolve opts when no-config & fix vulns PR: CI-ok PR: reviewed-approved

What kind of change does this PR introduce? Closes https://github.com/webpack/webpack-cli/issues/1023 Did you add tests for your changes? Yes If relevant, did you update the documentation? N/A Summary Dupes out of resolving options if there are none to throw an error

Does this PR introduce a breaking change? No Other information N/A

+204 -173

2 comments

3 changed files

evenstensberg

pr closed time in 7 days

push eventwebpack/webpack-cli

Rishabh Chawla

commit sha 9792c8183cf8d7628d3e18b09101390a558079ca

chore: update variable to be understandable

view details

Even Stensberg

commit sha da6d76ca214e1f20bab85a34aa353b11d2cd53cb

Merge pull request #1036 from rishabh3112/fix/version-test chore: update version test

view details

push time in 7 days

PR merged webpack/webpack-cli

chore: update version test PR: CI-ok PR: reviewed-approved PR: small

<!-- Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. -->

What kind of change does this PR introduce? refactoring

Did you add tests for your changes? Yes

If relevant, did you update the documentation? No

Summary NA

Does this PR introduce a breaking change? NO

Other information NO

+9 -9

1 comment

2 changed files

rishabh3112

pr closed time in 7 days

PR closed webpack/webpack-cli

chore: give feedback when no config PR: CI-ok PR: reviewed-approved PR: small

What kind of change does this PR introduce? feature

Did you add tests for your changes? No

If relevant, did you update the documentation? No

Summary Give feedback to the user if the config is not found

Does this PR introduce a breaking change? No

Other information NA

+4 -1

2 comments

1 changed file

rishabh3112

pr closed time in 7 days

pull request commentwebpack/webpack-cli

chore: give feedback when no config

I don't think we'll have this in now, but might change later once we're stable

rishabh3112

comment created time in 7 days

PR opened webpack/webpack-cli

[WIP] tests: initial entry test

What kind of change does this PR introduce? tests

Did you add tests for your changes? Yapp If relevant, did you update the documentation? N/A Summary Initial Entry test

Does this PR introduce a breaking change? No

Other information N/A

+47 -18

0 comment

3 changed files

pr created time in 9 days

create barnchwebpack/webpack-cli

branch : tests/entry

created branch time in 9 days

pull request commentwebpack/webpack-cli

tests: add tests for version

PTAL <3

evenstensberg

comment created time in 9 days

push eventwebpack/webpack-cli

evenstensberg

commit sha 9aa330e1d0e2397bf8198b10ca1ee4eebd3cf002

tests: clean up tests

view details

push time in 9 days

Pull request review commentwebpack/webpack-cli

tests: add tests for version

+'use strict';

I was planning to use snapshots for version and help flags, because they are static, will not change much. In hindsight, it might be beneficiary to assert correct versions, yes.

The convention I've used to diff these two are the naming, but they need a more consistent and clear separation, indeed.

Do you have any suggestion for the naming?

evenstensberg

comment created time in 9 days

Pull request review commentwebpack/webpack-cli

tests: add tests for version

 class webpackCLI extends GroupHelper {         const HelpGroup = require('./groups/help');         return new HelpGroup().outputHelp();     }+    async runVersion() {

Was following the async/await convention for each method, will remove

evenstensberg

comment created time in 9 days

Pull request review commentwebpack/webpack-cli

fix: resolve opts when no-config & fix vulns

 module.exports = function(...args) { 	}  	if (!configFileLoaded) {-		return processConfiguredOptions({});+		return processConfiguredOptions(null); 	} else if (options.length === 1) { 		return processConfiguredOptions(options[0]); 	} else { 		return processConfiguredOptions(options); 	}  	function processConfiguredOptions(options) {-		const webpackConfigurationValidationErrors = validateSchema(webpackConfigurationSchema, options);-		if (webpackConfigurationValidationErrors.length) {-			const error = new WebpackOptionsValidationError(webpackConfigurationValidationErrors);-			console.error(error.message, `\nReceived: ${typeof options} : ${JSON.stringify(options, null, 2)}`);-			process.exit(-1); // eslint-disable-line+		if (options) {+			const webpackConfigurationValidationErrors = validateSchema(webpackConfigurationSchema, options);+			if (webpackConfigurationValidationErrors.length) {+				const error = new WebpackOptionsValidationError(webpackConfigurationValidationErrors);+				console.error(error.message, `\nReceived: ${typeof options} : ${JSON.stringify(options, null, 2)}`);+				process.exit(-1); // eslint-disable-line+			}+		} else {+			options = {}; 		}  		// process Promise-		if (typeof options.then === "function") {+		if (options && typeof options.then === "function") {

Thanks for pointing it out, changed now!

evenstensberg

comment created time in 9 days

more