profile
viewpoint
Even Stensberg evenstensberg @TeliaSoneraNorge Tromsø, Norway even.dev

issue commentopenjs-foundation/cross-project-council

OpenJS Foundation Cross Project Council Meeting 2019-05-20

I won’t make it. Sitting on a plane to Oslo.

MylesBorins

comment created time in 13 hours

MemberEvent
MemberEvent

pull request commentopenjs-foundation/bootstrap

doc: 2019-05-06 notes

@mhdawson has a PR open too

MylesBorins

comment created time in 6 days

Pull request review commentwebpack/webpack-cli

fix(generator): using configFile in configPath to get the config file name

 export default function modifyHelperUtil( 			} 		}; 	}+	 	env.registerStub(generator, generatorName);--	env.run(generatorName)-		.then(+	env.run(generatorName, {+		configFile

This change is probably ok and needed as we need this to be dynamic. Just gotta check that it works. Change is that the generator will have output of the config file supplied vs webpack.config.js

anikethsaha

comment created time in 6 days

issue commentopenjs-foundation/bootstrap

OpenJS Foundation Bootstrap Team Meeting 2019-05-13

Could we get meetings put in a calendar invite using mailing lists @mhdawson ?

mhdawson

comment created time in 8 days

PublicEvent

issue commentwebpack/webpack-cli

Regression in version 3.3.1

Update to the latest version

sbrunner

comment created time in 14 days

created tagwebpack/webpack-cli

tagv3.2.2

Webpack's Command Line Interface

created time in 14 days

release webpack/webpack-cli

v3.2.2

released time in 14 days

issue closedwebpack/webpack-cli

Incorrect github tags

Describe the bug

v3.3.2 is tagged as v3.2.2 in GitHub incorrectly.

  • https://github.com/webpack/webpack-cli/releases/tag/v3.2.2
  • https://github.com/webpack/webpack-cli/commit/f0031fdd037a5ad3d5dca97b23aaac96c9edd4fb

Also, v3.2.2 is tagged as v.3.2.2 (including a weird dot after "v").

  • https://github.com/webpack/webpack-cli/releases/tag/v.3.2.2

In GitHub tags, some versions include the dot and the others don't include it.

  • https://github.com/webpack/webpack-cli/tags

All correct in npm.

  • https://www.npmjs.com/package/webpack-cli?activeTab=versions

Expected behavior

  • v3.3.2 should be tagged as v3.3.2 in GitHub.
  • Tags in GitHub should not include a dot after "v".

closed time in 15 days

teppeis

issue commentwebpack/webpack-cli

Incorrect github tags

Thanks for reporting. We're gonna follow npm convention from now on.

teppeis

comment created time in 15 days

issue commentwebpack/webpack-cli

[UI]: User flow for webpack ui

wow 😍

rishabh3112

comment created time in 15 days

issue commentwebpack/webpack-cli

webpack-cli@3.3.1 postinstall: `node ./bin/opencollective.js` npm ERR! Exit status 134

Will do this tomorrow Andrey. Hope you’re doing well! 🤗

Hethsron

comment created time in 16 days

issue closedwebpack/webpack-cli

webpack-cli@3.3.1 postinstall: `node ./bin/opencollective.js` npm ERR! Exit status 134

Describe the bug

A 💯 way to do this is to provide your configuration via a GitHub gist and/or to use markdown when describing which commands you used when the error occurred! Be precise and clear in your description of the bug.

What is the current behavior?

This is where you elaborate on the current behavior of the cli, how it behaves normally differing from the previous version/build you did.

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Please paste the results of webpack-cli info here, and mention other relevant information

Additional context Add any other context about the problem here like linking to an similar issue you might think is the cause.

closed time in 16 days

Hethsron

issue commentwebpack/webpack-cli

webpack-cli@3.3.1 postinstall: `node ./bin/opencollective.js` npm ERR! Exit status 134

webpack-cli v.3.2.2 comes with a fix for this.

Hethsron

comment created time in 16 days

release webpack/webpack-cli

v3.2.2

released time in 16 days

created tagwebpack/webpack-cli

tagv3.2.2

Webpack's Command Line Interface

created time in 16 days

push eventwebpack/webpack-cli

ev1stensberg

commit sha f0031fdd037a5ad3d5dca97b23aaac96c9edd4fb

chore: v.3.3.2

view details

push time in 16 days

push eventwebpack/webpack-cli

devid.farinelli@gmail.com

commit sha d4643ae5d0749a53dff6adaeb2f50fb6d48bceaf

feat(opencollective prompt): add option to disable it + doc

view details

Devid Farinelli

commit sha 246db427642750a6a8b59b37d6797c74b6ff9846

fix(opencollective prompt): fix grammar

view details

devid.farinelli@gmail.com

commit sha e17a26daf01ae0463669e7dc735eb8d8b40ac860

misc(opencollective-prompt): improve grammar

view details

Devid Farinelli

commit sha b4dfa17a9ebe42b47d57df6cdc5a53f6e91a3532

Merge branch 'master' into feat/option-to-disable-postinstall

view details

Even Stensberg

commit sha 0309e371c06d35f3d46b219c470bb460270cef96

Merge pull request #863 from misterdev/feat/option-to-disable-postinstall feat(opencollective prompt): add disable option

view details

push time in 16 days

PR merged webpack/webpack-cli

feat(opencollective prompt): add disable option PR: CI-ok PR: reviewed-approved

What kind of change does this PR introduce? Allows disabling the open collective prompt.

Following opencollective-postinstall, our prompt is disabled if DISABLE_OPENCOLLECTIVE or CI env variables are set to true

If relevant, did you update the documentation? Yes

Summary Closes #854

Other information This is an alternative PR to #856

+18 -5

4 comments

2 changed files

misterdev

pr closed time in 16 days

issue closedwebpack/webpack-cli

[request] opencollective postinstall should respect DISABLE_OPENCOLLECTIVE

Is your feature request related to a problem? Please describe. The inhouse opencollective postinstall bin/opencollective.js should respect DISABLE_OPENCOLLECTIVE (or CI) environment variable just like standard opencollective-postinstall.

https://github.com/opencollective/opencollective-postinstall/blob/7a5c767e043f7e86c452f5f8b96b9cf4db7a8ce5/index.js#L7

Describe the solution you'd like It should respect environment variables DISABLE_OPENCOLLECTIVE and CI, in order to allow user to turn the donation prompt off.

Describe alternatives you've considered NA

Additional context NA

closed time in 16 days

3cp

issue commentwebpack/webpack-cli

🐞[cli]: throws err when no args passed.

This is a no fix in my opinion

pranshuchittora

comment created time in 16 days

Pull request review commentwebpack/webpack-cli

chore(refactor): refactor scaffolding and AST utils

 export default function modifyHelperUtil( 			} 		}; 	}-	env.registerStub(generator, generatorName); -	env.run(generatorName)-		.then(-			(): void => {-				let configModule: object;-				try {-					const confPath = path.resolve(process.cwd(), ".yo-rc.json");-					configModule = require(confPath);-					// Change structure of the config to be transformed-					const tmpConfig: object = {};-					Object.keys(configModule).forEach(-						(prop: string): void => {-							const configs = Object.keys(configModule[prop].configuration);-							configs.forEach(-								(conf: string): void => {-									tmpConfig[conf] = configModule[prop].configuration[conf];-								}-							);-						}-					);-					configModule = tmpConfig;-				} catch (err) {-					console.error(chalk.red("\nCould not find a yeoman configuration file.\n"));-					console.error(-						chalk.red(-							"\nPlease make sure to use 'this.config.set('configuration', this.configuration);' at the end of the generator.\n"-						)-					);-					Error.stackTraceLimit = 0;-					process.exitCode = -1;+	if (!usingCLI) {+		/**

no need to add comment here, you will need to disable prompting and fully generate a scaffold file by running the transformation on the config object

rishabh3112

comment created time in 16 days

push eventwebpack/webpack-cli

Devid Farinelli

commit sha 5284b7e97cb8450d479d8220d09222103871ef72

fix(opencollective-prompt): check write permissions

view details

Even Stensberg

commit sha c833961c26bf2d22585fbcda76b7a9dc5c34e047

Merge pull request #876 from misterdev/fix-opencollective-eperm fix(opencollective-prompt): fix EPERM error

view details

push time in 16 days

PR merged webpack/webpack-cli

fix(opencollective-prompt): fix EPERM error PR: CI-ok PR: reviewed-approved PR: small

What kind of change does this PR introduce? Fixes open collective prompt EPERM error.

Did you add tests for your changes? I don't have access to a Linux machine at the moment, it would be nice if anyone could test this on Linux. Here's the repository. @sbrunner, @fredj :)

Summary Closes #870

+9 -2

1 comment

1 changed file

misterdev

pr closed time in 16 days

issue closedwebpack/webpack-cli

Regression in version 3.3.1

Describe the bug

Regression on vwersion 3.3.1

What is the current behavior?

I get the following error:

     + 1 hidden asset
    Entrypoint undefined = desktop.html
    [0] ../html-webpack-plugin/lib/loader.js!/src/geoportal/testgeomapfish_geoportal/static-ngeo/js/apps/desktop.html.ejs 15.7 KiB {0} [built]
    [2] ../webpack/buildin/global.js 177 bytes {0} [built]
    [3] ../webpack/buildin/module.js 511 bytes {0} [built]
    [4] /src/geoportal/testgeomapfish_geoportal/static-ngeo/js/apps/image/favicon.ico 64 bytes {0} [built]
    [5] /src/geoportal/testgeomapfish_geoportal/static-ngeo/js/apps/image/logo.png 61 bytes {0} [built]
    [6] /src/geoportal/testgeomapfish_geoportal/static-ngeo/js/apps/image/background-layer-button.png 80 bytes {0} [built]
        + 1 hidden module
Child html-webpack-plugin for "iframe_api.html":
     3 assets
    Entrypoint undefined = iframe_api.html
    [0] ../html-webpack-plugin/lib/loader.js!/src/geoportal/testgeomapfish_geoportal/static-ngeo/js/apps/iframe_api.html.ejs 4.62 KiB {0} [built]
    [2] ../webpack/buildin/global.js 177 bytes {0} [built]
    [3] ../webpack/buildin/module.js 511 bytes {0} [built]
    [4] /src/geoportal/testgeomapfish_geoportal/static-ngeo/js/apps/image/favicon.ico 64 bytes {0} [built]
    [5] /src/geoportal/testgeomapfish_geoportal/static-ngeo/js/apps/image/background-layer-button.png 80 bytes {0} [built]
        + 1 hidden module
Child html-webpack-plugin for "mobile.html":
     3 assets
    Entrypoint undefined = mobile.html
    [0] ../html-webpack-plugin/lib/loader.js!/src/geoportal/testgeomapfish_geoportal/static-ngeo/js/apps/mobile.html.ejs 9.76 KiB {0} [built]
    [2] ../webpack/buildin/global.js 177 bytes {0} [built]
    [3] ../webpack/buildin/module.js 511 bytes {0} [built]
    [4] /src/geoportal/testgeomapfish_geoportal/static-ngeo/js/apps/image/favicon.ico 64 bytes {0} [built]
    [5] /src/geoportal/testgeomapfish_geoportal/static-ngeo/js/apps/image/logo.png 61 bytes {0} [built]
    [6] ./contribs/gmf/src/icons/layers.svg 332 bytes {0} [built]
        + 1 hidden module
                            Thanks for using Webpack!
                 Please consider donating to our Open Collective
                        to help us maintain this package.
                 Donate: https://opencollective.com/webpack/donate
fs.js:114
    throw err;
    ^
Error: EPERM: operation not permitted, utime '/usr/lib/node_modules/webpack-cli/bin/opencollective.js'
    at utimesSync (fs.js:1108:3)
    at compilerCallback (/usr/lib/node_modules/webpack-cli/bin/cli.js:336:8)
    at compiler.run (/usr/lib/node_modules/webpack-cli/bin/cli.js:361:7)
    at finalCallback (/usr/lib/node_modules/webpack/lib/Compiler.js:220:39)
    at hooks.done.callAsync.err (/usr/lib/node_modules/webpack/lib/Compiler.js:269:14)
    at AsyncSeriesHook.eval [as callAsync] (eval at create (/usr/lib/node_modules/webpack/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:6:1)
    at AsyncSeriesHook.lazyCompileHook (/usr/lib/node_modules/webpack/node_modules/tapable/lib/Hook.js:154:20)
    at emitRecords.err (/usr/lib/node_modules/webpack/lib/Compiler.js:267:22)
    at Compiler.emitRecords (/usr/lib/node_modules/webpack/lib/Compiler.js:449:39)
    at emitAssets.err (/usr/lib/node_modules/webpack/lib/Compiler.js:261:10)
    at hooks.afterEmit.callAsync.err (/usr/lib/node_modules/webpack/lib/Compiler.js:435:14)
    at AsyncSeriesHook.eval [as callAsync] (eval at create (/usr/lib/node_modules/webpack/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:15:1)
    at AsyncSeriesHook.lazyCompileHook (/usr/lib/node_modules/webpack/node_modules/tapable/lib/Hook.js:154:20)
    at asyncLib.forEachLimit.err (/usr/lib/node_modules/webpack/lib/Compiler.js:432:27)
    at /usr/lib/node_modules/webpack/node_modules/neo-async/async.js:2813:7
    at done (/usr/lib/node_modules/webpack/node_modules/neo-async/async.js:3521:9)
    at /usr/lib/node_modules/webpack/node_modules/graceful-fs/graceful-fs.js:45:10
    at FSReqWrap.args [as oncomplete] (fs.js:140:20)
CONST_Makefile:604: recipe for target '/build/apps.timestamp' failed
make: *** [/build/apps.timestamp] Error 1

To Reproduce

  1. Install Webpack globally npm install --global ... (in my case in a Linux Docker container).
  2. Build the project using webpack.

Expected behavior Build success

Please paste the results of webpack-cli info here, and mention other relevant information

Full log: https://travis-ci.org/camptocamp/c2cgeoportal/builds/525892796#L4685

Additional context Looks that's this line is in charge of this issue: https://github.com/webpack/webpack-cli/pull/755/files/55992a45a302977ef5e5075e81cc127e9fafdf07#diff-22d5d2b57c69d2e1ac054c4d0f744ff1R493

closed time in 16 days

sbrunner

Pull request review commentwebpack/webpack-cli

misc(init-generator) cli improvements & refactor

+/**+ * Application entry point+ */++console.log("Hello World from <%= name %>");

agreeing with @misterdev

misterdev

comment created time in 16 days

IssuesEvent

issue closedwebpack/webpack-cli

[Feature] Extend from a base config

Is your feature request related to a problem? Please describe. Not a problem, but a nice to have. Lot of time people have different configuration file based on different environment or situation and sometimes they like to put the 'shared' configuration inside a specific file (webpack.base.js, something like this). It would nice if the webpack-cli would provide an automatic way to extend from a base file.

Describe the solution you'd like A clear and concise description of what you want to happen.

Usage scenarios:

// webpack.base.js
module.exports = {
  entry: {
     foo: './src/foo.js',
     bar: './src.bar.js'
   },
   output: {
      filename: [name].js
   }
}
// webpack.dev.js

module.exports = {
   mode: 'development',
   plugins: [
       new DefinePlugin() // anything
   ]
}
webpack --config webpack.dev.js --extend webpack.base.js

Or

// inside webpack.dev.js

module.exports = {
   extend: './webpack.base.js',
   mode: 'development',
   plugins: [
       new DefinePlugin() // anything
   ]
}

closed time in 16 days

ematipico

Pull request review commentwebpack/webpack-cli

[WIP] chore(ci): add node 12

 jobs:           npm -v         displayName: "Print version"       - script: |-          npm ci

npm ci is probably better, runs fresh install with lockfile

misterdev

comment created time in 16 days

issue commentwebpack/webpack-cli

webpack-cli@3.3.1 postinstall: `node ./bin/opencollective.js` npm ERR! Exit status 134

Could you give a complete stack trace after removing node modules and running npm install again?

Hethsron

comment created time in 16 days

MemberEvent

Pull request review commentwebpack/webpack-cli

[init]: Do not generate config when defaults are used

 export default class InitGenerator extends Generator { 			"\n" 		); +		const initConfig = []

this.configuration is better than alloc memory for all that

anshumanv

comment created time in 25 days

Pull request review commentwebpack/webpack-cli

[init]: Do not generate config when defaults are used

 export default class InitGenerator extends Generator { 			"\n" 		); +		const initConfig = []

You already have an object that you have access to already in two ways hint hint

anshumanv

comment created time in 25 days

Pull request review commentwebpack/webpack-cli

[init]: Do not generate config when defaults are used

 export default class InitGenerator extends Generator { 							this.configuration.config.webpackOptions.module.rules.push(moduleRulesObj); 						} 					}++					// Check if the options selected by the user are defaults+				if (checkDefault(initConfig)) {

nice

anshumanv

comment created time in 25 days

issue commentwebpack/webpack-cli

[request] opencollective postinstall should respect DISABLE_OPENCOLLECTIVE

The prompt is showing 1 day per week and only if you install it on that particular day. I don't think it's a big problem.

huochunpeng

comment created time in a month

Pull request review commentwebpack/webpack-cli

chore(async): add generator to async/await

 export default class AddGenerator extends Generator { 		// eslint-disable-next-line 		const isDeepProp: any[] = [false, false]; -		return this.prompt([-			AutoComplete("actionType", "What property do you want to add to?", {-				pageSize: 7,-				source: searchProps,-				suggestOnly: false-			})-		])-			.then(-				(actionTypeAnswer: { actionType: string }): void => {-					// Set initial prop, like devtool-					this.configuration.config.webpackOptions[actionTypeAnswer.actionType] = null;-					// update the action variable, we're using it later-					action = actionTypeAnswer.actionType;+		const actionTypeAnswer: {+			actionType: string,+		} =  await this.prompt([+			AutoComplete(+				"actionType",+				"What property do you want to add to?",+				{+					pageSize: 7,+					source: searchProps,+					suggestOnly: false,+				},+			),+		]);++		// Set initial prop, like devtool+		this.configuration.config.webpackOptions[+			actionTypeAnswer.actionType+		] = null;+		// update the action variable, we're using it later+		action = actionTypeAnswer.actionType;++		if (action === "entry") {+			const entryTypeAnswer: {+				entryType: boolean,+			} = await this.prompt([+				Confirm("entryType", "Will your application have multiple bundles?", false),+			]);++			// Ask different questions for entry points+			const entryOptions = await entryQuestions(self, entryTypeAnswer);++			this.configuration.config.webpackOptions.entry = entryOptions;+			this.configuration.config.item = action;++		} else {+			if (action === "topScope") {++				const topScopeAnswer: {+					topScope: string,+				} = await this.prompt([+					Input("topScope", "What do you want to add to topScope?"),+				]);++				this.configuration.config.topScope.push(topScopeAnswer.topScope);+				return;+			}+		}++		const temp: string = action;

reassigning a const

rishabh3112

comment created time in a month

Pull request review commentwebpack/webpack-cli

chore(cli): remove findup-sync from root move to utils package

 "use strict";  import * as path from "path";-import isLocalPath from "../is-local-path";+import { isLocalPath } from "../path-utils";

I think you'll need to change how the CI bootstraps in that case. You should get it up running locally first.

anshumanv

comment created time in a month

Pull request review commentwebpack/webpack-cli

feat(scaffold): create a webpack script on running a scaffold

+import { json } from "mrm-core";

I don't think we need a dependency to do a JSON write

anshumanv

comment created time in a month

Pull request review commentwebpack/webpack-cli

feat(scaffold): create a webpack script on running a scaffold

 export default function runTransform(transformConfig: TransformConfig, action: s 				); 		} 	);+	// Add a webpack script to package.json+	addScript("webpack", "webpack")

This script is dependant on which config you have generated. Sometimes it's prod, then you'll need --config flag, otherwise not

anshumanv

comment created time in a month

Pull request review commentwebpack/webpack-cli

fix(typedoc): fixes npm run docs

 import Generator = require("yeoman-generator");  import * as copyUtils from "@webpack-cli/utils/copy-utils"; import { InquirerScaffoldObject } from "@webpack-cli/webpack-scaffold";-import { YeoGenerator } from "../generate-loader/types/Yeoman";+import { YeoGenerator } from "./types/Yoeman";

wrong filename

pranshuchittora

comment created time in a month

Pull request review commentwebpack/webpack-cli

fix(typedoc): fixes npm run docs

+export interface YeoGenerator extends Object {

Wrong filename

pranshuchittora

comment created time in a month

created tagwebpack/webpack-cli

tagv.3.3.1

Webpack's Command Line Interface

created time in a month

release webpack/webpack-cli

v.3.1.1

released time in a month

push eventwebpack/webpack-cli

ev1stensberg

commit sha d3f8e2098130493299206acdd5d8887419d66bcc

chore: v.3.1.1

view details

push time in a month

issue openedwebpack/webpack-cli

[Bug]: `npm run docs` fails

Describe the bug

A 💯 way to do this is to provide your configuration via a GitHub gist and/or to use markdown when describing which commands you used when the error occurred! Be precise and clear in your description of the bug.

What is the current behavior?

Running the command results in an error. This is where you elaborate on the current behavior of the cli, how it behaves normally differing from the previous version/build you did.

To Reproduce Steps to reproduce the behavior:

  1. clone the repo
  2. install deps
  3. run npm run docs

Expected behavior Documentation is generated

Screenshots

Using TypeScript 3.1.6 from /Users/evenstensberg/Documents/Github/webpack-cli/node_modules/typedoc/node_modules/typescript/lib
INFO: applying regexp  .*packages/(@webpack-cli/[^/]+)/.*  to calculate module names
INFO: Enabled true
Error: /Users/evenstensberg/Documents/Github/webpack-cli/packages/add/node_modules/@webpack-cli/utils/scaffold.ts(6)
 Cannot find module '../init/types'.
Error: /Users/evenstensberg/Documents/Github/webpack-cli/packages/generate-loader/node_modules/@webpack-cli/generators/addon-generator.ts(6)
 Cannot find module '../generate-loader/types/Yeoman'.

created time in a month

push eventwebpack/webpack-cli

Anshuman Verma

commit sha f7451d427df679755587006b62550b2f202de817

docs(serve): update docs to use webpack-dev-server update docs to use webpack-dev-server ISSUES CLOSED: #846

view details

Anshuman Verma

commit sha cb68b1bfb899068006b2f7ad3b8ee0b409ea2763

docs(serve): link to webpack-dev-server link to webpack-dev-server

view details

Even Stensberg

commit sha f371e726c2e1134f4bffaa827a571c2aad00e80d

Merge pull request #847 from anshumanv/846 docs(serve): update docs to use webpack-dev-server

view details

push time in a month

PR merged webpack/webpack-cli

docs(serve): update docs to use webpack-dev-server PR: CI-ok PR: reviewed-approved PR: small

update docs to use webpack-dev-server

ISSUES CLOSED: #846

<!-- Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. -->

What kind of change does this PR introduce? docs <!-- E.g. a bugfix, feature, refactoring, build related change, etc… -->

Did you add tests for your changes? NA

If relevant, did you update the documentation? yes

Summary

  • Update serve package docs to use webpack-dev-server, webpack-serve is deprecated. <!-- Explain the motivation for making this change. What existing problem does the pull request solve? --> <!-- Try to link to an open issue for more information. -->

Does this PR introduce a breaking change? no <!-- If this PR introduces a breaking change, please describe the impact and a migration path for existing applications. -->

Other information NA

+2 -2

1 comment

2 changed files

anshumanv

pr closed time in a month

issue closedwebpack/webpack-cli

docs: inconsistent docs in serve package

<!-- Before creating an issue please make sure you are using the latest version of webpack. -->

Do you want to request a feature or report a bug? docs <!-- Please ask questions on StackOverflow or the webpack Gitter (https://gitter.im/webpack/webpack). Questions will be closed. -->

What is the current behavior? It contains deprecated docs, we no longer use webpack-serve image

If the current behavior is a bug, please provide the steps to reproduce. NA

<!-- A great way to do this is to provide your configuration via a GitHub gist. -->

What is the expected behavior? Since we're using webpack-dev-server and not webpack-serve so correct package.

If this is a feature request, what is motivation or use case for changing the behavior? consistent docs 😌

Please paste the results of webpack-cli info here, and mention other relevant information such as programming language.

closed time in a month

anshumanv

push eventwebpack/webpack-cli

Pranshu Chittora

commit sha 8c1db0317c20d29de14bf31527fdb5b5e7c0caf6

chore(docs): removes scaffolding docs from the root removes the scaffolding docs from the root of the project folder

view details

Even Stensberg

commit sha da9e732fa86c017a6b4faa0d926bdce577203b76

Merge pull request #841 from pranshuchittora/docs-remove chore(docs): removes scaffolding docs from the root

view details

push time in a month

PR merged webpack/webpack-cli

chore(docs): removes scaffolding docs from the root PR: CI-ok PR: reviewed-approved

As per #840 Removes the scaffolding docs from the root of the project folder. As it's already been maintained at webpack.js.org. Here

What kind of change does this PR introduce? chore

+0 -148

3 comments

1 changed file

pranshuchittora

pr closed time in a month

Pull request review commentwebpack/webpack-cli

chore(cli): remove findup-sync from root move to utils package

 "use strict";  import * as path from "path";-import isLocalPath from "../is-local-path";+import { isLocalPath } from "../path-utils";

absolute import by package here, to avoid breaking stuff

anshumanv

comment created time in a month

push eventevenstensberg/dotfiles

ev1stensberg

commit sha 810b06e3b110bdb824052f32d81075db731d61dd

chore: new file

view details

push time in a month

push eventevenstensberg/evenstensberg

ev1stensberg

commit sha c12fc3df0325adbf5b02256ddcf83251e7be61c2

chore: work

view details

push time in a month

push eventevenstensberg/evenstensberg

ev1stensberg

commit sha 8a6f5e926e15d3655f952653eaa826a2342b7c28

chore: work

view details

push time in a month

create barnchevenstensberg/evenstensberg

branch : blog

created branch time in a month

push eventevenstensberg/evenstensberg

ev1stensberg

commit sha b4f0ab51f22069dea3a8a85ad85cb12ea8e53995

chore: bugfixes

view details

push time in a month

push eventevenstensberg/evenstensberg

ev1stensberg

commit sha a3f6026099a13018e356b55fa60b16a4073b529c

chore: yes

view details

push time in a month

issue commentwebpack/webpack-cli

Add --no-config arg option to ignore webpack.config.js

Thank you so much for your comment. Could you bring this over to https://github.com/webpack/webpack-cli/issues/820 ?

benwiley4000

comment created time in a month

Pull request review commentwebpack/webpack-cli

Remove tslint in favour of eslint

 module.exports = {-	"root": true,-	"plugins": ["node"],-	"extends": ["eslint:recommended", "plugin:node/recommended"],-	"env": {-		"node": true,-		"es6": true,-		"jest": true+	// "root": true,

remove unneeded comments?

ematipico

comment created time in a month

push eventwebpack/webpack-cli

Pranshu Chittora

commit sha 6a0375a728888cf24736e631a3d52d2359d40085

docs(packages): adds downloads/month shield adds the image shield for downloads in readme file

view details

Even Stensberg

commit sha b8d5511ef3ede072f12f99e398339e6760eb39f1

Merge pull request #832 from pranshuchittora/docs docs(packages): adds downloads/month img shield

view details

push time in a month

PR merged webpack/webpack-cli

docs(packages): adds downloads/month img shield PR: CI-ok PR: reviewed-approved
  • Adds the image shield for total number downloads in the readme file of all packages.
  • Updates webpack-scaffold API table.

What kind of change does this PR introduce? Documentation

<!-- Explain the motivation for making this change. What existing problem does the pull request solve? --> To know whether the package is popular or not, in order to plan for future upgrades.

+45 -16

1 comment

12 changed files

pranshuchittora

pr closed time in a month

issue commentwebpack/webpack-cli

webpack-cli@3.2.1 postinstall: `lightercollective`

Or upgrade

brunolm

comment created time in a month

issue commentwebpack/webpack-cli

[cli]: Installation prompt should look for package from project root.

You will first need to look for the package in global and then local

anshumanv

comment created time in a month

push eventwebpack/webpack-cli

Pranshu Chittora

commit sha 0b28fb337a1a9c491d2b5aacbc8ca9300f057906

misc(utils): refactors scaffold refactors the conditional statements in scaffold.ts

view details

Pranshu Chittora

commit sha 7fe35435a75b89fbce10c4a0281a75b3030a7edb

fix(utils): refactors utils impoves the codebase by adding comments

view details

Pranshu Chittora

commit sha 80fd4facdd49a46c7deeaa9bcab5998c2ef93337

chore(junit): reverting the junit.xml

view details

Even Stensberg

commit sha 963c85f72c7097dfa648f8d98e0a33bc516d3f53

Merge pull request #818 from pranshuchittora/refactor-utils misc: Refactoring utils

view details

push time in a month

PR merged webpack/webpack-cli

misc: Refactoring utils PR: CI-ok PR: reviewed-approved

What kind of change does this PR introduce? Refactoring

What existing problem does the pull request solve? Refined codebase, better code readability.

Does this PR introduce a breaking change? Nopes

Other information Feedback appreciated :+1:

+17 -16

1 comment

3 changed files

pranshuchittora

pr closed time in a month

push eventwebpack/webpack-cli

Rishabh Chawla

commit sha 74179b5a94acc5b15e0b936a3321c4f03c01ef2b

docs(README): update scaffolding links Links from webpack.js.org

view details

Rishabh Chawla

commit sha e35a194bebee233a23076a8d591606ab21d7e594

docs(README): add link to webpack-scaffold-starter

view details

Rishabh Chawla

commit sha 3a11a16e83dce66604d5de2b3241b92350170b75

docs(README): phrase change

view details

Even Stensberg

commit sha 8506ccfa8edc8026df75266cf5f87f7cf4420b12

Merge pull request #827 from rishabh3112/patch-9 docs(README): update scaffolding links

view details

push time in a month

PR merged webpack/webpack-cli

docs(README): update scaffolding links PR: CI-ok PR: reviewed-approved PR: small

Links from webpack.js.org

<!-- Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. -->

What kind of change does this PR introduce? <!-- E.g. a bugfix, feature, refactoring, build related change, etc… -->

documentation change

Did you add tests for your changes? N/A

If relevant, did you update the documentation? inception

Summary

<!-- Explain the motivation for making this change. What existing problem does the pull request solve? --> <!-- Try to link to an open issue for more information. -->

Does this PR introduce a breaking change? <!-- If this PR introduces a breaking change, please describe the impact and a migration path for existing applications. -->

Other information

+1 -1

3 comments

1 changed file

rishabh3112

pr closed time in a month

issue commentwebpack/webpack-cli

[cli]: Installation prompt should look for package from project root.

No, we need to symlink

anshumanv

comment created time in a month

startedwebpack-contrib/closure-webpack-plugin

started time in a month

startedGoogleChrome/lighthouse-stack-packs

started time in a month

push eventevenstensberg/evenstensberg

ev1stensberg

commit sha 004807eabe40724924a588115de0502129b369d6

chore: add medium link

view details

push time in a month

push eventwebpack/webpack-cli

Pranshu Chittora

commit sha 958d06415801ad6263c36ca50171c92c74b22180

docs(readme): adds contributors shield adds the shield for the total number of contributors

view details

Even Stensberg

commit sha 834d90e9cb4a60a8e8b700fcf8559fd2694be515

Merge pull request #828 from pranshuchittora/shields docs(README): adds contributors shield

view details

push time in a month

PR merged webpack/webpack-cli

docs(README): adds contributors shield PR: CI-ok PR: reviewed-approved PR: small

Adds a new shield to represent the count of contributors

GitHub contributors

What kind of change does this PR introduce? docs

+1 -0

1 comment

1 changed file

pranshuchittora

pr closed time in a month

push eventevenstensberg/evenstensberg

ev1stensberg

commit sha a0194716a19970de326e0f780ceea6d3bd391822

chore: wip

view details

push time in a month

push eventevenstensberg/evenstensberg

ev1stensberg

commit sha 65ab22e4e7e1dc3cc81131dea8cab82ccfb9ed4d

chore: wip

view details

push time in a month

push eventevenstensberg/evenstensberg

ev1stensberg

commit sha 21ffbcd87c87df91b80deb9f3f7ef769e34c1a69

chore: wip

view details

push time in a month

push eventevenstensberg/evenstensberg

ev1stensberg

commit sha 6659493c8e8b68554dca466a88777b2d8bb93c39

chore: :)

view details

push time in a month

push eventevenstensberg/evenstensberg

ev1stensberg

commit sha 8b19c93150e84e16ebfc1a01ee83696b8215e550

chore: :)

view details

push time in a month

push eventevenstensberg/evenstensberg

ev1stensberg

commit sha 954e614ca1cd20bdf0ac5c7c909577d3233c6339

a lot of work

view details

push time in a month

push eventevenstensberg/evenstensberg

ev1stensberg

commit sha 455ac12c5c7e9999f07708794da620dc67ba27d2

a lot of work

view details

push time in a month

startedJoakimSjo/fable-react-nobinaApp

started time in a month

push eventevenstensberg/evenstensberg

ev1stensberg

commit sha a0ca3d05f3ac82849b675164c7b6980b22f3bbac

chore: wip

view details

push time in a month

delete branch evenstensberg/evenstensberg

delete branch : next

delete time in a month

push eventevenstensberg/evenstensberg

ev1stensberg

commit sha da9e21a6d0a828e9fe209b5c1b2b1232065978e4

chore: ok

view details

ev1stensberg

commit sha 7ec6369234b4bc0277d796b42f1c5ed5133a6ed3

ouf need to refactor a lot soon

view details

ev1stensberg

commit sha 11114edf8efff61db72140f1ccda56997844ed74

chore: :O

view details

Even Stensberg

commit sha 533f1d58914ac739616f38b03d9234c85c46b121

Merge pull request #1 from evenstensberg/next Moving on from static paging

view details

push time in a month

PR merged evenstensberg/evenstensberg

Moving on from static paging

Godaddy static server -> Gcloud

+10499 -7018

0 comment

42 changed files

evenstensberg

pr closed time in a month

push eventevenstensberg/evenstensberg

ev1stensberg

commit sha 11114edf8efff61db72140f1ccda56997844ed74

chore: :O

view details

push time in a month

Pull request review commentwebpack/webpack-cli

docs(README): update scaffolding links

 You will answer many questions when running the `init` so webpack CLI can provid  With v3 of webpack CLI, we introduced scaffolding as an integral part of the CLI. Our goal is to simplify the creation of webpack configurations for different purposes. Additionally, sharing such solutions with the community is beneficial and with webpack webpack's we want to allow this. We provide `webpack-scaffold` as a utility suite for creating these scaffolds. It contains functions that could be of use for creating an scaffold yourself. -You can read more about [Scaffolding](./SCAFFOLDING.md) or check out the example project [How do I compose a webpack-scaffold?](https://github.com/evenstensberg/webpack-scaffold-demo).+You can read more about [Scaffolding](https://webpack.js.org/guides/scaffolding), learn [How to compose a webpack-scaffold?](https://webpack.js.org/contribute/writing-a-scaffold) or start writing scaffolds with [webpack-scaffold-starter](https://github.com/rishabh3112/webpack-scaffold-starter) on the go.

Or generate one with {link}

rishabh3112

comment created time in a month

startedrherwig/template-react-ssr

started time in a month

push eventevenstensberg/evenstensberg

ev1stensberg

commit sha 7ec6369234b4bc0277d796b42f1c5ed5133a6ed3

ouf need to refactor a lot soon

view details

push time in a month

PR opened evenstensberg/evenstensberg

chore: ok

Godaddy static server -> Gcloud

+8595 -4993

0 comment

5 changed files

pr created time in a month

create barnchevenstensberg/evenstensberg

branch : next

created branch time in a month

created repositoryevenstensberg/unreal-fun

Just me messing around in Unreal

created time in a month

push eventevenstensberg/YATB

ev1stensberg

commit sha aebae1d5e8ee4beb48392ee32ea37733b775be59

chore: yas

view details

push time in a month

startedrShetty/awesome-podcasts

started time in a month

issue commentrishabh3112/webpack-ui-example

Discussion: Server framework

@evenstensberg So, are you happy with Nest now?

rishabh3112

comment created time in a month

issue commentrishabh3112/webpack-ui-example

Discussion: Server framework

Yes

rishabh3112

comment created time in a month

push eventevenstensberg/polar-sat-data

ev1stensberg

commit sha 9bb47cb382c33cd1b37557c46c97f55b442907dc

chore: OKi

view details

push time in a month

more