profile
viewpoint
est31 FLOSS software. Past contributions include @minetest, @rust-lang, F-Droid.

est31/cargo-udeps 342

Find unused dependencies in Cargo.toml

est31/cargo-local-serve 25

Mirror of https://gitlab.com/est/cargo-local-serve | Serve a local, offline, clone of crates.io.

est31/csrp-gmp 5

Minimal C implementation of the Secure Remote Password protocol (version 6a)

est31/anvil 1

An anvil mod for minetest based on the cottages anvil

est31/balloc 1

Bounded allocation for Rust

est31/addr2line 0

A cross-platform `addr2line` clone written in Rust, using `gimli`

est31/alert-after 0

Get a desktop notification after a command finishes executing.

est31/amethyst 0

Data-oriented and data-driven game engine written in Rust

issue commentRustAudio/deepspeech-rs

Could not run example: ERROR: Could not open 'deepspeech-0.8.0-models.tflite/output_graph.pb'

Thanks for the report. In older releases, pretrained models were distributed as a zip file but now apparently the bare files are distributed. The loading code has to be adjusted and take files instead of directories.

When making the release I haven't tried out loading the models and running it, unlike with earlier releases. This is the reason why the bug went out unnoticed. Maybe the CI should be adjusted to do it, but that's a separate issue.

antholeole

comment created time in 7 hours

pull request commentrust-lang/cargo

[WIP] Add flag to warn about unused dependencies

So I've implemented support to specify the lint levels via #![allow], #![deny] etc. See the last commit. It will always take the most severe lint level it sees in any unit and apply it globally for all lints. This is the conceptually most simple approach, but it has chances to confuse ppl when they e.g. put an allow into a test and are surprised the warning is shown when no tests are run. I can't think of something equally simple and non-confusing other than #5034.

est31

comment created time in 17 hours

issue commentpanicbit/repulse

Playback example requires patched audrey crate for FLAC

I've merged one of the PRs now.

panicbit

comment created time in a day

push eventRustAudio/audrey

Matt Wilkinson

commit sha 649f12c3b298fa64f1f776d14b3f41b84e019cab

Scale bit depth for flac like with wav

view details

est31

commit sha f414a54c0a692b52512856044f19a716d75c0f57

Merge pull request #23 from Cocalus/master Scale bit depth for Flac

view details

push time in a day

PR merged RustAudio/audrey

Scale bit depth for Flac

I ran into very quiet audio again with Flac this time. For the same reason that the bit depth wasn't being corrected. This was with a standard 16bit Flac. This should support any bit depth up to 32. I added errors for Wav and Flac such that unsupported bit depths will return errors. So up to 32 bits for Flac and 8,16,24,32 for Wav. While Wav has a bits per sample, everything seems to turn that into bytes per sample, so I don't think there are other valid Wav formats. But if such formats exist they will stop working with this (previously they would have their bit depth scaled incorrectly).

For spot checking code It looks like the other formats convert the bit depth internally in their respective crates, but I haven't tested them explicitly.

+61 -5

3 comments

1 changed file

Cocalus

pr closed time in a day

pull request commentRustAudio/audrey

Scale bit depth for Flac

Ideally the claxon crate would take care of this shifting, but idk. We can have the patch for as long as claxon has the buggy behaviour.

Cocalus

comment created time in a day

pull request commentRustAudio/audrey

Fix flac sample conversion

Wouldn't that compress the volume range?

How would it compress it? To me it seems that the shift only ensures that the topmost bit of the input data is also the topmost bit of the output data.

panicbit

comment created time in a day

push eventest31/rust

est31

commit sha db65a78c40ab0a5ced9790b22eeaef1123a551e3

Emit the lint level of the unused-crate-dependencies Also, turn off the lint when the unused dependencies json flag is specified so that cargo doesn't have to supress the lint

view details

push time in a day

push eventest31/cargo

est31

commit sha 718aab5fa0234a8eff320cc294f1050cc7eb6a02

Support specifying different lint levels Specifying via the command line is not possible for now because cargo currently has to pass -W via the command line, but once the lint is set to warn by default, this won't be needed :).

view details

push time in a day

issue commentest31/rcgen

Documentation improvement: mention the "x509-parser" feature flag

Yeah it's standard practice to add such remarks to the rustdoc of behind-feature functionality. PRs welcome!

jamadazi

comment created time in 3 days

push eventest31/cargo-local-serve

est31

commit sha 16039c76dd48228dd5e4658aced26c970de38d71

Update syntect and pulldown_cmark

view details

est31

commit sha 839e5dbf104039fa6b6ba307466d036e3a08edf3

Update petgraph to 0.5

view details

est31

commit sha a862131418f7bb13b94c13ae70ac6c12a313e529

Make edition = 2015 explicit

view details

push time in 4 days

push eventest31/cargo-local-serve

est31

commit sha 26855cda6014601990bc9d36ab488ed8b9a300d4

Cargo update

view details

est31

commit sha a41d02e9142be0c9f2d8630e014b744e58162a95

Fix unused_mut warning

view details

est31

commit sha 2d01b58fc53ce1e2bb3462d20571360309b0c7af

Update git2 to 0.13

view details

est31

commit sha d4438c060a9a48417fe7a60bfd89f9e53ac78c55

Update semver to 0.10.0

view details

push time in 4 days

issue commentrust-lang/backtrace-rs

Support column information

@retep998 good point, but note that currently rustc doesn't emit column information on windows. It sets them to zero because emitting them would create bad effects with VS studio. See https://github.com/rust-lang/rust/issues/42921

If LLVM gained an API to specify a full span containing start and end positions, one could think about enabling it again (or if the VS studio bugs got fixed, idk maybe by now they are).

est31

comment created time in 4 days

issue closedmozilla/DeepSpeech

Name for Rust bindings

Hi I've seen you've renamed the library.

https://github.com/mozilla/DeepSpeech/commit/fa2191104878fed468cb16cc8782c345c98ff7aa

Currently the Rust bindings are still named deepspeech and deepspeech-sys. I wonder which name they should get now. Do you have any ideas?

closed time in 4 days

est31

issue commentmozilla/DeepSpeech

Name for Rust bindings

Names sound good. Will use them. Thanks!

est31

comment created time in 4 days

issue openedmozilla/DeepSpeech

Name for Rust bindings

Hi I've seen you've renamed the library.

https://github.com/mozilla/DeepSpeech/commit/fa2191104878fed468cb16cc8782c345c98ff7aa

Currently the Rust bindings are still named deepspeech and deepspeech-sys. I wonder which name they should get now. Do you have any ideas?

created time in 5 days

push eventRustAudio/deepspeech-rs

est31

commit sha 493350072b0b0576f6f098b75ef1ca8072c0d0a4

Update the submodule to v0.9.0-alpha.4

view details

est31

commit sha 1d94ed21b3ba74ae7d61bf06f866089ee73d6a35

Adjust to the new header name and run the bg tool * Adjust to the new header name. The header was renamed in a rename of the entire library [0] * Run cargo +stable run --release -p bg We'll need adjustment to the new name, but that's left for future commits. [0]: https://github.com/mozilla/DeepSpeech/commit/fa2191104878fed468cb16cc8782c345c98ff7aa

view details

push time in 5 days

issue closedqnighy/yasna.rs

How to impl DEREncodable for CHOICE

How to impl DEREncodable for a CHOICE in struct:

PrefixFulfillment ::= SEQUENCE {
     subcondition       Condition
}
Condition ::= CHOICE {
     preimageSha256   [0] SimpleSha256Condition,
     prefixSha256     [1] CompoundSha256Condition,
     thresholdSha256  [2] CompoundSha256Condition,
     rsaSha256        [3] SimpleSha256Condition,
     ed25519Sha256    [4] SimpleSha256Condition
}
use yasna;
use yasna::tags::*;
let data = &[48, 5, 2, 1, 10, 5, 0];
let asn = yasna::parse_der(data, |reader| {
    reader.collect_sequence_of(|reader| {
        let tag = try!(reader.lookahead_tag());
        let choice;
        if tag == TAG_INTEGER {
            choice = Some(try!(reader.read_i64()));
        } else {
            try!(reader.read_null());
            choice = None;
        }
        return Ok(choice);
    })
}).unwrap();
assert_eq!(&asn, &[Some(10), None]);

closed time in 6 days

BruceChen1995

issue commentqnighy/yasna.rs

How to impl DEREncodable for CHOICE

You can use write_tagged (or maybe the _implicit variant, depending on what is specified) to write the tag, then write the rest continuing from there.

BruceChen1995

comment created time in 6 days

push eventest31/cargo

est31

commit sha a912ea4e913e195a7dddc9372a13308b7ec757e7

Support doctests

view details

push time in 6 days

push eventest31/rust

bors

commit sha c2cb565a3e80732233298c1e910883728bdd9174

Auto merge of #5807 - flip1995:changelog, r=yaahc Changelog [Rendered](https://github.com/flip1995/rust-clippy/blob/changelog/CHANGELOG.md) changelog: none

view details

Guillaume Gomez

commit sha 5f6c07937ae4afcf80644a82da5f95af97044efd

Set "invalid_codeblock_attributes" lint to warning level by default

view details

Jonas Schievink

commit sha 209991f8b29698f0dba9baa5e31d501bc7931229

Don't assign `()` to `!` MIR locals

view details

Aleksey Kladov

commit sha cac1768b03c8d6673c51605dca03997876979d68

First cut of `std::lazy` module

view details

Ashley Mannix

commit sha 237a97760ad79a21ce0655b9f5adc0cc5b5cbc79

integrate Lazy into std layout This commit refactors the initial implementation to fit into std and makes some other changes: - use MaybeUninit internally in SyncOnceCell - correctly impl Drop for lazy::Once - port Lazy::take from once_cell from: https://github.com/matklad/once_cell/pull/100 Co-Authored-By: Paul Dicker <pitdicker@users.noreply.github.com>

view details

Ashley Mannix

commit sha d1263f5e66d31ad170c524a70aa5f21e08474326

use set() in SyncOnceCell::from

view details

Ashley Mannix

commit sha d1017940d77f35f841008c3e108e3da5e48a592f

remove inlined lazy::Waiter in favor of sync::Once

view details

Ashley Mannix

commit sha 1f1cda65d9a5c88855d3fbcb3912095474e557de

appease tidy

view details

Nicholas Nethercote

commit sha 8e92f4fb912e42d7bb177b1c5a6ee4b530172f45

Remove unused `cx` parameter from `pathvec_std` and `path_std`.

view details

Nicholas Nethercote

commit sha bccff14a2084784d70bb3caefb24f1694212c0b4

Simplify `LifetimeBounds`. The `lifetimes` field is always empty. This commit removes it, and renames the type as `Bounds`.

view details

Alexis Bourget

commit sha 8a2f147b5b9756e67dc2299777b8b534bbd73d0b

Fix small nits, clarfying some confusing vocabulary and using more consistent wording

view details

Joshua Nelson

commit sha 5271e98f4e8cf2e74e9b01fc2494ea9e90b08194

Use get_module instead of `module_map` for `resolve_str_path_error`

view details

Joshua Nelson

commit sha 848a766e24b799d27e7ae7479cd1f8c07047a53e

Use the scope of the imported variable for resolution, not the current scope - Accept DefId in resolve_str_path_error This will probably break lots of internal invariants.

view details

Joshua Nelson

commit sha 69bd13f233d2cf5ceaf358f69c8e0902f79be73c

Use DefId for modules

view details

Joshua Nelson

commit sha c3d9a730b748a3c8bf673b88a265faad67ec7d9d

Don't panic on fake IDs

view details

Joshua Nelson

commit sha 20106d5a2fda0f2fef97ce253e5d78d4cf030289

unwrap() -> expect()

view details

Joshua Nelson

commit sha 24c3d85e66b0fd719d9ffa70ae5e56593cb9b644

Make sure that module_id is actually a module

view details

Joshua Nelson

commit sha 9542e23a7d915f50e84a048a5ed6aab34335ff52

Add tests for basic intra-doc links

view details

Joshua Nelson

commit sha 99f34d814e87e33e014433f791a13db3a3bd2273

Remove warnings

view details

Joshua Nelson

commit sha e78d499637761efceebf6f9cb8ab317a31541ec7

Add test for re-exports I had a hard time getting this to work without the `extern crate`, suggestions are welcome.

view details

push time in 6 days

pull request commentrust-lang/cargo

[WIP] Add flag to warn about unused dependencies

I've implemented doctests support, and I think I found a good design to giving rustc control over the lint level: if the arg is passed to print unused externs, rustc shall suppress emitting the unused externs lint, and document the lint level via the json message instead. Then cargo can read the level and use it to inform its decisions on the lint. Next step is to implement the design.

The doctest support breaks udeps output of cargo test --no-run because it waits with the lint emission until the doctests run (a doctest unit is created), but they never run, so it never emits the lints. I can think of two resolutions to this: either implement no-run mode for doctests, or make the code not generate a doctest unit if no_run is specified. I might want to do the former anyway so I'm holding back the latter until I know whether I want to do it or not.

est31

comment created time in 6 days

push eventest31/rust

est31

commit sha e8b26697a2f566089dc76f619760d8c9d667e6d6

Make doctests collect and emit the unused externs

view details

push time in 6 days

push eventest31/cargo

Carlos Pérez

commit sha 7553724e80061d749c6fba7799020eff97c18e91

Merge pull request #1 from rust-lang/master Update fork

view details

Alex Berghage

commit sha 1cea4cbe854a0cedb69e42058977c35a9b762bca

Allow populating CliUnstable from a HashMap This makes it easier to populate unstable options from configuration files. Might also help make unstable option tests easier to write.

view details

Alex Berghage

commit sha 4aede8c7847748c3b46afa176436387cf8f0593a

Allow setting unstable options in .cargo/config Obviously this only works with nightlies and all that, but if you're e.g. testing resolver v2, want to always have Ztiming on in your workspace, or something like that, this makes it easier to do.

view details

Alex Berghage

commit sha 9cb1ef88b6a7241773ebec42fdd959b065b10368

Allow both dashes and underscores for Z flags This makes it a little easier to match whatever the natural formatting is for where you're setting unstable options -- CLI or config file.

view details

Alex Berghage

commit sha c60da96b511ea48cacdbe6611b40698db7feb6f8

Update src/doc/src/reference/unstable.md Co-authored-by: Eric Huss <eric@huss.org>

view details

Alex Berghage

commit sha 6d7421cacb545496d57cfcd4b9eea89ed81ab03e

Clarify CliUnstable::parse/update_with_table These masquerade like construction functions, but they're in-place mutators since they're meant to be used one after another in a precedence chain.

view details

Alexander Berghage

commit sha 48a6f59ec368853fdc26c0a02f62cd8b99633804

Revert misfeatures Per comments on the PR, a couple changes need to be backed out.

view details

Alexander Berghage

commit sha bd938f077daf2cffd17ee3b136f53a430af40cc2

Switch unstable config parsing to serde Tests are currently failing, looks like there's something in the Deserializer impl that's forcing field-missing errors even when the serde `default` annotation is applied.

view details

Alexander Berghage

commit sha 14c32d4911b13d23a128222b1fda4e13b4a55a9c

[fixup] use single-line serde annotations

view details

Alex Berghage

commit sha c532c4964e1b0857b4928850a9bcc833a640af77

Treat all CliUnstable values as default-false This is a workaround in case y'all would like to land this change before I'm able to finish up a Deserializer refactor.

view details

Alex Berghage

commit sha 08f1020f4811939949adb8db5892a16ec68019e6

Drop broken test asserting invalid configs error on nightly The current behavior, with the default-false workaround in place, is not able to identify extra members of the `unstable` table, so it can't error on unexpected members. I'll add this test back in with a Deserializer refactor to clean up the extra logic added to CliUnstable.

view details

Alex Berghage

commit sha 62d62333c00832924aecd38ba003486c73c3de95

Revert workaround and patch Deserializer This patch changes how ConfigMapAccess iterates k/v pairs when deserializing structs. Previously we produced keys for exactly the set of fields needed for a struct, and errored out in the deserializer if we can't find anything for that field. This patch makes us produces keys from the union of two sets: 1. All fields that are both needed for the struct and can be found in the environment. 2. All fields in the config table. This change allows serde's codegen to handle both missing and unknown fields via the usual derive annotations (default or deny_unknown_fields respectively)

view details

Alex Berghage

commit sha 724273ed259381f95b10734d5c36667e43a2946a

Minor test fix (error text comparison) Serde's errors for missing fields are a lil' different than the ones from our Deserializer.

view details

Alex Berghage

commit sha 782b32bdfac5cc49d8b18c7cb533d5af4e76b789

clearer comment on doubleparse of cli flags

view details

Alex Berghage

commit sha 90b9c6a7631a6828a76dfc6468b2687af07a348c

fix nightly rustdoc-extern tests

view details

Alex Berghage

commit sha b82281ad944c6308f125ae1e437ab1a993d8d5dd

fix docs to drop reverted change

view details

Alex Berghage

commit sha e49b3aed792619368f90fe6b0dabe64aecc0774f

Add tests verifying overlapping prefixes and defaults These tests demonstrate the current failure mode around overlapping env keys and inner structs. To some extent this is a limitation of mapping on to environment variables with an underscore as both the namespace separator and the substitute for dashes in flag names in that the mapping is not strictly one-to-one.

view details

Alex Berghage

commit sha d035daae4e26bfe144ceff41f4c9a0bb11fea605

Fix tests for handling env key overlaps / errors

view details

bors

commit sha f35ebafc74fed12ba7c5f7c497a7e751889c11dd

Auto merge of #8393 - ludumipsum:unstable_flags_in_config, r=alexcrichton Allow configuring unstable flags via config file # Summary This fixes #8127 by mapping the `unstable` key in `.cargo/config` to Z flags. It should have no impact on stable/beta cargo, and on nightlies it gives folks the ability to configure Z flags for an entire project or workspace. This is meant to make it easier to try things like the [new features resolver](https://github.com/rust-lang/cargo/issues/8088) behavior, mtime-on-use, build-std, or timing reports across a whole project. I've also included a small (but entirely independent) ergonomics change -- treating dashes and underscores identically in Z flags. That's along for the ride in this PR as the last commit, and is included here because it makes for more idiomatic toml file keys (`print_im_a_teapot = yes` vs `print-im-a-teapot = yes`). Please let me know if y'all would prefer that be in a separate PR, or not happen at all. # Test Plan Apologies if I've missed anything -- this is my first cargo contrib and I've tried to hew to the contributing guide. If I've slipped up, please let me know how and I'll fix it. NB. My linux machine doesn't have multilib set up, so I disabled cross tests. * `cargo test` passes for each commit in the stack * I formatted each commit in the stack with `rustfmt` * New tests are included alongside the relevant change for each change * I've validated each test by locally undoing the code change they support and confirming failure. * The CLI wins, for both enable and disabling Z flags, as you'd expect. Keys in `unstable` which do not correspond with a Z flag will trigger an error indicating the invalid flag came from a config file read: ``` Invalid [unstable] entry in Cargo config Caused by: unknown `-Z` flag specified: an-invalid-flag ``` If you'd like to see a test case which isn't represented here, I'm happy to add it. Just let me know. # Documentation I've included commits in this stack updating the only docs page that seemed relevant to me, skimming the book -- `unstable.md`.

view details

Rustin-Liu

commit sha 773ab74b8781578b06c476ea7ed06cc8b35e374f

fix: add space to comments

view details

push time in 6 days

push eventRustAudio/rodio

Mac O'Brien

commit sha fb176a6883867ccd06a4e46a72bf9513348e1df6

Document PlayError and expose in public API

view details

est31

commit sha b376b91e9eadd78582aa4ee9428cac157cce82fb

Merge pull request #308 from cormac-obrien/expose-playerror Document PlayError and expose in public API

view details

push time in 6 days

PR merged RustAudio/rodio

Document PlayError and expose in public API

Currently, there are multiple public API methods which return Result<T, PlayError>:

  • Sink::try_new
  • SpatialSink::try_new
  • OutputStreamHandle::play_raw
  • OutputStreamHandle::play_once

However, PlayError is not exposed in the public API, so it can't be imported and doesn't generate documentation. It also has no doc comments. This PR resolves both problems.

+4 -1

0 comment

2 changed files

cormac-obrien

pr closed time in 6 days

issue closedRustAudio/rodio

Audio skips a lot

Whenever I play audio using this crate, the audio skips a lot, and playback is faster than normal. This only occurs when compiling unoptimized, with debug information. Compiling for release fixes the issue.

Using the example code in the docs:

let sink = Sink::new(&device);
let source = rodio::source::SineWave::new(440);
ink.append(source);
thread::sleep(Duration::from_millis(1000));

I'm using Ubuntu 18.04 cargo 1.45.0 (744bd1fbb 2020-06-15)

closed time in 6 days

dyc3

issue commentRustAudio/rodio

Audio skips a lot

You can compile dependencies only in release mode. https://doc.rust-lang.org/cargo/reference/profiles.html#overrides

IDK what rodio can do to improve this. If you have any ideas, PRs are welcome.

dyc3

comment created time in 6 days

PR closed rust-lang/cargo

Return (Result<(),E>,) in drain_the_queue S-waiting-on-review

This refactors the drain_the_queue function to return a tuple containing Result. That way, it's still not possible to use ? or try! to handle errors, but for readers of the function declaration it's clearer now that the error actually indicates one.

Bonus: it makes the calling code of drain_the_queue simpler.

+11 -12

4 comments

1 changed file

est31

pr closed time in 6 days

pull request commentrust-lang/cargo

Return (Result<(),E>,) in drain_the_queue

Ok I'll include it in #8437 instead, where I'm putting a value into the happy path of the Result, so the option will cease to be viable.

est31

comment created time in 6 days

pull request commentrust-lang/cargo

Return (Result<(),E>,) in drain_the_queue

I got the idea for this while working on #8437 as I was wondering how to return something in the case no error happened. It's okay if you reject this PR now, I can also include it as a commit in #8437.

est31

comment created time in 7 days

create barnchest31/cargo

branch : queue_drain_refactor

created branch time in 7 days

PR opened rust-lang/cargo

Return (Result<(),E>,) in drain_the_queue

This refactors the drain_the_queue function to return a tuple containing Result. That way, it's still not possible to use ? or try! to handle errors, but for readers of the function declaration it's clearer now that the error actually indicates one.

Bonus: it makes the calling code of drain_the_queue simpler.

+11 -12

0 comment

1 changed file

pr created time in 7 days

issue openedsyhw/wer_are_we

Include "Conformer: Convolution-augmented Transformer for Speech Recognition"

https://arxiv.org/abs/2005.08100

On the widely used LibriSpeech benchmark, our model achieves WER of 2.1%/4.3% without using a language model and 1.9%/3.9% with an external language model on test/testother. We also observe competitive performance of 2.7%/6.3% with a small model of only 10M parameters.

created time in 7 days

issue commentRustAudio/rodio

Seeking

Already 1 minute of samples at 48000 samples per seconds with 2 bytes per sample would mean 5760k or 6 mb of memory use. If it's an opt-in feature, people can use it if they want but optimally one would have seeking support in all of the libraries that rodio uses, then make rodio abstract over it.

SirWindfield

comment created time in 7 days

issue commentrust-lang/rust

`--message-format json` doesn't apply to rustdoc coverage output

Yeah it's part of a larger problem. For example, rustdoc also doesn't pass on json params to the sub compiler invocations it performs when doing doctests. And it has a bunch of eprintln! sprinkled across the codebase, all not abiding the json format.

Nemo157

comment created time in 7 days

issue commentRustAudio/rodio

Seeking

Yeah it'd be very CPU and RAM intensive and not a good idea. Some people may want to play back 10 hours of background music or something all in one file...

SirWindfield

comment created time in 7 days

push eventKOBUGE-Games/godot-httpd

Dirk Krause

commit sha 8d606ef73356c010aae9f4802639166b27603ab5

replace RawArray with PoolByteArray ... and it works with 3.1!

view details

push time in 7 days

PR merged KOBUGE-Games/godot-httpd

replace RawArray with PoolByteArray

... and it works with 3.1!

+2 -2

0 comment

1 changed file

dirkk0

pr closed time in 7 days

issue commentrandombit/botan-rs

Better errors

I just found https://github.com/randombit/botan/blob/2e1540735713d17d4c736ca288765f3e26f03416/src/lib/ffi/ffi.cpp#L22 which should be enough for my purposes. I can absolutely set an env var.

To add an idea, there could be a global variable based method (kinda like errno) to store the error. Access would be possible through a function to retrieve error information, this way one wouldn't need a separate FFI api. It could be implemented by a thread_local variable, which are present in C++ since C++11. It seems that botan requires C++11 already, so this shouldn't be an issue? What do you think?

Another approach I thought about was using the C++ API directly, but Rust sadly can't catch C++ errors.

est31

comment created time in 7 days

Pull request review commentrandombit/botan-rs

Add a vendored feature to both the botan and botan-sys crates

+[package]+name = "botan-src"+version = "0.1.0+2.15.0"+authors = ["Rodolphe Breard <rodolphe@what.tf>"]

The crate itself is new but most of the code is not and was not written by you, as it includes the full source code of the botan C library.

breard-r

comment created time in 9 days

Pull request review commentrandombit/botan-rs

Add a vendored feature to both the botan and botan-sys crates

+[package]+name = "botan-src"+version = "0.1.0+2.15.0"+authors = ["Rodolphe Breard <rodolphe@what.tf>"]

I fully wrote this new botan-src crate

It's mostly @randombit 's source code that's inside the crate, no?

breard-r

comment created time in 9 days

Pull request review commentrandombit/botan-rs

Add a vendored feature to both the botan and botan-sys crates

+[package]+name = "botan-src"+version = "0.1.0+2.15.0"+authors = ["Rodolphe Breard <rodolphe@what.tf>"]

This should probably be adjusted

breard-r

comment created time in 9 days

pull request commentrandombit/botan-rs

Add a vendored feature to both the botan and botan-sys crates

:+1: I want to add botan as one of the verifier libraries of rcgen but I dont want to burden people with installing a package just for running rcgen locally.

breard-r

comment created time in 9 days

issue openedrandombit/botan-rs

Better errors

It would be great if one would have nicer errors. I'm trying to load this certificate:

-----BEGIN CERTIFICATE-----
MIIC/jCCAeagAwIBAgIBKjANBgkqhkiG9w0BAQsFADAuMRIwEAYDVQQDDAlNYXN0
ZXIgQ0ExGDAWBgNVBAoMD0NyYWIgd2lkZ2l0cyBTRTAgFw03NTAxMDEwMDAwMDBa
GA80MDk2MDEwMTAwMDAwMFowLjESMBAGA1UEAwwJTWFzdGVyIENBMRgwFgYDVQQK
DA9DcmFiIHdpZGdpdHMgU0UwggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIB
AQDYjmgyV3/LSizJXrYrATZrrPr2Edo8yiOgBLFmi4sgeGdQ5n6nhjTGfBEIP2Ia
6z+hbiGOMncabEBczkdME+JFYVCSkS7r4ivMOzp2egxLgcPKcerBoXI8DUbHhIR9
z89lHiPHDJv3+d0Ac1b9bz9b8OAeZWiQmFvmjpbc2DfhQ2OFx2MwFZCYF196rrXO
c6/SR2esZVRrkW22RBKFTgz6GIA5A/5VWKIISSqEB1gOcMz2iq5987I28+Ez4rcL
Z2lB7cZ7TbNxkAwt0fPL+EuyP7XOzbIj4/kSAlU5xfwNERa3BEuOFro4i5EmSDj+
lR5xdRpFnx0j5zOozUL2lHG9AgMBAAGjJTAjMCEGA1UdEQQaMBiCC2NyYWJzLmNy
YWJzgglsb2NhbGhvc3QwDQYJKoZIhvcNAQELBQADggEBAEp3HQAjMLiXcPqDW+BO
O5Vutm24ccaMEBKoQ3QhEuP9Ck15tA5dIuSNxHjGNIrQ8KBfTxdOEu41oIRzvCCF
4hnDeJArATYM4Nwq+MMVRxavdUj2E1QZ8d4qgJaiUdAIkM12iTpn88TJjBFDsJ29
LWfqbAJj83CscgbeGf7iKV5InEiPZ/MRfpm3fkTsJ8JduI9dTeO51VXy3UpTbxRT
8t+qh9GV549otsYH7m+wvubX7xwQ+wIVy1a57xGEWwWilXqKqnQrccAdc/mPV2O3
JiNzuZmfz+fzvyVxZZXlGb6ny4IqdO7TnkLKzMJxEsR8M+bZa+tdHL7uCNX7u86f
cAo=
-----END CERTIFICATE-----

It gives the error BadParameter, which is not very informative. The botan CLI tool gives me a much better error: X509_Certificate parsing failed Time 40960101000000Z does not seem to be valid.

created time in 9 days

issue commentrust-lang/rust

Make `pub` in a binary be equivalent to `pub(crate)`

@jhpratt it's a level above the compiler, kinda like cargo-udeps. It requires save-analysis of all crates in the workspace as input. in order to support "go to places that use this", save analysis contains (thing_a -> thing_b) relationships when e.g. the thing_a function uses the thing_b function. the tool uses that info to find things that aren't used by anything else. It currently only supports one binary crate, but that's only an implementation limitation.

Anyways, the warnalyzer tool is in prototype phase, needs porting to rust-analyzer, and will always require some kind of manual user input about which crates a library crate is to be used by. Treating pub in binaries as pub(crate) can always run on the other hand, so the change should be done as well. Just wanted to make sure you are aware of warnalyzer :).

jhpratt

comment created time in 10 days

issue commentrust-lang/rust

Make `pub` in a binary be equivalent to `pub(crate)`

Ideally it would be cool to go even further, to have unused lints across crates. Many crates are only used by crates inside the same project, and their pub items may or may not be used by those crates. I've built something based on save-analysis a while ago but discontinued its development. https://github.com/est31/warnalyzer

jhpratt

comment created time in 10 days

issue commentrust-lang/rust

WebAssembly size regression between 1.40 and 1.41

Btw, why is there n/a pkg/squooshhqx_bg.wasm in 1.40? Could these files not be produced or some other reason?

Yeah wasm-pack hangs in the wasm-opt step for minutes. Eventually I just aborted it. Files were generated but no idea whether they were functional or not, so I excluded them.

Oh, also note that you're using -O3 not -Os - probably the reason why output files in 1.40 in your experiment are larger than mine, even after wasm-snip.

Good point! Personally I prefer -O3 because most times I've experienced that -Os creates barely smaller binaries and in fact sometimes -O3 created smaller ones probably because of some optimization. Same here, there is barely any difference, if there's any at all it has to be in the sub kb range. I'm getting the following sized after replacing -O3 with -Os:

1.40:

$ wasm-pack build --target web --
236K    pkg/squooshhqx_bg_snip_opt.wasm

$ wasm-pack build --target web -- --no-default-features
240K    pkg/squooshhqx_bg_snip_opt.wasm

$ wasm-pack build --target web -- --no-default-features --features wee_alloc
232K    pkg/squooshhqx_bg_snip_opt.wasm

1.41:

$ wasm-pack build --target web --
324K    pkg/squooshhqx_bg_snip_opt.wasm

$ wasm-pack build --target web -- --no-default-features
328K    pkg/squooshhqx_bg_snip_opt.wasm

$ wasm-pack build --target web -- --no-default-features --features wee_alloc
324K    pkg/squooshhqx_bg_snip_opt.wasm
RReverser

comment created time in 10 days

issue commentrust-lang/rust

WebAssembly size regression between 1.40 and 1.41

Just tried it again, disabling console_error_panic_hook plus running wasm-snip on the un-wasm-opt'd binary (followed by wasm-opt) reduces the wasm file size significantly compared to the baseline. However, there is still a regression between 1.40 and 1.41, probably due to std increases?

commands run after each wasm-pack command:
wasm-snip target/wasm32-unknown-unknown/release/squooshhqx.wasm --snip-rust-panicking-code -o pkg/squooshhqx_bg_snip.wasm
wasm-opt -O3 --dce  -o pkg/squooshhqx_bg_snip_opt.wasm 

----

1.40.0:

$ wasm-pack build --target web --
n/a     pkg/squooshhqx_bg.wasm
668K target/wasm32-unknown-unknown/release/squooshhqx.wasm
304K    pkg/squooshhqx_bg_snip.wasm
236K    pkg/squooshhqx_bg_snip_opt.wasm

$ wasm-pack build --target web -- --no-default-features
n/a     pkg/squooshhqx_bg.wasm
700K    target/wasm32-unknown-unknown/release/squooshhqx.wasm
308K    pkg/squooshhqx_bg_snip.wasm
240K    pkg/squooshhqx_bg_snip_opt.wasm

$ wasm-pack build --target web -- --no-default-features --features wee_alloc
n/a     pkg/squooshhqx_bg.wasm
668K    target/wasm32-unknown-unknown/release/squooshhqx.wasm
304K    pkg/squooshhqx_bg_snip.wasm
232K    pkg/squooshhqx_bg_snip_opt.wasm

1.41.0:

$ wasm-pack build --target web --
384K    pkg/squooshhqx_bg.wasm
760K    target/wasm32-unknown-unknown/release/squooshhqx.wasm
392K    pkg/squooshhqx_bg_snip.wasm
324K    pkg/squooshhqx_bg_snip_opt.wasm

$ wasm-pack build --target web -- --no-default-features
388K    pkg/squooshhqx_bg.wasm
792K    target/wasm32-unknown-unknown/release/squooshhqx.wasm
392K    pkg/squooshhqx_bg_snip.wasm
328K    pkg/squooshhqx_bg_snip_opt.wasm

$ wasm-pack build --target web -- --no-default-features --features wee_alloc
384K    pkg/squooshhqx_bg.wasm
760K    target/wasm32-unknown-unknown/release/squooshhqx.wasm
392K    pkg/squooshhqx_bg_snip.wasm
324K    pkg/squooshhqx_bg_snip_opt.wasm
RReverser

comment created time in 10 days

push eventRustAudio/deepspeech-rs

est31

commit sha f94b98d429bdac30b9b9aaa048946537b6ebd575

Update the DeepSpeech version we advertise support for

view details

push time in 11 days

issue closedRustAudio/rodio

Does not build on iOS

Attempting to build a rodio-dependent static library for iOS using lipo yields the following error:

error: failed to run custom build command for `coreaudio-sys v0.2.5`

Caused by:
  process didn't exit successfully: `/Users/johnwatson/Projects/rodio-demo/target/release/build/coreaudio-sys-ff45525eed014540/build-script-build` (exit code: 101)
--- stdout
cargo:rerun-if-env-changed=COREAUDIO_SDK_PATH
cargo:rustc-link-lib=framework=AudioUnit
cargo:rustc-link-lib=framework=CoreAudio
cargo:rerun-if-env-changed=BINDGEN_EXTRA_CLANG_ARGS
cargo:warning=couldn't execute `llvm-config --prefix` (error: No such file or directory (os error 2))
cargo:warning=set the LLVM_CONFIG_PATH environment variable to the full path to a valid `llvm-config` executable (including the executable itself)

It looks like there may be a similar/related open issue in the repo for coreaudio-sys? https://github.com/RustAudio/coreaudio-sys/issues/29

closed time in 11 days

johnnyw

issue commentRustAudio/rodio

Does not build on iOS

I'd say this is a dupe of the bug you linked. Also, it's a build failure in the coreaudio-sys crate so it's better to report it there. Thanks!

johnnyw

comment created time in 11 days

issue commentrust-lang/rust

WebAssembly size regression between 1.40 and 1.41

Doesn't work, just checked it. See also https://github.com/rustwasm/team/issues/19

RReverser

comment created time in 11 days

issue commentrust-lang/rust

WebAssembly size regression between 1.40 and 1.41

@RReverser have you enabled console_error_panic_hook or is it disabled? If the feature is disabled, it's possible that the info is all gone.

RReverser

comment created time in 11 days

created tagRustAudio/deepspeech-rs

tagv0.8.0

Rust bindings for the deepspeech library

created time in 11 days

push eventRustAudio/deepspeech-rs

est31

commit sha 64f2b0157febaaef56607c218f9c169c055f3f94

Cargo update

view details

est31

commit sha f62b7376252c3528636cef821e3b43863f78c3c1

Release 0.8.0

view details

push time in 11 days

push eventRustAudio/deepspeech-rs

est31

commit sha 5c598309fdb95c16e8bcbb626417b959bea11180

Silence a warning Otherwise it'd report that Library is unused, which is true when library is just (), but we need it for the case where the dynamic feature is enabled.

view details

est31

commit sha 2afb08e664735b62a2f132ba1adca5344fdddc2d

Release 0.8.0 of sys crate

view details

push time in 11 days

fork est31/quic-p2p

peer-to-peer communications library for Rust based on QUIC protocol

fork in 11 days

push eventRustAudio/deepspeech-rs

est31

commit sha b39ad1dbf514821007a5e7d6289b53890d56d069

Update the submodule to v0.8.0

view details

push time in 12 days

pull request commentrust-lang/cargo

[WIP] Add flag to warn about unused dependencies

Sounds fair! I'll think a bit about other approaches that satisfy the demands of the cargo team.

Note though that I won't have that much time to work on it in the next few months. The next thing I'll focus on will probably be json output for rustdoc errors. The mode will be required for implementation methods.

est31

comment created time in 13 days

issue commentRustAudio/rodio

Rust files in examples folder does not work

@cbondurant yes the API will change in the upcoming release. Either depend on the git version of rodio, or use examples from the 0.11.0 release commit in this repo.

cbondurant

comment created time in 14 days

issue closedRustAudio/rodio

Rust files in examples folder does not work

I was inspecting the /examples folder of this repository to help figure out issues I was having with using the filters for rodio, and noticed that none of the examples correctly compile.

This seems to be because OutputSink and rodio::Sink::try_new do not exist.

Im currently using the newest version of rodio: 0.11.0 on rust 1.41.0

closed time in 14 days

cbondurant

issue commentRustAudio/rodio

Docs example doesn't play sound on Windows

I'd say so, yes. Playback is non-blocking.

vladinator1000

comment created time in 14 days

push eventRustAudio/deepspeech-rs

est31

commit sha d302b4110ac2dc2c935f87c0d403e16cc0da809e

Update the submodule to v0.8.0-alpha.8

view details

push time in 15 days

push eventRustAudio/cpal

Richard Mitic

commit sha cb49e4446c3fd1d5ea7af624905d8f3da4de9356

Use alsa::pcm::Frames in alsa API calls instead of fixed-width integers. `alsa::pcm::Frames` resolves to `c_long` which is 32 bits when compiling for raspberry pi (armv7l).

view details

est31

commit sha ecbb026e2b6ba702813f62869841784a2849cb48

Merge pull request #457 from richardmitic/raspberry-pi-c-long Use alsa::pcm::Frames in alsa API calls instead of fixed-width integers.

view details

push time in 15 days

PR merged RustAudio/cpal

Use alsa::pcm::Frames in alsa API calls instead of fixed-width integers.

alsa::pcm::Frames resolves to c_long which is 32 bits instead of 64 when compiling for raspberry pi (armv7l).

+1 -1

0 comment

1 changed file

richardmitic

pr closed time in 15 days

issue commentRustAudio/rodio

Docs example doesn't play sound on Windows

A PR would be greatly welcomed! Regarding the sound issues, you might be running into #303 .

vladinator1000

comment created time in 16 days

issue commentRustAudio/rodio

Docs example doesn't play sound on Windows

Hmm yeah so I guess that's a problem with the example.

vladinator1000

comment created time in 16 days

issue commentRustAudio/rodio

Docs example doesn't play sound on Windows

Yeah cargo run is what should create a sound. Can you test the cpal examples?

git clone https://github.com/RustAudio/cpal
cargo run --example beep
vladinator1000

comment created time in 16 days

issue commentRustAudio/rodio

Docs example doesn't play sound on Windows

The api has changed, see https://github.com/RustAudio/rodio/blob/master/src/lib.rs#L23

vladinator1000

comment created time in 16 days

issue commentRustAudio/rodio

Docs example doesn't play sound on Windows

Can you try rodio from git? rodio = { git = "https://github.com/RustAudio/rodio" }

vladinator1000

comment created time in 16 days

pull request commentrust-lang/cargo

[WIP] Add flag to warn about unused dependencies

We explicitly are trying to avoid a system of managing lints in Cargo.

Who is "we" in that sentence? You? The entire cargo team? Most of the complexity of a "lints for cargo" system would already be covered by #5034 , so not really be a cost introduced by the unused dependencies lint.

It would also require the addition of a "non fatal error" in rustc where if the lint is #[deny]'d then it wouldn't actually halt compilation or fail compilation, instead the final status code would be left up to Cargo.

It would make the unused dependencies lint different from all other lints. Furthermore, cargo wouldn't just always re-emit that warning/error unchanged if it wants to support "this should rather be a dev-dependency" or (in the future) "this should rather be a bin-dependency" like messages (wich this PR already does). So the entire distinction would have to be emitted by cargo.

Another issue would be that it would make doctests more complicated. Rustdoc has to collect the reports of all doc snippets and combine them. The more simple the format is, the easier this combination. It also offloads a lot of the ugly hacks to rustc so not sure whether the rustc team will support that (or the rustdoc team).

est31

comment created time in 18 days

pull request commentrust-lang/cargo

[WIP] Add flag to warn about unused dependencies

@alexcrichton if I have this code:

fn hello() {
}
mod foo {
}
mod bar {
}

Then why should a #[allow(unused)] on mod bar silence the unused warning for hello? Adding #[allow(unused_dependencies)] to lib.rs would be the same concept. The units are the modules, conceptually.

Also see the PR description of https://github.com/rust-lang/rust/pull/73945 for further issues with that approach under the "Why not pass -Wunused-crate-dependencies?" section.

For controlling lint levels, I think that cargo should think about ways of allowing/denying lints for all units in a crate or even workspace, as that's usually what people want when they control lints in their crate lib.rs root (#5034). Control over the unused dependencies lint could build on that. Depending on the name, if it starts with cargo::, it could interpret the lint as a cargo lint, or if not, pass it to rustc via a flag. The system already exists to distinguish clippy from rustc lints. Clippy lints start with clippy::. Cargo already emits other warnings. Maybe it would be useful to convert some of them into "cargo lints".

est31

comment created time in 19 days

issue commentRustAudio/cpal

[asio] Asio does not work in Cpal 0.12.0 from crates.io

0.12.1 is out and should have the fix. Please test and report if it's broken!

HEnquist

comment created time in 19 days

push eventRustAudio/cpal

est31

commit sha 7a8f017b1d442408035a86d28bab07011aa10de3

Release 0.12.1 (#456)

view details

push time in 19 days

PR merged RustAudio/cpal

Release 0.12.1

Followup of #455 to fix #450 .

+5 -1

0 comment

2 changed files

est31

pr closed time in 19 days

PR opened RustAudio/cpal

Release 0.12.1

Followup of #455 to fix #450 .

+5 -1

0 comment

2 changed files

pr created time in 19 days

create barnchest31/cpal

branch : release_0_12_1

created branch time in 19 days

push eventRustAudio/cpal

est31

commit sha 822d9da643264068d446e19326dbd47a325b01ad

Update repo url of asio-sys

view details

est31

commit sha 0b185514b8dbb919cfb7a5c105acefa01a28f7da

Release asio-sys 0.2.0

view details

est31

commit sha 42ee11affca2b3e0e4f23c65d21eb3ecbe708348

Depend on version 0.2 of asio-sys

view details

est31

commit sha 7021c717a24bfc5c998946e6d7850349072872b9

Merge pull request #455 from est31/asio-sys-release Release asio-sys 0.2.0

view details

push time in 19 days

PR merged RustAudio/cpal

Release asio-sys 0.2.0

Fixes #450

+3 -3

2 comments

2 changed files

est31

pr closed time in 19 days

issue closedRustAudio/cpal

[asio] Asio does not work in Cpal 0.12.0 from crates.io

There seems to be an issue with the packaging of the asio-sys crate. When building a project that uses the Cpal crate from crates.io, it also downloads a quite outdated version of asio-sys from crates.io. It seems the version that is included in the cpal repository doesn't get included in the cpal crate. The result is that the build fails because the old asio-sys is missing things. Shouldn't the asio-sys crate be broken out to a separate repo, with a proper version number?

closed time in 19 days

HEnquist

push eventest31/cpal

est31

commit sha 0b185514b8dbb919cfb7a5c105acefa01a28f7da

Release asio-sys 0.2.0

view details

est31

commit sha 42ee11affca2b3e0e4f23c65d21eb3ecbe708348

Depend on version 0.2 of asio-sys

view details

push time in 19 days

pull request commentRustAudio/cpal

Release asio-sys 0.1.1

Hmm yeah good point

est31

comment created time in 19 days

PR opened RustAudio/cpal

Release asio-sys 0.1.1

Fixes #450

+2 -2

0 comment

1 changed file

pr created time in 19 days

create barnchest31/cpal

branch : asio-sys-release

created branch time in 19 days

push eventRustAudio/cpal

est31

commit sha 13041efbfd11659fa188ba0156c8a399f51b3316

Update bindgen dep of asio-sys to 0.54.0 and num-derive to 0.3 (#454)

view details

push time in 19 days

PR merged RustAudio/cpal

Asio-sys dependency updates

Fix #453

+2 -2

0 comment

1 changed file

est31

pr closed time in 19 days

issue closedRustAudio/cpal

Unable to build with asio feature

when trying to build with the asio feature it seems to fail as there is a conflict in the versions of clang that it wants Cargo.toml

[package]
name = "client"
version = "0.1.0"
authors = ["Zomatree <39768508+zomatree@users.noreply.github.com>"]
edition = "2018"

[dependencies]
cpal = { git = "https://github.com/RustAudio/cpal", features = ["asio"] }

output:

PS C:\Users\Zoomatree\Documents\Coding\Rust\client> cargo build
    Updating git repository `https://github.com/RustAudio/cpal`
    Updating crates.io index
error: failed to select a version for `clang-sys`.
    ... required by package `bindgen v0.51.0`
    ... which is depended on by `asio-sys v0.1.0 (https://github.com/RustAudio/cpal#997fb9fa)`
    ... which is depended on by `cpal v0.12.0 (https://github.com/RustAudio/cpal#997fb9fa)`
    ... which is depended on by `client v0.1.0 (C:\Users\Zoomatree\Documents\Coding\Rust\client)`
versions that meet the requirements `^0.28.0` are: 0.28.1, 0.28.0

the package `clang-sys` links to the native library `clang`, but it conflicts with a previous package which links to `clang` as well:
package `clang-sys v0.29.3`
    ... which is depended on by `bindgen v0.53.3`
    ... which is depended on by `coreaudio-sys v0.2.5`
    ... which is depended on by `coreaudio-rs v0.9.1`
    ... which is depended on by `cpal v0.12.0 (https://github.com/RustAudio/cpal#997fb9fa)`
    ... which is depended on by `client v0.1.0 (C:\Users\Zoomatree\Documents\Coding\Rust\client)`

failed to select a version for `clang-sys` which could resolve this conflict

closed time in 19 days

zomatree

PR opened RustAudio/cpal

Asio-sys dependency updates

Fix #453

+2 -2

0 comment

1 changed file

pr created time in 19 days

push eventest31/cpal

JoshuaBatty

commit sha f762e5dd8f7e86084648497542ff4f4ac202cb6f

prototyping an API for getting min and max buffersize

view details

JoshuaBatty

commit sha 919722a785af42bbf84bd522fadad22285956378

with_sample_rate_and_buffer_size sample_rate is set to self.max_sample_rate

view details

JoshuaBatty

commit sha 7eb45bca6fb9e9274eb71574796087891e96b6c6

cargo fmt

view details

JoshuaBatty

commit sha 7081c3bbd66487d2cec2262b7757374714f45b50

wip alsa buffersizes

view details

JoshuaBatty

commit sha d72b546dcaf98336a958c0e21a62182c3d457570

gets buffersize range and allows to set buffersize for alsa

view details

JoshuaBatty

commit sha 6edee6c6c22b6cf5f91a234243faf70be50cf76c

coreaudio buffersize wip

view details

JoshuaBatty

commit sha 9e660da433762220a62bb3a70404e6cafaa3b8a3

implemented buffersizes for asio

view details

JoshuaBatty

commit sha 4cd9d0bcec129b8b1a9d7e0c09221405c518f0f9

finished implementing buffersizes for coreaudio

view details

JoshuaBatty

commit sha 935fa280d3fe5cde7f4c8ab0acd2485e54e55f4d

buffersizes api for wasapi

view details

JoshuaBatty

commit sha cf1a928b84dd1a12973ca8331aa54118a7ebdfcc

reset examples

view details

JoshuaBatty

commit sha 7c1adce33064f97064179c258742c126f4c16ab4

adds support for buffersizes in webaudio and emscripten

view details

JoshuaBatty

commit sha 9c85eecb598716f4f6261dbd0fb4fe30ed5bbaa8

cargo fmt fix

view details

JoshuaBatty

commit sha 10599ac8267600ed487a0171ff32dfebe882e388

fixed coreaudio buffersize errors

view details

JoshuaBatty

commit sha 271cc34f3f749314887dbcb95946504ca1e9f4d6

cargo fmt fix for coreaudio

view details

est31

commit sha 6ec1953424bb9ab1982a25a16c0ed80af5c982df

Disable cargo publish invocation (#444) To allow pushing to master after the 0.12.0 release. The 0.12.0 release will be uploaded manually.

view details

est31

commit sha da40ea723eef1bc9007fad4c58d944a3ffe9bbb3

Reenable the publish github workflow (#445) The manual release of 0.12.0 is done. Hopefully the issue is now resolved and in the future the CI can do it automatically.

view details

JoshuaBatty

commit sha 4ce12a69b9b687ac16129683ca80545a9412907e

adds docs for BufferSize and fixes buffersize bugs in emscripten and alsa

view details

JoshuaBatty

commit sha f285389002803dd98ea00ccb90c33be5223cc151

fixed mismatched types in emscipten set_timeout

view details

JoshuaBatty

commit sha e854c4e54cdd3d6a498a7b4dd786f17eab519ac1

added in sniperrifle2004 code from PR 431

view details

JoshuaBatty

commit sha e739dbf32d82c4ce88ec3f301dff742b9181e3bf

cargo fmt

view details

push time in 19 days

create barnchest31/cpal

branch : asio-sys-dependency-updates

created branch time in 19 days

issue commentRustAudio/cpal

Unable to build with asio feature

Good catch. I'm not sure what's going on here. Anyways, it should be pretty easy to update bindgen in asio.

zomatree

comment created time in 19 days

Pull request review commentrust-lang/cargo

Prepare for not defaulting to master branch for git deps

 impl<'a> ser::Serialize for Resolve {             root: None,             metadata,             patch,+            version: match self.version() {+                ResolveVersion::V3 => Some(1),

I'm getting back into this sub-discussion for this one comment only. The format has changed prior to the "lockfiles 2.0" change. Some examples:

  • 5430db61f6c2668ec94945c91a1df22015ff1cf8 has put checksums into Cargo.lock... yes there used to be a time when there were no checksums :p.
  • #4571 has removed [root]
  • #6180 has added a @generated comment at the top
  • #7070 added the new format commonly referred to as lockfiles v2

Not guaranteeing for completeness of this list. I'm not sure what the "perfect" version number should be. But if #7070 says that it introduced lockfiles v2, even if that was technically wrong, it's better to continue with 3 than jumping over version numbers or starting with 1 again.

I've also wondered about semver lockfile versions where the major version indicates compatibility breakage (like the one which this PR introduces) and the minor version indicates small changes that don't break older cargo's but cargo may not generate the lockfile 100% the same way, e.g. #6180 would be one such change. If cargo supports writing lockfiles with the major version but the minor version is unsupported, it should do a more thorough check than a strcmp and only update if needed (to prevent needless back and forth, and only have back and forth if there is a different reason to update the lockfile). Basically I propose getting control flow into the body of this if check if the minor version is unsupported but the major is. The reason why I haven't proposed this earlier was because I doubt that there could be minor version increases like the generated comment addition in the future. Maybe my imagination is limited, idk. The version can be made semver in the future as well, it'd require breaking support for old cargo, aka a major number increase, and mess up the nice error messages for old cargo (turn "this version isn't supported" into "expected number, got string"). It's really a bikeshed.

alexcrichton

comment created time in 19 days

issue commentrust-lang/cargo

Should a version indicator be encoded into `Cargo.lock`

PR #8522 has been opened to add such version numbers.

alexcrichton

comment created time in 19 days

IssuesEvent

issue commentRustAudio/cpal

Unable to build with asio feature

Oh wait, no this is its own bug. Sorry about that!

This should be resolveable by updating the deps of asio-sys. Do you want to file a PR, @zomatree ?

zomatree

comment created time in 20 days

issue commentRustAudio/cpal

[asio] Asio does not work in Cpal 0.12.0 from crates.io

I can't publish an asio-sys update, only @mitchmindtree can, so we'll have to wait until they've got time.

HEnquist

comment created time in 20 days

issue closedRustAudio/cpal

Unable to build with asio feature

when trying to build with the asio feature it seems to fail as there is a conflict in the versions of clang that it wants Cargo.toml

[package]
name = "client"
version = "0.1.0"
authors = ["Zomatree <39768508+zomatree@users.noreply.github.com>"]
edition = "2018"

[dependencies]
cpal = { git = "https://github.com/RustAudio/cpal", features = ["asio"] }

output:

PS C:\Users\Zoomatree\Documents\Coding\Rust\client> cargo build
    Updating git repository `https://github.com/RustAudio/cpal`
    Updating crates.io index
error: failed to select a version for `clang-sys`.
    ... required by package `bindgen v0.51.0`
    ... which is depended on by `asio-sys v0.1.0 (https://github.com/RustAudio/cpal#997fb9fa)`
    ... which is depended on by `cpal v0.12.0 (https://github.com/RustAudio/cpal#997fb9fa)`
    ... which is depended on by `client v0.1.0 (C:\Users\Zoomatree\Documents\Coding\Rust\client)`
versions that meet the requirements `^0.28.0` are: 0.28.1, 0.28.0

the package `clang-sys` links to the native library `clang`, but it conflicts with a previous package which links to `clang` as well:
package `clang-sys v0.29.3`
    ... which is depended on by `bindgen v0.53.3`
    ... which is depended on by `coreaudio-sys v0.2.5`
    ... which is depended on by `coreaudio-rs v0.9.1`
    ... which is depended on by `cpal v0.12.0 (https://github.com/RustAudio/cpal#997fb9fa)`
    ... which is depended on by `client v0.1.0 (C:\Users\Zoomatree\Documents\Coding\Rust\client)`

failed to select a version for `clang-sys` which could resolve this conflict

closed time in 20 days

zomatree

issue commentRustAudio/cpal

Unable to build with asio feature

Dupe of #450

zomatree

comment created time in 20 days

issue commentSergioBenitez/Rocket

Compile with stable Rust

rocket

SergioBenitez

comment created time in 20 days

more