profile
viewpoint

bbcmicrobit/micropython 459

Port of MicroPython for the BBC micro:bit

ericsnowcurrently/interpreters 3

Python-level access to CPython's C-level subinterpreters API.

ericsnowcurrently/AzureNotebooks 1

Repo for tracking issues and hosting samples for Azure Notebooks

ericsnowcurrently/cpython 1

The Python programming language

ericsnowcurrently/aiohttp 0

Async http client/server framework (asyncio)

ericsnowcurrently/bedevere 0

A bot to help identify missing information for CPython pull requests

ericsnowcurrently/cherry-picker 0

🐍🍒⛏ Utility script for backporting/cherry-picking CPython changes from master into one of the maintenance branches.

ericsnowcurrently/cpython-mirror 0

Semi-official read-only mirror of the CPython Mercurial repository

ericsnowcurrently/cython 0

The most widely used Python to C compiler

ericsnowcurrently/devbox 0

tools for isolated development

issue commentmicrosoft/vscode-python

Argument suggestions for some functions in the pytorch module are duplicated when using Jedi

@CatNofishing, the Python extension ships with a vendored copy of Jedi, located in "[<extension dir>])https://code.visualstudio.com/docs/editor/extension-gallery#_where-are-extensions-installed)/pythonFiles/lib/python/" and uses that install explicitly for completions, etc. when configured to use Jedi. So to use a newer version you will need to manually replace the vendored copy with the newer one:

#PYEXT_DIR=~/.vscode/extensions/ms-python.python-$(code --list-extensions --show-versions | grep ms-python.python | awk -F'@' '{print $2}')
cd $PYEXT_DIR/pythonFiles/lib
mv jedi jedi.orig
python3 -m pip install --target . jedi

Doing that is fine as a one-off to see if the newer Jedi fixes the problem, but the proper solution is for the Python extension to update the vendored copy.

So if you feel up to manually installing the newer Jedi version, please give it a try. Otherwise we'll need to investigate further on our end. Either way, please let us know. Thanks!

CatNofishing

comment created time in 2 days

issue commentmicrosoft/vscode-python

Python extension not able to recognize installed modules immediately

@kevtan, open the "View" menu and select "Output". Then in the output panel click on the pull-down menu (probably says "Tasks") and select "Python". That will switch it to the "Python" output panel.

3627pranav

comment created time in 2 days

issue commentmicrosoft/vscode-python

Font messed up Lexend Deca Windows

@davidwarshawsky, thanks for letting us know about this. From the image you provided, it seems that the text in the editor panel is all jumbled. Is that the problem you are seeing? If so, this is likely an issue for the VS Code to resolve and I recommend opening an issue on that project.

I believe it is the python extension that is messed up(possibly linting)

Perhaps I've misunderstood the problem. What is the relationship between the problem and the Python extension? Thanks!

davidwarshawsky

comment created time in 2 days

Pull request review commentmicrosoft/vscode-python

Add telemetry for 'Select Interpreter' command

 export interface IEventNamePropertyMapping {          */         disabled: boolean;     };+    /**+     * Telemetry event sent when 'Select Interpreter' command is invoked+     */+    [EventName.SELECT_INTERPRETER]: never | undefined;+    /**+     * Telemetry event sent when 'Enter interpreter path' button is clicked+     */+    [EventName.ENTER_INTERPRETER_PATH_BUTTON]: never | undefined;+    /**+     * Telemetry event sent with details about what choice user made to input the interpreter path+     */+    [EventName.INPUT_INTERPRETER_PATH_CHOICES]: {+        /**+         * Carries 'enter' if user chose to enter the path to executable+         * Carries 'browse' if user chose to browse for the path to the executable

Don't forget to end sentences with a period, even in basic comments like this:

     * Telemetry event sent when 'Select Interpreter' command is invoked.
     */
    [EventName.SELECT_INTERPRETER]: never | undefined;
    /**
     * Telemetry event sent when 'Enter interpreter path' button is clicked.
     */
    [EventName.ENTER_INTERPRETER_PATH_BUTTON]: never | undefined;
    /**
     * Telemetry event sent with details about what choice user made to input the interpreter path.
     */
    [EventName.INPUT_INTERPRETER_PATH_CHOICES]: {
        /**
         * Carries 'enter' if user chose to enter the path to executable.
         * Carries 'browse' if user chose to browse for the path to the executable.
karrtikr

comment created time in 2 days

Pull request review commentmicrosoft/vscode-python

Add telemetry for 'Select Interpreter' command

 export enum EventName {     REFACTOR_EXTRACT_VAR = 'REFACTOR_EXTRACT_VAR',     REFACTOR_EXTRACT_FUNCTION = 'REFACTOR_EXTRACT_FUNCTION',     REPL = 'REPL',+    SELECT_INTERPRETER = 'SELECT_INTERPRETER',+    ENTER_INTERPRETER_PATH_BUTTON = 'ENTER_INTERPRETER_PATH_BUTTON',+    INPUT_INTERPRETER_PATH_CHOICES = 'INPUT_INTERPRETER_PATH_CHOICES',

It might be better to group these via the name, to make the relationship more clear:

    SELECT_INTERPRETER = 'SELECT_INTERPRETER',
    SELECT_INTERPRETER_ENTER_BUTTON = 'SELECT_INTERPRETER_ENTER_BUTTON',
    SELECT_INTERPRETER_ENTER_CHOICES = 'SELECT_INTERPRETER_ENTER_CHOICES',

Furthermore, "choices" implies multiple selections even though there was only one. So:

    SELECT_INTERPRETER = 'SELECT_INTERPRETER',
    SELECT_INTERPRETER_ENTER_BUTTON = 'SELECT_INTERPRETER_ENTER_BUTTON',
    SELECT_INTERPRETER_ENTER_CHOICE = 'SELECT_INTERPRETER_ENTER_CHOICE',
karrtikr

comment created time in 2 days

Pull request review commentmicrosoft/vscode-python

Add telemetry for 'Select Interpreter' command

+Add telemetry for "Select Interpreter" command.

If the command already has some telemetry then I recommend the folllowing:

Add more telemetry for "Select Interpreter" command.
karrtikr

comment created time in 2 days

push eventericsnowcurrently/vscode-python

Rich Chiodo

commit sha 8bb3ddf71e61bb33ce06c0dc91250e0fd82e98f6

Add package name to output (#12683)

view details

Don Jayamanne

commit sha 0ac275750dce0d83bdf59770fafb69734a51dd0b

Register notebook with VSC only in Insiders (#12681) For #10496 If the API changes, and user is not using the VSC Notebooks or insiders, then swallow errors. Do not register API against stable version of VSCode. Also fixed a test. Basically we need to ensure VSC works when using this API and not crash if the API changes.

view details

Joyce Er

commit sha 21fcb0b21086d302b7f01f012cee3b0c18ac2494

DS: Fixes for trusted notebooks UI (#12685) * Prompt to trust notebook should be error message * Fix apparent bug with markdown editor styling This was causing the markdown cells to jut out 2 pixels to the right of the middle content bar * Refactor readOnly markdown props for consistency * Sign up for keydown / up events when props.readOnly changes

view details

Kartik Raj

commit sha 678e016c86079abc557e6a1a6daab20ba05295ed

Log time taken by pytest hook and increase timeout (#12682)

view details

Eric Snow

commit sha 53e6fcebae17c582367013a0575c7b0b7d9e0087

Move remaining "virtual"-env-related code to the py-envs component tree. (#12516) This change is part of the work to isolate a "component" for Python environments. The focus here is on pulling over the remaining significant sections of code belonging to the "discovery" portion of the py-envs component. There are a few pieces here and there but we'll get those pulled over in later phases. For those most part this PR only moves code between files. In some cases this involves refactoring code so that part of it can be moved.

view details

Rich Chiodo

commit sha 2ac130e64993790bb8500e3227c0808487149213

Fix variable flash when using run by line (#12687) * Add refresh count where appropriate * More refresh cases * Fix run by line test. * Add news entry

view details

Nicolas Kruchten

commit sha ab1eadfb5f846d84969e4ae401f308a337c58b00

Bump plotly.js to 1.54.5 (#12609) * Bump plotly.js to 1.54.5 * update lockfile

view details

push time in 3 days

issue commentmicrosoft/vscode-python

pytest rootdir should be where configured

just a little OT question. When you say "less-common project structures", which project structure would you suggest?

I hope that didn't sound like a critique! 😄 It wasn't meant to. In the Python extension we expect (correctly, we believe) that most projects are relatively flat, such that the project root directory is the one that would go on sys.path, like this:

project_folder/
|----my_package/
|      |----python files ...
|----tests/
|      |----test_a.py
|      |----test_b.py
|---- ...

However, there's nothing wrong with the structure you have. It's just less common so we don't accommodate it as well in the extension. We'd like to improve that. Helping you with this issue actually helps that cause. 😄

slobinger

comment created time in 3 days

issue commentmicrosoft/vscode-python

pytest rootdir should be where configured

Thanks. That helps. Note that the only thing the "python.testing.cwd" setting does is set the current working directory for the spawned Python process that will discover/run the tests. "--rootdir=." should provide the right value to pytest normally, though you really shouldn't need it. (See the pytest docs about the "rootdir".)

I expect part of the problem here is with the value you used for the "python.testing.cwd" setting. What happens if you set "python.testing.cwd" to "app_src" instead of "app_src/test" and drop "--rootdir=."? If that doesn't help, what about if you use "--rootdir=./test" (and keep "cwd" as "app_src")? Likewise with "--rootdir=."?

slobinger

comment created time in 3 days

issue commentmicrosoft/vscode-python

first no results, then "IndentationError: unexpected indent" when starting commands with an indented block with shift+Enter

There should have been a lot more text in the output panel. That extra information will be helpful.

Regardless, I was able to reproduce the problem you;ve described. We'll investigate further.

lorenzznerol

comment created time in 3 days

issue commentmicrosoft/vscode-python

Argument suggestions for some functions in the pytorch module are duplicated when using Jedi

Thanks for checking that. We'd definitely like to resolve any problems you've had with the language server. To that end, I recommend opening a separate issue to address that directly.

If you also want to keep using Jedi then we can investigate further. (Otherwise we can close this issue.) I suspect that Jedi is returning multiple results due to some sort of overloading criteria (possibly due to type annotations), though it might also be a bug in Jedi (or the Python extension). Just keep in mind that our ability to address issues in Jedi is limited.

Either way, you might also consider contacting the Jedi project directly, to get a faster resolution. I've always found @davidhalter to be responsive, helpful, and committed to the success of his project.

CatNofishing

comment created time in 3 days

delete branch ericsnowcurrently/vscode-python

delete branch : py-envs-virtual-envs

delete time in 3 days

push eventmicrosoft/vscode-python

Eric Snow

commit sha 53e6fcebae17c582367013a0575c7b0b7d9e0087

Move remaining "virtual"-env-related code to the py-envs component tree. (#12516) This change is part of the work to isolate a "component" for Python environments. The focus here is on pulling over the remaining significant sections of code belonging to the "discovery" portion of the py-envs component. There are a few pieces here and there but we'll get those pulled over in later phases. For those most part this PR only moves code between files. In some cases this involves refactoring code so that part of it can be moved.

view details

push time in 3 days

PR merged microsoft/vscode-python

Move remaining "virtual"-env-related code to the py-envs component tree. skip news

This change is part of the work to isolate a "component" for Python environments. The focus here is on pulling over the remaining significant sections of code belonging to the "discovery" portion of the py-envs component. There are a few pieces here and there but we'll get those pulled over in later phases.

For those most part this PR is just moving code between files. In some cases this involves refactoring code so that part of it can be moved.

<!-- If an item below does not apply to you, then go ahead and check it off as "done" and strikethrough the text, e.g.: - [x] ~Has unit tests & system/integration tests~ -->

  • [x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • [x] Title summarizes what is changing.
  • ~[ ] Has a news entry file (remember to thank yourself!).~
  • ~[ ] Appropriate comments and documentation strings in the code.~
  • ~[ ] Has sufficient logging.~
  • ~[ ] Has telemetry for enhancements.~
  • ~[ ] Unit tests & system/integration tests are added/updated.~
  • ~[ ] Test plan is updated as appropriate.~
  • ~[ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).~
  • ~[ ] The wiki is updated with any design decisions/details.~
+734 -253

1 comment

12 changed files

ericsnowcurrently

pr closed time in 3 days

issue commentmicrosoft/vscode-python

first no results, then "IndentationError: unexpected indent" when starting commands with an indented block with shift+Enter

Sorry for the confusion. In the "View" menu click on "Output". Then click on the pulldown menu (It probably says "Tasks" by default) and select "Python".

lorenzznerol

comment created time in 4 days

push eventericsnowcurrently/vscode-python

Don Jayamanne

commit sha b071d1752a1eaaebc7ec275051805f3fc98f5bb5

Ensure we can open VSCode Notebook with old editor (#12676) If we setup old editor to always open ipynb files, then opening with VSC Notebook doesn't work.

view details

Don Jayamanne

commit sha cb0791a0d22660efb33b21529e20c59d766ed608

Updates to Notebooks based on latest VSC API changes (#12672) For #10496

view details

Eric Snow

commit sha a6db5c036d2e3ad3b51c8b92136eae7ec4704c23

Use composition rather than inheritance for ProtocolParser. (#12680) For #12679 This fixes some inversify-related test failures.

view details

Eric Snow

commit sha dad0bcc6ba4552808471c6fda649833026dc1793

Factor out getInterpreterTypeName() and sortInterpreters().

view details

Eric Snow

commit sha e6e25b714f0d5430a79fc2805be28c2f0ecbb24c

Factor out getName() for sub-envs.

view details

Eric Snow

commit sha 5a90714609e4e9e0b1125579b6c6fb34c8f33856

Factor out resolveVenvExecutable().

view details

Eric Snow

commit sha 9c879c56f659bb3b1be5d09a76d2d7db019aae78

Factor out findVenvExecutable().

view details

Eric Snow

commit sha 8884e98da83d677d41b6f1ccd7cb1b74a9764709

Factor out getType() and friends.

view details

Eric Snow

commit sha a1a8f06d7c7a01883100b30d4c7623a9cb527785

Add missing doc comments.

view details

Eric Snow

commit sha 34710946e1375a458c6243137c5085dc96d88ad0

Use PythonVersion instead of Version.

view details

Eric Snow

commit sha 5dbef5a86dd8a53f35d110e76922fc8433173e30

Drop findVenvExecutable().

view details

Eric Snow

commit sha 1343fffb17053f10bb11de8cf28c4867b8cdcff3

Log an otherwise ignored error.

view details

Eric Snow

commit sha e3ee65b770a5c06ec3bf9cd83cdbbbc4a2dc0b90

Appease inversify.

view details

push time in 4 days

push eventericsnowcurrently/vscode-python

Don Jayamanne

commit sha b071d1752a1eaaebc7ec275051805f3fc98f5bb5

Ensure we can open VSCode Notebook with old editor (#12676) If we setup old editor to always open ipynb files, then opening with VSC Notebook doesn't work.

view details

Don Jayamanne

commit sha cb0791a0d22660efb33b21529e20c59d766ed608

Updates to Notebooks based on latest VSC API changes (#12672) For #10496

view details

Eric Snow

commit sha a6db5c036d2e3ad3b51c8b92136eae7ec4704c23

Use composition rather than inheritance for ProtocolParser. (#12680) For #12679 This fixes some inversify-related test failures.

view details

push time in 4 days

issue closedmicrosoft/vscode-python

Test failures due to inversify.

In the "master" branch we have a number of test failures. It is not clear how the code got into this unstable state.

I'll have a PR up shortly.

closed time in 4 days

ericsnowcurrently

delete branch ericsnowcurrently/vscode-python

delete branch : fix-12679-test-failures-inversify

delete time in 4 days

push eventmicrosoft/vscode-python

Eric Snow

commit sha a6db5c036d2e3ad3b51c8b92136eae7ec4704c23

Use composition rather than inheritance for ProtocolParser. (#12680) For #12679 This fixes some inversify-related test failures.

view details

push time in 4 days

PR merged microsoft/vscode-python

Use composition rather than inheritance for ProtocolParser. skip news

For #12679

This fixes some inversify-related test failures.

+19 -7

1 comment

1 changed file

ericsnowcurrently

pr closed time in 4 days

push eventericsnowcurrently/vscode-python

Jim Griesmer

commit sha 53c3fc6231adc2dd4edd8deeca207f4943f4d044

Update experiments.json (#12524) All required steps passed.

view details

David Kutugata

commit sha 88f3b432bbe93474cc29e413b6a831050a056beb

Remove kernel change on the Interactive Window (#12439) * add 'select kernel' handle message on the interactive window * remove kernel toolbar from the interactive window if th user uses a local jupyter server * add setting to enable it back * add news file * oops * Add the experiment, as well as IExperimentService on everything that extends WebViewHost * removed setting * add setting back

view details

Don Jayamanne

commit sha df69c426433fb0e26bb5596f8e1d51ea70242f9d

Fixes related to execution & clearing output of Native Notebooks (#12490) * Do not run cells if empty * Clearing output should clear status, exec times, cell execution count (added tests, to ensure execution_count is null) * When running a cell/nb we should set status of cell as running early on * Clearing output should mark document as dirty * Restoring running tests on CI (forgot to revert some changes)

view details

Joyce Er

commit sha bea5e97d3573b2492dc1699c2e3fd75d4c3766bd

Make node install version in contributing docs match ci.yml (#12528) * Make node version in docs match ci.yml * Update .nvmrc

view details

Ian Huff

commit sha 2cc6c95db59c71b14275b53d43a6f1eca0c93850

Fully handle iopub comm messages (#12512)

view details

Joyce Er

commit sha 3bb92e12a316601a4307feaf811cf6aaceef0109

DS: Ensure atomic key creation for use with trusted notebooks (#12515)

view details

Timothy Ruscica

commit sha 036621a3be73b8d7fb5f31d7acebd4a3b1106b55

Added export notebook to PDF (#12517) * temp work * started working on dependency checking * good start on pdf * removed space from label * added to command pallete * changed pdf method to TeX * fixed pdf title * removed unecessary changes * changed back package-lock.json * cleaned up dependency checker * made changes and add telemetry * changed from 2 to 1 error message * changed name for temp directory * removed duplicate import * removed mardown prefix * deleted temp file

view details

Joyce Er

commit sha 94ca7f73f2293b239b5380af79866b478cc365cf

DS: Compute and store trusted digests for notebooks (#12479)

view details

Timothy Ruscica

commit sha 0734d4ea990b4d4a0352d07117107e93a3cdd4e0

added tests for pdf export (#12548)

view details

Joyce Er

commit sha b24a014b3ec0f5ed5e4fb320b62eec18efde6831

DS: Display 'Trusted' / 'Not Trusted' on notebook load (#12466)

view details

Jake Bailey

commit sha d80bead813b44990173bd347f1ad804b3947bee7

Don't modify LS settings if jediEnabled does not exist (#12551)

view details

Don Jayamanne

commit sha 6afc0839101f2cce1e1073239c237805ad6376a4

Add Telemetry for VSC Notebooks (#12542) * Added some missing telemetry for VS Code Notebooks * Track the type of notebook used in various operations (running cell, interrupting kernels, etc, determine whether user is performing such operations while in Native/Custom/Old editor) * Added a type for INobteookEditor (temporary, until VSC Notebook is stable) * Ensure users cannot opt into VSC Notebook Editor experiment when in VSC Stable.

view details

Joyce Er

commit sha 791d7bed6b7c3f0d2852e32109616674642c1602

DS: Show banner prompting user to trust notebook (#12555)

view details

Pavel Minaev

commit sha fb501ecf321503ab928c98ab3e961a017c63b96f

Fix #12446: Stock launch.json "attach" configs should be using "connect" (#12504) Change RemoteAttachDebugConfigurationProvider to generate configs with "connect".

view details

Kartik Raj

commit sha c88b314d392d133588ce89eaf4c5694c7bc159d9

Skip flaky CI tests (#12566)

view details

Don Jayamanne

commit sha 14389ef979adc5f29494df9bb25a3f691458b850

VS Code Notebook survey (#12558)

view details

Kartik Raj

commit sha 3d1e2f7dde970c3b0f2b5554c5554908a17c09ab

Prompt users that we have deleted pythonPath from their workspace settings when in DeprecatePythonPath experiment (#12536) * Prompt users that we have deleted pythonPath from their workspace settings when in DeprecatePythonPath experiment * Oops * Code reviews * Code reviews

view details

Luciana Abud

commit sha 0b590caff690b96a74ed281255c3b0d64d512e82

Turn pythonPath experiment for 20% of users. (#12549)

view details

Jim Griesmer

commit sha 2f5234a3bdd387d3bb26831cd63f49fce34f3a1a

Update experiments.json (#12573)

view details

Rich Chiodo

commit sha a94c8b8d648034d199046dcd4a83eafb75d1ee06

Jupyter hub preliminary support (#12574) * Move request header generation into password generation * Connecting to token api * Working jupyter hub connection * Use multistep input * Remove token on shutdown * Support certificate checking * Skip waiting on shutdown * Get old unit tests passing again * Fix xsrf token to remove extra cookie crap * Test plan changes and new unit test * Fix linter and input box result * Fix sonar warning * Review feedback * Actually cookie not sent back for hub

view details

push time in 4 days

issue commentmicrosoft/vscode-python

Test failures due to inversify.

@brettcannon @karthiknadig

ericsnowcurrently

comment created time in 4 days

PR opened microsoft/vscode-python

Reviewers
Use composition rather than inheritance for ProtocolParser. skip news

For #12679

This fixes some inversify-related test failures.

+19 -7

0 comment

1 changed file

pr created time in 4 days

issue openedmicrosoft/vscode-python

Test failures due to inversify.

In the "master" branch we have a number of test failures. It is not clear how the code got into this unstable state.

I'll have a PR up shortly.

created time in 4 days

push eventericsnowcurrently/vscode-python

Jim Griesmer

commit sha 53c3fc6231adc2dd4edd8deeca207f4943f4d044

Update experiments.json (#12524) All required steps passed.

view details

David Kutugata

commit sha 88f3b432bbe93474cc29e413b6a831050a056beb

Remove kernel change on the Interactive Window (#12439) * add 'select kernel' handle message on the interactive window * remove kernel toolbar from the interactive window if th user uses a local jupyter server * add setting to enable it back * add news file * oops * Add the experiment, as well as IExperimentService on everything that extends WebViewHost * removed setting * add setting back

view details

Don Jayamanne

commit sha df69c426433fb0e26bb5596f8e1d51ea70242f9d

Fixes related to execution & clearing output of Native Notebooks (#12490) * Do not run cells if empty * Clearing output should clear status, exec times, cell execution count (added tests, to ensure execution_count is null) * When running a cell/nb we should set status of cell as running early on * Clearing output should mark document as dirty * Restoring running tests on CI (forgot to revert some changes)

view details

Joyce Er

commit sha bea5e97d3573b2492dc1699c2e3fd75d4c3766bd

Make node install version in contributing docs match ci.yml (#12528) * Make node version in docs match ci.yml * Update .nvmrc

view details

Ian Huff

commit sha 2cc6c95db59c71b14275b53d43a6f1eca0c93850

Fully handle iopub comm messages (#12512)

view details

Joyce Er

commit sha 3bb92e12a316601a4307feaf811cf6aaceef0109

DS: Ensure atomic key creation for use with trusted notebooks (#12515)

view details

Timothy Ruscica

commit sha 036621a3be73b8d7fb5f31d7acebd4a3b1106b55

Added export notebook to PDF (#12517) * temp work * started working on dependency checking * good start on pdf * removed space from label * added to command pallete * changed pdf method to TeX * fixed pdf title * removed unecessary changes * changed back package-lock.json * cleaned up dependency checker * made changes and add telemetry * changed from 2 to 1 error message * changed name for temp directory * removed duplicate import * removed mardown prefix * deleted temp file

view details

Joyce Er

commit sha 94ca7f73f2293b239b5380af79866b478cc365cf

DS: Compute and store trusted digests for notebooks (#12479)

view details

Timothy Ruscica

commit sha 0734d4ea990b4d4a0352d07117107e93a3cdd4e0

added tests for pdf export (#12548)

view details

Joyce Er

commit sha b24a014b3ec0f5ed5e4fb320b62eec18efde6831

DS: Display 'Trusted' / 'Not Trusted' on notebook load (#12466)

view details

Jake Bailey

commit sha d80bead813b44990173bd347f1ad804b3947bee7

Don't modify LS settings if jediEnabled does not exist (#12551)

view details

Don Jayamanne

commit sha 6afc0839101f2cce1e1073239c237805ad6376a4

Add Telemetry for VSC Notebooks (#12542) * Added some missing telemetry for VS Code Notebooks * Track the type of notebook used in various operations (running cell, interrupting kernels, etc, determine whether user is performing such operations while in Native/Custom/Old editor) * Added a type for INobteookEditor (temporary, until VSC Notebook is stable) * Ensure users cannot opt into VSC Notebook Editor experiment when in VSC Stable.

view details

Joyce Er

commit sha 791d7bed6b7c3f0d2852e32109616674642c1602

DS: Show banner prompting user to trust notebook (#12555)

view details

Pavel Minaev

commit sha fb501ecf321503ab928c98ab3e961a017c63b96f

Fix #12446: Stock launch.json "attach" configs should be using "connect" (#12504) Change RemoteAttachDebugConfigurationProvider to generate configs with "connect".

view details

Kartik Raj

commit sha c88b314d392d133588ce89eaf4c5694c7bc159d9

Skip flaky CI tests (#12566)

view details

Don Jayamanne

commit sha 14389ef979adc5f29494df9bb25a3f691458b850

VS Code Notebook survey (#12558)

view details

Kartik Raj

commit sha 3d1e2f7dde970c3b0f2b5554c5554908a17c09ab

Prompt users that we have deleted pythonPath from their workspace settings when in DeprecatePythonPath experiment (#12536) * Prompt users that we have deleted pythonPath from their workspace settings when in DeprecatePythonPath experiment * Oops * Code reviews * Code reviews

view details

Luciana Abud

commit sha 0b590caff690b96a74ed281255c3b0d64d512e82

Turn pythonPath experiment for 20% of users. (#12549)

view details

Jim Griesmer

commit sha 2f5234a3bdd387d3bb26831cd63f49fce34f3a1a

Update experiments.json (#12573)

view details

Rich Chiodo

commit sha a94c8b8d648034d199046dcd4a83eafb75d1ee06

Jupyter hub preliminary support (#12574) * Move request header generation into password generation * Connecting to token api * Working jupyter hub connection * Use multistep input * Remove token on shutdown * Support certificate checking * Skip waiting on shutdown * Get old unit tests passing again * Fix xsrf token to remove extra cookie crap * Test plan changes and new unit test * Fix linter and input box result * Fix sonar warning * Review feedback * Actually cookie not sent back for hub

view details

push time in 4 days

push eventericsnowcurrently/vscode-python

Eric Snow

commit sha 7ea95d0b1cfea646fb690ce72a0d6ff48eeeedba

Log an otherwise ignored error.

view details

push time in 4 days

issue commentmicrosoft/vscode-python

first no results, then "IndentationError: unexpected indent" when starting commands with an indented block with shift+Enter

@lorenzznerol, thanks for letting us know about this. Please provide the content of your settings.json and the "Python" output panel. Also, how are you running the code? Are you highlighting the code and running a command?

lorenzznerol

comment created time in 4 days

issue commentmicrosoft/vscode-python

Python extension not able to recognize installed modules immediately

@3627pranav, thanks for letting us know about this. Please provide the content of your settings.json, as well as the "Python" output panel.

3627pranav

comment created time in 4 days

issue commentmicrosoft/vscode-python

Argument suggestions for some functions in the pytorch module are duplicated when using Jedi

@CatNofishing, thanks for letting us know about this. What happens when you use the language server? (In your settings.json, set 'python.languageServer": "Microsoft".)

CatNofishing

comment created time in 4 days

issue commentmicrosoft/vscode-python

pytest rootdir should be where configured

@luabud, this is consistently a point of confusion for users with less-common project structures.

slobinger

comment created time in 4 days

issue commentmicrosoft/vscode-python

pytest rootdir should be where configured

@slobinger, thanks for letting us know about this. We'll take a look at what we can do to make the pytest behavior more behavior when you have --rootdir and/or the "python.testing.cwd" setting. In the meantime, please provide the content of the "Python" and "Python Testing Log" output panels.

slobinger

comment created time in 4 days

Pull request review commentmicrosoft/vscode-docs

clarify how to disable pytest-cov when debugging

 See [unittest command-line interface](https://docs.python.org/3/library/unittest You can also configure pytest using a `pytest.ini` file as described on [pytest Configuration](https://docs.pytest.org/en/latest/customize.html).  > **Note**-> If you have the pytest-cov coverage module installed, VS Code doesn't stop at breakpoints while debugging because pytest-cov is using the same technique to access the source code being run. To prevent this behavior, include `--no-cov` in `pytestArgs` when debugging tests. (For more information, see [Debuggers and PyCharm](https://pytest-cov.readthedocs.io/en/latest/debuggers.html) in the pytest-cov documentation.)+> If you have the pytest-cov coverage module installed, VS Code doesn't stop at breakpoints while debugging because pytest-cov is using the same technique to access the source code being run. To prevent this behavior, include `--no-cov` in `pytestArgs` when debugging tests, for example by adding `"env": {"PYTEST_ADDOPTS": "--no-cov"}` to your [launch configuration](#debug-tests). (For more information, see [Debuggers and PyCharm](https://pytest-cov.readthedocs.io/en/latest/debuggers.html) in the pytest-cov documentation.)
> If you have the pytest-cov coverage module installed, VS Code doesn't stop at breakpoints while debugging because pytest-cov is using the same technique to access the source code being run. To prevent this behavior, include `--no-cov` in `pytestArgs` when debugging tests, for example by adding `"env": {"PYTEST_ADDOPTS": "--no-cov"}` to your debug configuration.  (See [Debug Tests](#debug-tests) above about how to set up that launch configuration.) (For more information, see [Debuggers and PyCharm](https://pytest-cov.readthedocs.io/en/latest/debuggers.html) in the pytest-cov documentation.)
Ezra

comment created time in 4 days

Pull request review commentmicrosoft/vscode-docs

clarify how to disable pytest-cov when debugging

 See [unittest command-line interface](https://docs.python.org/3/library/unittest You can also configure pytest using a `pytest.ini` file as described on [pytest Configuration](https://docs.pytest.org/en/latest/customize.html).  > **Note**-> If you have the pytest-cov coverage module installed, VS Code doesn't stop at breakpoints while debugging because pytest-cov is using the same technique to access the source code being run. To prevent this behavior, include `--no-cov` in `pytestArgs` when debugging tests. (For more information, see [Debuggers and PyCharm](https://pytest-cov.readthedocs.io/en/latest/debuggers.html) in the pytest-cov documentation.)+> If you have the pytest-cov coverage module installed, VS Code doesn't stop at breakpoints while debugging because pytest-cov is using the same technique to access the source code being run. To prevent this behavior, include `--no-cov` in `pytestArgs` when debugging tests, for example by adding `"env": {"PYTEST_ADDOPTS": "--no-cov"}` to your [launch configuration](#debug-tests). (For more information, see [Debuggers and PyCharm](https://pytest-cov.readthedocs.io/en/latest/debuggers.html) in the pytest-cov documentation.)

Is the link right? On the docs page it has a leading underscore:

> If you have the pytest-cov coverage module installed, VS Code doesn't stop at breakpoints while debugging because pytest-cov is using the same technique to access the source code being run. To prevent this behavior, include `--no-cov` in `pytestArgs` when debugging tests, for example by adding `"env": {"PYTEST_ADDOPTS": "--no-cov"}` to your [launch configuration](#_debug-tests). (For more information, see [Debuggers and PyCharm](https://pytest-cov.readthedocs.io/en/latest/debuggers.html) in the pytest-cov documentation.)

However, maybe the HTML generator takes care of that...

Ezra

comment created time in 4 days

Pull request review commentmicrosoft/vscode-python

Prompt users that we have deleted pythonPath from their workspace settings when in DeprecatePythonPath experiment

     "DataScience.liveShareServiceFailure": "Failure starting '{0}' service during live share connection.",     "DataScience.documentMismatch": "Cannot run cells, duplicate documents for {0} found.",     "DataScience.pythonInteractiveCreateFailed": "Failure to create a 'Python Interactive' window. Try reinstalling the Python extension.",-    "diagnostics.removePythonPathSettingsJson": "The setting \"python.pythonPath\" defined in your settings.json is now deprecated. Do you want us to delete it from your settings.json only? [Learn more](https://aka.ms/AA7jfor).",-    "diagnostics.removePythonPathCodeWorkspace": "The setting \"python.pythonPath\" defined in your workspace settings is now deprecated. Do you want us to delete it from your .code-workspace file only? [Learn more](https://aka.ms/AA7jfor).",-    "diagnostics.removePythonPathCodeWorkspaceAndSettingsJson": "The setting \"python.pythonPath\" defined in your workspace settings is now deprecated. Do you want us to delete it from your .code-workspace file and settings.json? [Learn more](https://aka.ms/AA7jfor).",+    "diagnostics.removedPythonPathFromSettings": "We removed the \"python.pythonPath\" setting from your settings.json file as the setting is now deprecated. You can get the path of your selected interpreter in the Python output panel. [Learn more](https://aka.ms/AA7jfor).",

"Deprecated" usually means we're going to remove something in the future.

karrtikr

comment created time in 10 days

Pull request review commentmicrosoft/vscode-python

Prompt users that we have deleted pythonPath from their workspace settings when in DeprecatePythonPath experiment

     "DataScience.liveShareServiceFailure": "Failure starting '{0}' service during live share connection.",     "DataScience.documentMismatch": "Cannot run cells, duplicate documents for {0} found.",     "DataScience.pythonInteractiveCreateFailed": "Failure to create a 'Python Interactive' window. Try reinstalling the Python extension.",-    "diagnostics.removePythonPathSettingsJson": "The setting \"python.pythonPath\" defined in your settings.json is now deprecated. Do you want us to delete it from your settings.json only? [Learn more](https://aka.ms/AA7jfor).",-    "diagnostics.removePythonPathCodeWorkspace": "The setting \"python.pythonPath\" defined in your workspace settings is now deprecated. Do you want us to delete it from your .code-workspace file only? [Learn more](https://aka.ms/AA7jfor).",-    "diagnostics.removePythonPathCodeWorkspaceAndSettingsJson": "The setting \"python.pythonPath\" defined in your workspace settings is now deprecated. Do you want us to delete it from your .code-workspace file and settings.json? [Learn more](https://aka.ms/AA7jfor).",+    "diagnostics.removedPythonPathFromSettings": "We removed the \"python.pythonPath\" setting from your settings.json file as the setting is now deprecated. You can get the path of your selected interpreter in the Python output panel. [Learn more](https://aka.ms/AA7jfor).",
    "diagnostics.removedPythonPathFromSettings": "We removed the \"python.pythonPath\" setting from your settings.json file as the setting is no longer used by the Python extension. You can get the path of your selected interpreter in the Python output panel. [Learn more](https://aka.ms/AA7jfor).",
karrtikr

comment created time in 10 days

PR opened microsoft/vscode-python

Reviewers
Move remaining "virtual"-env-related code to the py-envs component tree. skip news

This change is part of the work to isolate a "component" for Python environments. The focus here is on pulling over the remaining significant sections of code belonging to the "discovery" portion of the py-envs component. There are a few pieces here and there but we'll get those pulled over in later phases.

For those most part this PR is just moving code between files. In some cases this involves refactoring code so that part of it can be moved.

<!-- If an item below does not apply to you, then go ahead and check it off as "done" and strikethrough the text, e.g.: - [x] ~Has unit tests & system/integration tests~ -->

  • [x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • [x] Title summarizes what is changing.
  • ~[ ] Has a news entry file (remember to thank yourself!).~
  • ~[ ] Appropriate comments and documentation strings in the code.~
  • ~[ ] Has sufficient logging.~
  • ~[ ] Has telemetry for enhancements.~
  • ~[ ] Unit tests & system/integration tests are added/updated.~
  • ~[ ] Test plan is updated as appropriate.~
  • ~[ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).~
  • ~[ ] The wiki is updated with any design decisions/details.~
+732 -248

0 comment

12 changed files

pr created time in 11 days

create barnchericsnowcurrently/vscode-python

branch : py-envs-virtual-envs

created branch time in 11 days

push eventericsnowcurrently/vscode-python

Don Jayamanne

commit sha e396bfa9fdaccdd3f72360158ad16041f176d17c

Trigger changes in VSC Notebook when executing cells (#12489)

view details

Ian Huff

commit sha 29bf396c23df0f4c6c589624c585e8903e838fef

Mac keyboard undo and redo need to look for meta, not ctrl (#12487)

view details

David Kutugata

commit sha 1bec89bee8730ad42ce9a0d0d319915e3a299778

discard changes when the user clicks don't save (#12492)

view details

Brandon White

commit sha 3eb13259657e37c052ab8ba216ca1277a2d6c7e8

Added `workspaceContains:pyproject.toml` to activationEvents (#12056) (for #4765) This PR adds triggering off of 'pyproject.toml' in the workspace root to load the extension. Other recognizable file triggers (like setup.py) may be added later.

view details

Eric Snow

commit sha e39860742d2e704444b47beb934dd5a2ba73f8da

Move interpreter-info-related code to the py-envs component tree. (#12398) This change is part of the work to isolate a "component" for Python environments. The focus here is on pulling code related to getting interpreter info out of unrelated modules and into the py-envs component.

view details

Brett Cannon

commit sha e41681faf6435be5b3b93e02fd02b768936e809c

Drop `jediEnabled` from the issue template

view details

push time in 11 days

pull request commentmicrosoft/vscode-python

Move interpreter-info-related code to the py-envs component tree.

In the interest of moving things forward while folks are out, I've merged this PR under the assumption that all feedback has been addressed. There are a few points that may be open to further discussion, but we can handle them after the fact. In the meantime I can get the last of the consolidation work finished.

ericsnowcurrently

comment created time in 11 days

delete branch ericsnowcurrently/vscode-python

delete branch : py-envs-interpreter-info

delete time in 11 days

push eventmicrosoft/vscode-python

Eric Snow

commit sha e39860742d2e704444b47beb934dd5a2ba73f8da

Move interpreter-info-related code to the py-envs component tree. (#12398) This change is part of the work to isolate a "component" for Python environments. The focus here is on pulling code related to getting interpreter info out of unrelated modules and into the py-envs component.

view details

push time in 11 days

PR merged microsoft/vscode-python

Reviewers
Move interpreter-info-related code to the py-envs component tree. skip news

This change is part of the work to isolate a "component" for Python environments. The focus here is on pulling code related to getting interpreter info out of unrelated modules and into the py-envs component.

<!-- If an item below does not apply to you, then go ahead and check it off as "done" and strikethrough the text, e.g.: - [x] ~Has unit tests & system/integration tests~ -->

  • [X] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • [X] Title summarizes what is changing.
  • ~[ ] Has a news entry file (remember to thank yourself!).~
  • ~[ ] Appropriate comments and documentation strings in the code.~
  • ~[ ] Has sufficient logging.~
  • ~[ ] Has telemetry for enhancements.~
  • ~[ ] Unit tests & system/integration tests are added/updated.~
  • ~[ ] Test plan is updated as appropriate.~
  • ~[ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).~
  • ~[ ] The wiki is updated with any design decisions/details.~
+470 -53

2 comments

12 changed files

ericsnowcurrently

pr closed time in 11 days

pull request commentmicrosoft/vscode-python

Added `workspaceContains:pyproject.toml` to activationEvents

And sorry that took so long to sort out. Thanks for your patience. 😄

BrandonLWhite

comment created time in 11 days

push eventmicrosoft/vscode-python

Brandon White

commit sha 3eb13259657e37c052ab8ba216ca1277a2d6c7e8

Added `workspaceContains:pyproject.toml` to activationEvents (#12056) (for #4765) This PR adds triggering off of 'pyproject.toml' in the workspace root to load the extension. Other recognizable file triggers (like setup.py) may be added later.

view details

push time in 11 days

pull request commentmicrosoft/vscode-python

Added `workspaceContains:pyproject.toml` to activationEvents

Thanks @BrandonLWhite!

BrandonLWhite

comment created time in 11 days

PR merged microsoft/vscode-python

Reviewers
Added `workspaceContains:pyproject.toml` to activationEvents external contributor

(for #4765)

This PR adds triggering off of 'pyproject.toml' in the workspace root to load the extension.

I'm hoping that using this standard file is easier to get merged vs. the "kitchen-sink" approach that has stalled another PR due to debates and disagreements.

<!-- If an item below does not apply to you, then go ahead and check it off as "done" and strikethrough the text, e.g.: - [x] ~Has unit tests & system/integration tests~ -->

  • [x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • [x] Title summarizes what is changing.
  • [x] Has a news entry file (remember to thank yourself!).
  • [x] ~Appropriate comments and documentation strings in the code.~
  • [x] ~Has sufficient logging.~
  • [x] ~Has telemetry for enhancements.~
  • [x] ~Unit tests & system/integration tests are added/updated.~
  • [x] ~Test plan is updated as appropriate.~
  • [x] ~package-lock.json has been regenerated by running npm install (if dependencies have changed).~
  • [ ] The wiki is updated with any design decisions/details.
+3 -1

7 comments

2 changed files

BrandonLWhite

pr closed time in 11 days

issue commentmicrosoft/vscode-python

python unresolved import

@Kyitrai, please open a separate issue and refer back to this one. I suspect your situation is a slightly different problem and we don't want that to get lost in this issue. Thanks!

fdq09eca

comment created time in 11 days

issue commentmicrosoft/vscode-python

Debugging pytest tests ignore the set .env file

Thanks, that helps. It looks like our handling of .env files isn't quite right in the testing case (but correct in the other debug cases). In fact, the code for the debug config used for testing is almost completely distinct from that used for other debug scenarios. The same goes, to a lesser extent, for other uses of .env files in the Python extension. From what I can tell, we don't do any substitution relative to the process environment variables.

Regardless, we will investigate further and work on a fix.

flaker

comment created time in 11 days

issue commentmicrosoft/vscode-python

Unexpected "problems" reported for Django model attributes.

The following line from the log indicates that you are using Jedi instead of the Language Server:

Starting Jedi Python language engine.

The log also indicates that you have pylint set up and it is what is reporting the "problems". So using the language server would not make a difference.

The question is, why is pylint complaining about your project? What happens when you run pylint manually? Use the following command (which is what the extension runs):

~\AppData\Local\Programs\Python\Python38\python.exe -m pylint --disable=all --enable=F,unreachable,duplicate-key,unnecessary-semicolon,global-variable-not-assigned,unused-variable,unused-wildcard-import,binary-op-exception,bad-format-string,anomalous-backslash-in-string,bad-open-mode,E0001,E0011,E0012,E0100,E0101,E0102,E0103,E0104,E0105,E0107,E0108,E0110,E0111,E0112,E0113,E0114,E0115,E0116,E0117,E0118,E0202,E0203,E0211,E0213,E0236,E0237,E0238,E0239,E0240,E0241,E0301,E0302,E0303,E0401,E0402,E0601,E0602,E0603,E0604,E0611,E0632,E0633,E0701,E0702,E0703,E0704,E0710,E0711,E0712,E1003,E1101,E1102,E1111,E1120,E1121,E1123,E1124,E1125,E1126,E1127,E1128,E1129,E1130,E1131,E1132,E1133,E1134,E1135,E1136,E1137,E1138,E1139,E1200,E1201,E1205,E1206,E1300,E1301,E1302,E1303,E1304,E1305,E1306,E1310,E1700,E1701 --msg-template='{line},{column},{category},{symbol}:{msg}' --reports=n --output-format=text d:\Famzaa\home\views.py

Also, please provide your settings (d:\Famzaa\.vscode\settings.json).

Also, how is your workspace files structured? Is there a link to a repo you could provide?

fahadmalik-creator

comment created time in 11 days

pull request commentmicrosoft/vscode-python

Move interpreter-info-related code to the py-envs component tree.

@kimadeline, thanks for the review! All your comments should be addressed now.

ericsnowcurrently

comment created time in 12 days

push eventericsnowcurrently/vscode-python

Tim Ruscica

commit sha 9d382de3b594fbcd3222e96e52324772955b46f9

Added exporting notebook to HTML (#12375) * export working * added export base * file opens when click yes button * small changes to exportManagerFileOpener * small changes * added tests for html (new file) * localized string * added news file * added missing keys to package.nls.json * addressed comments * removes strange space * checked exported file is HTML file * modified test * fixed tests * changed launch.json back to original

view details

Brett Cannon

commit sha 00d9ddfdea0bfcf0fd4a2bb694a35ce224705865

Explicitly add the GitHub release step

view details

Rich Chiodo

commit sha a03edb51066adcd4721c95bb9eff781ad07d1b7d

Merging changes back from the release branch (#12393) * Port custom editor changes to release branch (#12222) * Implement the changes necessary to use the new custom editor (#12188) * Turn on custom editor again * Fix copy problem * Fix copy problem again * Get undo/redo to work * Some fixes for synching more than one editor * Fix untitled. Fix timeouts * fix command manager to not be used. Not necessary with temp path. fix delete/insert commands to undo properly * Fix functional test * Add experiment * Since package json is enabling proposed api, turn of notebooks with experiment * Turn off proposed api * Upgrade VS code to 1.45 so can use new api outside of insiders * Update package.json dynamically * Fix merge code to handle arrays * Fix unit tests. Backup happens at the provider level now * Fix hygiene * Fix untitled to work for old provider too * Some feedback and attempt to fix URI problem on linux/mac * Review feedback * Update changelog * Remove news entry * Port run by line stepping fix to release (#12223) * fix continue event to run cell (#12211) Co-authored-by: Ian Huff <ianhuff@alex-x230.northamerica.corp.microsoft.com> * update changelog and delete news file Co-authored-by: Ian Huff <ianhuff@alex-x230.northamerica.corp.microsoft.com> * Port run by line stop becoming interrupt to the release branch (#12271) * Run by line changes for release (#12256) * Run by line changes for release * Translate step tooltip and make sure F10 works outside of already debugging * Update changelog * Cherry-pick fixes from master to june release (#12282) * Merge stuff from may release back into master (#12233) * Revert vscode-extension-telemetry changes for the release (#11602) (#11656) * Revert "Fix slashes in telemetry unit tests (#11572)" This reverts commit 7431c9c53fa5f80fd440b47ae19a825286d3d760. * Revert "Use vscode-extension-telemetry for our exceptions & error telemetry (#11524)" This reverts commit d5065e6976ab8bf3289d70be4a34110a53b224c5. * Remove from changelog * Port storage fix to release branch (#11673) * Fix storage not being used (#11649) * Fix storage not being used * Add disposable to storage so it won't write after shutdown * Fix dirty title * Hack to get tests to pass * Another way to get run all to not interfere * Update changelog * Port scrolling fix to release (#11688) * Fix scrolling (#11681) * Fix scrolling * Review feedback - fix scrolling on expand/collapse * Update changelog * Update package.json Co-authored-by: Jim Griesmer <jimgries@microsoft.com> * Cherry-pick pipenv changes and pythonpath prompt changes to release (#11700) * Show the prompt again if user clicks on more info (#11664) * Show the prompt again if user clicks on more info * Review feedback * Use Learn more as text for the link. * Leave pipenv in a corner until the user decides to select an interpreter (#11654) * add onSuggestion option * Swap onActivation with onSuggestion * Update unit tests * Remove registration of IPipenvService * Move didTriggerInterpreterSuggestions logic inside pipenv locator * Fix existing unit tests * Add new unit tests * Replace typemoq any param with object * Shorten the tests * Fix warning * Duplicate teardown Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com> * Update extension version (#11730) * Update extension version * Update date in changelog. * Update change log with additional notes. (#11764) * Cherry picks and version updates for bug fix release (#11878) * Do not execute shebang as an interpreter until user has clicked on the codelens enclosing the shebang (#11816) * Do not execute shebang as an interpreter until user has clicked on the codelens enclosing the shebang * Rename * Oops * Update src/test/providers/shebangCodeLenseProvider.unit.test.ts Co-authored-by: Karthik Nadig <kanadig@microsoft.com> Co-authored-by: Karthik Nadig <kanadig@microsoft.com> * Update version and change log for bugfix release Co-authored-by: Kartik Raj <karraj@microsoft.com> * Cherry-pick ExP platform work from master (#12160) * User cannot belong to all experiments in an experiment group (#11945) * 10790 prep - Create an experiments/ folder (#11980) * experiments.ts -> experiments/manager.ts * eexperimentGroups -> experiments/experimentGroups * test/experiments.u.t -> test/experiments/manager.u.t * experimentGroups -> groups * Whoops committed one file too many * Add support for VS Code's experiment service (#11979) * Add npm package * News entry * experiments.ts -> experiments/manager.ts * Wrong issue number * eexperimentGroups -> experiments/experimentGroups * Move experiments.unit.tests.ts -> experiments/ * Commit new files * Merge gone sideways * Add types * Add opt in/out handling * Activation (service registry) * Don't pin tas-client to one version * Unit tests + fixes * Lol forgot to remove a comment + add headers * Forgot 'use strict' in service.ts * Use IApplicationEnvironment instead of IExtensions * Apply suggestions from code review Co-authored-by: Don Jayamanne <don.jayamanne@yahoo.com> * Remove unnecessary formatted props * n e v e r m i n d * Aight fixed it * flight -> experiment * Check stub calls instead of ctor impl * removed getExperimentService stub check * Set shared properties for all telemetry events * Add test for shared properties Co-authored-by: Don Jayamanne <don.jayamanne@yahoo.com> * Fix merge issues * Fix index unit tests * Revert "Fix index unit tests" This reverts commit 2fb61fc366c2c55b5c4b9c34e766ffbbcd50be74. * Make MPLS and vscode-extension-telemetry work together 🤝 (#11823) * Revert "Revert vscode-extension-telemetry changes for the release (#11602)" This reverts commit 71d17932d3268fb20c55e745a82f2da8bf1f3d0c. * Remove entry from changelog + add new news entry * Update LS code to use periods instead of slashes * Revert "Update LS code to use periods instead of slashes" This reverts commit 13566513a86bbe63365cfc16c387fe4c504bfc10. * Replace slashes before sending telemetry instead * Too fast too furious * Fix more merge issues Co-authored-by: Don Jayamanne <don.jayamanne@yahoo.com> Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com> * Update version and changelog for point release (#12171) * Ensure extension features are started when in Deprecate PythonPath experiment and opening a file without any folder opened (#12182) * Ensure extension features are started when in Deprecate PythonPath experiment and opening a file without any folder opened. * Added comments * Update change log (#12190) * Cherry pick fix for hasInterpreters and update change log (#12198) * Double-check for interpreters when running diagnostics (#12158) * Get interpreters if hasInterpreters returns false * Undo ignoreErrors() * Add unit tests * Fixed tests * Newline * Fix merge issues. * Update change log Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com> * Update version for point release (#12259) Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com> Co-authored-by: Rich Chiodo <rchiodo@users.noreply.github.com> Co-authored-by: Jim Griesmer <jimgries@microsoft.com> Co-authored-by: Kartik Raj <karraj@microsoft.com> Co-authored-by: Don Jayamanne <don.jayamanne@yahoo.com> * Make Jedi the default LS (#12226) * Make Jedi the default LS * Add news entry * Update change log Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com> Co-authored-by: Rich Chiodo <rchiodo@users.noreply.github.com> Co-authored-by: Jim Griesmer <jimgries@microsoft.com> Co-authored-by: Kartik Raj <karraj@microsoft.com> Co-authored-by: Don Jayamanne <don.jayamanne@yahoo.com> Co-authored-by: Luciana Abud <45497113+luabud@users.noreply.github.com> * Port raw auto start fix to release (#12288) * don't return a connection from the raw provider for getOnly (#12277) Co-authored-by: Ian Huff <ianhuff@alex-x230.northamerica.corp.microsoft.com> * update changelog and remove news entry Co-authored-by: Ian Huff <ianhuff@alex-x230.northamerica.corp.microsoft.com> * Rchiodo/rel june update (#12356) * Update security problems * Update release version * Update 3rd party notices * Add font awesome back to third party notices * ExP telemetry fixes (#12358) * Use extension channel instead of VS Code channel * Use publisher.name extension id (not just name) * Update vscode-tas-client Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com> * Port start page to release (#12365) * start page experiment and fixes (#12339) * move EnableStartPage enum to groups.ts * - remove the command from the experiment - fix the start page not loading when you go back to a priviews version and then updating again - update some labels in the start page - update the sample notebook to include run by line - the sample notebook now has a title - updated the images from the sample notebook * oops * oops * -add messages to open folder and workspace -add telemetry to measure if the webview error happens -give space between bullet points -add link to enable experiments to the sample notebook -get the release notes from a different file -fix bullet points in the sample notebook -sample notebook now opens with a counter in the title * fix a unit test * final changes * final final changes * final^3 changes * removed run by line from the sample notebook * Fixup after merge Co-authored-by: David Kutugata <dakutuga@microsoft.com> * Fixup bad merge * Last changes before release (#12371) Co-authored-by: Ian Huff <ianhu@microsoft.com> Co-authored-by: Ian Huff <ianhuff@alex-x230.northamerica.corp.microsoft.com> Co-authored-by: Karthik Nadig <kanadig@microsoft.com> Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com> Co-authored-by: Jim Griesmer <jimgries@microsoft.com> Co-authored-by: Kartik Raj <karraj@microsoft.com> Co-authored-by: Don Jayamanne <don.jayamanne@yahoo.com> Co-authored-by: Luciana Abud <45497113+luabud@users.noreply.github.com> Co-authored-by: David Kutugata <dakutuga@microsoft.com>

view details

Don Jayamanne

commit sha 3d829fc170ed9eedc17a8c58c648a988dcfeead0

Allow users to open VSC notebook even when using our own Notebook Editors (#12402) For #12400 * Side by side nb editors

view details

Don Jayamanne

commit sha 37a12b6c764001735fef8e1b2c9bf82d44c083c1

Add menu item to open nb with VSC Notebook (#12406) For #12405 Enable menu item only in VSC Insiders.

view details

Hugues Valois

commit sha e418ddec57ce2cad5875f6291fe7f845b2c51978

Do not trigger unnecessary work in language server when formatting a document (#12097) * Change getTempFileWithDocumentContents to not use the document's original file extension. Instead, use the .tmp extension which is not associated with Python language. This prevents a file add/delete event from reaching language server, invalidating some of its cache and causing unnecessary work. * Fix build. Co-authored-by: Don Jayamanne <don.jayamanne@yahoo.com>

view details

Rich Chiodo

commit sha 3ad61b1662f6ac068a482ed4d6455b5c8a4511c0

Add fixes for ipywidgets (I hope) and live share. (#12409)

view details

Don Jayamanne

commit sha 29e844c6dfa227857626f8e09c5e2f8431f04293

Disable use of proposedApi in stable VS Code (#12411) * Fixes to using Native NB with stable VS Code * Fixes

view details

David Kutugata

commit sha 2003e013e6d310a7d9da1df709d2210b9e85cc1c

Fix HTML links in markdown (#12395) * try string manipulation, katex and markdown-it * try to use markdown-it-latex * try to use latex2html5 * clean up latexManipulartion.ts and cellOutput.tsx * remove unused changes * add tests * rename latexManipulation to markdownManipulation * add news file and rename the test file * update package-lock * added one more test and a try catch * separate the fix of latex and links into different functions, and add comments to the fixLinks function

view details

Don Jayamanne

commit sha ae8903d41416e14078989f7460116d659bcbda61

Fixes to reverting notebooks (#12410)

view details

Kim-Adeline Miguel

commit sha 98e6aa5dfbb404ab44cdceff1328143e32dc5ed8

Pin py to 1.8.1 (Windows test failures) (#12407)

view details

Ian Huff

commit sha ea1c3c0c94c52cd3111b5d9b89a55f7b66eea6c5

turn on zmq for five percent (#12426) Co-authored-by: Ian Huff <ianhuff@alex-x230.northamerica.corp.microsoft.com>

view details

Rich Chiodo

commit sha ff06604524c1ed6463a36479a5edb59bf72c588c

Fix regression caused by multiple language support around indentation (#12428) * Fix serialization of language configuration to match what VS code does. * Add news entry * Missing parts of the configuration (functional test caught bracket matching) * Add test for indentation

view details

Mikhail Arkhipov

commit sha 98a9b506a79101db45a327f59981a92d0e0721c6

Turn off LS survey and banner (#12401) * Fix path * Suppress LS banner and survey * Comment * Format

view details

Karthik Nadig

commit sha 2a71954b0ccb9f3bb4538e37972dba9910025e98

Remove APIs related to ptvsd paths (#11757)

view details

Karthik Nadig

commit sha 474c49ddf82a37c80c781e19123a248accdad9f1

Remove TS debugAdapter (#11755) * Remove TS debugAdapter - initial * Fix renameSourceMaps * Test fixes

view details

Karthik Nadig

commit sha 650e4a93aa9c855113cfc4ea94033678a53eb6ab

Remove DebugAdapterNewPtvsd and DebugAdapterDescriptorFactory experiment. (#11769) * Remove DebugAdapterNewPtvsd and DebugAdapterDescriptorFactory experiment. * Fix tests * Remove experiments from json files

view details

Karthik Nadig

commit sha 6dc38e593bcdf69cec3adceb39af475dc572bde8

Update pinned node version (#12007)

view details

Karthik Nadig

commit sha 0eff545c1dc1f11f2b5eae3b7400a751c531ba16

Remove TS debug adapter subprocess support (#12008) * Remove TS debug adapter subprocess support * Address comments

view details

Karthik Nadig

commit sha 475b046e55930e6eafdbc17348f075de376725c6

Remove ptvsd install (#11998) * Remove ptvsd install and update to debugpy * Remove ptvsd install and switch to debugpy

view details

push time in 12 days

Pull request review commentmicrosoft/vscode-python

Move interpreter-info-related code to the py-envs component tree.

 // Copyright (c) Microsoft Corporation. All rights reserved. // Licensed under the MIT License. +// A representation of the information needed to run a Python executable. export type PythonExecInfo = {     command: string;     args: string[];      python: string[];+    pythonExecutable: string; }; -export function getPythonExecInfo(python: string | string[], pythonArgs?: string[]): PythonExecInfo {+// Compose Python execution info for the given executable.+export function buildPythonExecInfo(python: string | string[], pythonArgs?: string[]): PythonExecInfo {     if (Array.isArray(python)) {         const args = python.slice(1);         if (pythonArgs) {             args.push(...pythonArgs);         }-        return { command: python[0], args, python };+        return {+            command: python[0],+            args,+            python,+            pythonExecutable: python[python.length - 1]+        };     } else {-        return { command: python, args: pythonArgs || [], python: [python] };+        return {+            command: python,+            args: pythonArgs || [],+            python: [python],+            pythonExecutable: python+        };     } }++// Create a copy, optionally adding to the args to pass to Python.+export function copyPythonExecInfo(orig: PythonExecInfo, extraPythonArgs?: string[]): PythonExecInfo {+    const info = {

We need to deep-copy, whereas Object.assign() only does a shallow copy.

ericsnowcurrently

comment created time in 12 days

Pull request review commentmicrosoft/vscode-python

Move interpreter-info-related code to the py-envs component tree.

+// Copyright (c) Microsoft Corporation. All rights reserved.+// Licensed under the MIT License.++import { expect } from 'chai';+import { join as pathJoin } from 'path';+import { IMock, Mock, MockBehavior } from 'typemoq';+import { StdErrError } from '../../../client/common/process/types';+import { buildPythonExecInfo } from '../../../client/pythonEnvironments/exec';+import { getExecutablePath } from '../../../client/pythonEnvironments/info/executable';+import { EXTENSION_ROOT_DIR_FOR_TESTS } from '../../constants';++const isolated = pathJoin(EXTENSION_ROOT_DIR_FOR_TESTS, 'pythonFiles', 'pyvsc-run-isolated.py');++type ExecResult = {+    stdout: string;+};+interface IDeps {+    exec(command: string, args: string[]): Promise<ExecResult>;+}++suite('getExecutablePath()', () => {+    let deps: IMock<IDeps>;+    const python = buildPythonExecInfo('path/to/python');++    setup(() => {+        deps = Mock.ofType<IDeps>(undefined, MockBehavior.Strict);+    });+    function verifyAll() {

It's a pattern that I've gotten used to doing I guess. However, in this case I do not expect we will add any other mocks to verify.

ericsnowcurrently

comment created time in 12 days

push eventericsnowcurrently/vscode-python

Eric Snow

commit sha 5e194c50e5d00d016029a83228a40eb538e53ce1

Fix an errant import. (#12488)

view details

push time in 12 days

delete branch ericsnowcurrently/vscode-python

delete branch : fix-bad-import

delete time in 12 days

push eventmicrosoft/vscode-python

Eric Snow

commit sha 5e194c50e5d00d016029a83228a40eb538e53ce1

Fix an errant import. (#12488)

view details

push time in 12 days

PR merged microsoft/vscode-python

Fix an errant import. skip news

A bad import in master slipped through the cracks when we merged #12432. This fixes that.

+1 -1

1 comment

1 changed file

ericsnowcurrently

pr closed time in 12 days

Pull request review commentmicrosoft/vscode-python

Move interpreter-info-related code to the py-envs component tree.

 export function extractInterpreterInfo(python: string, raw: PythonEnvInfo): Inte         sysPrefix: raw.sysPrefix     }; }++type ShellExecResult = {+    stdout: string;+    stderr?: string;+};+type ShellExecFunc = (command: string, timeout: number) => Promise<ShellExecResult>;+type Logger = {

It happens to correspond to our existing types. However, this code does not care about those types. It only specifies what it needs, hence we have a type here rather than creating a dependency on existing types in some other module.

ericsnowcurrently

comment created time in 12 days

Pull request review commentmicrosoft/vscode-python

Move interpreter-info-related code to the py-envs component tree.

+// Copyright (c) Microsoft Corporation. All rights reserved.+// Licensed under the MIT License.++import { getExecutable as getPythonExecutableCommand } from '../../common/process/internal/python';+import { copyPythonExecInfo, PythonExecInfo } from '../exec';++type ExecResult = {+    stdout: string;+};+type ExecFunc = (command: string, args: string[]) => Promise<ExecResult>;

Unless there's a problem with clarity, I'd rather stick with the shorter name. Shorter names (where they do not sacrifice meaning) are almost always better for readers. This is especially true with a language like typescript that tends toward verbose names and expressions.

ericsnowcurrently

comment created time in 12 days

Pull request review commentmicrosoft/vscode-python

Move interpreter-info-related code to the py-envs component tree.

 // Copyright (c) Microsoft Corporation. All rights reserved. // Licensed under the MIT License. +// A representation of the information needed to run a Python executable. export type PythonExecInfo = {     command: string;     args: string[];      python: string[];+    pythonExecutable: string; }; -export function getPythonExecInfo(python: string | string[], pythonArgs?: string[]): PythonExecInfo {+// Compose Python execution info for the given executable.+export function buildPythonExecInfo(python: string | string[], pythonArgs?: string[]): PythonExecInfo {     if (Array.isArray(python)) {         const args = python.slice(1);         if (pythonArgs) {             args.push(...pythonArgs);         }-        return { command: python[0], args, python };+        return {+            command: python[0],+            args,+            python,+            pythonExecutable: python[python.length - 1]+        };     } else {-        return { command: python, args: pythonArgs || [], python: [python] };+        return {+            command: python,+            args: pythonArgs || [],+            python: [python],+            pythonExecutable: python+        };     } }++// Create a copy, optionally adding to the args to pass to Python.+export function copyPythonExecInfo(orig: PythonExecInfo, extraPythonArgs?: string[]): PythonExecInfo {

It's the object to be copied. I'm not sure what other name would be more meaningful here. The function name makes it clear we're copying it. FWIW, I've added JSDoc comments for the params. Perhaps that is what you were looking for?

ericsnowcurrently

comment created time in 12 days

PR opened microsoft/vscode-python

Fix an errant import. skip news

A bad import in master slipped through the cracks when we merged #12432. This fixes that.

+1 -1

0 comment

1 changed file

pr created time in 12 days

create barnchericsnowcurrently/vscode-python

branch : fix-bad-import

created branch time in 12 days

push eventericsnowcurrently/vscode-python

Kim-Adeline Miguel

commit sha 65f9709b295547de29e9448ca955e015b63d35c1

Fix `linting.pylintEnabled` setting check (#12444) * Fix `linting.pylintEnabled` setting check * Use stub instead of handspun variable

view details

Pavel Minaev

commit sha b2d2ec34bb7c0816b6f94da64f403169da54988c

Fix #11678: Add "argsExpansion" debug property to launch.json schema (#12445)

view details

push time in 12 days

Pull request review commentmicrosoft/vscode-python

Move interpreter-info-related code to the py-envs component tree.

 // Copyright (c) Microsoft Corporation. All rights reserved. // Licensed under the MIT License. +// A representation of the information needed to run a Python executable. export type PythonExecInfo = {     command: string;     args: string[];      python: string[];+    pythonExecutable: string; }; -export function getPythonExecInfo(python: string | string[], pythonArgs?: string[]): PythonExecInfo {+// Compose Python execution info for the given executable.+export function buildPythonExecInfo(python: string | string[], pythonArgs?: string[]): PythonExecInfo {     if (Array.isArray(python)) {         const args = python.slice(1);         if (pythonArgs) {             args.push(...pythonArgs);         }-        return { command: python[0], args, python };+        return {+            command: python[0],+            args,+            python,+            pythonExecutable: python[python.length - 1]+        };     } else {-        return { command: python, args: pythonArgs || [], python: [python] };+        return {+            command: python,+            args: pythonArgs || [],+            python: [python],+            pythonExecutable: python+        };     } }++// Create a copy, optionally adding to the args to pass to Python.

Sorry, I didn't think of that. :/ (I don't normally use VS Code to work on the extension.)

ericsnowcurrently

comment created time in 12 days

issue commentmicrosoft/vscode-python

Ripgrep causes out of memory crash due to `search.exclude` not being respected

@TheButlah, thanks for letting us know about this. From #11173 and https://github.com/microsoft/vscode/issues/48674 it looks like we only have limited options here:

  1. wait for VS Code to find a solution that incorporates "search.exclude" (https://github.com/microsoft/vscode/issues/48674)
  2. in nativeEditorProvider.ts, manually construct the excludes from 'search.exclude" to pass to findFiles()
  3. like (2), but apply the fix in a method (search() or a new one) on FileSystemUtils in src/client/common/platform/fileSystem.ts

If we don't want to wait for (1), which seems a low priority upstream, then (3) seems like the most sensible solution. We'll have to look into this further though.

TheButlah

comment created time in 12 days

issue closedmicrosoft/vscode-python

pytest treeview scrolls by itself when running tests

Environment data

  • VS Code version: 1.46.0
  • Extension version (available under the Extensions sidebar): 2020.6.89148
  • OS and version: macOS Catalina 10.15.3
  • Python version (& distribution if applicable, e.g. Anaconda): 3.8.1 64-bit
  • Type of virtual environment used (N/A | venv | virtualenv | conda | ...): conda

Expected behaviour

When running a single test, the tree view should not scroll by itself.

Actual behaviour

As seen in GIF the tree view scrolls dramatically and does not return to the same position. This is more annoying that you might think because it feels like you totally lose your place:

pytest-scroll

Steps to reproduce:

  1. Have a project with a lot of tests.
  2. Hit play on one in the middle.
  3. Watch treeview scroll by itself.

closed time in 12 days

pwinston

issue commentmicrosoft/vscode-python

pytest treeview scrolls by itself when running tests

Duplicate of #11743.

pwinston

comment created time in 12 days

issue commentmicrosoft/vscode-python

Refactor with rope does not adhere to files.exclude #9770

Certainly we'd rather get the language server to work for your needs. If that isn't an option then this is more of an enhancement than a bug. We don't send VS Code's "files.exclude" list to rope. We could look into doing so, but it isn't even clear if rope supports that. Regardless, I'll go ahead and mark this as an enhancement request.

FWIW, if you haven't already, it would be very helpful to have a separate bug report from you on the problems you have had with the language server.

@jakebailey

p-se

comment created time in 12 days

issue commentmicrosoft/vscode-python

The Python Tools server crashed 5 times in the last 3 minutes. The server will not be restarted.

@jakebailey should I leave this here for you or send this over to the other repo?

MarekOzana

comment created time in 12 days

issue commentmicrosoft/vscode-python

The Python Tools server crashed 5 times in the last 3 minutes. The server will not be restarted.

That looks like a problem with the Language Server install. We'll look into it further.

MarekOzana

comment created time in 12 days

delete branch ericsnowcurrently/vscode-python

delete branch : logging-changes-only

delete time in 12 days

push eventericsnowcurrently/vscode-python

Eric Snow

commit sha def0966b71a75ec73dd844b161a0fc14a0c688f5

Logging cleanup. (#11606) For #9837

view details

Kartik Raj

commit sha f1ba4908c3d6427c66412e5e2417011826d09b4c

Moved all logging into the Python output channel (#11695) * Added support * Correction * Only use console when environment variable is set * Code reviews * Added doc comments

view details

Kartik Raj

commit sha 9bedf2d350d2f9f41ce0ba6770cd2dbc5577aa7d

Added setting `python.logging.level` which carries the logging level value the extension will log at (#11698) * Added setting * Code reviews * Fix unit tests * Code reviews * Put config.level back * Added commnet * Code review * More code reviews * Fix tests

view details

Kartik Raj

commit sha fe1a91a234281263014323ffe123849048d8386b

Monkeypatch console.* calls on CI if we are asked to (#11897) * Move console.* monkeypatching to src/test/testLogging.ts * Use monkeypatching in all tests launched using testBootstrap.ts * Use monkeypatching in single workspace and multiroot tests * News entry * Don't do monkeypatching for smoketests * Modify gulp task to not delete 'out/client/logging' directory * Undo smoke test ccheck * Import only from ./out/client/logging in test logger * Added comment * More corrections * Add comments * Correct smoke tests * Oops

view details

Tim Ruscica

commit sha 834449f6f9b64e6aa839d49a041f1774a6c5f3f0

added max height for variable explorer (#12438)

view details

Rich Chiodo

commit sha 765c48387306b2526bb3b4b5d8f6dc9fc0b2b78d

Fix disposed execution factory to not have binding failures. (#12431) * Fix disposed execution factory to not have binding failures. * Fix linting tests

view details

Tim Ruscica

commit sha e6fc11dd29b7217e3ade0dcc140240e7b83a26af

Added telemetry for export to python and html (#12435) * added initial telemetry * spelling fixes * moved location of sending telemetry * fixed export to python telemetry * added suggested new telemetry * changed telemetry to send format * changed open close telemetry * small changes * removed unused imports * combined some telementry together * small typo fix * simplified small block * fixed lint

view details

Mikhail Arkhipov

commit sha b7a18225864a44e4d1a916cba6773c5f992623af

Actually fix user settings for `jediEnabled`. (#12433) * Fix path * Actually fix settings * Add news * Add test * Format * Suppress 'jediEnabled' removal

view details

Don Jayamanne

commit sha f8f4691f3596cb29004a1f64d04d1d23223e6f51

Minor refactoring to notebook model (#12437) Take ownership of a notebook model when it is opened (not when it is created) Delete clone method.

view details

Tim Ruscica

commit sha 23b9f5aab567ae72f053d8995e43cab73baa3976

removed space from HTML label (#12458)

view details

Rich Chiodo

commit sha 9004a5561dfa887a4b989e616fbbc0c476200560

Support not needing a password on a jupyter connection (#12456) * Support not needing a password on a jupyter connection * Fix unit tests

view details

Tim Ruscica

commit sha e7136b1448d27e9a607ca0d8242d4272b48aabdb

fixed a bug (#12464)

view details

Karthik Nadig

commit sha da85a769070ee785643e7929c8e82db0bd5e1f4a

Restore DebugAdapter experiment (#12483)

view details

Karthik Nadig

commit sha 17e317b7a48f5d83691e543db6aef23d2f6d80e0

Merge pull request #12432 from ericsnowcurrently/logging-changes-only Pull in the logging-related changes from the "logging-changes-and-drop-old-debugger" branch.

view details

push time in 12 days

pull request commentmicrosoft/vscode-python

Pull in the logging-related changes from the "logging-changes-and-drop-old-debugger" branch.

@karthiknadig please do your "Create a merge commit" magic. 😄

ericsnowcurrently

comment created time in 12 days

issue commentmicrosoft/vscode-python

Debugging pytest tests ignore the set .env file

The "python.envFile" setting definitely should be respected when debugging tests. The relevant extension code uses that setting by default when launching the debugger for tests.

You can also set "envFile" in your debugger config (in .vscode/launch.json) which overrides the workspace config. Likewise you can use the "env" setting in your debugger config to set environment variables directly. However, those debugger config settings are only respected for tests if the relevant config in launch.json has "request": "test".

(See: https://code.visualstudio.com/docs/python/testing#_debug-tests)

Do you get the same problem if you add a debugger config with "envFile" set in it, like the following, in .vscode/launch.json:

{
    "name": "Debug Flask Tests",
    "type": "python",
    "request": "test",
    "envFile": "/Users/myuser/dev/project/backend/.env.local_test"
}

What about if you set "env" there?

{
    "name": "Debug Flask Tests",
    "type": "python",
    "request": "test",
    "env": {
        "PYTHONPATH": "../backend-lib:$PYTHONPATH",
        "FLASK_APP": "api.app",
        "FLASK_ENV": "development",
        "DEBUG": true
    }
}

Using the explicit "env" will help to identify if the debugger is having trouble with the content of the .env file.

Also, please refer to the docs on debugging flask apps, though that doesn't relate to running tests.

flaker

comment created time in 12 days

issue commentmicrosoft/vscode-python

Unexpected "problems" reported for Django model attributes.

@fahadmalik-creator, sorry for any confusion. In the "View" menu click on "Output". Then, in the "OUTPUT" panel, click on the pull-down menu on the right (it probably defaults to "Tasks"). In that menu click on "Python". Paste the content (text, not image) here. Then do the same for "Python Language Server". Thanks.

fahadmalik-creator

comment created time in 12 days

pull request commentmicrosoft/vscode-python

Added `workspaceContains:pyproject.toml` to activationEvents

I'm fine with the PR (though I'd suggest adding setup.py to it). However, I'm double-checking with someone else first. Thanks for your patience.

BrandonLWhite

comment created time in 12 days

issue commentmicrosoft/vscode-python

If I have Python-related files in my workspace, automatically activate the extension

@luabud, are we okay to go ahead with PR #12056 (to activate where there is a top-level pyproject.toml)? It's a good start.

FWIW, I think we should make sure setup.py gets the same treatment, whether as part of #12056 or in a separate PR.

DonJayamanne

comment created time in 12 days

push eventericsnowcurrently/vscode-python

Karthik Nadig

commit sha 2a71954b0ccb9f3bb4538e37972dba9910025e98

Remove APIs related to ptvsd paths (#11757)

view details

Karthik Nadig

commit sha 474c49ddf82a37c80c781e19123a248accdad9f1

Remove TS debugAdapter (#11755) * Remove TS debugAdapter - initial * Fix renameSourceMaps * Test fixes

view details

Karthik Nadig

commit sha 650e4a93aa9c855113cfc4ea94033678a53eb6ab

Remove DebugAdapterNewPtvsd and DebugAdapterDescriptorFactory experiment. (#11769) * Remove DebugAdapterNewPtvsd and DebugAdapterDescriptorFactory experiment. * Fix tests * Remove experiments from json files

view details

Karthik Nadig

commit sha 6dc38e593bcdf69cec3adceb39af475dc572bde8

Update pinned node version (#12007)

view details

Karthik Nadig

commit sha 0eff545c1dc1f11f2b5eae3b7400a751c531ba16

Remove TS debug adapter subprocess support (#12008) * Remove TS debug adapter subprocess support * Address comments

view details

Karthik Nadig

commit sha 475b046e55930e6eafdbc17348f075de376725c6

Remove ptvsd install (#11998) * Remove ptvsd install and update to debugpy * Remove ptvsd install and switch to debugpy

view details

Joyce Er

commit sha 4b20034288dad15bbd24eae02775c404526594c0

Deprecate ptvsd for data science (#12105)

view details

Don Jayamanne

commit sha d71250e83766e2fe5e8f588da432ee1dfa5ee7af

Remove path from untitled files when using VSC NB (#12430) For #10496 We don't need the fully qualified path for untitled notebooks. However auto saving in untitiled nb doesn't work, VSC Master has a fix but we're waiting for insiders to get updated.

view details

Eric Snow

commit sha 3e451ac7ad99972dbb40b42c9b78794c92496258

Enable testing of the new debug adapter. (#11908) For #11704, #11733, and #9383 (and #4758?). We had a bunch of tests for the old debug adapter, but they were all disabled due to flakiness. Pretty much none of them are valid now that we've removed the old debug adapter. So we've removed all the old tests and added some new ones that run against the VS Code API (rather than using a DAP client).

view details

Anthony Shaw

commit sha a98be63c7bb9c1205e2c3754ceca4dc2e930e139

Update incorrect JSDoc annotations (#12101) * Update incorrect JSDoc annotations * Create 12101.md * Update src/client/common/utils/cacheUtils.ts Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com> * Update src/client/datascience/jupyter/kernels/kernelSelector.ts Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com> * Update src/client/datascience/jupyter/kernels/kernelSelections.ts Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com> * Update src/test/mocks/vsc/uri.ts Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com> * Update news/3 Code Health/12101.md Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com> Co-authored-by: Kartik Raj <karraj@microsoft.com>

view details

Karthik Nadig

commit sha 6009235b3c8320397aa6512b9c3b8711aa7b134e

Merge pull request #12434 from karthiknadig/dbg1 Merge back debugger changes to master.

view details

Bill Schnurr

commit sha c9a2f24df6c83b6799c6a9524c3d6c193e116bb3

LSP version update (#12386)

view details

push time in 16 days

push eventericsnowcurrently/vscode-python

Kartik Raj

commit sha fe1a91a234281263014323ffe123849048d8386b

Monkeypatch console.* calls on CI if we are asked to (#11897) * Move console.* monkeypatching to src/test/testLogging.ts * Use monkeypatching in all tests launched using testBootstrap.ts * Use monkeypatching in single workspace and multiroot tests * News entry * Don't do monkeypatching for smoketests * Modify gulp task to not delete 'out/client/logging' directory * Undo smoke test ccheck * Import only from ./out/client/logging in test logger * Added comment * More corrections * Add comments * Correct smoke tests * Oops

view details

push time in 16 days

push eventericsnowcurrently/vscode-python

Eric Snow

commit sha 0f26747b17307db5a98e246e50356ed45dc927bb

Enable testing of the new debug adapter. (#11908) For #11704, #11733, and #9383 (and #4758?). We had a bunch of tests for the old debug adapter, but they were all disabled due to flakiness. Pretty much none of them are valid now that we've removed the old debug adapter. So we've removed all the old tests and added some new ones that run against the VS Code API (rather than using a DAP client).

view details

Kartik Raj

commit sha 7df168d62e5c39f94a455ea29898654bf0c71d00

Monkeypatch console.* calls on CI if we are asked to (#11897) * Move console.* monkeypatching to src/test/testLogging.ts * Use monkeypatching in all tests launched using testBootstrap.ts * Use monkeypatching in single workspace and multiroot tests * News entry * Don't do monkeypatching for smoketests * Modify gulp task to not delete 'out/client/logging' directory * Undo smoke test ccheck * Import only from ./out/client/logging in test logger * Added comment * More corrections * Add comments * Correct smoke tests * Oops

view details

Joyce Er

commit sha 8205828216b168df2d3d54320ceda01a53a9d63d

Deprecate ptvsd for data science (#12105)

view details

push time in 16 days

issue commentmicrosoft/vscode-python

Debugging pytest tests ignore the set .env file

@flaker, thanks for letting us know about this. We'll take a look and get back to you as soon as possible.

flaker

comment created time in 16 days

push eventericsnowcurrently/vscode-python

Tim Ruscica

commit sha 9d382de3b594fbcd3222e96e52324772955b46f9

Added exporting notebook to HTML (#12375) * export working * added export base * file opens when click yes button * small changes to exportManagerFileOpener * small changes * added tests for html (new file) * localized string * added news file * added missing keys to package.nls.json * addressed comments * removes strange space * checked exported file is HTML file * modified test * fixed tests * changed launch.json back to original

view details

Brett Cannon

commit sha 00d9ddfdea0bfcf0fd4a2bb694a35ce224705865

Explicitly add the GitHub release step

view details

Rich Chiodo

commit sha a03edb51066adcd4721c95bb9eff781ad07d1b7d

Merging changes back from the release branch (#12393) * Port custom editor changes to release branch (#12222) * Implement the changes necessary to use the new custom editor (#12188) * Turn on custom editor again * Fix copy problem * Fix copy problem again * Get undo/redo to work * Some fixes for synching more than one editor * Fix untitled. Fix timeouts * fix command manager to not be used. Not necessary with temp path. fix delete/insert commands to undo properly * Fix functional test * Add experiment * Since package json is enabling proposed api, turn of notebooks with experiment * Turn off proposed api * Upgrade VS code to 1.45 so can use new api outside of insiders * Update package.json dynamically * Fix merge code to handle arrays * Fix unit tests. Backup happens at the provider level now * Fix hygiene * Fix untitled to work for old provider too * Some feedback and attempt to fix URI problem on linux/mac * Review feedback * Update changelog * Remove news entry * Port run by line stepping fix to release (#12223) * fix continue event to run cell (#12211) Co-authored-by: Ian Huff <ianhuff@alex-x230.northamerica.corp.microsoft.com> * update changelog and delete news file Co-authored-by: Ian Huff <ianhuff@alex-x230.northamerica.corp.microsoft.com> * Port run by line stop becoming interrupt to the release branch (#12271) * Run by line changes for release (#12256) * Run by line changes for release * Translate step tooltip and make sure F10 works outside of already debugging * Update changelog * Cherry-pick fixes from master to june release (#12282) * Merge stuff from may release back into master (#12233) * Revert vscode-extension-telemetry changes for the release (#11602) (#11656) * Revert "Fix slashes in telemetry unit tests (#11572)" This reverts commit 7431c9c53fa5f80fd440b47ae19a825286d3d760. * Revert "Use vscode-extension-telemetry for our exceptions & error telemetry (#11524)" This reverts commit d5065e6976ab8bf3289d70be4a34110a53b224c5. * Remove from changelog * Port storage fix to release branch (#11673) * Fix storage not being used (#11649) * Fix storage not being used * Add disposable to storage so it won't write after shutdown * Fix dirty title * Hack to get tests to pass * Another way to get run all to not interfere * Update changelog * Port scrolling fix to release (#11688) * Fix scrolling (#11681) * Fix scrolling * Review feedback - fix scrolling on expand/collapse * Update changelog * Update package.json Co-authored-by: Jim Griesmer <jimgries@microsoft.com> * Cherry-pick pipenv changes and pythonpath prompt changes to release (#11700) * Show the prompt again if user clicks on more info (#11664) * Show the prompt again if user clicks on more info * Review feedback * Use Learn more as text for the link. * Leave pipenv in a corner until the user decides to select an interpreter (#11654) * add onSuggestion option * Swap onActivation with onSuggestion * Update unit tests * Remove registration of IPipenvService * Move didTriggerInterpreterSuggestions logic inside pipenv locator * Fix existing unit tests * Add new unit tests * Replace typemoq any param with object * Shorten the tests * Fix warning * Duplicate teardown Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com> * Update extension version (#11730) * Update extension version * Update date in changelog. * Update change log with additional notes. (#11764) * Cherry picks and version updates for bug fix release (#11878) * Do not execute shebang as an interpreter until user has clicked on the codelens enclosing the shebang (#11816) * Do not execute shebang as an interpreter until user has clicked on the codelens enclosing the shebang * Rename * Oops * Update src/test/providers/shebangCodeLenseProvider.unit.test.ts Co-authored-by: Karthik Nadig <kanadig@microsoft.com> Co-authored-by: Karthik Nadig <kanadig@microsoft.com> * Update version and change log for bugfix release Co-authored-by: Kartik Raj <karraj@microsoft.com> * Cherry-pick ExP platform work from master (#12160) * User cannot belong to all experiments in an experiment group (#11945) * 10790 prep - Create an experiments/ folder (#11980) * experiments.ts -> experiments/manager.ts * eexperimentGroups -> experiments/experimentGroups * test/experiments.u.t -> test/experiments/manager.u.t * experimentGroups -> groups * Whoops committed one file too many * Add support for VS Code's experiment service (#11979) * Add npm package * News entry * experiments.ts -> experiments/manager.ts * Wrong issue number * eexperimentGroups -> experiments/experimentGroups * Move experiments.unit.tests.ts -> experiments/ * Commit new files * Merge gone sideways * Add types * Add opt in/out handling * Activation (service registry) * Don't pin tas-client to one version * Unit tests + fixes * Lol forgot to remove a comment + add headers * Forgot 'use strict' in service.ts * Use IApplicationEnvironment instead of IExtensions * Apply suggestions from code review Co-authored-by: Don Jayamanne <don.jayamanne@yahoo.com> * Remove unnecessary formatted props * n e v e r m i n d * Aight fixed it * flight -> experiment * Check stub calls instead of ctor impl * removed getExperimentService stub check * Set shared properties for all telemetry events * Add test for shared properties Co-authored-by: Don Jayamanne <don.jayamanne@yahoo.com> * Fix merge issues * Fix index unit tests * Revert "Fix index unit tests" This reverts commit 2fb61fc366c2c55b5c4b9c34e766ffbbcd50be74. * Make MPLS and vscode-extension-telemetry work together 🤝 (#11823) * Revert "Revert vscode-extension-telemetry changes for the release (#11602)" This reverts commit 71d17932d3268fb20c55e745a82f2da8bf1f3d0c. * Remove entry from changelog + add new news entry * Update LS code to use periods instead of slashes * Revert "Update LS code to use periods instead of slashes" This reverts commit 13566513a86bbe63365cfc16c387fe4c504bfc10. * Replace slashes before sending telemetry instead * Too fast too furious * Fix more merge issues Co-authored-by: Don Jayamanne <don.jayamanne@yahoo.com> Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com> * Update version and changelog for point release (#12171) * Ensure extension features are started when in Deprecate PythonPath experiment and opening a file without any folder opened (#12182) * Ensure extension features are started when in Deprecate PythonPath experiment and opening a file without any folder opened. * Added comments * Update change log (#12190) * Cherry pick fix for hasInterpreters and update change log (#12198) * Double-check for interpreters when running diagnostics (#12158) * Get interpreters if hasInterpreters returns false * Undo ignoreErrors() * Add unit tests * Fixed tests * Newline * Fix merge issues. * Update change log Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com> * Update version for point release (#12259) Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com> Co-authored-by: Rich Chiodo <rchiodo@users.noreply.github.com> Co-authored-by: Jim Griesmer <jimgries@microsoft.com> Co-authored-by: Kartik Raj <karraj@microsoft.com> Co-authored-by: Don Jayamanne <don.jayamanne@yahoo.com> * Make Jedi the default LS (#12226) * Make Jedi the default LS * Add news entry * Update change log Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com> Co-authored-by: Rich Chiodo <rchiodo@users.noreply.github.com> Co-authored-by: Jim Griesmer <jimgries@microsoft.com> Co-authored-by: Kartik Raj <karraj@microsoft.com> Co-authored-by: Don Jayamanne <don.jayamanne@yahoo.com> Co-authored-by: Luciana Abud <45497113+luabud@users.noreply.github.com> * Port raw auto start fix to release (#12288) * don't return a connection from the raw provider for getOnly (#12277) Co-authored-by: Ian Huff <ianhuff@alex-x230.northamerica.corp.microsoft.com> * update changelog and remove news entry Co-authored-by: Ian Huff <ianhuff@alex-x230.northamerica.corp.microsoft.com> * Rchiodo/rel june update (#12356) * Update security problems * Update release version * Update 3rd party notices * Add font awesome back to third party notices * ExP telemetry fixes (#12358) * Use extension channel instead of VS Code channel * Use publisher.name extension id (not just name) * Update vscode-tas-client Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com> * Port start page to release (#12365) * start page experiment and fixes (#12339) * move EnableStartPage enum to groups.ts * - remove the command from the experiment - fix the start page not loading when you go back to a priviews version and then updating again - update some labels in the start page - update the sample notebook to include run by line - the sample notebook now has a title - updated the images from the sample notebook * oops * oops * -add messages to open folder and workspace -add telemetry to measure if the webview error happens -give space between bullet points -add link to enable experiments to the sample notebook -get the release notes from a different file -fix bullet points in the sample notebook -sample notebook now opens with a counter in the title * fix a unit test * final changes * final final changes * final^3 changes * removed run by line from the sample notebook * Fixup after merge Co-authored-by: David Kutugata <dakutuga@microsoft.com> * Fixup bad merge * Last changes before release (#12371) Co-authored-by: Ian Huff <ianhu@microsoft.com> Co-authored-by: Ian Huff <ianhuff@alex-x230.northamerica.corp.microsoft.com> Co-authored-by: Karthik Nadig <kanadig@microsoft.com> Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com> Co-authored-by: Jim Griesmer <jimgries@microsoft.com> Co-authored-by: Kartik Raj <karraj@microsoft.com> Co-authored-by: Don Jayamanne <don.jayamanne@yahoo.com> Co-authored-by: Luciana Abud <45497113+luabud@users.noreply.github.com> Co-authored-by: David Kutugata <dakutuga@microsoft.com>

view details

Don Jayamanne

commit sha 3d829fc170ed9eedc17a8c58c648a988dcfeead0

Allow users to open VSC notebook even when using our own Notebook Editors (#12402) For #12400 * Side by side nb editors

view details

Don Jayamanne

commit sha 37a12b6c764001735fef8e1b2c9bf82d44c083c1

Add menu item to open nb with VSC Notebook (#12406) For #12405 Enable menu item only in VSC Insiders.

view details

Hugues Valois

commit sha e418ddec57ce2cad5875f6291fe7f845b2c51978

Do not trigger unnecessary work in language server when formatting a document (#12097) * Change getTempFileWithDocumentContents to not use the document's original file extension. Instead, use the .tmp extension which is not associated with Python language. This prevents a file add/delete event from reaching language server, invalidating some of its cache and causing unnecessary work. * Fix build. Co-authored-by: Don Jayamanne <don.jayamanne@yahoo.com>

view details

Rich Chiodo

commit sha 3ad61b1662f6ac068a482ed4d6455b5c8a4511c0

Add fixes for ipywidgets (I hope) and live share. (#12409)

view details

Don Jayamanne

commit sha 29e844c6dfa227857626f8e09c5e2f8431f04293

Disable use of proposedApi in stable VS Code (#12411) * Fixes to using Native NB with stable VS Code * Fixes

view details

David Kutugata

commit sha 2003e013e6d310a7d9da1df709d2210b9e85cc1c

Fix HTML links in markdown (#12395) * try string manipulation, katex and markdown-it * try to use markdown-it-latex * try to use latex2html5 * clean up latexManipulartion.ts and cellOutput.tsx * remove unused changes * add tests * rename latexManipulation to markdownManipulation * add news file and rename the test file * update package-lock * added one more test and a try catch * separate the fix of latex and links into different functions, and add comments to the fixLinks function

view details

Don Jayamanne

commit sha ae8903d41416e14078989f7460116d659bcbda61

Fixes to reverting notebooks (#12410)

view details

Kim-Adeline Miguel

commit sha 98e6aa5dfbb404ab44cdceff1328143e32dc5ed8

Pin py to 1.8.1 (Windows test failures) (#12407)

view details

Ian Huff

commit sha ea1c3c0c94c52cd3111b5d9b89a55f7b66eea6c5

turn on zmq for five percent (#12426) Co-authored-by: Ian Huff <ianhuff@alex-x230.northamerica.corp.microsoft.com>

view details

Rich Chiodo

commit sha ff06604524c1ed6463a36479a5edb59bf72c588c

Fix regression caused by multiple language support around indentation (#12428) * Fix serialization of language configuration to match what VS code does. * Add news entry * Missing parts of the configuration (functional test caught bracket matching) * Add test for indentation

view details

Mikhail Arkhipov

commit sha 98a9b506a79101db45a327f59981a92d0e0721c6

Turn off LS survey and banner (#12401) * Fix path * Suppress LS banner and survey * Comment * Format

view details

Eric Snow

commit sha def0966b71a75ec73dd844b161a0fc14a0c688f5

Logging cleanup. (#11606) For #9837

view details

Kartik Raj

commit sha f1ba4908c3d6427c66412e5e2417011826d09b4c

Moved all logging into the Python output channel (#11695) * Added support * Correction * Only use console when environment variable is set * Code reviews * Added doc comments

view details

Kartik Raj

commit sha 9bedf2d350d2f9f41ce0ba6770cd2dbc5577aa7d

Added setting `python.logging.level` which carries the logging level value the extension will log at (#11698) * Added setting * Code reviews * Fix unit tests * Code reviews * Put config.level back * Added commnet * Code review * More code reviews * Fix tests

view details

push time in 16 days

push eventericsnowcurrently/vscode-python

Tim Ruscica

commit sha 9d382de3b594fbcd3222e96e52324772955b46f9

Added exporting notebook to HTML (#12375) * export working * added export base * file opens when click yes button * small changes to exportManagerFileOpener * small changes * added tests for html (new file) * localized string * added news file * added missing keys to package.nls.json * addressed comments * removes strange space * checked exported file is HTML file * modified test * fixed tests * changed launch.json back to original

view details

Brett Cannon

commit sha 00d9ddfdea0bfcf0fd4a2bb694a35ce224705865

Explicitly add the GitHub release step

view details

Rich Chiodo

commit sha a03edb51066adcd4721c95bb9eff781ad07d1b7d

Merging changes back from the release branch (#12393) * Port custom editor changes to release branch (#12222) * Implement the changes necessary to use the new custom editor (#12188) * Turn on custom editor again * Fix copy problem * Fix copy problem again * Get undo/redo to work * Some fixes for synching more than one editor * Fix untitled. Fix timeouts * fix command manager to not be used. Not necessary with temp path. fix delete/insert commands to undo properly * Fix functional test * Add experiment * Since package json is enabling proposed api, turn of notebooks with experiment * Turn off proposed api * Upgrade VS code to 1.45 so can use new api outside of insiders * Update package.json dynamically * Fix merge code to handle arrays * Fix unit tests. Backup happens at the provider level now * Fix hygiene * Fix untitled to work for old provider too * Some feedback and attempt to fix URI problem on linux/mac * Review feedback * Update changelog * Remove news entry * Port run by line stepping fix to release (#12223) * fix continue event to run cell (#12211) Co-authored-by: Ian Huff <ianhuff@alex-x230.northamerica.corp.microsoft.com> * update changelog and delete news file Co-authored-by: Ian Huff <ianhuff@alex-x230.northamerica.corp.microsoft.com> * Port run by line stop becoming interrupt to the release branch (#12271) * Run by line changes for release (#12256) * Run by line changes for release * Translate step tooltip and make sure F10 works outside of already debugging * Update changelog * Cherry-pick fixes from master to june release (#12282) * Merge stuff from may release back into master (#12233) * Revert vscode-extension-telemetry changes for the release (#11602) (#11656) * Revert "Fix slashes in telemetry unit tests (#11572)" This reverts commit 7431c9c53fa5f80fd440b47ae19a825286d3d760. * Revert "Use vscode-extension-telemetry for our exceptions & error telemetry (#11524)" This reverts commit d5065e6976ab8bf3289d70be4a34110a53b224c5. * Remove from changelog * Port storage fix to release branch (#11673) * Fix storage not being used (#11649) * Fix storage not being used * Add disposable to storage so it won't write after shutdown * Fix dirty title * Hack to get tests to pass * Another way to get run all to not interfere * Update changelog * Port scrolling fix to release (#11688) * Fix scrolling (#11681) * Fix scrolling * Review feedback - fix scrolling on expand/collapse * Update changelog * Update package.json Co-authored-by: Jim Griesmer <jimgries@microsoft.com> * Cherry-pick pipenv changes and pythonpath prompt changes to release (#11700) * Show the prompt again if user clicks on more info (#11664) * Show the prompt again if user clicks on more info * Review feedback * Use Learn more as text for the link. * Leave pipenv in a corner until the user decides to select an interpreter (#11654) * add onSuggestion option * Swap onActivation with onSuggestion * Update unit tests * Remove registration of IPipenvService * Move didTriggerInterpreterSuggestions logic inside pipenv locator * Fix existing unit tests * Add new unit tests * Replace typemoq any param with object * Shorten the tests * Fix warning * Duplicate teardown Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com> * Update extension version (#11730) * Update extension version * Update date in changelog. * Update change log with additional notes. (#11764) * Cherry picks and version updates for bug fix release (#11878) * Do not execute shebang as an interpreter until user has clicked on the codelens enclosing the shebang (#11816) * Do not execute shebang as an interpreter until user has clicked on the codelens enclosing the shebang * Rename * Oops * Update src/test/providers/shebangCodeLenseProvider.unit.test.ts Co-authored-by: Karthik Nadig <kanadig@microsoft.com> Co-authored-by: Karthik Nadig <kanadig@microsoft.com> * Update version and change log for bugfix release Co-authored-by: Kartik Raj <karraj@microsoft.com> * Cherry-pick ExP platform work from master (#12160) * User cannot belong to all experiments in an experiment group (#11945) * 10790 prep - Create an experiments/ folder (#11980) * experiments.ts -> experiments/manager.ts * eexperimentGroups -> experiments/experimentGroups * test/experiments.u.t -> test/experiments/manager.u.t * experimentGroups -> groups * Whoops committed one file too many * Add support for VS Code's experiment service (#11979) * Add npm package * News entry * experiments.ts -> experiments/manager.ts * Wrong issue number * eexperimentGroups -> experiments/experimentGroups * Move experiments.unit.tests.ts -> experiments/ * Commit new files * Merge gone sideways * Add types * Add opt in/out handling * Activation (service registry) * Don't pin tas-client to one version * Unit tests + fixes * Lol forgot to remove a comment + add headers * Forgot 'use strict' in service.ts * Use IApplicationEnvironment instead of IExtensions * Apply suggestions from code review Co-authored-by: Don Jayamanne <don.jayamanne@yahoo.com> * Remove unnecessary formatted props * n e v e r m i n d * Aight fixed it * flight -> experiment * Check stub calls instead of ctor impl * removed getExperimentService stub check * Set shared properties for all telemetry events * Add test for shared properties Co-authored-by: Don Jayamanne <don.jayamanne@yahoo.com> * Fix merge issues * Fix index unit tests * Revert "Fix index unit tests" This reverts commit 2fb61fc366c2c55b5c4b9c34e766ffbbcd50be74. * Make MPLS and vscode-extension-telemetry work together 🤝 (#11823) * Revert "Revert vscode-extension-telemetry changes for the release (#11602)" This reverts commit 71d17932d3268fb20c55e745a82f2da8bf1f3d0c. * Remove entry from changelog + add new news entry * Update LS code to use periods instead of slashes * Revert "Update LS code to use periods instead of slashes" This reverts commit 13566513a86bbe63365cfc16c387fe4c504bfc10. * Replace slashes before sending telemetry instead * Too fast too furious * Fix more merge issues Co-authored-by: Don Jayamanne <don.jayamanne@yahoo.com> Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com> * Update version and changelog for point release (#12171) * Ensure extension features are started when in Deprecate PythonPath experiment and opening a file without any folder opened (#12182) * Ensure extension features are started when in Deprecate PythonPath experiment and opening a file without any folder opened. * Added comments * Update change log (#12190) * Cherry pick fix for hasInterpreters and update change log (#12198) * Double-check for interpreters when running diagnostics (#12158) * Get interpreters if hasInterpreters returns false * Undo ignoreErrors() * Add unit tests * Fixed tests * Newline * Fix merge issues. * Update change log Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com> * Update version for point release (#12259) Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com> Co-authored-by: Rich Chiodo <rchiodo@users.noreply.github.com> Co-authored-by: Jim Griesmer <jimgries@microsoft.com> Co-authored-by: Kartik Raj <karraj@microsoft.com> Co-authored-by: Don Jayamanne <don.jayamanne@yahoo.com> * Make Jedi the default LS (#12226) * Make Jedi the default LS * Add news entry * Update change log Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com> Co-authored-by: Rich Chiodo <rchiodo@users.noreply.github.com> Co-authored-by: Jim Griesmer <jimgries@microsoft.com> Co-authored-by: Kartik Raj <karraj@microsoft.com> Co-authored-by: Don Jayamanne <don.jayamanne@yahoo.com> Co-authored-by: Luciana Abud <45497113+luabud@users.noreply.github.com> * Port raw auto start fix to release (#12288) * don't return a connection from the raw provider for getOnly (#12277) Co-authored-by: Ian Huff <ianhuff@alex-x230.northamerica.corp.microsoft.com> * update changelog and remove news entry Co-authored-by: Ian Huff <ianhuff@alex-x230.northamerica.corp.microsoft.com> * Rchiodo/rel june update (#12356) * Update security problems * Update release version * Update 3rd party notices * Add font awesome back to third party notices * ExP telemetry fixes (#12358) * Use extension channel instead of VS Code channel * Use publisher.name extension id (not just name) * Update vscode-tas-client Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com> * Port start page to release (#12365) * start page experiment and fixes (#12339) * move EnableStartPage enum to groups.ts * - remove the command from the experiment - fix the start page not loading when you go back to a priviews version and then updating again - update some labels in the start page - update the sample notebook to include run by line - the sample notebook now has a title - updated the images from the sample notebook * oops * oops * -add messages to open folder and workspace -add telemetry to measure if the webview error happens -give space between bullet points -add link to enable experiments to the sample notebook -get the release notes from a different file -fix bullet points in the sample notebook -sample notebook now opens with a counter in the title * fix a unit test * final changes * final final changes * final^3 changes * removed run by line from the sample notebook * Fixup after merge Co-authored-by: David Kutugata <dakutuga@microsoft.com> * Fixup bad merge * Last changes before release (#12371) Co-authored-by: Ian Huff <ianhu@microsoft.com> Co-authored-by: Ian Huff <ianhuff@alex-x230.northamerica.corp.microsoft.com> Co-authored-by: Karthik Nadig <kanadig@microsoft.com> Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com> Co-authored-by: Jim Griesmer <jimgries@microsoft.com> Co-authored-by: Kartik Raj <karraj@microsoft.com> Co-authored-by: Don Jayamanne <don.jayamanne@yahoo.com> Co-authored-by: Luciana Abud <45497113+luabud@users.noreply.github.com> Co-authored-by: David Kutugata <dakutuga@microsoft.com>

view details

Don Jayamanne

commit sha 3d829fc170ed9eedc17a8c58c648a988dcfeead0

Allow users to open VSC notebook even when using our own Notebook Editors (#12402) For #12400 * Side by side nb editors

view details

Don Jayamanne

commit sha 37a12b6c764001735fef8e1b2c9bf82d44c083c1

Add menu item to open nb with VSC Notebook (#12406) For #12405 Enable menu item only in VSC Insiders.

view details

Hugues Valois

commit sha e418ddec57ce2cad5875f6291fe7f845b2c51978

Do not trigger unnecessary work in language server when formatting a document (#12097) * Change getTempFileWithDocumentContents to not use the document's original file extension. Instead, use the .tmp extension which is not associated with Python language. This prevents a file add/delete event from reaching language server, invalidating some of its cache and causing unnecessary work. * Fix build. Co-authored-by: Don Jayamanne <don.jayamanne@yahoo.com>

view details

Rich Chiodo

commit sha 3ad61b1662f6ac068a482ed4d6455b5c8a4511c0

Add fixes for ipywidgets (I hope) and live share. (#12409)

view details

Don Jayamanne

commit sha 29e844c6dfa227857626f8e09c5e2f8431f04293

Disable use of proposedApi in stable VS Code (#12411) * Fixes to using Native NB with stable VS Code * Fixes

view details

David Kutugata

commit sha 2003e013e6d310a7d9da1df709d2210b9e85cc1c

Fix HTML links in markdown (#12395) * try string manipulation, katex and markdown-it * try to use markdown-it-latex * try to use latex2html5 * clean up latexManipulartion.ts and cellOutput.tsx * remove unused changes * add tests * rename latexManipulation to markdownManipulation * add news file and rename the test file * update package-lock * added one more test and a try catch * separate the fix of latex and links into different functions, and add comments to the fixLinks function

view details

Don Jayamanne

commit sha ae8903d41416e14078989f7460116d659bcbda61

Fixes to reverting notebooks (#12410)

view details

Kim-Adeline Miguel

commit sha 98e6aa5dfbb404ab44cdceff1328143e32dc5ed8

Pin py to 1.8.1 (Windows test failures) (#12407)

view details

Ian Huff

commit sha ea1c3c0c94c52cd3111b5d9b89a55f7b66eea6c5

turn on zmq for five percent (#12426) Co-authored-by: Ian Huff <ianhuff@alex-x230.northamerica.corp.microsoft.com>

view details

Rich Chiodo

commit sha ff06604524c1ed6463a36479a5edb59bf72c588c

Fix regression caused by multiple language support around indentation (#12428) * Fix serialization of language configuration to match what VS code does. * Add news entry * Missing parts of the configuration (functional test caught bracket matching) * Add test for indentation

view details

Mikhail Arkhipov

commit sha 98a9b506a79101db45a327f59981a92d0e0721c6

Turn off LS survey and banner (#12401) * Fix path * Suppress LS banner and survey * Comment * Format

view details

push time in 16 days

PR opened microsoft/vscode-python

Reviewers
Pull in the logging-related changes from the "logging-changes-and-drop-old-debugger" branch. skip news

Notes:

  • the old debug adapter must be removed before these commits can land (see PR #11732)
  • each of the commits comes from the "logging-changes-and-drop-old-debugger" branch
  • each was reviewed separately in its own PR
  • each should be committed to master separately

So...this PR should be resolved via "Rebase and merge" or "Create a merge commit" and not "Squash and merge". This can be done via pushing to master via the git CLI or by using the GitHub UI. If we use GitHub then we will have to temporarily allow the selected "merge" button.

+747 -365

0 comment

23 changed files

pr created time in 16 days

create barnchericsnowcurrently/vscode-python

branch : logging-changes-only

created branch time in 16 days

push eventericsnowcurrently/vscode-python

Eric Snow

commit sha d6c78e82360a430333769f8b731dfdc53a707376

Fix lint errors.

view details

push time in 17 days

issue commentmicrosoft/vscode-python

Issue with Select Interpreter / Create Terminal after creation of new virtualenv

@david-waterworth, thanks for letting us know about this. We will work on fixing the issue as soon as we can.

david-waterworth

comment created time in 17 days

PR opened microsoft/vscode-python

Reviewers
Move interpreter-info-related code to the py-envs component tree. skip news

This change is part of the work to isolate a "component" for Python environments. The focus here is on pulling code related to getting interpreter info out of unrelated modules and into the py-envs component.

<!-- If an item below does not apply to you, then go ahead and check it off as "done" and strikethrough the text, e.g.: - [x] ~Has unit tests & system/integration tests~ -->

  • [X] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • [X] Title summarizes what is changing.
  • ~[ ] Has a news entry file (remember to thank yourself!).~
  • ~[ ] Appropriate comments and documentation strings in the code.~
  • ~[ ] Has sufficient logging.~
  • ~[ ] Has telemetry for enhancements.~
  • ~[ ] Unit tests & system/integration tests are added/updated.~
  • ~[ ] Test plan is updated as appropriate.~
  • ~[ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).~
  • ~[ ] The wiki is updated with any design decisions/details.~
+409 -53

0 comment

12 changed files

pr created time in 17 days

push eventericsnowcurrently/vscode-python

Eric Snow

commit sha afc04c9df248ad6e0ffc9a8ab8993f8782ca645b

Avoid wildcard imports.

view details

Eric Snow

commit sha d993b752000ada663440240b13e0d3f33e3817ca

Fix lint errors.

view details

Eric Snow

commit sha f09abdf59d68a3de9af8a96d8964dbe6a7e1b375

Add missing doc comments.

view details

Eric Snow

commit sha c83b8284d77c8bfbc362aa767e504060c8c2dc09

Factor out copyPythonExecInfo().

view details

push time in 17 days

create barnchericsnowcurrently/vscode-python

branch : py-envs-interpreter-info

created branch time in 17 days

push eventmicrosoft/vscode-python

Eric Snow

commit sha 5b55c599693bad5685e631e44ea5d8d8e8929a6d

Consolidate "info" under pythonEnvironments/info/. (#12383) This change is part of the series of changes related to factoring out an isolated Python environments "component" (specifically the "discovery" subcomponent). This change only moves files around.

view details

push time in 17 days

push eventericsnowcurrently/vscode-python

Rich Chiodo

commit sha 9ab353a71fcd12746cf246640f99ade31d6514e8

Infrastructure for mounting more than one webview at a time (#12382) * Beginnings of new idea * Rework all caes to use new way to fetch wrapper * Fix missed messages * Missed messages being dropped * Make role specific * More dispose fixes * Teardown is not being called if a test is skipped * Upgrade mocha and create factory for mounted web views * Fix failing functional test and make options correct * Fix unit test failures caused by new mocha

view details

Rich Chiodo

commit sha 71390fb7c0d9153445d9939854910aafb33bdc8f

Add test that validates interactive and notebook editor at the same time (#12384) * Add test to open both interactive and native at same time * Add news entry

view details

Eric Snow

commit sha 5b55c599693bad5685e631e44ea5d8d8e8929a6d

Consolidate "info" under pythonEnvironments/info/. (#12383) This change is part of the series of changes related to factoring out an isolated Python environments "component" (specifically the "discovery" subcomponent). This change only moves files around.

view details

push time in 17 days

delete branch ericsnowcurrently/vscode-python

delete branch : py-envs-common-info

delete time in 17 days

PR merged microsoft/vscode-python

Consolidate "info" under pythonEnvironments/info/. skip news

This change only moves files around, so I should only need 1 review.

<!-- If an item below does not apply to you, then go ahead and check it off as "done" and strikethrough the text, e.g.: - [x] ~Has unit tests & system/integration tests~ -->

  • [x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • [x] Title summarizes what is changing.
  • ~[ ] Has a news entry file (remember to thank yourself!).~
  • ~[ ] Appropriate comments and documentation strings in the code.~
  • ~[ ] Has sufficient logging.~
  • ~[ ] Has telemetry for enhancements.~
  • ~[ ] Unit tests & system/integration tests are added/updated.~
  • ~[ ] Test plan is updated as appropriate.~
  • ~[ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).~
  • ~[ ] The wiki is updated with any design decisions/details.~
+195 -195

1 comment

189 changed files

ericsnowcurrently

pr closed time in 17 days

push eventericsnowcurrently/cpython

Victor Stinner

commit sha fc710ee266e9461fdba9933ec6004318db588820

bpo-40993: Don't run Travis CI coverage on PRs (GH-20916) C and Python coverage jobs of Travis CI are no longer run on pull requests, only on branches like master.

view details

Victor Stinner

commit sha fcc60e40bbfe8a229b8b83f1d1ee77fd4bf870d1

bpo-40989: Make _PyTraceMalloc_NewReference() internal (GH-20915) Make the _PyTraceMalloc_NewReference() function fully internal: remove it from the public C API and don't export it anymore.

view details

Pablo Galindo

commit sha 51c5896b6205911d29ac07f167ec7f3cf1cb600d

bpo-40958: Avoid buffer overflow in the parser when indexing the current line (GH-20875)

view details

Dong-hee Na

commit sha c4862e333ab405dd5789b4061222db1982147de4

bpo-1635741: Port _gdbm module to multiphase initialization (GH-20920)

view details

Eric Snow

commit sha 818f5b597ae93411cc44e404544247d436026a00

bpo-32604: Clean up test.support.interpreters. (gh-20926) There were some minor adjustments needed and a few tests were missing. https://bugs.python.org/issue32604

view details

Eric Snow

commit sha e986543f0dba6f7952c2ddaa9e225d2c0b980aa8

Factor out struct _pending_call.

view details

Eric Snow

commit sha b23d0653e07859548e04a80e77659b617c21ca61

Switch to a linked list.

view details

Eric Snow

commit sha aeeb4941c33e07b667bec39ca75c8729548bd222

Add a NEWS entry.

view details

Eric Snow

commit sha 9f5167b12f2baadcdf86da56d35545994d7bf914

Add a section for cross-interpreter operations.

view details

Eric Snow

commit sha 9849dc02fbe1a726ffe7bd0c4ec31a83a5ef3b4c

Add _Py_DECREF_in_interpreter().

view details

Eric Snow

commit sha 1c0b35eb0e8c04b851ba60bd02af14988c1af445

Add _PyBuffer_Release_in_interpreter().

view details

Eric Snow

commit sha fbc2ba0f691252b7e28a73704cee1c2a40fa6e5e

Add _PyMem_Free_in_interpreter().

view details

Eric Snow

commit sha fc55d5cb6cb18d0883b29752898e8ad7d0115ada

Drop _call_in_interpreter().

view details

Eric Snow

commit sha 1644a7a4dfcc9cfc5049cd50fb5b6a47a81a552b

Special-case ops in the owning interpreter.

view details

Eric Snow

commit sha 7f172da0811729eaed57ac913ffae2a15cdde35e

Do not pass void* functions to _PyEval_AddPendingCall().

view details

Eric Snow

commit sha f4dc3cdb7bc43e76cd7208fcb306430f7f134068

Require the interpreter to exist in InterpreterID().

view details

Eric Snow

commit sha 5b2ec06a57f102357e86ee1320ac2d179dba3052

Fix tests (due to same-interpreter shortcut).

view details

Eric Snow

commit sha ecba9958912d26a9044fe001e6a52ad28d450c05

Update the NEWS entry.

view details

Eric Snow

commit sha b2b20a470e70e1e51c6a4cf4a6b5ab0ebf090f31

Clarify about the pending calls queue size.

view details

Eric Snow

commit sha e7dec9991938ae80a30a5731a1f8cae3f54307b1

Fix some comments.

view details

push time in 18 days

push eventericsnowcurrently/cpython

Victor Stinner

commit sha fc710ee266e9461fdba9933ec6004318db588820

bpo-40993: Don't run Travis CI coverage on PRs (GH-20916) C and Python coverage jobs of Travis CI are no longer run on pull requests, only on branches like master.

view details

Victor Stinner

commit sha fcc60e40bbfe8a229b8b83f1d1ee77fd4bf870d1

bpo-40989: Make _PyTraceMalloc_NewReference() internal (GH-20915) Make the _PyTraceMalloc_NewReference() function fully internal: remove it from the public C API and don't export it anymore.

view details

Pablo Galindo

commit sha 51c5896b6205911d29ac07f167ec7f3cf1cb600d

bpo-40958: Avoid buffer overflow in the parser when indexing the current line (GH-20875)

view details

Dong-hee Na

commit sha c4862e333ab405dd5789b4061222db1982147de4

bpo-1635741: Port _gdbm module to multiphase initialization (GH-20920)

view details

Eric Snow

commit sha 818f5b597ae93411cc44e404544247d436026a00

bpo-32604: Clean up test.support.interpreters. (gh-20926) There were some minor adjustments needed and a few tests were missing. https://bugs.python.org/issue32604

view details

push time in 18 days

delete branch ericsnowcurrently/cpython

delete branch : interpreters-fix-send-recv-tests

delete time in 18 days

push eventpython/cpython

Eric Snow

commit sha 818f5b597ae93411cc44e404544247d436026a00

bpo-32604: Clean up test.support.interpreters. (gh-20926) There were some minor adjustments needed and a few tests were missing. https://bugs.python.org/issue32604

view details

push time in 18 days

more