profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/ericsciple/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

actions/runner 2048

The Runner for GitHub Actions :rocket:

actions/checkout 1884

Action for checking out a repo

actions/setup-node 1448

Set up your GitHub Actions workflow with a specific version of node.js

actions/http-client 56

A lightweight HTTP client optimized for use with actions, TypeScript with generics and async await.

ericsciple/cache 1

Cache dependencies and build outputs in GitHub Actions

ericsciple/libuv 1

Cross-platform asynchronous I/O

ericsciple/babel 0

🐠 Babel is a compiler for writing next generation JavaScript.

ericsciple/bumblebee 0

`go fmt`–style command-line refactoring for C#

push eventericsciple/testing

eric sciple

commit sha 825eccfa5b2e674d79d53c8b53a82cf085a9d501

Update main.yml

view details

push time in 22 days

push eventericsciple/testing

eric sciple

commit sha 36d385d1959940a2d2b9e31fa01b753de3439faf

Update main.yml

view details

push time in 22 days

push eventericsciple/testing

eric sciple

commit sha 3b3a4d6a8de88f09b82dd1ead90520a1c0c9ae46

Update main.yml

view details

push time in 24 days

push eventericsciple/testing

eric sciple

commit sha 07661d47a39878d6cac9af9403539a8e0026982b

Update main.yml

view details

push time in 24 days

issue commentactions/checkout

Organization ssh url will not support submodule checkout

@bauergeorg i learned the format org-<NUMBER>@github.com: is used when ssh certificate authentication is enabled

from the git docs, it doesn't look like insteadOf supports globs/regexes. However we might be able to construct the value from the info in the GitHub event payload.

Can you add a the following step to one of your workflows and confirm whether .repository.owner.id. matches the org-<NUMBER>@github.com: value?

      - name: Dump gitub context
        env:
          GITHUB_CONTEXT: ${{ toJson(GitHub.Event) }}
        run: echo "$GITHUB_CONTEXT"
bauergeorg

comment created time in 24 days

issue commentactions/checkout

Organization ssh url will not support submodule checkout

@bauergeorg can you confirm you are not providing the input ssh-key? When not provided, the checkout action will only convert submodule URLs like git@github.com: to https://. From the docs:

    # Whether to checkout submodules: `true` to checkout submodules or `recursive` to
    # recursively checkout submodules.
    #
    # When the `ssh-key` input is not provided, SSH URLs beginning with
    # `git@github.com:` are converted to HTTPS.
    #
    # Default: false
    submodules: ''

It's strange that the clone URL in the UI is different for you. Mine are always like git@github.com. I can reach out to folks from the repos team to understand why yours are different.

bauergeorg

comment created time in 25 days

issue commentactions/runner

Error when auto-upgrading runner service on MacOS - service fails to restart after upgrade

  • We might need to treat the externals folder more like we treat the tool-cache folder (use it if it already exists).
  • Actually there might be a cheap fix... i wonder whether we could leverage readlink in the script to resolve the path of node (i.e. not the symlink path)
JohnLBergqvist

comment created time in 25 days

issue commentactions/checkout

Organization ssh url will not support submodule checkout

@bauergeorg could you clarify the following statement:

A few weeks ago github changed the ssh-clone-url from: git@github.com:my-org/my-repo.git into org-git12345678@github.com:my-org/my-repo.git.

I am not aware of anything that changed on the service. Did your checked-in submodule configuration change in your repo?

bauergeorg

comment created time in a month

PullRequestReviewEvent

Pull request review commentactions/runner

For Main Steps, just run the step, don't check condition

 private async Task RunStepsAsync(List<IStep> embeddedSteps, ActionRunStage stage                 CancellationTokenRegistration? jobCancelRegister = null;                 try                 {-                    // Register job cancellation call back only if job cancellation token not been fire before each step run-                    if (!ExecutionContext.Root.CancellationToken.IsCancellationRequested)+                    // For main steps just run the action+                    if (stage == ActionRunStage.Main)

discussed offline. When we support condition on Main in the future, we will need to register the cancel-callback. For now we don't need it.

thboop

comment created time in a month

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentactions/runner

Send path when resolving actions

 private async Task BuildActionContainerAsync(IExecutionContext executionContext,                     {                         NameWithOwner = repositoryReference.Name,                         Ref = repositoryReference.Ref,+                        Path = repositoryReference.Path,

my-org/my-repo/my-folder/my-subfolder@v1

  • NameWithOwner: my-org/my-repo
  • Ref: v1
  • Path my-folder/my-subfolder
thboop

comment created time in 2 months

PullRequestReviewEvent

Pull request review commentactions/runner

Send path when resolving actions

 private async Task BuildActionContainerAsync(IExecutionContext executionContext,                     {                         NameWithOwner = repositoryReference.Name,                         Ref = repositoryReference.Ref,+                        Path = repositoryReference.Path,

nit: consider deleting the comment on this method (line 595)

thboop

comment created time in 2 months

PullRequestReviewEvent

Pull request review commentactions/runner

Set Composite Post Step Context to the Main's step

 public interface IExecutionContext : IRunnerService         Guid Id { get; }         Guid EmbeddedId { get; }         string ScopeName { get; }+        string SiblingScopeName { get; }

consider MainScopeName ? trying to think of more names but it's hard 😞

thboop

comment created time in 2 months

PullRequestReviewEvent

Pull request review commentactions/runner

Set Context Name for Pre/Post Steps

 public void RegisterPostJobStep(IStep step)                 return;             } -            step.ExecutionContext = Root.CreatePostChild(step.DisplayName, IntraActionState);+            step.ExecutionContext = Root.CreatePostChild(step.DisplayName, IntraActionState, ContextName);

do we normally set ContextName for pre/post? can pre/post actually contribute to step outputs?

thboop

comment created time in 2 months

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentactions/runner

Set Context Name for Pre/Post Steps

 public Variables(IHostContext hostContext, IDictionary<string, VariableValue> co         public bool Retain_Default_Encoding => true; #endif -        public bool? Step_Debug => GetBoolean(Constants.Variables.Actions.StepDebug);+        public bool? Step_Debug => true;

was this for testing? did you mean to revert?

thboop

comment created time in 2 months

push eventericsciple/testing

eric sciple

commit sha a54a82b3fa268eb7f39ccc48555126f770d28e9a

Update main.yml

view details

push time in 2 months

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentactions/runner

Composite Code Cleanup

 private async Task RunStepsAsync(List<IStep> embeddedSteps)                     step.ExecutionContext.Complete(TaskResult.Failed);                 } -                await RunStepAsync(step);+                // Evaluate condition+                step.ExecutionContext.Debug($"Evaluating condition for step: '{step.DisplayName}'");

...since this feature is behind a FF anyway

thboop

comment created time in 2 months

PullRequestReviewEvent

Pull request review commentactions/runner

Composite Code Cleanup

 private async Task RunStepsAsync(List<IStep> embeddedSteps)                     step.ExecutionContext.Complete(TaskResult.Failed);                 } -                await RunStepAsync(step);+                // Evaluate condition+                step.ExecutionContext.Debug($"Evaluating condition for step: '{step.DisplayName}'");

if this PR is incrementally correct, you might want to figure out the callback thing in a future PR

thboop

comment created time in 2 months