profile
viewpoint
Eric Lewis ericandrewlewis Software Engineer @google New York, NY http://www.ericandrewlewis.com

PR opened ampproject/amphtml

:bug: Send layout jank metrics more proactively.

This metric is now sent when the viewer visibility state changes to inactive, rather than just on document end of lifecycle.

Fixes #22781

+42 -0

0 comment

2 changed files

pr created time in 15 days

create barnchericandrewlewis/amphtml

branch : 22

created branch time in 15 days

create barnchericandrewlewis/amphtml

branch : 22781

created branch time in 15 days

issue openedampproject/amphtml

Improve reporting of layout jank reporting

What's the issue?

Layout jank is a performance metric which we started emitting to AMP viewers in https://github.com/ampproject/amphtml/pull/21060.

This implementation sends the layout jank metric on page exit, which we detect using the Page Lifecycle API.

We found a bug in our own implementation of the viewer, because the closing of communication with the viewer frame was disposed before the iframe itself was disposed. We fixed this bug, and in our post-mortem discussion considered that the AMP viewer is aware of its own definition of visibility state. We could have the viewer proactively report layout jank when the viewer goes into the inactive state.

created time in 15 days

issue openedampproject/amp-by-example

amp-next-page playground example does not load next page

The amp-next-page playground example does not load the next page.

I see errors in my JavaScript console:

Experiment amp-next-page disabled
qd @ cdn.ampproject.org/v0/amp-next-page-0.1.js:70
log.js:343 Uncaught (in promise) Resource: failed to build: amp-next-page#1: Experiment amp-next-page disabled

created time in a month

issue openedaltair-viz/altair

How to set the axis bounds of a LayerChart?

Howdy :wave: this is my first issue on this repository. Thank you for building altair, I quite like it!

I have created a LayerChart:

import scipy
import numpy
import altair as alt
import pandas as pd

data = pd.DataFrame({
  'a': [1,4,67,53,33], 
  'b': [2,6,84,28,34],
  'c': ['a', 'd', 'f', 'g', 'e']
})

scatterplot = alt.Chart(data).mark_circle().encode(
  x='a',
  y='b',
  tooltip=['a', 'b', 'c']
).interactive()

scatterplot

data_b = pd.DataFrame({
  'x': [19,54,7,33,31], 
  'y': [42,66,4,58,54],
  'z': ['a', 'd', 'f', 'g', 'e']
})

line_chart = alt.Chart(data_b).mark_line().encode(
  x='x',
  y='y'
)
combined_chart = scatterplot + line_chart

combined_chart

And I'm wondering, how can I set the axis bounds? I think I'd like to set them to be "limits of the data set + a constant value," but being able to set an explicit domain would also be fine.

I've tried setting the bounds via an alt.Scale in one of the charts:

scatterplot = alt.Chart(data).mark_circle().encode(
  alt.X('a',
      scale=alt.Scale(domain=(-50,400))
  ),
  alt.Y('b',
      scale=alt.Scale(domain=(-50,1100))
  ),
)

But this configuration is discarded when combining the two charts together.

created time in 2 months

issue openedlydell/source-map-visualize

spawn E2BIG error

Hi, thanks for building this! I'm excited to use it.

I get an error when I attempt to run it against a medium large sized project:

$ ./source-map-visualize ../v0.js.br
internal/child_process.js:366
    throw errnoException(err, 'spawn');
    ^

Error: spawn E2BIG
    at ChildProcess.spawn (internal/child_process.js:366:11)
    at Object.spawn (child_process.js:538:9)
    at Object.module.exports [as open] (/usr/local/google/home/ericnyc/Desktop/source-map-visualize/node_modules/opn/index.js:75:24)
    at /usr/local/google/home/ericnyc/Desktop/source-map-visualize/cli.js:100:11
    at /usr/local/google/home/ericnyc/Desktop/source-map-visualize/index.js:40:9
    at /usr/local/google/home/ericnyc/Desktop/source-map-visualize/node_modules/source-map-resolve/lib/source-map-resolve-node.js:263:7
    at done (/usr/local/google/home/ericnyc/Desktop/source-map-visualize/node_modules/source-map-resolve/lib/source-map-resolve-node.js:137:7)
    at ReadFileContext.callback (/usr/local/google/home/ericnyc/Desktop/source-map-visualize/node_modules/source-map-resolve/lib/source-map-resolve-node.js:150:9)
    at FSReqWrap.readFileAfterOpen [as oncomplete] (fs.js:238:13)

Googling around tells me that this has to do with the size of the arguments passed to a child process, so I should note that my ARG_MAX is set to 2097152.

created time in 3 months

PR opened slightlyoff/never_slow_mode

Typo fix
+1 -1

0 comment

1 changed file

pr created time in 3 months

push eventericandrewlewis/never_slow_mode

Eric Lewis

commit sha 764bb80371bf69f204e0321ddc684b32ca85dab3

Typo fix

view details

push time in 3 months

fork ericandrewlewis/never_slow_mode

Never-Slow Mode (a.k.a. Slightly-Fast Mode)

fork in 3 months

more