profile
viewpoint
Florian Enner ennerf HEBI Robotics Salzburg, Austria https://ennerf.github.io/ Software Engineer, Co-Founder of HEBI Robotics

ennerf/HdrHistogramVisualizer 37

Visualizer for HdrHistogram and JHiccup logs

HebiRobotics/MFL 30

A Java library for reading and writing MATLAB's MAT File format

HebiRobotics/QuickBuffers 12

Protobuf 2 library suitable for real-time enviroments

ennerf/mvn-repo-sources 2

Project sources corresponding to mvn-repo.

ennerf/mvn-repo 1

Maven repository for useful open source projects that are not in central yet.

ennerf/B2E 0

Bat To Exe Converter can convert BAT (.bat) script files to the EXE (.exe) format.

ennerf/ejml 0

A fast and easy to use linear algebra library written in Java for dense, sparse, real, and complex matrices.

ennerf/ennerf.github.io 0

A web application to build your blog on GitHub

ennerf/jzy3d-api 0

A Java API for 3d charts

issue commentLMAX-Exchange/disruptor

Take a long hard look at the benchmarks and make them JMH

Since #314 we now have JMH benchmarks in the code. Need to add more and consider where we can find a stable environment to run them and record results.

Palmr

comment created time in 10 minutes

issue commentLMAX-Exchange/disruptor

The examples are not all runnable or documented

I have moved the examples to their own sourceset as of #333 given they were not tests so don't really live in the tests sourceset.

Palmr

comment created time in 11 minutes

issue openedLMAX-Exchange/disruptor

Take a long hard look at the benchmarks and make them JMH

There are many classes and tests under the "perf" sourceset. Not sure what all of these do, if they're relevant etc.

There is currently no way to track performance of the Disruptor in CI. Using some standard tools like JMH we can write benchmarks which output results in a standard way for tracking & display.

created time in 15 minutes

push eventLMAX-Exchange/disruptor

Nick Palmer

commit sha 856af3e5091177f954f4f174ea14ff05b1fda13a

Move examples out of test into their own source set

view details

Simon Warren

commit sha db55bb2f40131f327383983631c5f6ee436f793c

Merge pull request #333 from Palmr/examples Move examples out of test into their own source set

view details

github-action

commit sha 8446f2fc57cafeb76b4428a32219413a8ac94f84

Simple GitHub Pages Deploy Action

view details

push time in 17 minutes

issue openedLMAX-Exchange/disruptor

The examples are not all runnable or documented

We should take a look at all the existing samples and see if they make sense, document them better and make sure they're using modern syntax.

created time in 17 minutes

push eventLMAX-Exchange/disruptor

Nick Palmer

commit sha 856af3e5091177f954f4f174ea14ff05b1fda13a

Move examples out of test into their own source set

view details

Simon Warren

commit sha db55bb2f40131f327383983631c5f6ee436f793c

Merge pull request #333 from Palmr/examples Move examples out of test into their own source set

view details

push time in 18 minutes

PR opened LMAX-Exchange/disruptor

Reviewers
Move examples out of test into their own source set
+336 -239

0 comment

19 changed files

pr created time in 20 minutes

GollumEvent

push eventGSI-CS-CO/chart-fx

Alexander Krimm

commit sha 20ae7075014dcf17c609dbc1c0ab05b0029edcd8

Correct automatic module names Module names should not contain hyphens, so we cannot reuse our artifact names. Instead introduce a new property which will be set in each module. fixes #321

view details

push time in 2 hours

delete branch GSI-CS-CO/chart-fx

delete branch : fixAutoModuleName

delete time in 2 hours

PR merged GSI-CS-CO/chart-fx

Correct automatic module names

Module names should not contain hyphens, so we cannot reuse our artifact names. Instead introduce a new property which will be set in each module.

fixes #321

+22 -1

1 comment

8 changed files

wirew0rm

pr closed time in 2 hours

issue closedGSI-CS-CO/chart-fx

Hyphen module name breaks module based projects

As per the JSE 9+ specs;

https://docs.oracle.com/javase/specs/jls/se9/html/jls-7.html#jls-ModuleDeclaration https://docs.oracle.com/javase/specs/jls/se9/html/jls-3.html#jls-3.8

A module/package identifier, within the module descriptor(module-info.java) needs to be an alphanumeric string. The suggested workaround for module based projects is to use a period in place of the hyphen, for the "Automatic-Module-Name" in the manifest as such:

Automatic-Module-Name: de.gsi.chart.chartfx.chart

Further info on module resolution:

https://docs.oracle.com/javase/9/docs/api/java/lang/module/ModuleFinder.html

Love your work.

closed time in 2 hours

qballed

pull request commentGSI-CS-CO/chart-fx

Correct automatic module names

Codecov Report

Merging #323 (ae9e489) into master (a36e779) will decrease coverage by 0.00%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #323      +/-   ##
============================================
- Coverage     51.59%   51.58%   -0.01%     
+ Complexity     7266     7265       -1     
============================================
  Files           393      393              
  Lines         41072    41072              
  Branches       6611     6611              
============================================
- Hits          21191    21189       -2     
- Misses        18375    18376       +1     
- Partials       1506     1507       +1     
Impacted Files Coverage Δ Complexity Δ
.../main/java/de/gsi/chart/axes/spi/AbstractAxis.java 76.41% <0.00%> (-0.30%) 183.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a36e779...ae9e489. Read the comment docs.

wirew0rm

comment created time in 3 hours

push eventGSI-CS-CO/chart-fx

rstein

commit sha 6c2d39b46f9558c89c927e358f3759946b2d362c

moved EventStore and Filter concepts from test to main - WIP further refactoring needed

view details

push time in 3 hours

create barnchGSI-CS-CO/chart-fx

branch : OpenCMW

created branch time in 3 hours

push eventGSI-CS-CO/chart-fx

Ralph J. Steinhagen

commit sha 2fbf0720b52f45ac7c729c4bc730f195b04b18fe

updated OpenCMW protocol definition + frame concept (#322)

view details

push time in 4 hours

delete branch GSI-CS-CO/chart-fx

delete branch : OpenCMW

delete time in 4 hours

pull request commentGSI-CS-CO/chart-fx

updated OpenCMW protocol definition + frame concept

Codecov Report

Merging #322 (588c184) into master (a36e779) will increase coverage by 0.00%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #322   +/-   ##
=========================================
  Coverage     51.59%   51.60%           
- Complexity     7266     7269    +3     
=========================================
  Files           393      393           
  Lines         41072    41072           
  Branches       6611     6611           
=========================================
+ Hits          21191    21194    +3     
  Misses        18375    18375           
+ Partials       1506     1503    -3     
Impacted Files Coverage Δ Complexity Δ
...hart/plugins/measurements/DataSetMeasurements.java 75.77% <0.00%> (+0.34%) 153.00% <0.00%> (+2.00%)
...main/java/de/gsi/chart/ui/HiddenSidesPaneSkin.java 44.97% <0.00%> (+0.47%) 35.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a36e779...588c184. Read the comment docs.

RalphSteinhagen

comment created time in 4 hours

issue commentGSI-CS-CO/chart-fx

Hyphen module name breaks module based projects

Thanks for the clarification, prepared a pull request which will be merged as soon as CI passes.

qballed

comment created time in 4 hours

PR opened GSI-CS-CO/chart-fx

Correct automatic module names

Module names should not contain hyphens, so we cannot reuse our artifact names. Instead introduce a new property which will be set in each module.

fixes #321

+22 -1

0 comment

8 changed files

pr created time in 4 hours

create barnchGSI-CS-CO/chart-fx

branch : fixAutoModuleName

created branch time in 4 hours

issue commentGSI-CS-CO/chart-fx

Hyphen module name breaks module based projects

Dependent applications wont compile so it's more than just a spec violation. This is the following javac error on both Oracle 11.0.7 and OpenJDK-11.0.3.

error: cannot access module-info cannot resolve modules

Amending the manifest as per above works fine.

qballed

comment created time in 4 hours

push eventGSI-CS-CO/chart-fx

rstein

commit sha 588c184fd713fac711667397f251fe0b41e75cc2

updated OpenCMW protocol definition + frame concept

view details

push time in 4 hours

issue commentGSI-CS-CO/chart-fx

Hyphen module name breaks module based projects

Thank you for the report, we just reused our artifact id's without giving it enough thought.

As we do not have any modularized applications using chartfx: is this "just" a spec violation or does this actually stop you from using this in your module-info.java? Should be fixed anyway of course, but if users could already be using the current non-conforming module name, we should communicate this differently.

qballed

comment created time in 5 hours

PR opened GSI-CS-CO/chart-fx

updated OpenCMW protocol definition + frame concept
+273 -0

0 comment

4 changed files

pr created time in 5 hours

create barnchGSI-CS-CO/chart-fx

branch : OpenCMW

created branch time in 5 hours

issue openedGSI-CS-CO/chart-fx

Hyphen module name breaks module based projects

As per the JSE 9+ specs;

https://docs.oracle.com/javase/specs/jls/se9/html/jls-7.html#jls-ModuleDeclaration https://docs.oracle.com/javase/specs/jls/se9/html/jls-3.html#jls-3.8

A module/package identifier, within the module descriptor(module-info.java) needs to be an alphanumeric string. The suggested workaround for module based projects is to use a period in place of the hyphen, for the "Automatic-Module-Name" in the manifest as such:

Automatic-Module-Name: de.gsi.chart.chartfx.chart

Further info on module resolution:

https://docs.oracle.com/javase/9/docs/api/java/lang/module/ModuleFinder.html

Love your work.

created time in 6 hours

issue commentGSI-CS-CO/chart-fx

Chart subplots with bidirectional binding of xaxis

Thanks Alexander, I will try tests, and maybe it is not problem and AxisSynchronizer + hidden empty labels/invisible ticks will be accurate. In any cases, I have to create some separate "better" slider which will be placed under all plots. I found the problem that actual slider has very "very very" small for longer history, so it cannot be move, because second slider feature for extending range is activate instead of movement feature.

raven2cz

comment created time in 6 hours

issue commentGSI-CS-CO/chart-fx

Chart subplots with bidirectional binding of xaxis

Hey,

yes, you are right, we do not really have extensive support for subplots.

Here is what is currently available and what we use in our applications:

  • de.gsi.chart.utils.AxisSynchronizerbidirectional synchronisation of the axis range between two plots, as used in the sample you mentioned.
  • Currently it is not possible to hide the axis, so you would have to set empty labels and invisible tick marks. The axes needs to be there because the coordinates are computed based on the layout of the axis. I already thought about implementing a blank axis without any marks and labels for such usecases, which should be pretty straightforward.
  • For stacking charts there is the problem of different axis width for the y axis, so you would have to make sure to set a sufficient and equal width to all of them (or do some complex bindings without creating an infinite loop).

To help with these layout questions we have the ChartAnatomySample, to show the different components: chartAnatomy

Correctly implementing subplots would be a major undertaking and would probably break existing apps. Additionally we would have to think about how plugins (zoomer, tooltip, parameter measurements, indicators) should handle this, the mechanics for updating axes shared between different (sub)charts, etc. (I recently extended the Indicators to correctly handle multiple axes in a single chart, even that case is not so simple.) It is definitely interesting and useful functionality, but its not high enough priority for us at the moment compared to the amount of work it would need to properly implement.

I'll leave this feature request open to collect workarounds and implementation details for a potential future implementation.

raven2cz

comment created time in 8 hours

more