profile
viewpoint

carbon-design-system/carbon-components-react 1062

React components for the Carbon Design System

emyarod/bobby 3

OH YOU AINT KNOW?

emyarod/advent 0

advent of code

emyarod/ahk-scripts 0

A collection of AutoHotkey_L scripts

emyarod/all_leetcode_questions 0

All Leetcode questions in a single file

emyarod/atom-material-syntax-dark 0

A darker syntax theme for Atom that uses Google's Material Design color palette

emyarod/awesome-cheatsheets 0

📚 Awesome cheatsheets for popular programming languages, frameworks and development tools. They include everything you should know in one single file.

pull request commentcarbon-design-system/carbon

fix(DatePicker): add more locales to valid locales

Hello there, in our locales we also have kk, nb, pt-br, zh-cn, and zh-tw. I see zh-tw has been added. I'm checking if we map zh-cn to zh. And I'm checking into the others as well, but as they don't show in flatpickr I'm not sure what we'll do if they are languages we still support.

tw15egan

comment created time in 44 minutes

pull request commentcarbon-design-system/carbon

feat: add textDir property to FormLabel

Deploy preview for carbon-components-react failed.

Built without sensitive environment variables with commit 7c56064c967f261aa663c16943f5d1cc40793925

https://app.netlify.com/sites/carbon-components-react/deploys/6012b5d48413c300077f27dd

wajnberg

comment created time in an hour

pull request commentcarbon-design-system/carbon

feat: add textDir property to FormLabel

Deploy preview for carbon-elements ready!

Built with commit 7c56064c967f261aa663c16943f5d1cc40793925

https://deploy-preview-7683--carbon-elements.netlify.app

wajnberg

comment created time in 2 hours

pull request commentcarbon-design-system/carbon

feat: add textDir property to FormLabel

@sadir@il.ibm.com. FYI

wajnberg

comment created time in 2 hours

PR opened carbon-design-system/carbon

feat: add textDir property to FormLabel

Closes #7264

Add the textDir property for FormLabel. This is just a sample. This property should be applied to all relevant react components

Changelog

New bidiUtils

Changed

FormLabel

Testing / Reviewing

Add the new story WithTextDir in the FormLabel stroy

+125 -4

0 comment

3 changed files

pr created time in 2 hours

issue commentcarbon-design-system/carbon

carbon-components-react/es/components/UIShell/HeaderGlobalAction.js does not export 'default'

It looks like this is an issue with React lazy. At least, that seemed to fix it when we didn't use it.

rscoates

comment created time in 2 hours

issue openedcarbon-design-system/carbon

Modal with long selectable data-table in modal body : selecting a row causes modal to content overflow

What package(s) are you using?

  • [x] @console/pal v1.337.5

Detailed description

Creating a modal with a table inside with selectable rows . if you have a lot of selectable rows selecting the last row will cause the content to overflow outside of the modal. causing a blank modal content

Steps to reproduce the issue

  • create a modal with long table content with selectable rows
  • scroll to the last element
  • select last element
  • content disappears

sandbnox replication of the issue : https://codesandbox.io/s/dark-bush-dedz7?file=/index.js

Additional information

image

created time in 2 hours

PR opened emyarod/carbon

chore(deps): bump @storybook/addon-storysource from 5.3.19 to 6.1.15

Bumps @storybook/addon-storysource from 5.3.19 to 6.1.15. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/storybookjs/storybook/releases"><code>@storybook/addon-storysource's releases</code></a>.</em></p> <blockquote> <h2>v6.1.15</h2> <h3>Bug Fixes</h3> <ul> <li>Svelte: Fix duplicate story preview (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/13663">#13663</a>)</li> <li>Angular: Properly handle empty tsconfig compilerOptions (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/13596">#13596</a>)</li> </ul> <h3>Maintenance</h3> <ul> <li>Angular: Use Nx function to read non-angularCli configs (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/13558">#13558</a>)</li> </ul> <h3>Dependency Upgrades</h3> <ul> <li>Bump @types/reach__router version (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/13703">#13703</a>)</li> </ul> <h2>v6.1.14</h2> <h3>Bug Fixes</h3> <ul> <li>Core: Use fs-extra emptyDir so build works on docker volume (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/13474">#13474</a>)</li> <li>Addon-docs: Tighten preset webpack pattern for mdx stories (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/13476">#13476</a>)</li> <li>Typescript: Fix qs import in @storybook/client-api (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/13518">#13518</a>)</li> <li>CLI: Ensure --host option changes the network host (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/13521">#13521</a>)</li> <li>Svelte: Statically load docgen info for svelte components (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/13466">#13466</a>)</li> </ul> <h2>v6.1.12</h2> <h3>Bug Fixes</h3> <ul> <li>Addon-docs: Fix link not working cross origin (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/13022">#13022</a>)</li> <li>Addon-docs: Resolve babel-loader from storybook/core (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/13607">#13607</a>)</li> </ul> <h2>v6.1.11</h2> <h3>Bug Fixes</h3> <ul> <li>UI: Fix null ref in sidebar (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/13423">#13423</a>)</li> <li>Addon-docs: Handle svelte docgen failures gracefully (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/13386">#13386</a>)</li> </ul> <h3>Dependency Upgrades</h3> <ul> <li>Update react-popper-tooltip and @popperjs/core for react17 (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/13434">#13434</a>)</li> </ul> <h2>v6.1.10</h2> <h3>Bug Fixes</h3> <ul> <li>CLI: Fix stories path in Introduction.stories.mdx (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/13368">#13368</a>)</li> <li>UI: Fix display of custom brand image (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/13355">#13355</a>)</li> <li>Storyshots: Fix missing <code>done</code> attribute on type definition (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/13341">#13341</a>)</li> <li>Addon-docs: ArgTypes optional on Meta (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/13352">#13352</a>)</li> </ul> <h3>Dependency Upgrades</h3> <ul> <li>Addon-storyshots: Add React as peer dependency (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/13343">#13343</a>)</li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md"><code>@storybook/addon-storysource's changelog</code></a>.</em></p> <blockquote> <h2>6.1.15 (January 22, 2021)</h2> <h3>Bug Fixes</h3> <ul> <li>Svelte: Fix duplicate story preview (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/13663">#13663</a>)</li> <li>Angular: Properly handle empty tsconfig compilerOptions (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/13596">#13596</a>)</li> </ul> <h3>Maintenance</h3> <ul> <li>Angular: Use Nx function to read non-angularCli configs (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/13558">#13558</a>)</li> </ul> <h3>Dependency Upgrades</h3> <ul> <li>Bump @types/reach__router version (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/13703">#13703</a>)</li> </ul> <h2>6.2.0-alpha.18 (January 22, 2021)</h2> <h3>Bug Fixes</h3> <ul> <li>Svelte: Fix duplicate story preview (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/13663">#13663</a>)</li> </ul> <h3>Maintenance</h3> <ul> <li>Angular: Add Angular 11.1 support (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/13704">#13704</a>)</li> </ul> <h3>Dependency Upgrades</h3> <ul> <li>Bump @types/reach__router version (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/13703">#13703</a>)</li> </ul> <h2>6.2.0-alpha.17 (January 22, 2021)</h2> <h3>Features</h3> <ul> <li>Addon-docs/Svelte: Add dynamic snippet support (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/13653">#13653</a>)</li> <li>Addon-docs/Svelte: Add Slots and Events to the generated ArgsTable (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/13660">#13660</a>)</li> </ul> <h3>Bug Fixes</h3> <ul> <li>Angular: Force re-render if template change (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/13638">#13638</a>)</li> <li>Angular: Properly handle empty tsconfig compilerOptions (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/13596">#13596</a>)</li> </ul> <h3>Maintenance</h3> <ul> <li>Core: Deprecate default postcss config, recommend addon-postcss (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/13669">#13669</a>)</li> <li>Core: Throw an error for invalid story format (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/13673">#13673</a>)</li> <li>Build: Ensure consistency of Chromatic snapshots of Zoom stories (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/13676">#13676</a>)</li> </ul> <h3>Dependency Upgrades</h3> <ul> <li>Dependencies: Swap back to upstream postcss-loader (<a href="https://github-redirect.dependabot.com/storybookjs/storybook/pull/13698">#13698</a>)</li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/storybookjs/storybook/commit/ecd471c96b1ef2e8f8b7a07a137f391bb445bda9"><code>ecd471c</code></a> v6.1.15</li> <li><a href="https://github.com/storybookjs/storybook/commit/fcfbceb9986570d045a1a1e20a132c5a6306eead"><code>fcfbceb</code></a> Update git head to 6.1.14</li> <li><a href="https://github.com/storybookjs/storybook/commit/0ac0ec9ee30df2cb78de2178fda66f37a3c75081"><code>0ac0ec9</code></a> v6.1.14</li> <li><a href="https://github.com/storybookjs/storybook/commit/cfd6a3bd15ffa8c7edfcfb9ecae336ba4e524f32"><code>cfd6a3b</code></a> v6.1.13</li> <li><a href="https://github.com/storybookjs/storybook/commit/b90aa708aa4573c774f8a06018cf788919afdfe9"><code>b90aa70</code></a> Update git head to 6.1.12</li> <li><a href="https://github.com/storybookjs/storybook/commit/9c114af32618d516ae9e6f73700fbb79273c95e2"><code>9c114af</code></a> v6.1.12</li> <li><a href="https://github.com/storybookjs/storybook/commit/f4d658ff9ba54c017edafb8eb463503a94056e19"><code>f4d658f</code></a> Merge branch 'next' into perf/esm-dist</li> <li><a href="https://github.com/storybookjs/storybook/commit/775b8fa599fdfa76824167b8af0621983949eead"><code>775b8fa</code></a> Update git head to 6.1.11</li> <li><a href="https://github.com/storybookjs/storybook/commit/5999b789d796414997c21d74517f7dfede6ddeff"><code>5999b78</code></a> v6.1.11</li> <li><a href="https://github.com/storybookjs/storybook/commit/56728e9ebbb8e5a91e723901fa6f3d47d1a5d50e"><code>56728e9</code></a> Update git head to 6.1.10</li> <li>Additional commits viewable in <a href="https://github.com/storybookjs/storybook/commits/v6.1.15/addons/storysource">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

+2 -2

0 comment

2 changed files

pr created time in 7 hours

issue commentcarbon-design-system/carbon

Default focus is not set to token

I think this we'd have to dive deeper into this if this is something worth changing as TJ noted we do have custom border/box-shadows. If we remove outline to those anyway wouldn't a global outline only affect those components that have outline anyway.

@tw15egan

DusanMilko

comment created time in 8 hours

Pull request review commentcarbon-design-system/carbon

chore(contributors): update all contributor list

       "contributions": [         "code"       ]+    },+    {+      "login": "scottdickerson",+      "name": "Scott Dickerson",+      "avatar_url": "https://avatars.githubusercontent.com/u/6663002?v=4",+      "profile": "https://github.com/scottdickerson",+      "contributions": [+        "code"+      ]+    },+    {+      "login": "epodgaetskiy",+      "name": "Evgeniy Podgaetskiy",+      "avatar_url": "https://avatars.githubusercontent.com/u/15031623?v=4",+      "profile": "https://start.reactwarriors.com/join",+      "contributions": [+        "code"+      ]+    },+    {+      "login": "CassidyJensen",+      "name": "CassidyJensen",+      "avatar_url": "https://avatars.githubusercontent.com/u/45407808?v=4",+      "profile": "https://github.com/CassidyJensen",+      "contributions": [+        "code",+        "a11y"+      ]+    },+    {+      "login": "lattmann",+      "name": "Zsolt Lattmann",+      "avatar_url": "https://avatars.githubusercontent.com/u/1108945?v=4",+      "profile": "https://github.com/lattmann",+      "contributions": [+        "code"+      ]+    },+    {+      "login": "ConradSchmidt",+      "name": "Conrad Schmidt",+      "avatar_url": "https://avatars.githubusercontent.com/u/3808948?v=4",+      "profile": "https://conrad.codes/",+      "contributions": [+        "code"+      ]+    },+    {+      "login": "IgnacioBecerra",+      "name": "Ignacio Becerra",+      "avatar_url": "https://avatars.githubusercontent.com/u/24970122?v=4",+      "profile": "https://github.com/IgnacioBecerra",+      "contributions": [+        "code"+      ]+    },+    {+      "login": "swapnilpatil21",+      "name": "Swapnil Patil",+      "avatar_url": "https://avatars.githubusercontent.com/u/46713873?v=4",+      "profile": "https://github.com/swapnilpatil21",+      "contributions": [+        "doc"+      ]+    },+    {+      "login": "sophiiae",+      "name": "Fei Z",+      "avatar_url": "https://avatars.githubusercontent.com/u/18622886?v=4",+      "profile": "https://github.com/sophiiae",+      "contributions": [+        "code"+      ]+    },+    {+      "login": "IgnasA",+      "name": "Ignas Ausiejus",+      "avatar_url": "https://avatars.githubusercontent.com/u/7099068?v=4",+      "profile": "https://github.com/IgnasA",+      "contributions": [+        "doc"+      ]+    },+    {+      "login": "ryanomackey",+      "name": "Ryan O. Mackey",+      "avatar_url": "https://avatars.githubusercontent.com/u/17710824?v=4",+      "profile": "https://ryanomackey.com/",+      "contributions": [+        "code"+      ]+    },+    {+      "login": "skateman",+      "name": "Halász Dávid",
      "name": "Dávid Halász",
tw15egan

comment created time in 9 hours

issue commentcarbon-design-system/carbon

OrderedList - position of numbers in the ordered list

I don't understand this item is tagged with, ( status: waiting on author's response ) Daynssjal explained thoroughly the issue.

This item can be closed. We have built our own fix.

Daynssjal

comment created time in 11 hours

pull request commentcarbon-design-system/carbon-website

docs: update steering committee info

I think you can rock this. @jeanservaas

alisonjoseph

comment created time in 14 hours

issue openedcarbon-design-system/carbon-website

bug[live demo component]: remove field label from above dropdown

regression[live demo component]: remove field label from above dropdown

I'm assuming this is a regression of some kind. That field label was never in the spec and it wasn't in the approved merge either. We need to remove it please.

image

created time in 14 hours

pull request commentcarbon-design-system/carbon

chore(contributors): update all contributor list

Deploy preview for carbon-components-react ready!

Built with commit f48afc3b466d237cc6ca9932688f15194691b035

https://deploy-preview-7681--carbon-components-react.netlify.app

tw15egan

comment created time in 14 hours

pull request commentcarbon-design-system/carbon

chore(contributors): update all contributor list

Deploy preview for carbon-elements ready!

Built with commit f48afc3b466d237cc6ca9932688f15194691b035

https://deploy-preview-7681--carbon-elements.netlify.app

tw15egan

comment created time in 14 hours

pull request commentcarbon-design-system/carbon

Update TooltipDefinition.js

@harshitshah436 can you open a ticket for this issue and link it in this PR. we need to triage and verify this problem for ourselves. In the issue template you'll find a link to a Codepen where you can recreate so we can verify and then we can move forward here.

harshitshah436

comment created time in 14 hours

PR opened carbon-design-system/carbon

chore(contributors): update all contributor list

Adds in some newer contributors to our list

Big thanks to @scottdickerson, @epodgaetskiy, @CassidyJensen, @lattmann, @ConradSchmidt, @IgnacioBecerra, @swapnilpatil21, @sophiiae, @moczolaszlo, @IgnasA, @ryanomackey, and @skateman for your contributions and for helping make Carbon better for everyone! ❤️

+113 -0

0 comment

2 changed files

pr created time in 15 hours

issue commentcarbon-design-system/carbon

Tag: when a Tag is actionable(has an onClick), the pointer icon does not change

This also goes hand in hand with https://github.com/carbon-design-system/carbon/issues/7160, as click events are passed directly to the Tag through the ...other props.

guigueb

comment created time in 15 hours

Pull request review commentcarbon-design-system/carbon

fix(Tag): update filter tags to match updated spec

   .#{$prefix}--tag__close-icon:focus {     border-radius: 50%;     outline: none;-    box-shadow: inset 0 0 0 2px $focus;+    box-shadow: inset 0 0 0 1px $focus;

Yeah just wasn't sure if it was intentional or not, just wanted to bring it up 👍

emyarod

comment created time in 16 hours

pull request commentcarbon-design-system/carbon-website

chore(package): Update gatsby-theme-carbon to latest

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carbon-design-system/carbondesignsystem/el2bjpwza
✅ Preview: In Progress

tw15egan

comment created time in 16 hours

PR opened carbon-design-system/carbon-website

chore(package): Update gatsby-theme-carbon to latest

Closes https://github.com/carbon-design-system/carbon-website/issues/2058

Updates to the latest Carbon Gatsby theme, which fixes an issue with the 404 pages

Changelog

Changed

  • Updates gatsby-theme-carbon from 1.27.2 to 1.27.3
+873 -382

0 comment

2 changed files

pr created time in 16 hours

issue closedcarbon-design-system/carbon

Lists are not left aligned

<!-- Feel free to remove sections that aren't relevant.

Title line template: [Title]: Brief description

-->

What package(s) are you using?

<!-- Add an x in one of the options below, for example:

  • [x] package name -->

  • [X] carbon-components

  • [X] carbon-components-react

Detailed description

Describe in detail the issue you're having.

Ordered and Unordered lists have bullets/numbers which stick out to the left so they do nont align well with other content.

Is this issue related to a specific component?

OrderedList and UnorderedList

What did you expect to happen? What happened instead? What would you like to see changed?

According to carbon designers the lists should be left aligned so that the bullets/numbers line up with other content and do not stick out to the left.

What browser are you working in?

All

What version of the Carbon Design System are you using?

carbon: 10.9.3 carbon-components-react: 7.9.3

What offering/product do you work on? Any pressing ship or release dates we should be aware of?

Steps to reproduce the issue

  1. Create a page with an OrderedList and/or UnorderedList that also has some content above/below the list
  2. See that the list bullets/numbers do not align properly

Additional information

  • Screenshots or code
  • Notes

closed time in 16 hours

snrubnomis

issue commentcarbon-design-system/carbon

Lists are not left aligned

Closing this since this seems to be working as intended by design

snrubnomis

comment created time in 16 hours

push eventcarbon-design-system/carbon

TJ Egan

commit sha 96aa677d342353c01936b98477d287c84aa5d948

fix(ComposedModal): add accessible name and aria-label prop (#7609) * fix(ComposedModal): add accessible name and aria-label prop * chore(tests): update snapshots * fix(ComposedModal): generate aria-label only if one is not provided Co-authored-by: Andrea N. Cardona <andreancardona@gmail.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

view details

push time in 16 hours

PR merged carbon-design-system/carbon

fix(ComposedModal): add accessible name and aria-label prop status: ready to merge 🎉

Closes https://github.com/carbon-design-system/carbon/issues/6543

Fixes a11y issues with ComposedModal

Changelog

New

  • ariaLabel prop for ComposedModal
  • aria-modal attribute added

Changed

  • ModalHeader now uses h2 and h3 instead of p elements

Testing / Reviewing

Ensure there are no a11y violations with Composed Modal

+21 -3

4 comments

3 changed files

tw15egan

pr closed time in 16 hours

issue closedcarbon-design-system/carbon

Carbon Compose Modal accessibility violation

Detailed description

experiencing same/similar issue that was in ticket https://github.com/carbon-design-system/carbon/issues/4587. An interactive element/widget must have an accessible name. violation is thrown on top level of compose modal component. can be seen in both sample application below and in story book here https://react.carbondesignsystem.com/?path=/story/composedmodal--example-usage-with-trigger-button

What version of the Carbon Design System are you using?

  • versions, also found in codesandbox: "carbon-components": "10.16.0", "carbon-components-react": "7.16.0", "carbon-icons": "7.0.7", "react": "16.3.1", "react-dom": "16.3.1",

What did you expect to happen?

  • no accessibility violations

What WCAG 2.1 checkpoint does the issue violate?

https://aat.w3ibm.mybluemix.net/token/4950d599-abf0-4c72-b249-9eed7e3bf02e/82ec2f72-e53b-4c22-98b3-faab6bd311db/archives/2020JanDeploy//doc/w3/help/en-US/idhi_accessibility_check_g1156.html

Please create a reduced test case in CodeSandbox https://codesandbox.io/s/carbon-components-react-du1ip?file=/src/index.js

Additional information

Screen Shot 2020-07-24 at 9 21 44 AM

closed time in 16 hours

bryan-pegg23

Pull request review commentcarbon-design-system/carbon

fix(Tag): update filter tags to match updated spec

   }    .#{$prefix}--tag__close-icon {+    display: flex;     flex-shrink: 0;-    width: rem(16px);-    height: rem(16px);-    margin: 0 0 0 rem(4px);+    align-items: center;+    justify-content: center;+    width: rem(24px);+    height: rem(24px);+    margin: 0 0 0 rem(2px);

Can we add in our transition variables here?

transition: background-color $duration--fast-01 motion(standard, productive),
      box-shadow $duration--fast-01 motion(standard, productive);
emyarod

comment created time in 16 hours

pull request commentcarbon-design-system/carbon

fix(TextInput): fixes hover, focus issues with visibility icon

Deploy preview for carbon-components-react ready!

Built with commit f8c05fa16a8e79cafa07a09e8929ddf538e86d08

https://deploy-preview-7680--carbon-components-react.netlify.app

tw15egan

comment created time in 16 hours

more