profile
viewpoint
Takis Koumoutsakos eliotis Eliotis WebDev South of Sparta Greece eliotis.gr Love coding! Angular + NestJS + GraphQL.

eliotis/CountryGeoJSONCollection 0

A collection GeoJSON files of all first admin boundaries generated from the natural earth dataset

eliotis/leaflet-geoman 0

🍂🗺️ The most powerful leaflet plugin for drawing and editing geometry layers

eliotis/type-graphql 0

Create GraphQL schema and resolvers with TypeScript, using classes and decorators!

push eventangular/angular

Krivokhizhin Anton

commit sha b668768c0a8dc7f070c94f48eedf293165ba2486

test(forms): verify that an object is not a boxed value if only `disabled` field is present (#39801) The value of a `FormControl` is treated in a special way (called boxed values) when it's an object with exactly 2 fields: `value` and `disabled`. This commit adds a test which verifies that an object is not treated as a boxed value when `disabled` field is present, but `value` is missing. PR Close #39801

view details

Kapunahele Wong

commit sha 0870af1740f58c76e8c8ccd8566bbe54f1c3fba2

docs: edit start-data.md (#39628) PR Close #39628

view details

David-Emmanuel DIVERNOIS

commit sha c7f4abf18a942b3a7edffb2f75a21c14181e81d2

feat(common): allow any Subscribable in async pipe (#39627) As only methods from the Subscribable interface are currently used in the implementation of the async pipe, it makes sense to make it explicit so that it works successfully with any other implementation instead of only Observable. PR Close #39627

view details

Bjarki

commit sha 358c50e2260a02ce57882601c0abd8d3f48ab3c5

feat(compiler): add schema for Trusted Types sinks (#39554) Create a schema with an associated function to classify Trusted Types sinks. Piggyback a typo fix. PR Close #39554

view details

Bjarki

commit sha bb70a9bda42e34b5d75be55b672b13b1e578cddf

feat(compiler): support error reporting in I18nMetaVisitor (#39554) Make it possible to report errors from the I18nMetaVisitor parser. PR Close #39554

view details

Bjarki

commit sha c8a99ef4588ee6f3ca14c8c8909d1c4f2062b36b

fix(compiler): disallow i18n of security-sensitive attributes (#39554) To minimize security risk (XSS in particular) in the i18n pipeline, disallow i18n translation of attributes that are Trusted Types sinks. Add integration tests to ensure that such sinks cannot be translated. PR Close #39554

view details

Bjarki

commit sha 4916870dff60e627baba59fcb6d30eb4045324d8

fix(compiler): only promote Trusted Types to constants when necessary (#39554) Previously all constant values of security-sensitive attributes and properties were promoted to Trusted Types. While this is not inherently bad, it is also not optimal. Use the newly added Trusted Types schema to restrict promotion to constants that are in a Trusted Types-relevant context. PR Close #39554

view details

Bjarki

commit sha 2ae3fa009e60f627112ed4108a831d176fb384fd

refactor(compiler): remove unnecessary trustConstantScript function (#39554) Script tags, inline event handlers and other script contexts are forbidden or stripped from Angular templates by the compiler. In the context of Trusted Types, this leaves no sinks that require use of a TrustedScript. This means that trustConstantScript is never used, and can be removed. PR Close #39554

view details

Gautier Pelloux-Prayer

commit sha 938abc03bcc69925f88b64245f26df3d597ef7f3

docs(http): Add mention to default value 'OK' for statusText. #23334 (#23494) PR Close #23494

view details

push time in 2 minutes

PR opened typeorm/typeorm

test: SQL Server error when requesting additional returning columns (#7100)

Test for #7100 (currently failing until fixed)

Description of change

#5361 broke QueryBuilder.returning() for SQL Server, test to validate fix.

Pull-Request Checklist

  • [x] Code is up-to-date with the master branch
  • [x] npm run lint passes with this change
  • [ ] npm run test passes with this change
  • [ ] This pull request links relevant issues as Fixes #0000
  • [x] There are new or updated unit tests validating the change
  • [x] Documentation has been updated to reflect this change
  • [x] The new commits follow conventions explained in CONTRIBUTING.md
+73 -0

0 comment

2 changed files

pr created time in 6 minutes

pull request commentangular/angular

TEST

You can preview cb5600b at https://pr39815-cb5600b.ngbuilds.io/.

gkalpak

comment created time in 8 minutes

issue openedtypeorm/typeorm

SQL Server error when requesting additional returning columns

Issue Description

#5361 changed the way SQL Server uses OUTPUT in INSERT/UPDATE queries, causing an error if additional columns are requested using InsertQueryBuilder.returning().

Expected Behavior

connection.createQueryBuilder(Post, 'post')
    .update()
    .set({ title: "TITLE" })
    .returning(["text"])
    .execute();

Should execute without error and return additional column "text".

Actual Behavior

UPDATE "post" SET "title" = @1 OUTPUT INSERTED."text" INTO @OutputTable WHERE "id" IN (@0)
QueryFailedError: Error: Must declare the table variable "@OutputTable".

Relevant Database Driver(s)

  • [ ] aurora-data-api
  • [ ] aurora-data-api-pg
  • [ ] better-sqlite3
  • [ ] cockroachdb
  • [ ] cordova
  • [ ] expo
  • [ ] mongodb
  • [ ] mysql
  • [ ] nativescript
  • [ ] oracle
  • [ ] postgres
  • [ ] react-native
  • [ ] sap
  • [ ] sqlite
  • [ ] sqlite-abstract
  • [ ] sqljs
  • [x] sqlserver

Are you willing to resolve this issue by submitting a Pull Request?

  • [x] Yes, I have the time, and I know how to start.
  • [ ] Yes, I have the time, but I don't know how to start. I would need guidance.
  • [ ] No, I don't have the time, although I believe I could do it if I had the time...
  • [ ] No, I don't have the time and I wouldn't even know how to start.

created time in 14 minutes

issue commenttypeorm/typeorm

All Error thrown by TypeOrm shall have a base type

No updates on this?

Diluka

comment created time in 18 minutes

pull request commentangular/angular

docs: edit builtin-directives doc

You can preview 0495d15 at https://pr39816-0495d15.ngbuilds.io/.

kapunahelewong

comment created time in 26 minutes

pull request commentangular/angular

docs: replace --create-application by --createApplication

The arguments format are interchangeable at least for the time being. Ie both kebab and camel cases can be used.

In general kebab causes should be preferred in the documentation.

thierryc

comment created time in 26 minutes

Pull request review commentangular/angular

ci: migrate rebase-pr CI script to the circleci directory

-/**- * @license- * Copyright Google LLC All Rights Reserved.- *- * Use of this source code is governed by an MIT-style license that can be- * found in the LICENSE file at https://angular.io/license- */--/**- * **Usage:**- * ```- * node rebase-pr <github-repository> <pull-request-number>- * ```- * **Example:**- * ```- * node rebase-pr angular/angular 123- * ```

The command not longer obtains this information from the command line arguments, instead it gathers the information it needs from environment variables.

josephperrott

comment created time in 30 minutes

issue commentangular/components

Datepicker - Cannot select dates

@crisbeto Yes, per the filter only Mondays that are >= today are available to select. So the filtering of the dates itself seems to be working, but those it has left available for selection do nothing when clicked. E.g. 23rd and 30th in the screenshot.

Krenom

comment created time in 31 minutes

PR opened angular/angular

Reviewers
docs: edit builtin-directives doc comp: docs effort2: days risk: low target: patch

Edit built-in-directives.md copy and headers, fixes affected links, adds a docregion to make steps clearer.

+154 -272

0 comment

5 changed files

pr created time in 36 minutes

pull request commentangular/angular

fix(service-worker): correctly handle failed cache-busted request

You can preview febee11 at https://pr39786-febee11.ngbuilds.io/.

gkalpak

comment created time in 37 minutes

pull request commentangular/angular

TEST

You can preview 6232b6e at https://pr39815-6232b6e.ngbuilds.io/.

gkalpak

comment created time in 39 minutes

PR opened angular/angular

TEST
+2695 -2863

0 comment

79 changed files

pr created time in an hour

PR opened angular/components

Reviewers
docs: remove deprecated harness usage and use parallel promise utility P3 docs merge safe target: minor
  • Uses MatChipListboxHarness for the chip harness example since MatChipList harness has some deprecated methods.
  • Uses parallel instead of Promise.all like we do in the test harness code.
+16 -12

0 comment

2 changed files

pr created time in an hour

issue commenttypeorm/typeorm

Custom Repositories with Separate Entity Definitions

I think this would work:

class UserRecord {
  name: string;
  constructor(name: string) {
    this.name = name
  }
}

const UserSchema = new EntitySchema<UserRecord>({
  name: "user",
  target: UserRecord,
  columns: {
    name: { type: String, primary: true }
  }
});

@EntityRepository(UserSchema)
class UserRepository extends AbstractRepository<UserRecord> {
  findByName(name: string) {
    return this.repository.findOne({ name });
  }
}
christhekeele

comment created time in an hour

issue closedangular/angular

Check control type using constructor.name does not work when deployed on server

🔥 No visible Exception or Error

<pre><code> let controlNames = Object.keys(this.form.controls);
controlNames.forEach(controlName => { let ctrl = this.form.controls[controlName];

 if (ctrl.constructor.name == 'FormGroup') {

// Code here is not being reached when deploying on server } }); </code></pre>

🌍 Your Environment

Angular Version: 9.1.12

closed time in an hour

msleiman2

issue commentangular/angular

Check control type using constructor.name does not work when deployed on server

Hello, this happens because an optimizer has renamed symbols where possible to reduce the bundle size. In this case you could probably use the following:

let controlNames = Object.keys(this.form.controls);    
    controlNames.forEach(controlName => {
      let ctrl = this.form.controls[controlName];
      
     if (ctrl instanceof FormGroup) {
        // ...
     }
    });

It's not the responsibility of the framework to detect these kinds of things; maybe a linter could. Anyway, I'll close this as non-actionable for the framework.

msleiman2

comment created time in an hour

issue commentangular/angular

Angular component which references its own type and decorated by class decorator is broken when target es5 + enableIvy=true

Hi @ratoaq2 - I checked with the team. While this fix could have been merged into 10.2.x, that branch is now not the active patch branch. It is our standard policy to only backport security and catastrophic bugs to earlier branches. Please can I ask you to attempt an update to 11.0.x to receive the benefit of this fix?

ratoaq2

comment created time in an hour

pull request commentangular/angular

docs: replace --create-application by --createApplication

image

ref: https://angular.io/cli/new v11.0.x

thierryc

comment created time in 2 hours

issue commentangular/angular

MatStepper - Not validating inside template

Hey @AndrewKushnir, sorry for that! I actually just took the first one I found and adopted it, since the behavior did not change since that (actually pretty old) version. Here is a newer one: Angular 11

tsproesser

comment created time in 2 hours

Pull request review commentangular/angular

fix(core): call ngOnDestroy on component level services that are provided using a factory function

 export class AbstractFormGroupDirective extends ControlContainer implements OnIn     return this._parent ? this._parent.formDirective : null;   } +  /**+   * @description+   * Returns the current number of references to this directive.+   */+  get refCount() {+    return this._refCount;+  }++  /**+   * @description+   * Adds a reference into the total reference count.+   */+  addRef() {+    this._refCount++;+  }+

I believe we should revert these changes in Forms based on https://github.com/angular/angular/pull/28737#issuecomment-728266633. Current understanding is that the problem with re-providing the same instance via useFactory should be taken care of on the apps (not framework) side. However I'd propose to keep a test for now (and mark it with xit vs it) to have more context and we can update or remove the test later.

The next step for this PR is to perform further investigation in Google's codebase (Angular team will handle that) to see if it's feasible to update the code to fix the issue with ngOnDestroy. We'll have more details after investigation and will make a final decision based on this data.

llorenspujol

comment created time in 2 hours

issue closedangular/components

bug(datepicker): if given YYYY-MM-YY format, date picker can pick sometimes previous day because of timezone difference

Reproduction

Use StackBlitz to reproduce your issue: https://stackblitz.com/fork/components-issue

Steps to reproduce:

  1. copy paste 1970-12-23 into datepicker field
  2. on blur datepicker sets selected date.

Expected Behavior

What behavior were you expecting to see? always select pasted date

Actual Behavior

What behavior did you actually see? based on timezone it sets to previous date

Environment

  • Angular: 10
  • CDK/Material: 10
  • Browser(s): Chrome
  • Operating System (e.g. Windows, macOS, Ubuntu): Win10

closed time in 2 hours

ayhanyildiz

issue openedangular/angular

Check control type using constructor.name does not work when deployed on server

🔥 No visible Exception or Error

<pre><code> let controlNames = Object.keys(this.form.controls);
controlNames.forEach(controlName => { let ctrl = this.form.controls[controlName];

 if (ctrl.constructor.name == 'FormGroup') {

// Code here is not being reached when deploying on server } }); </code></pre>

🌍 Your Environment

Angular Version: 9.1.12

created time in 2 hours

issue commentangular/components

bug(datepicker): if given YYYY-MM-YY format, date picker can pick sometimes previous day because of timezone difference

By default, our date parsing is limited to basically new Date(value) since handling all possible use cases and date libraries would be impractical. There's some more information in the docs, but the options for resolving it are:

  1. Implement your own date adapter, either by extending the MatNativeDateAdapter that Material comes with, or from scratch.
  2. Use an existing date adapter like the MomentDateAdapter.
ayhanyildiz

comment created time in 2 hours

PR closed angular/angular

test: enable golden test for ng_package rule cla: no comp: bazel state: blocked target: major

PR Checklist

Please check if your PR fulfills the following requirements:

  • [ ] The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

<!-- Please check the one that applies to this PR using "x". -->

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

<!-- Please describe the current behavior that you are modifying, or link to a relevant issue. -->

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. -->

Other information

+9221 -1792

4 comments

129 changed files

alexeagle

pr closed time in 2 hours

pull request commentangular/angular

test: enable golden test for ng_package rule

Closing as this is no longer being worked on.

alexeagle

comment created time in 2 hours

issue commentangular/angular

MatStepper - Not validating inside template

Hi @tsproesser, thanks for reporting the issue and providing as repro. I've looked at the repro and found out that quite old version of Angular packages are used (v5). Could you please try re-creating this example using the most recent Angular version (v11.0.2 at this moment) and also simplify the demo to keep only the minimum required code to reproduce the issue (so that it's faster to investigate it)? Thank you.

tsproesser

comment created time in 2 hours

PR closed angular/angular

build: bazel JSON profile cla: yes comp: build & ci

PR Checklist

Please check if your PR fulfills the following requirements:

  • [ ] The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

<!-- Please check the one that applies to this PR using "x". -->

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

<!-- Please describe the current behavior that you are modifying, or link to a relevant issue. -->

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. -->

Other information

+95 -5

2 comments

4 changed files

alexeagle

pr closed time in 2 hours

pull request commentangular/angular

build: bazel JSON profile

Closing as this is now obsolete.

alexeagle

comment created time in 2 hours

more