profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/eldeni/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Elden S. Park eldeni Los Angeles https://eldeni.github.io Creator. Problem solver.

chatty-app/chatty-android 6

Write diary with chatbot - Android

eldeni/express-isomorphic 2

Unstoppable isomorphic-app web server

eldeni/browser-lock 1

Chrome, Whale Extension - Lock your browser in a second

eldeni/.tmux 0

🇫🇷 Oh My Tmux! Pretty & versatile tmux configuration / customization made with ❤️

eldeni/12306_code_server 0

该仓库用于构建自托管的12306验证码识别服务器

eldeni/Awesome-Profile-README-templates 0

A collection of awesome readme templates to display on your profile

issue commentmicrosoft/vscode

generic type interface with template literal string wrong generate implemented function

Please share the text of the code along with screenshots

siosio34

comment created time in a few seconds

pull request commentnodejs/node

tools: update eslint-plugin-markdown configuration

CI: https://ci.nodejs.org/job/node-test-pull-request/36408/

cjihrig

comment created time in a minute

pull request commentnodejs/node

doc,lib: add missing deprecation code

CI: https://ci.nodejs.org/job/node-test-pull-request/36407/

cjihrig

comment created time in 2 minutes

issue commentsequelize/sequelize

Not returning id on create

One solution to this problem is to have a custom variable (eg. let id = 0) in your server and increment it every time you sign up a new user.

Tom-Hudson

comment created time in 3 minutes

issue commentdenoland/deno

`deno compile` does not have dynamic import support

I'd love to be able to use denon as a stand-alone utility or another deno-similar variant (with full deno capabilities) as a cross-platform task runner or specialized script runner (eg, similar to perl -ne ...). Being able to produce such completely stand-alone variant executables would be an extremely attractive quality for devs.

lucacasonato

comment created time in 8 minutes

pull request commentfacebook/react

[Experiment] Lazily propagate context changes

I think this could work but would need to be paired with simultaneous propagation. I tried it out by having lazilyPropagateParentContextChanges accumulate all contexts up to root in a map keyed by the context and the changed bits as values (keeping first found so nearest providers mask ancestor ones of the same context type) followed by a propagation that halts as soon as work is found but continues to siblings. Then on the scheduleWorkOnParentPath I added the current fiber to a set indicating that it has fully propagated all contexts to children up to next work on any given sub-tree.

Yeah this is good. This is essentially what I landed on, too. Except I think what I'll do is consult the Set in lazilyPropagateParentContextChanges while searching for parent providers. If a parent's current fiber is in that Set, then I know I have to keep searching for providers that are beyond that, disregarding the DidPropagateContext flag. Other than that I think the rest of what you described will be the same.

I'll need to revert my change that consults in child -> parent order, though. That optimization is still nice for the Suspense and Offscreen case, where we have to propagate to the whole tree without bailout out regardless. So I could have two separate functions, one for each case; not sure it's worth the extra code size, though.

acdlite

comment created time in 11 minutes

issue commentfacebook/react-native

java.lang.NullPointerException

We probably won't be able to help without additional information and a repro. You can try to find similar issues here on github or on stackoverflow to see if others are facing the same problem.

DeebanT2S

comment created time in 15 minutes

issue closedfacebook/react-native

iOS 14.4 : Style property 'height' is not supported by native animated module

Description

Hello everyone,

I am having an issue with iOS 14.4 and the TextInput component in React Navigation Stack. First of all, I do not encounter the problem on iOS 13.X versions.

When I press a basic TextInput, I encounter the following error: Style property 'height' is not supported by native animated module

Thx in advance.

React Native version:

System:
    OS: macOS 11.2.1
    CPU: (4) x64 Intel(R) Core(TM) i5-7360U CPU @ 2.30GHz
    Memory: 34.75 MB / 8.00 GB
    Shell: 3.2.57 - /bin/bash
  Binaries:
    Node: 12.16.3 - /usr/local/bin/node
    Yarn: 1.22.10 - /usr/local/bin/yarn
    npm: 6.14.4 - /usr/local/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  Managers:
    CocoaPods: 1.10.0 - /usr/local/bin/pod
  SDKs:
    iOS SDK:
      Platforms: iOS 14.4, DriverKit 20.2, macOS 11.1, tvOS 14.3, watchOS 7.2
    Android SDK: Not Found
  IDEs:
    Android Studio: Not Found
    Xcode: 12.4/12D4e - /usr/bin/xcodebuild
  Languages:
    Java: Not Found
    Python: 2.7.16 - /usr/bin/python
  npmPackages:
    @react-native-community/cli: Not Found
    react: 16.13.1 => 16.13.1 
    react-native: 0.63.4 => 0.63.4 
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

Steps To Reproduce

  1. Click on TextInput

Expected Results

Describe what you expected to happen. Write in TextInput

Snack, code example, screenshot, or link to a repository:

import React, { Component } from 'react';
import { TextInput } from 'react-native';

export interface Props {
}

interface State {
    value: string;
}

class Search extends Component<Props, State> {
    constructor(props: Props | Readonly<Props>) {
        super(props);
        this.state = {
            value: "",
        }
    }

    render() {
        return (
            <TextInput 
                style={{ height: 40, width: "100%", backgroundColor: "#000" }}
                value={this.state.value}
                onChangeText={(text) => this.setState({ value: text })} />
        );
    }
}

export default Search;

Simulator Screen Shot - iPhone 12 Pro - 2021-02-28 at 21 41 41

closed time in 16 minutes

CharlesQuint

issue commentfacebook/react-native

iOS 14.4 : Style property 'height' is not supported by native animated module

The issue is pretty much described in the error message - animating the "height" property (and other layout properties) in this way is explicitly not supported for native animations. You can convert it to a native JS animation or use LayoutAnimations instead.

The reason is that changing height, width, other layout props, etc, requires going through a full layout pass that can impact other nodes around the node being animated; but native animations only animate the node under your control. JS animations are slower, but an update from JS will allow native to do a full layout of the screen every time the prop is updated. Similar with LayoutAnimations.

CharlesQuint

comment created time in 16 minutes

pull request commentfacebook/react

[Experiment] Lazily propagate context changes

I think you still have the edge case when constructing the contexts array where you would let an otherwise masked provider contribute a changedBits flags left a couple comments on one idea to deal with it

I think your idea would work, though my instinct would be to use a Set instead to skip duplicates as you search for providers in the tree.

I'm going to leave this as a todo, since in the worst case it's just a bit of extra propagation and I don't think it's a very common case.

i wrote it before noticing you updated earlier commits and changed the context propagation to be simultaneous already

Yeah sorry for editing those "in place" instead of pushing a new commit. I want the commits to be atomic so that I can bisect later if needed. I wish GitHub let you compare between versions of a PR like Phabricator does.

acdlite

comment created time in 18 minutes

pull request commentmicrosoft/vscode

#117667 add a markup escape for filenames in error messages

same issue

Cloud11665

comment created time in 21 minutes

issue closedbrave/brave-browser

Very high battery usage on Android since last update

Description <!-- Provide a brief description of the issue -->

Since last update a few days ago, Brave got to the top of battery using apps. Before the update I have 70% battery left by the evening, now it's 20%, and most of it is attributed to Brave.

Steps to reproduce <!-- Please add a series of steps to reproduce the issue -->

  1. Open brave once
  2. Wait all day

Actual result <!-- Please add screenshots if needed -->

Battery is almost empty

Expected result

Brave should not consume that much battery.

Issue reproduces how often <!-- [Easily reproduced/Intermittent issue/No steps to reproduce] -->

Every day for the last 3 days

Version/Channel Information:

<!--Does this issue happen on any other channels? Or is it specific to a certain channel?-->

  • Can you reproduce this issue with the current Play Store version?

Yes

  • Can you reproduce this issue with the current Play Store Beta version?

Haven't tried

  • Can you reproduce this issue with the current Play Store Nightly version?

Haven't tried

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Huawei P30
  • Android version: 10

Brave version

1.20.108

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome? No

Additional information

<!-- Any additional information, related issues, extra QA steps, configuration or data that might be necessary to reproduce the issue -->

closed time in 23 minutes

angryziber

issue commentbrave/brave-browser

Very high battery usage on Android since last update

Seems back to normal after a few reboots...

angryziber

comment created time in 23 minutes

pull request commentfacebook/react-native

Android - pass initial props to ViewManager createView in non-Fabric

I realized that some of our FB-internal view managers use the presence of props in the constructor to differentiate between Fabric and non-Fabric rendering modes. I will need to think about this a bit more.

gkode

comment created time in 23 minutes

issue openedmicrosoft/TypeScript

[NewErrors] 4.3.0-dev.20210228 vs 4.2.2

The following errors were reported by 4.3.0-dev.20210228, but not by 4.2.2

cdr/code-server

9 of 47 projects failed to build with the old tsc

lib/vscode/extensions/html-language-features/server/tsconfig.json

lib/vscode/extensions/typescript-language-features/tsconfig.json

ReactiveX/rxjs

7 of 11 projects failed to build with the old tsc

src/tsconfig.cjs.spec.json

src/tsconfig.esm5.rollup.json

typeorm/typeorm

tsconfig.json

reduxjs/redux-devtools

17 of 51 projects failed to build with the old tsc

packages/redux-devtools/tsconfig.json

  • error TS2322: Type 'MonitorProps' is not assignable to type 'IntrinsicAttributes & Omit<any, "monitorState" | "nextActionId" | "actionsById" | "stagedActionIds" | "skippedActionIds" | "committedState" | "currentStateIndex" | "computedStates" | "isLocked" | "isPaused" | "dispatch">'.
  • error TS2322: Type 'MonitorProps & { store: LiftedStore<S, A, MonitorState>; }' is not assignable to type 'IntrinsicAttributes & Omit<any, "monitorState" | "nextActionId" | "actionsById" | "stagedActionIds" | "skippedActionIds" | "committedState" | "currentStateIndex" | "computedStates" | "isLocked" | "isPaused" | "dispatch">'.

created time in 31 minutes

pull request commentnodejs/node

tools: update eslint-plugin-markdown configuration

I have a concurrent PR for this (https://github.com/nodejs/node/pull/37311), but we can land this one first as mine tries to change a few things in the linter config.

cjihrig

comment created time in 35 minutes

issue commentfacebook/react

Bug: Event handling with portals is broken

Hello ) I will try to fix this )

sag-tobias-frey

comment created time in 37 minutes

issue closedmicrosoft/TypeScript

Documentation of the full algorithms for type *union* (the `|` operator) and *intersection* (the `&` operator), and their higher order combinations.

Suggestion

<!-- Please fill in each section completely. Thank you! -->

🔍 Search Terms

<!-- 💡 Did you know? TypeScript has over 2,000 open suggestions! 🔎 Please search thoroughly before logging new feature requests as most common ideas already have a proposal in progress. The "Common Feature Requests" section of the FAQ lists many popular requests: https://github.com/Microsoft/TypeScript/wiki/FAQ#common-feature-requests

Replace the text below: -->

typescript unions and intersections

✅ Viability Checklist

<!-- Suggestions that don't meet all these criteria are very, very unlikely to be accepted. We always recommend reviewing the TypeScript design goals before investing time writing a proposal for ideas outside the scope of the project. --> My suggestion meets these guidelines:

  • [x ] This wouldn't be a breaking change in existing TypeScript/JavaScript code
  • [ x] This wouldn't change the runtime behavior of existing JavaScript code
  • [ ]x This could be implemented without emitting different JS based on the types of the expressions
  • [ x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
  • [ x] This feature would agree with the rest of TypeScript's Design Goals.

⭐ Suggestion

Documentation of the full algorithms for type union (the | operator) and intersection (the & operator), and their higher order combinations.

Here are some sample trials to give some insight about edge cases.

{
  type A = {a:number,b:number}
  type B = {b:string,c:string}
  type C = {c:bigint,a:bigint}
  const t1:A|B|C = {a:1,b:'1',c:1n} // fail
  const t2:A|B|C = {a:1,b:'1',c:'1'} 
  const t3:A|B|C = {a:1,b:1,c:1n} 
  const t4:A|B|C = {a:1,b:1,c:'1'} 
  const t5:A|B|C = {a:1n,b:'1',c:1n} 
  const t6:A|B|C = {a:1n,b:'1',c:'1'} 
  const t7:A|B|C = {a:1n,b:1,c:1n} 
  const t8:A|B|C = {a:1n,b:1,c:'1'} // fail 
}
{
  type A = {a:number,b:number,c:number}
  type B = {b:string,c:string,a:string}
  type C = {c:bigint,a:bigint, b:bigint}
  const t1:A|B|C = {a:1,b:'1',c:1n} // fail
  const t2:A|B|C = {a:1,b:'1',c:'1'} // fail
  const t3:A|B|C = {a:1,b:1,c:1n} // fail
  const t4:A|B|C = {a:1,b:1,c:'1'} // fail
  const t5:A|B|C = {a:1n,b:'1',c:1n} // fail
  const t6:A|B|C = {a:1n,b:'1',c:'1'} // fail
  const t7:A|B|C = {a:1n,b:1,c:1n} // fail
  const t8:A|B|C = {a:1n,b:1,c:'1'} // fail
}
{
  type A = {a:number,b:number,c:number}
  type B = {b:string,c:string,a:string}
  type C = {c:bigint,a:bigint}
  const t1:A|B|C = {a:1,b:'1',c:1n} // fail 
  const t2:A|B|C = {a:1,b:'1',c:'1'} // fail
  const t3:A|B|C = {a:1,b:1,c:1n} // fail
  const t4:A|B|C = {a:1,b:1,c:'1'} // fail
  const t5:A|B|C = {a:1n,b:'1',c:1n} 
  const t6:A|B|C = {a:1n,b:'1',c:'1'} // fail
  const t7:A|B|C = {a:1n,b:1,c:1n} 
  const t8:A|B|C = {a:1n,b:1,c:'1'} // fail
}

The union operations looks something like matching subsets of the instance against the 'whole' subtypes under the union/intersection tree, and then sometimes allowing at least one partial subset to finish it off.

It looks complex enough that I'd prefer reading the specifications (also covering intersection, ? marked keys, [key:string]:T additional key specifiers) to avoid misunderstanding.

📃 Motivating Example

<!-- If you were announcing this feature in a blog post, what's a short explanation that shows a developer why this feature improves the language? -->

It's a good idea to make public the documentation for the behavior of core algorithms, e.g., typescript type processing. Mostly it works as "expected" but there are enough edge cases to create some unnecessary surprises.

💻 Use Cases

<!-- What do you want to use this for? What shortcomings exist with current approaches? What workarounds are you using in the meantime? -->

I would like to use the rules to write precise specifications for Typescript native behavior when interfacing with external software - e.g., using JSON Schema. Having no precise documentation makes this hard and there is really no workaround.

closed time in an hour

craigphicks

issue commentmicrosoft/TypeScript

Documentation of the full algorithms for type *union* (the `|` operator) and *intersection* (the `&` operator), and their higher order combinations.

From (Release Notes 3.5)[https://devblogs.microsoft.com/typescript/announcing-typescript-4-2-beta/]

In TypeScript 3.5, the type-checker at least verifies that all the provided properties belong to some union member and have the appropriate type, meaning that the sample above correctly issues an error. Note that partial overlap is still permitted as long as the property types are valid.

Not stated, but implicit, is that at least one member type must also be completely satisfied.

I believe that answers my question, so I am closing this issue.

craigphicks

comment created time in an hour

issue commentVSCodeVim/Vim

Annoying flicker when adding keybinding to EasyMotion

Happens to me as well--didn't know it was related to keybindings, thanks for that--and on top of being unpleasant, it makes the command very slow for me; between a lag and some 3 flickers, it takes about a second before I can jump to the point I want.

McHeisenburglar

comment created time in an hour

issue commenttypeorm/typeorm

Models with simple-enum column type will cause TypeORM to drop and recreate the table

Any eta on when the fix will be released? We are just starting a new project and would require this to work. Running mssql.

hsharghi

comment created time in an hour

issue commentmicrosoft/TypeScript

Duplicate suggestions for react

It only happen if I have @material-ui/core installed.

same with react-bootstrap

Mangatt

comment created time in an hour

issue commentnodejs/node

Investigate persistent Windows test failure on test.wasi/test-return-on-exit

I agree that this is probably a genuine bug since it only shows up on 32-bit Windows, and coincided with the V8 8.8 update (which had wasm related changes). The returnOnExit feature also relies on somewhat corner case behavior - monkey patching the WASI import to throw a JavaScript exception that WebAssembly can't catch.

Regarding the test - as a last resort, we could skip it on Windows. It looks like there are two test cases in test/wasi/test-return-on-exit.js. Can we identify which of them is causing the crash, or if splitting them into separate test files somehow mitigates the problem?

Trott

comment created time in an hour

issue openedfacebook/react-native

iOS 14.4 : Style property 'height' is not supported by native animated module

Description

Hello everyone,

I am having an issue with iOS 14.4 and the TextInput component. First of all, I do not encounter the problem on iOS 13.X versions.

When I press a basic TextInput, I encounter the following error: Style property 'height' is not supported by native animated module

Thx in advance.

React Native version:

System:
    OS: macOS 11.2.1
    CPU: (4) x64 Intel(R) Core(TM) i5-7360U CPU @ 2.30GHz
    Memory: 34.75 MB / 8.00 GB
    Shell: 3.2.57 - /bin/bash
  Binaries:
    Node: 12.16.3 - /usr/local/bin/node
    Yarn: 1.22.10 - /usr/local/bin/yarn
    npm: 6.14.4 - /usr/local/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  Managers:
    CocoaPods: 1.10.0 - /usr/local/bin/pod
  SDKs:
    iOS SDK:
      Platforms: iOS 14.4, DriverKit 20.2, macOS 11.1, tvOS 14.3, watchOS 7.2
    Android SDK: Not Found
  IDEs:
    Android Studio: Not Found
    Xcode: 12.4/12D4e - /usr/bin/xcodebuild
  Languages:
    Java: Not Found
    Python: 2.7.16 - /usr/bin/python
  npmPackages:
    @react-native-community/cli: Not Found
    react: 16.13.1 => 16.13.1 
    react-native: 0.63.4 => 0.63.4 
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

Steps To Reproduce

  1. Click on TextInput

Expected Results

Describe what you expected to happen. Write in TextInput

Snack, code example, screenshot, or link to a repository:

export interface Props {
}

interface State {
    value: string;
}

class Search extends Component<Props, State> {
    constructor(props: Props | Readonly<Props>) {
        super(props);
        this.state = {
            value: "",
        }
    }

    render() {
        return (
            <TextInput 
                style={{ height: 40, width: "100%", backgroundColor: "#000" }}
                value={this.state.value}
                onChangeText={(text) => this.setState({ value: text })} />
        );
    }
}

export default Search;

Simulator Screen Shot - iPhone 12 Pro - 2021-02-28 at 21 41 41

created time in an hour

push eventtorvalds/linux

Arnd Bergmann

commit sha da83616bcd3fa84233f6e37e2cf8cbfa979c6927

kbuild: lto: add _mcount to list of used symbols Some randconfig builds fail with undefined references to _mcount when CONFIG_TRIM_UNUSED_KSYMS is set: ERROR: modpost: "_mcount" [drivers/tee/optee/optee.ko] undefined! ERROR: modpost: "_mcount" [drivers/fsi/fsi-occ.ko] undefined! ERROR: modpost: "_mcount" [drivers/fpga/dfl-pci.ko] undefined! Since there is already a list of symbols that get generated at link time, add this one as well. Fixes: fbe078d397b4 ("kbuild: lto: add a default list of used symbols") Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>

view details

Masahiro Yamada

commit sha a6aaeb841198016083663ae56c568de4e065d090

kbuild: fix UNUSED_KSYMS_WHITELIST for Clang LTO Commit fbe078d397b4 ("kbuild: lto: add a default list of used symbols") does not work as expected if the .config file has already specified CONFIG_UNUSED_KSYMS_WHITELIST="my/own/white/list" before enabling CONFIG_LTO_CLANG. So, the user-supplied whitelist and LTO-specific white list must be independent of each other. I refactored the shell script so CONFIG_MODVERSIONS and CONFIG_CLANG_LTO handle whitelists in the same way. Fixes: fbe078d397b4 ("kbuild: lto: add a default list of used symbols") Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> Tested-by: Sedat Dilek <sedat.dilek@gmail.com>

view details

Masahiro Yamada

commit sha 12e9dea6c9766c7403417d00193940cea33ee81a

kbuild: do not include include/config/auto.conf from adjust_autoksyms.sh Commit cd195bc4775a ("kbuild: split adjust_autoksyms.sh in two parts") split out the code that needs include/config/auto.conf. This script no longer needs to include include/config/auto.conf. Fixes: cd195bc4775a ("kbuild: split adjust_autoksyms.sh in two parts") Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>

view details

Masahiro Yamada

commit sha ad7953e7aebb585d0fcfc58d81e207360f751ddb

ia64: remove redundant READELF from arch/ia64/Makefile READELF is defined by the top Makefile. Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>

view details

Masahiro Yamada

commit sha 2214945422c143f8bb27faed77a97f728c0a1cb1

kbuild: make -s option take precedence over V=1 'make -s' should be really silent. However, 'make -s V=1' prints noisy log messages from some shell scripts. Of course, such a combination is odd, but the build system needs to do the right thing even if a user gives strange input. If -s is given, KBUILD_VERBOSE should be forced to 0. Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>

view details

Masahiro Yamada

commit sha 207da4c82ade9a6d59f7e794d737ba0748613fa2

kbuild: Fix <linux/version.h> for empty SUBLEVEL or PATCHLEVEL again Commit 78d3bb4483ba ("kbuild: Fix <linux/version.h> for empty SUBLEVEL or PATCHLEVEL") fixed the build error for empty SUBLEVEL or PATCHLEVEL by prepending a zero. Commit 9b82f13e7ef3 ("kbuild: clamp SUBLEVEL to 255") re-introduced this issue. This time, we cannot take the same approach because we have C code: #define LINUX_VERSION_PATCHLEVEL $(PATCHLEVEL) #define LINUX_VERSION_SUBLEVEL $(SUBLEVEL) Replace empty SUBLEVEL/PATCHLEVEL with a zero. Fixes: 9b82f13e7ef3 ("kbuild: clamp SUBLEVEL to 255") Reported-by: Christian Zigotzky <chzigotzky@xenosoft.de> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> Reviewed-and-tested-by: Sasha Levin <sashal@kernel.org>

view details

Linus Torvalds

commit sha 06d5d309a3f17e32cd59926f391db1e1ea652184

Merge tag 'kbuild-fixes-v5.12' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild Pull Kbuild fixes from Masahiro Yamada: - Fix UNUSED_KSYMS_WHITELIST for Clang LTO - Make -s builds really silent irrespective of V= option - Fix build error when SUBLEVEL or PATCHLEVEL is empty * tag 'kbuild-fixes-v5.12' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild: kbuild: Fix <linux/version.h> for empty SUBLEVEL or PATCHLEVEL again kbuild: make -s option take precedence over V=1 ia64: remove redundant READELF from arch/ia64/Makefile kbuild: do not include include/config/auto.conf from adjust_autoksyms.sh kbuild: fix UNUSED_KSYMS_WHITELIST for Clang LTO kbuild: lto: add _mcount to list of used symbols

view details

push time in an hour

startedpond3r/ggpo

started time in 2 hours

issue commentmicrosoft/vscode

Slow intellisence, slow navigation, slow formatting etc, it was fast before

Also when debugging c# it seems like vscode freezes first and only then hit the breakpoint.

JanBN

comment created time in 2 hours

issue openedbrave/brave-browser

Make brave_wallet buildable on Windows

We currently have a flag brave_wallet_enabled which is gated to enable_extensions

See components/brave_wallet/buildflags/buildflags.gni: brave_wallet_enabled = enable_extensions

We should instead allow it to build on everything except for iOS and then for the parts that use an extension don't include it for Android.

created time in 2 hours

issue commentdenoland/deno

wrong type for regex match, breaks named groups

that makes sense thanks.

Pyrolistical

comment created time in 2 hours

issue closeddenoland/deno

wrong type for regex match, breaks named groups

This is related to https://github.com/denoland/deno/issues/5444

Currently the type returned by String.match(RegExp) does not includes groups which leads to this situation

const {groups: {filename}} = path.match(/^\/play\/(?<filename>.+)$/);
error: TS2339 [ERROR]: Property 'groups' does not exist on type 'RegExpMatchArray | null'.
      const {groups: {filename}} = path.match(/^\/play\/(?<filename>.+)$/);
             ~~~~~~

Tested on Deno 1.7.2

Works in node.js

closed time in 2 hours

Pyrolistical