profile
viewpoint

efritz/nacelle 4

This project has migrated to http://github.com/go-nacelle/nacelle.

arrowsjs/arrows 3

Arrows are a method for async composition in JavaScript.

efritz/glock 2

Small go library for mocking parts of the time package.

efritz/deepjoy 1

A pooling and retrying redis client.

PR opened sourcegraph/lsif-go

Reviewers
Remove events from protocol
+0 -33

0 comment

2 changed files

pr created time in 23 minutes

create barnchsourcegraph/lsif-go

branch : dead-code

created branch time in 34 minutes

push eventsourcegraph/lsif-go

Eric Fritz

commit sha 1912764d9c4139eb625e97956c26c6c122e7ed2a

Fix moniker generation from refactor.

view details

Eric Fritz

commit sha 7d37cc48b5b46bb69b9f513d89126a5ac734fad0

Fix module inference from refactor.

view details

push time in 36 minutes

issue commentsourcegraph/sourcegraph

codeintel: add comment parsing to lsif-go

Is there a standard for this in general? It should be fairly easy to say "this word matches the case of a package-level variable". Is there similarly a way to specify fields of structs or exports from another package? Javadoc, ruby, and other spec types have other conventions and I'm not sure/aware of what Go uses in this regard (parent#child, parent.child, etc).

stefanhengl

comment created time in an hour

push eventsourcegraph/lsif-go

Eric Fritz

commit sha 6d7e94542f8f62fb620a2f7fb60c5194c2c3bd92

Major refactor (#69)

view details

push time in an hour

delete branch sourcegraph/lsif-go

delete branch : ef/refactor

delete time in an hour

PR merged sourcegraph/lsif-go

Reviewers
Major refactor

This is a major code reorganization, but should not have any major behavioral effects. There is increased test (coverage 80% of the indexer package) and documentation (each function).

The only change that should be visible is a nicer output (which outputs the progress of each stage of indexing).

+3673 -2495

1 comment

65 changed files

efritz

pr closed time in an hour

issue openedsourcegraph/lsif-go

Buildkite job

Add a buildkite job that runs the unit tests for this repository.

created time in an hour

push eventsourcegraph/lsif-go

Eric Fritz

commit sha 98f9f47acf3bb082aac65faf0342e313826306f6

Squash cmomits.

view details

push time in 2 hours

pull request commentsourcegraph/lsif-go

Major refactor

I am merging this now without a major version bump so that I can work on some additional low-hanging performance issues (that will be reviewable) before running benchmarks against the old version.

Feel free to look through the new code to see if there are any smells that have been uncovered by the reorganization here.

efritz

comment created time in 2 hours

push eventsourcegraph/lsif-go

Eric Fritz

commit sha 92b4c3a10a13a9f4778afc44db6bca8a287c5ff5

Add missing docs.

view details

push time in 2 hours

push eventsourcegraph/lsif-go

Eric Fritz

commit sha ec013fc8c3d1d87be63a7e43b71a9d70d1112571

Add noProgress flag.

view details

push time in 2 hours

push eventsourcegraph/lsif-go

Eric Fritz

commit sha 5d5061a1aefd637239d3d66cc743db0bc6988b83

Rearrange packages.

view details

push time in 19 hours

push eventsourcegraph/lsif-go

Eric Fritz

commit sha 5972c59ed9261cac25ce107c1e7a7f9593733eeb

Move testdata directory.

view details

push time in a day

push eventsourcegraph/lsif-go

Eric Fritz

commit sha f1c6517b1754dd52af1f01e2434339a113aa6d1f

Remove todo.txt files.

view details

push time in a day

push eventsourcegraph/lsif-go

Eric Fritz

commit sha bd980f246a33d2bc87ec3d71272688a197a442f6

Refactor additional packages.

view details

push time in a day

issue commentsourcegraph/sourcegraph

Code Intelligence 3.19 Tracking issue

Completed 2020/08/03-07

Finished implementation of an API that exposes the auto-index work queue, and a new service (deployable to a compute node outside of k8s) that will run docker images (soon Firecracker VMs) to allow extensible and setup steps and indexer logic during auto-indexing. See the task tracking issue for details.

Had discussions with @daxmc99, @pecigonzalo, @slimsag, and @chayim to talk about deploying the new indexer service. Discussion notes are present in the RFC 199: User code execution in the auto-indexer.

TL;DR:

  • We are going to create a new GCP project so that we have greater isolation between services (we will not need to firewall off subnets, or worry about users gaining access to the GCP API from within an index container). This will also allow us to see a cost breakdown more naturally for these compute resources.
  • We are going to create a terraform config that will set up the node with Weavework Ignite, Firecracker, Docker, etc. This will run the indexer agent as a docker image so that renovate can update the image tag and re-run terraform so we get continuous deployment on this project.
  • We are going to use stackdriver/built-in GCP logs for now.
  • We are going to expose metrics from the indexer agents via public DNS (nothing here is private data). This will allow us to scrape the metrics from the Prometheus server on the cloud cluster.

Planned 2020/08/03-07

Next week I am planning on primarily working through the tasks in the deployment discussion above.

efritz

comment created time in a day

PR opened sourcegraph/lsif-go

Reviewers
Refactor
+2135 -1087

0 comment

30 changed files

pr created time in a day

create barnchsourcegraph/sourcegraph

branch : ef/postgres-experiment

created branch time in a day

push eventsourcegraph/sourcegraph

Eric Fritz

commit sha 75199a91cc0c4e4bad872fb197e738c25e4d1b63

Squash commits.

view details

push time in a day

push eventsourcegraph/sourcegraph

Eric Fritz

commit sha 5766c0aaf7afdf14b667b2401131bec2e3665d14

lskdjf.

view details

Eric Fritz

commit sha 512b180fbb1436f38bbc71951cdb45ce2c28fa90

slkdj.

view details

push time in a day

push eventsourcegraph/sourcegraph

ᴜɴᴋɴᴡᴏɴ

commit sha 459388941f1959a8029ad28ab770dad62669d3c4

authz: always use msResolutionClock (#12757)

view details

Eric Fritz

commit sha 402b61a52ba6a36480eff5e827e963c2482ea7f0

Revert "Revert "codeintel: Internal API proxy (#12691)" (#12728)" (#12758)

view details

Erik Seliger

commit sha 592730d5d91b823cedfd7bd8b65950566648adfd

Add more storybooks for campaigns components (#12761)

view details

Bunny

commit sha 0e0a1b8553838cb4cd1d6e7dd516ea8cbbc9473d

Sync up footer (#12759) * Trying something to get onClick event in... * Removed extra stuff from header * Minor css fixes * Reverse changes from other PR Co-authored-by: aileenrose <aileenrose@users.noreply.github.com>

view details

Eric Fritz

commit sha 44fde753019728bc29eb51936dc9452d88d1d330

Fix default host for SRC_HTTP_ADDR_INTERNAL (#12768)

view details

Erik Seliger

commit sha 455a926e1f3886d4f3705c90948e6dfc8eac023e

Have separate coverage tracking for campaigns (#12765)

view details

Beyang Liu

commit sha 26f84cb9b1211fe870fed818592a9af688114fd3

monitoring: remove gitserver memory usage alert (#12635) gitserver generally uses up all the memory it gets, so alerting on long-term high memory usage is not very useful. This change also fixes a wording issue in provisioning alert solutions. Co-authored-by: Robert Lin <robert@bobheadxi.dev>

view details

ᴜɴᴋɴᴡᴏɴ

commit sha b777022053ccd46b3cbbc6de8bab9e677e17f720

RFC211: list external services allow filtering by user (#12755)

view details

Thorsten Ball

commit sha 6a17cca75c4c45a4de7040d745dff89d30428108

Implement missing methods in changesetResolver and add ChangesetStats (#12753) * Add test for CamaignResolver and changesetsConnectionResolver * Implement ChangesetStats * Check for repository permissions in ChangesetStats * Fix check for ExternalID in changesetResolver * Split up resolver tests * More cleanup * Add more assertions to ChangesetResolver test * Add tests for ChangesetResolver.Diff() * Clean up changesetResolver * Clean up whitespace

view details

Thorsten Ball

commit sha 5290646b5f475515de59a17ae2fed14018433454

Fix documentation for `content:` search keyword (#12777) After I saw @stefanhengl's new `-content:` I was wondering: "wait, how does `content:` work?" So I looked it up and was confused by the example for `content:` that did *not* have a `content:` in it 😄

view details

Robert Lin

commit sha cdd1b7715f8c126e717cb361bda6fa05bbfa34c3

monitoring: encourage silencing, render entry for alerts w/o solutions (#12731)

view details

Ryan Slade

commit sha 8436ad194ddb8624a2b7b3d5acfe54320ca10c02

usagestats: Use context for Redis connections (#12787)

view details

Thorsten Ball

commit sha ec1fc7ba53c2d29f38b7d5842d1f3619acd721b3

Remove noise and boilerplate from campaigns.TestService (#12783)

view details

Thorsten Ball

commit sha 99b5c994e1de9d91c002bdcfc1f7592c2c8ffa52

Fix deletion of expired ChangesetSpecs (#12780) The comments in the code explain what was wrong before: * We tried to delete `CampaignSpecs` before the `ChangesetSpecs`, which would lead to a foreign key constraint violation. * We expired `ChangesetSpecs` that were still attached to a `Changeset`, either as the `PreviousSpec` or the `CurrentSpec`. This commit fixes both issues and fixes #12763.

view details

Erik Seliger

commit sha b4cbefee1953912a01c3d39d671c72e9168dcbdd

Properly return null for empty descriptions on labels (#12770)

view details

ᴜɴᴋɴᴡᴏɴ

commit sha ff5324335c279f777959a5c4dbee0b6f462040ae

external_services: add NoNamespace option to the List method (#12781)

view details

Stefan Hengl

commit sha 2101f23b9e9de8abf953d6e45d5d5c04388718f1

search: facilitate simple searches if globbing is active (#12766)

view details

Eric Fritz

commit sha 2e63de368851f7ce99f70afebd1ec55662c2a25b

workerutil: Make generic store (#12792)

view details

Erik Seliger

commit sha 34ef7c28ee718de52466f5cf603fbe67f771e0f9

Don't load twice if changeset is not scheduled for syncing (#12771) * Don't load twice if changeset is not scheduled for synching Before, an empty preloadedNextSyncAt was not distinguished from not preloaded, and hence we loaded the sync state twice. This fixes it by explicitly passing that a preload was performed. * Add tests for sync resolver

view details

Eric Fritz

commit sha 2e575f0dce79d45bc3d31696510a8ddfc2714660

codeintel: Add mocks for queue client (#12798)

view details

push time in a day

push eventsourcegraph/sourcegraph

Eric Fritz

commit sha 779a3329dbd3e915d76133925cdfef297ad5d3ee

WIP.

view details

push time in a day

push eventsourcegraph/lsif-go

Eric Fritz

commit sha 72e6778fab465de9ba51e909876f9d786e74e9bf

WIP.

view details

push time in a day

pull request commentsourcegraph/src-cli

api: refactor the low level cmd/src GraphQL functionality into a new api package

This is a big change - seems good at a glance but probably won't be able to do an in-depth review. I'm good with this as long as the lsif-upload command still works :p

LawnGnome

comment created time in a day

push eventsourcegraph/lsif-go

Eric Fritz

commit sha d7202c68c2dc914176aca6f2ae0480e895cc6c6d

WIP.

view details

Eric Fritz

commit sha 3c92640061f8169ea0d9077a925c6bc6ab35dd3c

WIP.

view details

push time in a day

issue commentsourcegraph/sourcegraph

Code intel stops working on local instance when sourcegraph can no longer phone home

This is because code intel is provided by Sourcegraph extension, which is served from our public extension registry. Enterprise versions of the product allow you to sync the extensions into a local registry so that it can be run in highly firewalled environments, but requires manual syncing of extensions with the upstream.

PaulMooney56

comment created time in 2 days

push eventsourcegraph/sourcegraph

Eric Fritz

commit sha d464eb231256f1044f303c893143e549632de76e

Set TMPDIR again for indexer.

view details

push time in 2 days

push eventsourcegraph/sourcegraph

Eric Fritz

commit sha c7818d59ee51b1744ea02938da7975e067f3f5bc

Remove TMPDIR from procfile.

view details

push time in 2 days

push eventsourcegraph/sourcegraph

Eric Fritz

commit sha 0f1f2fc0189df676456860aa45fe9f12f3481909

Update test temp dir.

view details

push time in 2 days

push eventsourcegraph/sourcegraph

Erik Seliger

commit sha 07b389060aa4086917b5d956d03e2645f718ee4c

Fix pagination for changesets (#12794) Also moves the calculation of the sync state to the nodes resolver because it's not needed for PageInfo.

view details

Eric Fritz

commit sha 70b5927e190ae26c9d37bbca50f065c243fc79e0

internal API proxy: Remove verb allowlist in gitservice proxy (#12797)

view details

Eric Fritz

commit sha c2159f2f4867ce4499027fabe831404e6d2a2bb6

codeintel: Add disable indexer flag (#12800)

view details

Eric Fritz

commit sha 1bbc4dad942175784a02b9a2dce6faad13b59724

Merge branch 'main' into rfc199-indexer-vm

view details

push time in 2 days

push eventsourcegraph/sourcegraph

Eric Fritz

commit sha c2159f2f4867ce4499027fabe831404e6d2a2bb6

codeintel: Add disable indexer flag (#12800)

view details

push time in 2 days

delete branch sourcegraph/sourcegraph

delete branch : ef/disable-indexer-flag

delete time in 2 days

PR merged sourcegraph/sourcegraph

Reviewers
codeintel: Add disable indexer flag RFC-199 team/code-intelligence

Once we deploy the VM-based indexer, we'll need to ensure that we're not continuing to process indexes inside the cluster. This flag will help us in this transition:

  • Process all indexes within cluster
  • Deploy new VM-based service
  • Disable indexing within cluster
  • Start new VM-based service
  • Check health; reset flag on issues, continue if the new service works well
  • Remove in-cluster index code
+8 -1

0 comment

2 changed files

efritz

pr closed time in 2 days

push eventsourcegraph/sourcegraph

Eric Fritz

commit sha 70b5927e190ae26c9d37bbca50f065c243fc79e0

internal API proxy: Remove verb allowlist in gitservice proxy (#12797)

view details

push time in 2 days

delete branch sourcegraph/sourcegraph

delete branch : ef/internal-proxy-gitservice-http-verbs

delete time in 2 days

PR merged sourcegraph/sourcegraph

Reviewers
internal API proxy: Remove verb allowlist in gitservice proxy RFC-199 team/code-intelligence

These methods require more than GET, turns out.

+3 -4

0 comment

1 changed file

efritz

pr closed time in 2 days

push eventsourcegraph/sourcegraph

Erik Seliger

commit sha 34ef7c28ee718de52466f5cf603fbe67f771e0f9

Don't load twice if changeset is not scheduled for syncing (#12771) * Don't load twice if changeset is not scheduled for synching Before, an empty preloadedNextSyncAt was not distinguished from not preloaded, and hence we loaded the sync state twice. This fixes it by explicitly passing that a preload was performed. * Add tests for sync resolver

view details

Eric Fritz

commit sha 2e575f0dce79d45bc3d31696510a8ddfc2714660

codeintel: Add mocks for queue client (#12798)

view details

Erik Seliger

commit sha 56748daed9f0cee2b6e53eacac7d4b136f72274d

Add test for label resolver with empty description (#12790)

view details

Eric Fritz

commit sha 6b4e1b80fbf5d5de70a637bd0d3e40d6daf89c3e

Squash commits.

view details

push time in 2 days

push eventsourcegraph/sourcegraph

Eric Fritz

commit sha 2e575f0dce79d45bc3d31696510a8ddfc2714660

codeintel: Add mocks for queue client (#12798)

view details

push time in 2 days

delete branch sourcegraph/sourcegraph

delete branch : ef/queue-client-mocks

delete time in 2 days

PR merged sourcegraph/sourcegraph

Reviewers
codeintel: Add mocks for queue client RFC-199 team/code-intelligence
+389 -0

0 comment

2 changed files

efritz

pr closed time in 2 days

PR opened sourcegraph/sourcegraph

Reviewers
codeintel: Add disable indexer flag RFC-199 team/code-intelligence

Once we deploy the VM-based indexer, we'll need to ensure that we're not continuing to process indexes inside the cluster. This flag will help us in this transition:

  • Process all indexes within cluster
  • Deploy new VM-based service
  • Disable indexing within cluster
  • Start new VM-based service
  • Check health; reset flag on issues, continue if the new service works well
  • Remove in-cluster index code
+8 -1

0 comment

2 changed files

pr created time in 2 days

create barnchsourcegraph/sourcegraph

branch : ef/disable-indexer-flag

created branch time in 2 days

push eventsourcegraph/sourcegraph

Eric Fritz

commit sha c173aed3d74543a989348212aed303bff274a32c

Add precise-code-intel-indexer-vm service.

view details

push time in 2 days

PR opened sourcegraph/sourcegraph

Reviewers
Codeintel: Add mocks for queue client
+389 -0

0 comment

2 changed files

pr created time in 2 days

PR opened sourcegraph/sourcegraph

internal API proxy: Remove verb allowlist in gitservice proxy

These methods require more than GET, turns out.

+3 -4

0 comment

1 changed file

pr created time in 2 days

create barnchsourcegraph/sourcegraph

branch : ef/queue-client-mocks

created branch time in 2 days

PR opened sourcegraph/sourcegraph

Collapse worker handler and processor.

<!-- Reminder: Have you updated the changelog and relevant docs (user docs, architecture diagram, etc) ? -->

+94 -263

0 comment

5 changed files

pr created time in 2 days

create barnchsourcegraph/sourcegraph

branch : ef/refactor-worker-handler

created branch time in 2 days

push eventsourcegraph/sourcegraph

Eric Fritz

commit sha 86855efcf5ea0c259e86a7c74c598a366b2ce803

Squash commits.

view details

push time in 2 days

push eventsourcegraph/sourcegraph

Eric Fritz

commit sha 34524e63816c3aa506f7f118d093adb0d4d55af4

wip.

view details

push time in 2 days

push eventsourcegraph/sourcegraph

Eric Fritz

commit sha 374958133aa877388680c28398739f0c6b5459b4

Go mod tidy.

view details

push time in 2 days

push eventsourcegraph/sourcegraph

Stefan Hengl

commit sha 2101f23b9e9de8abf953d6e45d5d5c04388718f1

search: facilitate simple searches if globbing is active (#12766)

view details

Eric Fritz

commit sha 2e63de368851f7ce99f70afebd1ec55662c2a25b

workerutil: Make generic store (#12792)

view details

Eric Fritz

commit sha 2f02c97c4b031f4e053a2aaa144f66e2daf71fd6

Merge branch 'main' into rfc199-indexer-vm

view details

push time in 2 days

push eventsourcegraph/sourcegraph

Eric Fritz

commit sha 2e63de368851f7ce99f70afebd1ec55662c2a25b

workerutil: Make generic store (#12792)

view details

push time in 2 days

delete branch sourcegraph/sourcegraph

delete branch : ef/generic-worker-store

delete time in 2 days

PR merged sourcegraph/sourcegraph

Reviewers
workerutil: Make generic store

When implementing the VM-based code intel indexer (progress in https://github.com/sourcegraph/sourcegraph/pull/12723), I realized that I needed to copy all of the functionality of the workerutil Worker but targeting a different non-database persistence layer (it polls an API rather than Postgres).

This PR moves some code around to make it possible to supply small "shims" around persistence layers for use by the worker.

Summary of changes:

  • Create a more generic "Handler" and "Store" interface in the workerutil package. The handler changes only in the type of the (transactional) store argument it accepts, and the store is a subset of the database store that's used by the worker.
  • Move the store and database-specific handlers into a dbworker package.
  • Create a "refined" handler and store for the database layer.
  • Add small shims to translate db handler into a generic handler, and a generic store into a db store.
  • Update uses (code intel worker and indexer; campaigns reconciler)
+1328 -844

0 comment

37 changed files

efritz

pr closed time in 2 days

push eventsourcegraph/sourcegraph

Eric Fritz

commit sha 697ece426c0561c05175ee536472117b347dd1af

Update comments.

view details

push time in 2 days

Pull request review commentsourcegraph/sourcegraph

workerutil: Make generic store

 func (s *store) Transact(ctx context.Context) (*store, error) { // transaction. // // The supplied conditions may use the alias provided in `ViewName`, if one was supplied.-func (s *store) Dequeue(ctx context.Context, conditions []*sqlf.Query) (record Record, _ Store, exists bool, err error) {+func (s *store) Dequeue(ctx context.Context, conditions []*sqlf.Query) (record workerutil.Record, _ Store, exists bool, err error) { 	return s.dequeue(ctx, conditions, false) }  // DequeueWithIndependentTransactionContext is like Dequeue, but will use a context.Background() for the underlying // transaction context. This method allows the transaction to lexically outlive the code in which it was created. This // is useful if a longer-running transaction is managed explicitly bewteen multiple goroutines.-func (s *store) DequeueWithIndependentTransactionContext(ctx context.Context, conditions []*sqlf.Query) (Record, Store, bool, error) {+func (s *store) DequeueWithIndependentTransactionContext(ctx context.Context, conditions []*sqlf.Query) (workerutil.Record, Store, bool, error) { 	return s.dequeue(ctx, conditions, true) } -func (s *store) dequeue(ctx context.Context, conditions []*sqlf.Query, independentTxCtx bool) (record Record, _ Store, exists bool, err error) {+func (s *store) dequeue(ctx context.Context, conditions []*sqlf.Query, independentTxCtx bool) (record workerutil.Record, _ Store, exists bool, err error) { 	if s.InTransaction() { 		return nil, nil, false, ErrDequeueTransaction 	} +	txCtx := ctx

Note: This is the only change of the worker implementation, which is a fix of the context value given in Transact.

efritz

comment created time in 2 days

create barnchsourcegraph/sourcegraph

branch : ef/generic-worker-store

created branch time in 2 days

push eventsourcegraph/sourcegraph

Eric Fritz

commit sha 97ee8f61505c0965dea71a8ae6c2c06fd829b872

Run gofmt.

view details

push time in 2 days

push eventsourcegraph/sourcegraph

Erik Seliger

commit sha 455a926e1f3886d4f3705c90948e6dfc8eac023e

Have separate coverage tracking for campaigns (#12765)

view details

Beyang Liu

commit sha 26f84cb9b1211fe870fed818592a9af688114fd3

monitoring: remove gitserver memory usage alert (#12635) gitserver generally uses up all the memory it gets, so alerting on long-term high memory usage is not very useful. This change also fixes a wording issue in provisioning alert solutions. Co-authored-by: Robert Lin <robert@bobheadxi.dev>

view details

ᴜɴᴋɴᴡᴏɴ

commit sha b777022053ccd46b3cbbc6de8bab9e677e17f720

RFC211: list external services allow filtering by user (#12755)

view details

Thorsten Ball

commit sha 6a17cca75c4c45a4de7040d745dff89d30428108

Implement missing methods in changesetResolver and add ChangesetStats (#12753) * Add test for CamaignResolver and changesetsConnectionResolver * Implement ChangesetStats * Check for repository permissions in ChangesetStats * Fix check for ExternalID in changesetResolver * Split up resolver tests * More cleanup * Add more assertions to ChangesetResolver test * Add tests for ChangesetResolver.Diff() * Clean up changesetResolver * Clean up whitespace

view details

Thorsten Ball

commit sha 5290646b5f475515de59a17ae2fed14018433454

Fix documentation for `content:` search keyword (#12777) After I saw @stefanhengl's new `-content:` I was wondering: "wait, how does `content:` work?" So I looked it up and was confused by the example for `content:` that did *not* have a `content:` in it 😄

view details

Robert Lin

commit sha cdd1b7715f8c126e717cb361bda6fa05bbfa34c3

monitoring: encourage silencing, render entry for alerts w/o solutions (#12731)

view details

Ryan Slade

commit sha 8436ad194ddb8624a2b7b3d5acfe54320ca10c02

usagestats: Use context for Redis connections (#12787)

view details

Thorsten Ball

commit sha ec1fc7ba53c2d29f38b7d5842d1f3619acd721b3

Remove noise and boilerplate from campaigns.TestService (#12783)

view details

Thorsten Ball

commit sha 99b5c994e1de9d91c002bdcfc1f7592c2c8ffa52

Fix deletion of expired ChangesetSpecs (#12780) The comments in the code explain what was wrong before: * We tried to delete `CampaignSpecs` before the `ChangesetSpecs`, which would lead to a foreign key constraint violation. * We expired `ChangesetSpecs` that were still attached to a `Changeset`, either as the `PreviousSpec` or the `CurrentSpec`. This commit fixes both issues and fixes #12763.

view details

Erik Seliger

commit sha b4cbefee1953912a01c3d39d671c72e9168dcbdd

Properly return null for empty descriptions on labels (#12770)

view details

ᴜɴᴋɴᴡᴏɴ

commit sha ff5324335c279f777959a5c4dbee0b6f462040ae

external_services: add NoNamespace option to the List method (#12781)

view details

Eric Fritz

commit sha 2cadec9c357bf4e43fc4bd6a42f6c15aa117ea33

Merge branch 'main' into rfc199-indexer-vm

view details

push time in 2 days

push eventsourcegraph/sourcegraph

Eric Fritz

commit sha 061225fc7bd17257f9b4002122de66481b66d9a3

WIP.

view details

Eric Fritz

commit sha 875a6c94b8522baca8d852c50af826e1a39a22a8

WIP.

view details

push time in 2 days

push eventsourcegraph/sourcegraph

Bunny

commit sha 0e0a1b8553838cb4cd1d6e7dd516ea8cbbc9473d

Sync up footer (#12759) * Trying something to get onClick event in... * Removed extra stuff from header * Minor css fixes * Reverse changes from other PR Co-authored-by: aileenrose <aileenrose@users.noreply.github.com>

view details

Eric Fritz

commit sha 44fde753019728bc29eb51936dc9452d88d1d330

Fix default host for SRC_HTTP_ADDR_INTERNAL (#12768)

view details

Eric Fritz

commit sha 7fed4c5e8843f3f69b8f9eb3f3d08b47b113be86

Merge branch 'main' into rfc199-indexer-vm

view details

push time in 3 days

push eventsourcegraph/sourcegraph

Eric Fritz

commit sha 34432f1f459305835eb7430ba86dbabf3d740347

Add tests.

view details

Eric Fritz

commit sha c932dd7a74cb05f478f1b1c94a12c30f25ba12e0

Fix typo.

view details

Eric Fritz

commit sha fa7b208b6d81654451f02e61929833636ec1c958

Fix typos in workerutil.

view details

Eric Fritz

commit sha 628ab3cc3a076991ea465f91d755fb8d27ad4c53

Add mocks for queue client.

view details

Eric Fritz

commit sha 7fa62e0c000f39488c2310318c08adeca8c151d4

Disable flake.

view details

push time in 3 days

push eventsourcegraph/sourcegraph

Eric Fritz

commit sha 44fde753019728bc29eb51936dc9452d88d1d330

Fix default host for SRC_HTTP_ADDR_INTERNAL (#12768)

view details

push time in 3 days

delete branch sourcegraph/sourcegraph

delete branch : ef/fix-http-addr-internal-listen-host

delete time in 3 days

PR merged sourcegraph/sourcegraph

Fix default host for SRC_HTTP_ADDR_INTERNAL

localhost makes the container inaccessible outside of a container, which makes the frontends unreachable from other services in the cloud instance.

This makes it accessible everywhere serving from the current host. See https://github.com/sourcegraph/sourcegraph/pull/12758 and the chain of discussion ending there.

+1 -1

0 comment

1 changed file

efritz

pr closed time in 3 days

PR opened sourcegraph/sourcegraph

Fix default host for SRC_HTTP_ADDR_INTERNAL

localhost makes the container inaccessible outside of a container, which makes the frontends unreachable from other services in the cloud instance.

This makes it accessible everywhere serving from the current host.

+1 -1

0 comment

1 changed file

pr created time in 3 days

create barnchsourcegraph/sourcegraph

branch : ef/fix-http-addr-internal-listen-host

created branch time in 3 days

issue closedsourcegraph/sourcegraph

Show reference one line below

  • Sourcegraph version: sourcegraph.com
  • Platform information: latest Firefox and Chrome on Linux(Ubuntu 19.04) and Windows 10

Steps to reproduce:

Visit here

Expected behavior:

show reference under a cursor

Actual behavior:

show reference one line below the line under a cursor Screenshot from 2019-04-29 12-40-48

closed time in 3 days

JP3BGY

issue commentsourcegraph/sourcegraph

Show reference one line below

Unable to reproduce this issue, closing for now, please re-open if this is not the case.

JP3BGY

comment created time in 3 days

issue commentsourcegraph/sourcegraph

Query definition and hover provider so we can correctly badge results

@hitzhangjie We had someone else report the same issue and this is fixed in https://github.com/sourcegraph/code-intel-extensions/pull/453. Sorry for the trouble!

efritz

comment created time in 3 days

push eventsourcegraph/code-intel-extensions

Eric Fritz

commit sha 9d1b3a1fdf337698e14a5afdd56eed9451bded94

Fix promise resolution in noop combined providers (#453)

view details

push time in 3 days

delete branch sourcegraph/code-intel-extensions

delete branch : fix-noop-combined-providers

delete time in 3 days

PR merged sourcegraph/code-intel-extensions

Reviewers
Fix promise resolution in noop combined providers

The noop definitionAndHover provider did not resolve, which made it block on all hover and definition requests for instances without LSIF providers enabled.

+1 -1

0 comment

1 changed file

efritz

pr closed time in 3 days

PR opened sourcegraph/code-intel-extensions

Fix promise resolution in noop combined providers

The noop definitionAndHover provider did not resolve, which made it block on all hover and definition requests for instances without LSIF providers enabled.

+1 -1

0 comment

1 changed file

pr created time in 3 days

create barnchsourcegraph/code-intel-extensions

branch : fix-noop-combined-providers

created branch time in 3 days

push eventsourcegraph/sourcegraph

Rijnard van Tonder

commit sha 8b3e06bfb4af0b5c0881b7a490af3cd2a4c75d50

web: highlight search operators and/or/not (#12694)

view details

Stephen Gutekanst

commit sha fd165c8993196c050f2c33e9be739dbfa1743346

Revert "codeintel: Internal API proxy (#12691)" (#12728) This reverts commit 948c70bc63dca2818242f04ee1634f7729d9ca17.

view details

Robert Lin

commit sha 404914aae205bc7f99df4c958eda30d74485be60

monitoring: improve wording and formatting of prometheus, kubernetes (#12729)

view details

Robert Lin

commit sha 19bad5eb6ad4d263c366a80c9d86d026d07423b2

monitoring: set long-term provisioning alerts to 14d (#12730)

view details

Rijnard van Tonder

commit sha 77524f7c1f796dd45d7a0c275d27b4d8e48efce5

search: filter out noisy inputs used in diff testing (#12734)

view details

Keegan Carruthers-Smith

commit sha b773625e95073d7b10f1ff706ade2584a0e18772

dev: support switching our default branch to main (#11453) This mostly updates our dev CI/helpers which hardcoded master to instead hardcode main. In the case of CI we treat both main and master as the default branch.

view details

Thorsten Ball

commit sha d5394d3c046b46433b17fa31311525216c7e5b8c

Use static lists of columns in campaigns.Store methods (#12714) * Remove repetition of column names in store changeset methods * Use lists of columns in campaigns store

view details

Ryan Slade

commit sha 55116953b64e2542fa70438858bc30320e25a88c

db: Add last_sync_at, next_sync_at and namespace_user_id (#12713) * Add last_sync_at and next_sync_at to external services * Update repo store * Add new columns to ExternalService in api and types * Add namespace_user_id to external_services * Populate NamespaceUserID on external service types * Regenerate db schema

view details

ᴜɴᴋɴᴡᴏɴ

commit sha 459388941f1959a8029ad28ab770dad62669d3c4

authz: always use msResolutionClock (#12757)

view details

Eric Fritz

commit sha 402b61a52ba6a36480eff5e827e963c2482ea7f0

Revert "Revert "codeintel: Internal API proxy (#12691)" (#12728)" (#12758)

view details

Erik Seliger

commit sha 592730d5d91b823cedfd7bd8b65950566648adfd

Add more storybooks for campaigns components (#12761)

view details

Eric Fritz

commit sha 7ade63bf497ecc7ac56b8162f93c23c2ebee1d9d

Merge branch 'main' into rfc199-indexer-vm

view details

push time in 3 days

push eventsourcegraph/lsif-go

Eric Fritz

commit sha 2fd8e5b03a626d9afb22bb2002f4072905bccdf9

WIP.

view details

push time in 3 days

PR opened sourcegraph/sourcegraph

experiment: Replace SQLite with Scylladb

<!-- Reminder: Have you updated the changelog and relevant docs (user docs, architecture diagram, etc) ? -->

+755 -33

0 comment

16 changed files

pr created time in 3 days

create barnchsourcegraph/sourcegraph

branch : ef/scylladb-experiment

created branch time in 3 days

push eventsourcegraph/sourcegraph

Eric Fritz

commit sha 402b61a52ba6a36480eff5e827e963c2482ea7f0

Revert "Revert "codeintel: Internal API proxy (#12691)" (#12728)" (#12758)

view details

push time in 3 days

delete branch sourcegraph/sourcegraph

delete branch : revert-revert-12691

delete time in 3 days

PR merged sourcegraph/sourcegraph

Reviewers
Revert "Revert "codeintel: Internal API proxy (#12691)" (#12728)"

See https://github.com/sourcegraph/sourcegraph/pull/12728.

+419 -17

1 comment

9 changed files

efritz

pr closed time in 3 days

push eventsourcegraph/sourcegraph

Eric Fritz

commit sha 966ed637fd99de4fba837e6519216822ccc8fbb6

Appease localhost guard.

view details

push time in 3 days

PR opened sourcegraph/sourcegraph

Reviewers
Revert "Revert "codeintel: Internal API proxy (#12691)" (#12728)"

See https://github.com/sourcegraph/sourcegraph/pull/12728.

+415 -17

0 comment

9 changed files

pr created time in 3 days

create barnchsourcegraph/sourcegraph

branch : revert-revert-12691

created branch time in 3 days

PR opened sourcegraph/sourcegraph

WIP.

<!-- Reminder: Have you updated the changelog and relevant docs (user docs, architecture diagram, etc) ? -->

+601 -9

0 comment

20 changed files

pr created time in 4 days

create barnchsourcegraph/sourcegraph

branch : rfc199-indexer-vm

created branch time in 4 days

push eventsourcegraph/sourcegraph

Eric Fritz

commit sha 948c70bc63dca2818242f04ee1634f7729d9ca17

codeintel: Internal API proxy (#12691)

view details

push time in 4 days

delete branch sourcegraph/sourcegraph

delete branch : rfc199-codeintel-internal-proxy

delete time in 4 days

PR merged sourcegraph/sourcegraph

Reviewers
codeintel: Internal API proxy team/code-intelligence

This PR implements part of RFC 199: User code execution in the auto-indexer and closes https://github.com/sourcegraph/sourcegraph/issues/12666.

This PR adds a token-authenticated set of routes in the internally exposed frontend API that will perform requests to select routes on gitserver and to the precise-code-intel-indexer API introduced in https://github.com/sourcegraph/sourcegraph/pull/12657.

Things of note: we are planning on having the precise-code-intel-indexer that runs Firecracker VMs to be completely firewalled off from the rest of the application so that code running within the VMs cannot reach internal-only APIs and exfiltrate or modify data. This requires that all of the APIs required by the indexer be authenticated via shared tokens, and be exposed as part of the client/public-internet facing surface of Sourcegraph. Additionally, we cannot simply reverse proxy as the built-in support for reverse proxying in Go is fairly poor when supporting HTTP 307 responses with a POST request. We cannot simply return a Location header to an internal API, as that's useless for the firewalled service.

Additional note: I have a TODO in there about tracing requests. I plan to make an httputil package that will consolidate some of the tracing/observation logic that's pretty much copy-pasted in the queue index, bundle manager, and internal proxy client. Other existing clients can make use of this over time as well.

+415 -17

5 comments

9 changed files

efritz

pr closed time in 4 days

issue closedsourcegraph/sourcegraph

RFC 199: Expose internal routes for the indexer

The new indexer service will be deployed outside of the k8s cluster which means that it will not have access to the APIs that it needs out of the box.

We need to create a shared-token-authenticated proxy in the external frontend API that allows requests to a small set of gitserver endopints (for project cloning), as well as the index queue API defined in https://github.com/sourcegraph/sourcegraph/issues/12664.

See this slack thread for additional context.

closed time in 4 days

efritz

push eventsourcegraph/sourcegraph

Eric Fritz

commit sha b9d59b8cd49ce5b622bd85da5278c5a1cf869688

Ensure internal proxy handler envvars are not required.

view details

push time in 4 days

create barnchsourcegraph/lsif-go

branch : ef/refactor

created branch time in 4 days

push eventsourcegraph/sourcegraph

Eric Fritz

commit sha 4376e627921cdd7371193118094fc43bc9f53a00

Remove default.

view details

push time in 4 days

push eventsourcegraph/sourcegraph

Thorsten Ball

commit sha 67afca6be2afb716aa48d4601b6fda08dc5e030c

Various small fixes for the campaigns.Store (#12710) * Remove unused Store.TryAcquireAdvisoryLock We don't need this method anymore and if we need support for locks again we can simply use `basestore.Store` which we already use. * Remove debug print * Remove wrapper UpdateChangesets/CreateChangesets (plural) methods Before we loosened the constraints on the `changesets` table these methods did batch-insert and batch-update in a single database query. Since that's not needed (nor that easy) anymore, we can remove these methods, since they only provide syntactic sugar for a few usecases. If we decide we need the syntactic sugar back, we can re-add them. * Fix missing references

view details

Stefan Hengl

commit sha 0346923df298d344d167465e0e1eeae8773f4e95

search: treat * at pattern borders properly (#12697)

view details

Dax McDonald

commit sha 7292502dcb17365c036042db5d8be4404da0f91b

Set env var for reviewdog (#12717)

view details

Dax McDonald

commit sha 12b19de8e8752070590c8f4eba24a1b6b9e3ecba

Update Troubleshooting for nvm versions (#12687)

view details

Thorsten Ball

commit sha dd120b19c146c944ebe69cdf0f23ca2cbba25f9a

Check for publicationState/reconcilerState in permission tests (#12715)

view details

Thorsten Ball

commit sha d88a09359b6d0e62bd65d73f25306d3354a43d84

Fix 'template inlines' CI check (#12703) Looks like this has been broken for a while. Funnily enough: CI didn't break.

view details

Erik Seliger

commit sha 8ba77eedca480704eef549f352f60da0ee50128c

Update outdated note on GitLab support (#12719)

view details

Bunny

commit sha d142f1ef4b99fe2b0de892b72405641f75865a4d

Updated the logo (#12540) * Updated the logo * New-new logo from Victoria

view details

Felix Becker

commit sha 75188c68d0d68f0f958be7a611641debe4d8d449

Remove prepublish script (#12702)

view details

Adam Harvey

commit sha d474539c90befcb1851c315f3bb7032c75a37d5b

campaigns: add GitLab webhook support (#12139) Co-authored-by: Erik Seliger <erikseliger@me.com>

view details

TJ Kandala

commit sha 53339e93a17b7934abf3bc4aae3565c15a0631a9

Stop word-count extension from breaking extensions and command palette (#12573) * swallow errors for all types of extension contributions

view details

Eric Fritz

commit sha 39c940b00a63185e21e6b5c04f5f5d897d1159d9

Merge branch 'master' into rfc199-codeintel-internal-proxy

view details

push time in 4 days

more