profile
viewpoint

startedmojaloop/documentation

started time in 7 days

startedspring-projects/spring-framework

started time in 7 days

startedcheckstyle/contribution

started time in 7 days

startedplougher/squashfs-tools

started time in 11 days

startedgithub/webauthn-json

started time in 11 days

startedOpenSC/OpenSC

started time in 13 days

startedwereturtle/ghostwriter

started time in 13 days

created repositoryvorburger/LearningGradle

https://docs.gradle.org

created time in 15 days

startedAlexey1Gavrilov/ExpectIt

started time in 20 days

startedjbangdev/jbang

started time in 20 days

fork vorburger/jbang

Unleash the power of Java for shell scripting

https://jbang.dev

fork in 21 days

push eventpatternfly/patternfly-react

Renovate Bot

commit sha 497acc3a2a8614ecb37049e6963dcc6a03304305

chore(deps): update dependency @patternfly/patternfly to v4.65.1

view details

push time in 24 days

push eventpatternfly/patternfly-react

Joachim

commit sha 47c5f6e3b8fb749e52325267548c22d72f56c24b

add virtualized examples with composable components (#5122) * add virtualized examples with composable components * spelling * fix first example * remove export * remove comment that causes AST issue

view details

Renovate Bot

commit sha fe53d9381692ee083ee2795e16f28ea613a9013a

chore(deps): update dependency @patternfly/patternfly to v4.64.0

view details

push time in 24 days

pull request commentpatternfly/patternfly-react

feat(packages): upgrade victory package and remove all victory- dependencies

Codecov Report

Merging #5116 (cb90dd8) into master (47c5f6e) will decrease coverage by 0.03%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5116      +/-   ##
==========================================
- Coverage   52.90%   52.86%   -0.04%     
==========================================
  Files         562      562              
  Lines       10317    10324       +7     
  Branches     3857     3862       +5     
==========================================
  Hits         5458     5458              
- Misses       4168     4173       +5     
- Partials      691      693       +2     
Flag Coverage Δ
patternfly4 52.86% <0.00%> (-0.04%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...eact-charts/src/components/ChartAxis/ChartAxis.tsx 88.88% <ø> (ø)
...c/components/ChartBullet/ChartBulletGroupTitle.tsx 83.33% <ø> (ø)
...mponents/ChartCursorTooltip/ChartCursorTooltip.tsx 80.95% <ø> (ø)
...ts/ChartDonutUtilization/ChartDonutUtilization.tsx 61.53% <0.00%> (-5.13%) :arrow_down:
...mponents/ChartLegendTooltip/ChartLegendTooltip.tsx 82.14% <0.00%> (-6.32%) :arrow_down:
...s/ChartLegendTooltip/ChartLegendTooltipContent.tsx 58.69% <0.00%> (ø)
...harts/src/components/ChartTooltip/ChartTooltip.tsx 100.00% <ø> (ø)
...ct-charts/src/components/ChartUtils/chart-theme.ts 57.74% <0.00%> (ø)
...-charts/src/components/ChartUtils/chart-tooltip.ts 41.48% <0.00%> (-0.45%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 47c5f6e...cb90dd8. Read the comment docs.

DaoDaoNoCode

comment created time in 24 days

pull request commentpatternfly/patternfly-react

feat(packages): upgrade victory package and remove all victory- dependencies

PF4 preview: https://patternfly-react-pr-5116.surge.sh

DaoDaoNoCode

comment created time in 24 days

Pull request review commentpatternfly/patternfly-react

feat(packages): upgrade victory package and remove all victory- dependencies

 export const ChartDonutUtilization: React.FunctionComponent<ChartDonutUtilizatio       const donutThresholds = getDonutThresholds();       const mergeThemeProps = (i: number) => {         // Merge just the first color of dynamic (blue, green, etc.) with static (gray) for expected colorScale-        newTheme.pie.colorScale[0] = donutThresholds[i].color;-        newTheme.legend.colorScale[0] = donutThresholds[i].color;+        if (newTheme.pie.colorScale instanceof Array) {

Created https://github.com/patternfly/patternfly-react/issues/5129 to address the colorScale proper type.

DaoDaoNoCode

comment created time in 24 days

issue openedpatternfly/patternfly-react

Charts: colorScale type is incorrect

The chart colorScale props use Victory's ColorScalePropType type, which was previously defined as a string array. The ColorScalePropType type is now defined as:

"grayscale", "qualitative", "heatmap", "warm", "cool", "red", "green", "blue" | string[]

PatternFly charts will never use the color string types as they only have meaning for Victory's 'material' and 'grayscale' themes.

We should change our colorScale type to be string[] and update the property description to reflect that.

Note: It may be possible to override the ColorScalePropType type via src/types/victory.d.ts?

created time in 24 days

push eventpatternfly/patternfly-react

Joachim

commit sha 47c5f6e3b8fb749e52325267548c22d72f56c24b

add virtualized examples with composable components (#5122) * add virtualized examples with composable components * spelling * fix first example * remove export * remove comment that causes AST issue

view details

push time in 24 days

PR merged patternfly/patternfly-react

add virtualized examples with composable components

Add an example each for virtualized table and window scrolling virtualized table using the composable table components https://patternfly-react-pr-5122.surge.sh/extensions/virtual-scroll-table#using-composable-table-components https://patternfly-react-pr-5122.surge.sh/extensions/virtual-scroll-window-scroller/#using-composable-table-components

+283 -53

1 comment

4 changed files

jschuler

pr closed time in 24 days

pull request commentpatternfly/patternfly-react

WIP (fix)TreeView: fix various bugs

PF4 preview: https://patternfly-react-pr-5128.surge.sh

tlabaj

comment created time in 24 days

pull request commentpatternfly/patternfly-react

feat(DualListSelector): add new component

@mcarrano In the second example I was just demonstrating that the default status can be overwritten and consumer defined. By default it behaves like the first example

Can we note/document that as part of the example then? In looking at this, not sure I'd understand why the text is different. Maybe even just rename the example "Custom header with filter" or something like that?

nicolethoen

comment created time in 24 days

PR opened patternfly/patternfly-react

Reviewers
WIP (fix)TreeView: fix various bugs

<!-- What changes are being made? Please link the issue being addressed. --> What: Closes #4872 This is a work in progress. The checkbox variation still needs updates for the toggle. It will need to be a button. Once core u[dates this, we can updates the PR. There is also an issue with the toggle icon when the node is expanded. <!-- Are there any upstream issues or separate issues you need to reference? --> Additional issues:

+2215 -1854

0 comment

2 changed files

pr created time in 24 days

pull request commentpatternfly/patternfly-react

fix(datepicker): add calendar component

@redallen @mcoker @jessiehuff I've scheduled some time for tomorrow for us all to talk through this together. I get that there are not easy or straight forward answers, but I want to take the time to get it right. I'm looking at the implementation done in Carbon that behaves like I'd expect: https://react.carbondesignsystem.com/?path=/story/datepicker--single Perhaps we can model off that?

Regarding the confusion between the focus and hover states, I looked back at the prior implementation and we did have a different hover state as I'm showing here:

Screen Shot 2020-11-11 at 5 11 04 PM

@mcoker did we loose that in the CSS in this iteration?

cc @evwilkin

redallen

comment created time in 24 days

push eventpatternfly/patternfly-react

Jessie

commit sha 21a343deedf3c30f6dc63f34b23f10cf93103611

Update disabled dropdown items (#5044) * Update disabled dropdown items * Trying tabindex * Alter attributes * Add to focus order * Update snapshots and tests * Update cypress tests * Add ability to customize inoperable events * Update cypress tests * Create prevent events util

view details

Renovate Bot

commit sha 5d75515561927c55db844a2b54d495f9327828f3

chore(deps): update dependency @patternfly/patternfly to v4.63.0

view details

push time in 24 days

issue openedpatternfly/patternfly-react

Tooltips on disabled actions in react-table

Describe the issue. What is the expected and unexpected behavior? I have a use case where I would like to disable an action in the action's dropdown on a Table row and display a tooltip on why it is disabled. Looking through similar issues, mainly #2470 and #4581, the workaround for standard DropDownItems is to wrap the it in a tooltip; this is not viable because the Table is generating the DropDownItems.

Please provide the steps to reproduce. Feel free to link CodeSandbox or another tool. Passing tooltip will display the tool tip, as long as the action isn't diabled. Passing isDisabled will create the desired button behavoir but will also disable the tooltip.

Is this a bug or enhancement? If this issue is a bug, is this issue blocking you or is there a work-around? Bug, Blocking.

created time in 24 days

pull request commentpatternfly/patternfly-react

feat(DualListSelector): add new component

@evwilkin nice catch on the second note. that's my bad. as far as the background color - I think that's because the button still has focus after you deselect it. so the grey background is a result of the focus being on the item even though it's been deselected. @mcoker do you know if that's an implementation problem on my end? or is that a css issue as far you can tell?

nicolethoen

comment created time in 24 days

Pull request review commentpatternfly/patternfly-react

feat(DualListSelector): add new component

+---+id: Dual list selector+section: components+cssPrefix: 'pf-c-dual-list-selector'+propComponents: ['DualListSelector']+beta: true+---++import PficonSortCommonDescIcon from '@patternfly/react-icons/dist/js/icons/pficon-sort-common-desc-icon';+import PficonSortCommonAscIcon from '@patternfly/react-icons/dist/js/icons/pficon-sort-common-asc-icon';++## Examples++### Basic++```js+import React from 'react';+import { +  DualListSelector+} from '@patternfly/react-core';++class BasicDualListSelector extends React.Component {+  constructor(props) {+    super(props);+    this.state = {+      availableOptions: ['Option 1', 'Option 2', 'Option 3', 'Option 4'],+      chosenOptions: []+    }+  }+  +  render() {+    return (+      <DualListSelector+        availableOptions={this.state.availableOptions}+        chosenOptions={this.state.chosenOptions}+      />+    );+  }+}++```++### Basic with actions++```js+import React from 'react';+import { +  Button,+  ButtonVariant,+  Dropdown,+  DropdownItem,+  DualListSelector,+  KebabToggle+} from '@patternfly/react-core';+import PficonSortCommonDescIcon from '@patternfly/react-icons/dist/js/icons/pficon-sort-common-desc-icon';+import PficonSortCommonAscIcon from '@patternfly/react-icons/dist/js/icons/pficon-sort-common-asc-icon';++class ManagedDualListSelector extends React.Component {+  constructor(props) {+    super(props);+    this.state = {+      availableOptions: [+        <span>Option 1</span>, +        <span>Option 2</span>, +        <span>Option 3</span>, +        <span>Option 4</span>+      ],+      chosenOptions: [],+      isAvailableKebabOpen: false,+      availableDescending: true,+      isChosenKebabOpen: false,+      chosenDescending: true+    };+    +    this.onSort = (panel) => {+      if (panel === 'available') {+        this.setState(prevState => {+          const available = prevState.availableOptions.sort((a, b) => {+            let returnValue = 0;+            if (a.props.children > b.props.children) returnValue = -1;+            if (a.props.children < b.props.children) returnValue = 1;+            if (prevState.availableDescending) returnValue = returnValue * -1;+            return returnValue;+          });+          return {+            availableOptions: available,+            availableDescending: !prevState.availableDescending,+          }+        });+      }+      +      if (panel === 'chosen') {+        this.setState(prevState => {+          const chosen = prevState.chosenOptions.sort((a, b) => {+            let returnValue = 0;+            if (a.props.children > b.props.children) returnValue = -1;+            if (a.props.children < b.props.children) returnValue =  1;+            if (prevState.chosenDescending) returnValue = returnValue * -1;+            return returnValue;+          });+          return {+            chosenOptions: chosen,+            chosenDescending: !prevState.chosenDescending+          }+        });+      }+    };+    +    this.onListChange = (newAvailableOptions, newChosenOptions) => {+      this.setState({+        availableOptions: newAvailableOptions,+        chosenOptions: newChosenOptions,+      })+    };+    +    this.onToggle = (isOpen, pane) => {+      this.setState(prevState => {+        return {+          isAvailableKebabOpen: pane === "available" ? isOpen : prevState.isAvailableKebabOpen,+          isChosenKebabOpen: pane === "chosen" ? isOpen : prevState.isChosenKebabOpen+        }+      });+    };+    +    this.filterOption = (option, input) => {+      return option.props.children.includes(input);+    }+  }+  +  render() {+    const dropdownItems = [+      <DropdownItem key="link">Link</DropdownItem>,+      <DropdownItem key="action" component="button">+        Action+      </DropdownItem>,+      <DropdownItem key="second action" component="button">+        Second Action+      </DropdownItem>+    ];+    +    const availableOptionsActions = [+      <Button variant={ButtonVariant.plain} onClick={() => this.onSort("available")} aria-label="Sort" key="availableSortButton">+        {this.state.availableDescending ? <PficonSortCommonDescIcon/> : <PficonSortCommonAscIcon/>}+      </Button>,+      <Dropdown+        toggle={<KebabToggle onToggle={(isOpen) => this.onToggle(isOpen, "available")} id="toggle-id-1" />}+        isOpen={this.state.isAvailableKebabOpen}+        isPlain+        dropdownItems={dropdownItems}+        key="availableDropdown"+      />+    ];+    +    const chosenOptionsActions = [+      <Button variant={ButtonVariant.plain} onClick={() => this.onSort("chosen")} aria-label="Sort" key="chosenSortButton">+        {this.state.chosenDescending ? <PficonSortCommonDescIcon/> : <PficonSortCommonAscIcon/>}+      </Button>,+      <Dropdown+        toggle={<KebabToggle onToggle={(isOpen) => this.onToggle(isOpen, "chosen")} id="toggle-id-2" />}+        isOpen={this.state.isChosenKebabOpen}+        isPlain+        dropdownItems={dropdownItems}+        key="chosenDropdown"+      />+    ];+    +    return (+      <DualListSelector+        isSearchable+        availableOptions={this.state.availableOptions}+        availableOptionsStatus={`${this.state.availableOptions.length} available`}+        availableOptionsActions={availableOptionsActions}+        chosenOptions={this.state.chosenOptions}+        chosenOptionsStatus={`${this.state.availableOptions.length} chosen`}
        chosenOptionsStatus={`${this.state.chosenOptions.length} chosen`}
nicolethoen

comment created time in 24 days

pull request commentpatternfly/patternfly-react

feat(DualListSelector): add new component

@nicolethoen there are 2 things in the examples that are a bit confusing to me - first, when deselecting an item, the background color remains on the item until you click away (the text color does change from blue to black as expected): Screen Shot 2020-11-11 at 4 43 17 PM

Also - in the second example, it looks like the count for the "Chosen options" is mirroring the state for the "Available options" instead of actually giving the count for the chosen options: Screen Shot 2020-11-11 at 4 47 28 PM

nicolethoen

comment created time in 24 days

more