profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/easybe/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

easybe/alpine-reviewboard 3

A state-of-the-art Review Board image

easybe/easybundler 1

Creates a Mac Application Bundle form binaries and depending libraries

easybe/ansible-role-cuda 0

Installs cuda

easybe/ansiblecm 0

A Docker based Ansible control machine for running playbooks in a consistent environment.

easybe/au 0

Chocolatey Automatic Package Updater Module

easybe/au-packages 0

Chocolatey packages by majkinetor

easybe/brcmfmac_sdio-firmware 0

Broadcom SDIO firmware used with LibreELEC

easybe/choco 0

Chocolatey - the package manager for Windows

pull request commentbazelbuild/rules_python

Fix extract_single_wheel for Windows

@easybe are you able to refresh against main?

Done

easybe

comment created time in 19 days

push eventeasybe/rules_python

Jonathon Belotti

commit sha 92567575fb2d4efa6f316e9cfe86c9be326955b8

Improve README documentation of pip_install rule [tiny] (#501)

view details

Ezra Buehler

commit sha f8960ea45aea431b43408d9e61295b73ecf7f621

Fix extract_single_wheel for Windows On Windows, when using pip_parse, pip would fail with following error: Could not open requirements file: [Errno 13] Permission denied: ... This is due to Python holding a handle to the temporary file preventing pip, which is run as a sub-process, from reading it. For more information, see: https://bugs.python.org/issue14243 Closing the requirements file before running pip solves the problem.

view details

push time in 19 days

issue openedeasybe/homebrew-tap

websockets Python package missing

https://github.com/easybe/homebrew-tap/blob/e8cd861857310c17ebb4f049b3d85c0440c09c12/Formula/kismet.rb#L20

created time in 20 days

push eventeasybe/easyscripts

Ezra Buehler

commit sha b2310c62e49c6d6332fb60c23fea69feab9fb77c

epren.py: fix

view details

Ezra Buehler

commit sha 76686df9734ea62351a3735d038465841fa95152

epren.py: adapt to new directory structure

view details

push time in 21 days

push eventeasybe/easyscripts

Ezra Buehler

commit sha 7402120ccf7ec8aba140049daf927da8d406eb32

epren.py: fix

view details

Ezra Buehler

commit sha 98e79d3f0b04d7211c87d3bc41144c04c9a73124

epren.py: adapt to new directory structure

view details

push time in 21 days

push eventeasybe/rules_python

Ezra Buehler

commit sha 64086027947ca6228afcdfc85b007f64cd590450

Fix extract_single_wheel for Windows On Windows, when using pip_parse, pip would fail with following error: Could not open requirements file: [Errno 13] Permission denied: ... This is due to Python holding a handle to the temporary file preventing pip, which is run as a sub-process, from reading it. For more information, see: https://bugs.python.org/issue14243 Closing the requirements file before running pip solves the problem.

view details

push time in 24 days

Pull request review commentbazelbuild/rules_python

Fix extract_single_wheel for Windows

 def main() -> None:     if args.extra_pip_args:         pip_args += json.loads(args.extra_pip_args)["args"] -    with NamedTemporaryFile(mode='wb') as requirement_file:+    requirement_file = NamedTemporaryFile(mode='wb', delete=False)+    try:         requirement_file.write(args.requirement.encode("utf-8"))         requirement_file.flush()+        # Close the file so pip is allowed to read it when running on Windows.+        requirement_file.close()         # Requirement specific args like --hash can only be passed in a requirements file,         # so write our single requirement into a temp file in case it has any of those flags.         pip_args.extend(["-r", requirement_file.name])          # Assumes any errors are logged by pip so do nothing. This command will fail if pip fails         subprocess.run(pip_args, check=True)+    finally:+        try:+            os.unlink(requirement_file.name)+        except OSError:+            pass

I was inspired by: https://bugs.python.org/msg157925

easybe

comment created time in 24 days

PullRequestReviewEvent

Pull request review commentbazelbuild/rules_python

Fix extract_single_wheel for Windows

 def main() -> None:     if args.extra_pip_args:         pip_args += json.loads(args.extra_pip_args)["args"] -    with NamedTemporaryFile(mode='wb') as requirement_file:+    requirement_file = NamedTemporaryFile(mode='wb', delete=False)+    try:         requirement_file.write(args.requirement.encode("utf-8"))         requirement_file.flush()+        # Close the file so pip is allowed to read it when running on Windows.+        requirement_file.close()         # Requirement specific args like --hash can only be passed in a requirements file,         # so write our single requirement into a temp file in case it has any of those flags.         pip_args.extend(["-r", requirement_file.name])          # Assumes any errors are logged by pip so do nothing. This command will fail if pip fails         subprocess.run(pip_args, check=True)+    finally:+        try:+            os.unlink(requirement_file.name)+        except OSError:+            pass

This is in case, for whatever reason, the file is not present. Seems very unlikely though, I can remove it if you prefer.

easybe

comment created time in 24 days

PullRequestReviewEvent

push eventeasybe/rules_python

Jonathon Belotti

commit sha 46b8d99bb991fa5f4790268a30f19a782ac5b831

remove wording incorrectly suggesting python2 was supported by pip_install (#495) Co-authored-by: Henry Fuller <hrofuller@gmail.com>

view details

phlax

commit sha 929d5a13d4eb1b930086d9353fc6f2d6ad306e43

setuptools: Bump version to 54.0.0 (#422) * setuptools: Bump version to 54.0.0 * requirements Co-authored-by: Jonathon Belotti <jonathon@canva.com> Co-authored-by: Henry Fuller <hrofuller@gmail.com>

view details

Ezra Buehler

commit sha 371dd340a08f3c927df120170deb231c10a3ba5c

Fix extract_single_wheel for Windows On Windows, when using pip_parse, pip would fail with following error: Could not open requirements file: [Errno 13] Permission denied: ... This is due to Python holding a handle to the temporary file preventing pip, which is run as a sub-process, from reading it. Closing the requirements file before running pip solves the problem.

view details

push time in a month

pull request commentbazelbuild/rules_python

Fix extract_single_wheel for Windows

@googlebot I signed it!

easybe

comment created time in a month

PR opened bazelbuild/rules_python

Fix extract_single_wheel for Windows

On Windows, when using pip_parse, pip would fail with following error:

Could not open requirements file: [Errno 13] Permission denied: ...

This is due to Python holding a handle to the temporary file preventing pip, which is run as a sub-process, from reading it.

Closing the requirements file before running pip solves the problem.


PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] Does not include precompiled binaries, eg. .par files. See CONTRIBUTING.md for info
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

<!-- Please check the one that applies to this PR using "x". -->

  • [x] Bugfix
  • [ ] Feature (please, look at the "Scope of the project" section in the README.md file)
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [ ] Documentation content changes
  • [ ] Other... Please describe:

What is the current behavior?

<!-- Please describe the current behavior that you are modifying, or link to a relevant issue. -->

Issue Number: N/A

What is the new behavior?

pip_parse works on Windows.

Does this PR introduce a breaking change?

  • [ ] Yes
  • [x] No

<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. -->

Other information

+10 -1

0 comment

1 changed file

pr created time in a month

create barncheasybe/rules_python

branch : windows_fix

created branch time in a month

fork easybe/rules_python

Experimental Bazel Python Rules

fork in a month

create barncheasybe/Mailu

branch : antispam

created branch time in a month

fork easybe/Mailu

Insular email distribution - mail server as Docker images

https://mailu.io

fork in a month

push eventeasybe/au

Ezra Buehler

commit sha 514cb33be73eec53eab2ac2c93f7d350698ecf9f

dbg

view details

push time in 2 months

push eventeasybe/au

Ezra Buehler

commit sha c74fe3d79b0cb7b5c4e7f3c4fc25633b2584ee8d

Add Pull Request plugin

view details

push time in 2 months

push eventeasybe/au

Ezra Buehler

commit sha 1dbb29634fb8bb19e5fc73d0d8a3bcae1cdcfef3

Add Pull Request plugin

view details

push time in 2 months

push eventeasybe/au

Ezra Buehler

commit sha 3aefc478058012908cb7400d73a991ddabb8623e

Add Pull Request plugin

view details

push time in 2 months

create barncheasybe/au

branch : pr

created branch time in 2 months

delete branch easybe/au

delete branch : pr

delete time in 2 months

create barncheasybe/au

branch : pr

created branch time in 2 months

pull request commentmajkinetor/au

Git plugin: create branch if it does not exist

I like this solution because the changes are very minimal 🤷‍♂️

easybe

comment created time in 2 months

pull request commentmajkinetor/au

Git plugin: create branch if it does not exist

If you have two AU scripts pushing to the same branch, the slower one will pull the newly created branch.

easybe

comment created time in 2 months

pull request commentmajkinetor/au

Git plugin: create branch if it does not exist

I really don't see any problem. As I said,

If you specify master as the branch, nothing should have changed.

because a git pull is still performed.

If you use a different branch, worst case would be that you have a merge conflict when merging the branch. Then you can either re-run or rebase.

easybe

comment created time in 2 months

pull request commentmajkinetor/au

Git plugin: create branch if it does not exist

If you specify master as the branch, nothing should have changed.

easybe

comment created time in 2 months

pull request commentmajkinetor/au

Git plugin: create branch if it does not exist

For me it works because:

  • CI checks out master
  • AU creates a new branch from master
  • AU pushes that to the branch
  • You can merge branch into master

That is why the "pull" does not make sense to me...

easybe

comment created time in 2 months

pull request commentmajkinetor/au

Git plugin: create branch if it does not exist

Yes, I am done.

It works in my set up which is based on https://github.com/majkinetor/au-packages-template/blob/master/update_all.ps1.

Not sure how to test it more.

easybe

comment created time in 2 months