profile
viewpoint
Eric Amodio eamodio @microsoft MA amod.io Father, husband, code monkey, entrepreneur, geek. Creator of GitLens for VS Code. VS Code developer @Microsoft. Previously @TeamCodeStream.❤ open-source

eamodio/SaveAllTheTabs 49

Quickly save and restore sets of document tabs in Visual Studio

eamodio/eamodio.github.io 6

Personal website

eamodio/fitbit-pure 4

A beautifully designed, highly customizable, clean, and simple clock face for Fitbit Versa devices

eamodio/gitlens.github.io 3

GitLens website

eamodio/TortoiseGitCommands 3

Provides quick access to TortoiseGit commands.

eamodio/posh-git 2

A PowerShell environment for Git

eamodio/eslint-plugin-prettiest 1

ESLint rules to "fix" prettier formatting

eamodio/github-amethyst-theme 1

A dark theme for GitHub

eamodio/homebrew-cask 1

A CLI workflow for the administration of Mac applications distributed as binaries

eamodio/tslint-prettiest 1

TSLint rules to "fix" prettier formatting

issue openedmicrosoft/vscode

Views moved to the SCM view don't always restore to the proper size/position

Testing #98994

This seems to only affect views on the SCM viewlet. views

Might be related to #98615 but I've seen no correlation with a window border (and only on the SCM view)

created time in 3 hours

push eventmicrosoft/vscode

Miguel Solorio

commit sha f3c7c4df8e2c0706244049fe0b6a2e880ecd9ec6

Hard to see which buttons are toggled in find/replace dialog boxes Fixes #97204

view details

Miguel Solorio

commit sha d662ba0f31b84ae9356789d8ac8868a8bdf06b9d

Merge branch 'master' into misolori/issue97204

view details

Daniel Kelling

commit sha 4b00bed17724df21c5a03ac929358bff22ff4a0d

Add support for Unicode-aware regular expressions in Monaco Monarch language definitions

view details

Ladislau Szomoru

commit sha ed5e512a2f855598edb19c7c2a6ceabe66477bbd

Do not push an empty string to the result

view details

Miguel Solorio

commit sha 28a4232ddc22af7fdbe06687e3dc1b2685cf7e95

Update code cell bg, border, and output bg

view details

rebornix

commit sha 472571daa3b05dea6e17a17240a1cf7fe7f3cacd

await notebookEditor.setModel: sends all initialization events to ext host when opening notebook.

view details

rebornix

commit sha 0663fac3acdc53a344e2272cd8c421555429cfd9

support cell text model attach/detach on web.

view details

rebornix

commit sha c2131f984e8b3e007896ef3bf1fa4af6206e2f46

set visible editors active property correctly.

view details

rebornix

commit sha 7fccb0d608511be3d92c988fb7309c1da95b8b85

use updateState/compute instead of sending delta directly.

view details

rebornix

commit sha 0bf860564a3e2fb05518d5c29eb0ed4cf920a4bb

Diffing editors/documents/visibleEditors/activeEditor.

view details

rebornix

commit sha a14a793150e7a1837277d365c2b2b658d873cc8b

split editor does not await, notebook events are not sent to ext host in time on Web.

view details

rebornix

commit sha b1c870fe25d2a405847cbc15887a3dbccafdf546

Disable webview related tests on web.

view details

rebornix

commit sha ed0803e668dc626c5e632ad1ff71ba85cbb83cd1

fix false negative tests

view details

rebornix

commit sha ff9504d7d493463ef71b080a08dd5304f6ca6a63

Fix windows file name match

view details

Benjamin Pasero

commit sha 06524e63d00a7af0a1a71af7113432687d6fc7fb

notification - add animation steps to progress (fix #97900)

view details

Benjamin Pasero

commit sha 41150cfa63f72c117c2a4c145221ca37f51ddc4c

Files: unable to "Save as.." with same name, different case (fix #98864)

view details

Benjamin Pasero

commit sha 9bc5425eaa062f4d17985b6923138603d83a3f93

working copy file service - assert delete/move/copy operations are valid before even attempting them

view details

Benjamin Pasero

commit sha 75bfdbe70692da5e0975a3e7de570b4e86eed5fe

workaround #98934 (#98936)

view details

Benjamin Pasero

commit sha 705e1ba5a9bb4230b96b072fadc567d08fe02aa5

working copy files - use URI identity service and optimize move/copy to same URI

view details

Benjamin Pasero

commit sha 781950c23e552c74473735693833b904e4c8ba92

editors - change whenClosed to use editor interface

view details

push time in 17 hours

issue openedmicrosoft/vscode

Ctrl+K Ctrl+U doesn't uncomment lines in diff editor (right side)

For some reason Ctrl+K Ctrl+U (editor.action.removeCommentLine) doesn't work in the diff editor, but Ctrl+K Ctrl+C works fine

created time in 17 hours

issue commentmicrosoft/vscode

timeline-View shown nothing

@DawnPaladin are you still seeing this issue?

bardware

comment created time in 17 hours

issue commentmicrosoft/vscode

Timeline: use more horizontal space

@joaomoreno I can look into using the horizontal space better -- although I feel like this is a bigger feature, where the tree can tell the node its width when rendering -- because depending on the width a view might want to change the content (especially between the label and the description).

As for connecting the icons, it has been suggested, but not sure its a good idea as the Git entries are only 1 of many types that could be intermixed in the timeline.

joaomoreno

comment created time in 18 hours

CommitCommentEvent

push eventmicrosoft/vscode

Eric Amodio

commit sha ae75a6a3bdadecf96306e0229bd77872c8742d3e

Fixes #97222 - calls setVisible when hidden

view details

push time in 18 hours

issue closedmicrosoft/vscode

ERR Bad progress location: timeline

Issue Type: <b>Bug</b>

  1. Open a file with timeline history
  2. Hide timeline through a checkbox in explorer view
  3. Open another file
ERR Bad progress location: timeline: Error: Bad progress location: timeline
    at e.withProgress (.../Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:5583:646)
    at e.handleRequest (.../Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:7182:187)
    at e.loadTimelineForSource (.../Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:7181:755)
    at e.loadTimeline (.../Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:7180:873)
    at e.setUriCore (.../Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:7177:572)
    at e.onActiveEditorChanged (.../Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:7178:892)
    at e.fire (.../Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:95:821)
    at e.doHandleActiveEditorChangeEvent (.../Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:5908:1011)
    at e.handleActiveEditorChange (.../Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:5908:809)
    at .../Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:5909:104
    at e.fire (.../Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:95:801)
    at .../Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:6120:679
    at processTicksAndRejections (internal/process/task_queues.js:85:5)
    at async e.openEditor (.../Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:6119:589)

VS Code version: Code 1.45.0 (d69a79b73808559a91206d73d7717ff5f798f23c, 2020-05-07T16:18:48.860Z) OS version: Windows_NT x64 10.0.18363

<!-- generated by issue reporter -->

closed time in 18 hours

usernamehw

push eventmicrosoft/vscode

Eric Amodio

commit sha 61884cade0fe3025498b51c6b9535f6de335c73a

Fixes #97308 - invalid settings config

view details

push time in 18 hours

issue closedmicrosoft/vscode

Settings with invalid defaults

timeline.excludeSources and timeline.pageSize have null defaults but the types don't include null. Consider using a non-null default like an empty array, if there is no difference, it will be easier to display in the settings editor.

closed time in 18 hours

roblourens

issue closedmicrosoft/vscode

Timeline - Page Size - Invalid Setting (with no custom setting)

Issue Type: <b>Bug</b>

Scroll down to Timeline - Page Size in the Settings UI, and encounter an error, even though there are no user overrides for this setting:

page-size-invalid-setting

VS Code version: Code 1.45.0 (d69a79b73808559a91206d73d7717ff5f798f23c, 2020-05-07T15:57:33.467Z) OS version: Darwin x64 18.7.0

<details> <summary>System Info</summary>

Item Value
CPUs Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz (16 x 2400)
GPU Status 2d_canvas: enabled<br>flash_3d: enabled<br>flash_stage3d: enabled<br>flash_stage3d_baseline: enabled<br>gpu_compositing: enabled<br>metal: disabled_off<br>multiple_raster_threads: enabled_on<br>oop_rasterization: disabled_off<br>protected_video_decode: unavailable_off<br>rasterization: enabled<br>skia_renderer: disabled_off_ok<br>video_decode: enabled<br>viz_display_compositor: enabled_on<br>viz_hit_test_surface_layer: disabled_off_ok<br>webgl: enabled<br>webgl2: enabled
Load (avg) 2, 2, 2
Memory (System) 32.00GB (2.30GB free)
Process Argv -psn_0_15310489
Screen Reader no
VM 0%

</details><details><summary>Extensions (41)</summary>

Extension Author (truncated) Version
vscode-openapi 42C 3.2.0
vscode-tailwindcss bra 0.2.0
pgformatter bra 1.14.0
npm-intellisense chr 1.3.0
path-intellisense chr 1.4.2
vscode-markdownlint Dav 0.35.2
vscode-eslint dba 2.1.5
githistory don 0.6.5
gitlens eam 10.2.1
EditorConfig Edi 0.14.5
vscode-npm-script eg2 0.3.11
prettier-vscode esb 4.7.0
vscode-firefox-debug fir 2.8.0
lintlens ghm 3.0.0
headwind hey 1.6.5
vscode-peacock joh 3.7.2
chat kar 0.33.0
vscode-language-babel mgm 0.0.27
dotenv mik 1.0.1
vscode-docker ms- 1.2.0
remote-ssh ms- 0.51.0
remote-ssh-edit ms- 0.51.0
vsliveshare ms- 1.0.2169
vsliveshare-audio ms- 0.1.85
vsliveshare-pack ms- 0.3.4
debugger-for-chrome msj 4.12.7
sqltools mtx 0.21.7
vscode-jest Ort 3.2.0
polacode pnp 0.3.4
prisma Pri 0.1.5
vscode-yaml red 0.8.0
LiveServer rit 5.6.1
stylelint shi 0.51.0
fish-vscode sky 0.2.1
code-spell-checker str 1.9.0
shellcheck tim 0.9.0
sort-lines Tyr 1.9.0
vscodeintellicode Vis 1.2.7
vscode-todo-highlight way 1.0.4
JavaScriptSnippets xab 1.8.0
markdown-all-in-one yzh 2.8.0

</details> <!-- generated by issue reporter -->

closed time in 18 hours

hbergren

issue commentmicrosoft/vscode

Timeline - Page Size - Invalid Setting (with no custom setting)

Duplicate of https://github.com/microsoft/vscode/issues/97308

hbergren

comment created time in 18 hours

issue commentmicrosoft/vscode

Timeline entries should not end up in history

@jrieken is this still happening for you? I can't reproduce this.

jrieken

comment created time in 18 hours

issue commentmicrosoft/vscode

Provide open with support to embedding default editors

FYI @legomushroom - There is a new openWith?: string property on IDefaultEditor that can be used to open the document with a custom editor, e.g. markdown preview mode.

e.g.

openWith: 'vscode.markdown.preview.editor'
eamodio

comment created time in 18 hours

push eventmicrosoft/vscode

Eric Amodio

commit sha f75402751a2975ac2f6edba074629fab85d3da83

Closes #98048 - adds openWith to default editors

view details

push time in 18 hours

issue closedmicrosoft/vscode

Provide open with support to embedding default editors

Currently the embedding api for default editors doesn't allow support for custom editors.

To address this add an optional openWith: string property to the IDefaultEditor object.

closed time in 18 hours

eamodio

issue commentmicrosoft/vscode

Working Tree and Timeline not showing changes

Can you provide more details on the issue you are experiencing? Maybe even record a video? As I'm not seeing any issues with the SCM view and interaction with the Timeline view. Thanks!

sgkrenganathan

comment created time in 19 hours

issue commentmicrosoft/vscode

Timeline doesn't show file saves changes

This is expected behavior as the timeline doesn't currently show file saves, just git history. The note in the release notes was about the things the timeline view could be used for visualizing.

Will treat this as the feature request for file save history.

b1zzu

comment created time in 19 hours

issue closedmicrosoft/vscode

Re-add option to disable timeline

<!-- ⚠️⚠️ Do Not Delete This! feature_request_template ⚠️⚠️ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- Please search existing issues to avoid creating duplicates. -->

<!-- Describe the feature you'd like. -->

https://github.com/microsoft/vscode/commit/46679eee363519cc2a8f73a111d6175a941d1b41 and https://github.com/microsoft/vscode/commit/0a8ffc6bcbde9d156f130ecc4943f1309dc056f5 enabled the timeline on stable, but removed the option to disable it. I don't want the timeline view, and so I'd like the timeline.showView setting returned so it can be disabled. It can be set to default enabled however, in line with current behaviour.

closed time in 19 hours

palfrey

issue commentmicrosoft/vscode

Re-add option to disable timeline

As this is directly supported in the UI (for any view), I'm going to close this.

palfrey

comment created time in 19 hours

issue openedmicrosoft/vscode

SCM tree spacing is different than other views

There seems to be a lot of extra space between the edge and the icon of the files in the CHANGES view image

created time in 19 hours

issue openedmicrosoft/vscode

Restart while extension host debugging doesn't do anything anymore

Pressing the "Restart" button when debugging an extension doesn't seem to do anything anymore.

created time in a day

CommitCommentEvent
CommitCommentEvent

push eventmicrosoft/vscode

João Moreno

commit sha 5edf3d10631e426db6ffd3f273b8270c47b40b46

initial steps for win32 arm64

view details

João Moreno

commit sha 13ab842239fe1ec15026beccbda40d94315b657c

fix auto trigger

view details

João Moreno

commit sha d424ff23caddce71733849a830fdfbcaabf9a28b

skip remote for win32 arm64

view details

João Moreno

commit sha 04be06ff6f1d7c1077d5f09dbe9f2cbad605c80d

fix skip remote

view details

Janis Gailis

commit sha a34e15b15f4fd68c655fd17438461a2f1b4260cc

Add terminal colors Terminal colors are taken from Monokai, with the exception for ANSI black, which is the editor background color.

view details

Benjamin Pasero

commit sha 3514e96bf5b684579a1bdabbdac9fd9dda281906

sandbox - add rules for new electron-sandbox layer

view details

Benjamin Pasero

commit sha a4a5b1f19c5e2991024aa813b12f1f6a8a4cd75e

sandbox - expose limited IPC via preload script

view details

Benjamin Pasero

commit sha c3c1a95c760e30202c44e24157f7b3075b77799b

sandbox - introduce IPC over sandbox helper

view details

Martin Aeschlimann

commit sha 2e5b0824d1d3c1114a6f7fc36f9694723c86fc9c

Allow to run css language server headless

view details

Benjamin Pasero

commit sha dc8f291781000951ddbf6bea734ff7e16371ff94

sandbox - let workspaces service use sandboxed IPC

view details

Benjamin Pasero

commit sha 88af9b528f03f3d82163528c13da977a92106ec2

sandbox - make sure to use sandboxed main process service consistently in renderer

view details

Benjamin Pasero

commit sha 97f43a2fab44e72c560c79c44ff056ccd3cef0a9

sandbox - produce checksum for preload script

view details

Benjamin Pasero

commit sha 1ee6f73c9f1cdbcf5b1b33c37efab8ed6aa6aff5

sandbox - move storageKeysSyncRegistryService

view details

Benjamin Pasero

commit sha b1c12cac1046886be24009e3d47e52824df0bec7

sandbox - move menubarService

view details

Benjamin Pasero

commit sha 0565b5fc034501156f0b3e1fdbc2ba653bf68029

sandbox - move issueService

view details

Benjamin Pasero

commit sha bfe3cc05664da0b033573387378b7ac03d6e8434

sandbox - move IExtensionHostDebugService

view details

Benjamin Pasero

commit sha a5554716a0c9b1bcd3c0b0329fa356ae1647ac0c

sandbox - move updateService

view details

Benjamin Pasero

commit sha 2c2750be083ef78b58a6f3c47217aa699a5a3121

sandbox - get rid of IMainProcessService2

view details

Benjamin Pasero

commit sha 88ae7a43871d9bda8c2cc1951be8857935cab30e

sandbox - fix tests

view details

rzj17

commit sha 60d906fd579f15dafe4e6c1f584b43a4598fbfb2

Modify git add/revert to use splitInChunks

view details

push time in 2 days

issue openedeamodio/fitbit-pure

Add support for not showing stats at all

It has been requested to turn off all the activity stats.

created time in 4 days

push eventeamodio/vscode-gitlens

Eric Amodio

commit sha 9ae00f9b6147e37c50f8701999a75a300ac50ce2

Changes heatmap to be in the gutter Changes heatmap colorization for better clarity Changes blame avatars to be w/ the annotations rather than in the gutter

view details

push time in 5 days

startedgka/chroma.js

started time in 5 days

push eventmicrosoft/vscode

Daniel Imms

commit sha f5568c94f8c743dbbbc451f9682be5370f7bbbea

Remove link matchers from terminal Part of #96266

view details

Daniel Imms

commit sha 3f27e5123332def803eb6c9dbab92af77c4db10d

Fix test instantiation conflict

view details

Daniel Imms

commit sha d01deed96eaaad6b227714130135201b4881d9ac

Remove unused interface

view details

Robo

commit sha 949722520701ee8b2cb3b2a550d7b1e7246a9a26

chore: bump electron@8.2.5 (#98109)

view details

SteVen Batten

commit sha 349b16ddda3c64cf2b8232a0269296fd57f8724e

fixes #98016

view details

Rachel Macfarlane

commit sha a7fb3ef3038e732e9ff39033d1343f347f0ac9ea

Fix sign out confirmation message

view details

rebornix

commit sha a14736ca5e8a65de878058ebbca4930d6b882a98

introduce visible notebook editors

view details

rebornix

commit sha 55ac452768382a64dc38c8b3de99eb1ca5264580

webview id attached to notebook editor

view details

rebornix

commit sha 4c54f7124c08cf86eb2f3f70a5c651fdffa5809e

shared document between split editors and dispose them properly

view details

rebornix

commit sha d9fd263f52972ffe019641c45c692b1e10060dc9

load document with editor id.

view details

rebornix

commit sha 025bd27df7e386e326dde5e257e3d88165a711a6

webview comm based on editor other than document.

view details

rebornix

commit sha 1cfa610cb60c9944873fea5e1e4c28839e2f6ab8

model change on document.

view details

rebornix

commit sha a328f500d8afe24c9a3639177632d69833e876bb

:guard: move cells will not re-create cells in ExtHost.

view details

rebornix

commit sha b5831f5be72ad234f8fd29a25b681389b58a1b1e

notebook content change events.

view details

HaoboGu

commit sha 51fe691d22a92d46288a436fac5ae4a09502133c

fix #98102 When VSCode selects preselected completion items, the index shouldn't start from 1. If there are multiple completion items with preselect=true, the first item will never be chosen.

view details

deepak1556

commit sha 3bd9d7554b273cd43cef88c923eae0fa0b435d0a

Revert "chore: bump electron@8.2.5 (#98109)" This reverts commit 949722520701ee8b2cb3b2a550d7b1e7246a9a26.

view details

Sandeep Somavarapu

commit sha 403be36aebd235bbf00b36b585969a20bc954a6f

fix tests

view details

Sandeep Somavarapu

commit sha 6236f65fa0be9dd3019e5d3bf417ac504e1d0039

fix tests wait more than input time interval

view details

Johannes Rieken

commit sha 432451794896c6b53a33b99f3d6ada852c32bb03

Merge pull request #98127 from HaoboGu/master fix #98102

view details

Benjamin Pasero

commit sha dd2f659a863c9adb17a31f35841633411d8ff8ac

debt - put some reference dispose into finally blocks

view details

push time in 7 days

issue commentmicrosoft/vscode

js-debug debugger terminal discoverability

👍 to adding a new button to the terminal toolbar. Or even a debug button or something to turn a regular terminal into a debug one (if that is possible).

connor4312

comment created time in 7 days

issue closedmicrosoft/vscode-test

Publish 1.4.0 to npm

Would you be able to publish 1.4.0 to npm? We're facing an issue that would benefit from the change in #56

Thanks.

closed time in 7 days

ckant

issue commentmicrosoft/vscode-test

Publish 1.4.0 to npm

@ckant @jcreedcmu Sorry for the delay -- 1.4 has now been published

ckant

comment created time in 7 days

push eventmicrosoft/vscode-test

Eric Amodio

commit sha 9aade080626e0a237c17d230f4fccb926776eec7

v1.4.0

view details

push time in 7 days

push eventeamodio/vscode-gitlens

Eric Amodio

commit sha ae04eafc55e37a05cef435c1b700f1a10916e538

Fixes issue with compare files not showing changes

view details

Eric Amodio

commit sha cdc5916df79f5fc067299fe1c602b7c47941c173

Bumps to v11.0.0-alpha

view details

push time in 8 days

issue commentTypeStrong/fork-ts-checker-webpack-plugin

Add an example `tasks.json` to README?

@phryneas FYI, you can use the npm type tasks even with yarn if you set "npm.packageManager": "yarn" in your vscode settings

phryneas

comment created time in 8 days

issue commentTypeStrong/fork-ts-checker-webpack-plugin

Add an example `tasks.json` to README?

Here is a the tasks.json I use for GitLens:

{
	"version": "2.0.0",
	"tasks": [
		{
			"type": "npm",
			"script": "build",
			"group": "build",
			"problemMatcher": ["$ts-checker5-webpack", "$ts-checker5-eslint-webpack"]
		},
		{
			"type": "npm",
			"script": "lint",
			"group": "build",
			"problemMatcher": ["$eslint-stylish"]
		},
		{
			"type": "npm",
			"script": "watch",
			"group": {
				"kind": "build",
				"isDefault": true
			},
			"isBackground": true,
			"problemMatcher": ["$ts-checker5-webpack-watch", "$ts-checker5-eslint-webpack-watch"]
		}
	]
}

Which uses the problem matchers from my TypeScript + Webpack Problem Matchers extension

phryneas

comment created time in 8 days

push eventeamodio/vscode-gitlens

Eric Amodio

commit sha d35d96cbf8fa47b318b6455a5d2710507cd5987e

Updates dependencies

view details

Eric Amodio

commit sha d571e1e560cbfbb4334a1902466f0e357fe0d8df

Fixes problem matcher support

view details

Eric Amodio

commit sha 7996392b6cf09885439934c18ab71f4bc6cc94b1

wip

view details

Eric Amodio

commit sha 10de6b88063c351c127b11b6be4cf949a9497675

wip

view details

Eric Amodio

commit sha 26998aa6d3ffbe92b7d4cb67ab707415283b2aec

wip

view details

Eric Amodio

commit sha ad3446b0b1e608db1a10a2c2d11c7431b0eb70cc

wip

view details

push time in 8 days

push eventeamodio/vscode-gitlens

Eric Amodio

commit sha d35d96cbf8fa47b318b6455a5d2710507cd5987e

Updates dependencies

view details

Eric Amodio

commit sha d571e1e560cbfbb4334a1902466f0e357fe0d8df

Fixes problem matcher support

view details

push time in 8 days

issue commentTypeStrong/ts-loader

VSCode integration with webpack in watch mode

@KnisterPeter FYI, there is a problem matcher extension for ts-loader/fork-ts-checker. And I've just added support for fork-ts-checker v5

edvinv

comment created time in 8 days

issue commentTypeStrong/ts-loader

Feature: Support incremental build

Yeah, I just have a single project, no project references.

mc0

comment created time in 8 days

created tageamodio/vscode-tsl-problem-matcher

tagv0.2.0

TypeScript + Webpack Problem Matchers for VS Code

created time in 8 days

push eventeamodio/vscode-tsl-problem-matcher

Eric Amodio

commit sha 8e03475152171029d29d18731504dc845a6084e1

Updates README

view details

push time in 8 days

push eventeamodio/vscode-tsl-problem-matcher

Eric Amodio

commit sha 6fb0f825af6082b9bb1ee4ec1e9877aceb0866f0

Adds fork-ts-checker v5 support Adds code output Fixes eslint issue

view details

Eric Amodio

commit sha 62c96f60b4c6d933824306b441f8b0a77f45196e

Preps v0.2.0

view details

push time in 8 days

issue commentmicrosoft/vscode

Investigating Electron 8 exploration startup performance

I'm seeing VERY long opening times on my Windows 10 (2004 - slow ring, 19041.264) desktop machine (12-core 3.8GHz AMD proc) with the latest insiders too.

deepak1556

comment created time in 8 days

issue commentTypeStrong/ts-loader

Feature: Support incremental build

This still seems to be an issue for me, I am using the experimentalWatchApi and setting "incremental": true in my tsconfig.json, but am not seeing any .tsbuildinfo files being generated nor any reduction in compile times. FYI, I am using the latest fork-ts-checker 5.0.0-alpha.5 too

mc0

comment created time in 8 days

issue commentTypeStrong/fork-ts-checker-webpack-plugin

5.0.0-alpha.2: ESLint support only seems to work on initial compile, not on changes

https://github.com/eamodio/vscode-gitlens/blob/develop/webpack.config.js

eamodio

comment created time in 9 days

push eventeamodio/vscode-gitlens

Justin Hutchings

commit sha 8298a4bbda8527031098470c9c0490fb6b435e38

Add CodeQL Analysis workflow

view details

Grey Baker

commit sha b9e02102b6653ffff4a67ac4198f37843c361267

Move CodeQL workflow file

view details

Eric Amodio

commit sha 4946caadbefe9bb58b9c1e938c9ad5415aa2320d

Fixes autolinking with remote providers

view details

Eric Amodio

commit sha 7be9fdef1871d9086a08088c3fb3cdebbaccbd8e

Adds skipLibCheck

view details

Eric Amodio

commit sha 62477e16cc92e6914e9b8b7155f28db3c2db825c

Adds debug logging to hovers

view details

Eric Amodio

commit sha d9dc67c2d982863da72ca7b3fa4e68d675b54743

Adds support for quoted prefix/suffix in tokens

view details

Eric Amodio

commit sha fdd2bdc13966fac5ce530fc2b74b064cbb45b920

Adds tracing for debugging issues

view details

Eric Amodio

commit sha 9cfe108dcedc529a877113bf875880901e6ff527

Improves perf of contributors & details hover Moves current user to the top of the contributors marked w/ (you) suffix Adds a max timeout to live share presence requests (250ms) Only requests the presence of the current user in the contributors view

view details

Eric Amodio

commit sha 494cff1ea239fef1dd019ec0f2ed96097438f123

Fixes hovers not showing on first editor

view details

Eric Amodio

commit sha 67b58627be75cc9e8a2bf343e378a1643daf8b3c

Updates dependencies

view details

Eric Amodio

commit sha 32279bdd46854f116702512415e59fbaf8f5711c

Fixes lint issues

view details

Eric Amodio

commit sha 1a8e62fc86b99f791bb78f529fded953d97c927f

Attempts to speed up builds

view details

Eric Amodio

commit sha ff9d13f7a2eccf68dca4114b6c68366a64f27b88

Removes unused file

view details

Eric Amodio

commit sha 33905e9c853eb72904a7067ec2bcbacb8cb987bf

Fixes issues w/ range notation & branches w/ special characters

view details

Eric Amodio

commit sha da321ee5d0c3a2bc37e0436fa1cdd8799b2788eb

Fixes #910 - show in search failed from views

view details

Eric Amodio

commit sha 945a9ce2f8a58239eb130411048c832852f749a0

Changes diffWithWorking to use left diff Changes openRevision to use left diff

view details

Eric Amodio

commit sha 543ab4658b053f3120cdd8ab52eee79278604e28

Reverts (most of) eda2cd3 (range issues) This was a bad fix -- the issue wasn't special characters at all 😖

view details

Eric Amodio

commit sha 693df868cb72f21775c92b9b5ab571917973d479

Updates dependencies

view details

Eric Amodio

commit sha f2c14f147ab7266926d475899669049c7625fdc4

Updates dependencies

view details

Eric Amodio

commit sha 45d6861655024565647e260f9fd8b843abac3191

Splits annotations and hovers

view details

push time in 9 days

push eventeamodio/vscode-gitlens

Justin Hutchings

commit sha 8298a4bbda8527031098470c9c0490fb6b435e38

Add CodeQL Analysis workflow

view details

Grey Baker

commit sha b9e02102b6653ffff4a67ac4198f37843c361267

Move CodeQL workflow file

view details

Eric Amodio

commit sha 4946caadbefe9bb58b9c1e938c9ad5415aa2320d

Fixes autolinking with remote providers

view details

Eric Amodio

commit sha 7be9fdef1871d9086a08088c3fb3cdebbaccbd8e

Adds skipLibCheck

view details

Eric Amodio

commit sha 62477e16cc92e6914e9b8b7155f28db3c2db825c

Adds debug logging to hovers

view details

Eric Amodio

commit sha d9dc67c2d982863da72ca7b3fa4e68d675b54743

Adds support for quoted prefix/suffix in tokens

view details

Eric Amodio

commit sha fdd2bdc13966fac5ce530fc2b74b064cbb45b920

Adds tracing for debugging issues

view details

Eric Amodio

commit sha 9cfe108dcedc529a877113bf875880901e6ff527

Improves perf of contributors & details hover Moves current user to the top of the contributors marked w/ (you) suffix Adds a max timeout to live share presence requests (250ms) Only requests the presence of the current user in the contributors view

view details

Eric Amodio

commit sha 494cff1ea239fef1dd019ec0f2ed96097438f123

Fixes hovers not showing on first editor

view details

Eric Amodio

commit sha 67b58627be75cc9e8a2bf343e378a1643daf8b3c

Updates dependencies

view details

Eric Amodio

commit sha 32279bdd46854f116702512415e59fbaf8f5711c

Fixes lint issues

view details

Eric Amodio

commit sha 1a8e62fc86b99f791bb78f529fded953d97c927f

Attempts to speed up builds

view details

Eric Amodio

commit sha ff9d13f7a2eccf68dca4114b6c68366a64f27b88

Removes unused file

view details

Eric Amodio

commit sha 33905e9c853eb72904a7067ec2bcbacb8cb987bf

Fixes issues w/ range notation & branches w/ special characters

view details

Eric Amodio

commit sha da321ee5d0c3a2bc37e0436fa1cdd8799b2788eb

Fixes #910 - show in search failed from views

view details

Eric Amodio

commit sha 945a9ce2f8a58239eb130411048c832852f749a0

Changes diffWithWorking to use left diff Changes openRevision to use left diff

view details

Eric Amodio

commit sha 543ab4658b053f3120cdd8ab52eee79278604e28

Reverts (most of) eda2cd3 (range issues) This was a bad fix -- the issue wasn't special characters at all 😖

view details

Eric Amodio

commit sha 693df868cb72f21775c92b9b5ab571917973d479

Updates dependencies

view details

Eric Amodio

commit sha f2c14f147ab7266926d475899669049c7625fdc4

Updates dependencies

view details

Eric Amodio

commit sha 45d6861655024565647e260f9fd8b843abac3191

Splits annotations and hovers

view details

push time in 9 days

push eventeamodio/vscode-gitlens

Eric Amodio

commit sha f273d98726fc56da2197134d492ad69ee40d260c

Stops directory compare waiting for external tool

view details

Eric Amodio

commit sha d77f935f8e487a5ca1bc046bd4a3c385e252826c

Updates dependencies

view details

abdusabri

commit sha f664fa3f687cde73e96631caa1386bfd41bb6895

Closes #989 - adds option to disable click actions on code lens commands * adds option to disable click actions on recent changes and authors code lens commands * Updates documentation in the README file to reflect the changes

view details

Eric Amodio

commit sha 61c9d268c86c88f2f36f9185b996cc63502dd91b

Fixes settings metadata - null missing from many

view details

Eric Amodio

commit sha 896b976e6b790ed2af21c8d312a716e0f5c2a273

Uses data uri for gutter hightlight Eventually will allow for ThemeColor customizations

view details

Eric Amodio

commit sha 4335cf7b1653265fe74a4eba72ed363c9b2dd519

Fixes git log paging with merge commits

view details

Eric Amodio

commit sha b8da5320f017190576c0a12d8169f82f944b1b11

Use --first-parent for log with --follow Removes bogus merge commits that can show up in the history

view details

Eric Amodio

commit sha c5811994ea2edee69785610c2bcb3ea44bde269d

Fixes issue w/ previous line diff line # being off

view details

Eric Amodio

commit sha c6f6b7024eafa8ac312bd421d22820683fb2c05f

Ensure right-side diff

view details

Eric Amodio

commit sha 7b80228a2052b858c290417bf6d38330c5878a88

Updates dependencies & lint rules

view details

Eric Amodio

commit sha 6556a3ddc5eadcf55560c7a6dfafdd118143c6bf

Overhauls git command quickpick menus

view details

Eric Amodio

commit sha bfad1a55b90ff2205ad77262e4afb9200b0ce5fc

Fixes lint issues

view details

Eric Amodio

commit sha 9973ebe8787523f6d76b181abbea7eecac08a79c

Updates dependencies & caches eslint

view details

Eric Amodio

commit sha c2da9b57a8e5893a93809b0c6cfefa38191b3ef4

Removes dead telemetry code

view details

Eric Amodio

commit sha e8c572386f8b6e97e03357e3a9771b7ebf63e742

Removes help link until it exists

view details

Eric Amodio

commit sha 0d04c2816c499d483bc98934445a0449ad577282

Fixes #1033 - also switches to ejs templates

view details

Eric Amodio

commit sha 26c26416788814f0c2cdab2a44273fb16a1d1b1e

Changes github auth

view details

Eric Amodio

commit sha 5cfa26efb5d938df7120d1bbc18ce70b445a81fa

wip

view details

Eric Amodio

commit sha 1ec7c6e8f5002f3fe31b5b0081d8cbb9f0f3d8da

wip

view details

Eric Amodio

commit sha c3022878f66cb732b8186ec4fc2409381ce22e6b

wip

view details

push time in 9 days

push eventeamodio/vscode-gitlens

Eric Amodio

commit sha 61c9d268c86c88f2f36f9185b996cc63502dd91b

Fixes settings metadata - null missing from many

view details

Eric Amodio

commit sha 896b976e6b790ed2af21c8d312a716e0f5c2a273

Uses data uri for gutter hightlight Eventually will allow for ThemeColor customizations

view details

Eric Amodio

commit sha 4335cf7b1653265fe74a4eba72ed363c9b2dd519

Fixes git log paging with merge commits

view details

Eric Amodio

commit sha b8da5320f017190576c0a12d8169f82f944b1b11

Use --first-parent for log with --follow Removes bogus merge commits that can show up in the history

view details

Eric Amodio

commit sha c5811994ea2edee69785610c2bcb3ea44bde269d

Fixes issue w/ previous line diff line # being off

view details

Eric Amodio

commit sha c6f6b7024eafa8ac312bd421d22820683fb2c05f

Ensure right-side diff

view details

Eric Amodio

commit sha 7b80228a2052b858c290417bf6d38330c5878a88

Updates dependencies & lint rules

view details

Eric Amodio

commit sha 6556a3ddc5eadcf55560c7a6dfafdd118143c6bf

Overhauls git command quickpick menus

view details

Eric Amodio

commit sha bfad1a55b90ff2205ad77262e4afb9200b0ce5fc

Fixes lint issues

view details

Eric Amodio

commit sha 9973ebe8787523f6d76b181abbea7eecac08a79c

Updates dependencies & caches eslint

view details

Eric Amodio

commit sha c2da9b57a8e5893a93809b0c6cfefa38191b3ef4

Removes dead telemetry code

view details

Eric Amodio

commit sha e8c572386f8b6e97e03357e3a9771b7ebf63e742

Removes help link until it exists

view details

Eric Amodio

commit sha 0d04c2816c499d483bc98934445a0449ad577282

Fixes #1033 - also switches to ejs templates

view details

Eric Amodio

commit sha 26c26416788814f0c2cdab2a44273fb16a1d1b1e

Changes github auth

view details

push time in 9 days

issue closedeamodio/vscode-gitlens

How to get rid of "blame annotions between lines"?

This might be a silly question, but I simply can't find the right setting to disable blame annotations that appear "between lines". By that I mean all the "You, X minutes ago | 1 author (You)" in the following:

image

I find the annotations very noisy due to the changing line heights and the highly redundant information.

I found 29 settings of GitLens related to "blame", but after half an hour of experimenting I still haven't found the correct setting (maybe I do have to reload the editor after making each change to have an effect?). I just don't know how these things are called properly in GitLens terminology.

closed time in 9 days

bluenote10

issue commenteamodio/vscode-gitlens

How to get rid of "blame annotions between lines"?

Please try using the GitLens interactive settings editor. Using the command palette, run GitLens: Open Settings. The settings you are looking for are called "Code Lens"

bluenote10

comment created time in 9 days

issue commenteamodio/vscode-gitlens

Extension issue

Can you provide more details as to what happened and what error(s) you are seeing?

codenet

comment created time in 9 days

issue openedTypeStrong/fork-ts-checker-webpack-plugin

5.0.0-alpha.2: ESLint support only seems to work on initial compile, not on changes

Current behavior

<!-- Describe how the issue manifests. --> ESLint seems to only run on the initial compile, not on recompile (watch) after changes

Expected behavior

<!-- Describe what the desired behavior would be. --> ESLint should run in both scenarios

Steps to reproduce the issue

<!-- Describe how we can reproduce this problem step by step. --> Enable ESlint, have no ESLint issues on initial watch, then add an ESLint error

Environment

  • fork-ts-checker-webpack-plugin: [5.0.0-alpha.2]
  • typescript: [3.9.3]
  • eslint: [7.1.0]
  • @typescript-eslint/eslint-plugin: [3.0.0]
  • webpack: [4.43.0]
  • os: [Windows 10]

created time in 9 days

create barnchmicrosoft/vscode

branch : eamodio/serverless-github

created branch time in 13 days

issue commentmicrosoft/vscode

Add new theme color for drag feedback indicator lines

@sbatten I think the border I was thinking about would be visible all the time (on the left) -- just like the top border color in the side bar. Could we just re-use that top border color?

eamodio

comment created time in 13 days

issue commentmicrosoft/vscode

Do not access/update the storage state directly

Per conversations with @bpasero & @sandy081 were are simplifying/reducing the features of the default layout api and expanding on the default editors api.

Here is the new api:

interface IDefaultLayout {
	readonly views?: IDefaultView[];
	readonly editors?: IDefaultEditor[];
}

interface IDefaultView {
	readonly id: 'explorer' | 'run' | 'scm' | 'search' | 'extensions' | 'remote' | 'terminal' | 'debug' | 'problems' | 'output' | 'comments' | string;
}

interface IDefaultEditor {
	readonly uri: UriComponents;
	readonly openOnlyIfExists?: boolean;
	readonly viewType?: string;
}

IDefaultLayout.sidebar & IDefaultLayout.panel have been deprecated and replaced by IDefaultLayout.views. IDefaultLayout.views is an array of views that are desired to be active (regardless of current layout location). The first view in the array wins, so if you pass in an array with 2 views, and both views are in the sidebar, then the first view will be the active one.

IDefaultEditor now has a new viewType property which is the type of custom editor that should be opened in place of the default editor (if it exists).

Internally we will be replacing the current tweaking of storage keys from the default layout code, into specific apis exposed by the view service.

sandy081

comment created time in 16 days

issue openedmicrosoft/vscode

Provide open with support to embedding default editors

Currently the embedding api for default editors doesn't allow support for custom editors.

To address this add a viewType: string property to the IDefaultEditor object.

created time in 16 days

issue openedmicrosoft/vscode

Explore bringing GitLens "Git Commands" into built-in Git

Git Commands

Provides guided (step-by-step) access to common Git commands and their flags menu-git-commands

This feature IMO should be moved into VS Code as there is duplication with VS Code commands and it provides a nice unified way of dealing with the growing list of Git commands, of which are hard to discover and deal with different options for. By moving this into VS Code directly, the UX of this feature could be improved as well, to provide a more seamless experience for navigating commands. For example, it would be great if this experience was shown immediately upon typing git (with the space) in the Command Palette. Also many of the hoops and hacks that are needed to provide this experience should be largely eliminated as well (although many could be addressed through an expanded quick pick api).

Including this feature would also eliminate many duplicate git commands between GitLens and VS Code. And also since this feature is on-demand, there is no perf overhead for VS Code to provide this.

created time in 16 days

issue commentmicrosoft/vscode

Truncate and copy large values from the debug console

I definitely want this -- too many times, I find myself searching through large arrays and just wanted to output it as a searchable string and the truncation is very frustrating. Honestly, I would even be happy with a setting that would turn off the truncation altogether.

connor4312

comment created time in 18 days

issue commentgiltho/comby-vscode

Instead of code lenses, open a diff editor

You can open a diff editor using the vscode.diff command (https://code.visualstudio.com/api/references/commands), and then use a TextDocumentContextProvider (or a custom FileSystemProvider) to provide the content based on a url scheme.

felixfbecker

comment created time in 18 days

issue commenteamodio/vscode-amethyst-theme

Unable to distinguish editing area and result area in Python interactive window

@LastsForever Does this still happen on v3? If so, can you check on what color it is currently using? And which theme are you using -- Amethyst or Amethyst Dark?

LastsForever

comment created time in 19 days

issue closedeamodio/vscode-amethyst-theme

amethyst

closed time in 19 days

SKEmercasa

issue openedmicrosoft/vscode

Add `in` operator support to when clauses

Refs: #96927

There is a desire to be able to show a context menu command conditionally on explorer folders (or others) based on computed/determined criteria. For example, lets say I have a folder with a certain file type in it (or all of the same type) and I want to offer a command to only show up for folders that match that criteria. Today this isn't possible, since we don't offer any trigger on selection in the explorer tree (so you can't set a "global" context value), nor is it possible to lookup a context value using another context value.

To address this I propose a new in operator to be supported. This in operator would allow using an existing context key as a lookup key into another context value. The target of the in would be either an array or an object.

For example:

Given something like the following context key,

foldersToShowCommandFor: [ 'test', 'src/foo', 'src/foo/bar' ];

You'd then be able to use the following when on a command:

"menus": {
	"explorer/context": [
		{
			"command": "ext.jsFolder",
                        "when": "explorerResourceIsFolder && resourceFilename in foldersToShowCommandFor"
		}
	]
}

@idoprz Please add any more details or specifics about your use case too.

//cc @alexdima @jrieken

created time in 22 days

push eventeamodio/vscode-amethyst-theme

Eric Amodio

commit sha 81d4e5d227d7a8aa4a862ba8219c58a54c7954fe

Preps v3.0.0

view details

push time in 23 days

create barncheamodio/vscode-gitlens

branch : gitcommands

created branch time in 25 days

issue commentmicrosoft/vscode

Provide some richer (optional) UI for custom tree views

@alefragnani can you open a separate issue for that one - I definitely echo wanting it

eamodio

comment created time in a month

issue commentmicrosoft/vscode

Extension Authors Call for April 2020

Thank you to everyone who participated in this call!

Video

Highlights

  • Request for feedback on the Custom Editor API, as we are very close to finalization — https://github.com/microsoft/vscode/issues/77131
  • Walkthrough and request for feedback on the Timeline API — https://github.com/microsoft/vscode/issues/84297

Participants

Issues

Here are the issues tracking the features, bugs, etc that came up during the call.

  • Webviews in the sidebar — https://github.com/microsoft/vscode/issues/83911
  • Provide some richer (optional) UI for custom tree views — https://github.com/microsoft/vscode/issues/97190

Marketplace

  • Pre-release extension support in the marketplace — #15756

Looking forward to next month!

P.S. Extension authors — join our community run VS Code Developer Community Slack 😄

eamodio

comment created time in a month

issue openedmicrosoft/vscode

Provide some richer (optional) UI for custom tree views

Refs: #96927

It would be great to have some richer optional UI components that could be enabled within a custom view, e.g.

  • Search/Filter box
  • General input box
  • "Details" pane -- kind of like a footer to show details about the selected item(s)
  • Richer hovers https://github.com/microsoft/vscode/issues/84032

@idoprz Can you please add some more details here too?

created time in a month

push eventmicrosoft/vscode

Eric Amodio

commit sha 5b444df9705c42da54aff01128581856f50d0733

Don't overwrite cursor when fetching more recent

view details

push time in a month

issue commentmicrosoft/vscode

Extension Authors Call for April 2020

The call will be held on May 7th (tomorrow) at 9 am Pacific Time.

eamodio

comment created time in a month

issue commentmicrosoft/vscode

Extension Authors Call for March 2020

While I can't really offer any concrete "teeth" outside of tracking issues and championing them -- which I am definitely doing. At the same time, I believe I can confidently say that the call has definitely had an impact on planning.

For example, the following are all in-progress in one stage or another (some in spec/planning, others in implementation)

  • Dashboard stats — #94744
  • Pre-release extension support in the marketplace — #15756
  • Pinned tabs — #12622
  • Provide UI component toolkit — #94741

And all of the other issues have been raised up and reviewed.

To be clear, I don't want "just another list of issues" — I want to create a space where we can hear/see/feel what the community really wants or needs. Hopefully, that will help foster more internal champions and influence planning and direction. I also want to put people and faces to the issues, to "feel" the pain/wants/needs more acutely than in an textual issue -- to help foster a better richer community. On that point, we had other members of the VS Code team listening into the call (and I'm sure others watched it after the fact), as well as members from the marketplace team.

Although, at the same time, just because the community wants or needs something doesn't make it happen (or happen quickly even if we agree), it has to align with team goals, priorities, effort, etc. But the better we understand (truly understand) the needs and wants of the community we will be much better equipped to help provide them.

I would also point back the goals of these calls outlined here: #91714. The above is one of the main goals, while the other is early feedback on proposed APIs. And this next call (#96927) will be diving into some of that.

I hope that makes sense and helps.

eamodio

comment created time in a month

push eventmicrosoft/vscode

Eric Amodio

commit sha 756849af07555b1e8b76883319414a300a59c4ed

Adds diagnostics for github actions

view details

push time in a month

issue commentmicrosoft/vscode

API support for Timeline view

📢 Anyone currently using/trying this API or planning on it please join us in the April Extension Authors call: https://github.com/microsoft/vscode/issues/96927. We will be talking about the Timeline API and would love your feedback as we plan to finalize the API.

eamodio

comment created time in a month

pull request commentmicrosoft/vscode

Open in background on vscode.[open|openWith|diff]

Nothing urgent -- just felt like very low hanging fruit that could help the overhead and experience in the short term.

eamodio

comment created time in a month

PR opened microsoft/vscode

Reviewers
Open in background on vscode.[open|openWith|diff] api api-proposal

This PR fixes #96964

+47 -10

0 comment

3 changed files

pr created time in a month

create barnchmicrosoft/vscode

branch : eamodio/96964

created branch time in a month

issue openedmicrosoft/vscode

Allow opening editors in the background via extension api (commands)

Currently extensions can't control whether or not an editor is opened in the background (not active) or not. For example, in both the built-in Git extension and GitLens, we have commands that open multiple files or diffs. Today VS Code will open a document for each file and then show an editor for each, which will then become the active editor. This is costly, slow (relatively), and causes the UI to visibly jump around as the active editor get switched repeatedly.

We already have a way to support this functionality in core and just need to expose it for the vscode.open, vscode.openWith, and vscode.diff commands. All of those command already take a TextDocumentShowOptions, so I would propose a new TextEditorOpenOptions interface which is identical to TextDocumentShowOptions with the additional background flag:

export interface TextEditorOpenOptions {
	/**
	 * An optional view column in which the [editor](#TextEditor) should be shown.
	 * The default is the [active](#ViewColumn.Active), other values are adjusted to
	 * be `Min(column, columnCount + 1)`, the [active](#ViewColumn.Active)-column is
	 * not adjusted. Use [`ViewColumn.Beside`](#ViewColumn.Beside) to open the
	 * editor to the side of the currently active one.
	 */
	viewColumn?: ViewColumn;

	/**
	 * An optional flag that when `true` will stop the [editor](#TextEditor) from taking focus.
	 */
	preserveFocus?: boolean;

	/**
	 * An optional flag that controls if an [editor](#TextEditor)-tab will be replaced
	 * with the next editor or if it will be kept.
	 */
	preview?: boolean;

	/**
	 * An optional selection to apply for the document in the [editor](#TextEditor).
	 */
	selection?: Range;

	/**
	 * An optional flag that controls if an [editor](#TextEditor)-tab will be opened in the background.
	 */
	background?: boolean
}

I'm proposing a new interface because TextDocumentShowOptions is also shared with the window.showTextDocument function and since it requires a TextDocument and returns a TextEditor it isn't a good fit for this new flag (because it seems silly to have to open a text document to load in the background and also there won't be a TextEditor created so there isn't one to return).

created time in a month

issue commentmicrosoft/vscode

Logpoint causes VS Code to hang while debugging

I also see the same behavior if I add a console.log(fileName); statement to that line. But again, only when debugging.

eamodio

comment created time in a month

issue openedmicrosoft/vscode

Logpoint causes VS Code to hang while debugging

Add a Logpoint of {fileName} or {filename} to the following line and debug VS Code using the VS Code launch config https://github.com/microsoft/vscode/blob/15742965126175e46e70cb3a5bf3662361f3a068/src/vs/platform/diagnostics/node/diagnosticsService.ts#L143

With either the current debugger or js-debug VS Code will hang pretty immediately upon start. Using {fileName} as the Logpoint you should see some output before the hang (and it seems to take a bit longer but that could just be perception).

Version: 1.45.0-insider (user setup)
Commit: fd5d9a30259bb2bebab3e62dfd8315c2e1b27744
Date: 2020-05-04T09:29:52.824Z
Electron: 7.2.4
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.19041

created time in a month

issue commentmicrosoft/vscode

Extension Authors Call for March 2020

@ppezaris All of the issues raised in the call are tracked above, each linked to their own issue -- so you can definitely track them there. As for any more "closing of the loop", what would you be looking for?

@idoprz Sign up here for the April call: https://github.com/microsoft/vscode/issues/96927

eamodio

comment created time in a month

issue closedmicrosoft/vscode

Extension Authors Call for March 2020

Refs: #91714

Here is the rough plan for our extension authors call for March. The call will be on April 7th. The theme of this first call is "ice-breaker" 😄

Agenda

  • [~20 mins] Introductions — we are planning on having ~6 community members and we want to hear about yourselves and your extension(s)
  • [~40 mins] Discussions of each member's answers to "If you had 2 wishes to change/fix/improve VS Code and the marketplace, what would they be and why?", and also 1-2 (smaller) quality-of-life improvement items

Participants

Since we want a small set of participants to facilitate richer and more effective communication, we are asking everyone who is interested in participating to fill out the sign up link below:

Sign up to participate Sign-ups are over for this month's call

Sign-ups will end on April 1st. After which, we will reach out and confirm the set of authors who will be participating in the call, and will update this post with the final list.

Logistics

On April 7th at 9am PT (12pm ET), via a MS Teams call. Unfortunately, for this first call, we won't have a live stream setup for the broader community to join in and comment, but we will post a link to the recorded video at the end of the call. We are definitely looking into getting a live stream setup for future calls.

closed time in a month

eamodio

issue openedmicrosoft/vscode

Extension Authors Call for April 2020

Here is the rough plan for our extension authors call for April. The call will be on May 7th. This call will be focused on the new Timeline view and its API — so if you are interested in providing timeline information please join us!

Agenda

  • [~15 mins] Introductions — please introduce yourselves and your extension(s)
  • [~30 mins] @eamodio will walk through the new Timeline view and associated API. We will then open up for discussion and feedback
  • [~15 mins] Open discussion — please think about 1-2 (smaller) quality-of-life improvement items VS Code could do

Participants

Since we want a small set of participants to facilitate richer and more effective communication, we are asking everyone who is interested in participating to fill out the sign up link below:

Sign up to participate

Sign-ups will end on May 5st (sorry for the short notice). After which, we will reach out and confirm the set of authors who will be participating in the call, and will update this post with the final list.

Logistics

On May 7th at a TBD time, via a MS Teams call. Again, unfortunately, we won't have a live stream setup for the broader community to join in and comment, but we will post a link to the recorded video at the end of the call. We are definitely looking into getting a live stream setup for future calls.

created time in a month

issue commentmicrosoft/vscode

Automatically move focus to working tree compare when opening changes from time line view

@isidorn It seems like we need a good pattern here. enter for me in the Explorer starts a rename, while in SCM it opens the changes and sets focus. space in Explorer opens a file but preserves focus, and doesn't do anything in SCM.

jvesouza

comment created time in a month

push eventmicrosoft/vscode

Eric Amodio

commit sha 091e3dee32a9a605dc96983563201f36875fd95f

Fixes #96795

view details

push time in a month

issue closedmicrosoft/vscode

<hr> in hovers don't span width when stacked

Fix for https://github.com/microsoft/vscode-pull-request-github/issues/1578 (https://github.com/microsoft/vscode/commit/3c0630a09f8f085a3a875854538911e889697d4d) breaks this behavior:

If there are stacked hovers, the <hr> won't span them image

closed time in a month

eamodio

issue openedmicrosoft/vscode

<hr> in hovers don't span width when stacked

Fix for https://github.com/microsoft/vscode-pull-request-github/issues/1578 (https://github.com/microsoft/vscode/commit/3c0630a09f8f085a3a875854538911e889697d4d) breaks this behavior:

If there are stacked hovers, the <hr> won't span them image

created time in a month

CommitCommentEvent
CommitCommentEvent
CommitCommentEvent
CommitCommentEvent
CommitCommentEvent

push eventmicrosoft/vscode

Eric Amodio

commit sha f78c47062a2201f3f319a4535878ef1a43c38ff4

Fixes #96681 & more Adds `workbench.workspaceFirstOpen` workspace setting to control applying a default layout Removes `firstRun` flag from `IDefaultLayout` Changes `IDefaultEditor` to require a `uri` rather than path+scheme - still supports a fallback until embedders can migrate Adds `openOnlyIfExists` property to `IDefaultEditor` for better control on if a file should be opened or not

view details

push time in a month

issue closedmicrosoft/vscode

Welcome always shows even when closed

Steps to Reproduce:

  1. fresh everything, insiders
  2. open some editors (close welcome)
  3. close
  4. start

=> 🐛 welcome puts itself to the front

I actually found this only by trying to fix the smoke tests https://github.com/microsoft/vscode/issues/96459

closed time in a month

bpasero
GollumEvent

issue commentmicrosoft/vscode

Extend Extension API with QuickPickSeparator Support

Well without specified groups there wouldn't be a controlled ordering (especially if the label is also it's identifier). Nor the ability to have label-less groups (just a separator really).

go2sh

comment created time in a month

issue openedmicrosoft/TypeScript

Type narrowing seems to work until calling a function

<!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨

Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a bug, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!

Please help us by doing the following steps before logging an issue:

  • Search: https://github.com/Microsoft/TypeScript/search?type=Issues
  • Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ

Please fill in the entire template below. -->

TypeScript Version: 3.9.1-rc

<!-- Search terms you tried before logging this (so others can find this issue more easily) --> Search Terms:

Expected behavior: Type should be narrowed to successfully call the action method

Actual behavior: Error

<!-- Did you find other bugs that looked similar? --> Related Issues:

Code

export type StepState<T = {}> = T & { counter: number; confirm?: boolean; startingStep?: number };

interface Repository {
	path: string;
}

interface State {
	repos: string | string[] | Repository | Repository[];
	createBranch?: string;
}

function steps(state: StepState<State>) {
	if (state.repos != null && !Array.isArray(state.repos)) {
		// Doesn't work without the cast, or the checks below
		state.repos = [state.repos] as string[] | Repository[];

		// if (typeof state.repos === 'string') {
		// 	state.repos = [state.repos];
		// } else {
		// 	state.repos = [state.repos];
		// }
	}

	// With the cast above, this will be:
	// (property) State.repos: string[] | Repository[]
	state.repos; 
	
	// But it can't be passed here, because it seems the type gets unnarrowed
	// Argument of type 'StepState<State>' is not assignable to parameter of type '{ counter: number; confirm?: boolean | undefined; startingStep?: number | undefined; } & { repos?: string[] | Repository[] | undefined; }'.
	//   Type 'StepState<State>' is not assignable to type '{ repos?: string[] | Repository[] | undefined; }'.
	//     Types of property 'repos' are incompatible.
	//       Type 'string | Repository | string[] | Repository[]' is not assignable to type 'string[] | Repository[] | undefined'.
	//         Type 'string' is not assignable to type 'string[] | Repository[] | undefined'.(2345)
	action(state);
}

function action<State extends StepState & { repos?: string[] | Repository[] }>(state: State) {

}

<details><summary><b>Output</b></summary>

function steps(state) {
    if (state.repos != null && !Array.isArray(state.repos)) {
        // Doesn't work without the cast, or the checks below
        state.repos = [state.repos];
        // if (typeof state.repos === 'string') {
        // 	state.repos = [state.repos];
        // } else {
        // 	state.repos = [state.repos];
        // }
    }
    // With the cast above, this will be:
    // (property) State.repos: string[] | Repository[]
    state.repos;
    // But it can't be passed here, because it seems the type gets unnarrowed
    // Argument of type 'StepState<State>' is not assignable to parameter of type '{ counter: number; confirm?: boolean | undefined; startingStep?: number | undefined; } & { repos?: string[] | Repository[] | undefined; }'.
    //   Type 'StepState<State>' is not assignable to type '{ repos?: string[] | Repository[] | undefined; }'.
    //     Types of property 'repos' are incompatible.
    //       Type 'string | Repository | string[] | Repository[]' is not assignable to type 'string[] | Repository[] | undefined'.
    //         Type 'string' is not assignable to type 'string[] | Repository[] | undefined'.(2345)
    action(state);
}
function action(state) {
}

</details>

<details><summary><b>Compiler Options</b></summary>

{
  "compilerOptions": {
    "noImplicitAny": true,
    "strictNullChecks": true,
    "strictFunctionTypes": true,
    "strictPropertyInitialization": true,
    "strictBindCallApply": true,
    "noImplicitThis": true,
    "noImplicitReturns": true,
    "alwaysStrict": true,
    "esModuleInterop": true,
    "declaration": true,
    "experimentalDecorators": true,
    "emitDecoratorMetadata": true,
    "moduleResolution": 2,
    "target": "ES2017",
    "jsx": "React",
    "module": "ESNext"
  }
}

</details>

Playground Link: Provided

created time in a month

more