profile
viewpoint
Devin Nusbaum dwnusbaum @cloudbees Raleigh, NC

dwnusbaum/boyer-moore-demo 4

Interactive demo of the Boyer-Moore string search algorithm

abayer/jx 0

Jenkins X provides automated CI+CD for Kubernetes with Preview Environments on Pull Requests using Jenkins, Knative Build, Prow, Skaffold and Helm

dwnusbaum/acceptance-test-harness 0

Acceptance tests cases for Jenkins and its plug-ins based on selenium and docker.

dwnusbaum/access-modifier 0

Enforce access restrictions to deprecated code

dwnusbaum/ansicolor-plugin 0

Jenkins ANSI Color Plugin

dwnusbaum/apache-httpcomponents-client-4-api-plugin 0

Apache HttpClient 4.x API Plugin for Jenkins

dwnusbaum/archetypes 0

Collection of Maven archetypes to get developers started

dwnusbaum/blueocean-display-url-plugin 0

Provides a display url implementation

dwnusbaum/blueocean-plugin 0

Blue Ocean is a reboot of the Jenkins CI/CD User Experience

dwnusbaum/bom 0

JENKINS-47498: allow plugin dependencies to be specified via BOM

push eventdwnusbaum/workflow-api-plugin

Devin Nusbaum

commit sha 92aa05cb18720814013d84dbc47ffec9e509c1fc

Preserve NonNull annotations

view details

push time in a day

Pull request review commentjenkinsci/workflow-api-plugin

Revert fixes related to JENKINS-67351 and JENKINS-67164

 public void onLoaded() {                 all.add(execs);                 Futures.addCallback(execs,new FutureCallback<List<StepExecution>>() {                     @Override-                    public void onSuccess(@NonNull List<StepExecution> result) {+                    public void onSuccess(List<StepExecution> result) {

I can, they were only added in my earlier PRs though.

dwnusbaum

comment created time in a day

PullRequestReviewEvent
PullRequestEvent

PR closed jenkinsci/workflow-api-plugin

Revert fixes related to JENKINS-67351 and JENKINS-67164 bug

Reverts #188, #187, and #178 due to problems in https://github.com/jenkinsci/workflow-api-plugin/pull/188 (see https://github.com/jenkinsci/workflow-api-plugin/pull/188#issuecomment-1013382364) which have no obvious fix.

The FlowExecutionList.isResumptionComplete API from #188 is preserved to avoid binary compatibility issues with workflow-durable-task-step prior to https://github.com/jenkinsci/workflow-durable-task-step-plugin/pull/197.

These fixes were generally expected only to apply to uncommon scenarios related to disaster recovery, so I think it is ok to revert them for now.

  • [x] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • [x] Ensure that the pull request title represents the desired changelog entry
  • [x] Please describe what you did
  • [x] Link to relevant issues in GitHub or Jira
  • [x] Link to relevant pull requests, esp. upstream and downstream changes
  • [x] Ensure you have provided tests - that demonstrates feature works or fixes the issue

<!-- Put an x into the [ ] to show you have filled the information. The template comes from https://github.com/jenkinsci/.github/blob/master/.github/pull_request_template.md You can override it by creating .github/pull_request_template.md in your own repository -->

+23 -197

1 comment

2 changed files

dwnusbaum

pr closed time in a day

pull request commentjenkinsci/workflow-api-plugin

Revert fixes related to JENKINS-67351 and JENKINS-67164

Rebuilding, last build was interrupted for some reason.

dwnusbaum

comment created time in a day

PullRequestReviewEvent

Pull request review commentjenkinsci/workflow-api-plugin

Revert fixes related to JENKINS-67351 and JENKINS-67164

 public boolean isResumptionComplete() {     public static class ItemListenerImpl extends ItemListener {         @Override         public void onLoaded() {-            FlowExecutionList list = FlowExecutionList.get();

I went ahead and added the comment back in d923637 as well.

dwnusbaum

comment created time in 2 days

push eventdwnusbaum/workflow-api-plugin

Devin Nusbaum

commit sha d9236371fa028362ddfccab242f1c9593be3d563

Preserve explanatory comment and minor change to log message

view details

push time in 2 days

Pull request review commentjenkinsci/workflow-api-plugin

Revert fixes related to JENKINS-67351 and JENKINS-67164

 public boolean isResumptionComplete() {     public static class ItemListenerImpl extends ItemListener {         @Override         public void onLoaded() {-            FlowExecutionList list = FlowExecutionList.get();

Oh, maybe you are looking at an outdated diff? See fa07adf.

dwnusbaum

comment created time in 2 days

PullRequestReviewEvent

Pull request review commentjenkinsci/workflow-api-plugin

Revert fixes related to JENKINS-67351 and JENKINS-67164

 public boolean isResumptionComplete() {     public static class ItemListenerImpl extends ItemListener {         @Override         public void onLoaded() {-            FlowExecutionList list = FlowExecutionList.get();

You mean just to declare the variable and keep the comment around? Sure I can do that.

dwnusbaum

comment created time in 2 days

PullRequestReviewEvent

Pull request review commentjenkinsci/workflow-api-plugin

Revert fixes related to JENKINS-67351 and JENKINS-67164

 public static FlowExecutionList get() {     }      /**-     * Returns true if all executions that were present in this {@link FlowExecutionList} have been loaded and resumed.-     *-     * This takes place slightly after {@link InitMilestone#COMPLETED} is reached during Jenkins startup.-     *-     * Useful to avoid resuming Pipelines in contexts that may lead to deadlock.+     * @deprecated Only exists for binary compatibility.      */-    @Restricted(Beta.class)+    @Deprecated     public boolean isResumptionComplete() {-        return resumptionComplete;+        return false;     }

false prevents the code added in https://github.com/jenkinsci/workflow-durable-task-step-plugin/pull/188 (and https://github.com/jenkinsci/workflow-durable-task-step-plugin/pull/185) from ever taking effect, like if they were never merged and released in the first place.

dwnusbaum

comment created time in 2 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentjenkinsci/workflow-api-plugin

Revert fixes related to JENKINS-67351 and JENKINS-67164

 import java.util.logging.Level; import java.util.logging.Logger; +import javax.annotation.CheckForNull;

fa07adf

dwnusbaum

comment created time in 5 days

Pull request review commentjenkinsci/workflow-api-plugin

Revert fixes related to JENKINS-67351 and JENKINS-67164

 import com.google.common.util.concurrent.FutureCallback; import com.google.common.util.concurrent.Futures; import com.google.common.util.concurrent.ListenableFuture;-import edu.umd.cs.findbugs.annotations.CheckForNull;-import edu.umd.cs.findbugs.annotations.NonNull;+import com.google.inject.Inject;

fa07adf

dwnusbaum

comment created time in 5 days

PullRequestReviewEvent

push eventdwnusbaum/workflow-api-plugin

Devin Nusbaum

commit sha fa07adf9df7e7b6afb8b4d0d9916ef79ba54c14c

Preserve minor changes that removed Guice and JSR-305 annotations

view details

push time in 5 days

Pull request review commentjenkinsci/workflow-api-plugin

Revert fixes related to JENKINS-67351 and JENKINS-67164

 import java.util.logging.Level; import java.util.logging.Logger; +import javax.annotation.CheckForNull;

ditto

dwnusbaum

comment created time in 5 days

Pull request review commentjenkinsci/workflow-api-plugin

Revert fixes related to JENKINS-67351 and JENKINS-67164

 import com.google.common.util.concurrent.FutureCallback; import com.google.common.util.concurrent.Futures; import com.google.common.util.concurrent.ListenableFuture;-import edu.umd.cs.findbugs.annotations.CheckForNull;-import edu.umd.cs.findbugs.annotations.NonNull;+import com.google.inject.Inject;

I can add a comment to get rid of this again.

dwnusbaum

comment created time in 5 days

PullRequestReviewEvent
PullRequestReviewEvent

PR opened jenkinsci/workflow-api-plugin

Reviewers
Revert fixes related to JENKINS-67351 and JENKINS-67164

Reverts #188, #187, and #178 due to problems in https://github.com/jenkinsci/workflow-api-plugin/pull/188 (see https://github.com/jenkinsci/workflow-api-plugin/pull/188#issuecomment-1013382364) which have no obvious fix.

The FlowExecutionList.isResumptionComplete API from #188 is preserved to avoid binary compatibility issues with workflow-durable-task-step prior to https://github.com/jenkinsci/workflow-durable-task-step-plugin/pull/197.

These fixes were generally expected only to apply to uncommon scenarios related to disaster recovery, so I think it is ok to revert them for now.

  • [x] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • [x] Ensure that the pull request title represents the desired changelog entry
  • [x] Please describe what you did
  • [x] Link to relevant issues in GitHub or Jira
  • [x] Link to relevant pull requests, esp. upstream and downstream changes
  • [x] Ensure you have provided tests - that demonstrates feature works or fixes the issue

<!-- Put an x into the [ ] to show you have filled the information. The template comes from https://github.com/jenkinsci/.github/blob/master/.github/pull_request_template.md You can override it by creating .github/pull_request_template.md in your own repository -->

+33 -202

0 comment

2 changed files

pr created time in 5 days

create barnchdwnusbaum/workflow-api-plugin

branch : revert

created branch time in 5 days

PullRequestReviewEvent

Pull request review commentjenkinsci/workflow-durable-task-step-plugin

Revert fixes related to JENKINS-67351 and JENKINS-67164

 public String getCookie() {         }          @Override public CauseOfBlockage getCauseOfBlockage() {-            if (FlowExecutionList.get().isResumptionComplete()) {

I think I will preserve this API in workflow-api temporarily after I revert PRs over there just in case users update workflow-api before workflow-durable-task-step, but I will just make it always return false.

dwnusbaum

comment created time in 5 days

PR opened jenkinsci/workflow-durable-task-step-plugin

Reviewers
Revert fixes related to JENKINS-67351 and JENKINS-67164

Reverts #188 and #185 due to problems in https://github.com/jenkinsci/workflow-api-plugin/pull/188 (see https://github.com/jenkinsci/workflow-api-plugin/pull/188#issuecomment-1013382364) which have no obvious fix and so require the workflow-api PRs to be reverted. https://github.com/jenkinsci/workflow-api-plugin/pull/188 introduced an API required here after #188, but that API will be removed once the workflow-api PRs are reverted, so we need to revert the PRs here as well.

These fixes were generally expected only to apply to uncommon scenarios related to disaster recovery (although they apparently also mattered for regular usage of ci.jenkins.io as mentioned in https://github.com/jenkinsci/workflow-durable-task-step-plugin/pull/185#issuecomment-999703045), so I think it is ok to revert them for now.

  • [x] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • [x] Ensure that the pull request title represents the desired changelog entry
  • [x] Please describe what you did
  • [x] Link to relevant issues in GitHub or Jira
  • [x] Link to relevant pull requests, esp. upstream and downstream changes
  • [x] Ensure you have provided tests - that demonstrates feature works or fixes the issue

<!-- Put an x into the [ ] to show you have filled the information. The template comes from https://github.com/jenkinsci/.github/blob/master/.github/pull_request_template.md You can override it by creating .github/pull_request_template.md in your own repository -->

+2 -60

0 comment

2 changed files

pr created time in 5 days

push eventdwnusbaum/workflow-durable-task-step-plugin

Devin Nusbaum

commit sha 185989a7c4e59fc071bc26516bc5cd8bdae427d1

Revert "Recover gracefully when a `PlaceholderTask` is in the queue but the associated build is complete (#185)" This reverts commit 9c8d2f466adbc4f948fb659ed8f92f0aad5e6d6f.

view details

push time in 5 days

more