profile
viewpoint

dvanbrug/fog-google 0

Fog for Google Cloud Platform

dvanbrug/osate2 0

Open Source AADL2 Tool Environment

dvanbrug/pandas-profiling 0

Create HTML profiling reports from pandas DataFrame objects

dvanbrug/system-design-primer 0

Learn how to design large-scale systems. Prep for the system design interview. Includes Anki flashcards.

dvanbrug/vagrant-google 0

Vagrant provider for GCE.

pull request commentosate/osate2

Fix NestedClaimReference construction

@joeseibel Sorry, I did not mean to re-request a review. I was just taking a look at the status.

dvanbrug

comment created time in 2 months

PR opened osate/osate2

Fix NestedClaimReference construction

Per #2381 , Subclaims are not correctly rendered in the ALISA Assurance View.

The following method constructClaimReferencePath is responsible for building the NestedClaimReference object that is used by the Assurance View. It appears that the method never adds the subclaim object.

Lines 490-498 in AssureConstructor.xtend https://github.com/osate/osate2/blob/f3d0613e0869dc8830e6ff0f5e43fc9f79e3b185/alisa/org.osate.assure/src/org/osate/assure/generator/AssureConstructor.xtend#L490-L498

If we add the following line after the creation of parentNcr (line 495), the subclaims are correctly added to the parent object.

parentNcr.sub = ncr
+1 -0

0 comment

1 changed file

pr created time in 3 months

issue openedosate/osate2

Assurance View does not correctly render subclaims

<!-- If you want to ask a question or if you are not sure if there really is a bug in OSATE, post on the google group first, please. https://groups.google.com/forum/#!forum/osate --> <!-- Use regular sentence capitalization in issue title and use the preview tab to check the bug report before submitting it, please. -->

Summary

When creating a Verification Plan with nested subclaims, the “Assurance View” does not correctly render the Evidence or Description fields for the subclaims. All of the subclaims inherit the parent’s name / description instead of their own.

Expected and Current Behavior

Define a reqspec top level claim C1 and two nested claims C2 and C3 in the following structure:

  • C1 – Claim 1

    • C2 – Claim 2

    • C3 – Claim 3

I would expect the “Assurance View” to display the Assurance Plan in a similar structure. Instead, it outputs the following:

  • C1 – Claim 1

    • C1 – Claim 1

    • C1 – Claim 1

Steps to Reproduce

1.) Start with the following Alisa example: SimpleControlSystem (https://github.com/osate/alisa-examples/blob/master/SimpleControlSystem)

  • An example of nested subclaims can be seen in the SimpleControlSystem/dualscsvplan.verify file: https://github.com/osate/alisa-examples/blob/master/SimpleControlSystem/SimpleControlSystem/alisa/dualscsvplan.verify

2.) However, this verification plan is not used in an Assurance Case. If we modify the SCSCase (SCSVerification.alisa) by adding the following assurance plan entry, we can cause these to be evaluated.


assurance plan DualSCSPlan for SimpleControlSystem::SCSDualPower.impl [
		assure DualSCSvplan
	]

3.) Add implementation to SimpleControlSystem.aadl


system implementation SCSDualPower.impl
end SCSDualPower.impl;

4.) Open the "Assurance View" and select the SCSCase Assurance Case. You should see something similar to the following image:

OSATE_bugfix

However, instead it should look the the next message:

OSATE_bugfix_2

Environment

  • OSATE Version: 2.7.1
  • Operating System: All

Proposed Fix

The following method constructClaimReferencePath is responsible for building the NestedClaimReference object that is used by the Assurance View. It appears that the method never adds the subclaim object.

Lines 490-498 in AssureConstructor.xtend https://github.com/osate/osate2/blob/f3d0613e0869dc8830e6ff0f5e43fc9f79e3b185/alisa/org.osate.assure/src/org/osate/assure/generator/AssureConstructor.xtend#L490-L498

If we add the following line after the creation of parentNcr (line 495), the subclaims are correctly added to the parent object.

parentNcr.sub = ncr

I will submit a pull request with this change as a possible fix.

created time in 3 months

create barnchdvanbrug/osate2

branch : dvanbrug-subclaim-fix

created branch time in 3 months

fork dvanbrug/osate2

Open Source AADL2 Tool Environment

http://osate.org

fork in 3 months

more