profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/dscho/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Johannes Schindelin dscho @Microsoft @git-for-windows maintainer.

dscho/cpptasks 3

A git-svn fork of the ant-contrib package cpptasks

dscho/Arduino 2

open-source electronics prototyping platform

dscho/bioformats 1

Bio-Formats is a Java library for reading and writing data in life sciences image file formats. It is developed by the Open Microscopy Environment (particularly UW-Madison LOCI and Glencoe Software). Bio-Formats is released under the GNU General Public License (GPL); commercial licenses are available from Glencoe Software.

dscho/connectbot 1

ConnectBot development has moved back to Google Code! See http://connectbot.org/ for details!

derrickstolee/git_osx_installer 0

Installer for OS X

ditard/submoduleupdate_issue 0

Minimal test reposirory to reproduce GIT submodule update issue

dscho/action-tmate 0

Debug your GitHub Actions via SSH by using tmate to get access to the runner system itself.

dscho/active-cells-ij2 0

Active Cells for ImageJ2

dscho/angiotool 0

A trial to convert AngioTool ( https://ccrod.cancer.gov/confluence/display/ROB2/Home ) into a Fiji plugin

pull request commentgit-for-windows/git

Teach Git to handle huge files in smudge/clean

@vtbassmatt thank you for sharing access to a Git LFS-enabled test repository with me privately. I can confirm that the 5GB file fails to check out with the current Git for Windows version:

me@work MINGW64 ~/repros/large-file-lfs-3487/lfs-testing (master)
$ git switch large-file
Switched to a new branch 'large-file'
Branch 'large-file' set up to track remote branch 'large-file' from 'origin'.
Encountered 1 file(s) that may not have been copied correctly on Windows:
        large-file.bin

See: `git lfs help smudge` for more details.

me@work MINGW64 ~/repros/large-file-lfs-3487/lfs-testing (large-file)
$ ls -lah large-file.bin
-rw-r--r-- 1 me 4096 1.0G Oct 25 19:58 large-file.bin

And when I clone this (in hindsight, I could have just created a simple local test repository...) with the Git built from your PR branch, it works!!! 🎉

me@work MINGW64 /usr/src/git/wip8 (huge-file-smudge-clean)
$ ./bin-wrappers/git -C ~/repros/large-file-lfs-3487/ clone lfs-testing test-with-fixed-git
Cloning into 'test-with-fixed-git'...
done.
Updating files: 100% (507/507), done.
Filtering content: 100% (505/505), 1.00 GiB | 13.17 MiB/s, done.
Encountered 1 file(s) that may not have been copied correctly on Windows:
        large-file.bin

See: `git lfs help smudge` for more details.

me@work MINGW64 /usr/src/git/wip8 (huge-file-smudge-clean)
$ ls -lh ~/repros/large-file-lfs-3487/test-with-fixed-git/large-file.bin
-rw-r--r-- 1 me 4096 5.0G Oct 26 09:20 /c/Users/johasc/repros/large-file-lfs-3487/test-with-fixed-git/large-file.bin

The only remaining issue is that Git LFS has no way of knowing that Git for Windows got the size right, and therefore still offers the warning that "1 file(s) [...] may not have been copied correctly" (emphasis mine).

vtbassmatt

comment created time in 13 minutes

push eventgitgitgadget/git

Han-Wen Nienhuys

commit sha aa30fe1481b9af54efea9a14a367811849a339e5

branch tests: test for errno propagating on failing read Add a test for "git branch" to cover the case where .git/refs is symlinked. To check availability, refs_verify_refname_available() will run refs_read_raw_ref() on each prefix, leading to a read() from .git/refs (which is a directory). It would probably be more robust to re-issue the lstat() as a normal stat(), in which case, we would fall back to the directory case, but for now let's just test for the existing behavior as-is. This test covers a regression in a commit that only ever made it to "next", see [1]. 1. http://lore.kernel.org/git/pull.1068.git.git.1629203489546.gitgitgadget@gmail.com Signed-off-by: Han-Wen Nienhuys <hanwen@google.com> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Ævar Arnfjörð Bjarmason

commit sha ef18119dec8a9c65ed545fdd60c7ae9a6bc31f6f

refs API: add a version of refs_resolve_ref_unsafe() with "errno" Add a new refs_werrres_ref_unsafe() function, which is like refs_resolve_ref_unsafe() except that it explicitly saves away the "errno" to a passed-in parameter, the refs_resolve_ref_unsafe() then becomes a wrapper for it. In subsequent commits we'll migrate code over to it, before finally making "refs_resolve_ref_unsafe()" with an "errno" parameter the canonical version, so this this function exists only so that we can incrementally migrate callers, it will be going away in a subsequent commit. As the added comment notes has a rather tortured name to be the same length as "refs_resolve_ref_unsafe", to avoid churn as we won't need to re-indent the argument lists, similarly the documentation and structure of it in refs.h is designed to minimize a diff in a subsequent commit, where that documentation will be added to the new refs_resolve_ref_unsafe(). At the end of this migration the "meaningful errno" TODO item left in 76d70dc0c63 (refs.c: make resolve_ref_unsafe set errno to something meaningful on error, 2014-06-20) will be resolved. As can be seen from the use of refs_read_raw_ref() we'll also need to convert some functions that the new refs_werrres_ref_unsafe() itself calls to take this "failure_errno". That will be done in subsequent commits. Signed-off-by: Han-Wen Nienhuys <hanwen@google.com> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Han-Wen Nienhuys

commit sha 8b72fea7e91b5900c3a35891df1d8ea16d4b2bee

refs API: make refs_read_raw_ref() not set errno Add a "failure_errno" to refs_read_raw_ref(), his allows refs_werrres_ref_unsafe() to pass along its "failure_errno", as a first step before its own callers are migrated to pass it further up the chain. We are leaving out out the refs_read_special_head() in refs_read_raw_ref() for now, as noted in a subsequent commit moving it to "failure_errno" will require some special consideration. Signed-off-by: Han-Wen Nienhuys <hanwen@google.com> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Han-Wen Nienhuys

commit sha df3458e95710b14bff1e5acb830ad77b2a4b0c73

refs API: make parse_loose_ref_contents() not set errno Change the parse_loose_ref_contents() function to stop setting "errno" and failure, and to instead pass up a "failure_errno" via a parameter. This requires changing its callers to do the same. The EINVAL error from parse_loose_ref_contents is used in files-backend to create a custom error message. In untangling this we discovered a tricky edge case. The refs_read_special_head() function was relying on parse_loose_ref_contents() setting EINVAL. By converting it to use "saved_errno" we can migrate away from "errno" in this part of the code entirely, and do away with an existing "save_errno" pattern, its only purpose was to not clobber the "errno" we previously needed at the end of files_read_raw_ref(). Let's assert that we can do that by not having files_read_raw_ref() itself operate on *failure_errno in addition to passing it on. Instead we'll assert that if we return non-zero we actually do set errno, thus assuring ourselves and callers that they can trust the resulting "failure_errno". Signed-off-by: Han-Wen Nienhuys <hanwen@google.com> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Ævar Arnfjörð Bjarmason

commit sha c339ff690f5b5a9f27e27f4cb4d22023a0b7ebaf

refs API: make refs_rename_ref_available() static Move the refs_rename_ref_available() function into "refs/files-backend.c". It is file-backend specific. This function was added in 5fe7d825da8 (refs.c: pass a list of names to skip to is_refname_available, 2014-05-01) as rename_ref_available() and was only ever used in this one file-backend specific codepath. So let's move it there. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Ævar Arnfjörð Bjarmason

commit sha 5ac15ad2509f31555cbb40fece720066c5d8a01b

reflog tests: add --updateref tests Add tests that cover blindspots in "git reflog delete --updateref" behavior. Before this change removing the "type & REF_ISSYMREF" check added in 5e6f003ca8a (reflog_expire(): ignore --updateref for symbolic references, 2015-03-03) would not fail any tests. The "--updateref" option was added in 55f10565371 (git-reflog: add option --updateref to write the last reflog sha1 into the ref, 2008-02-22) for use in git-stash.sh, see e25d5f9c82e (git-stash: add new 'drop' subcommand, 2008-02-22). Even though the regression test I need is just the "C" case here, let's test all these combinations for good measure. I started out doing these as a for-loop, but I think this is more readable. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Ævar Arnfjörð Bjarmason

commit sha 52106430dc80ea20ec2e00a6079a7bc114d36b70

refs/files: remove "name exist?" check in lock_ref_oid_basic() In lock_ref_oid_basic() we'll happily lock a reference that doesn't exist yet. That's normal, and is how references are initially born, but we don't need to retain checks here in lock_ref_oid_basic() about the state of the ref, when what we're checking is either checked already, or something we're about to discover by trying to lock the ref with raceproof_create_file(). The one exception is the caller in files_reflog_expire(), who passes us a "type" to find out if the reference is a symref or not. We can move the that logic over to that caller, which can now defer its discovery of whether or not the ref is a symref until it's needed. In the preceding commit an exhaustive regression test was added for that case in a new test in "t1417-reflog-updateref.sh". The improved diagnostics here were added in 5b2d8d6f218 (lock_ref_sha1_basic(): improve diagnostics for ref D/F conflicts, 2015-05-11), and then much of the surrounding code went away recently in my 245fbba46d6 (refs/files: remove unused "errno == EISDIR" code, 2021-08-23). The refs_resolve_ref_unsafe() code being removed here looks like it should be tasked with doing that, but it's actually redundant to other code. The reason for that is as noted in 245fbba46d6 this once widely used function now only has a handful of callers left, which all handle this case themselves. To the extent that we're racy between their check and ours removing this check actually improves the situation, as we'll be doing fewer things between the not-under-lock initial check and acquiring the lock. Why this is OK for all the remaining callers of lock_ref_oid_basic() is noted below. There are only two of those callers: * "git branch -[cm] <oldbranch> <newbranch>": In files_copy_or_rename_ref() we'll call this when we copy or rename refs via rename_ref() and copy_ref(). but only after we've checked if the refname exists already via its own call to refs_resolve_ref_unsafe() and refs_rename_ref_available(). As the updated comment to the latter here notes neither of those are actually needed. If we delete not only this code but also refs_rename_ref_available() we'll do just fine, we'll just emit a less friendly error message if e.g. "git branch -m A B/C" would have a D/F conflict with a "B" file. Actually we'd probably die before that in case reflogs for the branch existed, i.e. when the try to rename() or copy_file() the relevant reflog, since if we've got a D/F conflict with a branch name we'll probably also have the same with its reflogs (but not necessarily, we might have reflogs, but it might not). As some #leftoverbits that code seems buggy to me, i.e. the reflog "protocol" should be to get a lock on the main ref, and then perform ref and/or reflog operations. That code dates back to c976d415e53 (git-branch: add options and tests for branch renaming, 2006-11-28) and probably pre-dated the solidifying of that convention. But in any case, that edge case is not our bug or problem right now. * "git reflog expire <ref>": In files_reflog_expire() we'll call this without previous ref existence checking in files-backend.c, but that code is in turn called by code that's just finished checking if the refname whose reflog we're expiring exists. See ae35e16cd43 (reflog expire: don't lock reflogs using previously seen OID, 2021-08-23) for the current state of that code, and 5e6f003ca8a (reflog_expire(): ignore --updateref for symbolic references, 2015-03-03) for the code we'd break if we only did a "update = !!ref" here, which is covered by the aforementioned regression test in "t1417-reflog-updateref.sh". Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Ævar Arnfjörð Bjarmason

commit sha 76887df01440018e1e757761fea81a4d3a676f25

refs API: remove refs_read_ref_full() wrapper Remove the refs_read_ref_full() wrapper in favor of migrating various refs.c API users to the underlying refs_werrres_ref_unsafe() function. A careful reading of these callers shows that the callers of this function did not care about "errno", by moving away from the refs_resolve_ref_unsafe() wrapper we can be sure that nothing relies on it anymore. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Ævar Arnfjörð Bjarmason

commit sha db7a3d25d639ba816fb85af3ca08d689702ab294

refs API: make resolve_gitlink_ref() not set errno I have carefully read the upstream callers of resolve_gitlink_ref() and determined that they don't care about errno. So let's move away from the errno-setting refs_resolve_ref_unsafe() wrapper to refs_werrres_ref_unsafe(), and explicitly ignore the errno it sets for us. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Ævar Arnfjörð Bjarmason

commit sha 096a7fbb97dc4015c97b1811aab4e08e2f0ac724

refs API: make loose_fill_ref_dir() not set errno Change the refs_resolve_ref_unsafe() invoked in loose_fill_ref_dir() to a form that ignores errno. The only eventual caller of this function is create_ref_cache(), whose callers in turn don't have their failure depend on any errno set here. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Ævar Arnfjörð Bjarmason

commit sha ac0986e302b9a94fd927e8d0a811fe6dc4d4c074

refs API: make files_copy_or_rename_ref() et al not set errno None of the callers of rename_ref() and copy_ref() care about errno, and as seen in the context here we already emit our own non-errno using error() in the case where we'd use it. So let's have it explicitly ignore errno, and do the same in commit_ref_update(), which is only used within other code in files_copy_or_rename_ref() itself which doesn't care about errno either. It might actually be sensible to have the callers use errno if the failure was filesystem-specific, and with the upcoming reftable backend we don't want to rely on that sort of thing, so let's keep ignoring that for now. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Ævar Arnfjörð Bjarmason

commit sha ccf3cc1b189f732cb1e99b08bda37e92a896047f

refs API: ignore errno in worktree.c's add_head_info() The static add_head_info() function is only used indirectly by callers of get_worktrees(), none of whom care about errno, and even if they did having the faked-up one from refs_resolve_ref_unsafe() would only confuse them if they used die_errno() et al. So let's explicitly ignore it here. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Ævar Arnfjörð Bjarmason

commit sha 0506eb71f7b64dac71ae35fafa7ca23c7a41e276

refs API: ignore errno in worktree.c's find_shared_symref() There are only handful of callers of find_shared_symref(), none of whom care about errno, so let's migrate to the non-errno-propagating version of refs_resolve_ref_unsafe() and explicitly ignore errno here. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Ævar Arnfjörð Bjarmason

commit sha 6846f7248d2915e534eebf1457600b83573f981d

refs tests: ignore ignore errno in test-ref-store helper The cmd_resolve_ref() function has always ignored errno on failure, but let's do so explicitly when using the refs_resolve_ref_unsafe() function. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Ævar Arnfjörð Bjarmason

commit sha f65bb9fb06f969e8fb89de2d6dc9218f13cb361c

refs API: make refs_resolve_refdup() not set errno Move refs_resolve_refdup() from the legacy refs_resolve_ref_unsafe() to the new refs_werrres_ref_unsafe(). I have read its callers and determined that they don't care about errno being set. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Ævar Arnfjörð Bjarmason

commit sha 1e3ccb552f3d9166009ca2bc40b27bbc0c0e2b78

refs API: make refs_ref_exists() not set errno Move refs_ref_exists from the legacy refs_resolve_ref_unsafe() to the new refs_werrres_ref_unsafe(). I have read its callers and determined that they don't care about errno being set, in particular: git grep -W -w -e refs_ref_exists -e ref_exists Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Ævar Arnfjörð Bjarmason

commit sha ed90f04155df1ec757b241ae3f45889c05efae26

refs API: make resolve_ref_unsafe() not set errno Change the resolve_ref_unsafe() wrapper function to use the underlying refs_werrres_ref_unsafe() directly. From a reading of the callers I determined that the only one who cared about errno was a sequencer.c caller added in e47c6cafcb5 (commit: move print_commit_summary() to libgit, 2017-11-24), I'm migrating it to using refs_werrres_ref_unsafe() directly. This adds another "set errno" instance, but in this case it's OK and idiomatic. We are setting it just before calling die_errno(). We could have some hypothetical die_errno_var(&saved_errno, ...) here, but I don't think it's worth it. The problem with errno is subtle action at distance, not this sort of thing. We already use this pattern in a couple of places in wrapper.c Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Ævar Arnfjörð Bjarmason

commit sha 6582bd31e3f3fa6cfb16fae0cd31036081c14a0a

refs API: make expand_ref() & repo_dwim_log() not set errno The use of these two is rather trivial, and it's easy to see none of their callers care about errno. So let's move them from refs_resolve_ref_unsafe() to refs_resolve_ref_unsafe_with_errno(), these were the last two callers, so we can get rid of that wrapper function. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Ævar Arnfjörð Bjarmason

commit sha 4755d7dff7a27f431493926541fd6aab2e860aa4

refs API: don't expose "errno" in run_transaction_hook() In run_transaction_hook() we've checked errno since 67541597670 (refs: implement reference transaction hook, 2020-06-19), let's reset errno afterwards to make sure nobody using refs.c directly or indirectly relies on it. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Ævar Arnfjörð Bjarmason

commit sha 25a33b33424cd6c8e2c7db0f0c4b1ba01415ce38

refs API: post-migration API renaming [1/2] In preceding commits all callers of refs_resolve_ref_unsafe() were migrated to the transitory refs_werrres_ref_unsafe() function. As a first step in getting rid of it let's remove the old function from the public API (it went unused in a preceding commit). We then provide both a coccinelle rule to do the rename, and a macro to avoid breaking the existing callers. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

push time in 8 hours

push eventgitgitgadget/git

Junio C Hamano

commit sha 061a21d36d807bdcf996f388d5e487d5e1993bbc

Merge branch 'ab/fsck-unexpected-type' "git fsck" has been taught to report mismatch between expected and actual types of an object better. * ab/fsck-unexpected-type: fsck: report invalid object type-path combinations fsck: don't hard die on invalid object types object-file.c: stop dying in parse_loose_header() object-file.c: return ULHR_TOO_LONG on "header too long" object-file.c: use "enum" return type for unpack_loose_header() object-file.c: simplify unpack_loose_short_header() object-file.c: make parse_loose_header_extended() public object-file.c: return -1, not "status" from unpack_loose_header() object-file.c: don't set "typep" when returning non-zero cat-file tests: test for current --allow-unknown-type behavior cat-file tests: add corrupt loose object test cat-file tests: test for missing/bogus object with -t, -s and -p cat-file tests: move bogus_* variable declarations earlier fsck tests: test for garbage appended to a loose object fsck tests: test current hash/type mismatch behavior fsck tests: refactor one test to use a sub-repo fsck tests: add test for fsck-ing an unknown type

view details

Junio C Hamano

commit sha 91016984db40c41df0ab8ec39344e703cf6a2a2b

Merge branch 'jh/perf-remove-test-times' Perf test fix. * jh/perf-remove-test-times: t/perf/perf-lib.sh: remove test_times.* at the end test_perf_()

view details

Junio C Hamano

commit sha bfa646c2cbad55cf652344415616eadc9e20f3c4

Merge branch 'ab/unpack-trees-leakfix' Leakfix. * ab/unpack-trees-leakfix: sequencer: fix a memory leak in do_reset() sequencer: add a "goto cleanup" to do_reset() unpack-trees: don't leak memory in verify_clean_subdirectory()

view details

Junio C Hamano

commit sha 162a13b855ee8d920a31d6d1e928cef0f0a18e18

Merge branch 'jt/no-abuse-alternate-odb-for-submodules' Follow through the work to use the repo interface to access submodule objects in-process, instead of abusing the alternate object database interface. * jt/no-abuse-alternate-odb-for-submodules: submodule: trace adding submodule ODB as alternate submodule: pass repo to check_has_commit() object-file: only register submodule ODB if needed merge-{ort,recursive}: remove add_submodule_odb() refs: peeling non-the_repository iterators is BUG refs: teach arbitrary repo support to iterators refs: plumb repo into ref stores

view details

Junio C Hamano

commit sha 525705a0a24ec13aedda8acc5f826295f7888c0e

Merge branch 'rs/disable-gc-during-perf-tests' Avoid performance measurements from getting ruined by gc and other housekeeping pauses interfering in the middle. * rs/disable-gc-during-perf-tests: perf: disable automatic housekeeping

view details

Junio C Hamano

commit sha 6ffb5fc06940ebb312b5cb010246e27c1b6aead0

Merge branch 'rs/add-dry-run-without-objects' Stop "git add --dry-run" from creating new blob and tree objects. * rs/add-dry-run-without-objects: add: don't write objects with --dry-run

view details

Junio C Hamano

commit sha 2c428e4205a50cee19669d5b73cc149ec2254a5d

Merge branch 'ab/fix-commit-error-message-upon-unwritable-object-store' "git commit" gave duplicated error message when the object store was unwritable, which has been corrected. * ab/fix-commit-error-message-upon-unwritable-object-store: commit: fix duplication regression in permission error output unwritable tests: assert exact error output

view details

Junio C Hamano

commit sha e058b1846c3b2051aab364d7b80e8c1696958a48

Merge branch 'pw/sparse-cache-tree-verify-fix' Recent sparse-index addition, namely any use of index_name_pos(), can expand sparse index entries and breaks any code that walks cache-tree or existing index entries. One such instance of such a breakage has been corrected. * pw/sparse-cache-tree-verify-fix: t1092: run "rebase --apply" without "-q" in testing sparse index: fix use-after-free bug in cache_tree_verify()

view details

Junio C Hamano

commit sha 18c6653da0be924f83415f987d76f6813b81f086

Merge branch 'fs/ssh-signing' Use ssh public crypto for object and push-cert signing. * fs/ssh-signing: ssh signing: test that gpg fails for unknown keys ssh signing: tests for logs, tags & push certs ssh signing: duplicate t7510 tests for commits ssh signing: verify signatures using ssh-keygen ssh signing: provide a textual signing_key_id ssh signing: retrieve a default key from ssh-agent ssh signing: add ssh key format and signing code ssh signing: add test prereqs ssh signing: preliminary refactoring and clean-up

view details

Junio C Hamano

commit sha ef1639145de771d33fe5b919f13debaaeaca35f7

Merge branch 'fs/ssh-signing-fix' Fix-up for the other topic already in 'next'. * fs/ssh-signing-fix: gpg-interface: fix leak of strbufs in get_ssh_key_fingerprint() gpg-interface: fix leak of "line" in parse_ssh_output() ssh signing: clarify trustlevel usage in docs ssh signing: fmt-merge-msg tests & config parse

view details

Junio C Hamano

commit sha 6a1bb089fda35768b7649a91bf890e619c32e8e8

Merge branch 'da/mergetools-special-case-xxdiff-exit-128' The xxdiff difftool backend can exit with status 128, which the difftool-helper that launches the backend takes as a significant failure, when it is not significant at all. Work it around. * da/mergetools-special-case-xxdiff-exit-128: mergetools/xxdiff: prevent segfaults from stopping difftool

view details

Junio C Hamano

commit sha f3f157ff2774527a84bad7df1a95a63b7a2f4a4b

Merge branch 'js/userdiff-cpp' Userdiff patterns for the C++ language has been updated. * js/userdiff-cpp: userdiff-cpp: back out the digit-separators in numbers userdiff-cpp: learn the C++ spaceship operator userdiff-cpp: permit the digit-separating single-quote in numbers userdiff-cpp: prepare test cases with yet unsupported features userdiff-cpp: tighten word regex t4034: add tests showing problematic cpp tokenizations t4034/cpp: actually test that operator tokens are not split

view details

Junio C Hamano

commit sha 65ca3245f99e3595ac483e4af5b2ff34b7985635

Merge branch 'ab/parse-options-cleanup' Random changes to parse-options implementation. * ab/parse-options-cleanup: parse-options: change OPT_{SHORT,UNSET} to an enum parse-options tests: test optname() output parse-options.[ch]: make opt{bug,name}() "static" commit-graph: stop using optname() parse-options.c: move optname() earlier in the file parse-options.h: make the "flags" in "struct option" an enum parse-options.c: use exhaustive "case" arms for "enum parse_opt_result" parse-options.[ch]: consistently use "enum parse_opt_result" parse-options.[ch]: consistently use "enum parse_opt_flags" parse-options.h: move PARSE_OPT_SHELL_EVAL between enums

view details

Junio C Hamano

commit sha 5a4f8381b68b39e1a39e78039ddb2c415927cb12

Merge branch 'ab/mark-leak-free-tests' Bunch of tests are marked as "passing leak check". * ab/mark-leak-free-tests: leak tests: mark some misc tests as passing with SANITIZE=leak leak tests: mark various "generic" tests as passing with SANITIZE=leak leak tests: mark some read-tree tests as passing with SANITIZE=leak leak tests: mark some ls-files tests as passing with SANITIZE=leak leak tests: mark all checkout-index tests as passing with SANITIZE=leak leak tests: mark all trace2 tests as passing with SANITIZE=leak leak tests: mark all ls-tree tests as passing with SANITIZE=leak leak tests: run various "test-tool" tests in t00*.sh SANITIZE=leak leak tests: run various built-in tests in t00*.sh SANITIZE=leak

view details

Junio C Hamano

commit sha 54c4f8ce52f20ea1be99c780ce19867964f430b7

Merge branch 'ab/mark-leak-free-tests-more' Bunch of tests are marked as "passing leak check". * ab/mark-leak-free-tests-more: merge: add missing strbuf_release() ls-files: add missing string_list_clear() ls-files: fix a trivial dir_clear() leak tests: fix test-oid-array leak, test in SANITIZE=leak tests: fix a memory leak in test-oidtree.c tests: fix a memory leak in test-parse-options.c tests: fix a memory leak in test-prio-queue.c

view details

Junio C Hamano

commit sha 97ab03b12a044ded55de68aac160ffb72c951830

Merge branch 'jc/doc-commit-header-continuation-line' Doc update. * jc/doc-commit-header-continuation-line: signature-format.txt: explain and illustrate multi-line headers

view details

Junio C Hamano

commit sha 67f310e1adfe3cc186aa3dd5c1acfc94398540cc

Merge branch 'ab/test-cleanly-recreate-trash-directory' Improve test framework around unwritable directories. * ab/test-cleanly-recreate-trash-directory: test-lib.sh: try to re-chmod & retry on failed trash removal

view details

Junio C Hamano

commit sha d54fd59d848422989268088c8fba01a5c27e8dc2

Merge branch 'tb/fix-midx-rename-while-mapped' The codepath to write a new version of .midx multi-pack index files has learned to release the mmaped memory holding the current version of .midx before removing them from the disk, as some platforms do not allow removal of a file that still has mapping. * tb/fix-midx-rename-while-mapped: midx.c: guard against commit_lock_file() failures midx.c: lookup MIDX by object directory during repack midx.c: lookup MIDX by object directory during expire midx.c: extract MIDX lookup by object_dir

view details

Junio C Hamano

commit sha 06355d72dc610ec3806cda328ec9b347a5daed5b

Merge branch 'ab/pkt-line-cleanup' Code clean-up. * ab/pkt-line-cleanup: pkt-line.[ch]: remove unused packet_read_line_buf() pkt-line.[ch]: remove unused packet_buf_write_len()

view details

Junio C Hamano

commit sha 63ec2297d26155adb0e38745bf2284cd663add8e

Merge branch 'ab/fix-make-lint-docs' Build fix. * ab/fix-make-lint-docs: doc lint: make "lint-docs" non-.PHONY doc build: speed up "make lint-docs" doc lint: emit errors on STDERR doc lint: fix error-hiding regression

view details

push time in 8 hours

push eventgitgitgadget/git

Junio C Hamano

commit sha 28ecef4c84af0b3300b84e73d2a7749e9a4ac83f

Merge branch 'jk/grep-haystack-is-read-only' into hm/paint-hits-in-log-grep * jk/grep-haystack-is-read-only: grep: store grep_source buffer as const grep: mark "haystack" buffers as const grep: stop modifying buffer in grep_source_1() grep: stop modifying buffer in show_line() grep: stop modifying buffer in strip_timestamp

view details

Hamza Mahfooz

commit sha 3f566c4e695a6df8237c34b7c1f34f0832b7e575

grep: refactor next_match() and match_one_pattern() for external use These changes are made in preparation of, the colorization support for the "git log" subcommands that, rely on regex functionality (i.e. "--author", "--committer" and "--grep"). These changes are necessary primarily because match_one_pattern() expects header lines to be prefixed, however, in pretty, the prefixes are stripped from the lines because the name-email pairs need to go through additional parsing, before they can be printed and because next_match() doesn't handle the case of "ctx == GREP_CONTEXT_HEAD" at all. So, teach next_match() how to handle the new case and move match_one_pattern()'s core logic to headerless_match_one_pattern() while preserving match_one_pattern()'s uses that depend on the additional processing. Signed-off-by: Hamza Mahfooz <someguy@effective-light.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Hamza Mahfooz

commit sha 6a5c337922a5221d1f6d025d84e18b526df9944c

pretty: colorize pattern matches in commit messages The "git log" command limits its output to the commits that contain strings matched by a pattern when the "--grep=<pattern>" option is used, but unlike output from "git grep -e <pattern>", the matches are not highlighted, making them harder to spot. Teach the pretty-printer code to highlight matches from the "--grep=<pattern>", "--author=<pattern>" and "--committer=<pattern>" options (to view the last one, you may have to ask for --pretty=fuller). Also, it must be noted that we are effectively greping the content twice (because it would be a hassle to rework the existing matching code to do a /g match and then pass it all down to the coloring code), however it only slows down "git log --author=^H" on this repository by around 1-2% (compared to v2.33.0), so it should be a small enough slow down to justify the addition of the feature. Signed-off-by: Hamza Mahfooz <someguy@effective-light.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Junio C Hamano

commit sha 03883527c5608f81590f04bf5b9399f1e842a763

Merge branch 'ns/tmp-objdir' into ns/batched-fsync * ns/tmp-objdir: tmp-objdir: disable ref updates when replacing the primary odb tmp-objdir: new API for creating temporary writable databases

view details

Neeraj Singh

commit sha 4780496f20e2cc09554a84473bd63250391d662a

bulk-checkin: rename 'state' variable and separate 'plugged' boolean Preparation for adding bulk-fsync to the bulk-checkin.c infrastructure. * Rename 'state' variable to 'bulk_checkin_state', since we will later be adding 'bulk_fsync_state'. This also makes the variable easier to find in the debugger, since the name is more unique. * Move the 'plugged' data member of 'bulk_checkin_state' into a separate static variable. Doing this avoids resetting the variable in finish_bulk_checkin when zeroing the 'bulk_checkin_state'. As-is, we seem to unintentionally disable the plugging functionality the first time a new packfile must be created due to packfile size limits. While disabling the plugging state only results in suboptimal behavior for the current code, it would be fatal for the bulk-fsync functionality later in this patch series. Signed-off-by: Neeraj Singh <neerajsi@microsoft.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Neeraj Singh

commit sha ec983eb5d21a7c3f46de1fb9c35f3f8c15642396

core.fsyncobjectfiles: batched disk flushes When adding many objects to a repo with core.fsyncObjectFiles set to true, the cost of fsync'ing each object file can become prohibitive. One major source of the cost of fsync is the implied flush of the hardware writeback cache within the disk drive. Fortunately, Windows, and macOS offer mechanisms to write data from the filesystem page cache without initiating a hardware flush. Linux has the sync_file_range API, which issues a pagecache writeback request reliably after version 5.2. This patch introduces a new 'core.fsyncObjectFiles = batch' option that batches up hardware flushes. It hooks into the bulk-checkin plugging and unplugging functionality and takes advantage of tmp-objdir. When the new mode is enabled do the following for each new object: 1. Create the object in a tmp-objdir. 2. Issue a pagecache writeback request and wait for it to complete. At the end of the entire transaction when unplugging bulk checkin: 1. Issue an fsync against a dummy file to flush the hardware writeback cache, which should by now have processed the tmp-objdir writes. 2. Rename all of the tmp-objdir files to their final names. 3. When updating the index and/or refs, we assume that Git will issue another fsync internal to that operation. This is not the case today, but may be a good extension to those components. On a filesystem with a singular journal that is updated during name operations (e.g. create, link, rename, etc), such as NTFS, HFS+, or XFS we would expect the fsync to trigger a journal writeout so that this sequence is enough to ensure that the user's data is durable by the time the git command returns. This change also updates the macOS code to trigger a real hardware flush via fnctl(fd, F_FULLFSYNC) when fsync_or_die is called. Previously, on macOS there was no guarantee of durability since a simple fsync(2) call does not flush any hardware caches. _Performance numbers_: Linux - Hyper-V VM running Kernel 5.11 (Ubuntu 20.04) on a fast SSD. Mac - macOS 11.5.1 running on a Mac mini on a 1TB Apple SSD. Windows - Same host as Linux, a preview version of Windows 11. This number is from a patch later in the series. Adding 500 files to the repo with 'git add' Times reported in seconds. core.fsyncObjectFiles | Linux | Mac | Windows ----------------------|-------|-------|-------- false | 0.06 | 0.35 | 0.61 true | 1.88 | 11.18 | 2.47 batch | 0.15 | 0.41 | 1.53 Signed-off-by: Neeraj Singh <neerajsi@microsoft.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Neeraj Singh

commit sha d11da094aa1e0de458ec6f7e9e008cfff7c454db

core.fsyncobjectfiles: add windows support for batch mode This commit adds a win32 implementation for fsync_no_flush that is called git_fsync. The 'NtFlushBuffersFileEx' function being called is available since Windows 8. If the function is not available, we return -1 and Git falls back to doing a full fsync. The operating system is told to flush data only without a hardware flush primitive. A later full fsync will cause the metadata log to be flushed and then the disk cache to be flushed on NTFS and ReFS. Other filesystems will treat this as a full flush operation. I added a new file here for this system call so as not to conflict with downstream changes in the git-for-windows repository related to fscache. Signed-off-by: Neeraj Singh <neerajsi@microsoft.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Neeraj Singh

commit sha 085d91472d33ba5e9849873d07d29ea91c8ff0ee

update-index: use the bulk-checkin infrastructure The update-index functionality is used internally by 'git stash push' to setup the internal stashed commit. This change enables bulk-checkin for update-index infrastructure to speed up adding new objects to the object database by leveraging the pack functionality and the new bulk-fsync functionality. There is some risk with this change, since under batch fsync, the object files will not be available until the update-index is entirely complete. This usage is unlikely, since any tool invoking update-index and expecting to see objects would have to synchronize with the update-index process after passing it a file path. Signed-off-by: Neeraj Singh <neerajsi@microsoft.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Neeraj Singh

commit sha 2881e3edb7a2546d227ff8f353e0608a72d90a32

unpack-objects: use the bulk-checkin infrastructure The unpack-objects functionality is used by fetch, push, and fast-import to turn the transfered data into object database entries when there are fewer objects than the 'unpacklimit' setting. By enabling bulk-checkin when unpacking objects, we can take advantage of batched fsyncs. Signed-off-by: Neeraj Singh <neerajsi@microsoft.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Neeraj Singh

commit sha e058d35e94646d41172df92cf0b300287314accd

core.fsyncobjectfiles: tests for batch mode Add test cases to exercise batch mode for: * 'git add' * 'git stash' * 'git update-index' * 'git unpack-objects' These tests ensure that the added data winds up in the object database. In this change we introduce a new test helper lib-unique-files.sh. The goal of this library is to create a tree of files that have different oids from any other files that may have been created in the current test repo. This helps us avoid missing validation of an object being added due to it already being in the repo. Signed-off-by: Neeraj Singh <neerajsi@microsoft.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Neeraj Singh

commit sha e2d74931156f0b97aa8a6b2084fd176c721f9320

core.fsyncobjectfiles: performance tests for add and stash Add a basic performance test for "git add" and "git stash" of a lot of new objects with various fsync settings. Signed-off-by: Neeraj Singh <neerajsi@microsoft.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Jeff King

commit sha e4c497a1944f035b3e4e947d9518d947d42d40a1

urlmatch: add underscore to URL_HOST_CHARS When parsing a URL to normalize it, we allow hostnames to contain only dot (".") or dash ("-"), plus brackets and colons for IPv6 literals. This matches the old URL standard in RFC 1738, which says: host = hostname | hostnumber hostname = *[ domainlabel "." ] toplabel domainlabel = alphadigit | alphadigit *[ alphadigit | "-" ] alphadigit But this was later updated by RFC 3986, which is more liberal: host = IP-literal / IPv4address / reg-name reg-name = *( unreserved / pct-encoded / sub-delims ) unreserved = ALPHA / DIGIT / "-" / "." / "_" / "~" While names with underscore in them are not common and possibly violate some DNS rules, they do work in practice, and we will happily contact them over http://, git://, or ssh://. It seems odd to ignore them for purposes of URL matching, especially when the URL RFC seems to allow them. There shouldn't be any downside here. It's not a syntactically significant character in a URL, so we won't be confused about parsing; we'd have simply rejected such a URL previously (the test here checks the url code directly, but the obvious user-visible effect would be failing to match credential.http://foo_bar.example.com.helper, or similar config in http.<url>.*). Arguably we'd want to allow tilde ("~") here, too. There's likewise probably no downside, but I didn't add it simply because it seems like an even less likely character to appear in a hostname. Reported-by: Alex Waite <alex@waite.eu> Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Ævar Arnfjörð Bjarmason

commit sha 3247919a758710692e316a13c209e13933936d51

commit-graph tests: fix error-hiding graph_git_two_modes() helper The graph_git_two_modes() helper added in 177722b3442 (commit: integrate commit graph with commit parsing, 2018-04-10) didn't &&-chain its "git commit-graph" invocations, which as can be seen with SANITIZE=leak will happily mark tests as passing if both of these commands die, since test_cmp() will be comparing two empty files. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Ævar Arnfjörð Bjarmason

commit sha a046aa38ca9e0b62dc847a00a1bd8efaa682ef31

commit-graph tests: fix another graph_git_two_modes() helper In 135a7123755 (commit-graph: add --split option to builtin, 2019-06-18) this function was copy/pasted to the split commit-graph tests, as in the preceding commit we need to fix this to use &&-chaining, so it won't be hiding errors. Unlike its sister function in "t5318-commit-graph.sh", which we got lucky with, this one was hiding a real test failure. A tests added in c523035cbd8 (commit-graph: allow cross-alternate chains, 2019-06-18) has never worked as intended. Unlike most other graph_git_behavior uses in this file it clones the repository into a sub-directory, so we'll need to refer to "commits/6" as "origin/commits/6". It's not easy to simply move the "graph_git_behavior" to the test above it, since it itself spawns a "test_expect_success". Let's instead add support to "graph_git_behavior()" and "graph_git_two_modes()" to pass a "-C" argument to git. We also need to add a "test -d fork" here, because otherwise we'll fail on e.g.: GIT_SKIP_TESTS=t5324.13 ./t5324-split-commit-graph.sh Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Ævar Arnfjörð Bjarmason

commit sha 095d112f8cce6610bb4ed112a5318d4379322b55

commit-graph: don't consider "replace" objects with "verify" Extend the code added in d6538246d3d (commit-graph: not compatible with replace objects, 2018-08-20) which ignored replace objects in the "write" command to ignore it in the "verify" command too. We can just move this assignment to the cmd_commit_graph(), it dispatches to "write" and "verify", and we're unlikely to ever get a sub-command that would like to consider replace refs. This will make tests added in eddc1f556cd (mktag tests: test update-ref and reachable fsck, 2021-06-17) pass in combination with the "GIT_TEST_COMMIT_GRAPH" mode added in 859fdc0c3cf (commit-graph: define GIT_TEST_COMMIT_GRAPH, 2018-08-29), except that mode is currently broken (but is being fixed concurrently). See the discussion starting at [1]. 1. https://lore.kernel.org/git/87wnmihswp.fsf@evledraar.gmail.com/ Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Hamza Mahfooz

commit sha ae39ba431ab861548eb60b4bd2e1d8b8813db76f

grep/pcre2: fix an edge case concerning ascii patterns and UTF-8 data If we attempt to grep non-ascii log message text with an ascii pattern, we run into the following issue: $ git log --color --author='.var.*Bjar' -1 origin/master | grep ^Author grep: (standard input): binary file matches So, to fix this teach the grep code to use PCRE2_UTF, as long as the log output is encoded in UTF-8. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Hamza Mahfooz <someguy@effective-light.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Junio C Hamano

commit sha ed41385ad65ebf5d6341db96728be357dde3194d

Merge branch 'ab/ignore-replace-while-working-on-commit-graph' into gc/use-repo-settings * ab/ignore-replace-while-working-on-commit-graph: commit-graph: don't consider "replace" objects with "verify" commit-graph tests: fix another graph_git_two_modes() helper commit-graph tests: fix error-hiding graph_git_two_modes() helper

view details

Glen Choo

commit sha f30e4d854bb8462d1a4da697ad95501d33fe4425

fsck: verify commit graph when implicitly enabled Change fsck to check the "core_commit_graph" variable set in "repo-settings.c" instead of reading the "core.commitGraph" variable. This fixes a bug where we wouldn't verify the commit-graph if the config key was missing. This bug was introduced in 31b1de6a09 (commit-graph: turn on commit-graph by default, 2019-08-13), where core.commitGraph was turned on by default. Add tests to "t5318-commit-graph.sh" to verify that fsck checks the commit-graph as expected for the 3 values of core.commitGraph. Also, disable GIT_TEST_COMMIT_GRAPH in t/t0410-partial-clone.sh because some test cases use fsck in ways that assume that commit-graph checking is disabled. Helped-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Glen Choo <chooglen@google.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Glen Choo

commit sha dc5570872f684f7c838fe7571225d279243b8700

fsck: verify multi-pack-index when implictly enabled Like the previous commit, change fsck to check the "core_multi_pack_index" variable set in "repo-settings.c" instead of reading the "core.multiPackIndex" config variable. This fixes a bug where we wouldn't verify midx if the config key was missing. This bug was introduced in 18e449f86b (midx: enable core.multiPackIndex by default, 2020-09-25) where core.multiPackIndex was turned on by default. Helped-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Glen Choo <chooglen@google.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Glen Choo

commit sha a897ab7ed143b2790f05785a3b1916f8a71c7a8c

gc: perform incremental repack when implictly enabled builtin/gc.c has two ways of checking if multi-pack-index is enabled: - git_config_get_bool() in incremental_repack_auto_condition() - the_repository->settings.core_multi_pack_index in maintenance_task_incremental_repack() The two implementations have existed since the incremental-repack task was introduced in e841a79a13 (maintenance: add incremental-repack auto condition, 2020-09-25). These two values can diverge because prepare_repo_settings() enables the feature in the_repository->settings by default. In the case where core.multiPackIndex is not set in the config, the auto condition would fail, causing the incremental-repack task to not be run. Because we always want to consider the default values, we should always use the_repository->settings. Standardize on using the_repository->settings.core_multi_pack_index to check if multi-pack-index is enabled. Signed-off-by: Glen Choo <chooglen@google.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

push time in 8 hours

push eventgitgitgadget/git

Fabian Stelzer

commit sha b5726a5d9cabba0bd8fb6c1b25a887bc7ea4650d

ssh signing: preliminary refactoring and clean-up Openssh v8.2p1 added some new options to ssh-keygen for signature creation and verification. These allow us to use ssh keys for git signatures easily. In our corporate environment we use PIV x509 Certs on Yubikeys for email signing/encryption and ssh keys which I think is quite common (at least for the email part). This way we can establish the correct trust for the SSH Keys without setting up a separate GPG Infrastructure (which is still quite painful for users) or implementing x509 signing support for git (which lacks good forwarding mechanisms). Using ssh agent forwarding makes this feature easily usable in todays development environments where code is often checked out in remote VMs / containers. In such a setup the keyring & revocationKeyring can be centrally generated from the x509 CA information and distributed to the users. To be able to implement new signing formats this commit: - makes the sigc structure more generic by renaming "gpg_output" to "output" - introduces function pointers in the gpg_format structure to call format specific signing and verification functions - moves format detection from verify_signed_buffer into the check_signature api function and calls the format specific verify - renames and wraps sign_buffer to handle format specific signing logic as well Signed-off-by: Fabian Stelzer <fs@gigacodes.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Fabian Stelzer

commit sha 64625c728fc281181e6dc6c0b8b538f0fbe47a30

ssh signing: add test prereqs Generate some ssh keys and a allowedSignersFile for testing Signed-off-by: Fabian Stelzer <fs@gigacodes.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Fabian Stelzer

commit sha 29b315778e958417a411f02b6d4b5a0fc9d731e2

ssh signing: add ssh key format and signing code Implements the actual sign_buffer_ssh operation and move some shared cleanup code into a strbuf function Set gpg.format = ssh and user.signingkey to either a ssh public key string (like from an authorized_keys file), or a ssh key file. If the key file or the config value itself contains only a public key then the private key needs to be available via ssh-agent. gpg.ssh.program can be set to an alternative location of ssh-keygen. A somewhat recent openssh version (8.2p1+) of ssh-keygen is needed for this feature. Since only ssh-keygen is needed it can this way be installed seperately without upgrading your system openssh packages. Signed-off-by: Fabian Stelzer <fs@gigacodes.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Fabian Stelzer

commit sha fd9e226776d1874af36b6b02fb2002b917af42fa

ssh signing: retrieve a default key from ssh-agent If user.signingkey is not set and a ssh signature is requested we call gpg.ssh.defaultKeyCommand (typically "ssh-add -L") and use the first key we get Signed-off-by: Fabian Stelzer <fs@gigacodes.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Fabian Stelzer

commit sha 4838f62c8caffbfe5d7d39cad4e8aeb2a2d57da8

ssh signing: provide a textual signing_key_id For ssh the user.signingkey can be a filename/path or even a literal ssh pubkey. In push certs and textual output we prefer the ssh fingerprint instead. Signed-off-by: Fabian Stelzer <fs@gigacodes.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Fabian Stelzer

commit sha facca53ac3c2e8a5e2a4fe54c9c15de656c72de1

ssh signing: verify signatures using ssh-keygen To verify a ssh signature we first call ssh-keygen -Y find-principal to look up the signing principal by their public key from the allowedSignersFile. If the key is found then we do a verify. Otherwise we only validate the signature but can not verify the signers identity. Verification uses the gpg.ssh.allowedSignersFile (see ssh-keygen(1) "ALLOWED SIGNERS") which contains valid public keys and a principal (usually user@domain). Depending on the environment this file can be managed by the individual developer or for example generated by the central repository server from known ssh keys with push access. This file is usually stored outside the repository, but if the repository only allows signed commits/pushes, the user might choose to store it in the repository. To revoke a key put the public key without the principal prefix into gpg.ssh.revocationKeyring or generate a KRL (see ssh-keygen(1) "KEY REVOCATION LISTS"). The same considerations about who to trust for verification as with the allowedSignersFile apply. Using SSH CA Keys with these files is also possible. Add "cert-authority" as key option between the principal and the key to mark it as a CA and all keys signed by it as valid for this CA. See "CERTIFICATES" in ssh-keygen(1). Signed-off-by: Fabian Stelzer <fs@gigacodes.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Fabian Stelzer

commit sha 3326a783f1cb309d438adea3d94a0448c4a21304

ssh signing: duplicate t7510 tests for commits Signed-off-by: Fabian Stelzer <fs@gigacodes.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Fabian Stelzer

commit sha f265f2d630c498fd256d5da9d8b742efaf0cba8c

ssh signing: tests for logs, tags & push certs Signed-off-by: Fabian Stelzer <fs@gigacodes.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Fabian Stelzer

commit sha 1bfb57f642d34dc4b65be3602bb429abd9f32b58

ssh signing: test that gpg fails for unknown keys Test that verify-commit/tag will fail when a gpg key is completely unknown. To do this we have to generate a key, use it for a signature and delete it from our keyring aferwards completely. Signed-off-by: Fabian Stelzer <fs@gigacodes.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Junio C Hamano

commit sha 6295f87b5f46fcb1037eb12e81afaf0490a00922

Merge branch 'jt/add-submodule-odb-clean-up' into jt/no-abuse-alternate-odb-for-submodules * jt/add-submodule-odb-clean-up: revision: remove "submodule" from opt struct repository: support unabsorbed in repo_submodule_init submodule: remove unnecessary unabsorbed fallback

view details

Junio C Hamano

commit sha b6b210c5e1705c28274ac2e83a500644c126dd9a

Merge branch 'jk/ref-paranoia' into jt/no-abuse-alternate-odb-for-submodules * jk/ref-paranoia: (71 commits) refs: drop "broken" flag from for_each_fullref_in() ref-filter: drop broken-ref code entirely ref-filter: stop setting FILTER_REFS_INCLUDE_BROKEN repack, prune: drop GIT_REF_PARANOIA settings refs: turn on GIT_REF_PARANOIA by default refs: omit dangling symrefs when using GIT_REF_PARANOIA refs: add DO_FOR_EACH_OMIT_DANGLING_SYMREFS flag refs-internal.h: reorganize DO_FOR_EACH_* flag documentation refs-internal.h: move DO_FOR_EACH_* flags next to each other t5312: be more assertive about command failure t5312: test non-destructive repack t5312: create bogus ref as necessary t5312: drop "verbose" helper t5600: provide detached HEAD for corruption failures t5516: don't use HEAD ref for invalid ref-deletion tests t7900: clean up some more broken refs The eighth batch t0000: avoid masking git exit value through pipes tree-diff: fix leak when not HAVE_ALLOCA_H pack-revindex.h: correct the time complexity descriptions ...

view details

Ævar Arnfjörð Bjarmason

commit sha 3b723f722df6578926705c754a170c11acdbff63

parse-options.h: move PARSE_OPT_SHELL_EVAL between enums Fix a bad landmine of a bug which has been with us ever since PARSE_OPT_SHELL_EVAL was added in 47e9cd28f8a (parseopt: wrap rev-parse --parseopt usage for eval consumption, 2010-06-12). It's an argument to parse_options() and should therefore be in "enum parse_opt_flags", but it was added to the per-option "enum parse_opt_option_flags" by mistake. Therefore as soon as we'd have an enum member in the former that reached its value of "1 << 8" we'd run into a seemingly bizarre bug where that new option would turn on the unrelated PARSE_OPT_SHELL_EVAL in "git rev-parse --parseopt" by proxy. I manually checked that no other enum members suffered from such overlap, by setting the values to non-overlapping values, and making the relevant codepaths BUG() out if the given value was above/below the expected (excluding flags=0 in the case of "enum parse_opt_flags"). Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Ævar Arnfjörð Bjarmason

commit sha 093fffdfbec4ce3fee9a5cebde0aae87bcebb0cc

fsck tests: add test for fsck-ing an unknown type Fix a blindspot in the fsck tests by checking what we do when we encounter an unknown "garbage" type produced with hash-object's --literally option. This behavior needs to be improved, which'll be done in subsequent patches, but for now let's test for the current behavior. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Ævar Arnfjörð Bjarmason

commit sha f7a0dba7a25ec600e2c9e8d98ecabf8d3d97f6ed

fsck tests: refactor one test to use a sub-repo Refactor one of the fsck tests to use a throwaway repository. It's a pervasive pattern in t1450-fsck.sh to spend a lot of effort on the teardown of a tests so we're not leaving corrupt content for the next test. We can instead use the pattern of creating a named sub-repository, then we don't have to worry about cleaning up after ourselves, nobody will care what state the broken "hash-mismatch" repository is after this test runs. See [1] for related discussion on various "modern" test patterns that can be used to avoid verbosity and increase reliability. 1. https://lore.kernel.org/git/87y27veeyj.fsf@evledraar.gmail.com/ Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Ævar Arnfjörð Bjarmason

commit sha 42cd635b21f3a440c775022003b168feef946fa6

fsck tests: test current hash/type mismatch behavior If fsck we move an object around between .git/objects/?? directories to simulate a hash mismatch "git fsck" will currently hard die() in object-file.c. This behavior will be fixed in subsequent commits, but let's test for it as-is for now. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Ævar Arnfjörð Bjarmason

commit sha a5ed333121bde3e170e5497d30391671a9910fb0

fsck tests: test for garbage appended to a loose object There wasn't any output tests for this scenario, let's ensure that we don't regress on it in the changes that come after this. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Ævar Arnfjörð Bjarmason

commit sha 70e4a57762e7a23af8772483026b1e00f9de296b

cat-file tests: move bogus_* variable declarations earlier Change the short/long bogus bogus object type variables into a form where the two sets can be used concurrently. This'll be used by subsequently added tests. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Ævar Arnfjörð Bjarmason

commit sha 59b8283d557a00d0c09684e621f5e000e6996b5f

cat-file tests: test for missing/bogus object with -t, -s and -p When we look up a missing object with cat_one_file() what error we print out currently depends on whether we'll error out early in get_oid_with_context(), or if we'll get an error later from oid_object_info_extended(). The --allow-unknown-type flag then changes whether we pass the "OBJECT_INFO_ALLOW_UNKNOWN_TYPE" flag to get_oid_with_context() or not. The "-p" flag is yet another special-case in printing the same output on the deadbeef OID as we'd emit on the deadbeef_short OID for the "-s" and "-t" options, it also doesn't support the "--allow-unknown-type" flag at all. Let's test the combination of the two sets of [-t, -s, -p] and [--{no-}allow-unknown-type] (the --no-allow-unknown-type is implicit in not supplying it), as well as a [missing,bogus] object pair. This extends tests added in 3e370f9faf0 (t1006: add tests for git cat-file --allow-unknown-type, 2015-05-03). Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Ævar Arnfjörð Bjarmason

commit sha 7e7d220d9d0f357388923d0fe4a7e3f898858adb

cat-file tests: add corrupt loose object test Fix a blindspot in the tests for "cat-file" (and by proxy, the guts of object-file.c) by testing that when we can't decode a loose object with zlib we'll emit an error from zlib.c. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Ævar Arnfjörð Bjarmason

commit sha dd45a5624608d353b706cb54ebdf60ef154dbbe5

cat-file tests: test for current --allow-unknown-type behavior Add more tests for the current --allow-unknown-type behavior. As noted in [1] I don't think much of this makes sense, but let's test for it as-is so we can see if the behavior changes in the future. 1. https://lore.kernel.org/git/87r1i4qf4h.fsf@evledraar.gmail.com/ Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

push time in 8 hours

push eventgit-for-windows/get-azure-pipelines-artifact

dependabot[bot]

commit sha a47ede648cf510b035b34f5cb4459128f8fb69ad

build(deps-dev): bump @types/node from 12.20.34 to 12.20.35 Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 12.20.34 to 12.20.35. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

view details

Johannes Schindelin

commit sha 73c955550586274dca1a82b3ec7ea684ddd65da0

Merge pull request #199 from git-for-windows/dependabot/npm_and_yarn/types/node-12.20.35 build(deps-dev): bump @types/node from 12.20.34 to 12.20.35

view details

push time in 10 hours

PR merged git-for-windows/get-azure-pipelines-artifact

Reviewers
build(deps-dev): bump @types/node from 12.20.34 to 12.20.35 dependencies

Bumps @types/node from 12.20.34 to 12.20.35. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

+3 -3

0 comment

1 changed file

dependabot[bot]

pr closed time in 10 hours

create barnchgitgitgadget/git

branch : sg/sparse-index-not-that-common-a-command

created branch time in 11 hours

push eventgitgitgadget/git

Martin Ågren

commit sha 480f0541b8b22a4528425d348d2db3f572c39350

config.txt: fix typo Fix the spelling of "substituted". Signed-off-by: Martin Ågren <martin.agren@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

push time in 11 hours

push eventgitgitgadget/git

Johannes Sixt

commit sha 386076ec92c702104cb15bc23e4521dac10c7c2d

userdiff-cpp: back out the digit-separators in numbers The implementation of digit-separating single-quotes introduced a note-worthy regression: the change of a character literal with a digit would splice the digit and the closing single-quote. For example, the change from 'a' to '2' is now tokenized as '[-a'-]{+2'+} instead of '[-a-]{+2+}'. The options to fix the regression are: - Tighten the regular expression such that the single-quote can only occur between digits (that would match the official syntax). - Remove support for digit separators. I chose to remove support, because - I have not seen a lot of code make use of digit separators. - If code does use digit separators, then the numbers are typically long. If a change in one of the segments occurs, it is actually better visible if only that segment is highlighted as the word that changed instead of the whole long number. This choice does introduce another minor regression, though, which is highlighted in the test case: when a change occurs in the second or later segment of a hexadecimal number where the segment begins with a digit, but also has letters, the segment is mistaken as consisting of a number and an identifier. I can live with that. Signed-off-by: Johannes Sixt <j6t@kdbg.org> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Robin Dupret

commit sha 12144e8f02094eaca371b5363db438b3c4691e18

http-backend: remove a duplicated code branch Try to make reading the computation of the gzipped flag a bit more natural. Signed-off-by: Robin Dupret <robin.dupret@hey.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

SZEDER Gábor

commit sha 6a9a50a8afd7f7dead7495fdc2c9b4053acfefc6

command-list.txt: remove 'sparse-index' from main help Ever since 'git sparse-checkout' was introduced [1] it is included in 'git --help' in the section "work on the current change" along with the commands 'add', 'mv', 'restore', and 'rm'. It clearly doesn't belong to that group, moreover it can't be considered such a common command to belong to 'git --help' in the first place, so remove it from there. [1] 94c0956b60 (sparse-checkout: create builtin with 'list' subcommand, 2019-11-21) Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Martin Ågren

commit sha 480f0541b8b22a4528425d348d2db3f572c39350

config.txt: fix typo Fix the spelling of "substituted". Signed-off-by: Martin Ågren <martin.agren@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Junio C Hamano

commit sha 9707f2953972968a45eff893172f938cc0667c01

SubmittingPatchs: clarify choice of base and testing We encourage identifying what, among many topics on `next`, exact topics a new work depends on, instead of building directly on `next`. Let's clarify this in the documentation. Developers should know what they are building on top of, and be aware of which part of the system is currently being worked on. Encouraging them to make trial merges to `next` and `seen` themselves will incentivize them to read others' changes and understand them, eventually helping the developers to coordinate among themselves and reviewing each others' changes. Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Junio C Hamano

commit sha fab7899f18c17785c9b9dc6d39911ad30ee21318

(wip) reword the final review part

view details

Bagas Sanjaya

commit sha c4b208c30919c42c29b18388975857330160b972

archive: describe compression level option Describe the only <extra> option in `git archive`, that is the compression level option. Previously this option is only described for zip backend; add description also for tar backend. Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com> Helped-by: Eric Sunshine <sunshine@sunshineco.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Martin Ågren

commit sha 82a57cd13fa12b30607ebe5fabf51a2ade638f2c

git.txt: fix typo Fix the spelling of "internally". Signed-off-by: Martin Ågren <martin.agren@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Martin Ågren

commit sha 85bc0065612d83f6297d24f0cf62b2e2a0f33d25

git-multi-pack-index.txt: change "folder" to "directory" We prefer "directory" over "folder" when discussing the file system concept. In all of our documentation, these are the only spots where we refer to the `.git` directory as a folder. Switch to "directory", and while doing so, add backticks to the ".git" filename to set it in monospace. Signed-off-by: Martin Ågren <martin.agren@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Martin Ågren

commit sha c314b62553e2abf9055aa58d5e4ed2e5bb8c9f64

gitignore.txt: change "folder" to "directory" We prefer "directory" over "folder" when discussing the file system concept. Change this instance for consistency -- indeed, even within this paragraph, we already use "directory". Signed-off-by: Martin Ågren <martin.agren@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Martin Ågren

commit sha 236bae14da6240b68bfab783623b602af2ffc003

gitweb.txt: change "folder" to "directory" We prefer "directory" over "folder" when discussing the file system concept. Change this instance for consistency. After this, the only hits for '\<folder\>' in Documentation/ relate to IMAP folders. Signed-off-by: Martin Ågren <martin.agren@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Junio C Hamano

commit sha 65989d42a0ebcbe9510134b20abad52d577c94cd

Merge branch 'js/userdiff-cpp' into jch Userdiff patterns for the C++ language has been updated. * js/userdiff-cpp: userdiff-cpp: back out the digit-separators in numbers userdiff-cpp: learn the C++ spaceship operator userdiff-cpp: permit the digit-separating single-quote in numbers userdiff-cpp: prepare test cases with yet unsupported features userdiff-cpp: tighten word regex t4034: add tests showing problematic cpp tokenizations t4034/cpp: actually test that operator tokens are not split

view details

Junio C Hamano

commit sha 2dec4fe5e439e8bc65b897038ed0d7d7555797ab

Merge branch 'ab/parse-options-cleanup' into jch Random changes to parse-options implementation. * ab/parse-options-cleanup: parse-options: change OPT_{SHORT,UNSET} to an enum parse-options tests: test optname() output parse-options.[ch]: make opt{bug,name}() "static" commit-graph: stop using optname() parse-options.c: move optname() earlier in the file parse-options.h: make the "flags" in "struct option" an enum parse-options.c: use exhaustive "case" arms for "enum parse_opt_result" parse-options.[ch]: consistently use "enum parse_opt_result" parse-options.[ch]: consistently use "enum parse_opt_flags" parse-options.h: move PARSE_OPT_SHELL_EVAL between enums

view details

Junio C Hamano

commit sha ac6b79200942e331abf22c78365cfcf733c2d6fc

Merge branch 'ab/mark-leak-free-tests' into jch Bunch of tests are marked as "passing leak check". * ab/mark-leak-free-tests: leak tests: mark some misc tests as passing with SANITIZE=leak leak tests: mark various "generic" tests as passing with SANITIZE=leak leak tests: mark some read-tree tests as passing with SANITIZE=leak leak tests: mark some ls-files tests as passing with SANITIZE=leak leak tests: mark all checkout-index tests as passing with SANITIZE=leak leak tests: mark all trace2 tests as passing with SANITIZE=leak leak tests: mark all ls-tree tests as passing with SANITIZE=leak leak tests: run various "test-tool" tests in t00*.sh SANITIZE=leak leak tests: run various built-in tests in t00*.sh SANITIZE=leak

view details

Junio C Hamano

commit sha 64da5a2ae51bc4f17a63ac3bc9551be5c952f19e

Merge branch 'ab/mark-leak-free-tests-more' into jch Bunch of tests are marked as "passing leak check". * ab/mark-leak-free-tests-more: merge: add missing strbuf_release() ls-files: add missing string_list_clear() ls-files: fix a trivial dir_clear() leak tests: fix test-oid-array leak, test in SANITIZE=leak tests: fix a memory leak in test-oidtree.c tests: fix a memory leak in test-parse-options.c tests: fix a memory leak in test-prio-queue.c

view details

Junio C Hamano

commit sha 11cfd531af77106fdbfce6ae2a7045128e742e58

Merge branch 'jc/doc-commit-header-continuation-line' into jch Doc update. * jc/doc-commit-header-continuation-line: signature-format.txt: explain and illustrate multi-line headers

view details

Junio C Hamano

commit sha c81c016aa2d4a64cd307638cab49755faff642e1

Merge branch 'ab/test-cleanly-recreate-trash-directory' into jch Improve test framework around unwritable directories. * ab/test-cleanly-recreate-trash-directory: test-lib.sh: try to re-chmod & retry on failed trash removal

view details

Junio C Hamano

commit sha 56e66450b7a8e0347c9b989f084c666064853edd

Merge branch 'tb/fix-midx-rename-while-mapped' into jch The codepath to write a new version of .midx multi-pack index files has learned to release the mmaped memory holding the current version of .midx before removing them from the disk, as some platforms do not allow removal of a file that still has mapping. * tb/fix-midx-rename-while-mapped: midx.c: guard against commit_lock_file() failures midx.c: lookup MIDX by object directory during repack midx.c: lookup MIDX by object directory during expire midx.c: extract MIDX lookup by object_dir

view details

Junio C Hamano

commit sha 8b1a43b1afddb4d608756f179d53476796366552

Merge branch 'ab/pkt-line-cleanup' into jch Code clean-up. * ab/pkt-line-cleanup: pkt-line.[ch]: remove unused packet_read_line_buf() pkt-line.[ch]: remove unused packet_buf_write_len()

view details

Junio C Hamano

commit sha b2c9ed1f0e9a2dfea0e17ebbdf162a19143281f3

Merge branch 'ab/fix-make-lint-docs' into jch Build fix. * ab/fix-make-lint-docs: doc lint: make "lint-docs" non-.PHONY doc build: speed up "make lint-docs" doc lint: emit errors on STDERR doc lint: fix error-hiding regression

view details

push time in 11 hours

push eventgitgitgadget/git

Martin Ågren

commit sha 82a57cd13fa12b30607ebe5fabf51a2ade638f2c

git.txt: fix typo Fix the spelling of "internally". Signed-off-by: Martin Ågren <martin.agren@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

push time in 11 hours

create barnchgitgitgadget/git

branch : ma/doc-folder-to-directory

created branch time in 11 hours

create barnchgitgitgadget/git

branch : rd/http-backend-code-simplification

created branch time in 11 hours

push eventgitgitgadget/git

Johannes Sixt

commit sha 386076ec92c702104cb15bc23e4521dac10c7c2d

userdiff-cpp: back out the digit-separators in numbers The implementation of digit-separating single-quotes introduced a note-worthy regression: the change of a character literal with a digit would splice the digit and the closing single-quote. For example, the change from 'a' to '2' is now tokenized as '[-a'-]{+2'+} instead of '[-a-]{+2+}'. The options to fix the regression are: - Tighten the regular expression such that the single-quote can only occur between digits (that would match the official syntax). - Remove support for digit separators. I chose to remove support, because - I have not seen a lot of code make use of digit separators. - If code does use digit separators, then the numbers are typically long. If a change in one of the segments occurs, it is actually better visible if only that segment is highlighted as the word that changed instead of the whole long number. This choice does introduce another minor regression, though, which is highlighted in the test case: when a change occurs in the second or later segment of a hexadecimal number where the segment begins with a digit, but also has letters, the segment is mistaken as consisting of a number and an identifier. I can live with that. Signed-off-by: Johannes Sixt <j6t@kdbg.org> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

push time in 11 hours

push eventgitgitgadget/git

Bagas Sanjaya

commit sha c4b208c30919c42c29b18388975857330160b972

archive: describe compression level option Describe the only <extra> option in `git archive`, that is the compression level option. Previously this option is only described for zip backend; add description also for tar backend. Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com> Helped-by: Eric Sunshine <sunshine@sunshineco.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

push time in 11 hours

create barnchgitgitgadget/git

branch : jc/doc-submitting-patches-choice-of-base

created branch time in 11 hours

push eventgitgitgadget/git

Johannes Sixt

commit sha 386076ec92c702104cb15bc23e4521dac10c7c2d

userdiff-cpp: back out the digit-separators in numbers The implementation of digit-separating single-quotes introduced a note-worthy regression: the change of a character literal with a digit would splice the digit and the closing single-quote. For example, the change from 'a' to '2' is now tokenized as '[-a'-]{+2'+} instead of '[-a-]{+2+}'. The options to fix the regression are: - Tighten the regular expression such that the single-quote can only occur between digits (that would match the official syntax). - Remove support for digit separators. I chose to remove support, because - I have not seen a lot of code make use of digit separators. - If code does use digit separators, then the numbers are typically long. If a change in one of the segments occurs, it is actually better visible if only that segment is highlighted as the word that changed instead of the whole long number. This choice does introduce another minor regression, though, which is highlighted in the test case: when a change occurs in the second or later segment of a hexadecimal number where the segment begins with a digit, but also has letters, the segment is mistaken as consisting of a number and an identifier. I can live with that. Signed-off-by: Johannes Sixt <j6t@kdbg.org> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Robin Dupret

commit sha 12144e8f02094eaca371b5363db438b3c4691e18

http-backend: remove a duplicated code branch Try to make reading the computation of the gzipped flag a bit more natural. Signed-off-by: Robin Dupret <robin.dupret@hey.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

SZEDER Gábor

commit sha 6a9a50a8afd7f7dead7495fdc2c9b4053acfefc6

command-list.txt: remove 'sparse-index' from main help Ever since 'git sparse-checkout' was introduced [1] it is included in 'git --help' in the section "work on the current change" along with the commands 'add', 'mv', 'restore', and 'rm'. It clearly doesn't belong to that group, moreover it can't be considered such a common command to belong to 'git --help' in the first place, so remove it from there. [1] 94c0956b60 (sparse-checkout: create builtin with 'list' subcommand, 2019-11-21) Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Martin Ågren

commit sha 480f0541b8b22a4528425d348d2db3f572c39350

config.txt: fix typo Fix the spelling of "substituted". Signed-off-by: Martin Ågren <martin.agren@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Junio C Hamano

commit sha 9707f2953972968a45eff893172f938cc0667c01

SubmittingPatchs: clarify choice of base and testing We encourage identifying what, among many topics on `next`, exact topics a new work depends on, instead of building directly on `next`. Let's clarify this in the documentation. Developers should know what they are building on top of, and be aware of which part of the system is currently being worked on. Encouraging them to make trial merges to `next` and `seen` themselves will incentivize them to read others' changes and understand them, eventually helping the developers to coordinate among themselves and reviewing each others' changes. Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Junio C Hamano

commit sha fab7899f18c17785c9b9dc6d39911ad30ee21318

(wip) reword the final review part

view details

Bagas Sanjaya

commit sha c4b208c30919c42c29b18388975857330160b972

archive: describe compression level option Describe the only <extra> option in `git archive`, that is the compression level option. Previously this option is only described for zip backend; add description also for tar backend. Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com> Helped-by: Eric Sunshine <sunshine@sunshineco.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Martin Ågren

commit sha 82a57cd13fa12b30607ebe5fabf51a2ade638f2c

git.txt: fix typo Fix the spelling of "internally". Signed-off-by: Martin Ågren <martin.agren@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Martin Ågren

commit sha 85bc0065612d83f6297d24f0cf62b2e2a0f33d25

git-multi-pack-index.txt: change "folder" to "directory" We prefer "directory" over "folder" when discussing the file system concept. In all of our documentation, these are the only spots where we refer to the `.git` directory as a folder. Switch to "directory", and while doing so, add backticks to the ".git" filename to set it in monospace. Signed-off-by: Martin Ågren <martin.agren@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Martin Ågren

commit sha c314b62553e2abf9055aa58d5e4ed2e5bb8c9f64

gitignore.txt: change "folder" to "directory" We prefer "directory" over "folder" when discussing the file system concept. Change this instance for consistency -- indeed, even within this paragraph, we already use "directory". Signed-off-by: Martin Ågren <martin.agren@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Martin Ågren

commit sha 236bae14da6240b68bfab783623b602af2ffc003

gitweb.txt: change "folder" to "directory" We prefer "directory" over "folder" when discussing the file system concept. Change this instance for consistency. After this, the only hits for '\<folder\>' in Documentation/ relate to IMAP folders. Signed-off-by: Martin Ågren <martin.agren@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Junio C Hamano

commit sha 65989d42a0ebcbe9510134b20abad52d577c94cd

Merge branch 'js/userdiff-cpp' into jch Userdiff patterns for the C++ language has been updated. * js/userdiff-cpp: userdiff-cpp: back out the digit-separators in numbers userdiff-cpp: learn the C++ spaceship operator userdiff-cpp: permit the digit-separating single-quote in numbers userdiff-cpp: prepare test cases with yet unsupported features userdiff-cpp: tighten word regex t4034: add tests showing problematic cpp tokenizations t4034/cpp: actually test that operator tokens are not split

view details

Junio C Hamano

commit sha 2dec4fe5e439e8bc65b897038ed0d7d7555797ab

Merge branch 'ab/parse-options-cleanup' into jch Random changes to parse-options implementation. * ab/parse-options-cleanup: parse-options: change OPT_{SHORT,UNSET} to an enum parse-options tests: test optname() output parse-options.[ch]: make opt{bug,name}() "static" commit-graph: stop using optname() parse-options.c: move optname() earlier in the file parse-options.h: make the "flags" in "struct option" an enum parse-options.c: use exhaustive "case" arms for "enum parse_opt_result" parse-options.[ch]: consistently use "enum parse_opt_result" parse-options.[ch]: consistently use "enum parse_opt_flags" parse-options.h: move PARSE_OPT_SHELL_EVAL between enums

view details

Junio C Hamano

commit sha ac6b79200942e331abf22c78365cfcf733c2d6fc

Merge branch 'ab/mark-leak-free-tests' into jch Bunch of tests are marked as "passing leak check". * ab/mark-leak-free-tests: leak tests: mark some misc tests as passing with SANITIZE=leak leak tests: mark various "generic" tests as passing with SANITIZE=leak leak tests: mark some read-tree tests as passing with SANITIZE=leak leak tests: mark some ls-files tests as passing with SANITIZE=leak leak tests: mark all checkout-index tests as passing with SANITIZE=leak leak tests: mark all trace2 tests as passing with SANITIZE=leak leak tests: mark all ls-tree tests as passing with SANITIZE=leak leak tests: run various "test-tool" tests in t00*.sh SANITIZE=leak leak tests: run various built-in tests in t00*.sh SANITIZE=leak

view details

Junio C Hamano

commit sha 64da5a2ae51bc4f17a63ac3bc9551be5c952f19e

Merge branch 'ab/mark-leak-free-tests-more' into jch Bunch of tests are marked as "passing leak check". * ab/mark-leak-free-tests-more: merge: add missing strbuf_release() ls-files: add missing string_list_clear() ls-files: fix a trivial dir_clear() leak tests: fix test-oid-array leak, test in SANITIZE=leak tests: fix a memory leak in test-oidtree.c tests: fix a memory leak in test-parse-options.c tests: fix a memory leak in test-prio-queue.c

view details

Junio C Hamano

commit sha 11cfd531af77106fdbfce6ae2a7045128e742e58

Merge branch 'jc/doc-commit-header-continuation-line' into jch Doc update. * jc/doc-commit-header-continuation-line: signature-format.txt: explain and illustrate multi-line headers

view details

Junio C Hamano

commit sha c81c016aa2d4a64cd307638cab49755faff642e1

Merge branch 'ab/test-cleanly-recreate-trash-directory' into jch Improve test framework around unwritable directories. * ab/test-cleanly-recreate-trash-directory: test-lib.sh: try to re-chmod & retry on failed trash removal

view details

Junio C Hamano

commit sha 56e66450b7a8e0347c9b989f084c666064853edd

Merge branch 'tb/fix-midx-rename-while-mapped' into jch The codepath to write a new version of .midx multi-pack index files has learned to release the mmaped memory holding the current version of .midx before removing them from the disk, as some platforms do not allow removal of a file that still has mapping. * tb/fix-midx-rename-while-mapped: midx.c: guard against commit_lock_file() failures midx.c: lookup MIDX by object directory during repack midx.c: lookup MIDX by object directory during expire midx.c: extract MIDX lookup by object_dir

view details

Junio C Hamano

commit sha 8b1a43b1afddb4d608756f179d53476796366552

Merge branch 'ab/pkt-line-cleanup' into jch Code clean-up. * ab/pkt-line-cleanup: pkt-line.[ch]: remove unused packet_read_line_buf() pkt-line.[ch]: remove unused packet_buf_write_len()

view details

Junio C Hamano

commit sha b2c9ed1f0e9a2dfea0e17ebbdf162a19143281f3

Merge branch 'ab/fix-make-lint-docs' into jch Build fix. * ab/fix-make-lint-docs: doc lint: make "lint-docs" non-.PHONY doc build: speed up "make lint-docs" doc lint: emit errors on STDERR doc lint: fix error-hiding regression

view details

push time in 11 hours

push eventgitgitgadget/git

Johannes Sixt

commit sha 386076ec92c702104cb15bc23e4521dac10c7c2d

userdiff-cpp: back out the digit-separators in numbers The implementation of digit-separating single-quotes introduced a note-worthy regression: the change of a character literal with a digit would splice the digit and the closing single-quote. For example, the change from 'a' to '2' is now tokenized as '[-a'-]{+2'+} instead of '[-a-]{+2+}'. The options to fix the regression are: - Tighten the regular expression such that the single-quote can only occur between digits (that would match the official syntax). - Remove support for digit separators. I chose to remove support, because - I have not seen a lot of code make use of digit separators. - If code does use digit separators, then the numbers are typically long. If a change in one of the segments occurs, it is actually better visible if only that segment is highlighted as the word that changed instead of the whole long number. This choice does introduce another minor regression, though, which is highlighted in the test case: when a change occurs in the second or later segment of a hexadecimal number where the segment begins with a digit, but also has letters, the segment is mistaken as consisting of a number and an identifier. I can live with that. Signed-off-by: Johannes Sixt <j6t@kdbg.org> Signed-off-by: Junio C Hamano <gitster@pobox.com>

view details

Junio C Hamano

commit sha 2158813163fd49c558a494d4be5db1000158878f

Merge branch 'js/userdiff-cpp' into next Userdiff patterns for the C++ language has been updated. * js/userdiff-cpp: userdiff-cpp: back out the digit-separators in numbers

view details

push time in 11 hours

issue commentgit-for-windows/git

Best way to "run git for windows in wine" or "how to make use of git within pip from python under wine"

And after installing win32 as suggested, I get this, of course:

$ wine /mnt/c/git-sdk-64/cmd/git.exe version
0020:err:module:attach_dlls "libiconv-2.dll" failed to initialize, aborting
0020:err:module:attach_dlls Initializing dlls for L"Z:\\mnt\\c\\git-sdk-64\\mingw64\\bin\\git.exe" failed, status c0000005
mcfreis

comment created time in 18 hours

issue commentgit-for-windows/git

Best way to "run git for windows in wine" or "how to make use of git within pip from python under wine"

Seems that I am currently unable to run Docker in my WSL2 instance. So I gave plain wine a try in my Ubuntu 18.04, and it says this:

$ wine /mnt/c/git-sdk-64/cmd/git.exe version
it looks like wine32 is missing, you should install it.
multiarch needs to be enabled first.  as root, please
execute "dpkg --add-architecture i386 && apt-get update &&
apt-get install wine32"
001e:err:module:attach_dlls "libiconv-2.dll" failed to initialize, aborting
001e:err:module:attach_dlls Initializing dlls for L"Z:\\mnt\\c\\git-sdk-64\\mingw64\\bin\\git.exe" failed, status c00000
05

Not sure whether you can reproduce this in a minimal Docker configuration?

mcfreis

comment created time in 18 hours

pull request commentgit-for-windows/git

Teach Git to handle huge files in smudge/clean

Which makes sense, as we do not know the size of the object before reading it, it is therefore the responsibility of read_object_file() to initialize the value, hence the need to pass a pointer to it.

I can't figure out if I broke this or if it was already broken?

@vtbassmatt no, the intention of the original code is to let read_object_file() initialize the value. Hence passing around the pointer to an as-yet-uninitialized value.

vtbassmatt

comment created time in 19 hours

pull request commentgit-for-windows/git

Teach Git to handle huge files in smudge/clean

Discussion point: can we create a fresh typedef (e.g. memlen, still to ulong, to indicate the places where future changes will be needed (e.g. those function casts). Let's use the name equivalence of typedefs to our benefit.

This would be dramatically out of scope for this PR.

vtbassmatt

comment created time in 19 hours

Pull request review commentgit-for-windows/git

Teach Git to handle huge files in smudge/clean

 static int create_file(const char *path, unsigned int mode) void *read_blob_entry(const struct cache_entry *ce, size_t *size) { 	enum object_type type;+	unsigned long trunc_size = (unsigned long)*size;+	if (trunc_size != *size)

The problem is simple: when size_t is wider than unsigned long, the cast to the latter might cut off bits. The end result is that the cast value is different from the original value. And that is precisely what the code in question tested.

So I don't see any way to improve the clarity of this code.

Casting the value back to size_t explicitly before comparing only would make things confusing again.

vtbassmatt

comment created time in 19 hours

PullRequestReviewEvent

push eventgit-for-windows/get-azure-pipelines-artifact

dependabot[bot]

commit sha de4d01cf282a8c81f50288941f9469b8f1dc57a3

build(deps): bump @adobe/node-fetch-retry from 1.1.2 to 1.1.3 Bumps [@adobe/node-fetch-retry](https://github.com/adobe/node-fetch-retry) from 1.1.2 to 1.1.3. - [Release notes](https://github.com/adobe/node-fetch-retry/releases) - [Changelog](https://github.com/adobe/node-fetch-retry/blob/master/.releaserc.json) - [Commits](https://github.com/adobe/node-fetch-retry/compare/v1.1.2...v1.1.3) --- updated-dependencies: - dependency-name: "@adobe/node-fetch-retry" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

view details

Johannes Schindelin

commit sha b6574fbe46880aeb6c11348f2bb8cbe17f36083b

npm run build && npm run package Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>

view details

Johannes Schindelin

commit sha 596a6106d9c29812ce4e9ba00e15f6cbf5289c81

Merge pull request #197 from git-for-windows/dependabot/npm_and_yarn/adobe/node-fetch-retry-1.1.3 build(deps): bump @adobe/node-fetch-retry from 1.1.2 to 1.1.3

view details

push time in 19 hours

PR merged git-for-windows/get-azure-pipelines-artifact

Reviewers
build(deps): bump @adobe/node-fetch-retry from 1.1.2 to 1.1.3 dependencies

Bumps @adobe/node-fetch-retry from 1.1.2 to 1.1.3. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/adobe/node-fetch-retry/releases"><code>@​adobe/node-fetch-retry</code>'s releases</a>.</em></p> <blockquote> <h2>v1.1.3</h2> <h2><a href="https://github.com/adobe/node-fetch-retry/compare/v1.1.2...v1.1.3">1.1.3</a> (2021-10-22)</h2> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/adobe/node-fetch-retry/commit/48755df4aa7e86fca62ad1e70218cf9a894dfa10"><code>48755df</code></a> [ci skip] no-release: version number update</li> <li><a href="https://github.com/adobe/node-fetch-retry/commit/b650f7faa731e7657331eb8a41dedd84a735689e"><code>b650f7f</code></a> BUGFIX-RELEASE: more robust handling of http errors to fix dep mod tests (<a href="https://github-redirect.dependabot.com/adobe/node-fetch-retry/issues/62">#62</a>)</li> <li>See full diff in <a href="https://github.com/adobe/node-fetch-retry/compare/v1.1.2...v1.1.3">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

+20 -6

0 comment

4 changed files

dependabot[bot]

pr closed time in 19 hours

push eventgit-for-windows/get-azure-pipelines-artifact

Johannes Schindelin

commit sha b6574fbe46880aeb6c11348f2bb8cbe17f36083b

npm run build && npm run package Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>

view details

push time in 19 hours

push eventgit-for-windows/setup-git-for-windows-sdk

dependabot[bot]

commit sha b77124317b057645c8a373da94750a0e9f8b5a54

build(deps): bump @adobe/node-fetch-retry from 1.1.2 to 1.1.3 Bumps [@adobe/node-fetch-retry](https://github.com/adobe/node-fetch-retry) from 1.1.2 to 1.1.3. - [Release notes](https://github.com/adobe/node-fetch-retry/releases) - [Changelog](https://github.com/adobe/node-fetch-retry/blob/master/.releaserc.json) - [Commits](https://github.com/adobe/node-fetch-retry/compare/v1.1.2...v1.1.3) --- updated-dependencies: - dependency-name: "@adobe/node-fetch-retry" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

view details

Johannes Schindelin

commit sha df08470b5cd583cc7df8889eaa09173111440ba1

npm run build && npm run package Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>

view details

Johannes Schindelin

commit sha 320fc2501b79a71b32dc10e1bc24e55a8adc56e6

Merge pull request #246 from git-for-windows/dependabot/npm_and_yarn/adobe/node-fetch-retry-1.1.3 build(deps): bump @adobe/node-fetch-retry from 1.1.2 to 1.1.3

view details

push time in 19 hours

PR merged git-for-windows/setup-git-for-windows-sdk

Reviewers
build(deps): bump @adobe/node-fetch-retry from 1.1.2 to 1.1.3 dependencies

Bumps @adobe/node-fetch-retry from 1.1.2 to 1.1.3. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/adobe/node-fetch-retry/releases"><code>@​adobe/node-fetch-retry</code>'s releases</a>.</em></p> <blockquote> <h2>v1.1.3</h2> <h2><a href="https://github.com/adobe/node-fetch-retry/compare/v1.1.2...v1.1.3">1.1.3</a> (2021-10-22)</h2> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/adobe/node-fetch-retry/commit/48755df4aa7e86fca62ad1e70218cf9a894dfa10"><code>48755df</code></a> [ci skip] no-release: version number update</li> <li><a href="https://github.com/adobe/node-fetch-retry/commit/b650f7faa731e7657331eb8a41dedd84a735689e"><code>b650f7f</code></a> BUGFIX-RELEASE: more robust handling of http errors to fix dep mod tests (<a href="https://github-redirect.dependabot.com/adobe/node-fetch-retry/issues/62">#62</a>)</li> <li>See full diff in <a href="https://github.com/adobe/node-fetch-retry/compare/v1.1.2...v1.1.3">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

+20 -6

0 comment

4 changed files

dependabot[bot]

pr closed time in 19 hours

push eventgit-for-windows/setup-git-for-windows-sdk

Johannes Schindelin

commit sha df08470b5cd583cc7df8889eaa09173111440ba1

npm run build && npm run package Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>

view details

push time in 19 hours