profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/drexin/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

apple/swift-evolution 12159

This maintains proposals for changes and user-visible enhancements to the Swift Programming Language.

drexin/akka-mesos 41

Mesos library built on top of Akka.

drexin/akka-io-file 30

An asynchronous file handling module for Akka IO

drexin/akka-amqp-mailbox 15

Durable akka-mailbox using the AMQP protocol.

drexin/akka-persistence-mapdb 12

A MapDB based backend for Akka persistence

drexin/akka-amqp 3

Akka based AMQP client

drexin/cloby 3

A Clojure Ref/STM plugin for JRuby

drexin/recur 2

Adds tail recursion to every ruby interpreter.

drexin/akka 1

Akka Project

Pull request review commentapple/swift-evolution

Fix typos in SE-0309

 func test(_ collection: RandomAccessCollection) { ``` ___ -This way, a protocol or protocol extension member (method/property/subscript/initializer) may be used on an existential value iff the following criteria hold:+This way, a protocol or protocol extension member (method/property/subscript/initializer) may be used on an existential value if and only if the following criteria hold: * The type of the invoked member (accessor — for storage declarations), as viewed in context of the *base type*, must **not** contain references to `Self` or `Self`-rooted associated types in [non-covariant](https://en.wikipedia.org/wiki/Covariance_and_contravariance_(computer_science)) position.

Awesome, added it to the changes :)

hybridcattt

comment created time in 4 minutes

Pull request review commentapple/swift-evolution

Fix typos in SE-0309

 func test(_ collection: RandomAccessCollection) { ``` ___ -This way, a protocol or protocol extension member (method/property/subscript/initializer) may be used on an existential value iff the following criteria hold:+This way, a protocol or protocol extension member (method/property/subscript/initializer) may be used on an existential value if the following criteria hold:

Thank you!

hybridcattt

comment created time in 11 minutes

Pull request review commentapple/swift-evolution

Fix typos in SE-0309

 func test(_ collection: RandomAccessCollection) { ``` ___ -This way, a protocol or protocol extension member (method/property/subscript/initializer) may be used on an existential value iff the following criteria hold:+This way, a protocol or protocol extension member (method/property/subscript/initializer) may be used on an existential value if and only if the following criteria hold: * The type of the invoked member (accessor — for storage declarations), as viewed in context of the *base type*, must **not** contain references to `Self` or `Self`-rooted associated types in [non-covariant](https://en.wikipedia.org/wiki/Covariance_and_contravariance_(computer_science)) position.

Your suggestion looks fine to me!

hybridcattt

comment created time in 12 minutes

issue commentapple/swift-nio

WebSocket continuation (Fragmentation)

Thank you for your quick response! I will implement it and open a PR.

dnadoba

comment created time in 12 minutes

issue commentapple/swift-nio

WebSocket continuation (Fragmentation)

Nope, SwiftNIO does not provide such a thing. If you wanted to implement it we'd be more than happy to accept the patch.

dnadoba

comment created time in 25 minutes

issue openedapple/swift-nio

WebSocket continuation (Fragmentation)

Hi everyone,

Does SwiftNIO include something similar to WebSocketFrameAggregator from Netty? It buffers incoming WebSocketFrames with the continuation opcode.

I didn't found anything in the swift-nio repository. Vapor has implemented buffering to handle the continuation opcode, but does not enforce a maximum buffer size.

Thanks David

created time in 38 minutes

Pull request review commentapple/swift-evolution

Fix typos in SE-0309

 func test(_ collection: RandomAccessCollection) { ``` ___ -This way, a protocol or protocol extension member (method/property/subscript/initializer) may be used on an existential value iff the following criteria hold:+This way, a protocol or protocol extension member (method/property/subscript/initializer) may be used on an existential value if and only if the following criteria hold: * The type of the invoked member (accessor — for storage declarations), as viewed in context of the *base type*, must **not** contain references to `Self` or `Self`-rooted associated types in [non-covariant](https://en.wikipedia.org/wiki/Covariance_and_contravariance_(computer_science)) position.

While examining this section, I found the sentence structure here a bit hard to parse. I suggest we reverse the wording for easier understanding, which then also mirrors the outlined limitations above

This way, a protocol or protocol extension member (method/property/subscript/initializer) may be used on an existential value *unless*:
* The type of the invoked member (accessor — for storage declarations), as viewed in context of the *base type*, contains references to `Self` or `Self`-rooted associated types in [non-covariant](https://en.wikipedia.org/wiki/Covariance_and_contravariance_(computer_science)) position.

Feel free to discard this suggestion if you think it's not necessary.

hybridcattt

comment created time in 2 hours

Pull request review commentapple/swift-evolution

Fix typos in SE-0309

 func test(_ collection: RandomAccessCollection) { ``` ___ -This way, a protocol or protocol extension member (method/property/subscript/initializer) may be used on an existential value iff the following criteria hold:+This way, a protocol or protocol extension member (method/property/subscript/initializer) may be used on an existential value if the following criteria hold:

Updated to use the spelled out version. From the context it seems intentional and not a typo.

hybridcattt

comment created time in 2 hours

Pull request review commentapple/swift-evolution

Fix typos in SE-0309

 func test(_ collection: RandomAccessCollection) { ``` ___ -This way, a protocol or protocol extension member (method/property/subscript/initializer) may be used on an existential value iff the following criteria hold:+This way, a protocol or protocol extension member (method/property/subscript/initializer) may be used on an existential value if the following criteria hold:

"iff" was removed from public API documentation: apple/swift#27115

hybridcattt

comment created time in 3 hours

Pull request review commentapple/swift-evolution

Fix typos in SE-0309

 func test(_ collection: RandomAccessCollection) { ``` ___ -This way, a protocol or protocol extension member (method/property/subscript/initializer) may be used on an existential value iff the following criteria hold:+This way, a protocol or protocol extension member (method/property/subscript/initializer) may be used on an existential value if the following criteria hold:

TIL - I've never seen it shortened like that before (having studied math in another language). Would you agree that it'd be clearer, if it's spelled out fully?

hybridcattt

comment created time in 3 hours

push eventapple/swift-evolution

Kirill Titov

commit sha 80602141f65b3fc8a98283e1e8dc4fe1b51312bd

0311 minor fixes (#1335) Plain text print to actual call

view details

push time in 4 hours

PR merged apple/swift-evolution

0311 print fixes

Plain text print to actual call

+5 -5

2 comments

1 changed file

kirilltitov

pr closed time in 4 hours

pull request commentapple/swift-evolution

0311 print fixes

Sure, might as well -- thank you.

kirilltitov

comment created time in 4 hours

pull request commentapple/swift-evolution

0311 print fixes

cc @ktoso

kirilltitov

comment created time in 4 hours

PR opened apple/swift-evolution

0311 print fixes

Plain text print to actual call

+5 -5

0 comment

1 changed file

pr created time in 4 hours

pull request commentapple/swift-driver

PrebuiltModuleGen: add an option for skipping the job execution

@swift-ci please test

nkcsgexi

comment created time in 8 hours

push eventapple/swift-driver

Artem Chikin

commit sha 631d7eb931d5b1d9af87bded3efc99869d866aa2

Update `isSDKTooOld` to be compatible with older compilers. 5.3 and ealier compilers may hit: ``` swift-driver/Sources/SwiftDriver/Driver/Driver.swift:2044:15: error: definition conflicts with previous value guard let sdkInfo = sdkInfo else { ```

view details

Artem Chikin

commit sha cd5bfdc30d2f2a41ea58116cd07191c4bc42d109

Merge pull request #609 from artemcm/OldCompilersNeedHelp Update `isSDKTooOld` to be compatible with older compilers.

view details

push time in 8 hours

PR merged apple/swift-driver

Reviewers
Update `isSDKTooOld` to be compatible with older compilers.

5.3 and ealier compilers may hit:

swift-driver/Sources/SwiftDriver/Driver/Driver.swift:2044:15: error: definition conflicts with previous value
    guard let sdkInfo = sdkInfo else {

e.g. https://ci.swift.org/job/swift-PR-toolchain-osx/949/console

+2 -2

1 comment

1 changed file

artemcm

pr closed time in 8 hours

pull request commentapple/swift-driver

Update `isSDKTooOld` to be compatible with older compilers.

@swift-ci please test

artemcm

comment created time in 8 hours

PR opened apple/swift-driver

Reviewers
Update `isSDKTooOld` to be compatible with older compilers.

5.3 and ealier compilers may hit:

swift-driver/Sources/SwiftDriver/Driver/Driver.swift:2044:15: error: definition conflicts with previous value
    guard let sdkInfo = sdkInfo else {

e.g. https://ci.swift.org/job/swift-PR-toolchain-osx/949/console

+2 -2

0 comment

1 changed file

pr created time in 8 hours

push eventapple/swift-driver

Artem Chikin

commit sha 433c66dbe644f5beb6adb9127eba7e838489a707

Remove target `x86_64` specialization from `testExplicitModuleBuildEndToEnd`

view details

Xi Ge

commit sha ddf2bde1a44981af935c55ffd9d0288b97c9fe3d

Merge pull request #608 from artemcm/NoTargetInEndToEndTest Remove target `x86_64` specialization from `testExplicitModuleBuildEndToEnd`

view details

push time in 9 hours

PR merged apple/swift-driver

Reviewers
Remove target `x86_64` specialization from `testExplicitModuleBuildEndToEnd`

This explicit specifier causes these modules to get built for x86_64 even on Apple Silicon hosts: e.g. https://ci.swift.org/job/oss-swift-incremental-RA-macos-apple-silicon/490/console

+3 -3

1 comment

3 changed files

artemcm

pr closed time in 9 hours

pull request commentapple/swift-driver

Remove target `x86_64` specialization from `testExplicitModuleBuildEndToEnd`

@swift-ci please test

artemcm

comment created time in 10 hours

PR opened apple/swift-driver

Reviewers
Remove target `x86_64` specialization from `testExplicitModuleBuildEndToEnd`

This explicit specifier causes these modules to get built for x86_64 even on Apple Silicon hosts: e.g. https://ci.swift.org/job/oss-swift-incremental-RA-macos-apple-silicon/490/console

+3 -3

0 comment

3 changed files

pr created time in 10 hours

pull request commentapple/swift-tools-support-core

Improve path normalization and judgment on Windows

First, please work with @compnerd to get this PR to a mergeable state.

I’m just missing the point to evolve this PR. I believe in its current state it’s making things better (but not perfect yet) without introducing new problems.

@compnerd Can you make a detailed review on the codes?

stevapple

comment created time in 13 hours

PR opened apple/swift-argument-parser

Hide option group with new OptionGroup constructor

Second PR that is needed to fix --help for SwiftPM

Related PRs:

SwiftPM ArgumentParser

Checklist

  • [x] I've added at least one test that validates that my change is working, if appropriate
  • [x] I've followed the code style of the rest of the project
  • [x] I've read the Contribution Guidelines
  • [x] I've updated the documentation if necessary
+155 -5

0 comment

7 changed files

pr created time in 15 hours

create barnchapple/swift-argument-parser

branch : hideOptionGroup

created branch time in 15 hours

push eventapple/swift-driver

Artem Chikin

commit sha e1e9b80db1f7c71169f6581162a63d35147bd5d4

Account for Simulator platforms when checking if the provided SDK is too old

view details

Artem Chikin

commit sha b7fb5872cea5c1fd0172afface415d1a7f0a38ae

Merge pull request #607 from artemcm/SimulatorSDKTooOld Account for Simulator platforms when checking if the provided SDK is too old

view details

push time in 15 hours