profile
viewpoint

dongsik-yoo/assemblyscript-live-loader 18

webpack loader that compiles assemblyscript to webassembly(wasm) and bundles it

dongsik-yoo/my-custom-framework 5

An example to render html without framework using Proxy, snabbdom

dongsik-yoo/esm-ui-library 4

Javascript UI Library Boilerplate to support eliminating dead code(Tree Shaking)

dongsik-yoo/html-page-layout 4

html page layout tool

dongsik-yoo/awesome-expo-web-example 1

awesome-expo-web-example

dongsik-yoo/tui.grid 1

Toast UI Grid

dongsik-yoo/hands-on-labs.toastui-calendar 0

NHN Forward Hands on Labs - Toast UI Calendar

issue commentnhn/tui.calendar

Posting data that ends up in calendar.

This issue has been automatically marked as inactive because there hasn’t been much going on it lately. It is going to be closed after 7 days. Thanks!

dadweiss

comment created time in 14 hours

issue commentnhn/tui.calendar

dayGrid click event problem When don't use popup.

This issue has been automatically marked as inactive because there hasn’t been much going on it lately. It is going to be closed after 7 days. Thanks!

sjpark0513

comment created time in 14 hours

issue openednhn/tui.calendar

Posibility to set maximum schedule duration

Hello, the issue is that I need to disable the ability to create a schedule that spans across multiple days.

Version

The demo in https://ui.toast.com/tui-calendar

Current Behavior

Right now the user is able to create a schedule that spans across multiple days: image

Expected Behavior

The user can only pick one day and set the starting hour and end hour. For example, the user would pick the day of the schedule to be 2020-12-02 and then be able to select start hours (i.e. 10:00) and end hours (i.e. 15:00)

created time in a day

issue commentnhn/tui.calendar

Drag/Drop an element from outside the Calendar to schedule it.

This feature is not yet supported.

Tudodesk

comment created time in 2 days

issue openednhn/tui.calendar

Drag/Drop an element from outside the Calendar to schedule it.

How can I drag a Dom element from outside the calendar and drop it on a day to scheduled it. I would use HTML5 drag drop. Want I am trying to do is detect the drop event in the calendar and schedule it based on the day element it is dropped into. Is this possible?

created time in 5 days

issue commentnhn/tui.calendar

Week schedule does not get smaller than 20 minutes

This issue has been automatically marked as inactive because there hasn’t been much going on it lately. It is going to be closed after 7 days. Thanks!

ifrancesalcantara

comment created time in 6 days

pull request commentnhn/tui.calendar

Fix: Incorrect time for created schedule when event is after Daylight Saving Time change

This issue has been automatically marked as inactive because there hasn’t been much going on it lately. It is going to be closed after 7 days. Thanks!

lunfel

comment created time in 6 days

starteddongsik-yoo/assemblyscript-live-loader

started time in 6 days

push eventnhn/tui.calendar

Jenny Cho

commit sha 03112f371aaf1ef6ecf995d1e63fef8bd78ae716

chore: change crone string

view details

push time in 8 days

push eventnhn/tui.calendar

Jenny Cho

commit sha 1318406578e1b654c2f47a246d9065dbfad974dc

refactor: update example code

view details

push time in 8 days

push eventnhn/tui.calendar

Jenny Cho

commit sha a1363ba2455291de6cdf7b54c1872c832e1facf8

chore: change action cron string

view details

push time in 8 days

push eventnhn/tui.calendar

Jenny Cho

commit sha 3cd83ccad92209cbf1e783c5f54f3195c5c769a1

chore: set-env deprecated

view details

push time in 9 days

issue commentnhn/tui.calendar

Support for Arabic - Right to Left

Not planned yet.

MM-Awais

comment created time in 9 days

issue commentnhn/tui.calendar

Location is undefined

Check it out. Nice work! https://codesandbox.io/s/tuicalendar-for-using-popupdetail-11214-wy38x

kpehl

comment created time in 9 days

push eventnhn/tui.calendar

Jenny Cho

commit sha 9825ffb7ae5ba8df18ebd629f5c763c9f37ba1a3

fix: resolve creation popup for using dst timezone

view details

push time in 9 days

push eventnhn/tui.calendar

Jenny Cho

commit sha 38452e128c56d8280adc3797481a4a8bad92384e

fix: recalculate detail popup time

view details

push time in 10 days

push eventnhn/tui.calendar

Jenny Cho

commit sha e4483ef02c0e4a1066e5c4e427bd8bce90e9bbc3

refactor: remove console log

view details

push time in 10 days

push eventnhn/tui.calendar

Jenny Cho

commit sha 07833c150b88d81f2e782ada8bf8d1c83a2cdeb3

refactor: refactor duration code

view details

push time in 11 days

push eventnhn/tui.calendar

Jenny Cho

commit sha bebadc99be99c679939a81b4f012d07d6c00444a

test: resolve broken TC

view details

push time in 11 days

pull request commentnhn/tui.calendar

Feat : custom timezone spec (#723)

ok to test

jungeun-cho

comment created time in 11 days

PR closed nhn/tui.calendar

fix: resolve event rendering issue when including DST timezones(fix #671, #677, #423) Category: DST Category: Timezone

<!-- EDIT TITLE PLEASE --> <!-- It should be one of them <ISSUE TYPE>: Short Description (<CLOSING TYPE> #<ISSUE NUMBERS>) ex) feat: add new feature (close #111) fix: wrong behavior (fix #111) chore: change build tool (ref #111) -->

<!-- SPECIFY A ISSUE TYPE AT HEAD feat: A new feature fix: A bug fix docs: Documentation only changes style: Changes that do not affect the meaning of the code (white-space, formatting etc) refactor: A code change that neither fixes a bug or adds a feature perf: A code change that improves performance test: Adding missing tests chore: Changes to the build process or auxiliary tools and libraries such as documentation generation -->

<!-- ADD CLOSING TYPE AND ISSUE NUMBER AT TAIL (<CLOSING TYPE> #<ISSUE NUMBERS>) close: resolve not a bug(feature, docs, etc) completely fix: resolve a bug completely ref: not fully resolved or related to -->

Please check if the PR fulfills these requirements

  • [x] It's submitted to right branch according to our branching model
  • [x] It's right issue type on title
  • [x] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • [x] The commit message follows our guidelines
  • [x] Tests for the changes have been added (for bug fixes/features)
  • [x] Docs have been added/updated (for bug fixes/features)
  • [x] It does not introduce a breaking change or has description for the breaking change

Description

  • Whether or not summer time is used, the schedule should always be rendered in the same location.
  • The schedule at the time when the time zone offset is changed is displayed as follows. (similar to Google Calendar or Mac Calendar behavior)
// e.g. If I live in NY 
cal.createSchedules([
  {
    id: 1,
    calendarId: '1',
    start: '2020-11-01 01:00:00',
    end: '2020-11-01 02:00:00',
    title: 'EDT -> EST (01:00 ~ 02:00(O), 01:00 ~ 03:00(X))',
    category: 'time',
  },
  {
    id: 2,
    calendarId: '2',
    start: '2021-03-14 01:00:00',
    end: '2021-03-14 02:00:00',
    title: 'EST -> EDT (01:00 ~ 02:00(X), 01:00 ~ 03:00(O))',
    category: 'time',
  }
...
]);

스크린샷 2020-10-28 03 44 24 스크린샷 2020-10-28 03 44 37

  • Resolved when using custom time zone offset.

You can customize the default time zone (e.g.'Asia / Seoul','America / New_York') when rendering the calendar.

The timezones and timezoneOffset will be deprecated. In order to calculate the offset, timezone property is essential.

A new timeZone option is available. Set the list of time zones in the zones property. Basically, it will calculate the offset using Intl.DateTimeFormat with the value of the timezone property entered.

If you define the offsetCalculator property, the offset calculation is done with this function.

var cal = new Calendar('#calendar', {
  timeZone: { // set timeZone config
    zones: [
      {
        tooltip: 'Seoul',
        timezone: 'Asia/Seoul',
        displayLabel: 'GMT+09:00'
      },
      {
        tooltip: 'New York',
        timezone: 'America/New_York',
        displayLabel: 'GMT-05:00'
      },
    ],
  }
});

The offsetCalculator option allows you to set up a function that returns the timezone offset for that time using date libraries like js-joda and moment-timezone.

The offsetCalculator option is useful when your browser does not support Intl.DateTimeFormat and formatToPart, or you want to use the date library you are familiar with.

var cal = new Calendar('#calendar', {
  timeZone: { // set timeZone config
    ...
    offsetCalculator: function(timezone, timestamp){
      // e.g. +09:00 => 540, -04:00 => -240
      return -moment.tz.zone(timezone).utcOffset(timestamp);
    },
  }
});

If you are using a custom time zone, you need to add a polyfill if all of the following are true.

1) Browser does not support Intl.DateTimeFormat and formatToPart. 2) The offsetCalculator option is not defined. 3) Your service supports Internet Explorer.

  • Fixed schedule rendering bug when creating schedule after or before time zone offset was changed

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

+395 -48

10 comments

7 changed files

jungeun-cho

pr closed time in 11 days

issue openednhn/tui.calendar

Improved schedule creation guide time display

<!-- Thank you for your contribution.

When it comes to write an issue, please, use the template below. To use the template is mandatory for submit new issue and we won't reply the issue that without the template.

And you can write template's contents in Korean also. -->

Version

1.13

Current Behavior

1) When the regional setting of the system OS is set to New York. 스크린샷 2020-11-17 21 54 30

2) Main time zone is set to Seoul (+09:00) by the custom time zone setting of the calendar.

const cal = new Calendar(el, {
  defaultView: 'week',
  timeZone: {
      zones: [
        {
          tooltip: 'Seoul',
          displayLabe: '+09:00',
          timezone: 'Asia/Seoul',
        },
        {
          tooltip: 'New York',
          displayLabe: '+09:00',
          timezone: 'America/New_York',
        },
      ],
},
});

3) The guide display time in the time grid of the weekly view is affected by the system OS. * It is displayed as '01:00 ~ 03:00'. 스크린샷 2020-11-17 22 53 35

Expected Behavior

Since the main time zone is Seoul (+0900), the time displayed in the guide should be '01:00-02:00'.

created time in 11 days

issue openednhn/tui.calendar

Custom time zone designation option specification definition

Version

1.13

Custom Timezone Setting

AS-IS

const cal = new Calendar(el, {
    ...
    timezones: [
            {
              tooltip: 'Seoul',
              displayLabel: 'GMT+09:00',
              timezoneOffset: 540
            },
            {
              tooltip: 'New York',
              displayLabel: 'GMT-05:00',
              timezoneOffset: -300
            },
    ]
});

The timezones and timezoneOffset will be deprecated.

In order to calculate the offset, timezone info(e.g. 'Asia/Seoul', 'America/New_York') is essential. A new timeZone option is available. Set the list of time zones in the zones property. Basically, it will calculate the offset using Intl.DateTimeFormat with the value of the timezone property entered.

TO-BE

const cal = new Calendar(el, {
    timeZone: {
        zones: [
            {
              timezone: 'Asia/Seoul',
              tooltip: 'Seoul',
              displayLabel: 'GMT+09:00'
            },
            {
              timezone: 'America/New_York',
              tooltip: 'New York',
              displayLabel: 'GMT-05:00'
            },
        ]
    }
});

If you define the offsetCalculator property, the offset calculation is done with this function. The offsetCalculator option allows you to set up a function that returns the timezone offset for that time using date libraries like js-joda and moment-timezone.

The offsetCalculator option is useful when your browser does not support Intl.DateTimeFormat andformatToPart, or you want to use the date library you are familiar with.

const cal = new Calendar(el, {
    timeZone: {
        zones: [
            {
              timezone: 'Asia/Seoul',
              tooltip: 'Seoul',
              displayLabel: 'GMT+09:00'
            },
            {
              timezone: 'America/New_York',
              tooltip: 'New York',
              displayLabel: 'GMT-05:00'
            },
        ],
        offsetCalculator: function(timezone, timestamp){
            // matches 'getTimezoneOffset()' of Date API
            // e.g. +09:00 => -540, -04:00 => 240
            return moment.tz.zone(timezone).utcOffset(timestamp);
        },
    }
});

If you are using a custom time zone, you need to add a polyfill if all of the following are true.

  1. Browser does not support Intl.DateTimeFormat and formatToPart.
  2. The offsetCalculator option is not defined.
  3. Your service supports Internet Explorer.

UMD

  • Intl ployfill
  • I copied the node_modules/@formatjs/intl-datetimeformat/polyfill.umd.min.js file and used it.
  • You also need node_modules/@formatjs/intl-getcanonicallocales/polyfill.umd.min.js file to support lower versions of Internet Explorer 11.

CommonJS / ES6

created time in 11 days

pull request commentnhn/tui.calendar

Feat : custom timezone spec

ok to test

jungeun-cho

comment created time in 11 days

push eventnhn/tui.calendar

Jenny Cho

commit sha e00b294fe65a5c3b234f8115615fae85ed5002b5

refactor: remove unnecessary code

view details

push time in 11 days

push eventnhn/tui.calendar

조정은

commit sha 76b9d6be22ccfee06ea61c46fe310bb8a0bc139b

style: fix prettier config (#722)

view details

조정은

commit sha 8fee2b51425cce38cddf987c6ce603a381b6ca4d

Merge branch 'master' into feat/custom-timezone-spec

view details

push time in 11 days

delete branch nhn/tui.calendar

delete branch : style/fix-prettier

delete time in 11 days

push eventnhn/tui.calendar

Jenny Cho

commit sha 7e8156549457537ab50dba0fed9960e452633ff1

style: revert eslint style

view details

push time in 11 days

push eventnhn/tui.calendar

조정은

commit sha 76b9d6be22ccfee06ea61c46fe310bb8a0bc139b

style: fix prettier config (#722)

view details

push time in 11 days

PR merged nhn/tui.calendar

style: fix prettier config

<!-- EDIT TITLE PLEASE --> <!-- It should be one of them <ISSUE TYPE>: Short Description (<CLOSING TYPE> #<ISSUE NUMBERS>) ex) feat: add new feature (close #111) fix: wrong behavior (fix #111) chore: change build tool (ref #111) -->

<!-- SPECIFY A ISSUE TYPE AT HEAD feat: A new feature fix: A bug fix docs: Documentation only changes style: Changes that do not affect the meaning of the code (white-space, formatting etc) refactor: A code change that neither fixes a bug or adds a feature perf: A code change that improves performance test: Adding missing tests chore: Changes to the build process or auxiliary tools and libraries such as documentation generation -->

<!-- ADD CLOSING TYPE AND ISSUE NUMBER AT TAIL (<CLOSING TYPE> #<ISSUE NUMBERS>) close: resolve not a bug(feature, docs, etc) completely fix: resolve a bug completely ref: not fully resolved or related to -->

Please check if the PR fulfills these requirements

  • [x] It's submitted to right branch according to our branching model
  • [ ] It's right issue type on title
  • [ ] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • [x] The commit message follows our guidelines
  • [ ] Tests for the changes have been added (for bug fixes/features)
  • [ ] Docs have been added/updated (for bug fixes/features)
  • [ ] It does not introduce a breaking change or has description for the breaking change

Description

  • fix prettier config

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

+23 -39

0 comment

4 changed files

jungeun-cho

pr closed time in 11 days

more