profile
viewpoint

console-rs/indicatif 2326

A command line progress reporting library for Rust

bluejekyll/trust-dns 2189

A Rust based DNS client, server, and resolver

djc/askama 1538

Type-safe, compiled Jinja-like templates for Rust

djc/bb8 392

Full-featured async (tokio-based) postgres connection pool (like r2d2)

budziq/rust-skeptic 269

Test your Rust Markdown documentation via Cargo

djc/awmy 31

arewemeetingyet.com: help communicate meeting times to timezone-challenged participants

djc/abna 10

Python library to automatically retrieve mutations from ABN Amro

djc/appdirs-rs 7

Rust crate for determining platform-specific application directories

djc/corda-rpc 6

Rust libraries for doing Corda RPC

djc/clang-format-find 1

Find the clang-format configuration that best fits your codebase

PullRequestReviewEvent

issue commentrustls/rustls

CI/CD should warn about using Rust versions with known vulnerabilities

Ah, I see it has been released:

https://rustsec.org/advisories/CVE-2022-21658.html

briansmith

comment created time in 4 hours

issue commentrustls/rustls

`cargo check --all-features` is broken on non-nightly builds

Yup, I also dislike the current setup. On the other hand, not a big fan of build scripts either. Seems like #[rustversion::nightly] could do the trick nicely, though?

briansmith

comment created time in 7 hours

issue commentrustls/rustls

CI/CD should warn about using Rust versions with known vulnerabilities

The usual way I do this is by running cargo deny, but I haven't seen an advisory in the database about the std vulnerability yet.

briansmith

comment created time in 7 hours

PR closed bluejekyll/trust-dns

Bump clap from 3.0.7 to 3.0.10 dependencies

Bumps clap from 3.0.7 to 3.0.10. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/clap-rs/clap/releases">clap's releases</a>.</em></p> <blockquote> <h2>v3.0.10</h2> <h2>[3.0.10] - 2022-01-18</h2> <h3>Fixes</h3> <ul> <li>Resolve <code>panic!</code> from v3.0.8 when using <code>global_setting(PropagateVersion)</code>.</li> </ul> <h2>v3.0.9</h2> <h2>[3.0.9] - 2022-01-17</h2> <h3>Features</h3> <ul> <li>Added <code>App::find_subcommand_mut</code></li> </ul> <h2>v3.0.8</h2> <h2>[3.0.8] - 2022-01-17</h2> <h3>Fixes</h3> <ul> <li>Respected <code>DisableColoredHelp</code> on <code>cmd help help</code></li> <li>Provide a little more context when completing arguments for <code>cmd help</code></li> <li>Provide more context for some asserts</li> <li>Small documentation improvements</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/clap-rs/clap/blob/master/CHANGELOG.md">clap's changelog</a>.</em></p> <blockquote> <h2>[3.0.10] - 2022-01-18</h2> <h3>Fixes</h3> <ul> <li>Resolve <code>panic!</code> from v3.0.8 when using <code>global_setting(PropagateVersion)</code>.</li> </ul> <h2>[3.0.9] - 2022-01-17</h2> <h3>Features</h3> <ul> <li>Added <code>App::find_subcommand_mut</code></li> </ul> <h2>[3.0.8] - 2022-01-17</h2> <h3>Fixes</h3> <ul> <li>Respected <code>DisableColoredHelp</code> on <code>cmd help help</code></li> <li>Provide a little more context when completing arguments for <code>cmd help</code></li> <li>Provide more context for some asserts</li> <li>Small documentation improvements</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/clap-rs/clap/commit/5877f884f17af99937f91ebb065179faacd65378"><code>5877f88</code></a> chore: Release</li> <li><a href="https://github.com/clap-rs/clap/commit/8cfa3567ef638255ce34abfcc05029f71c0bb98c"><code>8cfa356</code></a> docs: Update changelog</li> <li><a href="https://github.com/clap-rs/clap/commit/c6b5f640a4ba883ef700425ecfae0173a307a9df"><code>c6b5f64</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/clap-rs/clap/issues/3311">#3311</a> from epage/fix</li> <li><a href="https://github.com/clap-rs/clap/commit/38e6952d4687ac04645c97ecad31833d98838611"><code>38e6952</code></a> fix: Don't panic when propagating</li> <li><a href="https://github.com/clap-rs/clap/commit/4b60440d91c02a472e31e66117c34b0fc9e6d09a"><code>4b60440</code></a> docs: Note case in <a href="https://github-redirect.dependabot.com/clap-rs/clap/issues/3309">#3309</a></li> <li><a href="https://github.com/clap-rs/clap/commit/bd1bf66279c3e965a0d4d73135d952bfd3c270eb"><code>bd1bf66</code></a> chore: Release</li> <li><a href="https://github.com/clap-rs/clap/commit/4e51f9b0efa39e71b92ced0bdfa30a0b39107f52"><code>4e51f9b</code></a> docs: Update changelog</li> <li><a href="https://github.com/clap-rs/clap/commit/784d249a4ee12f4742c27e7a620a055e9b673121"><code>784d249</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/clap-rs/clap/issues/3306">#3306</a> from sunshowers/sub</li> <li><a href="https://github.com/clap-rs/clap/commit/236ec973d95e02c8440ee0da6e6c5713389ffc71"><code>236ec97</code></a> feat: Implement App::find_subcommand_mut</li> <li><a href="https://github.com/clap-rs/clap/commit/ccbbba8908ac30114345a26ccba227326c0ec73d"><code>ccbbba8</code></a> chore: Release</li> <li>Additional commits viewable in <a href="https://github.com/clap-rs/clap/compare/v3.0.7...v3.0.10">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

+4 -4

2 comments

1 changed file

dependabot[bot]

pr closed time in 8 hours

pull request commentbluejekyll/trust-dns

Bump clap from 3.0.7 to 3.0.10

@dependabot ignore this major version

dependabot[bot]

comment created time in 8 hours

push eventrustls/rustls

Brian Smith

commit sha 97c366945234bb709ef7fc56ea6ad280d8cc8d8d

Remove `RsaSigningKey` from the public API documentation. The API isn't part of the public API. It is `pub` only because some tests use it.

view details

push time in 8 hours

PR merged rustls/rustls

Remove `RsaSigningKey` from the public API documentation.

The API isn't part of the public API. It is pub only because some tests use it.

+5 -1

0 comment

1 changed file

briansmith

pr closed time in 8 hours

PullRequestReviewEvent

Pull request review commentrustls/rustls

Remove `RsaSigningKey` from the public API documentation.

 pub fn any_eddsa_type(der: &key::PrivateKey) -> Result<Arc<dyn SigningKey>, Sign     Err(SignError(())) } -/// A `SigningKey` for RSA-PKCS1 or RSA-PSS+/// A `SigningKey` for RSA-PKCS1 or RSA-PSS.+///+/// This is used by the test suite, so it must be `pub`, but it isn't part of+/// the public, stable, API.+#[doc(hidden)]

Maybe file a follow-up issue or, even better, a tracker issue for all the API-incompatible changes we want to make?

briansmith

comment created time in 8 hours

PullRequestReviewEvent

push eventrustls/rustls

Brian Smith

commit sha 5835681bbfd41f6f1ae05de119734cf3622d5127

CommonState::process_main_protocol: Remove misleading comments. The comments are out of date. In particular, `check_message` isn't used, but also the other comments are misleading. Just remove them.

view details

push time in 8 hours

PR merged rustls/rustls

CommonState::process_main_protocol: Remove misleading comments.

The comments are out of date. In particular, check_message isn't used, but also the other comments are misleading. Just remove them.

+0 -3

0 comment

1 changed file

briansmith

pr closed time in 8 hours

PullRequestReviewEvent

issue closedrustls/rustls

Is it possible to export CommonState -> record_layer-> message_encrypter content

Hi, all

I'm trying to see is it possible to get the AES/Chacha20_poly1305, symmetric key and IV, salt, and seq value from the TLS1.2/1.3's CommonState record_layer, is there any plan to add this function from the export_key_materials interfaces? if currently supported this function already please let me know, if it is not implementated yet, do you like to have this kind of functionalities? if plan to have this types of funcs, maybe I can try to add this to rustls.

closed time in 8 hours

AlexZhao

issue commentrustls/rustls

Is it possible to export CommonState -> record_layer-> message_encrypter content

Yeah, let's discuss that in terms of the problem, not a particular solution.

AlexZhao

comment created time in 8 hours

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentquinn-rs/quinn

Implement draft-ietf-quic-bit-grease-02

 impl TransportParameters {                     }                     params.max_datagram_frame_size = Some(r.get().unwrap());                 }+                0x2ab2 => {+                    if len != 0 {+                        return Err(Error::Malformed);+                    }+                    params.grease_quic_bit = true;

Nit: match?

Ralith

comment created time in 8 hours

push eventrustls/rustls

Brian Smith

commit sha 3e466251eb73bf05fe452aadff9764ac0222c6b0

Clarify when `may_receive_application_data` is set. `start_incoming_traffic()` doesn't need to exist as a `pub(crate)` function, or at all, because it is only used by the function right below it. Inline it into that function to make it clearer when `may_receive_application_data` is set.

view details

push time in 20 hours

PR merged rustls/rustls

Clarify when `may_receive_application_data` is set.

start_incoming_traffic() doesn't need to exist as a pub(crate) function, or at all, because it is only used by the function right below it. Inline it into that function to make it clearer when may_receive_application_data is set.

+1 -5

0 comment

1 changed file

briansmith

pr closed time in 20 hours

PullRequestReviewEvent

push eventrustls/rustls

Dirkjan Ochtman

commit sha 3405c4fc77966818fc23b8b4d645aa58fa997ae5

Implement enum for client/server distinctions

view details

Dirkjan Ochtman

commit sha 9a4307f7a7b7ca65af5aafe9f1547399994177c3

Explicitly pass side to make_cipher_pair()

view details

Dirkjan Ochtman

commit sha be5b3972a0c7ebe1be9c2e4075bb331b516c6f1a

tls12: inline downgrade marker handling Avoids duplicating the client/server state in the ConnectionRandoms, which was unused if TLS 1.2 was disabled.

view details

push time in a day

PR merged rustls/rustls

Make side handling more obvious

Removes the ConnectionRandoms::we_are_client and CommonState::is_client fields in favor of getting this state from the context. The former was unused in case TLS 1.2 was disabled, leading to a warning. Saves a few lines of code, 1 bit of state in handshake states, 1 bit of state in CommonState, and a branch in process_main_protocol(). Also defines an enum Side { Client, Server } in favor of using bool, which makes the resulting code easier to follow.

+42 -57

3 comments

8 changed files

djc

pr closed time in a day

pull request commentbluejekyll/trust-dns

update clap to 3.0

Sounds good!

bluejekyll

comment created time in a day

pull request commentbluejekyll/trust-dns

update clap to 3.0

I'd probably still prefer to be a little more conservative, but I'm also fine if you prefer to go with 1.54.

bluejekyll

comment created time in a day

issue commentrust-lang/rustfmt

cargo fmt doesn't work with --all --manifest-path

This is with the current stable. I finally figured out that the issue was that one of the crates had a workspace = [".."] in its metadata pointing to a directory where no Cargo.toml was present. This didn't seem to cause issues for Cargo (which arguably should warn about this), but caused this suprising warning from rustfmt.

djc

comment created time in a day

issue commentrust-lang/rustfmt

cargo fmt doesn't work with --all --manifest-path

Actually, something stranger is going on:

djc-2021 split-rust bolt $ git checkout main
Switched to branch 'main'
Your branch is up to date with 'origin/main'.
djc-2021 main bolt $ find . -name "Cargo.toml"
./rust/Cargo.toml
./rust/screenshot/Cargo.toml
./rust/epp/Cargo.toml
./rust/downloader/Cargo.toml
./rust/shared/Cargo.toml
./rust/vectors/Cargo.toml
./rust/gcp/Cargo.toml
./rust/whois/Cargo.toml
./rust/epoxide/Cargo.toml
./rust/loader/Cargo.toml
./rust/diachron/Cargo.toml
./rust/nominl/Cargo.toml
./rust/service/Cargo.toml
./rust/dns/Cargo.toml
./rust/servec/Cargo.toml
djc-2021 main bolt $ cargo fmt --manifest-path rust/Cargo.toml --all -- --check
djc-2021 main bolt $ git checkout split-rust
Switched to branch 'split-rust'
Your branch is up to date with 'origin/split-rust'.
djc-2021 split-rust bolt $ find . -name "Cargo.toml"                                 
./rust/domains/Cargo.toml
./rust/domains/epp/Cargo.toml
./rust/domains/whois/Cargo.toml
./rust/domains/epoxide/Cargo.toml
./rust/domains/dns/Cargo.toml
./rust/shared/Cargo.toml
./rust/gcp/Cargo.toml
./rust/search/Cargo.toml
./rust/search/screenshot/Cargo.toml
./rust/search/downloader/Cargo.toml
./rust/search/vectors/Cargo.toml
./rust/search/loader/Cargo.toml
./rust/search/diachron/Cargo.toml
./rust/search/nominl/Cargo.toml
./rust/search/servec/Cargo.toml
./rust/service/Cargo.toml
djc-2021 split-rust bolt $ cargo fmt --manifest-path rust/domains/Cargo.toml --all -- --check
`cargo metadata` exited with an error: error: failed to read `/Users/djc/src/bolt/rust/Cargo.toml`

Caused by:
  No such file or directory (os error 2)
djc

comment created time in a day

issue openedrust-lang/rustfmt

cargo fmt doesn't work with --all --manifest-path

I can invoke cargo check --workspace --manifest-path path/to/Cargo.toml and it will ostensibly do the right thing. However, cargo fmt --manifest-path does not seem to understand workspace manifests (with or without --all).

created time in a day

issue commentEmbarkStudios/cargo-deny

Private crates that are added via path are not recognized as private

FWIW, I'm also running into this. At work, I'm doing an experiment where I switch our Cargo workspace into two workspaces with a few shared crates outside the workspace. Those crates are used as path dependencies directly.

fgo-ableton

comment created time in a day

more