Kwang-in (Dennis) Jung djKooks LeapMind Inc. Tokyo, Japan http://djkooks.github.io Developer, 개발자、かいはつしゃ

startedHAECHI-LABS/vvisp

started time in 20 hours

issue openedcontentful/rich-text.php

Too few arguments to Parser

Hello, I caught an error when calling parser and renderer for RichText

2019/03/19 06:21:17 [error] 6#6: *5 FastCGI sent in stderr: "PHP message: PHP Fatal error:  Uncaught ArgumentCountError: Too few arguments to function Contentful\RichText\Parser::__construct(), 0 passed in /var/www/html/include/contentful_function.php on line 82 and at least 1 expected in /var/www/html/assets/vendor/contentful/rich-text/src/Parser.php:45

My code is:

...
    $parser = new Contentful\RichText\Parser();
    $renderer = new Contentful\RichText\Renderer();
    
    $node = $parser->parse($data);
...

What parameter do I have to put on Parser constructor?

Thanks.

created time in 21 hours

issue openeddjKooks/piggi

Make installer

Create installer to make user can use it directly by installing from package manager(such as homebrew)

created time in 4 days

created tagdjKooks/piggi

tagv0.1

(WIP!) Prompt-base Interactivity for GitHub

created time in 4 days

release djKooks/piggi

v0.1

released time in 4 days

push eventdjKooks/piggi

Kwang-in (Dennis) Jung

commit sha 67d2966ce5c98085e627ade1a65b77fbd7651399

Update README.md

view details

push time in 4 days

push eventdjKooks/piggi

kwangin

commit sha d6936f6a1a24dfb4708b32ad84127ce2888128d5

Update readme

view details

push time in 4 days

startedurfave/cli

started time in 4 days

fork djKooks/promptui

Interactive prompt for command-line applications

https://www.manifold.co

fork in 4 days

push eventdjKooks/piggi

djKooks

commit sha 9dd3b905787a92b3d5416aabb74ccfc3e3d127bd

Refactor codes

view details

push time in 5 days

push eventdjKooks/piggi

Kwang-in (Dennis) Jung

commit sha 2647a6007b92c120b75188179d6436b2a0eed424

Update README.md Fix project name

view details

push time in 5 days

push eventdjKooks/djkooks.github.com

Kwang-in (Dennis) Jung

commit sha c868c9feb8f45ee0bcb60a3b6e5da14370e8e15b

Update 2019-02-28-things-of-do-dont.md

view details

push time in 5 days

startedtakecore/github-activity-reporter

started time in 5 days

created tagdjKooks/tucson

tagv0.3.1

JSON key/values transformer, to make it fit on your project

created time in 6 days

release djKooks/tucson

v0.3.1

released time in 6 days

push eventdjKooks/piggu

djKooks

commit sha ad83529e82b443b88180f45f7418693dce7440a2

Fix query to get opened issue only

view details

djKooks

commit sha 596bdf8b59898994a8ca2c946f7818a3659a3e69

Add function for PR

view details

djKooks

commit sha 5684799c71cf20220e16848cf6a4800b96535cf5

Get user information

view details

push time in 6 days

push eventdjKooks/piggu

djKooks

commit sha e306a0fdce16d0b72960cce2b7203fc51b72f1a0

Change alignment for request

view details

djKooks

commit sha 81bdb8ab25e32d375a1291281723f62571c83bee

Update prompter for BodyText

view details

djKooks

commit sha 0ff52a60ac237fcfe1b23087e7a03917f6947a7d

Add updated date information

view details

push time in 6 days

startedjunsooo/linux-insides-ko

started time in 6 days

push eventdjKooks/piggu

Kwang-in (Dennis) Jung

commit sha 2a0d0f79d4311098ce1a351ad53e92e24e827655

Create README.md

view details

push time in 6 days

startedmanifoldco/promptui

started time in 6 days

push eventdjKooks/gitti

djKooks

commit sha 3e2a3c45a94d870829c0e275a4bdcccd7190ee5c

Update API

view details

djKooks

commit sha 77aed939e58605bce2959f0222b263673ae7a580

Add prompter for visualize

view details

djKooks

commit sha 9d7df1af9d9cd95c4437dbade2dba268c0794735

Add issue function

view details

djKooks

commit sha 7d30f969e306ef85e5b2441c5f0b009e86775a92

Update issue prompter

view details

djKooks

commit sha 7db1987e3b2701b02c254f733925d47eabf192f9

Update query for issue

view details

push time in 7 days

issue openeddjKooks/jopt

Data storage / distribution handler

created time in 7 days

issue openeddjKooks/jopt

Test with ML/DL modules

  • [ ] SparkML
  • [ ] Mahout
  • [ ] DL4J

...and more

created time in 7 days

issue openeddjKooks/jopt

Clear interface

created time in 7 days

starteddotnet/machinelearning

started time in 7 days

push eventdjKooks/gitti

djKooks

commit sha 77fee0a89810866709ce13239964c71122bab3c1

Wrap-up common lines

view details

djKooks

commit sha 024f589a1d8b95f744daea174fdcc5fb24ac1729

Add formatter for data display

view details

push time in 8 days

push eventdjKooks/jopt

Kwang-in (Dennis) Jung

commit sha 824b2a0eba59aba5c5629ff9b461fd5046e9912b

Create README.md

view details

push time in 8 days

create barnchdjKooks/gitti

branch : master

created branch time in 8 days

created repositorydjKooks/gitti

created time in 8 days

push eventdjKooks/jopt

djKooks

commit sha 1eb5ae5b0e84e24306196a4f7cf319caa28670ee

Update test

view details

push time in 8 days

push eventdjKooks/gnoter

djKooks

commit sha 6eb60db1b7620caf799328facf505038d0c0e80d

Rename project

view details

push time in 9 days

push eventdjKooks/godmin

kwangin

commit sha 5a116c991ae76e493ec1f02bc7f926cfbee3c4f5

Remove duplications

view details

push time in 10 days

push eventdjKooks/jopt

kwangin

commit sha 385ad3193543dbfd2724d7ad7353dddcf3ef1d46

Add random data generator

view details

kwangin

commit sha fc9ac3de4b0c9866b5e0d70801f6629b99dc7c65

Use interface for function runner

view details

push time in 11 days

push eventdjKooks/jopt

djKooks

commit sha d3a6357cf40a1826fc8d7b33d752eec1a365aaa4

Add default method

view details

push time in 14 days

push eventdjKooks/djkooks.github.com

kwangin

commit sha 8e951d9a21d87b41fd67d214fd342b653416a59e

Fix title

view details

push time in 17 days

push eventdjKooks/djkooks.github.com

kwangin

commit sha 879fb8aa53c357d7c3604b6af1aac1edef597986

Fix post

view details

push time in 17 days

push eventdjKooks/djkooks.github.com

kwangin

commit sha e50ac3a6bc582c9926f21adad37bc0486526e85d

New post

view details

push time in 17 days

push eventdjKooks/djkooks.github.com

djKooks

commit sha ff2ac596db7d405d485d899abf2d0b3a36baccbe

Fix wrong link

view details

push time in 19 days

push eventdjKooks/djkooks.github.com

djKooks

commit sha 0e0863f1e71f63431df13ffd2df837785837c87e

New post

view details

djKooks

commit sha 31d82cc2531511335f12154dc703234e1d355360

Update about

view details

push time in 19 days

push eventdjKooks/jopt

djKooks

commit sha 38e39df37c21e98ad19ddd2a1099e680c67758eb

Remove example in repository

view details

push time in 23 days

push eventdjKooks/jopt

kwangin

commit sha 934367d848f047e89adc00aeb4092d9b46ec92cc

Update gitignore

view details

push time in 25 days

create barnchdjKooks/jopt

branch : master

created branch time in a month

created repositorydjKooks/jopt

created time in a month

startedsile/plumtuna

started time in a month

push eventdjKooks/godmin

djKooks

commit sha 972a708623730cca125f01c77a0c09be30b1b776

Remove execution file

view details

djKooks

commit sha 101c259350cf46276f5d5258c7ec20e40250ca30

Change router to gorilla-mux

view details

djKooks

commit sha f09fce25a10914c8cb1e0d40e65ea5ff1de2a7bc

Make interface for registering admin user

view details

push time in a month

startedmlflow/mlflow

started time in a month

PublicEvent

push eventdjKooks/tokio-review

djKooks

commit sha 670ac5c1808393f9ee48abc7c6be9889203b9e6b

restart project

view details

push time in a month

issue closeddenoland/deno

Install directly after ./tools/build.py

Is there a way to install with objects generated after ./tools/build.py completed? I've installed deno with installer, and want to work with newest version, but cannot find installer from source code.

Thanks.

closed time in a month

djKooks

issue commentdenoland/deno

Install directly after ./tools/build.py

@bartlomieju you're right. Thanks for following up.

djKooks

comment created time in a month

issue openeddenoland/deno

Build process requires openssl@1.1

Hello,

This is an issue while debugging on #1399 , working on ./tools/build.py:

...
dyld: Library not loaded: /usr/local/opt/openssl@1.1/lib/libssl.1.1.dylib
  Referenced from: /Users/jung/workspace/etc/deno/prebuilt/mac/sccache
  Reason: image not found

Current build process forces to use openssl 1.1 version, and I couldn't figure out why. I think there should be a guide about installing openssl v1.1 if deno must use this version.

Thanks.

created time in a month

push eventdjKooks/blueoil

lm_konda

commit sha ec2ab43f0798522199c580830ce87b9ff1211956

fix tests

view details

lm_konda

commit sha 70313da8f23cb950f8f0f2a73e905b11830a9980

add test for optimizer selector

view details

lm_konda

commit sha a7eacb7ab89e805ac11b79335a2b0391a251c993

add interface for optimizer selection

view details

lm_konda

commit sha dcf7b0e22003bbda58ab44638d5e3477f860f969

reflect optimizer selection

view details

lm_konda

commit sha 35e3b791b9b77a907efaa6b058c6426494241f6a

modify test (option commnet)

view details

lm_konda

commit sha 8323376029a3fa81b09158bba151ad6590ae6ae3

modify template (option comment)

view details

lm-konda

commit sha 6ec26279d4149874a28c8633992e4070bacd0384

Merge branch 'master' into optimizer_selector

view details

lm_konda

commit sha 07fce6d604f9c318c04228f3c2f5d8288de355fd

fix unit test

view details

konda

commit sha 8d3ac11d5dda907f5f46b0a8374346dfbadabb0f

modify doc for optimizer selection

view details

lm-konda

commit sha 02703ed5c3252d5b2a8547396975c35718aa7e41

Merge branch 'master' into optimizer_selector

view details

konda

commit sha 401530d93e2b6853c5189087351fb6f94ee4a8eb

fix unit test

view details

Takuya Wakisaka

commit sha 3dadb8b2ec4671faaefc1ae184d2554840d798f7

Merge branch 'master' into optimizer_selector

view details

lm_konda

commit sha dcf7f6be0ebb4b532d9aaad418a92885a7529a48

fix bug (momentum param is not always applicable.)

view details

konda

commit sha 328402d21bf39062ac575d77a6d411cdd492e19f

add Adadelta Optimizer

view details

lm_konda

commit sha b950be6f8bdda4e837479b64b880c701104b4917

support AdadeltaOptimizer

view details

lm_konda

commit sha 5e81b38df43bbb804dea5f689e27c56a92bf8a88

support AdagradOptimizer

view details

konda

commit sha 7eebda5b62c1664b33e019371bc50bbcc79a9804

add optimizers and fixed

view details

konda

commit sha 71bb7c3d293fe5357d5d688af0f1b1228ce7ad25

merge

view details

lm_konda

commit sha 945fcc54a059958e5094a1447c9228e908439db7

support ProximalGradientDescentOptimizer

view details

lm_konda

commit sha 25c2775fcafbc0fd0e31dfb041b784c4867ff4ab

support RMSPropOptimizer

view details

push time in a month

issue commentdenoland/deno

Build failure: no such package

@bartlomieju I just tested with master branch in MacOS 10.14.

There were some problem in ./tools/build.py:

...
dyld: Library not loaded: /usr/local/opt/openssl@1.1/lib/libssl.1.1.dylib
  Referenced from: /Users/jung/workspace/etc/deno/prebuilt/mac/sccache
  Reason: image not found

I already installed openssl, but it is trying to find openssl@1.1. I tried again after brew install openssl@1.1, build works fine.

I think there should be a guide about installing openssl v1.1 if deno must use this version.

Thanks.

djKooks

comment created time in a month

issue closedexonum/exonum

Build failure

<!-- Feel free to describe your feature request or issue in any appropriate form. For an issue please specify your platform, Rust and Exonum versions. -->

Hello~ I'm a beginner in this project. I just faced an error while build:

  Compiling actix v0.7.9
   Compiling snow v0.4.2
   Compiling exonum_sodiumoxide v0.0.20
error: failed to run custom build command for `exonum v0.10.2 (/Users/kwangin/workspace/exonum/exonum)`
process didn't exit successfully: `/Users/kwangin/workspace/exonum/target/debug/build/exonum-a38683bcef37b8fd/build-script-build` (exit code: 101)
--- stdout
cargo:protos=/Users/kwangin/workspace/exonum/exonum/src/proto/schema/exonum

--- stderr
thread 'main' panicked at 'protoc: Custom { kind: NotFound, error: StringError("failed to spawn `\"protoc\" \"--version\"`: No such file or directory (os error 2)") }', libcore/result.rs:1009:5
...

Is there somebody know about this?

My env:

MacOS: 10.14
Rust: 1.31

closed time in a month

djKooks

issue commentexonum/exonum

Build failure

@vitvakatu thanks! Official docs didn't comment about protobuf(seems updated in newest version), so I missed it.

djKooks

comment created time in a month

issue openedexonum/exonum

Build failure

<!-- Feel free to describe your feature request or issue in any appropriate form. For an issue please specify your platform, Rust and Exonum versions. -->

Hello~ I'm a beginner in this project. I just faced an error while build:

  Compiling actix v0.7.9
   Compiling snow v0.4.2
   Compiling exonum_sodiumoxide v0.0.20
error: failed to run custom build command for `exonum v0.10.2 (/Users/kwangin/workspace/exonum/exonum)`
process didn't exit successfully: `/Users/kwangin/workspace/exonum/target/debug/build/exonum-a38683bcef37b8fd/build-script-build` (exit code: 101)
--- stdout
cargo:protos=/Users/kwangin/workspace/exonum/exonum/src/proto/schema/exonum

--- stderr
thread 'main' panicked at 'protoc: Custom { kind: NotFound, error: StringError("failed to spawn `\"protoc\" \"--version\"`: No such file or directory (os error 2)") }', libcore/result.rs:1009:5
...

Is there somebody know about this?

My env:

MacOS: 10.14
Rust: 1.31

created time in a month

fork djKooks/exonum

An extensible open-source framework for creating private/permissioned blockchain applications

https://exonum.com

fork in a month

startedtendermint/rust-abci

started time in a month

push eventdjKooks/djkooks.github.com

kwangin

commit sha 3e78213a29ad8c9a69072832e3dbab05a7f10577

Update profile

view details

push time in a month

startedmaidsafe/safe_client_libs

started time in a month

push eventdjKooks/djkooks.github.com

djKooks

commit sha 4869b2c58c299751d8c556cbb7d940b62d34635c

Fix wrong typo

view details

push time in a month

push eventdjKooks/djkooks.github.com

djKooks

commit sha 4d8796e187ef665ef68fc007f9cb46103760fcfb

Update drafts

view details

djKooks

commit sha a78d8509e838f58cab5d91cbc5b1569e4fcc7c12

Update post

view details

djKooks

commit sha 6bc2604589f465452d5e5a07469ee3b2ca1b791e

Add new post

view details

push time in a month

delete branch djKooks/blueoil

delete branch : fix-default-path

delete time in a month

issue openedgo-oauth2/oauth2

How do you think about function which offers id_token?

Hello How do you think about implementing function which offers id_token, in OpenID-connect specification(https://auth0.com/docs/tokens/id-token)? I know this could not be fit to this project, because this is out of spec in OAuth2. But when I was implementing authentication server based on this module, I felt this could be useful.

Thanks.

created time in a month

issue commentterafoundation/wallet

Is this project a scam?

Yeah... I replied on mail, and said that mail address cannot be found...

mlasy

comment created time in a month

PR opened blue-oil/blueoil

Fix non-existing path

<!--- 👉👉👉 Provide a general summary of your changes. 👈👈👈 --> It has been requested in previous lmnet project, and moved on to blueoil.(https://github.com/LeapMind/lmnet/pull/269) Fix default config file path which is not existing anymore.

Motivation and Context

<!--- 💭💡💭 Why is this change required? What problem does it solve? 💭💡💭 --> Fix error when executing train.py without defining config file.

How has this been tested?

<!--- 🙆👌🙆 Please describe in detail how you tested your changes. 🙆👌🙆 --> <!--- Include details of your testing environment, details of your manual tests, snippet code or commands of your manual tests, table of experiments results metrics, tests ran to see how your change affects other areas of the code, etc. --> <!--- If you have experiments report documents please link to here. -->

Screenshots (if appropriate):

Types of changes

<!--- 🏁🎌🏁 What types of changes does your code introduce? Put an x in all the boxes that apply: 🏁🎌🏁 -->

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature / Optimization (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
+1 -1

0 comment

1 changed file

pr created time in a month

create barnchdjKooks/blueoil

branch : fix-default-path

created branch time in a month

issue commentterafoundation/wallet

Is this project a scam?

I also think it is better to remove executable files in repos. Seems it needs some arrangement...

mlasy

comment created time in a month

fork djKooks/blueoil

Bring Deep Learning to small devices

https://blue-oil.org

fork in a month

startedterafoundation/wallet

started time in a month

startededwardyoon/heimdallr

started time in 2 months

starteddeviantony/docker-elk

started time in 2 months

startedpfnet/optuna

started time in 2 months

startedexonum/exonum

started time in 2 months

pull request commentpaypal/gimel

[WIP][#6] Update code coverage for kafka

Sorry, I've been in busy situation, so cannot focused on this. Sorry for this. I'll re-open if I have time again, but before that, I'll close this one.

djKooks

comment created time in 2 months

PR closed paypal/gimel

[WIP][#6] Update code coverage for kafka

Make sure you have checked all steps below.

GitHub Issue

Fixes #6

Checklist:

<!--- Go over all the following points. Check boxes that apply to this pull request -->

  • [ ] This pull request updates the documentation
  • [ ] This pull request changes library dependencies
  • [ ] Title of the PR is of format (example) : [#25][Github] Add Pull Request Template

What is the purpose of this pull request?

This PR update improve code coverage for kafka connector

Commit Guidelines

  • [ ] My commits all reference GH issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"
+40 -1

1 comment

1 changed file

djKooks

pr closed time in 2 months

startedqubvel/classification_models

started time in 2 months

startedDenisKolodin/yew

started time in 2 months

issue commentqor/admin

No `AdminConfig` in dep package

I checked package inside, and it does not have AdminConfig in admin.go, different with master branch version:

type Admin struct {
	Config           *qor.Config
	SiteName         string
	I18n             I18n
	menus            []*Menu
	resources        []*Resource
	searchResources  []*Resource
	auth             Auth
	router           *Router
	funcMaps         template.FuncMap
	metaConfigorMaps map[string]func(*Meta)
}

I changed package to master version, but it caused other problem as:

delta-auth/vendor/github.com/qor/qor/resource
vendor/github.com/qor/qor/resource/meta.go:130:38: cannot use roles (type []interface {}) as type []string in argument to meta.Permission.HasPermission
vendor/github.com/qor/qor/resource/resource.go:164:37: cannot use roles (type []interface {}) as type []string in argument to res.Permission.HasPermission

How can I fix it?

djKooks

comment created time in 2 months

issue openedqor/admin

No `AdminConfig` in dep package

Hello, I'm trying to use admin via dep package manager, but it causes error like:

./main.go:179:22: undefined: admin.AdminConfig

My dep package are:

...
[[constraint]]
  name = "github.com/jinzhu/gorm"
  version = "1.9.2"

[[constraint]]
  name = "github.com/qor/qor"
  version = "1.0.0"
...

and error is being caused when using admin.AdminConfig like below:

	db, err := gorm.Open("mysql", "root:root@tcp(127.0.0.1:3306)/delta_auth?charset=utf8&parseTime=true")
	if err != nil {
		panic(err)
	}

	defer db.Close()

	db.AutoMigrate(&Userinfo{})
	Admin := admin.New(&admin.AdminConfig{DB: db})

created time in 2 months

startedcharlax/professional-programming

started time in 2 months

Pull request review commentdenoland/deno_std

Add oak framework

+# oak

@kitsonk @sh7dm oh, actually you are right. I really agree the name oak is more better than middleware. I just mean that because name of other modules inside deno_std are datetime, http, io and these are easy to understand only with its name. It doesn't need to be intuitive if it is separate framework, but when it becomes standard module, it can be different story.

kitsonk

comment created time in 2 months

issue closedpfnet/optuna

Visualization not working

Hello. I faced on error when:

import optuna

study = optuna.create_study()
...
optuna.visualization.plot_intermediate_values(study)

this shows:

AttributeError                            Traceback (most recent call last)
<ipython-input-11-04cb7fde5fca> in <module>
----> 1 optuna.visualization.plot_intermediate_values(study)

AttributeError: module 'optuna' has no attribute 'visualization'

Do I have to do something for visualization?

closed time in 2 months

djKooks

issue commentpfnet/optuna

Visualization not working

@g-votte okay thanks! I'm testing with pip pkg manager, so it was the reason.

djKooks

comment created time in 2 months

issue openedpfnet/optuna

Visualization not working

Hello. I faced on error when:

import optuna

study = optuna.create_study()
...
optuna.visualization.plot_intermediate_values(study)

this shows:

AttributeError                            Traceback (most recent call last)
<ipython-input-11-04cb7fde5fca> in <module>
----> 1 optuna.visualization.plot_intermediate_values(study)

AttributeError: module 'optuna' has no attribute 'visualization'

Do I have to do something for visualization?

created time in 2 months

Pull request review commentdenoland/deno_std

Add oak framework

+# oak

@kitsonk Seems very good! But name oak seems not intuitive so hard to understand...how about name middleware or else?

kitsonk

comment created time in 2 months

startedPeARSearch/PeARS-orchard

started time in 2 months

issue closedgo-oauth2/oauth2

Server with multiple client

I'm trying to allow multiple client for single auth server, so implemented as:

        ...
        firstClientStore := store.NewClientStore()
	firstClientStore.Set("first-client", &models.Client{
		ID:     "first-client",
		Secret: "first-client-secret",
		Domain: "http://localhost:3333",
	})

        secondClientStore := store.NewClientStore()
	secondClientStore.Set("second-client", &models.Client{
		ID:     "second-client",
		Secret: "second-client-secret",
		Domain: "http://localhost:4444",
	})

	manager.MapClientStorage(firstClientStore)
	manager.MapClientStorage(secondClientStore)

        srv := server.NewServer(server.NewConfig(), manager)
        ...

...but this seems not working well. It refuses the request. How can I make it?

closed time in 2 months

djKooks

issue commentgo-oauth2/oauth2

Server with multiple client

@LyricTian thanks!

djKooks

comment created time in 2 months

issue openedgo-oauth2/oauth2

Server with multiple client

I'm trying to allow multiple client for single auth server, so implemented as:

        firstClientStore := store.NewClientStore()
	firstClientStore.Set("first-client", &models.Client{
		ID:     "first-client",
		Secret: "first-client-secret",
		Domain: "http://localhost:3333",
	})

        secondClientStore := store.NewClientStore()
	secondClientStore.Set("second-client", &models.Client{
		ID:     "second-client",
		Secret: "second-client-secret",
		Domain: "http://localhost:4444",
	})

	manager.MapClientStorage(firstClientStore)
	manager.MapClientStorage(secondClientStore)

        srv := server.NewServer(server.NewConfig(), manager)

...but this seems not working well. It refuses the request. How can I make it?

created time in 2 months

delete branch djKooks/optuna

delete branch : sk-warning

delete time in 2 months

pull request commentpfnet/optuna

Fix warning issue on recent sklearn version

@sile thanks for guide! I just updated it, so please look on.

djKooks

comment created time in 2 months

push eventdjKooks/optuna

djKooks

commit sha b51b7c34e54c7e7b62a947256d4b51a51a0299f6

fix ci failure

view details

push time in 2 months

Pull request review commentblue-oil/blueoil

Add Blueoil CLI

 def image_size_filter(raw):     return image_size  -def save_config(blueoil_config):-    env = Environment(loader=FileSystemLoader('./blueoil/templates', encoding='utf8'))+def save_config(blueoil_config, output=None):+    env = Environment(loader=FileSystemLoader(TEMPLATE_DIR, encoding='utf8'))     tpl = env.get_template('blueoil-config.tpl.yml')      applied = tpl.render(blueoil_config)-    config_file = blueoil_config['model_name'] + ".yml"-    with open(config_file, 'w') as fp:++    if not output:

How about checking format of output here, instead of just checking this is None or not? Such as:

# this is sudo code...may cannot work
if not output or output.endswith('.yml') == False:
odoku

comment created time in 2 months

Pull request review commentpfnet/optuna

Fix warning issue on recent sklearn version

 def __call__(self, trial):             rf_max_depth = int(trial.suggest_loguniform('rf_max_depth', 2, 32))             classifier_obj = sklearn.ensemble.RandomForestClassifier(max_depth=rf_max_depth) -        score = sklearn.model_selection.cross_val_score(classifier_obj, x, y, n_jobs=-1)+        cv = sklearn.model_selection.ShuffleSplit()+        score = sklearn.model_selection.cross_val_score(classifier_obj, x, y, n_jobs=-1, cv=cv)

@sile thanks! Just updated.

djKooks

comment created time in 2 months

push eventdjKooks/optuna

djKooks

commit sha 0a0ebaf6741e0eaf312f6db232473ff42a7599e8

define cv to specific value

view details

push time in 2 months

Pull request review commentblue-oil/blueoil

Dockerize Blueoil

 def image_size_filter(raw):     return image_size  -def save_config(blueoil_config):-    env = Environment(loader=FileSystemLoader('./blueoil/templates', encoding='utf8'))+def save_config(blueoil_config, output=None):+    env = Environment(loader=FileSystemLoader(TEMPLATE_DIR, encoding='utf8'))     tpl = env.get_template('blueoil-config.tpl.yml')      applied = tpl.render(blueoil_config)-    config_file = blueoil_config['model_name'] + ".yml"-    with open(config_file, 'w') as fp:++    if not output:

How about checking format of output here, instead of just checking this is None or not? Such as:

# this is sudo code...may cannot work
if not output or output.endswith('.yml') == False:
odoku

comment created time in 2 months

PR opened pfnet/optuna

Fix warning issue on recent sklearn version

Hello. This is update to remove warnings I found while testing example. It is related with issue here.

Please look on. Thanks.

+4 -2

0 comment

2 changed files

pr created time in 2 months

create barnchdjKooks/optuna

branch : sk-warning

created branch time in 2 months

more