profile
viewpoint
Dmitry Murzin dima74 MIPT University Russia, Moscow

dima74/intellij-indent-rainbow 21

Extension which shows indentation with a faint rainbow colored background to make them more readable

dima74/AncientEmpires 10

It's a fantasy turn-based tactics game for android

dima74/cpp-useful-functions-for-debug-print 3

Few easy-to-use debug print functions with nice colored output

clumpytuna/vk-hack-yellow-dc 1

The voice assistant for the Pushkin State Museum of Fine Arts

dima74/factorio-mod-example 1

Example repository for testing https://github.com/dima74/factorio-mods-localization

dima74/factorio-mods-localization 1

Translate your Factorio mod easily with power of Crowdin

dima74/Hakaton-Flask 1

Движок сайта для хакатона 19-20.11.2016 https://vk.com/hack_mipt

dima74/MIPT-AKOS 1

МФТИ ФИВТ, АКОС, 2 семестр, 2016

dima74/MIPT-FormalLanguages 1

МФТИ ФИВТ, Формальные языки, 3 семестр, 2016

dima74/phystech-print 1

Сервис печати для студентов МФТИ

push eventdima74/compilers-2020

Dmitry Murzin

commit sha a128c74faf8e3c20fe48dc1f539ebf5ca35cda5f

Task1: evalExpr & eval

view details

Dmitry Murzin

commit sha 29160b5ae4e0c0c82cbbe85294d3a2a81e31147d

Task1: SM

view details

push time in 9 hours

push eventintellij-rust/intellij-rust

Dmitry Murzin

commit sha df35d65958aa19d8db32880ce18ec13b2e818cbb

PERF: Store hash of RsMacro and RsMacroCall in stubs

view details

Dmitry Murzin

commit sha faedceb9e8608dcbb372857ca1371ea869ab961a

STUB: Add helper methods for new resolve

view details

push time in 2 days

push eventdima74/ifmo-2020-dependent-types

Dmitry Murzin

commit sha 246bb047b2b492676e6407a932e94925dd18dad7

HW04 (task 1,2,5,7,9)

view details

push time in 3 days

push eventdima74/ifmo-2020-dependent-types

Valery Isaev

commit sha 693c9678b73dc7eb51dbc0e231264acda4715d5f

Add lect04

view details

Dmitry Murzin

commit sha 2a8ce2c0e8fcc43f53e961ee02de45f321596a63

Initial commit

view details

Dmitry Murzin

commit sha 78a7f859d56ad070adf184f36e197c41b9398085

HW 01

view details

Dmitry Murzin

commit sha 0bbb6d6a5c7b08f38d7500517c7fb59909c25afb

HW 02 (first 7 tasks)

view details

Dmitry Murzin

commit sha 2950df54085c247979abdfc1fd328d0d5a508db3

HW 02 (task 8)

view details

Dmitry Murzin

commit sha de389c349baec1ae4edc34efcfd856e3242fa6d5

HW 03 (first 9 tasks)

view details

Dmitry Murzin

commit sha bf0553eb596887c08f2f2d2914b2863845345a86

HW 03 (task 11-12 and fix task 8)

view details

Dmitry Murzin

commit sha 65537e004b9daeab887688cd38a9058412cf5f86

HW04 (task 3,4,6,8,10-15)

view details

push time in 3 days

PR opened intellij-rust/intellij-rust

STUB: Add helper methods for new resolve

Added helper methods for stubs which will be used in new resolve.

Also:

  • Added hasColonColon flag to RsUseSpeckStub to distinguish use {aaa, bbb}; and use ::{aaa, bbb};
  • Added bodyHash to macro and macro call stubs as an optimization
+232 -44

0 comment

10 changed files

pr created time in 3 days

create barnchintellij-rust/intellij-rust

branch : diralik/resolve2-stubs

created branch time in 3 days

push eventdima74/intellij-rust

Dmitry Murzin

commit sha 89d3e247c07e10f285aaa4309e238ad2ada4646b

New resolve

view details

Dmitry Murzin

commit sha 2c44d17a73a402d5bffc9e0c58bb033829fb4a73

Refactoring

view details

Dmitry Murzin

commit sha 0cff37da96db2f1aa755699da49597d585df66a8

Refactoring

view details

Dmitry Murzin

commit sha 4c275ee2e2fd5748188b840760c1275562839d53

Refactoring

view details

Dmitry Murzin

commit sha 30dfe9e88adf2417d2d53fae6d0c480569701ccb

Refactoring

view details

push time in 5 days

push eventintellij-rust/intellij-rust

Dmitry Murzin

commit sha e39a9b12fb20ca87959a8d7717889cffd044b4a6

Add compile only dependency on kotlin stdlib

view details

push time in 5 days

pull request commentintellij-rust/intellij-rust

Add compile only dependency on kotlin stdlib

Not sure why regressions workflow fails - I restarted it manually and it succeeds

dima74

comment created time in 5 days

create barnchdima74/intellij-rust

branch : diralik/kotlin-stblib-sources

created branch time in 5 days

PR opened intellij-rust/intellij-rust

Add compile only dependency on kotlin stdlib

It allows viewing kotlin stdlib source code with comments.

It was already added before, and then removed because it caused problems when running tests using JPS (instead of Gradle). I don't find any problems now when using JPS with this compile only dependency, so let's try add it again.

+1 -0

0 comment

1 changed file

pr created time in 5 days

push eventintellij-rust/intellij-rust

Dmitry Murzin

commit sha 7876c2e655ee5335e06976e8425f4e05f2c8ca75

Add compile only dependency on kotlin stdlib

view details

push time in 5 days

push eventdima74/intellij-rust

Dmitry Murzin

commit sha c8a326950411434294134aeef70107dec67b888e

New resolve

view details

Dmitry Murzin

commit sha 833ea0936014e48913318ecfca2221f1fc5e5d01

Refactoring

view details

Dmitry Murzin

commit sha c9dc75007228ddcce67c8cef1f03bd760c7c6fc6

backup

view details

push time in 5 days

push eventdima74/intellij-rust

Dmitry Murzin

commit sha 0887b60f570f7e3bd375736e72aa3277279cd654

New resolve

view details

push time in 6 days

push eventdima74/intellij-rust

Dmitry Murzin

commit sha e21c02b7ac8fc5fe5aa734d4d030020736c64359

RES: Add name to RsResolveProcessor

view details

vlad20012

commit sha 8527c7c2fc405fd545bedb85505285dc245015ad

Fix "Incorrect CachedValue use" exception in RsFile

view details

Jakub Beránek

commit sha aa20878e31e67e67bdaa955bb8252819e2142193

FIX: render types with a fully qualified name when needed

view details

GitHub Action

commit sha 88241a709454bac92158c4ed2dae9fb5fdbd6096

INT: add support for generic types to UnElideLifetimesIntention

view details

bors[bot]

commit sha 876af4c9972dc9cdc4b81db542d08c052da31791

Merge #6127 6127: Fix "Incorrect CachedValue use" exception in RsFile r=Undin a=vlad20012 The bug was introduced in #5690 <details> <summary>Stacktrace</summary> ``` java.lang.Throwable: Incorrect CachedValue use: same CV with different captured context, this can cause unstable results and invalid PSI access. Field this$0 in class org.rust.lang.core.psi.RsFile$declarations$1 has non-equivalent values: FILE (org.rust.lang.core.psi.RsFile) and FILE (org.rust.lang.core.psi.RsFile) Either make `equals()` hold for these values, or avoid this dependency, e.g. by extracting CV provider into a static method. at com.intellij.openapi.diagnostic.Logger.error(Logger.java:143) at com.intellij.util.CachedValueStabilityChecker.complain(CachedValueStabilityChecker.java:163) at com.intellij.util.CachedValueStabilityChecker.checkFieldEquivalence(CachedValueStabilityChecker.java:130) at com.intellij.util.CachedValueStabilityChecker.checkFieldEquivalence(CachedValueStabilityChecker.java:126) at com.intellij.util.CachedValueStabilityChecker.checkProvidersEquivalent(CachedValueStabilityChecker.java:81) at com.intellij.util.CachedValuesManagerImpl.getCachedValue(CachedValuesManagerImpl.java:71) at com.intellij.psi.util.CachedValuesManager.getCachedValue(CachedValuesManager.java:150) at org.rust.lang.core.psi.RsFile.getDeclarations(RsFile.kt:205) at org.rust.lang.core.psi.RsFile.getDeclaration(RsFile.kt:190) ... ``` </details> bors r+ Co-authored-by: vlad20012 <beskvlad@gmail.com>

view details

bors[bot]

commit sha c461d4fb0c20e8ae728b387234511d7508262b5c

Merge #3829 3829: INT: add support for generic types to unelide lifetimes intention r=mchernyavsky a=Kobzol This PR generalizes the Unelide lifetimes intention to work with generic types. Fixes: https://github.com/intellij-rust/intellij-rust/issues/769 Co-authored-by: GitHub Action <action@github.com>

view details

bors[bot]

commit sha e9b9a320f5a90a1afaf3dfbc4929ef5461858b88

Merge #5456 5456: FIX: render types with a fully qualified name when needed r=mchernyavsky a=Kobzol This PR enhances `TypeRenderer` to render (fully) qualified names for types when needed. This is basically only needed when two types are displayed together to disambiguate them if their name is the same, but they are different types. Two instances of this scenario that I found is in the type mismatch diagnostic and in `ChangeReturnTypeFix`, so I changed both of them to use the qualified name type renderer in this PR. Fixes https://github.com/intellij-rust/intellij-rust/issues/3223, fixes https://github.com/intellij-rust/intellij-rust/issues/5452. Co-authored-by: Jakub Beránek <jakub.beranek@vsb.cz>

view details

Arseniy Pendryak

commit sha 82ba7adea8ad4efab3bb6b72b020a274eff4e207

#6124: move code related to match check into utils package

view details

Arseniy Pendryak

commit sha 7ad02017a4d4c748d8d28c87f1fce4173c19675d

CARGO: introduce CargoSyncTask Replace multiple calls of `org.rust.openapiext.AsyncTasksKt.runAsyncTask` with single inheritor of RsTask

view details

bors[bot]

commit sha a40e882b81791240334c966389ca21aad7882be2

Merge #6114 6114: CARGO: introduce CargoSyncTask r=vlad20012 a=Undin Replace multiple calls of `org.rust.openapiext.AsyncTasksKt.runAsyncTask` with single inheritor of RsTask Note, it's just an internal change and it shouldn't affect users Part of #6104 Co-authored-by: Arseniy Pendryak <a.pendryak@yandex.ru>

view details

Arseniy Pendryak

commit sha d100cd66a421c0a3f5534efe6ec2c9222cf85a6d

T: add cargo home to allowed roots

view details

Arseniy Pendryak

commit sha e8938e4d7201bfcba318490b053e17be863065ad

#6124: introduce AddRemainingArmsIntention and AddWildcardArmIntention These intention do the same as `AddRemainingArmsFix` and `AddWildcardArmFix` quick fixes of `RsNonExhaustiveMatchInspection` respectively. They are needed to provide the same actions inside `match` expression not only on `match` keyword

view details

Arseniy Pendryak

commit sha 075e371576ba9107bc3e3fdc417bebfc820d853e

#6124: check AddRemainingArmsIntention and AddWildcardArmIntention

view details

bors[bot]

commit sha a1269468456a77d4624b9ba9129236e50bddaea7

Merge #6133 6133: T: add cargo home to allowed roots r=Undin a=Undin Should fix timeout issue in #5444 Co-authored-by: Arseniy Pendryak <a.pendryak@yandex.ru>

view details

bors[bot]

commit sha b0047b0ac3996edf22d82ce1aae988fcf0be0082

Merge #6132 6132: INT: add remaining arms and add wildcard arm intentions r=vlad20012 a=Undin Restores functionality to add missing patterns in `match` expression inside match block that was removed in #5720. Previously, this feature was provided by `Fill match arms` intention. New intentions work exactly the same as `Add remaining patterns` and `Add _ pattern` but in different places. As a result, new intentions support more cases than old `Fill match arms` which supported only enums and only empty `match` expression Closes #6124 Co-authored-by: Arseniy Pendryak <a.pendryak@yandex.ru>

view details

GitHub Action

commit sha 30cb25ae26be90ec5978a67ca361ff2198729f17

Changelog

view details

mchernyavsky

commit sha 56671a8ac4592d8ad1d39ff28d2a4e3ec712f0bb

RUN: Ignore some messages in Build tool window

view details

mchernyavsky

commit sha 6a50b0472d8d5e0edf214a923728ebe00a06d8ef

T: Update Build tool window tests to 202

view details

bors[bot]

commit sha 1890b48aa3ed699f078e30a7a3e9307e621c98f9

Merge #6144 6144: T: Update Build tool window tests to 202 r=mchernyavsky a=Undin <!-- Hello and thank you for the pull request! We don't have any strict rules about pull requests, but you might check https://github.com/intellij-rust/intellij-rust/blob/master/CONTRIBUTING.md for some hints! Note that we need an electronic CLA for contributions: https://github.com/intellij-rust/intellij-rust/blob/master/CONTRIBUTING.md#cla After you sign the CLA, please add your name to https://github.com/intellij-rust/intellij-rust/blob/master/CONTRIBUTORS.txt :) --> Co-authored-by: mchernyavsky <chernyavsky.mikhail@gmail.com>

view details

bors[bot]

commit sha 7691e6cb0af9dfccfa9879088fc04cad0c0208b7

Merge #5955 5955: RES: Add name to RsResolveProcessor r=vlad20012 a=dima74 This will be used in new resolve to improve performance (instead of iterating all items in scope, only item with specified name will be processed). Potentially it can be used in other places, e.g. in [`processModDeclResolveVariants`](https://github.com/intellij-rust/intellij-rust/blob/e2d8902505475453db2ddc9629b3cd2ec9b68ee9/src/main/kotlin/org/rust/lang/core/resolve/NameResolution.kt#L226) Co-authored-by: Dmitry Murzin <diralik@yandex.ru>

view details

push time in 6 days

create barnchintellij-rust/intellij-rust

branch : diralik/kotlin-stblib-sources

created branch time in 6 days

push eventintellij-rust/intellij-rust

Dmitry Murzin

commit sha e21c02b7ac8fc5fe5aa734d4d030020736c64359

RES: Add name to RsResolveProcessor

view details

Arseniy Pendryak

commit sha 43e08a814fb3a96ab2ef62c1d1af5871ac6c3755

GRD: update 2020.2 dependencies

view details

bors[bot]

commit sha 79964ca39d36fced3858172fbfa13d446998dcf8

Merge #6123 6123: GRD: update 2020.2 dependencies r=Undin a=Undin Co-authored-by: Arseniy Pendryak <a.pendryak@yandex.ru>

view details

vlad20012

commit sha b22ea7e1e637903dcba8c238e5f241ba2f740818

Fix exception in the cargo toolwindow init Looks like `runAfterOpened` can run outside of EDT

view details

vlad20012

commit sha 5194d9aaa34c87cff68ff8b65f42366e5b1a3dfd

Fix exception `PsiElementBase.notNullChild` after variable inlining

view details

vlad20012

commit sha 7ab9113429e847e8e9f13011d5f5b741aa67dd4c

T: check that PSI matches re-parsed text after applying an action

view details

bors[bot]

commit sha 642706b101b1ba22254a1a065b64b123b517d04f

Merge #6125 6125: Fix exception in the cargo toolwindow init r=mchernyavsky a=vlad20012 Fix for #5999. Looks like `runAfterOpened` can run outside of EDT. <details> <summary>Stacktrace</summary> ``` Access is allowed from event dispatch thread with IW lock only. com.intellij.openapi.diagnostic.RuntimeExceptionWithAttachments: EventQueue.isDispatchThread()=false Toolkit.getEventQueue()=com.intellij.ide.IdeEventQueue@6d984235 Current thread: Thread[ApplicationImpl pooled thread 11,4,Idea Thread Group] 1697154984 SystemEventQueueThread: Thread[AWT-EventQueue-0,6,Idea Thread Group] 1894364389 at com.intellij.openapi.application.impl.ApplicationImpl.assertIsDispatchThread(ApplicationImpl.java:1061) at com.intellij.openapi.application.impl.ApplicationImpl.assertIsDispatchThread(ApplicationImpl.java:1043) at com.intellij.openapi.wm.impl.ToolWindowManagerImpl.doRegisterToolWindow(ToolWindowManagerImpl.kt:986) at com.intellij.openapi.wm.impl.ToolWindowManagerImpl.initToolWindow(ToolWindowManagerImpl.kt:530) at com.intellij.openapi.wm.impl.ToolWindowManagerImpl.initToolWindow(ToolWindowManagerImpl.kt:512) at org.rust.cargo.project.toolwindow.CargoToolWindow$Companion.initializeToolWindow(CargoToolWindow.kt:151) at org.rust.cargo.project.model.impl.CargoProjectsServiceImpl$$special$$inlined$with$lambda$3$1.run(CargoProjectImpl.kt:106) at com.intellij.ide.startup.impl.StartupManagerImpl.runActivity(StartupManagerImpl.java:436) at com.intellij.ide.startup.impl.StartupManagerImpl.runActivities(StartupManagerImpl.java:392) at com.intellij.ide.startup.impl.StartupManagerImpl.runPostStartupActivitiesRegisteredDynamically(StartupManagerImpl.java:334) at com.intellij.ide.startup.impl.StartupManagerImpl.runPostStartupActivities(StartupManagerImpl.java:247) at com.intellij.openapi.progress.impl.CoreProgressManager.lambda$runProcess$2(CoreProgressManager.java:170) at com.intellij.openapi.progress.impl.CoreProgressManager.registerIndicatorAndRun(CoreProgressManager.java:629) at com.intellij.openapi.progress.impl.CoreProgressManager.executeProcessUnderProgress(CoreProgressManager.java:581) at com.intellij.openapi.progress.impl.ProgressManagerImpl.executeProcessUnderProgress(ProgressManagerImpl.java:60) at com.intellij.openapi.progress.impl.CoreProgressManager.runProcess(CoreProgressManager.java:157) at com.intellij.openapi.progress.util.BackgroundTaskUtil.runUnderDisposeAwareIndicator(BackgroundTaskUtil.java:254) at com.intellij.ide.startup.impl.StartupManagerImpl.lambda$projectOpened$1(StartupManagerImpl.java:154) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.util.concurrent.Executors$PrivilegedThreadFactory$1$1.run(Executors.java:652) at java.util.concurrent.Executors$PrivilegedThreadFactory$1$1.run(Executors.java:649) at java.security.AccessController.doPrivileged(Native Method) at java.util.concurrent.Executors$PrivilegedThreadFactory$1.run(Executors.java:649) at java.lang.Thread.run(Thread.java:748) ``` </details> Co-authored-by: vlad20012 <beskvlad@gmail.com>

view details

bors[bot]

commit sha 961fb7d2b375da203825a010513e23f49dffded0

Merge #6126 6126: Fix exception `PsiElementBase.notNullChild` after variable inlining r=vlad20012 a=vlad20012 RsPath can't be replaced with `RsExpr`. Instead, parent `RsPathExpr` should be replaced. Typical stacktrace ends with this: ``` java.lang.Throwable: 10 parent=let b = 10; at com.intellij.openapi.diagnostic.Logger.error(Logger.java:143) at com.intellij.psi.impl.PsiElementBase.notNullChild(PsiElementBase.java:284) at org.rust.lang.core.psi.impl.RsPathExprImpl.getPath(RsPathExprImpl.java:43) ``` Also, I enhanced tests in order to catch such bugs in the future. c.c. @Kobzol Co-authored-by: vlad20012 <beskvlad@gmail.com>

view details

vlad20012

commit sha 8527c7c2fc405fd545bedb85505285dc245015ad

Fix "Incorrect CachedValue use" exception in RsFile

view details

Jakub Beránek

commit sha aa20878e31e67e67bdaa955bb8252819e2142193

FIX: render types with a fully qualified name when needed

view details

GitHub Action

commit sha 88241a709454bac92158c4ed2dae9fb5fdbd6096

INT: add support for generic types to UnElideLifetimesIntention

view details

bors[bot]

commit sha 876af4c9972dc9cdc4b81db542d08c052da31791

Merge #6127 6127: Fix "Incorrect CachedValue use" exception in RsFile r=Undin a=vlad20012 The bug was introduced in #5690 <details> <summary>Stacktrace</summary> ``` java.lang.Throwable: Incorrect CachedValue use: same CV with different captured context, this can cause unstable results and invalid PSI access. Field this$0 in class org.rust.lang.core.psi.RsFile$declarations$1 has non-equivalent values: FILE (org.rust.lang.core.psi.RsFile) and FILE (org.rust.lang.core.psi.RsFile) Either make `equals()` hold for these values, or avoid this dependency, e.g. by extracting CV provider into a static method. at com.intellij.openapi.diagnostic.Logger.error(Logger.java:143) at com.intellij.util.CachedValueStabilityChecker.complain(CachedValueStabilityChecker.java:163) at com.intellij.util.CachedValueStabilityChecker.checkFieldEquivalence(CachedValueStabilityChecker.java:130) at com.intellij.util.CachedValueStabilityChecker.checkFieldEquivalence(CachedValueStabilityChecker.java:126) at com.intellij.util.CachedValueStabilityChecker.checkProvidersEquivalent(CachedValueStabilityChecker.java:81) at com.intellij.util.CachedValuesManagerImpl.getCachedValue(CachedValuesManagerImpl.java:71) at com.intellij.psi.util.CachedValuesManager.getCachedValue(CachedValuesManager.java:150) at org.rust.lang.core.psi.RsFile.getDeclarations(RsFile.kt:205) at org.rust.lang.core.psi.RsFile.getDeclaration(RsFile.kt:190) ... ``` </details> bors r+ Co-authored-by: vlad20012 <beskvlad@gmail.com>

view details

bors[bot]

commit sha c461d4fb0c20e8ae728b387234511d7508262b5c

Merge #3829 3829: INT: add support for generic types to unelide lifetimes intention r=mchernyavsky a=Kobzol This PR generalizes the Unelide lifetimes intention to work with generic types. Fixes: https://github.com/intellij-rust/intellij-rust/issues/769 Co-authored-by: GitHub Action <action@github.com>

view details

bors[bot]

commit sha e9b9a320f5a90a1afaf3dfbc4929ef5461858b88

Merge #5456 5456: FIX: render types with a fully qualified name when needed r=mchernyavsky a=Kobzol This PR enhances `TypeRenderer` to render (fully) qualified names for types when needed. This is basically only needed when two types are displayed together to disambiguate them if their name is the same, but they are different types. Two instances of this scenario that I found is in the type mismatch diagnostic and in `ChangeReturnTypeFix`, so I changed both of them to use the qualified name type renderer in this PR. Fixes https://github.com/intellij-rust/intellij-rust/issues/3223, fixes https://github.com/intellij-rust/intellij-rust/issues/5452. Co-authored-by: Jakub Beránek <jakub.beranek@vsb.cz>

view details

Arseniy Pendryak

commit sha 82ba7adea8ad4efab3bb6b72b020a274eff4e207

#6124: move code related to match check into utils package

view details

Arseniy Pendryak

commit sha 7ad02017a4d4c748d8d28c87f1fce4173c19675d

CARGO: introduce CargoSyncTask Replace multiple calls of `org.rust.openapiext.AsyncTasksKt.runAsyncTask` with single inheritor of RsTask

view details

bors[bot]

commit sha a40e882b81791240334c966389ca21aad7882be2

Merge #6114 6114: CARGO: introduce CargoSyncTask r=vlad20012 a=Undin Replace multiple calls of `org.rust.openapiext.AsyncTasksKt.runAsyncTask` with single inheritor of RsTask Note, it's just an internal change and it shouldn't affect users Part of #6104 Co-authored-by: Arseniy Pendryak <a.pendryak@yandex.ru>

view details

Arseniy Pendryak

commit sha d100cd66a421c0a3f5534efe6ec2c9222cf85a6d

T: add cargo home to allowed roots

view details

Arseniy Pendryak

commit sha e8938e4d7201bfcba318490b053e17be863065ad

#6124: introduce AddRemainingArmsIntention and AddWildcardArmIntention These intention do the same as `AddRemainingArmsFix` and `AddWildcardArmFix` quick fixes of `RsNonExhaustiveMatchInspection` respectively. They are needed to provide the same actions inside `match` expression not only on `match` keyword

view details

Arseniy Pendryak

commit sha 075e371576ba9107bc3e3fdc417bebfc820d853e

#6124: check AddRemainingArmsIntention and AddWildcardArmIntention

view details

push time in 6 days

PR opened intellij-rust/intellij-rust.github.io

Improvements of changelog.py

Minor changelog.py improvements:

  • Don't generate empty section
  • Add requirements.txt file
+7 -4

0 comment

3 changed files

pr created time in 6 days

Pull request review commentintellij-rust/intellij-rust.github.io

Changelog 131

+---+layout: post+title: "IntelliJ Rust Changelog #131"+date: 2020-09-21 12:00:00 +0300+---+++## New Features++<!-- https://github.com/intellij-rust/intellij-rust/pull/6039 -->+* Provide intention to create a method from an unresolved method call (by [@Kobzol])++    {% include gif-img.html path="/assets/posts/changelog-131/create_method" w="364px" %}++<!-- https://github.com/intellij-rust/intellij-rust/pull/5928 -->+* Add initial parsing of the new [asm! macro](https://github.com/rust-lang/rfcs/blob/master/text/2873-inline-asm.md) syntax (by [@Kobzol])++<!-- https://github.com/intellij-rust/intellij-rust/pull/5720 -->+* Supersede `Fill match arms` intention with `Add remaining patterns` quick fix which supports empty `match` expressions now++    {% include gif-img.html path="/assets/posts/changelog-131/empty_match_add_remaining_patterns" w="350px" %}++<!-- https://github.com/intellij-rust/intellij-rust/pull/5369 -->+* Place methods with `&mut self` at the end of completion list for non-mutable variables++<!-- https://github.com/intellij-rust/intellij-rust/pull/5657 -->+* Handle name conflicts after renaming local variables (by [@Kobzol])++<!-- https://github.com/intellij-rust/intellij-rust/pull/5956 -->+* Add `dbgr` postfix completion (by [@mgrachev])++    {% include gif-img.html path="/assets/posts/changelog-131/dbgr" w="406px" %}++* Improvements of `Move` refactoring for top-level items (`Refactor | Move` or <kbd>F6</kbd>):+    <!-- https://github.com/intellij-rust/intellij-rust/pull/6010 -->+    * Make moved items public if needed++        {% include gif-img.html path="/assets/posts/changelog-131/move_make_items_public" w="373px" %}++    <!-- https://github.com/intellij-rust/intellij-rust/pull/6078 -->+    * Support finding visibility conflicts in more cases++<!-- https://github.com/intellij-rust/intellij-rust/pull/6057 -->+* Introduce a quick fix to add `..` to struct pattern that has missing fields (by [@t-kameyama])++    {% include gif-img.html path="/assets/posts/changelog-131/pat_rest" w="400px" %}++<!-- https://github.com/intellij-rust/intellij-rust/pull/5995 -->+* Rename "Cargo Command" run configuration to "Cargo"++## Fixes++<!-- https://github.com/intellij-rust/intellij-rust/pull/6075 -->+* Fix "File is not included in module tree" warnings for a project under a symlinked directory++<!-- https://github.com/intellij-rust/intellij-rust/pull/6033 -->+* Don't resolve macros from `std` with `no_std` attribute (by [@Kobzol])++<!-- https://github.com/intellij-rust/intellij-rust/pull/6041 -->+* Fix highlighting inside macro calls in some cases++<!-- https://github.com/intellij-rust/intellij-rust/pull/6049 -->+* Fix flattening nested `use` statements intention (by [@t-kameyama])++<!-- https://github.com/intellij-rust/intellij-rust/pull/6056 -->+* Fix benches flag in `cargo` command completion++<!-- https://github.com/intellij-rust/intellij-rust/pull/6102 -->+<!-- * INT: add missing title and fix typo in CreateFunctionIntention (by [@Kobzol]) -->

Thanks, I forgot about this

dima74

comment created time in 7 days

PullRequestReviewEvent

push eventintellij-rust/intellij-rust.github.io

Dmitry Murzin

commit sha b02bd6b8d9d2ad177476bb29e40d6e87b5ea44ce

Changelog 131

view details

push time in 7 days

Pull request review commentintellij-rust/intellij-rust.github.io

Changelog 131

+---+layout: post+title: "IntelliJ Rust Changelog #131"+date: 2020-09-21 12:00:00 +0300+---+++## New Features++<!-- https://github.com/intellij-rust/intellij-rust/pull/6039 -->+* Provide intention to create a method from an unresolved method call (by [@Kobzol])++    {% include gif-img.html path="/assets/posts/changelog-131/create_method" w="364px" %}++<!-- https://github.com/intellij-rust/intellij-rust/pull/5928 -->+* Add initial parsing of the new [asm! macro](https://github.com/rust-lang/rfcs/blob/master/text/2873-inline-asm.md) syntax (by [@Kobzol])++<!-- https://github.com/intellij-rust/intellij-rust/pull/5720 -->+* Supersede `Fill match arms` intention with `Add remaining patterns` quick fix which supports empty `match` expressions now++    {% include gif-img.html path="/assets/posts/changelog-131/empty_match_add_remaining_patterns" w="350px" %}++<!-- https://github.com/intellij-rust/intellij-rust/pull/5369 -->+* Place methods with `&mut self` at the end of completion list for non-mutable variables++<!-- https://github.com/intellij-rust/intellij-rust/pull/5657 -->+* Handle name conflicts after renaming local variables (by [@Kobzol])++<!-- https://github.com/intellij-rust/intellij-rust/pull/5956 -->+* Add `dbgr` postfix completion (by [@mgrachev])++    {% include gif-img.html path="/assets/posts/changelog-131/dbgr" w="406px" %}++* Improvements of `Move` refactoring for top-level items (`Refactor | Move` or <kbd>F6</kbd>):+    <!-- https://github.com/intellij-rust/intellij-rust/pull/6010 -->+    * Make moved items public if needed++        {% include gif-img.html path="/assets/posts/changelog-131/move_make_items_public" w="373px" %}++    <!-- https://github.com/intellij-rust/intellij-rust/pull/6078 -->+    * Support finding visibility conflicts in more cases++<!-- https://github.com/intellij-rust/intellij-rust/pull/6057 -->+* Introduce a quick fix to add `..` to struct pattern that has missing fields (by [@t-kameyama])++    {% include gif-img.html path="/assets/posts/changelog-131/pat_rest" w="400px" %}++<!-- https://github.com/intellij-rust/intellij-rust/pull/5995 -->+* Rename "Cargo Command" run configuration to "Cargo"++## Fixes++<!-- https://github.com/intellij-rust/intellij-rust/pull/6075 -->+* Fix "File is not included in module tree" warnings for a project under a symlinked directory++<!-- https://github.com/intellij-rust/intellij-rust/pull/6033 -->+* Don't resolve macros from `std` with `no_std` attribute (by [@Kobzol])++<!-- https://github.com/intellij-rust/intellij-rust/pull/6041 -->+* Fix highlighting inside macro calls in some cases++<!-- https://github.com/intellij-rust/intellij-rust/pull/6049 -->+* Fix flattening nested `use` statements intention (by [@t-kameyama])++<!-- https://github.com/intellij-rust/intellij-rust/pull/6056 -->+* Fix benches flag in `cargo` command completion++<!-- https://github.com/intellij-rust/intellij-rust/pull/6102 -->+<!-- * INT: add missing title and fix typo in CreateFunctionIntention (by [@Kobzol]) -->

I dropped commented items not included in the milestone, but this commit is included in the milestone

dima74

comment created time in 7 days

PullRequestReviewEvent

Pull request review commentintellij-rust/intellij-rust.github.io

Changelog 131

+---+layout: post+title: "IntelliJ Rust Changelog #131"+date: 2020-09-21 12:00:00 +0300+---+++## New Features++<!-- https://github.com/intellij-rust/intellij-rust/pull/6039 -->+* Provide intention to create a method from an unresolved method call (by [@Kobzol])++    {% include gif-img.html path="/assets/posts/changelog-131/create_method" w="364px" %}

Thanks, good idea

dima74

comment created time in 7 days

PullRequestReviewEvent

push eventintellij-rust/intellij-rust.github.io

Dmitry Murzin

commit sha a044d29ce7d05e8ca62e56c56da1f5adac10ebcd

Changelog 131

view details

push time in 7 days

PR closed intellij-rust/intellij-rust

PSI: Make RsForeignModItem implement RsItemsOwner

RsForeignModItem is naturally an item's owner, so it would be reasonable for it to implement RsItemsOwner interface

+4 -1

1 comment

2 changed files

dima74

pr closed time in 7 days

push eventintellij-rust/intellij-rust.github.io

Dmitry Murzin

commit sha 7a7abfc1b6808f166fdde700f34a5bc7a6256af3

Changelog 131

view details

push time in 7 days

issue commentdima74/factorio-mods-localization

locale parsing issues

Locale strings that contain the (valid) character ; (semi-colon) are improperly/incompletely parsed into the crowd-in project.

@kirazy this should be fixed now! Could you please check

kirazy

comment created time in 9 days

push eventdima74/factorio-mods-localization

Dmitry Murzin

commit sha 8410eec5a5e0e254ef5a5db30a0c615c70eb22cd

Escape strings containing quote or semicolon

view details

Dmitry Murzin

commit sha 0e9370dd08d91833261a484b34f3880685fd4ede

Add crowdin badge

view details

push time in 9 days

push eventdima74/factorio-mods-localization

Dmitry Murzin

commit sha 6fbb67d323641121060393c6d30a465d6c4391b2

Escape strings containing quote or semicolon

view details

Dmitry Murzin

commit sha 8216ddb03502066a6e4c6a84083dab3e1f858f8c

Add crowdin badge

view details

push time in 9 days

push eventdima74/factorio-mods-localization

Dmitry Murzin

commit sha f0c132fde470d8677784fc1f458ee1e276f769e1

Add crowdin badge

view details

push time in 9 days

push eventdima74/factorio-mods-localization

Dmitry Murzin

commit sha ec3feb5a730aded182074590b153577468ae7500

Remove not working dependencies badge

view details

push time in 9 days

push eventdima74/factorio-mods-localization

Dmitry Murzin

commit sha df0d49cc57c91fa391e121de5e696c194af6ed6b

Update README.md

view details

push time in 9 days

issue closeddima74/factorio-mods-localization

English string with quotes are imported incorrectly?

https://github.com/NoxyNixie/Noxys_Achievement_Helper/blob/master/locale/en/locale.cfg https://crowdin.com/translate/factorio-mods-localization/all/en-fr#29786

closed time in 9 days

dima74

issue commentdima74/factorio-mods-localization

English string with quotes are imported incorrectly?

Fixed in d8080e6199eed63bb3f0d0e6b88aba3a2106d6d6

dima74

comment created time in 9 days

push eventdima74/factorio-mods-localization

Dmitry Murzin

commit sha beaca9a388b158b954a694357df34dc1412bbcd9

Minor refactoring

view details

Dmitry Murzin

commit sha d8080e6199eed63bb3f0d0e6b88aba3a2106d6d6

Escape strings containing quote or semicolon

view details

push time in 9 days

push eventdima74/factorio-mods-localization

Dmitry Murzin

commit sha 27d7d98d53c397550dc1802d9c0ebc1a88871931

Escape strings containing quote or semicolon

view details

push time in 9 days

push eventdima74/factorio-mods-localization

Dmitry Murzin

commit sha 509bb549bb13dec869885b4dc3291f69ea05a1be

Escape strings containing quote or semicolon Signed-off-by: Dmitry Murzin <diralik@yandex.ru>

view details

Dmitry Murzin

commit sha ee7b05ecd49420adf88ffe41d489cedc4ac9df6d

backup

view details

push time in 9 days

push eventdima74/factorio-mod-example

push time in 9 days

push eventdima74/factorio-mod-example

Dmitry Murzin

commit sha 8a261672651c46d1e456cc15f3d03d9f09a2a6a4

backup

view details

push time in 9 days

push eventdima74/factorio-mod-example

Dmitry Murzin

commit sha 4bd9ced0ef9199f1056e44360267194a8c9e6189

backup

view details

push time in 9 days

push eventdima74/factorio-mods-localization

Dmitry Murzin

commit sha 49ee5fb5c7b354012804e089bb1fc0ff6fdfdd46

Minor refactoring

view details

Dmitry Murzin

commit sha 937712d72c6e7a7739f93e99d8f5940dc7b229a5

Escape strings containing quote or semicolon

view details

push time in 9 days

issue openedsoftprops/hubcaps

List installations for the authenticated app

<!-- Please search existing issues to avoid creating duplicates. -->

💡 Feature description

<!-- Describe the feature you'd like. --> It would be nice to add a method for listing all installations of the app: https://docs.github.com/en/rest/reference/apps#list-installations-for-the-authenticated-app

created time in 9 days

push eventdima74/factorio-mod-example

push time in 9 days

push eventdima74/factorio-mod-example

Dmitry Murzin

commit sha 624d1b9e2158c0ca2540723c66972d0233fb46ab

backup

view details

push time in 9 days

push eventdima74/factorio-mod-example

Dmitry Murzin

commit sha 8b42ce8712803809857f30c84f5dfffdbffb14b2

backup

view details

push time in 9 days

push eventdima74/factorio-mod-example

Dmitry Murzin

commit sha c8d7a4c53e6a4d945cd3ed94093bafe770d2b47c

backup

view details

push time in 9 days

push eventdima74/factorio-mod-example

Dmitry Murzin

commit sha e5a46704ca14e5f275a90f69cacc3908225e3610

backup

view details

push time in 9 days

push eventdima74/factorio-mod-example

Dmitry Murzin

commit sha ff6488e2ee55f58dcec05e41975f82a4590df8ed

backup

view details

push time in 9 days

push eventdima74/factorio-mod-example

Dmitry Murzin

commit sha 0ae802a1a603c7200a0cac064ba845b8e59760b7

backup

view details

push time in 9 days

push eventdima74/factorio-mod-example

Dmitry Murzin

commit sha 17d9b42dd98c4b21e73a8ed76548c3f308d05941

backup

view details

push time in 9 days

push eventdima74/factorio-mod-example

Dmitry Murzin

commit sha 42e20d3dced6a000e26079c86c1c168778fa96ed

backup

view details

push time in 9 days

push eventdima74/factorio-mod-example

Dmitry Murzin

commit sha 8fb215226667d06bb3fbebc39ac5cdc8fe2a9429

backup

view details

push time in 9 days

push eventdima74/ifmo-2020-dependent-types

Dmitry Murzin

commit sha e24c9499e47ba5c511c095ac04318efef60cb7a8

HW 03 (task 11-12 and fix task 8)

view details

push time in 9 days

push eventintellij-rust/intellij-rust.github.io

Dmitry Murzin

commit sha 324e0f08299eb4042729d350a31dae795537e5a1

Review fixes

view details

push time in 10 days

push eventdima74/ifmo-2020-dependent-types

Valery Isaev

commit sha fb58b445b83e6b257b3b66cc8433ebba4fbaa352

Add lect03

view details

Dmitry Murzin

commit sha 0744a7c2c9777f99ef806a67447da5e2a52a49e2

Initial commit

view details

Dmitry Murzin

commit sha 0eaa3a7e2d3f77245ccdfb2c012f96435d89365f

HW 01

view details

Dmitry Murzin

commit sha 3c570b7fd3bbb75912350551e60b63dc33602088

HW 02 (first 7 tasks)

view details

Dmitry Murzin

commit sha 42c66c14380dd42f49bc1054ff332f6b66622e71

HW 02 (task 8)

view details

Dmitry Murzin

commit sha fe2bbfd2837800e39ecbf84d9f29f17a65bbad6c

HW 03 (first 9 tasks)

view details

push time in 10 days

create barnchintellij-rust/intellij-rust.github.io

branch : diralik/changelog-131

created branch time in 10 days

issue openedphw/peek

Gifs are downscaled on HiDPI displays when height is more than 600

I have archlinux with kde plasma and display scale set to 2.

  • When recording gif with peek window size 800x598 (or any smaller height), the resulting gif size is correct (800x598)
  • When recording gif with peek window size 800x600 (or any higher height), the resulting gif size is downscaled (400x300)

created time in 10 days

issue openedintellij-rust/intellij-rust

False-negative "Match must be exhaustive" when matching pair of references

Environment

  • IntelliJ Rust plugin version: 0.3.132.3356-202-nightly
  • Rust toolchain version: 1.46.0 (04488afe3 2020-08-24) x86_64-unknown-linux-gnu
  • IDE name and version: IntelliJ IDEA 2020.2.1 Community Edition (IC-202.6948.69)
  • Operating system: Linux 5.8.8-arch1-1

Problem description

There is no inspection "Match must be exhaustive" on this code when using version 0.3.132.3356-202-nightly: image

There is inspection when using version 0.3.130.3337-202: image

Steps to reproduce

enum E { A, B }
use E::*;
fn foo(a: &E, b: &E) {
    match (a, b) {
        (A, A) => {}
        (_, B) => {}
    }
}

Probably this regression was introduced in #5720

Related issue: #5901 (it was fixed by #5720)

created time in 10 days

issue closedintellij-rust/intellij-rust

False-positive "Match must be exhaustive" when matching pair of references

Environment

  • IntelliJ Rust plugin version: 0.3.129.3274-202-nightly
  • Rust toolchain version: 1.47.0-nightly (6c8927b0c 2020-07-26) x86_64-unknown-linux-gnu
  • IDE name and version: CLion 2020.2 (CL-202.6397.106)
  • Operating system: Linux 5.7.12-arch1-1

Problem description

image

Warning disappears if type of a is changed from &E to E

Steps to reproduce

enum E { A, B }
use E::*;
fn foo(a: &E, b: &E) {
    match (a, b) {
        (A, A) => {}
        (_, B) => {}
        (B, A) => {}
    }
}

closed time in 10 days

dima74

issue commentintellij-rust/intellij-rust

False-positive "Match must be exhaustive" when matching pair of references

Looks like it is fixed by #5720

dima74

comment created time in 10 days

pull request commentintellij-rust/intellij-rust

INSP: refactor checking and filling of match expressions

Looks like this pull request also fixes #5901! @ortem probably it is worth to add test from #5901

ortem

comment created time in 10 days

push eventdima74/intellij-rust

Dmitry Murzin

commit sha d3865b365ec1366f605fc919495a4ab9c50319da

New resolve

view details

push time in 10 days

push eventdima74/intellij-rust

Arseniy Pendryak

commit sha 43e08a814fb3a96ab2ef62c1d1af5871ac6c3755

GRD: update 2020.2 dependencies

view details

bors[bot]

commit sha 79964ca39d36fced3858172fbfa13d446998dcf8

Merge #6123 6123: GRD: update 2020.2 dependencies r=Undin a=Undin Co-authored-by: Arseniy Pendryak <a.pendryak@yandex.ru>

view details

vlad20012

commit sha b22ea7e1e637903dcba8c238e5f241ba2f740818

Fix exception in the cargo toolwindow init Looks like `runAfterOpened` can run outside of EDT

view details

vlad20012

commit sha 5194d9aaa34c87cff68ff8b65f42366e5b1a3dfd

Fix exception `PsiElementBase.notNullChild` after variable inlining

view details

vlad20012

commit sha 7ab9113429e847e8e9f13011d5f5b741aa67dd4c

T: check that PSI matches re-parsed text after applying an action

view details

bors[bot]

commit sha 642706b101b1ba22254a1a065b64b123b517d04f

Merge #6125 6125: Fix exception in the cargo toolwindow init r=mchernyavsky a=vlad20012 Fix for #5999. Looks like `runAfterOpened` can run outside of EDT. <details> <summary>Stacktrace</summary> ``` Access is allowed from event dispatch thread with IW lock only. com.intellij.openapi.diagnostic.RuntimeExceptionWithAttachments: EventQueue.isDispatchThread()=false Toolkit.getEventQueue()=com.intellij.ide.IdeEventQueue@6d984235 Current thread: Thread[ApplicationImpl pooled thread 11,4,Idea Thread Group] 1697154984 SystemEventQueueThread: Thread[AWT-EventQueue-0,6,Idea Thread Group] 1894364389 at com.intellij.openapi.application.impl.ApplicationImpl.assertIsDispatchThread(ApplicationImpl.java:1061) at com.intellij.openapi.application.impl.ApplicationImpl.assertIsDispatchThread(ApplicationImpl.java:1043) at com.intellij.openapi.wm.impl.ToolWindowManagerImpl.doRegisterToolWindow(ToolWindowManagerImpl.kt:986) at com.intellij.openapi.wm.impl.ToolWindowManagerImpl.initToolWindow(ToolWindowManagerImpl.kt:530) at com.intellij.openapi.wm.impl.ToolWindowManagerImpl.initToolWindow(ToolWindowManagerImpl.kt:512) at org.rust.cargo.project.toolwindow.CargoToolWindow$Companion.initializeToolWindow(CargoToolWindow.kt:151) at org.rust.cargo.project.model.impl.CargoProjectsServiceImpl$$special$$inlined$with$lambda$3$1.run(CargoProjectImpl.kt:106) at com.intellij.ide.startup.impl.StartupManagerImpl.runActivity(StartupManagerImpl.java:436) at com.intellij.ide.startup.impl.StartupManagerImpl.runActivities(StartupManagerImpl.java:392) at com.intellij.ide.startup.impl.StartupManagerImpl.runPostStartupActivitiesRegisteredDynamically(StartupManagerImpl.java:334) at com.intellij.ide.startup.impl.StartupManagerImpl.runPostStartupActivities(StartupManagerImpl.java:247) at com.intellij.openapi.progress.impl.CoreProgressManager.lambda$runProcess$2(CoreProgressManager.java:170) at com.intellij.openapi.progress.impl.CoreProgressManager.registerIndicatorAndRun(CoreProgressManager.java:629) at com.intellij.openapi.progress.impl.CoreProgressManager.executeProcessUnderProgress(CoreProgressManager.java:581) at com.intellij.openapi.progress.impl.ProgressManagerImpl.executeProcessUnderProgress(ProgressManagerImpl.java:60) at com.intellij.openapi.progress.impl.CoreProgressManager.runProcess(CoreProgressManager.java:157) at com.intellij.openapi.progress.util.BackgroundTaskUtil.runUnderDisposeAwareIndicator(BackgroundTaskUtil.java:254) at com.intellij.ide.startup.impl.StartupManagerImpl.lambda$projectOpened$1(StartupManagerImpl.java:154) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.util.concurrent.Executors$PrivilegedThreadFactory$1$1.run(Executors.java:652) at java.util.concurrent.Executors$PrivilegedThreadFactory$1$1.run(Executors.java:649) at java.security.AccessController.doPrivileged(Native Method) at java.util.concurrent.Executors$PrivilegedThreadFactory$1.run(Executors.java:649) at java.lang.Thread.run(Thread.java:748) ``` </details> Co-authored-by: vlad20012 <beskvlad@gmail.com>

view details

bors[bot]

commit sha 961fb7d2b375da203825a010513e23f49dffded0

Merge #6126 6126: Fix exception `PsiElementBase.notNullChild` after variable inlining r=vlad20012 a=vlad20012 RsPath can't be replaced with `RsExpr`. Instead, parent `RsPathExpr` should be replaced. Typical stacktrace ends with this: ``` java.lang.Throwable: 10 parent=let b = 10; at com.intellij.openapi.diagnostic.Logger.error(Logger.java:143) at com.intellij.psi.impl.PsiElementBase.notNullChild(PsiElementBase.java:284) at org.rust.lang.core.psi.impl.RsPathExprImpl.getPath(RsPathExprImpl.java:43) ``` Also, I enhanced tests in order to catch such bugs in the future. c.c. @Kobzol Co-authored-by: vlad20012 <beskvlad@gmail.com>

view details

Dmitry Murzin

commit sha 5abb23583e39107ae3d0ae69c968c8637334f02b

New resolve

view details

push time in 10 days

PR opened intellij-rust/intellij-rust

PSI: Make RsForeignModItem implement RsItemsOwner

RsForeignModItem is naturally an item's owner, so it would be reasonable for it to implement RsItemsOwner interface

+4 -1

0 comment

2 changed files

pr created time in 11 days

push eventintellij-rust/intellij-rust

Dmitry Murzin

commit sha 4e0dc86b861d6920254935ac8030a88a4b92ebd4

PSI: Make RsForeignModItem implement RsItemsOwner

view details

push time in 11 days

push eventintellij-rust/intellij-rust

Arseniy Pendryak

commit sha db1c83fdda0b8f554678c5888377be2c2565ace3

#5915: properly update debugger after NativeDebug plugin update

view details

GitHub Action

commit sha 9ecfad4f3bc85311ee9806b1ea61e3a580271a5d

:arrow_up: patch version

view details

bors[bot]

commit sha 55f2782e65ef908c449a84ac554a35371e34244b

Merge #6113 6113: DBG: properly update debugger after NativeDebug plugin update r=mchernyavsky a=Undin Fixes #5915 Co-authored-by: Arseniy Pendryak <a.pendryak@yandex.ru>

view details

vlad20012

commit sha cd452ea202e2415dead6b039a60c9f31e8f198a7

REF: don't rename `src` dir. Fix issue #6117 Changes in test makes this test failing (without the fix): `test handle file references in path attribute`

view details

bors[bot]

commit sha 9cb4c77fe1a274cd5bc76daddf539d0fdd319b89

Merge #6118 6118: REF: don't rename `src` dir r=vlad20012 a=vlad20012 Fixes #6117 Co-authored-by: vlad20012 <beskvlad@gmail.com>

view details

vlad20012

commit sha 14215d12f4bda987a37722338fdf9b1b3669fd23

T: `modifyTemporary` - modify rust settings with Disposable in tests

view details

Dmitry Murzin

commit sha 05b16a7dfd93feea57854dae49219f890f05f90a

CI: Show number of regressions as github messages

view details

bors[bot]

commit sha 1214b38aaea77597259f2cfcc059a5a84ad4091c

Merge #6116 6116: CI: Show number of regressions as github messages r=undin a=dima74 Extends great [regression workflow](https://github.com/intellij-rust/intellij-rust/pull/5932) by showing number of regressions as [github messages](https://docs.github.com/en/actions/reference/workflow-commands-for-github-actions#setting-a-warning-message), so it will be possible to quickly inspect number of regressions for all crates (cargo, tokio and amethyst) on single page. [Example messages](https://github.com/intellij-rust/intellij-rust/actions/runs/257629920) (for this pull request). Also: * Swap order of annotations (`introduced` first, then `fixed`) - I think `introduced annotations` are more useful * Checkout back to tested commit before calculating regressions, so it will be easier to test changes to `calculate_regressions.py` Co-authored-by: Dmitry Murzin <diralik@yandex.ru>

view details

mchernyavsky

commit sha 8dc0df053fa366a2e28041cf46d676ef199c7023

FMT: Add an option to use rustfmt instead of build-in formatter

view details

bors[bot]

commit sha e7c1a3c547a80518023cb552e8609d410a977139

Merge #5704 5704: FMT: Add an option to use rustfmt instead of build-in formatter r=vlad20012 a=mchernyavsky Closes https://github.com/intellij-rust/intellij-rust/issues/5191. c.c. #1087 In this implementation, `Rustfmt` can be used **only** when formatting the **whole file** by: 1. `Code | Reformat Code` (`Ctrl + Alt + L`) action **without text selection** 2. `Code | Reformat File ...` (`Ctrl + Alt + Shift + L`) action with `Whole file` option E.g. `Rustfmt` can't be used when committing to git with `Reformat code Before Commit` option (it doesn't clear how to achieve this). By default, the built-in formatter is still ALWAYS used. `Rustfmt` can be enabled in `Settings | Languages & Frameworks | Rust | Rustfmt`. NB: rustfmt has an unstable option to restrict reformatting to specific sets of lines (https://github.com/rust-lang/rustfmt/issues/3397). Co-authored-by: vlad20012 <beskvlad@gmail.com> Co-authored-by: mchernyavsky <chernyavsky.mikhail@gmail.com>

view details

vlad20012

commit sha a31852eef81ee0e4699254b22301655c7fa03e5f

Get rid of `Don't reformat child modules` option This option does nothing for a long time. Finally get rid of it.

view details

bors[bot]

commit sha f0ddb0403db4489dab717092ab934124bc8b4a8b

Merge #6122 6122: Get rid of `Don't reformat child modules` option r=mchernyavsky a=vlad20012 This option does nothing for a long time. Finally, get rid of it. ![Screenshot from 2020-09-16 22-50-46](https://user-images.githubusercontent.com/3221931/93385561-183e0f00-f86f-11ea-880e-3ec8d9587bb0.png) Co-authored-by: vlad20012 <beskvlad@gmail.com>

view details

Dmitry Murzin

commit sha ff37680cbab71f322f5c9249b0bf8aa9ee79e6ea

New resolve

view details

Dmitry Murzin

commit sha b49e681811324490500208b4de381a25da71bdc5

Fix resolve stdlib macros in doctest injections

view details

Dmitry Murzin

commit sha ffe5a4b3c89bc82a9e52b3dfd1e7f1e05c96d3b3

Don't ignore cfg-disabled items in resolve

view details

Dmitry Murzin

commit sha 02915c4cd182f604d274322efbdeea4f1ea08d33

Correct multiresolve when mod contains two elements with same name

view details

Dmitry Murzin

commit sha b0df1faf96af35bb8e5bed596b53698ce465b618

Refactor isEnabledByCfg vs isDeeplyEnabledByCfg

view details

Dmitry Murzin

commit sha 5ddc344efee5442e7d9be1c6f7ba60b9695c21a5

Use old resolve inside cfg-disabled file shadowed by cfg-enabled file

view details

Dmitry Murzin

commit sha b99fe431267326bc972e14819f23497c55a8f5e6

Add debug checks after DefMap built

view details

Dmitry Murzin

commit sha e26677d39dc86f7edeb949a6c584d9bd7b755eb2

Minor refactoring

view details

push time in 11 days

push eventdima74/intellij-rust

Dmitry Murzin

commit sha 8ea3eda0acd752ec86e5e5f5dead511fb025bfb2

Temporary comment testAssert

view details

push time in 11 days

push eventdima74/intellij-rust

Dmitry Murzin

commit sha 2aa8c59238d221a6edb26d8d6d8bd1265716d9c4

Regressions: more projects

view details

Dmitry Murzin

commit sha f83ea592a67bef66d4295a187fbaf9beb35b69eb

Minor RsHighlightingPerformanceTest refactoring

view details

Dmitry Murzin

commit sha 6e501eee4f13cbdd32aed5816f10989f4165c914

Fix $crate handling in use item with use group

view details

push time in 11 days

push eventdima74/intellij-rust

Dmitry Murzin

commit sha 017582e09de7fb16c5a07a399b6549e37ccfa6b9

Regressions: more projects

view details

Dmitry Murzin

commit sha 71a8f084f7e0011827601aa7d32c497146624812

Minor RsHighlightingPerformanceTest refactoring

view details

push time in 11 days

push eventdima74/intellij-rust

Arseniy Pendryak

commit sha db1c83fdda0b8f554678c5888377be2c2565ace3

#5915: properly update debugger after NativeDebug plugin update

view details

bors[bot]

commit sha 55f2782e65ef908c449a84ac554a35371e34244b

Merge #6113 6113: DBG: properly update debugger after NativeDebug plugin update r=mchernyavsky a=Undin Fixes #5915 Co-authored-by: Arseniy Pendryak <a.pendryak@yandex.ru>

view details

vlad20012

commit sha cd452ea202e2415dead6b039a60c9f31e8f198a7

REF: don't rename `src` dir. Fix issue #6117 Changes in test makes this test failing (without the fix): `test handle file references in path attribute`

view details

bors[bot]

commit sha 9cb4c77fe1a274cd5bc76daddf539d0fdd319b89

Merge #6118 6118: REF: don't rename `src` dir r=vlad20012 a=vlad20012 Fixes #6117 Co-authored-by: vlad20012 <beskvlad@gmail.com>

view details

vlad20012

commit sha 14215d12f4bda987a37722338fdf9b1b3669fd23

T: `modifyTemporary` - modify rust settings with Disposable in tests

view details

Dmitry Murzin

commit sha 05b16a7dfd93feea57854dae49219f890f05f90a

CI: Show number of regressions as github messages

view details

bors[bot]

commit sha 1214b38aaea77597259f2cfcc059a5a84ad4091c

Merge #6116 6116: CI: Show number of regressions as github messages r=undin a=dima74 Extends great [regression workflow](https://github.com/intellij-rust/intellij-rust/pull/5932) by showing number of regressions as [github messages](https://docs.github.com/en/actions/reference/workflow-commands-for-github-actions#setting-a-warning-message), so it will be possible to quickly inspect number of regressions for all crates (cargo, tokio and amethyst) on single page. [Example messages](https://github.com/intellij-rust/intellij-rust/actions/runs/257629920) (for this pull request). Also: * Swap order of annotations (`introduced` first, then `fixed`) - I think `introduced annotations` are more useful * Checkout back to tested commit before calculating regressions, so it will be easier to test changes to `calculate_regressions.py` Co-authored-by: Dmitry Murzin <diralik@yandex.ru>

view details

mchernyavsky

commit sha 8dc0df053fa366a2e28041cf46d676ef199c7023

FMT: Add an option to use rustfmt instead of build-in formatter

view details

bors[bot]

commit sha e7c1a3c547a80518023cb552e8609d410a977139

Merge #5704 5704: FMT: Add an option to use rustfmt instead of build-in formatter r=vlad20012 a=mchernyavsky Closes https://github.com/intellij-rust/intellij-rust/issues/5191. c.c. #1087 In this implementation, `Rustfmt` can be used **only** when formatting the **whole file** by: 1. `Code | Reformat Code` (`Ctrl + Alt + L`) action **without text selection** 2. `Code | Reformat File ...` (`Ctrl + Alt + Shift + L`) action with `Whole file` option E.g. `Rustfmt` can't be used when committing to git with `Reformat code Before Commit` option (it doesn't clear how to achieve this). By default, the built-in formatter is still ALWAYS used. `Rustfmt` can be enabled in `Settings | Languages & Frameworks | Rust | Rustfmt`. NB: rustfmt has an unstable option to restrict reformatting to specific sets of lines (https://github.com/rust-lang/rustfmt/issues/3397). Co-authored-by: vlad20012 <beskvlad@gmail.com> Co-authored-by: mchernyavsky <chernyavsky.mikhail@gmail.com>

view details

vlad20012

commit sha a31852eef81ee0e4699254b22301655c7fa03e5f

Get rid of `Don't reformat child modules` option This option does nothing for a long time. Finally get rid of it.

view details

bors[bot]

commit sha f0ddb0403db4489dab717092ab934124bc8b4a8b

Merge #6122 6122: Get rid of `Don't reformat child modules` option r=mchernyavsky a=vlad20012 This option does nothing for a long time. Finally, get rid of it. ![Screenshot from 2020-09-16 22-50-46](https://user-images.githubusercontent.com/3221931/93385561-183e0f00-f86f-11ea-880e-3ec8d9587bb0.png) Co-authored-by: vlad20012 <beskvlad@gmail.com>

view details

Arseniy Pendryak

commit sha 43e08a814fb3a96ab2ef62c1d1af5871ac6c3755

GRD: update 2020.2 dependencies

view details

bors[bot]

commit sha 79964ca39d36fced3858172fbfa13d446998dcf8

Merge #6123 6123: GRD: update 2020.2 dependencies r=Undin a=Undin Co-authored-by: Arseniy Pendryak <a.pendryak@yandex.ru>

view details

vlad20012

commit sha b22ea7e1e637903dcba8c238e5f241ba2f740818

Fix exception in the cargo toolwindow init Looks like `runAfterOpened` can run outside of EDT

view details

bors[bot]

commit sha 642706b101b1ba22254a1a065b64b123b517d04f

Merge #6125 6125: Fix exception in the cargo toolwindow init r=mchernyavsky a=vlad20012 Fix for #5999. Looks like `runAfterOpened` can run outside of EDT. <details> <summary>Stacktrace</summary> ``` Access is allowed from event dispatch thread with IW lock only. com.intellij.openapi.diagnostic.RuntimeExceptionWithAttachments: EventQueue.isDispatchThread()=false Toolkit.getEventQueue()=com.intellij.ide.IdeEventQueue@6d984235 Current thread: Thread[ApplicationImpl pooled thread 11,4,Idea Thread Group] 1697154984 SystemEventQueueThread: Thread[AWT-EventQueue-0,6,Idea Thread Group] 1894364389 at com.intellij.openapi.application.impl.ApplicationImpl.assertIsDispatchThread(ApplicationImpl.java:1061) at com.intellij.openapi.application.impl.ApplicationImpl.assertIsDispatchThread(ApplicationImpl.java:1043) at com.intellij.openapi.wm.impl.ToolWindowManagerImpl.doRegisterToolWindow(ToolWindowManagerImpl.kt:986) at com.intellij.openapi.wm.impl.ToolWindowManagerImpl.initToolWindow(ToolWindowManagerImpl.kt:530) at com.intellij.openapi.wm.impl.ToolWindowManagerImpl.initToolWindow(ToolWindowManagerImpl.kt:512) at org.rust.cargo.project.toolwindow.CargoToolWindow$Companion.initializeToolWindow(CargoToolWindow.kt:151) at org.rust.cargo.project.model.impl.CargoProjectsServiceImpl$$special$$inlined$with$lambda$3$1.run(CargoProjectImpl.kt:106) at com.intellij.ide.startup.impl.StartupManagerImpl.runActivity(StartupManagerImpl.java:436) at com.intellij.ide.startup.impl.StartupManagerImpl.runActivities(StartupManagerImpl.java:392) at com.intellij.ide.startup.impl.StartupManagerImpl.runPostStartupActivitiesRegisteredDynamically(StartupManagerImpl.java:334) at com.intellij.ide.startup.impl.StartupManagerImpl.runPostStartupActivities(StartupManagerImpl.java:247) at com.intellij.openapi.progress.impl.CoreProgressManager.lambda$runProcess$2(CoreProgressManager.java:170) at com.intellij.openapi.progress.impl.CoreProgressManager.registerIndicatorAndRun(CoreProgressManager.java:629) at com.intellij.openapi.progress.impl.CoreProgressManager.executeProcessUnderProgress(CoreProgressManager.java:581) at com.intellij.openapi.progress.impl.ProgressManagerImpl.executeProcessUnderProgress(ProgressManagerImpl.java:60) at com.intellij.openapi.progress.impl.CoreProgressManager.runProcess(CoreProgressManager.java:157) at com.intellij.openapi.progress.util.BackgroundTaskUtil.runUnderDisposeAwareIndicator(BackgroundTaskUtil.java:254) at com.intellij.ide.startup.impl.StartupManagerImpl.lambda$projectOpened$1(StartupManagerImpl.java:154) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.util.concurrent.Executors$PrivilegedThreadFactory$1$1.run(Executors.java:652) at java.util.concurrent.Executors$PrivilegedThreadFactory$1$1.run(Executors.java:649) at java.security.AccessController.doPrivileged(Native Method) at java.util.concurrent.Executors$PrivilegedThreadFactory$1.run(Executors.java:649) at java.lang.Thread.run(Thread.java:748) ``` </details> Co-authored-by: vlad20012 <beskvlad@gmail.com>

view details

push time in 11 days

push eventdima74/intellij-rust

vlad20012

commit sha cd452ea202e2415dead6b039a60c9f31e8f198a7

REF: don't rename `src` dir. Fix issue #6117 Changes in test makes this test failing (without the fix): `test handle file references in path attribute`

view details

bors[bot]

commit sha 9cb4c77fe1a274cd5bc76daddf539d0fdd319b89

Merge #6118 6118: REF: don't rename `src` dir r=vlad20012 a=vlad20012 Fixes #6117 Co-authored-by: vlad20012 <beskvlad@gmail.com>

view details

vlad20012

commit sha 14215d12f4bda987a37722338fdf9b1b3669fd23

T: `modifyTemporary` - modify rust settings with Disposable in tests

view details

Dmitry Murzin

commit sha 05b16a7dfd93feea57854dae49219f890f05f90a

CI: Show number of regressions as github messages

view details

bors[bot]

commit sha 1214b38aaea77597259f2cfcc059a5a84ad4091c

Merge #6116 6116: CI: Show number of regressions as github messages r=undin a=dima74 Extends great [regression workflow](https://github.com/intellij-rust/intellij-rust/pull/5932) by showing number of regressions as [github messages](https://docs.github.com/en/actions/reference/workflow-commands-for-github-actions#setting-a-warning-message), so it will be possible to quickly inspect number of regressions for all crates (cargo, tokio and amethyst) on single page. [Example messages](https://github.com/intellij-rust/intellij-rust/actions/runs/257629920) (for this pull request). Also: * Swap order of annotations (`introduced` first, then `fixed`) - I think `introduced annotations` are more useful * Checkout back to tested commit before calculating regressions, so it will be easier to test changes to `calculate_regressions.py` Co-authored-by: Dmitry Murzin <diralik@yandex.ru>

view details

mchernyavsky

commit sha 8dc0df053fa366a2e28041cf46d676ef199c7023

FMT: Add an option to use rustfmt instead of build-in formatter

view details

bors[bot]

commit sha e7c1a3c547a80518023cb552e8609d410a977139

Merge #5704 5704: FMT: Add an option to use rustfmt instead of build-in formatter r=vlad20012 a=mchernyavsky Closes https://github.com/intellij-rust/intellij-rust/issues/5191. c.c. #1087 In this implementation, `Rustfmt` can be used **only** when formatting the **whole file** by: 1. `Code | Reformat Code` (`Ctrl + Alt + L`) action **without text selection** 2. `Code | Reformat File ...` (`Ctrl + Alt + Shift + L`) action with `Whole file` option E.g. `Rustfmt` can't be used when committing to git with `Reformat code Before Commit` option (it doesn't clear how to achieve this). By default, the built-in formatter is still ALWAYS used. `Rustfmt` can be enabled in `Settings | Languages & Frameworks | Rust | Rustfmt`. NB: rustfmt has an unstable option to restrict reformatting to specific sets of lines (https://github.com/rust-lang/rustfmt/issues/3397). Co-authored-by: vlad20012 <beskvlad@gmail.com> Co-authored-by: mchernyavsky <chernyavsky.mikhail@gmail.com>

view details

vlad20012

commit sha a31852eef81ee0e4699254b22301655c7fa03e5f

Get rid of `Don't reformat child modules` option This option does nothing for a long time. Finally get rid of it.

view details

bors[bot]

commit sha f0ddb0403db4489dab717092ab934124bc8b4a8b

Merge #6122 6122: Get rid of `Don't reformat child modules` option r=mchernyavsky a=vlad20012 This option does nothing for a long time. Finally, get rid of it. ![Screenshot from 2020-09-16 22-50-46](https://user-images.githubusercontent.com/3221931/93385561-183e0f00-f86f-11ea-880e-3ec8d9587bb0.png) Co-authored-by: vlad20012 <beskvlad@gmail.com>

view details

Dmitry Murzin

commit sha ff37680cbab71f322f5c9249b0bf8aa9ee79e6ea

New resolve

view details

Dmitry Murzin

commit sha b49e681811324490500208b4de381a25da71bdc5

Fix resolve stdlib macros in doctest injections

view details

Dmitry Murzin

commit sha ffe5a4b3c89bc82a9e52b3dfd1e7f1e05c96d3b3

Don't ignore cfg-disabled items in resolve

view details

Dmitry Murzin

commit sha 02915c4cd182f604d274322efbdeea4f1ea08d33

Correct multiresolve when mod contains two elements with same name

view details

Dmitry Murzin

commit sha b0df1faf96af35bb8e5bed596b53698ce465b618

Refactor isEnabledByCfg vs isDeeplyEnabledByCfg

view details

Dmitry Murzin

commit sha 5ddc344efee5442e7d9be1c6f7ba60b9695c21a5

Use old resolve inside cfg-disabled file shadowed by cfg-enabled file

view details

Dmitry Murzin

commit sha b99fe431267326bc972e14819f23497c55a8f5e6

Add debug checks after DefMap built

view details

Dmitry Murzin

commit sha e26677d39dc86f7edeb949a6c584d9bd7b755eb2

Minor refactoring

view details

Dmitry Murzin

commit sha 30ae55bf2a12dea6aea1337b2d0cb89248ba71fa

Rewrite ModCollector from Psi to Stub

view details

Dmitry Murzin

commit sha 9820eba458b2be70a7e8bcea0527342dee9bd823

Parse macroBody lazy

view details

Dmitry Murzin

commit sha c1d6e5b30021d564fde8c4460541c97b06ec38c5

Use stub in macro expansion & refactor HashCalculator usage

view details

push time in 11 days

pull request commentintellij-rust/intellij-rust

CI: Show number of regressions as github messages

bors r=undin

dima74

comment created time in 11 days

push eventintellij-rust/intellij-rust

Dmitry Murzin

commit sha 05b16a7dfd93feea57854dae49219f890f05f90a

CI: Show number of regressions as github messages

view details

push time in 11 days

PR opened intellij-rust/intellij-rust

Reviewers
CI: Show number of regressions as github messages

Extends great regression workflow by showing number of regressions as github messages, so it will be possible to quickly inspect number of regressions for all crates (cargo, tokio and amethyst) on single page.

Also:

  • Swap order of annotations (introduced first, then fixed) - I think introduced annotations are more useful
  • Checkout back to tested commit before calculating regressions, so it will be easier to test changes to calculate_regressions.py
+11 -4

0 comment

2 changed files

pr created time in 12 days

push eventintellij-rust/intellij-rust

Dmitry Murzin

commit sha 353e76e840c14759126bc9b0a95199a7e865e6f1

CI: Show number of regressions as github messages

view details

push time in 12 days

push eventdima74/intellij-rust

Arseniy Pendryak

commit sha db1c83fdda0b8f554678c5888377be2c2565ace3

#5915: properly update debugger after NativeDebug plugin update

view details

bors[bot]

commit sha 55f2782e65ef908c449a84ac554a35371e34244b

Merge #6113 6113: DBG: properly update debugger after NativeDebug plugin update r=mchernyavsky a=Undin Fixes #5915 Co-authored-by: Arseniy Pendryak <a.pendryak@yandex.ru>

view details

Dmitry Murzin

commit sha 364ca2efda3d2f8e93a3131e95a5185ab1dae076

Add regressions info as annotations

view details

Dmitry Murzin

commit sha ce9315f2ec6fb9b4ab1eb12f43e49e41a17b9510

New resolve

view details

Dmitry Murzin

commit sha b572a1b2d90a39f229f9fb319670059737979840

Fix resolve stdlib macros in doctest injections

view details

Dmitry Murzin

commit sha cf0b3ec95472a7cbc491a1fab515eecc977abdc4

Don't ignore cfg-disabled items in resolve

view details

Dmitry Murzin

commit sha 519ebf315659944684de56b12a0dbb1afa9dfc7b

Correct multiresolve when mod contains two elements with same name

view details

Dmitry Murzin

commit sha 42f42ef050eeb7244c7cb0ed2d0a6402987ee22b

Refactor isEnabledByCfg vs isDeeplyEnabledByCfg

view details

Dmitry Murzin

commit sha 8540991b6dff14d50b5868b44d569e5c07038367

Use old resolve inside cfg-disabled file shadowed by cfg-enabled file

view details

Dmitry Murzin

commit sha bc18bf4f799ced014cde78e876ca6629f5ffb4f3

Add debug checks after DefMap built

view details

Dmitry Murzin

commit sha a736e96772dd9d849aa6ed2e0551f002aaa9d993

Minor refactoring

view details

Dmitry Murzin

commit sha ac4993e0af19b53cd5f3769ca83151a516f8906e

Rewrite ModCollector from Psi to Stub

view details

Dmitry Murzin

commit sha 08bde548f3070a969d32cc4ca6a54660375cdd85

Parse macroBody lazy

view details

Dmitry Murzin

commit sha 02126f6feaa7649f46efa0cf23923919c6af105e

Use stub in macro expansion & refactor HashCalculator usage

view details

Dmitry Murzin

commit sha 6f2354e297adfbd9350b8a2c9fe9e9499e3b461b

Optimize collecting use item

view details

Dmitry Murzin

commit sha 76d00ae8f40e166aa557830d16f6796a61b270b7

Store path as Array<String> for macro calls and restricted visibility

view details

Dmitry Murzin

commit sha 931525f9382af2be7079bde7c7f8a26c94e74a1d

Move hasPreludeImport to RsUseItemStub

view details

Dmitry Murzin

commit sha 8d47a864456ef3f3e78e585c4280341e8b5686eb

Introduce RsStubElementTypes

view details

push time in 12 days

push eventdima74/intellij-rust

Dmitry Murzin

commit sha 19dd99e0ae52065ea446483b09d40ad0ec62e9d7

New resolve

view details

Dmitry Murzin

commit sha af58578f6480fe366e90c2827a6eefaddcf73640

Fix resolve stdlib macros in doctest injections

view details

Dmitry Murzin

commit sha 45cad7a66045cf0e6c7a31212224a6edba469fc0

Don't ignore cfg-disabled items in resolve

view details

Dmitry Murzin

commit sha f17f39133dcf9ed3cc377b2064b4547ae4129752

Correct multiresolve when mod contains two elements with same name

view details

Dmitry Murzin

commit sha 834b097de1eaa1c3f31065ecef298338e17c67cb

Refactor isEnabledByCfg vs isDeeplyEnabledByCfg

view details

Dmitry Murzin

commit sha 14a4f6d325e1e72058f1972faac510a9f3aeb512

Use old resolve inside cfg-disabled file shadowed by cfg-enabled file

view details

Dmitry Murzin

commit sha aec2b1df2fcb1bf2dd33a0dccc574dc4899cd245

Add debug checks after DefMap built

view details

Dmitry Murzin

commit sha f647ae061e3070dfe04f0e0d80e8c37d23896ed6

Minor refactoring

view details

Dmitry Murzin

commit sha f593a0d99284eb0d0e9d4ff21544731930111d21

Rewrite ModCollector from Psi to Stub

view details

Dmitry Murzin

commit sha dbfb71cf32f36d8dafbe80be75201c8e98a9fd72

Parse macroBody lazy

view details

Dmitry Murzin

commit sha aa6f65857ee9e7d7db801dc62e4179de4aac5a0f

Use stub in macro expansion & refactor HashCalculator usage

view details

Dmitry Murzin

commit sha 321553fe12808a0ac0895abd1b8063390a69900b

Optimize collecting use item

view details

Dmitry Murzin

commit sha 791d0162fa3b9cade2d62a40bd7b438839bd49ff

Store path as Array<String> for macro calls and restricted visibility

view details

push time in 12 days

push eventdima74/intellij-rust

Dmitry Murzin

commit sha 8ddce8c98eda5ce0892de4f4f44eaaa2103d3598

backup

view details

push time in 12 days

push eventdima74/intellij-rust

Dmitry Murzin

commit sha 5ae1194acab2cd3e7cd8003b48288d3713e69bdd

Add regressions info as annotations

view details

Dmitry Murzin

commit sha 21842164e032439ec78020d3e18942d16e9dfd70

New resolve

view details

Dmitry Murzin

commit sha c0f5cc1bfddd3e468c076e3e250089d202e4c769

Fix resolve stdlib macros in doctest injections

view details

Dmitry Murzin

commit sha 85467e4fe8d8d431c82aa0cf84900447ca8491e0

Don't ignore cfg-disabled items in resolve

view details

Dmitry Murzin

commit sha d2f4f73c886edd3f68ffb34ec72be69c1c071e6b

Correct multiresolve when mod contains two elements with same name

view details

Dmitry Murzin

commit sha c02ea5bcdf0ce27f49ef8b0151b1fe363920bfd1

Refactor isEnabledByCfg vs isDeeplyEnabledByCfg

view details

Dmitry Murzin

commit sha 48a4363186dc0f9036e2b72b5b19b1ff375cabe3

Use old resolve inside cfg-disabled file shadowed by cfg-enabled file

view details

Dmitry Murzin

commit sha 47354edcc8c2b5c993ac99af16acfd0739e7ddda

Add debug checks after DefMap built

view details

Dmitry Murzin

commit sha 0998520d5fecfccd5901b478af309dedac5c2372

Minor refactoring

view details

Dmitry Murzin

commit sha d5839ced225fe258258be41b98d2d071aeab9b24

Rewrite ModCollector from Psi to Stub

view details

Dmitry Murzin

commit sha 5691989b911cc9b83e18ac08810de576cd3d192e

Parse macroBody lazy

view details

Dmitry Murzin

commit sha 4c15849eb4b4dc117b88f463fe458e0cbb62b47c

Use stub in macro expansion & refactor HashCalculator usage

view details

Dmitry Murzin

commit sha 5523fb185f2e0855d844b78f4a4fa46a0c4bc4a1

Optimize collecting use item

view details

push time in 12 days

push eventdima74/new-2

Dmitry Murzin

commit sha e0a5d1608abf6f55cd97dbc0a6683abc3eb7dd15

Initial commit

view details

push time in 12 days

push eventdima74/new-2

Dmitry Murzin

commit sha 6474f3ee9638d8f49218fbe01b15afdfb30dad69

Create README.md

view details

push time in 12 days

create barnchdima74/ifmo-2020-metacalculations

branch : master

created branch time in 12 days

push eventdima74/intellij-rust

Dmitry Murzin

commit sha 38162b15fe8738ac4b746d4f739685dd5ee4e801

backup

view details

push time in 13 days

push eventdima74/intellij-rust

GitHub Action

commit sha 9ecfad4f3bc85311ee9806b1ea61e3a580271a5d

:arrow_up: patch version

view details

push time in 13 days

push eventdima74/intellij-rust

Jakub Beránek

commit sha a8621ee9d5fe0ffc1ddb46ec5da622d0bd0aeff6

REF: handle name conflicts after renaming bindings

view details

Jakub Beránek

commit sha 94a3bb3267915f6f6d02c98b08d766181ed92d23

COMP: Deprioritize completion of &mut self methods for const references and bindings

view details

bors[bot]

commit sha 6afd43111ee9c98dfc27b56e770b6baad3c3a55d

Merge #5657 5657: REF: handle name conflicts after renaming bindings r=vlad20012 a=Kobzol This PR adds support for detecting conflicts that can arise when bindings are renamed. The behaviour is inspired by the Kotlin/Java plugin, however I also added support for conflicts during renaming parameters (this doesn't happen in Kotlin/Java). I'm not sure if it's a good idea though. The implementation uses `processLocalVariables` to find local bindings, so it only "sees" existing names that are available at the place of the binding which is being renamed. ```rust fn test() { let c/*rename to a*/ = 1; // no conflict let a = 1; let b/*rename to a*/ = 1; // conflict } ``` I'm not sure what's the best behaviour here. Renaming `c` to `a` should be fine, but only if there is no usage of `c` that follows the declaration of the previous `a` binding. To support this scenario we would have to scan the usages of local variables and only include the conflict if `X` is renamed to `Y` and a usage of `X` "crosses" a declaration of another binding with name `Y`. Or we can do it like Kotlin and simply process all local bindings in the scope (i.e. go both up and down), which might be simpler. It would also be easier for parameter handling, currently I scan the function from the end for local variables, but it does not take bindings that are the last child of a block/function into account because they do not "see" themselves when `processLocalVariables` is used. The line `error("Conflicts $conflicts missing")` in tests is not practically reachable, because if there are no conflicts the refactoring will proceed and the test will fail with a `ComparisonFailure`, which I did not know how to handle/catch. Fixes: https://github.com/intellij-rust/intellij-rust/issues/3630 Co-authored-by: Jakub Beránek <berykubik@gmail.com>

view details

bors[bot]

commit sha 378eae8dc03890610257fb8f55c4e89060a8db51

Merge #5369 5369: COMP: Deprioritize completion of &mut self methods for const references and bindings r=mchernyavsky a=Kobzol This PR attempts to sort methods in completion based on mutability of `self`. If a method call is performed on a const reference or a non-mut binding,`&mut self` methods will be deprioritized. The implementation needs additional work that I wanted to discuss here. I needed to somehow pass the method call (`RsFieldLookup`) to `ScopedBaseCompletionEntity::getBasePriority` (I didn't know how else to get it from there). `ImplLookup` was already being passed down the completion chain, so I just slapped the element to the lookup, which is not optimal. Is there an easier way of passing down the element? Should I add it to the `RsCompletionContext` and pass it down the completion chain of methods and processors? The implementation now uses a very simple heuristic for deciding if the method should be deprioritized. Let me know if I should improve it (or how :) ). Completion could possibly receive a larger overhaul to support use cases like smart completion (https://github.com/intellij-rust/intellij-rust/issues/5196). Fixes: https://github.com/intellij-rust/intellij-rust/issues/1409 Co-authored-by: Jakub Beránek <jakub.beranek@vsb.cz>

view details

GitHub Action

commit sha 9ecfad4f3bc85311ee9806b1ea61e3a580271a5d

:arrow_up: patch version

view details

Dmitry Murzin

commit sha a4b4f06f590bf55668422a097103b9dd9c020904

Add regressions info as annotations

view details

Dmitry Murzin

commit sha 59107b58cb0e75cc29af8bc589957d4ffe117c4a

New resolve

view details

Dmitry Murzin

commit sha bb5e2c92b336fb8d5bdbfd0e84419a196b159858

Fix resolve stdlib macros in doctest injections

view details

Dmitry Murzin

commit sha f3e755d1ea2c9a470f5e3a122ecfdb0d35694ae9

Don't ignore cfg-disabled items in resolve

view details

Dmitry Murzin

commit sha 914a5f9a3b0f9d7cd9817304f00c8a04fbc15476

Correct multiresolve when mod contains two elements with same name

view details

Dmitry Murzin

commit sha 4fda042a387886ec00a4da4242a3b28ed4715000

Refactor isEnabledByCfg vs isDeeplyEnabledByCfg

view details

Dmitry Murzin

commit sha 10854f53104fd7311f33ac991c595d74a85e86b1

Use old resolve inside cfg-disabled file shadowed by cfg-enabled file

view details

Dmitry Murzin

commit sha 80317f016f537edd658f4980c6b2881f4fe8c3c0

Add debug checks after DefMap built

view details

Dmitry Murzin

commit sha c83ed4c400d2bce38d570222b5c7b7c23c5a78e9

Minor refactoring

view details

Dmitry Murzin

commit sha 55e81b07144151046f8f1ffd2103a2a63129c3f2

Rewrite ModCollector from Psi to Stub

view details

Dmitry Murzin

commit sha b7ec7cfd76a8b7037f470e6f459daf9d15de0088

Parse macroBody lazy

view details

Dmitry Murzin

commit sha 64de8a7f16ee74de45ab1c58c8a7b9b15ff18e5b

Use stub in macro expansion & refactor HashCalculator usage

view details

push time in 13 days

push eventdima74/Wikipedia-Yofication

Frequencies bot

commit sha a685534071c5bb390cc5e7e2a2ff0667279aae18

Build 626

view details

push time in 13 days

push eventintellij-rust/intellij-rust

Jakub Beránek

commit sha a8621ee9d5fe0ffc1ddb46ec5da622d0bd0aeff6

REF: handle name conflicts after renaming bindings

view details

ortem

commit sha c23783fa0b1f63daf5c75d909746235ea5eba0b3

RUN: Rename "Cargo Command" run configuration to "Cargo"

view details

Jakub Beránek

commit sha 2fbc1a89cc63bc2af27649497569243a40dc4445

INT: add support for creating methods in CreateFunctionIntention

view details

Dmitry Murzin

commit sha 21b9a264763ec7a0e0b6995669a7ec17af598f3b

T: Add additional resolve tests

view details

Jakub Beránek

commit sha ab29a5dc2558c37fe14dfab21c0c754d12625023

CI: cache evcxr in check workflow

view details

Dmitry Murzin

commit sha 191568567343f8f3e03023467f6d3f6e5c296803

REF: Use same processor for move files and move items refactoring

view details

bors[bot]

commit sha 45aaad4b2a08f66728fc1d55466b2a64e58159cf

Merge #5995 5995: RUN: Rename "Cargo Command" run configuration to "Cargo" r=Undin a=ortem <img width="324" alt="Screenshot 2020-08-25 at 13 30 26" src="https://user-images.githubusercontent.com/4854600/91164071-2cab4380-e6d7-11ea-97e8-e91ed880fb15.png"> Co-authored-by: ortem <ortem00@gmail.com>

view details

bors[bot]

commit sha 91f01dc5765b13dad55439af70ea1f49cc55ac1d

Merge #6069 6069: CI: cache evcxr in check workflow r=Undin a=Kobzol This PR caches `evcxr` so that it is not recompiled in every `check` workflow. This should hopefully reduce the runtime of this workflow on Ubuntu by about 2 minutes (~ 10% of the total runtime). I also tried to cache the `Download` task, but I'm not sure what does it download. When I cached the `deps` folder, it still took a long time to run the download task (it probably also downloads some gradle stuff?). Co-authored-by: Jakub Beránek <jakub.beranek@vsb.cz>

view details

bors[bot]

commit sha 8ee97f7f91d643689c3738b8918e13c5bb3d374d

Merge #6079 6079: T: Add additional resolve tests r=vlad20012 a=dima74 Adds additional tests related to resolve. These tests found some bugs in name resolution 2.0 implementation Co-authored-by: Dmitry Murzin <diralik@yandex.ru>

view details

Dmitry Murzin

commit sha bc06734cdab161ca70f0c20b2d43aab9e247e69a

Remove build_helper from std dependencies

view details

bors[bot]

commit sha 2370ca55d2d80f4e04010d89b9fbb576a249e1d1

Merge #6086 6086: Remove build_helper from std dependencies r=vlad20012 a=dima74 * `std` [no longer depends](https://github.com/rust-lang/rust/blob/5a6b426e3471382c0385c11b09c2d6b37f70ac49/library/std/Cargo.toml#L13-L36) on `build_helper` (removed in [this commit](https://github.com/rust-lang/rust/commit/8d500572fa8f4110033fa3bc5e925831f6bbd18e#diff-1a7024d46c31d728a04d5e0cafd98df8L47)) * `proc_macro` [no longer depends](https://github.com/rust-lang/rust/blob/5a6b426e3471382c0385c11b09c2d6b37f70ac49/library/proc_macro/Cargo.toml#L7-L8) on `syntax` (removed in [this commit](https://github.com/rust-lang/rust/commit/8cf463bcffea8b6582fec170841b22ae0d6c77ea#diff-08f7810b7aec61ec35fd3dcb7bb0b8f9L11)) Co-authored-by: Dmitry Murzin <diralik@yandex.ru>

view details

vlad20012

commit sha 2700c5a7259eb6d48a8f538f4221969c22d2e180

MACRO: fix RangeMap generation

view details

bors[bot]

commit sha 8f86a7b885bdc901700c5401dc7a9cf894c789cf

Merge #6041 6041: MACRO: fix RangeMap generation r=vlad20012 a=vlad20012 Co-authored-by: vlad20012 <beskvlad@gmail.com>

view details

bors[bot]

commit sha c684983779a2701b545798aac08c77c27e316cd5

Merge #6039 6039: INT: add support for creating methods in CreateFunctionIntention r=vlad20012 a=Kobzol This PR adds support for creatng methods in `CreateFunctionIntention`. Also I previously forget to register the intention and add a description, since it was originally a quick fix, so this PR also fixes that. ![create-method](https://user-images.githubusercontent.com/4539057/91731838-ae074800-eba7-11ea-89a1-3b98d50798e8.gif) Co-authored-by: Jakub Beránek <jakub.beranek@vsb.cz>

view details

ortem

commit sha b86d52b7cc2e3f5dedcc765b3be2b1817667d22f

#5215: Split `Match Check` into two inspections `Match Check` is now divided into two inspections: * `RsNonExhaustiveMatchInspection` (E0004 error) * `RsUselessMatchArmInspection` (unreachable_patterns warning)

view details

ortem

commit sha 8d7bf33614143640a08b7ca74d88c346163c2a50

#5215: Process empty match exprs in `RsNonExhaustiveMatchInspection`

view details

ortem

commit sha 3ec2a30aafcc99e76e103dcecdcee74d86225e84

#5215: Do not fill fully wildcard struct literals

view details

ortem

commit sha 3c31a2ae5f1214f91896c7d4cded5828f202d439

#5215: Get rid of `FillMatchArmsIntention` Empty match expressions filling is now implemented in `RsNonExhaustiveMatchInspection`

view details

ortem

commit sha 04d32eaffc9a15c734631738d981f3ad0fdde0db

#5215: Refactor `AddRemainingArmsFix` and `AddWildcardArmFix`

view details

ortem

commit sha 457c01913e25dbe76f4b40c69394ed069dbc9190

#5215: Improve Match checking code readability and documentation

view details

push time in 13 days

push eventdima74/intellij-rust

Jakub Beránek

commit sha a8621ee9d5fe0ffc1ddb46ec5da622d0bd0aeff6

REF: handle name conflicts after renaming bindings

view details

Dmitry Murzin

commit sha 191568567343f8f3e03023467f6d3f6e5c296803

REF: Use same processor for move files and move items refactoring

view details

ortem

commit sha b86d52b7cc2e3f5dedcc765b3be2b1817667d22f

#5215: Split `Match Check` into two inspections `Match Check` is now divided into two inspections: * `RsNonExhaustiveMatchInspection` (E0004 error) * `RsUselessMatchArmInspection` (unreachable_patterns warning)

view details

ortem

commit sha 8d7bf33614143640a08b7ca74d88c346163c2a50

#5215: Process empty match exprs in `RsNonExhaustiveMatchInspection`

view details

ortem

commit sha 3ec2a30aafcc99e76e103dcecdcee74d86225e84

#5215: Do not fill fully wildcard struct literals

view details

ortem

commit sha 3c31a2ae5f1214f91896c7d4cded5828f202d439

#5215: Get rid of `FillMatchArmsIntention` Empty match expressions filling is now implemented in `RsNonExhaustiveMatchInspection`

view details

ortem

commit sha 04d32eaffc9a15c734631738d981f3ad0fdde0db

#5215: Refactor `AddRemainingArmsFix` and `AddWildcardArmFix`

view details

ortem

commit sha 457c01913e25dbe76f4b40c69394ed069dbc9190

#5215: Improve Match checking code readability and documentation

view details

ortem

commit sha 0b56bee004ca4009fe241fb98ba5708f14965a5a

#5215: Substitute types during TyAdt pattern specialization

view details

ortem

commit sha b4081ef1620ad219c924786f5957ba2dcaaf501e

#5215: Improve matrix types validation * Throw `CheckMatchException` on ambiguous matrix type instead of fallback to analyzed pattern * Check enum variant patterns types are valid: they might be inherited from the matched expression, but not actually correct

view details

bors[bot]

commit sha 174fb1ab92a4cfca82ab08a663768f6e9138e4fe

Merge #5720 5720: INSP: refactor checking and filling of match expressions r=Undin a=ortem Closes #5215 Fixes #4349 * Split `Match Check` into two inspections: - `RsNonExhaustiveMatchInspection` (E0004 error) - `RsUselessMatchArmInspection` (unreachable_patterns warning) * Implement all `FillMatchArmsIntention` logic in `RsNonExhaustiveMatchInspection` and get rid of it Co-authored-by: ortem <ortem00@gmail.com>

view details

bors[bot]

commit sha 7561e06e9fde4375af6f8ab5cc12de9eb496c239

Merge #6080 6080: REF: Use same processor for move files and move items refactoring r=ortem a=dima74 This pull request is expected to not have any user-visible changes, but is needed to: * Easily implement move for multiple files (common processor is already able to process multiple items) * Any future change to common processor will affect both move files and move items refactoring (so no code duplication, etc) Co-authored-by: Dmitry Murzin <diralik@yandex.ru>

view details

Jakub Beránek

commit sha 0bdf0aa17ef3ac05ad21ed5d513b0993fdcf317a

INT: add missing title to CreateFunctionIntention

view details

Jakub Beránek

commit sha 57499b5613436bccf3897f051c239cbf1eae2841

Fix after template of CreateFunctionIntention

view details

bors[bot]

commit sha d65cbc584f3139c1c3f0f138b52c6742cba32584

Merge #6102 6102: INT: add missing title and fix typo in CreateFunctionIntention r=vlad20012 a=Kobzol I also noticed that the template for this intention had a typo. I think that it's a small enough change that we can bolt it onto this PR? Fixes: https://github.com/intellij-rust/intellij-rust/issues/6098 Co-authored-by: Jakub Beránek <jakub.beranek@vsb.cz>

view details

Arseniy Pendryak

commit sha d686566da9554fdd81a1d9f7aace5b279008aee2

CI: simplify base commit retrieving

view details

Arseniy Pendryak

commit sha 80b67f5193dfd8552d596a655ac51df4f8b1cdae

CI: extend list of real projects for regression testing tokio and amethyst are added

view details

bors[bot]

commit sha 3f4eb6e80c08ee8c987e321ea5abedab8f71e4f7

Merge #6067 6067: CI: extend list of real projects for regression testing r=Undin a=Undin tokio and amethyst projects are added by these changes Co-authored-by: Arseniy Pendryak <a.pendryak@yandex.ru>

view details

Jakub Beránek

commit sha 94a3bb3267915f6f6d02c98b08d766181ed92d23

COMP: Deprioritize completion of &mut self methods for const references and bindings

view details

bors[bot]

commit sha 6afd43111ee9c98dfc27b56e770b6baad3c3a55d

Merge #5657 5657: REF: handle name conflicts after renaming bindings r=vlad20012 a=Kobzol This PR adds support for detecting conflicts that can arise when bindings are renamed. The behaviour is inspired by the Kotlin/Java plugin, however I also added support for conflicts during renaming parameters (this doesn't happen in Kotlin/Java). I'm not sure if it's a good idea though. The implementation uses `processLocalVariables` to find local bindings, so it only "sees" existing names that are available at the place of the binding which is being renamed. ```rust fn test() { let c/*rename to a*/ = 1; // no conflict let a = 1; let b/*rename to a*/ = 1; // conflict } ``` I'm not sure what's the best behaviour here. Renaming `c` to `a` should be fine, but only if there is no usage of `c` that follows the declaration of the previous `a` binding. To support this scenario we would have to scan the usages of local variables and only include the conflict if `X` is renamed to `Y` and a usage of `X` "crosses" a declaration of another binding with name `Y`. Or we can do it like Kotlin and simply process all local bindings in the scope (i.e. go both up and down), which might be simpler. It would also be easier for parameter handling, currently I scan the function from the end for local variables, but it does not take bindings that are the last child of a block/function into account because they do not "see" themselves when `processLocalVariables` is used. The line `error("Conflicts $conflicts missing")` in tests is not practically reachable, because if there are no conflicts the refactoring will proceed and the test will fail with a `ComparisonFailure`, which I did not know how to handle/catch. Fixes: https://github.com/intellij-rust/intellij-rust/issues/3630 Co-authored-by: Jakub Beránek <berykubik@gmail.com>

view details

push time in 13 days

push eventdima74/intellij-rust

Dmitry Murzin

commit sha 4e1a1364cb714b80332e220bc8ec26716571124e

Parse macroBody lazy

view details

Dmitry Murzin

commit sha b75666d07391d8ed9a16e75164fec5d925d965e5

Use stub in macro expansion & refactor HashCalculator usage

view details

push time in 13 days

push eventdima74/intellij-rust

Dmitry Murzin

commit sha 191568567343f8f3e03023467f6d3f6e5c296803

REF: Use same processor for move files and move items refactoring

view details

ortem

commit sha b86d52b7cc2e3f5dedcc765b3be2b1817667d22f

#5215: Split `Match Check` into two inspections `Match Check` is now divided into two inspections: * `RsNonExhaustiveMatchInspection` (E0004 error) * `RsUselessMatchArmInspection` (unreachable_patterns warning)

view details

ortem

commit sha 8d7bf33614143640a08b7ca74d88c346163c2a50

#5215: Process empty match exprs in `RsNonExhaustiveMatchInspection`

view details

ortem

commit sha 3ec2a30aafcc99e76e103dcecdcee74d86225e84

#5215: Do not fill fully wildcard struct literals

view details

ortem

commit sha 3c31a2ae5f1214f91896c7d4cded5828f202d439

#5215: Get rid of `FillMatchArmsIntention` Empty match expressions filling is now implemented in `RsNonExhaustiveMatchInspection`

view details

ortem

commit sha 04d32eaffc9a15c734631738d981f3ad0fdde0db

#5215: Refactor `AddRemainingArmsFix` and `AddWildcardArmFix`

view details

ortem

commit sha 457c01913e25dbe76f4b40c69394ed069dbc9190

#5215: Improve Match checking code readability and documentation

view details

ortem

commit sha 0b56bee004ca4009fe241fb98ba5708f14965a5a

#5215: Substitute types during TyAdt pattern specialization

view details

ortem

commit sha b4081ef1620ad219c924786f5957ba2dcaaf501e

#5215: Improve matrix types validation * Throw `CheckMatchException` on ambiguous matrix type instead of fallback to analyzed pattern * Check enum variant patterns types are valid: they might be inherited from the matched expression, but not actually correct

view details

bors[bot]

commit sha 174fb1ab92a4cfca82ab08a663768f6e9138e4fe

Merge #5720 5720: INSP: refactor checking and filling of match expressions r=Undin a=ortem Closes #5215 Fixes #4349 * Split `Match Check` into two inspections: - `RsNonExhaustiveMatchInspection` (E0004 error) - `RsUselessMatchArmInspection` (unreachable_patterns warning) * Implement all `FillMatchArmsIntention` logic in `RsNonExhaustiveMatchInspection` and get rid of it Co-authored-by: ortem <ortem00@gmail.com>

view details

bors[bot]

commit sha 7561e06e9fde4375af6f8ab5cc12de9eb496c239

Merge #6080 6080: REF: Use same processor for move files and move items refactoring r=ortem a=dima74 This pull request is expected to not have any user-visible changes, but is needed to: * Easily implement move for multiple files (common processor is already able to process multiple items) * Any future change to common processor will affect both move files and move items refactoring (so no code duplication, etc) Co-authored-by: Dmitry Murzin <diralik@yandex.ru>

view details

Jakub Beránek

commit sha 0bdf0aa17ef3ac05ad21ed5d513b0993fdcf317a

INT: add missing title to CreateFunctionIntention

view details

Jakub Beránek

commit sha 57499b5613436bccf3897f051c239cbf1eae2841

Fix after template of CreateFunctionIntention

view details

bors[bot]

commit sha d65cbc584f3139c1c3f0f138b52c6742cba32584

Merge #6102 6102: INT: add missing title and fix typo in CreateFunctionIntention r=vlad20012 a=Kobzol I also noticed that the template for this intention had a typo. I think that it's a small enough change that we can bolt it onto this PR? Fixes: https://github.com/intellij-rust/intellij-rust/issues/6098 Co-authored-by: Jakub Beránek <jakub.beranek@vsb.cz>

view details

Arseniy Pendryak

commit sha d686566da9554fdd81a1d9f7aace5b279008aee2

CI: simplify base commit retrieving

view details

Arseniy Pendryak

commit sha 80b67f5193dfd8552d596a655ac51df4f8b1cdae

CI: extend list of real projects for regression testing tokio and amethyst are added

view details

bors[bot]

commit sha 3f4eb6e80c08ee8c987e321ea5abedab8f71e4f7

Merge #6067 6067: CI: extend list of real projects for regression testing r=Undin a=Undin tokio and amethyst projects are added by these changes Co-authored-by: Arseniy Pendryak <a.pendryak@yandex.ru>

view details

Dmitry Murzin

commit sha 19a01c857e836db15397ca14b87cc9ceccdfabbb

Add regressions info as annotations

view details

Dmitry Murzin

commit sha 8afc269aed4741ee3a45428cf0d1cccdca8f3e6b

New resolve

view details

Dmitry Murzin

commit sha b2150fd24f10bf333521b157c6dab3365fee4a2e

Fix resolve stdlib macros in doctest injections

view details

push time in 13 days

PR opened intellij-rust/intellij-rust

REF: Support move multiple files feature

Move refactoring improvements:

  • Support move multiple files/directories
  • Support move file to another crate

This pull requests mostly changes only move handler (it finds which exactly files should be moved). Actual implementation was added in #5736 and #6080

+188 -53

0 comment

4 changed files

pr created time in 14 days

PR opened intellij-rust/intellij-rust

REF: Improve newline handling in move items refactoring fix

Currently item is moved together with succeeding whitespace. It creates following problems:

  • when moving last item from file, after move source file will have double newline at the end
  • when moving non-last item from file, after move target file will have double newline at the end

This pull request fixes it by moving item together with preceding whitespace

+170 -5

0 comment

2 changed files

pr created time in 14 days

more