profile
viewpoint

digeff/angular 0

One framework. Mobile & desktop.

digeff/nodejstools 0

Node.js Tools for Visual Studio

digeff/noice-json-rpc 0

Noice Json RPC exposes a clean ES6 Proxy and Promise based interface for JSON-RPC2 Clients and Servers

digeff/old-vscode-pwa 0

VSCode PWA Extension

digeff/react-native 0

A framework for building native apps with React.

digeff/vscode-chrome-debug 0

Debug your JavaScript code running in Google Chrome from VS Code.

digeff/vscode-chrome-debug-core 0

A library for implementing VS Code debug adapters for targets that implement the Chrome Debugging Protocol.

digeff/vscode-debugadapter-node 0

Debug adapter protocol and implementation for VS Code.

digeff/vscode-node-debug 0

A VS Code debug adapter for node

digeff/vscode-node-debug2 0

A VS Code debug adapter that supports debugging Node via the Chrome Debugging Protocol.

Pull request review commentmicrosoft/vscode-js-debug

Support for using remote FileSystem

 export class GoldenText {       const match = frame.match(/^(.*):(\d+):(\d+)$/);       if (!match) return null;       const filePath = match[1];-      if (filePath === __filename) continue;-      return filePath;++      // We need to consider .ts files because we may have source-map-support to convert stack traces to .ts

As discussed offline, this only affect golden test files

digeff

comment created time in 15 hours

PullRequestReviewEvent

Pull request review commentmicrosoft/vscode-js-debug

Support for using remote FileSystem

 export class NodeConfigurationResolver extends BaseConfigurationResolver<AnyNode   constructor(     @inject(ExtensionContext) context: vscode.ExtensionContext,     @inject(INvmResolver) private readonly nvmResolver: INvmResolver,+    // We don't need Node to support remote file system at the moment, so we hardcode fsUtils

Done

digeff

comment created time in 16 hours

PullRequestReviewEvent

push eventmicrosoft/vscode-js-debug

digeff

commit sha cd97c2c4867170a31f6fdeb0e5900b7871e98ad8

Obtain FsUtils from globalcontainer

view details

digeff

commit sha 0c8afe0d2af006567c25affa3700e184f762fcad

Move FsUtils to fsUtils.ts

view details

digeff

commit sha 9781db210ebd2f49cbb9359c30b9a6c8a717d9d4

Renamed FsUtils to IFsUtils

view details

push time in 16 hours

Pull request review commentmicrosoft/vscode-js-debug

Support for using remote FileSystem

 export const Execa = Symbol('execa');  */ export const FS = Symbol('FS'); +/**+ * Injection for the `FsUtils` module.+ */+export const FSUtils = Symbol('FsUtils');

Done

digeff

comment created time in 16 hours

PullRequestReviewEvent

push eventmicrosoft/vscode-js-debug

digeff

commit sha a621375cc3d3fbbcee4b0bddc2b843283d5f1b3c

Update src/ioc.ts Co-authored-by: Connor Peet <connor@peet.io>

view details

push time in 17 hours

push eventmicrosoft/vscode-js-debug

digeff

commit sha 1477fd23ecb2ee3a9c04f51599457ab7e065e003

Update src/ioc.ts Co-authored-by: Connor Peet <connor@peet.io>

view details

push time in 17 hours

push eventmicrosoft/vscode-js-debug

digeff

commit sha 6dc885472debedbfbd10a6a0f98ceef1ddea9baa

Don't block checkContentHash

view details

push time in 18 hours

Pull request review commentmicrosoft/vscode-js-debug

Support for using remote FileSystem

 export async function checkContentHash(   }    if (!contentHash) {-    const exists = await fsUtils.exists(absolutePath);+    const exists = fs.existsSync(absolutePath);

That was my mistake. Good catch!

digeff

comment created time in 18 hours

PullRequestReviewEvent

push eventmicrosoft/vscode-js-debug

Connor Peet

commit sha 14020ccc70a05d8ea2863dd9253b95984f004db2

feat: include timestamp in node resource metrics

view details

Connor Peet

commit sha eccbe13fa8abeb8df46a0e3c99fb2c8dc70b3095

fix: don't apply resolveSourceMap default for remote workspaces Fixes https://github.com/microsoft/vscode-js-debug/issues/759

view details

Connor Peet

commit sha eede0d8f46e8636f051c9ac444b709eb56aba85d

fix: lazily set the basepath for auto attach path resolution Fixes https://github.com/microsoft/vscode/issues/106803

view details

Connor Peet

commit sha 4f1f6581b0164dcd465e6e74f99c0b2e9c68700b

chore: set the urlFilter to * by default Refs https://github.com/microsoft/vscode/issues/106795#issuecomment-693583850

view details

Connor Peet

commit sha ef111f392b32a51c53d4b94f5052c8ba6641f905

docs: start a COMMON_PROBLEMS.md doc

view details

Eric Cornelson

commit sha 207b7d5d487e255da5cf2a2d6c42531cd0a1c714

fix: Remove exclamation in operation error telemetry for VS (#758)

view details

Connor Peet

commit sha e460282d76378733beeb611eb6a572bd879869af

fix: don't attach to code cli in smart attach mode Fixes https://github.com/microsoft/vscode/issues/106920

view details

Connor Peet

commit sha db6415e96fdcbc2b4e2632160b5643e12d8f7bde

chore: polish working in auto attach warning Fixes https://github.com/microsoft/vscode-js-debug/issues/762

view details

digeff

commit sha 813d6adf525bec09152a2c3909da8ab2521bdbc5

Merge remote-tracking branch 'origin/master' into remote-fs

view details

push time in 18 hours

issue openeddotnet/runtime

MonoProxy send stack traces with reference to script that wasn't notified

  1. Create a new Blazor WebAssembly project in VS
  2. Set breakpoint at line14(currentCount++) of "Pages\Counter.razor".
  3. Debug Project with Chrome
  4. Navigate the web page to the counter page
  5. Click the click me button
  6. After hitting the breakpoint press step into two times

We get this stack frame: { "callFrameId": "{"ordinal":0,"injectedScriptId":2}", "functionName": "monoeg_g_free", "location": { "scriptId": "16", "lineNumber": 0, "columnNumber": 22343 },

But we never got a scriptParsed event with id 16. We got these: image

created time in 2 days

push eventmicrosoft/vscode-js-debug

digeff

commit sha b68a087e38d71877d547abff69b1add3154d47f3

Use sync exists on OSX

view details

push time in 3 days

push eventmicrosoft/vscode-js-debug

digeff

commit sha 11843966d74a0237493221b38da606fbb2631388

Use sync exists on OSX

view details

push time in 3 days

push eventmicrosoft/vscode-js-debug

digeff

commit sha 0426e4bd49cce583553d15573716b4c332b81473

Use existsSync

view details

push time in 3 days

push eventmicrosoft/vscode-js-debug

digeff

commit sha 469ce6790fdce547b06fa986c1839859d203e740

skip

view details

push time in 3 days

push eventmicrosoft/vscode-js-debug

digeff

commit sha c8a017ed1d17dac70584098cb9ebcc35d41335c0

Only test

view details

push time in 3 days

delete branch microsoft/vscode-js-debug

delete branch : skipBootloader

delete time in 4 days

push eventmicrosoft/vscode-js-debug

push time in 4 days

push eventmicrosoft/vscode-js-debug

digeff

commit sha 697c4e9a5237db4e3a2672d5a80ba5a1a4d0de46

Logging

view details

push time in 4 days

push eventmicrosoft/vscode-js-debug

Connor Peet

commit sha 000465166a592cae19b191346ddbb7443565a86f

fix: don't create any absolute path for eval'd code

view details

Connor Peet

commit sha 5f6bae0716cc2b8aaa4820edf74793aba3ed8e39

fix: correctly pass cleanUp down to browser launching

view details

Connor Peet

commit sha 1759060a27a1c1ea4cdb96543ce526e8c7050acd

fix: errors observed with next.js apps - It seems like they can generate very large inline sourcemap uris, which can cause an error in the breakpoint cache. We don't actually need to cache the sourcemap URIs -- fix that. - Remove sources when a new source comes in on the same path. This fixes some hot-reloading scenarios. Next.js' dev server is still odd, but this fixes breakpoints looking like they're set in garbage locations.

view details

Eric Cornelson

commit sha 975d29acac290463f0433e29e5596ca12c8f84cc

fix: broken VS error telemetry (#747) * fix: broken VS error telemetry * feedback: make isVsCode param true by default

view details

Connor Peet

commit sha d6afc7d82b979ca9ebeb88f72fb1a70e92f6a9af

fix: proper fix for next.js, rebuild webview for test failures

view details

dependabot[bot]

commit sha 77c4ce68422d561ecc642568abfc1da198d854c8

chore(deps): bump yargs-parser from 13.1.1 to 13.1.2 in /demos/webpack (#749) Bumps [yargs-parser](https://github.com/yargs/yargs-parser) from 13.1.1 to 13.1.2. - [Release notes](https://github.com/yargs/yargs-parser/releases) - [Changelog](https://github.com/yargs/yargs-parser/blob/master/docs/CHANGELOG-full.md) - [Commits](https://github.com/yargs/yargs-parser/commits) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

Connor Peet

commit sha 293d14ba6907d99d6304a7141114781ce08adb7e

chore: update sources tests

view details

Connor Peet

commit sha dc229974392f0963fb4788b25549e1f6c64fec84

feat: add debug link to welcome view, offer to save in launch.json Fixes https://github.com/microsoft/vscode/issues/104585

view details

Dan Čermák

commit sha d14c365a7ff52fe1ec12684bd53912687fc58528

fix: await nyc.report() or no test coverage gets recorded `report` is an asynchronous function and should be awaited otherwise the test coverage might not get written to the disk

view details

Connor Peet

commit sha 46e84b6987ee8532bcc7245b26d2e241d5b598c6

fix: process.stderr being incorrectly destroyed This was intended to destroy a pipe reader, but that reader was removed at some point and this code was left in there. Interestingly it does not seem to cause an issue for most simple program, so I didn't catch this, but causes 'random' failures later on. Fixes https://github.com/microsoft/vscode/issues/106484

view details

Connor Peet

commit sha 6368145d00f8d6f8bcb9dee1d44517fe94efdff9

chore: add disabled setting for auto attach filter Goes with https://github.com/microsoft/vscode/pull/106521

view details

Connor Peet

commit sha dcd7c1caeb3cd969c67f31d5c166d67f3f8bbc90

fix: append rather than replace node options in auto attach Fixes https://github.com/microsoft/vscode/issues/106631

view details

Connor Peet

commit sha 57b2da277b3f06fab3fe4eecd4036adb46ec5f48

feat: add getPerformance custom DAP messagea for js-debug

view details

Connor Peet

commit sha 8581c0bcda559b775d8666fb5765641c4118498b

fix: rm debug

view details

digeff

commit sha 2554968845430480f274a07d49402dc4cd1ad267

Add support for remote file system operations

view details

digeff

commit sha b24fa3c78cd15d6bae9e5ae9706d78746139ff71

Remove fsUtils from global container

view details

digeff

commit sha 3469746d8ee046838de04f0ea83edcb3a6dc805b

Increase timeout

view details

digeff

commit sha 70f80eeaec4a7ff9161ab7940df0b2c50d843001

test

view details

push time in 4 days

push eventmicrosoft/vscode-js-debug

digeff

commit sha 6c93bb7080508ef57fa157ec5e8adb1e985f4f7d

test

view details

push time in 8 days

push eventmicrosoft/vscode-js-debug

digeff

commit sha fd279e3fad6310eaf5f98343ff6dd0c43ee3eb43

Increase timeout

view details

push time in 8 days

push eventmicrosoft/vscode-js-debug

digeff

commit sha 5d38c5e507f2cb2ca25409a113c891042a085641

Remove fsUtils from global container

view details

push time in 8 days

push eventmicrosoft/vscode-js-debug

digeff

commit sha 2ade0684511060b270af731c85c8e37d18497847

Fix missing fsUtils

view details

push time in 8 days

push eventmicrosoft/vscode-js-debug

Connor Peet

commit sha 4313acdbe3f6675e75727c37e9ff5d0f8b90f964

1.49.4

view details

Connor Peet

commit sha dc223449b680402825e0e4da50e9b78a463de3b7

fix: check Chrome lockfile correctly on OSX as well Refs https://github.com/microsoft/vscode/issues/103083\#issuecomment-685840003

view details

Connor Peet

commit sha 72954aa575f41afa8a43af897bc2b36aa908556c

fix: error paths not being replaced in anonymous functions Fixes https://github.com/microsoft/vscode-js-debug/issues/412

view details

Connor Peet

commit sha 98a0694a9e41f16c7237be73fd0c99459c03beae

fix: typo in smart pattern description Fixes https://github.com/microsoft/vscode/issues/105965

view details

Connor Peet

commit sha c6cea4175b54a6c54ae29720a29b940cb2c02257

1.49.5

view details

Connor Peet

commit sha 6fa9e5ad74d876ecf831262e166bfaf3bedb9bc6

fix: smart attach only attaching to allowed tools Fixes https://github.com/microsoft/vscode/issues/105837

view details

Connor Peet

commit sha d7129a4ebbbe6aeae7b02389517efe377dacbb7d

1.49.6

view details

Connor Peet

commit sha 10d2e551c5b45b75b779d0cc8066731724ca6b52

chore: remove long prediction setting Works on https://github.com/microsoft/vscode-js-debug/issues/732

view details

Connor Peet

commit sha e916daeed4ac5b48217821d9cdb68b967bfd3682

fix: pad the inlineSourceOffset for script content Fixes https://github.com/microsoft/vscode-js-debug/issues/736

view details

Connor Peet

commit sha 73abffc76558be9edff698495807322404e39331

chore: rework wording for auto attach patterns description Fixes https://github.com/microsoft/vscode-js-debug/issues/734

view details

Connor Peet

commit sha 1a63cf5584ed026dd7ebb7e5b84046ca9c237c2d

chore: update test fixture

view details

Eric Cornelson

commit sha 9e90ad043f682a1062bcadf4502808975c80e7d2

fix: a race condition that can leave dangling debug sessions

view details

Connor Peet

commit sha 3d0ad98b0c56ab259637de57287612e93f7dd5a4

feat: allow a pure regex in sourceMapPathOverrides Fixes https://github.com/microsoft/vscode-js-debug/issues/530

view details

Connor Peet

commit sha 542d9ab5b2fb46df013649c4b151f47061769096

fix: ensure teardown is complete before sending terminate Fixes https://github.com/microsoft/vscode-js-debug/issues/436

view details

Connor Peet

commit sha f78c54483075597ffcf050a4310e531a59fb98dd

fix: potential race condition in script skipper Fixes https://github.com/microsoft/vscode/issues/104195

view details

digeff

commit sha 4c67dddde9682c58f584b1511dd478b7ead131c7

Add support for remote file system operations

view details

digeff

commit sha b3058f35554eab6102a58f5d2f8fcf69979f18cf

Remove fsUtils from global container

view details

push time in 8 days

push eventmicrosoft/vscode-js-debug

D

commit sha 44c82858a03dc03f9161fd8f87c24076ce4bbcb9

Added support for customDebuggerProperties

view details

push time in 9 days

push eventmicrosoft/vscode-js-debug

Connor Peet

commit sha 6ae0bd3c202939ade686ab9eeee34637d8714a8b

feat: adopt acorn+astring for beautification Fixes https://github.com/microsoft/vscode-js-debug/issues/371

view details

Connor Peet

commit sha 7bd3d0cd5e179f465f05f003095b1541eb878d53

fix: indicate overflow in object preview Fixes https://github.com/microsoft/vscode/issues/105739

view details

Connor Peet

commit sha 3d1db6e97a0fa4c70b10d4760aa326e0dffa4dc9

fix: invalidate sm caches on general context destruction Fixes https://github.com/microsoft/vscode-js-debug/issues/730 Fixes https://github.com/microsoft/vscode/issues/101762

view details

Connor Peet

commit sha 98bb433efa55a3c1185822f395360f33df9beac0

fix: update test fixtures

view details

Connor Peet

commit sha 3a6ec0609e8512183bedf5b635534de2746b56a0

potential fix for #624 (#687)

view details

Connor Peet

commit sha 4b6d9a45b69ed3107cbc7743f582ce90a4f05c55

feat: allow pausing when a condition bp throws Fixes https://github.com/microsoft/vscode-js-debug/issues/378

view details

Connor Peet

commit sha 53acd642fe4badf202b732200015aca148fc6862

1.49.3

view details

Connor Peet

commit sha 2ed44a3e02be28d467702c96774ed808a9a1d87c

fix: refresh env vars when auto attach settings change Fixes https://github.com/microsoft/vscode-js-debug/issues/731

view details

Connor Peet

commit sha 6c5b5cb02fda32f96d318b2a25ee169b7abc54c1

fix: language for aa setting Fixes https://github.com/microsoft/vscode/issues/105838

view details

Connor Peet

commit sha 4d22463fa76315ca44a6fe084925d7ffee0a993f

fix: improve language for aa 'explicit' mode Fixes https://github.com/microsoft/vscode/issues/105840

view details

Connor Peet

commit sha 175cd4dfbb39f2da9881bdac909e3fd2c7d90d5c

polish: debug terminal language in welcome view Fixes https://github.com/microsoft/vscode/issues/105833

view details

Connor Peet

commit sha 4313acdbe3f6675e75727c37e9ff5d0f8b90f964

1.49.4

view details

Connor Peet

commit sha dc223449b680402825e0e4da50e9b78a463de3b7

fix: check Chrome lockfile correctly on OSX as well Refs https://github.com/microsoft/vscode/issues/103083\#issuecomment-685840003

view details

Connor Peet

commit sha 72954aa575f41afa8a43af897bc2b36aa908556c

fix: error paths not being replaced in anonymous functions Fixes https://github.com/microsoft/vscode-js-debug/issues/412

view details

Connor Peet

commit sha 98a0694a9e41f16c7237be73fd0c99459c03beae

fix: typo in smart pattern description Fixes https://github.com/microsoft/vscode/issues/105965

view details

Connor Peet

commit sha c6cea4175b54a6c54ae29720a29b940cb2c02257

1.49.5

view details

Connor Peet

commit sha 6fa9e5ad74d876ecf831262e166bfaf3bedb9bc6

fix: smart attach only attaching to allowed tools Fixes https://github.com/microsoft/vscode/issues/105837

view details

Connor Peet

commit sha d7129a4ebbbe6aeae7b02389517efe377dacbb7d

1.49.6

view details

Connor Peet

commit sha 10d2e551c5b45b75b779d0cc8066731724ca6b52

chore: remove long prediction setting Works on https://github.com/microsoft/vscode-js-debug/issues/732

view details

Connor Peet

commit sha e916daeed4ac5b48217821d9cdb68b967bfd3682

fix: pad the inlineSourceOffset for script content Fixes https://github.com/microsoft/vscode-js-debug/issues/736

view details

push time in 9 days

push eventmicrosoft/vscode-js-debug

digeff

commit sha e4bbd01ca926c5907efe708cde0ec0e3f29e4cd3

test

view details

digeff

commit sha be9932e9ca2463cd20e33b515b6dcc86a20f1650

fix

view details

push time in 9 days

issue openedmicrosoft/vscode-js-debug

Breakpoints and stepping on dynamic embedded script files has several issues

  1. Create a ASP.NET project with a <script> inside an .cshtml file
  2. Try to stop on the script by using a debugger; statement, the debugger shows the wrong place
  3. Try to set breakpoints on the dynamic script file: They don't work because we set the breakpoints relative to the script, and chrome expect breakpoints relative to the html file (when we setbreakpointbyurl)

Attaching the project where this happens on VS Code and a log too (inside the zip). CSHTML WebApp.zip

created time in 14 days

issue commentmicrosoft/vscode-js-debug

Error: Unknown session id: <session-id> while processing: Inspector.targetReloadedAfterCrash

@connor4312 Sorry for the delay. At the moment all the stack traces in telemetry are blank, so we don't know what's happening yet. We are looking into this.

digeff

comment created time in 14 days

push eventmicrosoft/vscode-js-debug

Connor Peet

commit sha b5eac2827c2c16b64767c59bdeebb9da89fb60f5

fix: consistent escaping in contexts Fixes https://github.com/microsoft/vscode/issues/105552

view details

Connor Peet

commit sha 6ae0bd3c202939ade686ab9eeee34637d8714a8b

feat: adopt acorn+astring for beautification Fixes https://github.com/microsoft/vscode-js-debug/issues/371

view details

Connor Peet

commit sha 7bd3d0cd5e179f465f05f003095b1541eb878d53

fix: indicate overflow in object preview Fixes https://github.com/microsoft/vscode/issues/105739

view details

Connor Peet

commit sha 3d1db6e97a0fa4c70b10d4760aa326e0dffa4dc9

fix: invalidate sm caches on general context destruction Fixes https://github.com/microsoft/vscode-js-debug/issues/730 Fixes https://github.com/microsoft/vscode/issues/101762

view details

Connor Peet

commit sha 98bb433efa55a3c1185822f395360f33df9beac0

fix: update test fixtures

view details

Connor Peet

commit sha 3a6ec0609e8512183bedf5b635534de2746b56a0

potential fix for #624 (#687)

view details

Connor Peet

commit sha 4b6d9a45b69ed3107cbc7743f582ce90a4f05c55

feat: allow pausing when a condition bp throws Fixes https://github.com/microsoft/vscode-js-debug/issues/378

view details

Connor Peet

commit sha 53acd642fe4badf202b732200015aca148fc6862

1.49.3

view details

Connor Peet

commit sha 2ed44a3e02be28d467702c96774ed808a9a1d87c

fix: refresh env vars when auto attach settings change Fixes https://github.com/microsoft/vscode-js-debug/issues/731

view details

Connor Peet

commit sha 6c5b5cb02fda32f96d318b2a25ee169b7abc54c1

fix: language for aa setting Fixes https://github.com/microsoft/vscode/issues/105838

view details

Connor Peet

commit sha 4d22463fa76315ca44a6fe084925d7ffee0a993f

fix: improve language for aa 'explicit' mode Fixes https://github.com/microsoft/vscode/issues/105840

view details

Connor Peet

commit sha 175cd4dfbb39f2da9881bdac909e3fd2c7d90d5c

polish: debug terminal language in welcome view Fixes https://github.com/microsoft/vscode/issues/105833

view details

digeff

commit sha e6fde73372f0e5f24b3d150ca70ab54aa830ee05

Merge remote-tracking branch 'origin/master' into remote-fs

view details

push time in 17 days

push eventmicrosoft/vscode-js-debug

digeff

commit sha 9ffaca212659a66c11f18aef29a8e0dad7042f65

fix

view details

digeff

commit sha f16dee78aaf6eadddb1231aefc4f59955a479cde

fix

view details

push time in 17 days

push eventmicrosoft/vscode-js-debug

Connor Peet

commit sha f13a97cd527d3a716a39890d7c14c4ae6e3217d9

feat: add localization step for vs

view details

Connor Peet

commit sha 0fd22f22d40308b6934a400c4bd2c7aa1485fe5e

fixup! update nls dev for code extraction

view details

Connor Peet

commit sha 9172baa0b23d1fa1e921d2aaba25366a8aa7517c

fix: launch programs in terminals via relative path Fixes #536

view details

Connor Peet

commit sha 84a6bae3852ec174b03cbfaf58df0e56d89bd4d2

chore: update to terminal link provider api

view details

Connor Peet

commit sha 05e344ef08db21d090d499e1a92fc348a05c709e

Merge branch 'master' into update-terminal-link-api

view details

Connor Peet

commit sha e65bbbfcb620b02bbb5183f22cfd40fa5778b2db

chore: update to latest api

view details

Connor Peet

commit sha e5356ab06931bc6b61eff805f3e41b3f240c691c

fix: remove bad bundle prefix preventing localization

view details

Connor Peet

commit sha e65daa6ce7718337eb1a165c7cbaab71a4c505eb

fix: propagate noDebug to child debug sessions See https://github.com/microsoft/vscode/issues/102057#issuecomment-666489023

view details

Connor Peet

commit sha 9d11a8b29df4e9fd7b7e6ffd4434f4fc2bf322d9

fix: launching programs on different drives in windows failing Fixes test case failure

view details

Connor Peet

commit sha c5e0565e632d538933630674d22bb1c8a270a75f

fix: lease file touching triggering 'system busy' Fixes https://github.com/microsoft/vscode/issues/103187

view details

Connor Peet

commit sha c97431566044b56e05649d209686c433340860a4

feat: support custom scope types from cdp Fixes: https://github.com/microsoft/vscode-js-debug/issues/651

view details

Connor Peet

commit sha 86768e32c0c8c0b803921398f88d485d3a648702

fix: timeouts when stopping an attach config during a restart Fixes https://github.com/microsoft/vscode/issues/103706

view details

Connor Peet

commit sha 4eeae222ec887f5f9e88a33a1d189d3d3a503d82

v1.48.1

view details

Connor Peet

commit sha 59dcf5716e9c2960819116eb372986bd0dbde1fc

fix: add breakpoint set timeout to fix occasional vscode freezes

view details

Connor Peet

commit sha 69b8a78351344b8f6d50b7164df620339641b3c8

fix: tests breaking due to engine mismatch

view details

Connor Peet

commit sha 64b4a536eb7720cf0f21650a1cec551349aec32b

fix: relative paths in root rebasing not being correctly detected on windows

view details

Eric Cornelson

commit sha df969564be5a9d49e67bfa96a8b171fe98780471

fix: don't launch chrome with a cwd that doesn't exist (#683) * fix: don't launch chrome with a cwd that doesn't exist * feedback: use canAccess instead of existsSync

view details

Connor Peet

commit sha bc9fd3694c2a8d85d4970ce1caaf933577f24ff4

Merge branch 'update-terminal-link-api'

view details

Connor Peet

commit sha 8afbd17605b4f11a5ab8be4742ddd9018e004beb

Merge branch 'master' of github.com:microsoft/vscode-pwa

view details

Connor Peet

commit sha aa5ae434db6009124ed1f469c86ef3db702f468e

fix: pass restart tasks down to deep children Fixes https://github.com/microsoft/vscode/issues/104246

view details

push time in 20 days

push eventmicrosoft/vscode-js-debug

digeff

commit sha a04cff2e4c2b39616d4e1b813f41a40643b9fa76

feat: added customDescriptionGenerator feature to customize the descriptions of the debugger (#666) * Added customDescriptionGenerator feature to customize the descriptions of the debugger * Applied feedback * Make the code work for arrays too * Fix product issues * Delete unused file * Apply feedback * Use custom sample app instead of existing one * Delete something.js * Increase timeout

view details

digeff

commit sha 66ae4ac2ec581a03a1cee106745bf7d86177c507

Merge remote-tracking branch 'origin/master' into remote-fs

view details

push time in 21 days

push eventmicrosoft/vscode-js-debug

digeff

commit sha 2c267f70261e5ae858f63b84ced7d8a52acd1966

Use sync fs for checking contents

view details

push time in 21 days

push eventmicrosoft/vscode-js-debug

digeff

commit sha 5d4ee19c77bcb32c507a84256210cb3cc4c29fe3

Disable process.env.RETRY_TESTS

view details

push time in 21 days

push eventmicrosoft/vscode-js-debug

Connor Peet

commit sha 7d8f598a61728a2f0c00ec756d7b565c9bbab030

feat: reload sourcemap on new targets to deal with nodemon etc. Life is a little difficult dealing with servers like nodemon or `nest:dev`. These restart and can trigger things to re-compile on the fly, which means the sourcemaps we went to the trouble of parsing earlier might be invalid now. But we also don't want to just re-predict on every single new target, since doing so can be expensive. This implements a heuristic which I think should cover these cases well: - When a session's child exits (e.g. nodemon restarts a running process), then the next child that session spawns will receive a new instance of the breakpoint predictor. - The source map cache will now take into account source map mtimes to reload a map if it's discovered with a new mtime (by a breakpoint predictor--source maps loaded at runtime have no mtime). Also, after children are destroyed we will re-load source maps that lack an mtime, if we need to load them again. Fixes #711

view details

Eric Cornelson

commit sha e59cf6d8f90fcbfc5950b52f3dfdd61a889d91ba

fix: block DAP messages from being sent after responding to the disco… (#707) * fix: block DAP messages from being sent after responding to the disconnect request, and add error handling on transport stream writes * fix: failing test

view details

Connor Peet

commit sha 6d029faa215053ca6edd2da47035639c404c3bf8

fix: tests on osx hanging

view details

Connor Peet

commit sha ffe66f62c921598083ba4c0be3fb92fea4ea2424

fix: more descriptive variable naming

view details

digeff

commit sha 3a6b78d40e01b47e6aaa949686e2f26504f39e6c

Increase timeout

view details

digeff

commit sha 7eff301bde7376412f15f20ddedcf7c41f6f5114

Merge remote-tracking branch 'origin/master' into remote-fs

view details

push time in 22 days

push eventmicrosoft/vscode-js-debug

Connor Peet

commit sha 7d8f598a61728a2f0c00ec756d7b565c9bbab030

feat: reload sourcemap on new targets to deal with nodemon etc. Life is a little difficult dealing with servers like nodemon or `nest:dev`. These restart and can trigger things to re-compile on the fly, which means the sourcemaps we went to the trouble of parsing earlier might be invalid now. But we also don't want to just re-predict on every single new target, since doing so can be expensive. This implements a heuristic which I think should cover these cases well: - When a session's child exits (e.g. nodemon restarts a running process), then the next child that session spawns will receive a new instance of the breakpoint predictor. - The source map cache will now take into account source map mtimes to reload a map if it's discovered with a new mtime (by a breakpoint predictor--source maps loaded at runtime have no mtime). Also, after children are destroyed we will re-load source maps that lack an mtime, if we need to load them again. Fixes #711

view details

Eric Cornelson

commit sha e59cf6d8f90fcbfc5950b52f3dfdd61a889d91ba

fix: block DAP messages from being sent after responding to the disco… (#707) * fix: block DAP messages from being sent after responding to the disconnect request, and add error handling on transport stream writes * fix: failing test

view details

Connor Peet

commit sha 6d029faa215053ca6edd2da47035639c404c3bf8

fix: tests on osx hanging

view details

Connor Peet

commit sha ffe66f62c921598083ba4c0be3fb92fea4ea2424

fix: more descriptive variable naming

view details

D

commit sha e932a713365308b6f37369c848d620272e76f38b

Merge remote-tracking branch 'origin/master' into customDescriptionGenerator

view details

D

commit sha 31be0cc078f3b767706a820ad44d0d39a59f9de8

Increase timeout

view details

push time in 22 days

push eventmicrosoft/vscode-js-debug

D

commit sha 5d2fb4251fbd652891dbfeb643d1992c856de497

Delete something.js

view details

push time in 22 days

PullRequestReviewEvent

Pull request review commentmicrosoft/vscode-js-debug

Added customDescriptionGenerator feature to customize the descriptions of the debugger

             "program": "${workspaceFolder}\\app.ts",             "outFiles": [                 "${workspaceFolder}/**/*.js"-            ]+            ],+            "customDescriptionGenerator": "const lal = 4; lal + global.customDebuggerDescription(this, defaultValue)",

Moved to it's own demo

digeff

comment created time in 22 days

push eventmicrosoft/vscode-js-debug

D

commit sha ded68ede9d939f457e5605109a5c29d48982b553

Apply feedback

view details

D

commit sha c44cdc42191343489693644eb24d992d2c31c640

Use custom sample app instead of existing one

view details

push time in 22 days

Pull request review commentmicrosoft/vscode-js-debug

Added customDescriptionGenerator feature to customize the descriptions of the debugger

+/*---------------------------------------------------------+ * Copyright (C) Microsoft Corporation. All rights reserved.+ *--------------------------------------------------------*/+import { getSyntaxErrorIn } from './sourceUtils';+import { invalidLogPointSyntax } from '../dap/errors';+import { ProtocolError } from '../dap/protocolError';+import ts from 'typescript';++/**+ * function (params) { code } => function (params) { catchAndReturnErrors(code) }+ * statement => function () { return catchAndReturnErrors(return statement) }+ * statement; statement => function () { catchAndReturnErrors(statement; return statement;) }+ * */+export function codeToFunctionReturningErrors(+  parameterNames: string,+  statements: ReadonlyArray<ts.Statement>,+) {+  if (statements.length === 1 && statements[0].kind === ts.SyntaxKind.FunctionDeclaration) {+    const functionDeclarationCode = statements[0].getText();+    const callFunctionCode = `return (${functionDeclarationCode}).call(this, ${parameterNames});`;+    return codeToFunctionExecutingCodeAndReturningErrors(parameterNames, callFunctionCode, true);+  } else {+    return statementToFunctionReturningErrors(parameterNames, statements, true);+  }+}++/**+ * code => (parameterNames) => return catchAndReturnErrors(code)+ * */+export function codeToFunctionExecutingCodeAndReturningErrors(

Done

digeff

comment created time in 22 days

PullRequestReviewEvent

Pull request review commentmicrosoft/vscode-js-debug

Added customDescriptionGenerator feature to customize the descriptions of the debugger

 export class VariableStore {     };   } -  private _createObjectVariable(name: string, value: RemoteObject, context?: string): Dap.Variable {+  private async _createObjectVariable(+    name: string,+    value: RemoteObject,+    context?: string,+  ): Promise<Dap.Variable> {     const variablesReference = this._createVariableReference(value);     const object = value.o;     return {       name,-      value:-        (name === '__proto__' && object.description) ||-        objectPreview.previewRemoteObject(object, context),+      value: await this._generateVariableValueDescription(name, value, object, context),       evaluateName: value.accessor,       type: object.subtype || object.type,       variablesReference,     };   } -  private _createArrayVariable(name: string, value: RemoteObject, context?: string): Dap.Variable {+  private async _generateVariableValueDescription(+    name: string,+    value: RemoteObject,+    object: Cdp.Runtime.RemoteObject,+    context?: string,+  ): Promise<string> {+    const defaultValueDescription =+      (name === '__proto__' && object.description) ||+      objectPreview.previewRemoteObject(object, context);++    if (this.customDescriptionGenerator) {

Done

digeff

comment created time in 22 days

PullRequestReviewEvent

Pull request review commentmicrosoft/vscode-js-debug

Added customDescriptionGenerator feature to customize the descriptions of the debugger

+function _generatedCode(defaultValue) {+  try {+    return (function (def) {+      return global.customDebuggerDescription(this, def)+    })(defaultValue);+  } catch (e) {+    return e.stack || e.message || String(e);+  }+}

Removed

digeff

comment created time in 22 days

PullRequestReviewEvent

push eventmicrosoft/vscode-js-debug

D

commit sha cdd4b6d282a8305a19bfeab8bcf3eff01cd74ad8

Delete unused file

view details

push time in 22 days

push eventmicrosoft/vscode-js-debug

digeff

commit sha 903bf9c8c2582425b33bf689edb02ad7e6ca3c8e

Make platform independent

view details

digeff

commit sha d443011903d9fa73abdea02b9d4ce7639017a14d

Remove only

view details

digeff

commit sha 368ff4618359996c02c65de3830f02a5f0a40d19

Fix format

view details

push time in 22 days

push eventmicrosoft/vscode-js-debug

digeff

commit sha 7c6be1c74a9f47f78ad36b3da2f647c38bf9f923

Fix formatting

view details

push time in 22 days

push eventmicrosoft/vscode-js-debug

digeff

commit sha 01167c666850bffed6a2c0d997d7d29eb047e8ae

Make golden files work with .ts stack traces

view details

push time in 22 days

push eventmicrosoft/vscode-js-debug

D

commit sha 3f017122571acfaba26af08c44de7aa513827f18

Fix product issues

view details

push time in 22 days

push eventmicrosoft/vscode-js-debug

Connor Peet

commit sha 912817fb016763aa207c370be8ccdc04cf577269

fix: leak in tests causing timeout on osx

view details

Connor Peet

commit sha aae064fae5622daff43df62fd02905a8c7de1498

refactor: improve hasher code, move hash to unit tests

view details

Connor Peet

commit sha 91cbf0f75c81c9c4bae921b2e627eeeb7b8d8c8c

fix: race when setting and unsetting breakpoints rapidly Refs https://github.com/microsoft/vscode-js-debug/issues/679#issuecomment-681003475

view details

Connor Peet

commit sha e4c5f681f367751f80954eced92af1be319fa46c

fix: always prefer to set breakpoints by deriving from the absolute path I think this is a good change to make. Previously we would set by the source URL, but this can be overly specific (as in the linked issue) and also introduces a difference in breakpoint resolution in those set before launch and after launch, which is undesirable. Fixes #600

view details

D

commit sha 6a8754d525f14160613787c7cbe6f5c42feed868

Merge remote-tracking branch 'origin/master' into customDescriptionGenerator

view details

push time in 22 days

PR closed microsoft/vscode-js-debug

Reviewers
Ensure source.rootPaths being defined when Node is a child session of Chrome

We were having some issues on Node sessions that were a child of a Chrome session because they were started without the rootSession or cwd configured, and so we couldn't configure the source.rootPath so we ended up showing absolute paths for the loaded script files. With this fix, we show relative file paths instead

+8 -1

6 comments

3 changed files

digeff

pr closed time in 22 days

pull request commentmicrosoft/vscode-js-debug

Ensure source.rootPaths being defined when Node is a child session of Chrome

@connor4312 We'll try to change our implementation to use two different sessions started independently. Let's hold off on this PR to see if that approach will work without issues.

digeff

comment created time in 22 days

push eventmicrosoft/vscode-js-debug

digeff

commit sha 4e670ca82029a99eb7c58815641df51b1f55f412

Fix format

view details

push time in 22 days

push eventmicrosoft/vscode-js-debug

digeff

commit sha ee3105eba64e784537abf6553e337da7649f61de

Fix other test

view details

push time in 22 days

push eventmicrosoft/vscode-js-debug

digeff

commit sha e78f3e06d24f9f5ede08f135ed710efff5012496

Fix test

view details

push time in 23 days

push eventmicrosoft/vscode-js-debug

digeff

commit sha 0753a73e4bad72d935bfb019dfeb8812946e7ce1

Finish fixing conflicts

view details

push time in 23 days

push eventmicrosoft/vscode-js-debug

Connor Peet

commit sha 912817fb016763aa207c370be8ccdc04cf577269

fix: leak in tests causing timeout on osx

view details

Connor Peet

commit sha aae064fae5622daff43df62fd02905a8c7de1498

refactor: improve hasher code, move hash to unit tests

view details

Connor Peet

commit sha 91cbf0f75c81c9c4bae921b2e627eeeb7b8d8c8c

fix: race when setting and unsetting breakpoints rapidly Refs https://github.com/microsoft/vscode-js-debug/issues/679#issuecomment-681003475

view details

Connor Peet

commit sha e4c5f681f367751f80954eced92af1be319fa46c

fix: always prefer to set breakpoints by deriving from the absolute path I think this is a good change to make. Previously we would set by the source URL, but this can be overly specific (as in the linked issue) and also introduces a difference in breakpoint resolution in those set before launch and after launch, which is undesirable. Fixes #600

view details

digeff

commit sha 7a47fb8e3f885408c4e50db326eca432799ac5dd

Merge remote-tracking branch 'origin/master' into remote-fs

view details

push time in 23 days

push eventmicrosoft/vscode-js-debug

digeff

commit sha 17049da8a3f66118bee39ba2a2668932f51df661

Fix broken build

view details

push time in 24 days

pull request commentmicrosoft/vscode-js-debug

Ensure source.rootPaths being defined when Node is a child session of Chrome

@connor4312 What would you suggest as the best way to handle this scenario? Is there a different feature/parameter we can use?

digeff

comment created time in 24 days

push eventmicrosoft/vscode-js-debug

digeff

commit sha ef7e64f6b75895dff664a4d2bf8134440b39c599

Skip Bootloader to hide it from users

view details

digeff

commit sha c819a4d9677ea1bf20f58132f00921208167e755

Applied feedback

view details

Connor Peet

commit sha f18cb0200e4b07d7af0da0e09bf5babe02f8a747

Merge remote-tracking branch 'origin/skipBootloader'

view details

Connor Peet

commit sha 2eadab0f2e033821e82813753ed18e408195d685

feat: hide all internal evaluations with .cdp scripts

view details

digeff

commit sha 90a509a7ec855788960a31fb6df63f7dd7baa552

Merge remote-tracking branch 'origin/master' into remote-fs

view details

push time in 24 days

Pull request review commentmicrosoft/vscode-js-debug

Support for using remote FileSystem

 export class Binder implements IDisposable {           dap,         ),       );-      dap.on('launch', params =>-        this._boot(+      dap.on('launch', params => {+        const remoteFilePrefix = (params as { __remoteFilePrefix: string | undefined })+          .__remoteFilePrefix;+        this._rootServices+          .bind(FSUtils)+          .toConstantValue(LocalAndRemoteFsUtils.create(remoteFilePrefix, fsPromises, dap));

Done!

digeff

comment created time in 24 days

PullRequestReviewEvent

push eventmicrosoft/vscode-js-debug

digeff

commit sha a3cf62c10256405b0b4e63efc9c99a4989436967

Remove unnecesary code

view details

push time in 24 days

push eventmicrosoft/vscode-js-debug

Connor Peet

commit sha f13a97cd527d3a716a39890d7c14c4ae6e3217d9

feat: add localization step for vs

view details

Connor Peet

commit sha 0fd22f22d40308b6934a400c4bd2c7aa1485fe5e

fixup! update nls dev for code extraction

view details

Connor Peet

commit sha 9172baa0b23d1fa1e921d2aaba25366a8aa7517c

fix: launch programs in terminals via relative path Fixes #536

view details

Connor Peet

commit sha 84a6bae3852ec174b03cbfaf58df0e56d89bd4d2

chore: update to terminal link provider api

view details

Connor Peet

commit sha 05e344ef08db21d090d499e1a92fc348a05c709e

Merge branch 'master' into update-terminal-link-api

view details

Connor Peet

commit sha e65bbbfcb620b02bbb5183f22cfd40fa5778b2db

chore: update to latest api

view details

Connor Peet

commit sha e5356ab06931bc6b61eff805f3e41b3f240c691c

fix: remove bad bundle prefix preventing localization

view details

Connor Peet

commit sha e65daa6ce7718337eb1a165c7cbaab71a4c505eb

fix: propagate noDebug to child debug sessions See https://github.com/microsoft/vscode/issues/102057#issuecomment-666489023

view details

Connor Peet

commit sha 9d11a8b29df4e9fd7b7e6ffd4434f4fc2bf322d9

fix: launching programs on different drives in windows failing Fixes test case failure

view details

Connor Peet

commit sha c5e0565e632d538933630674d22bb1c8a270a75f

fix: lease file touching triggering 'system busy' Fixes https://github.com/microsoft/vscode/issues/103187

view details

Connor Peet

commit sha c97431566044b56e05649d209686c433340860a4

feat: support custom scope types from cdp Fixes: https://github.com/microsoft/vscode-js-debug/issues/651

view details

Connor Peet

commit sha 86768e32c0c8c0b803921398f88d485d3a648702

fix: timeouts when stopping an attach config during a restart Fixes https://github.com/microsoft/vscode/issues/103706

view details

Connor Peet

commit sha 4eeae222ec887f5f9e88a33a1d189d3d3a503d82

v1.48.1

view details

Connor Peet

commit sha 59dcf5716e9c2960819116eb372986bd0dbde1fc

fix: add breakpoint set timeout to fix occasional vscode freezes

view details

Connor Peet

commit sha 69b8a78351344b8f6d50b7164df620339641b3c8

fix: tests breaking due to engine mismatch

view details

Connor Peet

commit sha 64b4a536eb7720cf0f21650a1cec551349aec32b

fix: relative paths in root rebasing not being correctly detected on windows

view details

Eric Cornelson

commit sha df969564be5a9d49e67bfa96a8b171fe98780471

fix: don't launch chrome with a cwd that doesn't exist (#683) * fix: don't launch chrome with a cwd that doesn't exist * feedback: use canAccess instead of existsSync

view details

Connor Peet

commit sha bc9fd3694c2a8d85d4970ce1caaf933577f24ff4

Merge branch 'update-terminal-link-api'

view details

Connor Peet

commit sha 8afbd17605b4f11a5ab8be4742ddd9018e004beb

Merge branch 'master' of github.com:microsoft/vscode-pwa

view details

Connor Peet

commit sha aa5ae434db6009124ed1f469c86ef3db702f468e

fix: pass restart tasks down to deep children Fixes https://github.com/microsoft/vscode/issues/104246

view details

push time in 24 days

push eventmicrosoft/vscode-js-debug

Connor Peet

commit sha 2540489141266333db7d155d9d8ff345da25fae9

refactor: adopt new vscode API for DAP breakpoints

view details

Connor Peet

commit sha 7d2532d331db00ef9692b88f5b67cc2abfa2ac29

fix: handle certain browser launch errors better Refs https://github.com/microsoft/vscode-js-debug/issues/713

view details

Connor Peet

commit sha 67d874a66c85bed59a5aaf06172831fa6dbe0afc

fix: breakpoint prediction warning not working Fixes https://github.com/microsoft/vscode-js-debug/issues/712

view details

Connor Peet

commit sha 32244ec6b0c979f79a1808cbb506e6ef5900d6b2

feat: hide debug spam from console Originally didn't think it worked due to a typeo. Fixes #558

view details

Connor Peet

commit sha 70a28110d7752fa8076f553d0e092a52d9439e73

fix: allow turning on auto attach without a binary if no spaces in path

view details

Connor Peet

commit sha d40c1e12e42b3f9d43a2ecaedaa155aab152aa8d

fix: tests

view details

Connor Peet

commit sha ed4af53f7cfad568d1972b14a97b2f2cd3dcff5a

feat: allow attaching by patterns in auto attach Refs: https://github.com/microsoft/vscode-js-debug/issues/703

view details

Connor Peet

commit sha c9cf3c89d311bf7a561273206126dc6eb9112076

chore: bump min compatibility for stable 1.49 release

view details

Connor Peet

commit sha 535959854ed5619aaa14382e7f803ba9db963d1b

1.49.0

view details

Connor Peet

commit sha 44f5fbf06ab1877a4b376054431a86fdd1399238

chore: add more details to binary not found errors

view details

Connor Peet

commit sha 2518eeb26140ef2d3c0254056614bf335b7a29d3

fix: run tests on insiders for new apis

view details

Connor Peet

commit sha f7349c3cd61ae07752d78da19a4cf8d26d366ca4

fix: don't send a hash request if the absolutePath is empty

view details

Connor Peet

commit sha 0e39e63e92365aac218e43d3eeccacf26679b4ed

feat: require positive ack from auto launch that a debugger is expected

view details

Connor Peet

commit sha 38b5da1b876300c074b539c2711636ba01d790bb

1.49.1

view details

Connor Peet

commit sha 0e80166687b8fe15eecbed128bd3c40bac5ce92d

fix: auto attach interfering with debug terminal

view details

Connor Peet

commit sha d14b4f3104aec524677a8d3795a3ab3a6eef5da1

refactor: reduce bootloader script size

view details

Connor Peet

commit sha e3c6b98b70bfe2c8796dc7472bbd8cf23fee6906

feat: improve behavior of stderr capture for processes Only capture up until the "debugger attached" message, and dump the stderr if the process dies before that happens. Fixes https://github.com/microsoft/vscode/issues/104675

view details

Connor Peet

commit sha 94ffcfb97525503bcd52e29112c5d7aa765bb1f5

fix: 'module not found' errors not being displayed

view details

Connor Peet

commit sha 93f6e3205f0d7fd8f79fab12a7a8637138a9c63f

1.49.2

view details

Connor Peet

commit sha 94e3abdbbe7df9af91cbcb41f3ec2bbdc6d88fa8

fix: flakey variables test

view details

push time in 24 days

issue commentmicrosoft/vscode-js-debug

Blazor wasm and MS Edge

@connor4312 I haven't seen any of these

vchirikov

comment created time in 24 days

Pull request review commentmicrosoft/vscode-js-debug

Support for using remote FileSystem

 import { ILauncher, ITarget } from './targets/targets'; import { DapTelemetryReporter } from './telemetry/dapTelemetryReporter'; import { NullTelemetryReporter } from './telemetry/nullTelemetryReporter'; import { ITelemetryReporter } from './telemetry/telemetryReporter';+import { IScriptSkipper } from './adapter/scriptSkipper/scriptSkipper';+import { IDefaultBrowserProvider, DefaultBrowserProvider } from './common/defaultBrowserProvider';+import { ResourceProviderState } from './adapter/resourceProvider/resourceProviderState';+import { StatefulResourceProvider } from './adapter/resourceProvider/statefulResourceProvider';+import { IResourceProvider } from './adapter/resourceProvider';+import { BreakpointManager } from './adapter/breakpoints';+import { ObservableMap } from './common/datastructure/observableMap';+import {+  IBreakpointConditionFactory,+  BreakpointConditionFactory,+} from './adapter/breakpoints/conditions';+import { LogPointCompiler } from './adapter/breakpoints/conditions/logPoint';+import { OutFiles, VueComponentPaths } from './common/fileGlobList';+import { IVueFileMapper, VueFileMapper } from './adapter/vueFileMapper';+import { VSCodeRendererAttacher } from './targets/browser/vscodeRendererAttacher';+import { LocalAndRemoteFsUtils } from './common/fsUtils';

yes, reverted!

digeff

comment created time in a month

PullRequestReviewEvent

push eventmicrosoft/vscode-js-debug

digeff

commit sha 3279ca4c97c5b8e5d8a1e69a575d5db64fce4877

Restore ioc.ts imports

view details

push time in a month

push eventmicrosoft/vscode-js-debug

digeff

commit sha d931519b4529762fed667a6edf8ce9dd3e8d0a25

Applied feedback

view details

digeff

commit sha c466b890b190d2a16230d1793fb55ca0a3f47811

Reformat files

view details

push time in a month

Pull request review commentmicrosoft/vscode-js-debug

Support for using remote FileSystem

 export class NvmResolver implements INvmResolver {    * This detects that.    */   private async getBinaryInFolder(dir: string) {-    if (await some(['node64.exe', 'node64'].map(exe => exists(path.join(dir, exe))))) {+    if (await some(['node64.exe', 'node64'].map(exe => this.fsUtils.exists(path.join(dir, exe))))) {

I don't follow. This is the header I found for some: export function some<T>( promises: ReadonlyArray<Promise<T | undefined | null | false | ''>>, ): Promise<T | undefined> { Won't promises work here?

digeff

comment created time in a month

PullRequestReviewEvent

Pull request review commentmicrosoft/vscode-js-debug

Support for using remote FileSystem

 export class AutoAttachLauncher extends NodeLauncherBase<ITerminalLaunchConfigur     @inject(ILogger) logger: ILogger,     @inject(ExtensionContext) private readonly extensionContext: vscode.ExtensionContext,     @inject(FS) private readonly fs: FsPromises,

Awesome! :)

digeff

comment created time in a month

PullRequestReviewEvent

Pull request review commentmicrosoft/vscode-js-debug

Support for using remote FileSystem

 export const createTargetContainer = (   container.bind(BasicCpuProfiler).toSelf();   container.bind(IProfilerFactory).to(ProfilerFactory).inSingletonScope();   container.bind(IProfileController).to(ProfileController).inSingletonScope();+  container+    .bind(FSUtils)+    .toConstantValue(+      LocalAndRemoteFsUtils.create(launchParams.__remoteFilePrefix, fsPromises, dap),+    );

Done

digeff

comment created time in a month

PullRequestReviewEvent

Pull request review commentmicrosoft/vscode-js-debug

Support for using remote FileSystem

 export const createTargetContainer = (   target: ITarget,   dap: Dap.Api,   cdp: Cdp.Api,+  launchParams: AnyLaunchConfiguration,

Removed

digeff

comment created time in a month

PullRequestReviewEvent

Pull request review commentmicrosoft/vscode-js-debug

Support for using remote FileSystem

 export class Binder implements IDisposable {           dap,         ),       );-      dap.on('launch', params =>-        this._boot(+      dap.on('launch', params => {+        const remoteFilePrefix = (params as { __remoteFilePrefix: string | undefined })+          .__remoteFilePrefix;+        this._rootServices+          .bind(FSUtils)+          .toConstantValue(LocalAndRemoteFsUtils.create(remoteFilePrefix, fsPromises, dap));

Done

digeff

comment created time in a month

PullRequestReviewEvent

Pull request review commentmicrosoft/vscode-js-debug

Support for using remote FileSystem

 export function readFileRaw(path: string): Promise<Buffer> {   return fs.promises.readFile(path).catch(() => Buffer.alloc(0)); } -export function exists(path: string): Promise<boolean> {-  return new Promise(cb => {-    fs.exists(path, cb);-  });+export interface IFsUtils {+  exists(path: string): Promise<boolean>;+}++export class LocalFsUtils implements IFsUtils {+  public constructor(private readonly fs: FsPromises) {}++  public async exists(path: string): Promise<boolean> {+    // Check if the file exists in the current directory.+    try {+      await this.fs.access(path, fs.constants.F_OK);+      return true;+    } catch {+      return false;+    }+  }+}++interface IDapWithCustomRequest {+  remoteFileExistsRequest(params: { localFilePath: string }): Promise<{ doesExists: boolean }>;+}++export class RemoteFsThroughDapUtils implements IFsUtils {+  public constructor(private readonly dap: Dap.Api) {}++  public async exists(path: string): Promise<boolean> {+    try {+      // Custom request+      const { doesExists } = await ((this+        .dap as unknown) as IDapWithCustomRequest).remoteFileExistsRequest({

Done

digeff

comment created time in a month

PullRequestReviewEvent

push eventmicrosoft/vscode-js-debug

digeff

commit sha c819a4d9677ea1bf20f58132f00921208167e755

Applied feedback

view details

push time in a month

PR opened microsoft/vscode-js-debug

Reviewers
Skip Bootloader to hide it from users

This fixes all the bootloader sources appearing on the "Loaded scripts" list (which the user doesn't care about)

+9 -0

0 comment

1 changed file

pr created time in a month

pull request commentmicrosoft/vscode-js-debug

Ensure source.rootPaths being defined when Node is a child session of Chrome

@connor4312 We use the server launch.json argument to launch a Chrome session that also has a node session

digeff

comment created time in a month

create barnchmicrosoft/vscode-js-debug

branch : skipBootloader

created branch time in a month

PR opened microsoft/vscode-js-debug

Reviewers
Ensure source.rootPaths being defined when Node is a child session of Chrome

We were having some issues on Node sessions that were a child of a Chrome session because they were started without the rootSession or cwd configured, and so we couldn't configure the source.rootPath so we ended up showing absolute paths for the loaded script files. With this fix, we show relative file paths instead

+8 -1

0 comment

3 changed files

pr created time in a month

create barnchmicrosoft/vscode-js-debug

branch : relativeLoadedScripts

created branch time in a month

push eventmicrosoft/vscode-js-debug

digeff

commit sha 2d2443de3480775ddff2f71d52d054c9aff8fa13

Fixes

view details

push time in a month

push eventmicrosoft/vscode-js-debug

Connor Peet

commit sha 375221ba7ed1a166b59410648089c86d3d3e4b33

feat: harden auto attach, round 1 - Make semver detection and capabilities more precise for other features - Prefer to only quote the path if we verify there are spaces in it. This prevents breaking in the edge case that we guess wrong or the user switches Node versions.

view details

Connor Peet

commit sha 49cebfebbc7ecdb3321a8881d5dcb317bb016189

feat: introduce 'smart' auto attach option This will, by default, try to only attach when running node scripts directly, and avoid attaching to tooling installed globally or in dependencies. See #703

view details

Connor Peet

commit sha 6e4b87da58c081de9bc9df9ad0599808c403a913

feat: add stub hooks for --inspect-publish-uid option See: https://github.com/microsoft/vscode-js-debug/issues/558 Currently blocked on: https://github.com/nodejs/node/issues/12665#issuecomment-675758519

view details

Connor Peet

commit sha f42d52be5d06339a0396831812db5ccb6c77f43e

fix: correctly start cdp methods at 1000

view details

Eric Cornelson

commit sha 9bcb4a7b1a35acd3b9d314996e1316c2cc77b60f

fix: flat session root session creation (#710)

view details

D

commit sha 877abb75bd5e5c721d6ad348ccc554a7d7d0e04b

Change fs.exist operations to use an injectable component

view details

digeff

commit sha 833a5da91583e745e8e457d5e7fa6f454d36f9c1

Fixes

view details

digeff

commit sha eb442ae5b5e1c44098965f2ed270cbbe93a5254c

Fix

view details

digeff

commit sha 7c2d4e33b9ab49cefbd87df552952e6cff253df1

fix

view details

push time in a month

PullRequestReviewEvent

push eventmicrosoft/vscode-js-debug

digeff

commit sha 027c7c5846d2f31281f9ec9ebf5ff4b6870fadcf

Fix

view details

push time in a month

PR opened microsoft/vscode-js-debug

Reviewers
Remote fs
  • Add support to use a remote FileSystem. If __remoteFilePrefix is specified, when we do a fs.exists operation, if the filePath starts with __remoteFilePrefix, the operation will be performed by asking the DAP client to perform this operation.
  • Modified the code using fsUtils.exist to consume fsUtils via injection

This is the first iteration of the remote file system, we'll need further changes in the future (such as reading source-maps using remote file operations too) I'm sending this now because we already have a lot of changes, so as to keep the PR to a reasonable level

+292 -98

0 comment

31 changed files

pr created time in a month

more