profile
viewpoint

digeff/angular 0

One framework. Mobile & desktop.

digeff/nodejstools 0

Node.js Tools for Visual Studio

digeff/noice-json-rpc 0

Noice Json RPC exposes a clean ES6 Proxy and Promise based interface for JSON-RPC2 Clients and Servers

digeff/old-vscode-pwa 0

VSCode PWA Extension

digeff/react-native 0

A framework for building native apps with React.

digeff/vscode-chrome-debug 0

Debug your JavaScript code running in Google Chrome from VS Code.

digeff/vscode-chrome-debug-core 0

A library for implementing VS Code debug adapters for targets that implement the Chrome Debugging Protocol.

digeff/vscode-debugadapter-node 0

Debug adapter protocol and implementation for VS Code.

digeff/vscode-node-debug 0

A VS Code debug adapter for node

digeff/vscode-node-debug2 0

A VS Code debug adapter that supports debugging Node via the Chrome Debugging Protocol.

PR opened microsoft/vscode-js-debug

Do not block on source-map if there are no breakpoints

Do not block on source-map processing if there are no breakpoints

+11 -1

0 comment

1 changed file

pr created time in 2 days

create barnchmicrosoft/vscode-js-debug

branch : dont_block_without_bps

created branch time in 2 days

create barnchdigeff/vscode-pwa

branch : vs/d16.7

created branch time in 5 days

create barnchmicrosoft/vscode-js-debug

branch : vs/d16.7

created branch time in 5 days

push eventmicrosoft/vscode-js-debug

digeff

commit sha eec523787fbeb57fcb982fbb22f723eadc515ea8

Change variable name

view details

push time in 9 days

push eventmicrosoft/vscode-js-debug

digeff

commit sha 7038954c1d64b929d835d002495193097aace864

Change variable name

view details

push time in 9 days

push eventmicrosoft/vscode-js-debug

digeff

commit sha 16b40e4849040cba2e17d5447145a4b68d543c12

Applied feedback

view details

push time in 9 days

push eventmicrosoft/vscode-js-debug

digeff

commit sha a4ebce455ef808ba47943aa431a3610c138e71dd

Update src/adapter/threads.ts Co-authored-by: Connor Peet <connor@peet.io>

view details

push time in 9 days

push eventmicrosoft/vscode-js-debug

digeff

commit sha 9a253075fc6ae88a4765195b8a77351d3f4aa8e7

Update src/adapter/sources.ts Co-authored-by: Connor Peet <connor@peet.io>

view details

push time in 9 days

PR opened microsoft/vscode-js-debug

Reviewers
Now we can configure the timeouts used for waiting for source-maps

In VS we were not hitting breakpoints because the 1 sec source-map timeout wasn't enough for the source-maps to be processed.

Added the "cumulative extra timeout" concept, to address this up to 10 seconds. Also made it configurable if it's not enough for all users.

+108 -21

0 comment

8 changed files

pr created time in 10 days

create barnchmicrosoft/vscode-js-debug

branch : configurableTimeouts

created branch time in 10 days

issue commentmicrosoft/vscode-js-debug

Web-page hits a breakpoint but VS Code doesn't show it

This only seems to happen while launching the debug adapter with the debugServer configuration in VS Code. I'm not sure if we want to fix it or not.

digeff

comment created time in 10 days

push eventmicrosoft/vscode-js-debug

Connor Peet

commit sha fb8f779ca2d8b028811d809820b7e3e06072b521

1.47.0

view details

Connor Peet

commit sha f366e12e84437a95b1d9ea675f47e1ac634e87e7

fix: use correct mode for packages

view details

digeff

commit sha 2e6e2229436d096de29d021a484fb4256c9edf33

Do not block on exception pause before configurationDone

view details

digeff

commit sha 93504ced53dde208e19332b5ccdbed2fd86ca81e

Applied feedback

view details

push time in 10 days

Pull request review commentmicrosoft/vscode-js-debug

Do not block on exception pause before configurationDone

 export class DebugAdapter implements IDisposable {     this._pauseOnExceptionsState = 'none';     if (params.filters.includes('caught')) this._pauseOnExceptionsState = 'all';     else if (params.filters.includes('uncaught')) this._pauseOnExceptionsState = 'uncaught';-    if (this._thread) await this._thread.setPauseOnExceptionsState(this._pauseOnExceptionsState);+    if (this._thread) {+      const result = this._thread.setPauseOnExceptionsState(this._pauseOnExceptionsState);+      const logger = this._services.get<ILogger>(ILogger);+      if (this._configurationDoneDeferred.hasSettled()) {+        logger.verbose(LogTag.Internal, 'setExceptionBreakpoints: awaiting blocking response');+        await result;+      } else {+        result+          .then(() => {+            logger.verbose(+              LogTag.Internal,+              'setExceptionBreakpoints: succesful non-blocking response',+            );+          })+          .catch(rejection => {+            const output = localize(+              '`errors.setExceptionBreakpoints.async.failed`',+              'Failed to configure the exceptions for which to pause due to: {0}',+              rejection.message || localize('errors.unknown', 'Unknown error'),+            );+            this.dap.output({ category: 'stderr', output: output });+            const telemetry = this._services.get<ITelemetryReporter>(ITelemetryReporter);+            telemetry.reportOperation(

You are right

digeff

comment created time in 10 days

PR opened microsoft/vscode-js-debug

Reviewers
Do not block on exception pause before configurationDone

Chrome cannot answer some APIs when the target is paused. Do not block on exception pause before configurationDone to avoid the API getting stuck.

+42 -31

0 comment

2 changed files

pr created time in 11 days

create barnchmicrosoft/vscode-js-debug

branch : fix_exceptionPause

created branch time in 11 days

issue openedmicrosoft/vscode-js-debug

Web-page hits a breakpoint but VS Code doesn't show it

On the VS react and redux default template set a breakpoint on: App.tsx: Line 10 Counter.tsx: Lines 12 and 14

       "webRoot": "${workspaceFolder}/ClientApp",

Load webpage, click to go to counter page, and the web-page is stuck and VS Code doesn't show the breakpoint pause.

In the logs I see a Debugger.paused message from chrome but no Debugger.resume, and no message to the client telling it about the pause

image

vscode-debugadapter-0 - Copy.zip

When that happens if I open chrome dev tools I see: image

created time in 12 days

create barnchmicrosoft/vscode-js-debug

branch : runAfterCrash

created branch time in 15 days

PR opened microsoft/vscode-js-debug

Hardcode translations

Hardcode translations for VS until we get the real pipeline going

+1960 -0

0 comment

11 changed files

pr created time in 16 days

create barnchmicrosoft/vscode-js-debug

branch : hardcode_translations

created branch time in 16 days

Pull request review commentmicrosoft/vscode-js-debug

Handler hasher process exit

 const create = () => {     delete deferredMap[msg.id];     deferred?.resolve(msg);   });+  instance.on('exit', () => {+    Object.keys(deferredMap).forEach(msgId => {+      delete deferredMap[msgId];+      const deferred = deferredMap[msgId];+      deferred?.reject(new Error('hash.bundle.js process unexpectedly exited'));+    });

Added some retrying with a max retry count

digeff

comment created time in 17 days

push eventmicrosoft/vscode-js-debug

digeff

commit sha 41a9f3a859f05551f5b4b011c65acb0343a971b8

Retry hasher

view details

digeff

commit sha a341d518fb362b756bd6defa33fceb0130c0da5e

fix

view details

push time in 17 days

issue openedmicrosoft/vscode-js-debug

We should validate the responses of getting source-maps

While trying to debug: https://www.bing.com/ I get:

Could not read source map for https://www.bing.com/rp/ioAVnYYj8CxpiUPxW_EUQF5pvFY.br.js: Unexpected token  in JSON at position 0

Because getting the sourcemap at https://www.bing.com/rp/hooks.umd.js.map returns a 404 in xml format.

It's great that we are getting an error message already! :) We could improve this by saying that the GET request to get the source-map failed with a 404, and showing the response contents so we can see the error on the console.

created time in 17 days

pull request commentmicrosoft/vscode-js-debug

Improve user experience when content validation fails

@connor4312 If I understand correctly your suggestion, here it is: https://github.com/microsoft/vscode-js-debug/pull/539 Do you know how can I test that code?

digeff

comment created time in 17 days

PR opened microsoft/vscode-js-debug

Handler hasher process exit

Feedback from: https://github.com/microsoft/vscode-js-debug/pull/532

+8 -0

0 comment

1 changed file

pr created time in 17 days

create barnchmicrosoft/vscode-js-debug

branch : handle_hasher_exit

created branch time in 17 days

issue openeddotnet/runtime

Blazor debug proxy and Mono proxy should generate ETL events

For investigating performance issues it'd be great if Blazor debug proxy and Mono proxy generates ETL events for the main things that are happening (loading things, getting requests to set breakpoints, and the breakpoint can now be hit, etc...) so then we can use the ETL trace gathered by the VS Report a Problem tool to easily analyze performance issues

created time in 18 days

PR opened microsoft/vscode-js-debug

Fix angular long path issues in VS

Fix angular having absolute paths for all files in VS

+13 -6

0 comment

1 changed file

pr created time in 19 days

create barnchmicrosoft/vscode-js-debug

branch : fix_angular

created branch time in 19 days

issue openeddotnet/aspnetcore

Blazor debug proxy and Mono proxy should generate ETL events

For investigating performance issues it'd be great if Blazor debug proxy and Mono proxy generates ETL events for the main things that are happening (loading things, getting requests to set breakpoints, and the breakpoint can now be hit, etc...) so then we can use the ETL trace gathered by the VS Report a Problem tool to easily analyze performance issues

created time in 19 days

PR opened microsoft/vscode-js-debug

Improve user experience when content validation fails

Show an error message when content validation fails. Return undefined so other code that depends on this can work as expected.

This is in response of having several reports of this error from telemetry:

Error [ERR_IPC_CHANNEL_CLOSED]: Channel closed
    at ChildProcess.send (internal/child_process.js:678:16)
    at send (index.js:37:8)
    at Object.verifyFile (index.js:56:66)
    at Object.checkContentHash (sourceUtils.js:253:24)
    at new A (sources.js:92:50)
    at O.source [as addSource] (sources.js:511:24)
    at threads.js:912:19
+31 -7

0 comment

2 changed files

pr created time in 24 days

push eventmicrosoft/vscode-js-debug

digeff

commit sha c72cf5a95a1f5219505061d606ba3e194b6752d6

Handle error when content validation fails

view details

push time in 24 days

create barnchmicrosoft/vscode-js-debug

branch : contentHash

created branch time in 24 days

delete branch microsoft/nodejstools

delete branch : fix_webapp_v3

delete time in 25 days

PR opened microsoft/nodejstools

Make progress in WebApp debugging for v3

With this Fix the v3 debugger will not fail to Launch for node web apps (We are making some progress in the right direction)

I'm also passing the projectGuid so we can override launch.json parameters for Node.js proyects.

Open issues: I don't think that the current value for WebRoot will work for Chrome/Client debugging. We'll have to figure out what's the right value an update it.

+15 -2

0 comment

2 changed files

pr created time in 25 days

create barnchmicrosoft/nodejstools

branch : fix_webapp_v3

created branch time in 25 days

PR opened microsoft/vscode-js-debug

Fix logging logic when we don't have sourcemapurl

Handler was crashing when a sourceMapUrl wasn't specified

+2 -0

0 comment

1 changed file

pr created time in a month

create barnchmicrosoft/vscode-js-debug

branch : fix_logging_logic

created branch time in a month

push eventmicrosoft/vscode-js-debug

D

commit sha 1ccad440a62868d864a6fdd7ca51a76ee213ae3f

Kill chrome on tests

view details

push time in a month

push eventmicrosoft/vscode-js-debug

digeff

commit sha 65b000308ef8efd67d087b519f4d6a1699f76684

feat: don't print sourceMapUrls that are data (#509)

view details

digeff

commit sha 468ce6934605dc8f3273f4dd5e910d5231b6b5bc

fix: partial fix for unknown session (#511) * Partial fix for unknown session * Update src/cdp/connection.ts Co-authored-by: Connor Peet <connor@peet.io> Co-authored-by: Connor Peet <connor@peet.io>

view details

Connor Peet

commit sha cc84c6cabd20a2fc54c04bf2f199174657d3667d

fix: error on cancelled stackframes response Fixes #495

view details

Connor Peet

commit sha 88e380e64f5bac3a722f879a95793e2688bd4062

feat: preview the location of the breakpoint in perf selection See https://github.com/microsoft/vscode/issues/96473#issuecomment-638588819 Fixes https://github.com/microsoft/vscode-js-debug/issues/518 See https://github.com/microsoft/vscode/issues/99716

view details

Connor Peet

commit sha 9d78d45d0566dddaafa1a91ef59e99a8c119e10a

fix: narrow scope for focus tab action See #481

view details

Connor Peet

commit sha 0a6726ae65568b70c16878914fd9f65dca362522

feat: improve values copied and clipboard Fixes #476

view details

digeff

commit sha 14712fd9162cea9bacb9afd81d10c50c2fabf49e

Kill only the tab by default

view details

digeff

commit sha 912ebe3692d272002aa707ca837519e03e5a10f6

Applied feedback

view details

D

commit sha 5e76473cf7d1391e69ac205dd7387dd4b91418c7

Close connection when closing targets

view details

push time in a month

push eventmicrosoft/vscode-js-debug

D

commit sha 158e1326206d3e280af2a2cece2f469c8f6320d7

Close connection when closing targets

view details

push time in a month

Pull request review commentmicrosoft/vscode-js-debug

Kill only the tab by default

 export interface IChromiumLaunchConfiguration extends IChromiumBaseConfiguration    * If true, will start profiling soon as the page launches.    */   profileStartup: boolean;++  /**+   * Close whole browser or just the tab when cleaning up+   */+  cleanUp: 'wholeBrowser' | 'onlyTab' | null;

Removed

digeff

comment created time in a month

Pull request review commentmicrosoft/vscode-js-debug

Kill only the tab by default

 const chromeLaunchConfig: IDebugger<IChromeLaunchConfiguration> = {       description: refString('browser.profileStartup.description'),       default: true,     },+    cleanUp: {+      type: 'string',+      description: refString('browser.cleanUp.description'),+      default: null,+    },

Done

digeff

comment created time in a month

push eventmicrosoft/vscode-js-debug

digeff

commit sha 5bf436e5cca44249d24c28c7bf991fdb32988f13

Applied feedback

view details

push time in a month

push eventmicrosoft/vscode-js-debug

digeff

commit sha 21e9c77b162eff895f836f68a6e0618a189b8f83

Update src/cdp/connection.ts Co-authored-by: Connor Peet <connor@peet.io>

view details

push time in a month

PR opened microsoft/vscode-js-debug

Reviewers
Kill only the tab by default

Now we only kill the tab when the debugging sessions ends by default. I added an option to keep the existing functionality too in case someone prefers that one.

+41 -8

0 comment

6 changed files

pr created time in a month

push eventmicrosoft/vscode-js-debug

Connor Peet

commit sha b3f48fc213d098fc83ebf29e91cb06f4330a9a5e

fix: bad log message format in dap messages

view details

Connor Peet

commit sha 5e608d0f3589e667f8e54a19b4441e6d2937bc94

fix: update source-map library to remove codespaces incompatibility The main breaking changes are around wasm handling (which we don't deal with) and URL parsing (which we don't depend on and instead preserve all original URLs). Because of this I think the change is safe, and all tests pass locally. See: https://github.com/MicrosoftDocs/vsonline/issues/567

view details

Connor Peet

commit sha 32ff4220e39c70c5c547e62674ba875b7d9171fa

1.46.1

view details

Connor Peet

commit sha 5d4013e2e6ab1746b38d20e9e50e142e4a3d85b3

fix: stopOnEntry not working if another breakpoint was in file We apply an entrypoint break if there's any breakpoint in a file to deal with ts-node/babel-register. This caused the stopOnEntry to be skipped, since we didn't recognize that as a user-defined breakpoint. Fixes #515

view details

Connor Peet

commit sha 16be11689130f8e1e72704c0b8d7a3efea14406d

feat: log errors encountered when parsing sourcemaps Fixes #483

view details

Connor Peet

commit sha bc0517a50b467f9fe0c484d99d8f83cf5ea06516

fix: being too aggressive about detecting entrypoint at instrumentation bps Fixes #514

view details

Connor Peet

commit sha 1d4d9521087b54f2186a7172c532dbbee10a557f

fix: don't reattach to tabs after detaching from them Fixes #505

view details

Connor Peet

commit sha 5bfba74d8f4e33dde61f0a7f198c8ea140572e83

fix: detach from target in CDP when manually detaching target Works on #486

view details

Connor Peet

commit sha c951f0d604389b1da0117eefc372c5728686a676

fix: automatically unattach when there's no targets left Fixes #506

view details

Connor Peet

commit sha 53a710e1f589ae07bd40021da09e3d7defc3b1f4

fix: prevent pick from attaching to additional targets if initially only single available Fixes #508

view details

digeff

commit sha 7314b7cb66d5ef10ed01e5c95d5cdda407784e1e

Kill only the tab by default

view details

push time in a month

issue commentmono/mono

[blazor] [wasm] Debugger takes an exceptionally long time to attach

@floreseken To help us investigate this issue further, it would be really helpful if you can send us additional diagnostics information by using the Visual Studio Record feature of the Help -> Send Feedback -> Report a Problem wizard. To use the Record feature you'll have to:

  1. File a new problem
  2. In the "Attachments" step: 2.1. Click on Record 2.2. Select your instance of Visual Studio 2.3. Click Start recording 2.4. Launch the debugger with the 8 seconds issue, and record it while it happens. Wait until breakpoints start working. 2.5. Stop the recording 2.6. Submit the issue. 2.7. Paste the link of the new issue here so we can start investigating it right away

Thanks!

mkArtakMSFT

comment created time in a month

create barnchmicrosoft/vscode-js-debug

branch : killOnlyTab

created branch time in a month

issue commentdotnet/aspnetcore

Unable to debug Blazor app from VS

Thank you @clawton , that is very useful to know! :)

SIkebe

comment created time in a month

PR opened microsoft/vscode-js-debug

Partial fix for unknown session

I was able to reproduce the unknown session issue #486 . We were getting messages about a session after it has been disposed. I don't know if this solves all cases of unknown session or not.

+16 -1

0 comment

1 changed file

pr created time in a month

push eventmicrosoft/vscode-js-debug

digeff

commit sha 07e4900d6caa71d292daffa67c9824e09e155c2f

Partial fix for unknown session

view details

push time in a month

create barnchmicrosoft/vscode-js-debug

branch : partial_fix_unknown_session

created branch time in a month

issue commentmicrosoft/vscode-js-debug

Breakpoint doesn't hit on react redux application

Just to recap the information sent by chat, the breakpoint on line 11 works fine, the issue is when the breakpoint it set on line 10.

digeff

comment created time in a month

PR opened microsoft/vscode-js-debug

Don't print sourceMapUrls that are data

Don't print sourceMapUrls that are data

+8 -0

0 comment

1 changed file

pr created time in a month

create barnchmicrosoft/vscode-js-debug

branch : sourceMapUrl

created branch time in a month

PR opened microsoft/vscode-js-debug

Reviewers
Do not print sources in logs

Now we log this instead:

{"tag":"cdp.receive","timestamp":1591302982704,"metadata":{"connectionId":0,"message":{"id":28,"result":{"scriptSource":"<script source>"},"sessionId":"349604CB8C037F470A4BCAFCD223B94C"}},"level":0}
{"tag":"dap.send","timestamp":1591302982706,"metadata":{"connectionId":0,"objectToLog":{"seq":191,"type":"response","request_seq":5,"command":"source","success":true,"body":{"content":"<script source>","mimeType":"text/javascript"},"sessionId":"C9995BF646D2938A47CC5EE7A5673E48"}},"level":0}

+16 -2

0 comment

2 changed files

pr created time in a month

create barnchmicrosoft/vscode-js-debug

branch : dont_log_sources

created branch time in a month

pull request commentmicrosoft/vscode-js-debug

Fix undefined function description

Sounds good! Closing

digeff

comment created time in a month

PR closed microsoft/vscode-js-debug

Fix undefined function description

We got telemetry that description is sometimes undefined on formatFunctionDescription: TypeError: Cannot read property 'replace' of undefined at formatFunctionDescription (index.js:251:10) at renderPreview (index.js:88:16) at renderObjectPreview (index.js:176:25) at renderPreview (index.js:91:16) at previewRemoteObjectInternal (index.js:61:11) at Object.previewRemoteObject (index.js:48:20) at _createObjectVariable (variables.js:417:31) at _createVariable (variables.js:388:25) at _createVariablesForProperty (variables.js:366:30) at _getObjectProperties (variables.js:276:37)"

+6 -0

2 comments

1 changed file

digeff

pr closed time in a month

PR opened microsoft/vscode-js-debug

Fix undefined function description

We got telemetry that description is sometimes undefined on formatFunctionDescription: TypeError: Cannot read property 'replace' of undefined at formatFunctionDescription (index.js:251:10) at renderPreview (index.js:88:16) at renderObjectPreview (index.js:176:25) at renderPreview (index.js:91:16) at previewRemoteObjectInternal (index.js:61:11) at Object.previewRemoteObject (index.js:48:20) at _createObjectVariable (variables.js:417:31) at _createVariable (variables.js:388:25) at _createVariablesForProperty (variables.js:366:30) at _getObjectProperties (variables.js:276:37)"

+6 -0

0 comment

1 changed file

pr created time in a month

create barnchmicrosoft/vscode-js-debug

branch : undefined_function_description

created branch time in a month

PR opened microsoft/vscode-js-debug

Update ws errors to be actual errors when possible

From the telemetry it seems that we are getting errors on ws.addEventListener('error', reject) that are not of the class error. Documentation says we get an ErrorEvent which is not an error, see https://github.com/websockets/ws/blob/2e5c01f5b550ae4171d127b0b707ebcec5925cc3/lib/event-target.js#L87

+1 -1

0 comment

1 changed file

pr created time in a month

push eventmicrosoft/vscode-js-debug

D

commit sha 1eca018110fcee442716db99fb093f1df14453f0

Update ws errors to be actual errors when possible

view details

push time in a month

create barnchmicrosoft/vscode-js-debug

branch : fix_ws_errors

created branch time in a month

push eventmicrosoft/vscode-js-debug

D

commit sha 11363e89455d19a1733dcb89ca819701383a3c4a

Applied feedback

view details

push time in a month

Pull request review commentmicrosoft/vscode-js-debug

Fix possible race condition

 export class Thread implements IVariableStoreDelegate {       return;     } -    this._pausedDetails = this._createPausedDetails(event);+    // We store pausedDetails in a local variable to avoid race conditions while awaiting this._smartStepper.shouldSmartStep+    const pausedDetails = (this._pausedDetails = this._createPausedDetails(event));     if (!shouldPause) {       this.resume();       return;     } -    if (await this._smartStepper.shouldSmartStep(this._pausedDetails)) {

Changed

digeff

comment created time in a month

push eventmicrosoft/vscode-js-debug

D

commit sha a6456253c5cbbc9ab56b1a6792825c5ab95053e5

Applied feedback

view details

push time in a month

issue commentmicrosoft/vscode-js-debug

Error: Unknown session id: <session-id> while processing: Inspector.targetReloadedAfterCrash

A lot of our users are hitting this issue. Raising to vs-p1

digeff

comment created time in a month

PR opened microsoft/vscode-js-debug

Fix reduce failing when array is empty

We got this unhandled rejection from telemetry:

TypeError: Reduce of empty array with no initial value at Array.reduce (<anonymous>) at Object.formatAsTable (index.js:381:58) at k.slot [as _onConsoleMessage] (threads.js:791:41) at threads.js:341:17

Using 0 as an initial seed won't change the value when the array has contents, and will avoid the crash when it's empty.

I'm assuming that columnsWidth = 0 makes sense if we don't have any columns.

+1 -1

0 comment

1 changed file

pr created time in a month

create barnchmicrosoft/vscode-js-debug

branch : fix_reduce_issue

created branch time in a month

PR opened microsoft/vscode-js-debug

Fix possible race condition

In telemetry we got:

TypeError: Invalid value used as weak map key at WeakMap.set (<anonymous>) at k._onPaused (threads.js:511:34)

My guess is that while we await this._smartStepper.shouldSmartStep(pausedDetails) For some reason the app resumes (maybe the user reloads the page, or uses Chrome DevTools), so this._pausedDetails becomes undefined and this._pausedDetailsEvent.set(pausedDetails, event); fails because undefined can't be a key of a WeakMap.

Assuming that's happening, this fix should address that issue

+35 -15

0 comment

2 changed files

pr created time in a month

create barnchmicrosoft/vscode-js-debug

branch : fix_possible_race_condition

created branch time in a month

issue commentdotnet/aspnetcore

Unable to debug Blazor app from VS

@clawton It doesn't seem like enabling the logs worked. I've just updated the instruction to fix some formatting issues, and change some "projects" to "solution" to make it work better for hosted projects. Can you take another run at enabling the logs to see if these updated instructions work? Thanks!

SIkebe

comment created time in a month

issue commentdotnet/aspnetcore

Unable to debug Blazor app from VS

@clawton Can you please follow these steps so the Blazor Debug Proxy generates additional logs, to see if they give us any actionable information:

  1. Create a nuget.config file with the following contents next to the project's root: <?xml version="1.0" encoding="utf-8"?> <configuration> <packageSources> <!--To inherit the global NuGet package sources remove the <clear/> line below --> <clear /> <add key="nuget" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-dotnet-aspnetcore-9b98da36/nuget/v3/index.json" /> </packageSources> </configuration>

  2. Open a command prompt in the solution root folder and run the following commands: dotnet nuget locals --clear all

    // This command will fail to find some packages. That's fixed by the new command. dotnet restore dotnet restore -s https://api.nuget.org/v3/index.json

  3. Create a file named blazor-debugproxysettings.json on the project root with these contents (For hosted projects please this on the server project folder): { "Logging": { "LogLevel": { "Default": "Debug" } } }

  4. Logs will appear on the Visual Studio output window in the: "<BlazorApp> - ASP.NET Core Web Server" section. Please upload the logs so we can take a look at them.

  5. After you've obtained the logs, delete the nuget.config so restore will continue to work in the future

Thanks

SIkebe

comment created time in a month

issue commentdotnet/aspnetcore

Unable to debug Blazor app from VS

@clawton Just to help us rule-out some possible causes, can you try the following:

  1. Create a new standard ASP.NET project: ASP.NET Core Web Application -> Web Application
  2. In the project, in the file wwwroot/js/site.js add: console.log("Test"), set a breakpoing on that line
  3. Enable the new JavaScript debugger that we use for debugging Blazor also for standard ASP.NET projects by going to Tools -> Options -> Debugging -> General -> “Enable using the multi-target JavaScript debugger…”
  4. Start debugging the project with F5 and confirm whether everything works and the breakpoint is hit

Thank you for your patience and assistance :)

SIkebe

comment created time in a month

issue commentdotnet/aspnetcore

Unable to debug Blazor app from VS

@clawton It does look like the same issue. If you can, I'd try setting the environment variable as a system wide environment variable and restarting VS to see if that works.

SIkebe

comment created time in a month

issue commentdotnet/aspnetcore

Unable to debug Blazor app from VS

@clawton Did you try the NO_PROXY workaround? Can you share with me your C:\Users<username>\AppData\Local\Temp\vscode-chrome-debug.txt log just after hitting this issue so I can confirm whether you are running into the same issue or a different issue?

SIkebe

comment created time in a month

issue commentdotnet/aspnetcore

Unable to debug Blazor app from VS

@ergwun Have you tried setting NO_PROXY environment variable to localhost or 127.0.0.1 ?

SIkebe

comment created time in a month

push eventmicrosoft/vscode-js-debug

D

commit sha 023a7897e439b373c25ef8a8867947f4665a03c3

Fix format

view details

push time in a month

issue closedmicrosoft/vscode-js-debug

Evaluate fails due to: Cannot read property 'objectId' of undefined

We are getting a lot of telemetry where the evaluate requests fails due to: Cannot read property 'objectId' of undefined

This happens on this line https://github.com/microsoft/vscode-js-debug/blob/master/src/adapter/variables.ts#L45 because object is null.

Stack trace:

TypeError: Cannot read property 'objectId' of undefined
    at new p (variables.js:33:32)
    at _.createVariable (variables.js:188:41)
    at k.result [as evaluate] (threads.js:296:46)
    at a._onMessage (connection.js:140:27)"

closed time in a month

digeff

issue commentmicrosoft/vscode-js-debug

Evaluate fails due to: Cannot read property 'objectId' of undefined

This seems to happen on Blazor only, so re-filed the bug there: https://github.com/dotnet/aspnetcore/issues/22375

digeff

comment created time in a month

issue openeddotnet/aspnetcore

Blazor DebugProxy returns undefined in Debugger.evaluateOnCallFrame or Runtime.evaluate

Describe the bug

We got stack traces in telemetry (see https://github.com/microsoft/vscode-js-debug/issues/485) which indicates that Blazor is returning undefined in the result field of Debugger.evaluateOnCallFrame or Runtime.evaluate. In the CDP protocol that field is not marked as optional, so it should never be undefined.

To Reproduce

We got this stack trace from telemetry, so we don't know how to reproduce this issue

Further technical details

Debugging Blazor in VS

created time in a month

push eventmicrosoft/vscode-js-debug

D

commit sha ea08382bffb9736f902e99ab09bd6c80b4d9e8a0

Applied feedback

view details

push time in a month

Pull request review commentmicrosoft/vscode-js-debug

Fix hitting breakpoints on first line on VS

 export class Thread implements IVariableStoreDelegate {         };       default:         if (event.hitBreakpoints && event.hitBreakpoints.length) {-          const isStopOnEntry =+          let isStopOnEntry = false; // By default we assume breakpoints aren't stop on entry+          if (             event.hitBreakpoints.length === 1 &&-            this._delegate.entryBreakpointId === event.hitBreakpoints[0];+            this._delegate.entryBreakpoint?.cdtpId === event.hitBreakpoints[0]+          ) {+            isStopOnEntry = true; // But if it matches the entry breakpoint id, then it's probably stop on entry+            const entryBreakpointAbsolutePath = fileUrlToAbsolutePath(+              this._delegate.entryBreakpoint.path,+            );+            const entryBreakpointSource = this._sourceContainer.source({+              path: entryBreakpointAbsolutePath,+            });++            if (entryBreakpointSource !== undefined) {+              const entryBreakpointLocations = this._sourceContainer.currentSiblingUiLocations({+                lineNumber: 1,+                columnNumber: 1,+                source: entryBreakpointSource,+              });++              // But if there is a user breakpoint on the same location that the stop on entry breakpoint, then we consider it an user breakpoint

In the cases I tested it just contains the entry breakpoint. I wrote the code as-is in case we run into a case where we find more than 1 breakpoint here.

digeff

comment created time in a month

issue commentdotnet/aspnetcore

Blazor -Blazor Web Assembly- Unable to Launch debug adapter following Windows password change

@timcromarty Can you please upload %TEMP%\vscode-chrome-debug.txt right after this happens? (The log gets overwritten each time you launch the debugger)

timcromarty

comment created time in a month

push eventmicrosoft/vscode-js-debug

D

commit sha 81ea284d526894def614f0dff9bc2f35f9a81159

Fix stack trace

view details

push time in a month

push eventmicrosoft/vscode-js-debug

Connor Peet

commit sha c1777e1d2813544cea138c4af6a98e5fd3107cc8

chore: set usePreview to null to distinguish for insiders usage

view details

Connor Peet

commit sha b2a9a31791da8d31e63dde4ab0b9a3bf0ada77dd

docs: improve docs and types around address/port, rm duplicate node attach option

view details

Connor Peet

commit sha 9dea2a09c44b2470caea59b59d7d45fd958a7947

Revert "chore: set usePreview to null to distinguish for insiders usage" This reverts commit c1777e1d2813544cea138c4af6a98e5fd3107cc8.

view details

Connor Peet

commit sha 9547ac0681f3e8ac532f5e58dd6de23957b53edd

feat: use the page title as session titles by default See #479

view details

Connor Peet

commit sha 6006f796f05a5092fd41f5517d05e0a0662f89e9

refactor: make child sessions have the same debug type as the parent Additionally, add a 'reveal tab' action. Fixes #481, see #479

view details

Connor Peet

commit sha 61f45d3d3ddffe6a5de88cb66429aa9bcbdcce75

fix: don't clear the console when execution contexts are destroyed See #479

view details

Connor Peet

commit sha 2db14f4b166ca24ff54b5b41a1e30560db5bdd60

feat: add targetSelection to allow picking single tabs to connect to See #479

view details

Connor Peet

commit sha a8256d457031d3ca892c2f2612b4b4c6db45761b

fix: expand debug types in contributions correctly

view details

Connor Peet

commit sha 9ebda766c98589168a4b01963919f731e1f13107

fix: update tests to name changes

view details

Connor Peet

commit sha b6e46d69683eb28b8913f02c970d0ae24feca97f

fix: use webRoot for the rootPath when appropriate

view details

Connor Peet

commit sha 7655a6ff97c84282c3935caedad84a586b85ef8e

fix: name threads dynamically, fix tests

view details

Connor Peet

commit sha ae3323a2aa1bc2726619afd6c970126c8ec849c3

wd refactor

view details

Connor Peet

commit sha b3f261d4efec53018fd8e6fa6e34be48e208777a

fix: run the watchdog in the parent process for attachment Fixes https://github.com/microsoft/vscode/issues/96995

view details

Connor Peet

commit sha fed367b5468b13e57d50bb9cc49b7686c3eef61f

fix: correct strings for localization https://github.com/microsoft/vscode/issues/98585

view details

Connor Peet

commit sha 482e8293bc085214c809ba4d100557d5afe6e2ed

fix: allow launching npm scripts from nested package.json's Fixes https://github.com/microsoft/vscode/issues/98481

view details

Connor Peet

commit sha 1b048891a9ef947565ba3cd38aff753ae43d9d83

fix: update tests

view details

digeff

commit sha 4320005cdc08fd9a146a3792bce1d18eb00ce10a

Fix hitting breakpoints on first line on VS

view details

digeff

commit sha fc00b3afbf6758c0fdab25b64c162bc05b978c24

Applied feedback

view details

D

commit sha ddaa224bb53c0784590e7da72d3d3de59c8fa4d5

Add test for breakpoint on first line with stop on entry on .tsx

view details

push time in a month

push eventmicrosoft/vscode-js-debug

Connor Peet

commit sha 99aaa3ae5762c8f898aa9b2460f93e8df222fc21

feat: contribute node.js debug terminal as a dynamic configuration For https://github.com/microsoft/vscode/issues/98054

view details

digeff

commit sha efcfdbafde0495b8878001b1bbe404a580dba1fb

Fix hitting breakpoints on first line on VS

view details

digeff

commit sha c06f6c393e8d23dfbd594090fa67b865d53a61ec

Applied feedback

view details

D

commit sha 31de731baf5193368183162a7a9b3503c5f96f5f

Add test for breakpoint on first line with stop on entry on .tsx

view details

push time in a month

push eventmicrosoft/vscode-js-debug

D

commit sha 1d3856033d571e698d9d413051b4b28e08079912

Add tests

view details

push time in a month

issue commentmicrosoft/vscode-js-debug

Evaluate fails due to: Cannot read property 'objectId' of undefined

This is from telemetry, I don't know how to reproduce this :(

digeff

comment created time in a month

issue openedmicrosoft/vscode-js-debug

Error: Unknown session id: <session-id> while processing: Inspector.targetReloadedAfterCrash

We got telemetry that the debug adapter is seeing a lot of this error:

Error: Unknown session id: <session-id> while processing: Inspector.targetReloadedAfterCrash
    at t.default._onMessage (connection.js:47:19)
    at call (connection.js:19:61)
    at t.EventEmitter.fire (events.js:36:27)
    at T.call (webSocketTransport.js:21:33)
    at T.r (event-target.js:120:16)
    at T.emit (events.js:210:5)
    at e.exports.R (websocket.js:801:20)
    at e.exports.emit (events.js:210:5)
    at e.exports.dataMessage (receiver.js:436:14)
    at e.exports.getData (receiver.js:366:17)

This also happens while processing these other events, and some request responses too:

  • Debugger.scriptParsed
  • Mono.runtimeReady
  • Runtime.consoleAPICalled
  • Inspector.targetCrashed
  • Inspector.detached

Can this be causing a detrimental experience to the users?

created time in a month

issue commentmicrosoft/vscode-js-debug

Error parsing mappings (code 4): invalid base 64 character while parsing a VLQ

@connor4312 We got some telemetry that some stackTrace requests are also failing with this error: Error: Error parsing mappings (code 4): invalid base 64 character while parsing a VLQ at l._parseMappings (source-map-consumer.js:360:13) at l._getMappingsPtr (source-map-consumer.js:315:12) at f (source-map-consumer.js:510:14) at Object.withMappingCallback (wasm.js:95:11) at l.originalPositionFor (source-map-consumer.js:508:16) at t.SourceMap.originalPositionFor (sourceMap.js:61:30) at O.getOptiminalOriginalPosition (sources.js:491:31) at O._sourceMappedUiLocation (sources.js:448:28) at O.preferredUiLocation (sources.js:394:39)

digeff

comment created time in a month

issue openedmicrosoft/vscode-js-debug

Evaluate fails due to: Cannot read property 'objectId' of undefined

We are getting a lot of telemetry where the evaluate requests fails due to: Cannot read property 'objectId' of undefined

This happens on this line https://github.com/microsoft/vscode-js-debug/blob/master/src/adapter/variables.ts#L45 because object is null.

Stack trace:

TypeError: Cannot read property 'objectId' of undefined
    at new p (variables.js:33:32)
    at _.createVariable (variables.js:188:41)
    at k.result [as evaluate] (threads.js:296:46)
    at a._onMessage (connection.js:140:27)"

created time in a month

issue openedmicrosoft/vscode-js-debug

Error parsing mappings (code 4): invalid base 64 character while parsing a VLQ

We got 5623 unhandled rejections in VS with that message. If we can't parse the sourcemap, there is a possibility that we won't be able to bind some breakpoints. It'd be great if we could print some message in the console, or similar, and also set the status of any unbound breakpoint to say: "This might be caused because source-map aaa.js.map couldn't be parsed because...."

These are the stack traces that we got: [ Error: Error parsing mappings (code 4): invalid base 64 character while parsing a VLQ at l._parseMappings (source-map-consumer.js:360:13) at l._getMappingsPtr (source-map-consumer.js:315:12) at f (source-map-consumer.js:510:14) at Object.withMappingCallback (wasm.js:95:11) at l.originalPositionFor (source-map-consumer.js:508:16) at t.SourceMap.originalPositionFor (sourceMap.js:61:30) at O.getOptiminalOriginalPosition (sources.js:491:31) at O._sourceMappedUiLocation (sources.js:448:28) at O.preferredUiLocation (sources.js:394:39)", "Error: Error parsing mappings (code 4): invalid base 64 character while parsing a VLQ at l._parseMappings (source-map-consumer.js:360:13) at l._getMappingsPtr (source-map-consumer.js:315:12) at f (source-map-consumer.js:510:14) at Object.withMappingCallback (wasm.js:95:11) at l.originalPositionFor (source-map-consumer.js:508:16) at t.SourceMap.originalPositionFor (sourceMap.js:61:30) at O.getOptiminalOriginalPosition (sources.js:491:31) at O._sourceMappedUiLocation (sources.js:448:28) at O.uiLocation [as preferredUiLocation] (sources.js:394:39) at k._onConsoleMessage (threads.js:777:17)", "Error: Error parsing mappings (code 4): invalid base 64 character while parsing a VLQ at l._parseMappings (source-map-consumer.js:360:13) at l._getMappingsPtr (source-map-consumer.js:315:12) at f (source-map-consumer.js:510:14) at Object.withMappingCallback (wasm.js:95:11) at l.originalPositionFor (source-map-consumer.js:508:16) at t.SourceMap.originalPositionFor (sourceMap.js:61:30) at O.getOptiminalOriginalPosition (sources.js:491:31) at O._sourceMappedUiLocation (sources.js:448:28) at O.preferredUiLocation (sources.js:394:39) at runNextTicks (internaltask_queues.js:58:5)", "Error: Error parsing mappings (code 4): invalid base 64 character while parsing a VLQ at l._parseMappings (source-map-consumer.js:360:13) at l._getMappingsPtr (source-map-consumer.js:315:12) at f (source-map-consumer.js:510:14) at Object.withMappingCallback (wasm.js:95:11) at l.originalPositionFor (source-map-consumer.js:508:16) at t.SourceMap.originalPositionFor (sourceMap.js:61:30) at O.getOptiminalOriginalPosition (sources.js:491:31) at O._sourceMappedUiLocation (sources.js:448:28) at O.uiLocation [as preferredUiLocation] (sources.js:394:39) at a (smartStepping.js:9:11)" ]

created time in 2 months

issue commentdotnet/aspnetcore

Visual Studio 2019 attach to Blazor WebAssembly App browser - A debugger operation is taking a long time

@AlexeyBoiko We haven't had a chance to fix the issue yet. We are planning on doing it during version 16.7. I'll let you know when the fix is available for you to test.

AlexeyBoiko

comment created time in 2 months

issue commentdotnet/aspnetcore

Unable to debug Blazor app from VS

@SIkebe : To help us isolate and diagnose the issue, could you please:

  1. Create a new standard ASP.NET project: ASP.NET Core Web Application -> Web Application
  2. In the project, in the file wwwroot/js/site.js add: console.log("Test"), set a breakpoing on that line
  3. Enable the new JavaScript debugger that we use for debugging Blazor also for standard ASP.NET projects by going to Tools -> Options -> Debugging -> General -> “Enable using the multi-target JavaScript debugger…”
  4. Start debugging the project with F5 and confirm whether everything works and the breakpoint is hit
  5. If something doesn't work, please send us the logs at C:\Users<username>\AppData\Local\Temp\vscode-chrome-debug.txt again

Thanks!

SIkebe

comment created time in 2 months

push eventmicrosoft/vscode-js-debug

D

commit sha ae755ce6ae732c17202d68a8e93d344f5b1009a1

Add test for breakpoint on first line with stop on entry on .tsx

view details

push time in 2 months

more