diegohaz ( Haz )

Thank you for opening an issue. We'll get back to you as soon as we can. Please, consider supporting us on Open Collective. We give a special attention to issues opened by backers.

If you use Reakit at work, you can also ask your company to sponsor us :heart:. <link>

smacintyre

comment created time in 10 hours

issue openedreakit/reakit

When Button is disabled, it sets style="pointer-events: none;"

🐛 Bug report

Current behaviour

Currently, when Button has disabled={true} set, it adds a style property to the element: style="pointer-events: none;" -- this overrides the cursor CSS set for the disabled state.

The current document says that Reakit elements are unstyled by default, but this is incorrect here.

Steps to reproduce the bug

See: https://codesandbox.io/s/frosty-waterfall-uf4c8?file=/index.js

Expected behavior

Reakit shouldn't set the style property on the button by default, as per the docs.

Possible solutions

Stop setting the style property in the default setup when the button is disabled
If some users depend on this functionality, pass a prop to optionally enable the current behaviour
Alternately document when Reakit adds styles with the default config and document how to override this behaviour

Environment

Please, run the command below inside your project directory.

$ npx envinfo --system --binaries --browsers --npmPackages "{react*,reakit*}"

  System:
    OS: Linux 5.4 Ubuntu 20.04.1 LTS (Focal Fossa)
    CPU: (16) x64 Intel(R) Xeon(R) CPU
    Memory: 862.39 MB / 62.81 GB
    Container: Yes
    Shell: 5.0.17 - /bin/bash
  Binaries:
    Node: 14.16.0 - ~/.nvm/versions/node/v14.16.0/bin/node
    Yarn: 1.22.10 - ~/.nvm/versions/node/v14.15.5/bin/yarn
    npm: 6.14.11 - ~/.nvm/versions/node/v14.16.0/bin/npm
  npmPackages:
    react: ^17.0.1 => 17.0.1 
    react-dom: ^17.0.1 => 17.0.1 
    react-hook-form: ^6.15.1 => 6.15.1 
    react-router: ^5.2.0 => 5.2.0 
    react-router-dom: ^5.2.0 => 5.2.0 
    react-scripts: ^4.0.0 => 4.0.2 
    react-select-event: ^5.1.0 => 5.1.0 
    reakit: ^1.3.5 => 1.3.5

created time in 10 hours

starteddiegohaz/rest

started time in 12 hours

starteddiegohaz/rest

started time in 15 hours

starteddiegohaz/constate

started time in 16 hours

starteddiegohaz/constate

started time in 16 hours

starteddiegohaz/constate

started time in 19 hours

starteddiegohaz/constate