profile
viewpoint
David Flemström dflemstr @spotify Stockholm, Sweden

10bestdesign/jqvmap 1760

jQuery Vector Map Library

dflemstr/assignment-template 3

A LaTeX assignment template

dflemstr/chfft 3

Chalharu's Fastest Fourier Transform crate for Rust.

dflemstr/box 2

A web application for managing PND files

dflemstr/CraftBukkit 1

The Minecraft Server Mod API Implementation

dflemstr/archlinuxarm-abs 0

PKGBUILDs modified to build on Arch Linux ARM

pull request commentbackstage/backstage

Add pagerduty config to helm chart

⚠️ No Changeset found

Latest commit: d298d506390e84c93051f293acd994c6b620bcf1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

<details><summary>This PR includes no changesets</summary>

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

</details>

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

dtuite

comment created time in 14 minutes

PR opened backstage/backstage

Add pagerduty config to helm chart

This allows Helm chart users to set the PAGERDUTY_TOKEN via the values.yaml file.

+2 -0

0 comment

2 changed files

pr created time in 14 minutes

starteddflemstr/rq

started time in an hour

Pull request review commentbackstage/backstage

Update Footer.js

 class Footer extends React.Component {             <a href={this.props.config.fossWebsite}>               Open Source @ {this.props.config.organizationName}             </a>+      +      <a href="https://engineering.atspotify.com/">Spotify Engineering Blog</a>+      </a>++      <a href="https://developer.spotify.com/">Spotify for Developers</a>+</a>+      

See https://github.com/cncf/foundation/blob/master/website-guidelines.md

AlleyWei

comment created time in 4 hours

created tagdrone-os/drone

tagv0.13.1

CLI utility for Drone, an Embedded Operating System.

created time in 4 hours

push eventdrone-os/drone

Valentine Valyaeff

commit sha 65fc39c74fdb8b8f06769abdcd1b20041e6c4573

Move all rustflags to .cargo/config

view details

Valentine Valyaeff

commit sha b879f119f80d5187b827c85696c8f6067beecf74

Deprecate `drone env`

view details

Valentine Valyaeff

commit sha b72046fd241c63773f01a41fee1c9d6448be398c

Version bump

view details

push time in 4 hours

PR merged drone-os/drone

Streamline RUSTFLAGS

Make new projects generated by drone new more IDE-friendly by moving all RUSTFLAGS configuration to .cargo/config.

One minor drawback of this change is that some configuration options are duplicated within .cargo/config file because of cargo issue https://github.com/rust-lang/cargo/issues/5376. Also the compile target is stored in both .cargo/config and Justfile.

+51 -35

0 comment

10 changed files

valff

pr closed time in 4 hours

PR closed drone-os/drone

Modify .cargo/config template to contain target and flags

.cargo/config will now contain the correct target and the needed flags used by Drone. This is helpful information for rust-analyzer or RLS.

+22 -5

2 comments

3 changed files

thibautvdv

pr closed time in 4 hours

pull request commentdrone-os/drone

Modify .cargo/config template to contain target and flags

Closing in favour of https://github.com/drone-os/drone/pull/21.

thibautvdv

comment created time in 4 hours

PR opened drone-os/drone

Streamline RUSTFLAGS

Make new projects generated by drone new more IDE-friendly by moving all RUSTFLAGS configuration to .cargo/config.

One minor drawback of this change is that some configuration options are duplicated within .cargo/config file because of cargo issue https://github.com/rust-lang/cargo/issues/5376. Also the compile target is stored in both .cargo/config and Justfile.

+51 -35

0 comment

10 changed files

pr created time in 4 hours

create barnchdrone-os/drone

branch : streamline-rustflags

created branch time in 4 hours

Pull request review commentbackstage/backstage

Update Footer.js

 class Footer extends React.Component {             <a href={this.props.config.fossWebsite}>               Open Source @ {this.props.config.organizationName}             </a>+      +      <a href="https://engineering.atspotify.com/">Spotify Engineering Blog</a>+      </a>++      <a href="https://developer.spotify.com/">Spotify for Developers</a>+</a>+      

Not sure we can actually put that here? The microsite is supposed to be vendor neutral

AlleyWei

comment created time in 4 hours

Pull request review commentbackstage/backstage

Update Footer.js

 /*+* Made with <3 at Spotify+

Klio is owned by Spotify, but Backstage is not, so I don't think we add that https://backstage.io

AlleyWei

comment created time in 4 hours

push eventbackstage/backstage

Himanshu Mishra

commit sha dae4f39838c9fa35bd8a6ef2fac91d9f13cc527a

techdocs: Add changeset for all three packages

view details

push time in 4 hours

push eventbackstage/backstage

Himanshu Mishra

commit sha 435847fb3ba4a11e47dd9a1995bebe2e5e5dbfd5

techdocs: Add changeset for all three packages

view details

push time in 4 hours

push eventbackstage/backstage

Himanshu Mishra

commit sha 72367946cb96c1d8fe85c7b26f25859db9971d7e

techdocs: Add changeset for all three packages

view details

push time in 4 hours

push eventbackstage/backstage

Himanshu Mishra

commit sha 372160ede54bf3179c6b2e890e2ba6c420e1e60c

Update README of all three techdocs packages/plugins

view details

Himanshu Mishra

commit sha e6848f2b9fe7671d2f5bb911127bcfb2b0a3b84f

techdocs: Add changeset for all three packages

view details

push time in 4 hours

pull request commentbackstage/backstage

feat(storybook): upgrade storybook

⚠️ No Changeset found

Latest commit: 19dc52366e257fbf8dc0182208b6ccc655e79edf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

<details><summary>This PR includes no changesets</summary>

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

</details>

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

virtuoushub

comment created time in 5 hours

PR opened backstage/backstage

feat(storybook): upgrade storybook

Upgrade to https://github.com/storybookjs/storybook/releases/tag/v6.1.10

Hey, I just made a Pull Request!

<!-- Please describe what you added, and add a screenshot if possible. That makes it easier to understand the change so we can :shipit: faster. -->

:heavy_check_mark: Checklist

<!--- Please include the following in your Pull Request when applicable: -->

  • [ ] A changeset describing the change and affected packages. (more info)
  • [ ] Added or updated documentation
  • [ ] Tests for new functionality and regression tests for bug fixes
  • [ ] Screenshots attached (for UI changes)
+1264 -621

0 comment

3 changed files

pr created time in 5 hours

Pull request review commentbackstage/backstage

Update Footer.js

 /*+* Made with <3 at Spotify+

We need to add this in the same way that it appears here: https://klio.io/

Where can I add it so it'll appear?

AlleyWei

comment created time in 5 hours

Pull request review commentbackstage/backstage

Update Footer.js

 class Footer extends React.Component {             <a href={this.props.config.fossWebsite}>               Open Source @ {this.props.config.organizationName}             </a>+      +      <a href="https://engineering.atspotify.com/">Spotify Engineering Blog</a>+      </a>++      <a href="https://developer.spotify.com/">Spotify for Developers</a>+</a>+      

Will do, thank you.

AlleyWei

comment created time in 5 hours

push eventbackstage/backstage

Himanshu Mishra

commit sha 17cab77fd2f2acf4236e1bafd78b817455fcbf92

techdocs-common: Add tests for google publisher and some more

view details

push time in 5 hours

pull request commentbackstage/backstage

Slightly more padding in dense tables

Still a Draft PR @Fox32 😎I was expecting this to be shot down 😅

stefanalund

comment created time in 10 hours

push eventbackstage/backstage

Himanshu Mishra

commit sha ff3dd9c02b7796daae1ca5974c001f59c3422f45

create-app: Add new techdocs default configs

view details

push time in 12 hours

issue commentbackstage/backstage

Multiple entities incorrectly show to be registered from a sample catalog info YAML

(Side note - we actually should reject unregistration of the bootstrap location as well, since it's part of the static config)

See #3398

adamdmharvey

comment created time in 12 hours

issue commentbackstage/backstage

Multiple entities incorrectly show to be registered from a sample catalog info YAML

(Side note - we actually should reject unregistration of the bootstrap location as well, since it's part of the static config)

adamdmharvey

comment created time in 12 hours

issue commentbackstage/backstage

Multiple entities incorrectly show to be registered from a sample catalog info YAML

Oh, this is a bug in that feature. The outcome if you followed through should be that it rejects the registration because it would lead to a duplicate. If it doesn't, then that's another separate bug too :)

In my opinion, what your interface should have told you, is that you can't do that because there's already an entity with that kind+namespace+name and you need to either rename the new entity or unregister the previous one.

And if you tried to do THAT last thing, the interface might tell you that it shares a location with a lot of other entities, because they all did come from the bootstrap location. And you register/unregister locations (which spawn entities) - not individual entities.

adamdmharvey

comment created time in 12 hours

push eventbackstage/backstage

Himanshu Mishra

commit sha a212e431425ed93d4214c7c0c9608b5d163f21ce

techdocs: Add JSON Schema config Show better error if techdocs.builder is set to 'ci' and if no docs are found. Return 404 from googleStorage client when a file is not found.

view details

push time in 12 hours

issue commentbackstage/backstage

Multiple entities incorrectly show to be registered from a sample catalog info YAML

I think we had something similar before. The reason why you get "all" entities is that they are all part of the bootstrap location.

adamdmharvey

comment created time in 12 hours

Pull request review commentbackstage/backstage

[Cost Insights] Add support for multiple types of entity cost breakdown

 export interface Entity {   An entity could be atomic or composite. An atomic entity is indivisible   and cannot be broken into sub-entities. -  A composite entity can be broken down recursively into sub-entities-  that generate cost **over the same time period**. All costs must sum to the root cost.+  A composite entity is divided into sub-entities that account for portions+  of the total cost **over the same time period**. The root entity is+  expected to only have _one_ Record consisting of the sub-entities to display+  in the product panel (keyed by the entity type, such as "service" for

I composed a commit-message haiku for this amazing spot ❤️

timbonicus

comment created time in 19 hours

more