profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/dfarrell07/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Daniel Farrell dfarrell07 Red Hat Raleigh, NC https://wiki.opendaylight.org/view/User:Dfarrell07 Current: K8s multicluster networking. Recent: OpenDaylight Board/TSC/PTL/committer, LFN TAC, OPNFV PTL, CentOS NFV committer.

dfarrell07/puppet-opendaylight 12

Moved: https://git.opendaylight.org/gerrit/gitweb?p=integration/packaging/puppet-opendaylight.git;a=tree

dfarrell07/ansible-opendaylight 9

Moved: https://git.opendaylight.org/gerrit/gitweb?p=integration/packaging/ansible-opendaylight.git;a=tree

dfarrell07/401-project2 4

Client-server file transfer protocol that runs on UDP and adds reliable data transfer via Go-Back-N.

dfarrell07/dotfiles 3

Configuration files

clholgat/iTrust 1

This thing for class

dfarrell07/CBenchF 1

General framework for performance testing SDN controllers

dfarrell07/csc517p1 1

Project 1 for CSC517 at NCSU

dfarrell07/odl_rpm 1

Scratch repo for RPM of OpenDaylight

dfarrell07/opendaylight-systemd 1

OpenDaylight systemd unit file

dfarrell07/P2P-for-RFCs 1

This is a project for CSC401

pull request commentsubmariner-io/submariner-website

Doc that diag inter-cluster requires two configs

There's not a way to use a merged KUBECONFIG here, right @sridhargaddam? That would be helpful IMHO, as I think most use cases end up with merged KUBECONFIGs these days.

dfarrell07

comment created time in a day

PR opened submariner-io/submariner-website

Doc that diag inter-cluster requires two configs documentation

Document that subctl diagnose firewall inter-cluster requires two KUBECONFIG arguments.

Signed-off-by: Daniel Farrell dfarrell@redhat.com

+1 -1

0 comment

1 changed file

pr created time in a day

create barnchdfarrell07/submariner-website

branch : fw_diag

created branch time in a day

pull request commentopen-cluster-management/submariner-addon

Enable golangci-lint revive linter, fix errors

After improving the ignores, these are the new failures revive finds. What do you think @tpantelis, are these real issues? Any tips about fixing them?

pkg/helpers/testing/helpers.go:25:51: unexported-return: exported func NewFakeSyncContext returns unexported type *testing.fakeSyncContext, which can be annoying to use (revive)
func NewFakeSyncContext(t *testing.T, key string) *fakeSyncContext {
                                                  ^
pkg/hub/submarineraddonagent/agent.go:78:98: unexported-return: exported func NewAddOnAgent returns unexported type *submarineraddonagent.addOnAgent, which can be annoying to use (revive)
func NewAddOnAgent(kubeClient kubernetes.Interface, recorder events.Recorder, agentImage string) *addOnAgent {
dfarrell07

comment created time in a day

create barnchdfarrell07/submariner-addon

branch : revive

created branch time in a day

pull request commentopen-cluster-management/submariner-addon

Enable golangci-lint nilerr linter, fix errors

Perhaps we can get it upgraded. I'll leave this open for now.

Yeah, we'll hopefully get it updated and enable these newer linters. I thought I had all the new ones set aside on a different list, but I guess they all didn't show warnings. I have https://github.com/open-cluster-management/submariner-addon/pull/204 also wainting on an update.

tpantelis

comment created time in 2 days

push eventdfarrell07/submariner-addon

Tom Pantelis

commit sha 5e40f8a0ab4bcc211a2b4aa31e219a38de058135

Enable golangci-lint gocyclo linter, fix errors The existing min-complexity setting was 20 which yielded one function in violation. Generally 10 is considered within the cyclomatic complexity acceptable range but I think 15 is reasonable. Only 4 functions required some refactoring: pkg/spoke/submarineragent/deployment_controller.go:61:1: cyclomatic complexity 24 of func `(*deploymentStatusController).sync` is high (> 15) (gocyclo) func (c *deploymentStatusController) sync(ctx context.Context, syncCtx factory.SyncContext) error { ^ pkg/spoke/submarineragent/config_controller.go:115:1: cyclomatic complexity 20 of func `(*submarinerConfigController).sync` is high (> 15) (gocyclo) func (c *submarinerConfigController) sync(ctx context.Context, syncCtx factory.SyncContext) error { ^ pkg/hub/submarineragent/controller.go:261:1: cyclomatic complexity 16 of func `(*submarinerAgentController).syncManagedCluster` is high (> 15) (gocyclo) func (c *submarinerAgentController) syncManagedCluster( ^ pkg/hub/submarineragent/controller.go:176:1: cyclomatic complexity 16 of func `(*submarinerAgentController).sync` is high (> 15) (gocyclo) func (c *submarinerAgentController) sync(ctx context.Context, syncCtx factory.SyncContext) error { ^ Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

view details

Daniel Farrell

commit sha 269e98f3e3aad8e2b742e1a8fee12187b9ca978b

Enable golangci-lint godot linter, fix errors Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

view details

push time in 2 days

push eventdfarrell07/submariner-addon

Daniel Farrell

commit sha cd2d5d47098c0a17273d106ad1806717658a72e4

Enable golangci-lint godot linter, fix errors Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

view details

push time in 2 days

Pull request review commentopen-cluster-management/submariner-addon

Enable golangci-lint godot linter, fix errors

 var ( 	GroupName     = "submarineraddon.open-cluster-management.io" 	GroupVersion  = schema.GroupVersion{Group: GroupName, Version: "v1alpha1"} 	schemeBuilder = runtime.NewSchemeBuilder(addKnownTypes)-	// Install is a function which adds this version to a scheme+	// Install is a function which adds this version to a scheme. 	Install = schemeBuilder.AddToScheme -	// SchemeGroupVersion generated code relies on this name-	// Deprecated+	// SchemeGroupVersion generated code relies on this name.+	// DEPRECATED!

Yep, that seems a lot more useful than an exclamation mark. :wink:

dfarrell07

comment created time in 2 days

PullRequestReviewEvent
PullRequestReviewEvent

pull request commentsubmariner-io/submariner

Wrap validation error instead of recreating

Depends on https://github.com/submariner-io/releases/issues/241

wangchenglong01

comment created time in 2 days

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

pull request commentsubmariner-io/submariner-charts

Update helm chart to 0.10.1 & Add missing variables to support AKS

ACK @SteveMattar, there are long-term things we could maybe do to make maintenance easier. But in the meantime, let's get this one in IMHO. @skitt @sridhargaddam @tpantelis

vigohe

comment created time in 2 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentopen-cluster-management/submariner-addon

Enable golangci-lint gocyclo linter, fix errors

 linters:   enable:     - asciicheck     - bodyclose-    # - cyclop # TODO: Do we want this?

Let's not remove it, let's change the comment to clarify why we don't want it enabled.

tpantelis

comment created time in 2 days

PullRequestReviewEvent

push eventdfarrell07/submariner-addon

Daniel Farrell

commit sha 959824c67258b37c8e778987b504ff9ccbd8e4e2

Enable golangci-lint godot linter, fix errors Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

view details

push time in 2 days

create barnchdfarrell07/submariner-addon

branch : godot

created branch time in 2 days

pull request commentopen-cluster-management/submariner-addon

Enable golangci-lint forcetypeassert, fix errors

It seems we golangci-lint 1.38.0 for this linter.

dfarrell07

comment created time in 2 days