profile
viewpoint
Bonggyun Lee deptno 이봉 Seoul. https://bglee.me fullstack engineer / ts, swift, node, next.js, graphql, aws(dynamodb, serverless), terraform, postgresql, swift, swiftui

deptno/dynamon 321

:smiling_imp: Dynamon is GUI client for DynamoDB, can connect local dynamodb.

deptno/cwlog 23

:paw_prints: cli AWS Cloudwatch Logs Downloader

deptno/action-aws-ssm-to-dotenv 11

🔐Github Action. create `.env` via AWS SSM parameters path

deptno/dynalee 10

🍳 DynamoDB Typescript ORM

deptno/aws-appsync-iam-example 4

:hear_no_evil: Fullstacked GraphQL example based on AWS AppSync, Amplify and IAM role

deptno/color 2

colors for fast dev

deptno/awesome-crypto-currency-trading 1

😎 awesome-crypto-currency-trading

deptno/bglee.me 1

👤 bglee.me

deptno/blog 1

🍼

pull request commentprisma/prisma-examples

refactor: Migrate apollo

This broke the function getUserId in utils.ts as the context object is different on apollo-server. Fixed it locally but not allowed to open PRs here.

ruheni

comment created time in an hour

issue closedfacebookexperimental/Recoil

How to write simple unit test for an atom?

This is my simple atom, I want to write a unit test for it but I couldn't find documentation anywhere to write a unit test for it, can someone please guide

export const domainDocuments = atom({
	key: 'domainDocuments',
	default: [],
});

closed time in 3 hours

thealitahir

issue commentfacebookexperimental/Recoil

Get previous states from selectors

@mastorm / @BenjaBobs Would a solution using useRecoilCallback() like the following work?

export const allItems = atom<Array<Item>>>({
  key: 'allItems',
  default: [],
});

const currentCursorInternal = atom<number>({
  key: 'currentCursorInternal',
  default: 0,
});

export fetchMoreItems = useRecoilCallback(({snapshot, set}) => async () => {
  set(currentCursorInternal, cursor => {
    const next = cursor + 1;
    promiseDone(ApiCall(next), newData => {
      // TODO use some queue mechanism to handle out-of-order responses.
      set(allItems, existing => [...existing, ...newData]);
    });
    return next;
  });
});

But, the most versatile or appropriate for this situation might be using the waitForNone() helper to handle the incremental loading pattern:

const itemQuery = selectorFamily({
  key: 'ItemQuery',
  get: cursor => () => ApiCall(cursor),
});

const currentCursorInternal = atom<number>({
  key: 'currentCursorInternal',
  default: 0,
});

export function useFetchMoreItems() {
  const setCurrentCursor = useSetRecoilState(currentCursorInternal);
  return () => setCurrentCursor(cursor => cursor + 1);
}

export const allItems = selector({
  key: 'AllItems',
  get: ({get}) => {
    const current = get(currentCursorInternal);
    const cursorRange = Array.from(Array(current).keys());
    return get(waitForNone(cursorRange.map(itemQuery)));
  },
});

function ShowItemsComponent() {
  const itemLoadables = useGetRecoilValue(allItems);
  const fetchMoreItems = useFetchMoreItems();
  return (
    <div>
      <button onClick={fetchMoreItems}>Fetch More Items</button>
      {itemLoadables.map(itemLoadable => ({
        hasValue: <Item item={itemLoadable.contents} />,
        hasError: <Error error={itemLoadable.contents} />,
        loading: <CoolShimmer />,
      }[itemLoadable.state])}
    </div>
  );
}
mastorm

comment created time in 3 hours

push eventJasonEtco/JasonEtco

github-actions[bot]

commit sha bdf4e28b9354959b4c23267e9599ef6ad44ca271

Updating the README!

view details

push time in 3 hours

push eventfacebookexperimental/Recoil

GitHub Actions

commit sha d22708d9ef03fbafd47d8774e5650656067471a3

Publishing a nightly build as 0.1.2

view details

push time in 3 hours

issue commentfacebookexperimental/Recoil

How to write simple unit test for an atom?

https://recoiljs.org/docs/guides/testing#example-jest-unit-testing-selectors

thealitahir

comment created time in 3 hours

issue closedfacebookexperimental/Recoil

Minor bug in the documentation in the Query Refresh section

Hello,

Sorry I'm not sure if it was noticed before, I just would like to point out a minor bug that I spotted recently at this url under the section use a request id.

In the code block below, the anonymous arrow function passed as parameter to the setUserInfoQueryRequestID function is returning undefined which will cause the atom to not update.

return () => { setUserInfoQueryRequestID(requestID => requestID++); };

This is because requestID++ is converted by the compiler/interpreter to the statement requestID = requestID + 1; and as we know statements in Javascript doesn't return anything.

I know it might be an obvious thing for most, but it can also lead some to think there's a bug in the library.

Thanks

Screenshot 2020-11-26 at 00 26 56

closed time in 4 hours

nickmarca

issue commentfacebookexperimental/Recoil

Minor bug in the documentation in the Query Refresh section

Yeah.. requestID++ is an expression which increments the value stored in requestID and returns the incremented value as the value of the expression. But, the problem here is that requestID is an input argument, so not really mutable. Fixed in #770

nickmarca

comment created time in 4 hours

push eventfacebookexperimental/Recoil

Douglas Armstrong

commit sha 9d0c2af0cb804960b0d65e5b8e91909f1e8c6491

[docs] Fix query refresh example

view details

Douglas Armstrong

commit sha 52aee7f1b6385e52509bc4d4c5a0d3a9dfd9de6e

Merge pull request #770 from drarmstr/docs [docs] Fix query refresh example

view details

push time in 4 hours

PR merged facebookexperimental/Recoil

[docs] Fix query refresh example CLA Signed documentation

Fixes #768

+1 -1

0 comment

1 changed file

drarmstr

pr closed time in 4 hours

PR opened facebookexperimental/Recoil

[docs] Fix query refresh example documentation

Fixes #768

+1 -1

0 comment

1 changed file

pr created time in 4 hours

issue openedfacebookexperimental/Recoil

How to write simple unit test for an atom?

This is my simple atom, I want to write a unit test for it but I couldn't find documentation anywhere to write a unit test for it, can someone please guide

export const domainDocuments = atom({
	key: 'domainDocuments',
	default: [],
});

created time in 4 hours

issue openedfacebookexperimental/Recoil

Minor bug in the documentation in the Query Refresh section

Hello,

Sorry I'm not sure if it was noticed before, I just would like to point out a minor bug that I spotted recently at this url under the section use a request id.

In the code block below, the anonymous arrow function passed as parameter to the setUserInfoQueryRequestID function is returning undefined which will cause the atom to not update.

return () => { setUserInfoQueryRequestID(requestID => requestID++); };

This is because requestID++ is converted by the compiler/interpreter to the statement requestID = requestID + 1; and as we know statements in Javascript doesn't return anything.

I know it might be an obvious thing for most, but it can also lead some to think there's a bug in the library.

Thanks

Screenshot 2020-11-26 at 00 26 56

created time in 5 hours

issue commentfacebookexperimental/Recoil

unnecessary re-renderings

Hi @davidmccabe, May this get fixed in react@17 too instead of experimental version only?

suren-atoyan

comment created time in 7 hours

issue openedfacebookexperimental/Recoil

effects_UNSTABLE not triggering when using RecoilRoot initializeState

RecoilRoot using initializeState:

      <RecoilRoot
        initializeState={({ set }) => set(domainState, props.savedDomainState)}
      >
        <AppRoot root={props.root} />
      </RecoilRoot>

The Atom using an effect:

const domainState = atom({
  key: "domainState",
  default: null,
  effects_UNSTABLE: [syncDomainStorage],
});

The function: syncDomainStorage is never triggered if I use initializeState, if I remove initializeState the function is called when the atom is updated.

created time in 7 hours

pull request commentjwasham/coding-interview-university

today's progress

checkin

poojankhanpara

comment created time in 7 hours

issue openedaseprite/aseprite

Increasing UI Elements Scaling causes ui to become more squished

I'm using a high dpi display (System scaling is 250% and resolution is 3200x1800). Screen Scaling set to 400% and UI Elements Scaling set to 100%: Screenshot 2020-11-27 205726 Screenshot 2020-11-27 205708 Screen Scaling set to 100% and UI Elements Scaling set to 400%: Screenshot 2020-11-27 205945 Screenshot 2020-11-27 205643

Aseprite and System version

  • Aseprite version: 1.2.25, Steam
  • System: Windows 10

created time in 7 hours

push eventprisma/prisma-examples

Prismo

commit sha b1b5ed04872bddd949062ff2de76fe69ff9f38e7

chore(packages): bump @prisma/cli to 2.12.1-dev.1

view details

push time in 9 hours

push eventprisma/prisma-examples

Prismo

commit sha c85ff55ade5d54c8ec62c568cd74ab8317da098a

chore(packages): bump @prisma/cli to 2.13.0-dev.19

view details

push time in 9 hours

push eventprisma/prisma-examples

Renovate Bot

commit sha 91373286b186e4869cb7b13a350dcc2e58c01788

chore(deps): update dependency prettier to v2.2.1

view details

Prismo

commit sha 5c9324cd53e07af0413dd5f716bb6e9ef2f07a8e

chore: sync, use 2.13.0-dev.19

view details

push time in 9 hours

push eventprisma/prisma-examples

Renovate Bot

commit sha 91373286b186e4869cb7b13a350dcc2e58c01788

chore(deps): update dependency prettier to v2.2.1

view details

Prismo

commit sha dffae6e4c58a845756f66bf5eed897aac1590337

chore: sync, use 2.12.1-dev.1

view details

push time in 9 hours

issue commentprisma/prisma-examples

typescript/graphql-apollo-server: npm install fails

Are you still getting the error?

npetronikolos

comment created time in 9 hours

push eventprisma/prisma-examples

Renovate Bot

commit sha 91373286b186e4869cb7b13a350dcc2e58c01788

chore(deps): update dependency prettier to v2.2.1

view details

push time in 9 hours

delete branch prisma/prisma-examples

delete branch : renovate/prettier-2.x

delete time in 9 hours

PR merged prisma/prisma-examples

chore(deps): update dependency prettier to v2.2.1

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
prettier (source) 2.2.0 -> 2.2.1 age adoption passing confidence

Release Notes

<details> <summary>prettier/prettier</summary>

v2.2.1

Compare Source

diff

Fix formatting for AssignmentExpression with ClassExpression (#​9741 by @​sosukesuzuki)

<!-- prettier-ignore -->

// Input
module.exports = class A extends B {
  method() {
    console.log("foo");
  }
};

// Prettier 2.2.0
module.exports = class A extends (
  B
) {
  method() {
    console.log("foo");
  }
};

// Prettier 2.2.1
module.exports = class A extends B {
  method() {
    console.log("foo");
  }
};

</details>


Renovate configuration

:date: Schedule: At any time (no schedule defined).

:vertical_traffic_light: Automerge: Enabled.

:recycle: Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

+9 -9

0 comment

6 changed files

renovate[bot]

pr closed time in 9 hours

PR opened prisma/prisma-examples

chore(deps): update dependency prettier to v2.2.1

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
prettier (source) 2.2.0 -> 2.2.1 age adoption passing confidence

Release Notes

<details> <summary>prettier/prettier</summary>

v2.2.1

Compare Source

diff

Fix formatting for AssignmentExpression with ClassExpression (#​9741 by @​sosukesuzuki)

<!-- prettier-ignore -->

// Input
module.exports = class A extends B {
  method() {
    console.log("foo");
  }
};

// Prettier 2.2.0
module.exports = class A extends (
  B
) {
  method() {
    console.log("foo");
  }
};

// Prettier 2.2.1
module.exports = class A extends B {
  method() {
    console.log("foo");
  }
};

</details>


Renovate configuration

:date: Schedule: At any time (no schedule defined).

:vertical_traffic_light: Automerge: Enabled.

:recycle: Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

+9 -9

0 comment

6 changed files

pr created time in 10 hours

create barnchprisma/prisma-examples

branch : renovate/prettier-2.x

created branch time in 10 hours

push eventjaywcjlove/awesome-mac

jaywcjlove

commit sha eccc0221532c8f6cc5682c2f3206bfe85487008a

Automated deployment: Sat Nov 28 01:23:14 UTC 2020 b1c1b462c42108036a14de19c4afc752a0538093

view details

push time in 10 hours

more