profile
viewpoint

starteddenoland/deno_std

started time in 2 hours

starteddenoland/deno

started time in 2 hours

starteddenoland/deno

started time in 2 hours

issue commentdenoland/deno

deno fmt is slow

Are these gzipped over the wire? Is deno using Accept-Encoding="gzip"?

ry

comment created time in 5 hours

issue commentdenoland/deno

deno fmt is slow

For the curious, here's the current size of prettier's dist:

kB file
1388 bin-prettier.js
59 doc.js
1329 index.js
56 parser-angular.js
218 parser-babylon.js
1430 parser-flow.js
138 parser-glimmer.js
43 parser-graphql.js
79 parser-html.js
127 parser-markdown.js
913 parser-postcss.js
2261 parser-typescript.js
135 parser-yaml.js
1000 standalone.js
140 third-party.js
ry

comment created time in 5 hours

starteddenoland/deno_std

started time in 5 hours

pull request commentdenoland/deno

feat: log permission access

Previous art:

  • Rust is an environment variable RUST_LOG so you get RUST_LOG=info
  • Python is --log so --log=INFO
  • npm uses --loglevel so you get --loglevel verbose but also has individual flags to control things as well.

There were a few other examples, but the best thing is that they are totally inconsistent. Some have just simple flags, some only have environment variables. 🤷‍♂ It does seem like DENO_LOG could/should be respected though.

bartlomieju

comment created time in 6 hours

create barnchdenoland/deno_std

branch : v0.9

created branch time in 6 hours

created tagdenoland/deno_std

tagv0.9.0

deno standard modules

created time in 6 hours

pull request commentdenoland/registry

Remove std modules from registry

I kinda think this should be done before 1.0

hayd

comment created time in 6 hours

push eventdenoland/deno_std

Ryan Dahl

commit sha 33bc3db00105e2572a7e3abd6da8591cbc5abae1

ci: bump version to v0.9.0 (#493)

view details

push time in 6 hours

PR merged denoland/deno_std

ci: bump version to v0.9.0

merge on approval

+1 -1

0 comment

1 changed file

ry

pr closed time in 6 hours

issue commentdenoland/deno

Major features necessary for 1.0

@acconrad I have a WIP PR open for that https://github.com/denoland/registry/pull/95

ry

comment created time in 7 hours

starteddenoland/deno_std

started time in 7 hours

starteddenoland/deno

started time in 7 hours

issue commentdenoland/deno

Major features necessary for 1.0

@bartlomieju see #1858

ry

comment created time in 8 hours

issue commentdenoland/deno

Change return value in Reader interface

I wonder if there are any objections to keeping the EOF symbol and type and moving it into core. Originally I only added it as a "hack" to get typescript's help during this refactor, thinking that eventually I'd do a global search-and-replace and replace EOF by null, but I must say that it works rather well.

We could define EOF to be 0 or null but I see only disadvantages. Using 0 doesn't work when the return value is a number (e.g. BufReader.readByte() currently returns -1 on eof; I didn't touch it in this PR but I think we might want to change it over as well). Using null is useless in non-strict mode.

So what about just keeping it?

Originally posted by @piscisaureus in https://github.com/denoland/deno_std/pull/444#issuecomment-496841065

So I guess scope of this issue changed a bit to introduce EOF type here and tweak interface to what we use in BufReader now.

CC @ry @piscisaureus

ry

comment created time in 8 hours

issue commentdenoland/deno

Major features necessary for 1.0

@ry I'll take this:

When you visit a deno.land script url

Where would the CSS live for that? Where is the website server code within deno?

ry

comment created time in 8 hours

issue commentdenoland/deno

Promise exit behaviour

Could you explain what "the promise behaviour we were talking about" is?

benjamingr

comment created time in 8 hours

issue commentdenoland/deno

Major features necessary for 1.0

@afinch7 could you explain what's to address with op_fetch_module_meta_data? (preferably in separate issue)

ry

comment created time in 8 hours

issue commentdenoland/deno

Major features necessary for 1.0

We also need to address this at some point before 1.0 https://github.com/denoland/deno/blob/76329cf610af1612d4e9c562a1ee3a4dd6082a37/cli/ops.rs#L196

ry

comment created time in 9 hours

starteddenoland/deno

started time in 9 hours

starteddenoland/deno_std

started time in 9 hours

push eventdenoland/deno

Deployment Bot (from Travis CI)

commit sha ea38704f5c993bbac5a78f1a8575030dbb9f8a56

Deploy denoland/deno to github.com/denoland/deno.git:gh-pages

view details

push time in 9 hours

issue openeddenoland/deno

add docs to manual for "deno install"

created time in 9 hours

PR opened denoland/deno_std

ci: bump version to v0.9.0
+1 -1

0 comment

1 changed file

pr created time in 9 hours

push eventdenoland/deno

David Stone

commit sha 76329cf610af1612d4e9c562a1ee3a4dd6082a37

Fixes benchmark page spinner on Edge #2508 (#2525)

view details

push time in 9 hours

PR merged denoland/deno

Fixes benchmark page spinner not hiding on Edge #2508

Also fixes a couple of typos and css positioning of spinner.

https://github.com/denoland/deno/issues/2508

+7 -5

4 comments

3 changed files

davidjamesstone

pr closed time in 9 hours

starteddenoland/deno

started time in 9 hours

PR opened denoland/deno

Refactor dispatch

Removed most of the changes to core from #2452, but kept the improvements to cli dispatch.

  • cli dispatches now return a Result<Op<DenoError>, DenoError> value allowing for use of the try operator and returning non-futures in the form of Op::Sync
  • seamless handling of Op::Sync responses to async calls.
  • some cleanups in //js/dispatch.js
+470 -497

0 comment

8 changed files

pr created time in 10 hours

Pull request review commentdenoland/deno

Loader refactor

 impl<L: Loader> RecursiveLoad<L> {      Ok(module_name)   }++  pub fn get_future(

Eventually this should go. I added it to make porting over the tests easier.

piscisaureus

comment created time in 10 hours

release denoland/deno

v0.9.0

released time in 11 hours

starteddenoland/deno

started time in 11 hours

push eventdenoland/deno

Deployment Bot (from Travis CI)

commit sha dcaff4204389ebc224f4bc7f173ed6b6c1ac4fc4

Deploy denoland/deno to github.com/denoland/deno.git:gh-pages

view details

push time in 11 hours

created tagdenoland/deno

tagv0.9.0

A secure JavaScript/TypeScript runtime built with V8, Rust, and Tokio

created time in 12 hours

push eventdenoland/deno

Ryan Dahl

commit sha 7b06aa37342c021f9f1fac99125847d134e67001

v0.9.0

view details

push time in 12 hours

PR merged denoland/deno

v0.9.0

"deno install" needs to be fixed or reverted before landing https://github.com/denoland/deno/issues/2526

+25 -5

1 comment

4 changed files

ry

pr closed time in 12 hours

push eventdenoland/deno

Deployment Bot (from Travis CI)

commit sha 65a7a3ad6f49ebc0b4070f27b5357d510859e561

Deploy denoland/deno to github.com/denoland/deno.git:gh-pages

view details

push time in 12 hours

push eventdenoland/deno

Ryan Dahl

commit sha 9142a7df46fd1335c9ee007edcc4e83eb589a794

Upgrade INSTALLER_URL to include fixes (#2532) denoland/deno_std#492

view details

push time in 13 hours

PR merged denoland/deno

Upgrade INSTALLER_URL to include fixes

denoland/deno_std#492

cc @bartlomieju

+1 -1

0 comment

1 changed file

ry

pr closed time in 13 hours

push eventdenoland/deno

Deployment Bot (from Travis CI)

commit sha ccea6ce36b5870d9f8f9c761a491e9e2dee1c954

Deploy denoland/deno to github.com/denoland/deno.git:gh-pages

view details

push time in 13 hours

starteddenoland/deno

started time in 13 hours

PR opened denoland/deno

Upgrade INSTALLER_URL to include fixes

denoland/deno_std#492

<!-- Before submitting a PR read https://deno.land/manual.html#contributing -->

+1 -1

0 comment

1 changed file

pr created time in 13 hours

push eventdenoland/deno

Bartek Iwańczuk

commit sha 061f6dd4832320ff654ee2a7a07901852b702639

fix deno install (#2529)

view details

push time in 13 hours

PR merged denoland/deno

fix: deno install

Closes #2526

CC @ry

+73 -9

1 comment

1 changed file

bartlomieju

pr closed time in 13 hours

issue closeddenoland/deno

"deno install deno_colors https://deno.land/std/examples/colors.ts" fails

> git log -1 --oneline
1361e302 (HEAD -> master, origin/master, origin/HEAD) Revert "Refactor dispatch handling (#2452)"
> ./target/debug/deno install deno_colors https://deno.land/std/examples/colors.ts
thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', src/libcore/option.rs:345:21
stack backtrace:
   0: std::sys::unix::backtrace::tracing::imp::unwind_backtrace
             at src/libstd/sys/unix/backtrace/tracing/gcc_s.rs:39
   1: std::sys_common::backtrace::_print
             at src/libstd/sys_common/backtrace.rs:71
   2: std::panicking::default_hook::{{closure}}
             at src/libstd/sys_common/backtrace.rs:59
             at src/libstd/panicking.rs:197
   3: std::panicking::default_hook
             at src/libstd/panicking.rs:211
   4: <std::panicking::begin_panic::PanicPayload<A> as core::panic::BoxMeUp>::get
             at src/libstd/panicking.rs:474
   5: std::panicking::continue_panic_fmt
             at src/libstd/panicking.rs:381
   6: std::panicking::try::do_call
             at src/libstd/panicking.rs:308
   7: <T as core::any::Any>::type_id
             at src/libcore/panicking.rs:85
   8: <T as core::any::Any>::type_id
             at src/libcore/panicking.rs:49
   9: core::option::Option<T>::unwrap
             at /rustc/3c235d5600393dfe6c36eeed34042efad8d4f26e/src/libcore/macros.rs:12
  10: deno::flags::flags_from_vec
             at cli/flags.rs:624
  11: deno::main
             at cli/main.rs:333
  12: std::rt::lang_start::{{closure}}
             at /rustc/3c235d5600393dfe6c36eeed34042efad8d4f26e/src/libstd/rt.rs:64
  13: std::panicking::try::do_call
             at src/libstd/rt.rs:49
             at src/libstd/panicking.rs:293
  14: panic_unwind::dwarf::eh::read_encoded_pointer
             at src/libpanic_unwind/lib.rs:87
  15: std::panicking::update_count_then_panic
             at src/libstd/panicking.rs:272
             at src/libstd/panic.rs:388
             at src/libstd/rt.rs:48
  16: std::rt::lang_start
             at /rustc/3c235d5600393dfe6c36eeed34042efad8d4f26e/src/libstd/rt.rs:64
  17: deno::main

closed time in 13 hours

ry

PR opened denoland/deno

Expand LSAN coverage to deno_core_test

<!-- Before submitting a PR read https://deno.land/manual.html#contributing -->

+3 -1

0 comment

1 changed file

pr created time in 14 hours

push eventdenoland/deno

Deployment Bot (from Travis CI)

commit sha 24e0900d7978c1017a329922f95d7c0f26b483ad

Deploy denoland/deno to github.com/denoland/deno.git:gh-pages

view details

push time in 14 hours

issue commentdenoland/deno_std

assertStrContains and assertArrayContains

Agree for the renaming.

About the separates functions i've focus on the Jest implementations, see: https://jestjs.io/docs/en/expect.html

I don't think it's better to have it just one function. It's more a philosophy question than a technical one.

kitsonk

comment created time in 14 hours

pull request commentdenoland/deno

fix: deno install

@bartlomieju looks good. Can you update the commit to include https://github.com/denoland/deno_std/pull/492

diff --git a/cli/flags.rs b/cli/flags.rs
index d3166441..0e1110bb 100644
--- a/cli/flags.rs
+++ b/cli/flags.rs
@@ -509,7 +509,7 @@ fn parse_run_args(mut flags: DenoFlags, matches: &ArgMatches) -> DenoFlags {
 /// Used for `deno fmt <files>...` subcommand
 const PRETTIER_URL: &str = "https://deno.land/std@v0.7.0/prettier/main.ts";
 /// Used for `deno install...` subcommand
-const INSTALLER_URL: &str = "https://deno.land/std@a3015be/installer/mod.ts";
+const INSTALLER_URL: &str = "https://deno.land/std@1679ba/installer/mod.ts";

 /// These are currently handled subcommands.
 /// There is no "Help" subcommand because it's handled by `clap::App` itself.
bartlomieju

comment created time in 14 hours

push eventdenoland/deno_std

Ryan Dahl

commit sha 1679ba0b57e27624b3d3fdc303dccbe69a9d798d

installer: Print name of installed file (#492)

view details

push time in 14 hours

PR merged denoland/deno_std

installer: Print name of installed file

cc @bartlomieju

+10 -8

1 comment

1 changed file

ry

pr closed time in 14 hours

issue closeddenoland/deno_std

[encoding/csv] add easyCSV parse

I developped a wrapper for CSV with proposals of @j-f1 and @bartlomieju .

https://github.com/zekth/deno_easyCSV

I think it would be a good addition to add parse function to std.

closed time in 14 hours

zekth

pull request commentdenoland/deno_std

Expose fileServer options and move file_server start to examples

Agree

hayd

comment created time in 14 hours

pull request commentdenoland/deno

feat: log permission access

The naming of these type of flags has been done before. We'd probably be best off by using existing nomenclature.

In glog ( https://godoc.org/github.com/golang/glog ) they use -v=$LEVEL ... I'm most familiar with glog flags like -logtostderr... But I know many people hate glog. Does anyone have alternative logging systems we could steal ideas from?

bartlomieju

comment created time in 14 hours

pull request commentdenoland/deno_std

installer: Print name of installed file

LGTM

ry

comment created time in 14 hours

push eventdenoland/deno_third_party

Bert Belder

commit sha c29d758cd2ca6fd275f141239d59560157ac4535

Upgrade rust crates

view details

push time in 14 hours

push eventdenoland/deno

Bert Belder

commit sha 77737707e4e07d7421d9a4f813d6dcd27ecf54fe

third_party: upgrade rust crates

view details

push time in 14 hours

PR merged denoland/deno

third_party: upgrade rust crates

<!-- Before submitting a PR read https://deno.land/manual.html#contributing -->

+165 -153

0 comment

5 changed files

piscisaureus

pr closed time in 14 hours

PR opened denoland/deno_std

installer: Print name of installed file
+10 -8

0 comment

1 changed file

pr created time in 14 hours

issue commentdenoland/deno_std

[encoding/csv] add easyCSV parse

we can close it yes.

zekth

comment created time in 14 hours

issue commentdenoland/deno

hope: XMLHttpRequest in deno

I agree with @kitsonk - it would be great if we didn't support XHR.

@MarkTiedemann I believe that "progress events" are available through fetch streaming?

runnerSnail

comment created time in 14 hours

issue commentdenoland/deno_std

[encoding/csv] add easyCSV parse

Done in #458?

zekth

comment created time in 14 hours

PR opened denoland/deno

Reviewers
third_part: upgrade rust crates

<!-- Before submitting a PR read https://deno.land/manual.html#contributing -->

+165 -153

0 comment

5 changed files

pr created time in 14 hours

create barnchdenoland/deno_third_party

branch : 20190615_upgrade_crates

created branch time in 14 hours

pull request commentdenoland/deno_std

Expose fileServer options and move file_server start to examples

@hayd this PR is pretty stale... I think file_server is fine in http/

hayd

comment created time in 14 hours

pull request commentdenoland/deno

feat: log permission access

Or how about we introduce --log-level=debug or something that means we are not proliferating a load of flags.

Done! Added --log-level/-L flag that takes either info or debug value. (I don't really like -L 🙄... let you be the judge)

I kept -D/--log-debug flag for compatibility - basically it's an alias for --log-level=debug.

Now permission access show only with --log-level=info or --log-level=debug:

deno_dev --log-level=info -A https://deno.land/std/http/file_server.ts
ℹ️  Granted network access to "0.0.0.0:4500"
HTTP server listening on http://0.0.0.0:4500/
ℹ️  Granted read access to "/Users/biwanczuk/dev/deno"
ℹ️  Granted read access to "/Users/biwanczuk/dev/deno"
ℹ️  Granted read access to "/Users/biwanczuk/dev/deno/Cargo.toml"
ℹ️  Granted read access to "/Users/biwanczuk/dev/deno/buildtools"
ℹ️  Granted read access to "/Users/biwanczuk/dev/deno/tools"
...
bartlomieju

comment created time in 15 hours

starteddenoland/deno

started time in 16 hours

fork 95th/deno

A secure JavaScript/TypeScript runtime built with V8, Rust, and Tokio

https://deno.land/

fork in 16 hours

PR opened denoland/deno

fix: deno install

Closes #2526

+73 -9

0 comment

1 changed file

pr created time in 17 hours

starteddenoland/deno_std

started time in 18 hours

starteddenoland/deno

started time in 19 hours

starteddenoland/deno

started time in 21 hours

issue commentdenoland/deno

hope: XMLHttpRequest in deno

I really think XMLHttpRequest is a big ole can of worms. It is a really old API with a load of crap to try to make it compatible with the browsers. IMO we really have to draw the line of "browser compatibility" somewhere.

The best thing is that is someone desired, to use the built in Deno bindings to create a polyfill in std and bring it into core if it actually worked well.

runnerSnail

comment created time in a day

issue commentdenoland/deno

console.log not show private members of javascript

The output with the TypeScript private is irrelevant because it isn't a runtime thing, private is a TypeScript only construct at that point.

There appears to be inconstancy between Chrome and Node.js on this.

Chrome 74:

class Foo
{
	#foo= 8;
}

console.log( new Foo, );
VM39:6 Foo {#foo: 8}
undefined

Node.js 12.4:

> class Foo
... {
... 	#foo= 8;
... }
undefined
> 
> console.log( new Foo, );
Foo {}
undefined

I would have expected private members to not be logged actually, since they would be like non-enumerable properties too. But clearly there is inconsistency.

Fenzland

comment created time in a day

issue openeddenoland/deno

console.log not show private members of javascript

test.ts


class Foo
{
	private foo= 8;
}

console.log( new Foo, );

// expect:   Foo { foo: 8 }
// actually: Foo { foo: 8 }

test.js


class Foo
{
	#foo= 8;
}

console.log( new Foo, );

// expect:   Foo { #foo: 8 }
// actually: Foo {}

created time in a day

starteddenoland/deno_std

started time in a day

starteddenoland/deno

started time in a day

starteddenoland/deno

started time in a day

issue commentdenoland/deno

Building failing: duplicate symbol

Hmm it’s building on AppVeyor.

I’ll break out my windows machine tomorrow and try to repeat.

95th

comment created time in a day

starteddenoland/deno

started time in a day

issue commentdenoland/deno

Building failing: duplicate symbol

I tried reverting only the v8 upgrade done on June 10th.

third_party -> git revert 92159ba506cf2fb87f4779bebeb07fd3463d0063
deno -> git revert 523ab6a929dacf4cdd692c1319173a1a49c642de

Build is working now. cc @piscisaureus

95th

comment created time in a day

pull request commentdenoland/deno

feat: log permission access

Or how about we introduce --log-level=debug or something that means we are not proliferating a load of flags.

bartlomieju

comment created time in a day

issue commentdenoland/deno

Building failing: duplicate symbol

I am using Visual Studio 2019 (GYP_MSVS_VERSION=2019). It used to build with it before Jun 10. Today I tried checking out at an older commit.

PS C:\denodev\deno> git log -1
commit e0436975211202afadb1a8ccd7d5154694162f38 (HEAD -> master)
Author: Ryan Dahl <ry@tinyclouds.org>
Date:   Mon Jun 10 15:27:34 2019 -0400

    Expose dynamic import in core (#2472)

Submodules at:

PS C:\denodev\deno> git submodule status
 7b594236fbba04ee23d32ba3adf5ea68611cf2e7 build (remotes/origin/20190428_win_clang_depfile)
 68faf32f721d2a95c7b1c75661713c8118c077c7 js/deps/https/deno.land/std (20190520)
 72a4202a0341516115a92aa18951eb3010fb75fa third_party (remotes/origin/20190601_ts351-1-g72a4202a0)

Now it is building. So, something happened after this. One of change is v8 but I am not sure if that is the cause but chromium support VS 2019.

95th

comment created time in a day

starteddenoland/deno

started time in a day

pull request commentdenoland/deno

v0.9.0

I'll fix Deno install till tomorrow

ry

comment created time in a day

pull request commentdenoland/deno

Fixes benchmark page spinner not hiding on Edge #2508

Thanks Ryan. LOL I actually had line breaks in initially then took them out.

I did see this

Run tools/format.py 
 M website/app.ts

But I was kind of expecting the linting error afterwards but the output ended there.

davidjamesstone

comment created time in a day

PR opened denoland/deno

v0.9.0

<!-- Before submitting a PR read https://deno.land/manual.html#contributing -->

+22 -2

0 comment

3 changed files

pr created time in a day

issue commentdenoland/deno_std

assertStrContains and assertArrayContains

#491 may (?) be another approach to this same issue.

kitsonk

comment created time in a day

issue commentdenoland/deno_std

suggestion: a decoder/assertion library

#484 could be related (in that a generalized decoder API would be able to handle the assertions described in that issue).

The main advantage of providing a decoder API, instead of using individual assert() functions, would be composability.

thefliik

comment created time in a day

pull request commentdenoland/deno

Fixes benchmark page spinner not hiding on Edge #2508

@davidjamesstone It's at the end of the very verbose output:

Run tools/format.py 
 M website/app.ts

I've pushed the format change

davidjamesstone

comment created time in a day

issue commentdenoland/deno_std

suggestion: a decoder/assertion library

Beyond simply providing a unified API for (what I think is) a common programming task, a decoder library is generally going to be related to an application's security, so I think it could benefit from being maintained in deno_std.

thefliik

comment created time in a day

issue openeddenoland/deno_std

suggestion: a decoder/assertion library

Something I've found to be a recurring need: taking an unknown input, asserting that it has a specific shape, and either returning a response that is correctly typed in typescript or returning an error.

You could call this a decoder library or an assertion library, but would adding a package to deno_std that deals with this be appropriate?

As an example, recently I started using a small but helpful library for this purpose ts.data.json (I'm not affiliated with the project). Its main export is a Decoder class.

From the source:

const string: Decoder<string> = new Decoder<string>((json: any) => {
    if (typeof json === 'string') {
      return ok<string>(json);
    } else {
      return err<string>($JsonDecoderErrors.primitiveError(json, 'string'));
    }
  })

This decoder can be used to both assert that an unknown is a string, and properly type the result.

I'm not wedded to the ts.data.json api (though I like it), but, in general, would something along these lines be appropriate to add to deno_std? This seems like something that many projects could benefit from.

A more complex example:

interface IUser {
  firstname: string;
  lastname: string;
};

const userDecoder = JsonDecoder.object<IUser>(
  {
    firstname: JsonDecoder.string,
    lastname: JsonDecoder.string
  },
  'User'
);

const unknownJSON = {
  firstname: 1,
  lastname: 'Smith'
};

// This would actually throw a type error because the type of `unknownJSON`
// is known to violate the type that `userDecoder` expects, but lets assume that
// `unknownJSON` is really unknown
const result = userDecoder.decode(unknownJSON)

if (result instanceof Err) {
  throw new Error(
    result.err // error message
  );
}

// properly typed as IUser
const user = result.value

created time in a day

pull request commentdenoland/deno

Fixes benchmark page spinner not hiding on Edge #2508

Thanks & sorry about that, I failed to read https://deno.land/manual.html#submittingapullrequest.

It's not clear to me from the Travis output what it's failing on - is it a linting problem?

I can't run tools/format.py at the moment. I've never setup the full deno build environment before. I don't have XCode or Rust on this work machine either so I think I might be better off setting up a linux vm.

If you're happy to wait I'll hopefully get time this weekend to do it but please feel free to step in and fix if it's quicker.

davidjamesstone

comment created time in a day

issue openeddenoland/deno

"deno install deno_colors https://deno.land/std/examples/colors.ts" fails

> ./target/debug/deno install deno_colors https://deno.land/std/examples/colors.ts
thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', src/libcore/option.rs:345:21
stack backtrace:
   0: std::sys::unix::backtrace::tracing::imp::unwind_backtrace
             at src/libstd/sys/unix/backtrace/tracing/gcc_s.rs:39
   1: std::sys_common::backtrace::_print
             at src/libstd/sys_common/backtrace.rs:71
   2: std::panicking::default_hook::{{closure}}
             at src/libstd/sys_common/backtrace.rs:59
             at src/libstd/panicking.rs:197
   3: std::panicking::default_hook
             at src/libstd/panicking.rs:211
   4: <std::panicking::begin_panic::PanicPayload<A> as core::panic::BoxMeUp>::get
             at src/libstd/panicking.rs:474
   5: std::panicking::continue_panic_fmt
             at src/libstd/panicking.rs:381
   6: std::panicking::try::do_call
             at src/libstd/panicking.rs:308
   7: <T as core::any::Any>::type_id
             at src/libcore/panicking.rs:85
   8: <T as core::any::Any>::type_id
             at src/libcore/panicking.rs:49
   9: core::option::Option<T>::unwrap
             at /rustc/3c235d5600393dfe6c36eeed34042efad8d4f26e/src/libcore/macros.rs:12
  10: deno::flags::flags_from_vec
             at cli/flags.rs:624
  11: deno::main
             at cli/main.rs:333
  12: std::rt::lang_start::{{closure}}
             at /rustc/3c235d5600393dfe6c36eeed34042efad8d4f26e/src/libstd/rt.rs:64
  13: std::panicking::try::do_call
             at src/libstd/rt.rs:49
             at src/libstd/panicking.rs:293
  14: panic_unwind::dwarf::eh::read_encoded_pointer
             at src/libpanic_unwind/lib.rs:87
  15: std::panicking::update_count_then_panic
             at src/libstd/panicking.rs:272
             at src/libstd/panic.rs:388
             at src/libstd/rt.rs:48
  16: std::rt::lang_start
             at /rustc/3c235d5600393dfe6c36eeed34042efad8d4f26e/src/libstd/rt.rs:64
  17: deno::main

created time in a day

push eventdenoland/deno

Deployment Bot (from Travis CI)

commit sha 99542b43e73b979524ea30ba981d7b2643b79b0b

Deploy denoland/deno to github.com/denoland/deno.git:gh-pages

view details

push time in a day

pull request commentdenoland/deno

Fixes benchmark page spinner not hiding on Edge #2508

@davidjamesstone Thanks! CI is failing due to formatting. Can you run "tools/format.py" ?

davidjamesstone

comment created time in a day

starteddenoland/deno

started time in a day

more