profile
viewpoint
Dennis van der Schagt dennisschagt Netherlands https://dschagt.nl

newsboat/newsboat 1315

An RSS/Atom feed reader for text terminals

dennisschagt/stfl 2

stfl - Forked from svn http://svn.clifford.at/stfl (http://www.clifford.at/stfl/)

dennisschagt/2ID90 0

Assignments for 2ID90 (Artificial Intelligence)

dennisschagt/architecture 0

Notes on the AVR architecture

dennisschagt/aur 0

Personal PKGBUILDs for Arch Linux based on packages from AUR and official repositories

dennisschagt/awesome-reversing 0

A curated list of awesome reversing resources

dennisschagt/crev-proofs 0

Crev proof repository

dennisschagt/dino-park-front-end 0

Front-end for Mozillians.org

dennisschagt/display-anchors 0

Display #Anchors offers an easy way to see all (invisible) anchors in a page, to make it easier to link to a specific part of a webpage.

push eventdennisschagt/newsboat

Dennis van der Schagt

commit sha e6f0d0e6d41844b44dc9130a5cb557d4b3a71f15

Improve readability of delete-read-articles-on-quit description

view details

push time in an hour

Pull request review commentnewsboat/newsboat

Add a --cleanup option

 usage: ./newsboat [-i <file>|-e] [-u <urlfile>] [-c <cachefile>] [-x <command> .     -E, --export-to-file=<file>     export list of read articles to <file>     -I, --import-from-file=<file>   import list of read articles from <file>     -h, --help                      this help+        --cleanup                   remove unreferenced items from cache

Done: https://github.com/newsboat/newsboat/pull/1250/commits/7f30aa737b28ba48974d2f3a0e2c5b64e8e809b8

dennisschagt

comment created time in 2 hours

PullRequestReviewEvent

push eventdennisschagt/newsboat

Dennis van der Schagt

commit sha 7f30aa737b28ba48974d2f3a0e2c5b64e8e809b8

Update version shown in "first steps" example output

view details

push time in 2 hours

Pull request review commentnewsboat/newsboat

Add a --cleanup option

 terminals on Unix or Unix-like systems such as GNU/Linux, BSD or Mac OS X.         _delete-read-articles-on-quit_, _keep-articles-days_, and _max-items_         settings. +--cleanup::+        Remove unreferenced entries from the cache. Feeds and their articles+        will be removed if the feedurl is no longer in the _urls_ file. If 

Good idea, done: https://github.com/newsboat/newsboat/pull/1250/commits/f03bcc83298e98b2c802b6e8770ca2aefa13f53f

dennisschagt

comment created time in 2 hours

PullRequestReviewEvent

push eventdennisschagt/newsboat

Dennis van der Schagt

commit sha f03bcc83298e98b2c802b6e8770ca2aefa13f53f

Move --cleanup+delete-read-articles-on-quit description in extra paragraph Indentation is removed from the paragraph because it would otherwise show up with strange formatting in the manpage.

view details

push time in 2 hours

Pull request review commentnewsboat/newsboat

Add a --cleanup option

 confirm-exit||[yes/no]||no||If set to `yes`, then Newsboat will ask for confirma cookie-cache||<path>||""||Set a cookie cache. If set, cookies will be cached in (i.e. read from and written to) this file, using http://www.cookiecentral.com/faq/#3.5[Netscape format].||cookie-cache "~/.newsboat/cookies.txt" datetime-format||<date/time format>||%b %d||This format specifies the date/time format in the article list. For a detailed documentation on the allowed formats, consult the manpage of strftime(3).||datetime-format "%D, %R" define-filter||<name> <filterexpr>||n/a||With this command, you can predefine filters, which you can later select from a list, and which are then applied after selection. This is especially useful for filters that you need often and you don't want to enter them every time you need them.||define-filter "all feeds with 'fun' tag" "tags # \"fun\""-delete-read-articles-on-quit||[yes/no]||no||If set to `yes`, then all read articles will be deleted when you quit Newsboat.||delete-read-articles-on-quit yes+delete-read-articles-on-quit||[yes/no]||no||If set to `yes`, all read articles will be deleted when you start Newsboat with the `--cleanup` option or quit Newsboat if `cleanup-on-quit` is set.||delete-read-articles-on-quit yes

This setting only applies when cleanup-on-quit is set.

That sounds incorrect because the setting also applies when only specifying --cleanup (even when cleanup-on-quit would be no).

Do you think the following is clear enough?

If set to yes, all read articles will be deleted when quiting Newsboat. This option only applies if cleanup-on-quit is set to yes or if the --cleanup argument is passed.

dennisschagt

comment created time in 3 hours

PullRequestReviewEvent

issue commentnewsboat/newsboat

Automatically open specific feed upon startup

This will be possible in the next releaseof Newsboat (or by building from the current master branch).

You can use the run-on-startup option in the config file to select a feed based on (part of) its title and then open it, e.g.:

run-on-startup      goto-title "newsboat" ; open
Minoru

comment created time in a day

push eventdennisschagt/newsboat

Dennis van der Schagt

commit sha 87e37f6c27ef921ed714cf4379ba3431dbd76e7b

Introduce "goto-title" operation which works like the "goto" command

view details

Dennis van der Schagt

commit sha 6bcb39a4d9ecbbc87b0ffd5ddcfaa0c3077dae4c

Handle "goto-title" operation in ItemListFormAction

view details

Dennis van der Schagt

commit sha 701cd6dd4f181f4116ed065ab904470fcd416385

Don't search through titles if list of items is empty

view details

Dennis van der Schagt

commit sha 466bed93102292fcb129416e01d2f1f37cc0f5fd

Mention that goto-title matches titles case-insensitively

view details

Alexander Batischev

commit sha 1ff811679ded5c83b57544dcad4d049d963fe8b0

Merge pull request #1249 from dennisschagt/feature/issue-1135 Add an operation to select a feed/article based on its title

view details

push time in a day

PR opened newsboat/newsboat

Add a --cleanup option

Resolves https://github.com/newsboat/newsboat/issues/1182.

+122 -15

0 comment

13 changed files

pr created time in a day

push eventdennisschagt/newsboat

Dennis van der Schagt

commit sha 16a479baf093a31a89b27929860006b09f91582c

Simplify handling of --vacuum in Controller

view details

Dennis van der Schagt

commit sha a71e7b6483c344f38588588319acb8a365abc312

Add a --cleanup option which cleans the cache; then exits newsboat It has the same effect as configuring `cleanup-on-quit yes` and starting+quiting newsboat.

view details

Dennis van der Schagt

commit sha 38ba619a916609201192742a6999be47b32569ef

delete-read-articles-on-quit only works with --cleanup/cleanup-on-quit

view details

push time in a day

create barnchdennisschagt/newsboat

branch : feature/issue-1182

created branch time in a day

delete branch dennisschagt/newsboat

delete branch : feature/issue-1135

delete time in 2 days

pull request commentnewsboat/newsboat

Add an operation to select a feed/article based on its title

Thank you for the review!

dennisschagt

comment created time in 2 days

Pull request review commentnewsboat/newsboat

Add an operation to select a feed/article based on its title

 home||HOME||Go to the first item in the list. end||END||Go to the last item in the list. macro-prefix||,||Initiate macro execution. The next key press selects the actual macro and runs it. switch-focus||TAB||Switch focus between widgets. This is currently only applicable to the `filebrowser` and `dirbrowser` contexts.+goto-title||||Go to item whose title contains the specified string.

Done: https://github.com/newsboat/newsboat/pull/1249/commits/466bed93102292fcb129416e01d2f1f37cc0f5fd

dennisschagt

comment created time in 2 days

PullRequestReviewEvent

Pull request review commentnewsboat/newsboat

Add an operation to select a feed/article based on its title

 std::string ItemListFormAction::item2formatted_line(const ItemPtrPosPair& item, 	return formattedLine; } +void ItemListFormAction::goto_item(const std::string& title)+{+	const unsigned int curpos = list.get_position();+	for (unsigned int i = curpos + 1; i < visible_items.size(); ++i) {+		if (strcasestr(visible_items[i].first->title().c_str(),+				title.c_str()) != nullptr) {+			list.set_position(i);+			return;+		}+	}+	for (unsigned int i = 0; i <= curpos; ++i) {

Good catch, I fixed it by skipping the whole function if the list is empty: https://github.com/newsboat/newsboat/pull/1249/commits/701cd6dd4f181f4116ed065ab904470fcd416385.

dennisschagt

comment created time in 2 days

PullRequestReviewEvent

push eventdennisschagt/newsboat

Dennis van der Schagt

commit sha 701cd6dd4f181f4116ed065ab904470fcd416385

Don't search through titles if list of items is empty

view details

Dennis van der Schagt

commit sha 466bed93102292fcb129416e01d2f1f37cc0f5fd

Mention that goto-title matches titles case-insensitively

view details

push time in 2 days

PR opened newsboat/newsboat

Add an operation to select a feed/article based on its title

Fixes https://github.com/newsboat/newsboat/issues/1135.

Combined with https://github.com/newsboat/newsboat/pull/1134, this fixes https://github.com/newsboat/newsboat/issues/888. This can be used with a configuration like:

run-on-startup goto-title "newsboat" ; open
+58 -1

0 comment

7 changed files

pr created time in 2 days

create barnchdennisschagt/newsboat

branch : feature/issue-1135

created branch time in 2 days

push eventdennisschagt/newsboat

Alexander Batischev

commit sha 74c1957c90ff165bc44bec0f1bcccd77a619bb14

CI: upgrade to FreeBSD 12.2

view details

Alexander Batischev

commit sha fb11be52b91165b20878a2a6a61d0c7904d24874

Merge pull request #1248 from newsboat/feature/ci-freebsd-12.2 CI: upgrade to FreeBSD 12.2

view details

push time in 3 days

issue commentnewsboat/newsboat

Show unread counter in tag view

This might be possible by configuring the selecttag-format option. Its documentation suggests the following (example) configuration: selecttag-format "[%2i] %T (%n unread articles in %f feeds, %u feeds total)" where the %n identifier probably does what you want: https://newsboat.org/releases/2.21/docs/newsboat.html#selecttag-format-n

mdosch

comment created time in 4 days

issue openedeProsima/Fast-DDS

Fast-DDS subscriber throws exception when OpenDDS publisher transmits a "key" message

It looks like there is an incompatibility between Fast-DDS and OpenDDS. When setting up an OpenDDS publisher with a Fast-DDS subscriber, Fast-DDS often throws an exception when the first sample is published.

I can also reproduce this with the ShapesDemo.

Steps to Reproduce

  1. Start the OpenDDS ishapes application. It can be found in their repo (examples/DCPS/ishapes). I build it (tag: DDS-3.14) using ./configure --qt --tests "--configh=#define ACE_LACKS_SYS_SYSCTL_H" && make -j8 and run it using source ./setenv.sh && ./examples/DCPS/ishapes/ishapes.
  2. Start eProsima's ShapesDemo application. I build (tag: v2.0.1) and run it using the instructions in its README.
  3. In eProsima's ShapesDemo, click "Subscribe" -> "Ok" (subscribes to "SQUARE" topic).
  4. In OpenDDS's ishapes application, change the shape (dropdown) option to "Square" and click Publish

Order is important. If changing the order of steps 3 and 4, the ShapesDemo works as expected.

Expected Behavior

The ShapesDemo visualizes the data which is published on the "SQUARE" topic.

Current Behavior

The ShapesDemo terminates with the following output:

terminate called after throwing an instance of 'eprosima::fastcdr::exception::NotEnoughMemoryException'
  what():  Not enough memory in the buffer stream
Aborted (core dumped)

System information

  • Fast-DDS version: v2.0.1
  • OS: Arch Linux
  • Network interfaces: enp0s31f6 (192.168.2.2 in the included Wireshark capture)

Additional context

Backtrace when running ShapesDemo with gdb: image

It looks like Fast-DDS sometimes crashes when eprosima::fastrtps::SubscriberImpl::takeNextData() is called. From what I understand, this happens after receiving an RTPS DATA submessage with the "Serialized Key" flag set. Such a message is also visible in the attached Wireshark capture (can be found with Wireshark display filter rtps.flag.data.serialized_key == 1). image

The attached Wireshark capture contains the packets transmitted between two hosts, one running eProsima's ShapesDemo (IP: 192.168.2.2), the other running OpenDDS's ishapes application (IP: 192.168.2.50). All packets matching the Wireshark filter rtps are included, all other packets have been filtered out.

Additional resources

created time in 4 days

push eventdennisschagt/newsboat

Alexander Batischev

commit sha da7029067c83cbb9db1766181bbc5f1ac5c57a01

Add Clang 11 to CI Also migrate the "more checks" and "sanitizer" jobs to Clang 11, since it makes sense to run those with the latest-and-greatest compiler.

view details

Dennis van der Schagt

commit sha e83ed2fb8776017dfaabce5933cae35fde756b93

Return error from UrlReader::reload() when file cannot be opened

view details

Dennis van der Schagt

commit sha 036c637f72ec873fc4a7986138684d9ccd4de12b

Return error from FileUrlReader::write_config() when file cannot be opened

view details

Dennis van der Schagt

commit sha f5eadf48e19e2b683d7ce1c9fa63be278b62b254

Test if FileUrlReader returns error message when failing to open file

view details

dependabot[bot]

commit sha 539fe7b1c1e8e2a042a37d20216e40e5f01f94d8

Bump libc from 0.2.79 to 0.2.80 Bumps [libc](https://github.com/rust-lang/libc) from 0.2.79 to 0.2.80. - [Release notes](https://github.com/rust-lang/libc/releases) - [Commits](https://github.com/rust-lang/libc/compare/0.2.79...0.2.80) Signed-off-by: dependabot[bot] <support@github.com>

view details

Alexander Batischev

commit sha 4ffa8c5ffa3d2410693a5f9a02be0bd73d94129c

Merge pull request #1246 from newsboat/dependabot/cargo/libc-0.2.80 Bump libc from 0.2.79 to 0.2.80

view details

Dennis van der Schagt

commit sha fee20da19a2592e7e360ea77f94e15fbd5291a1c

Use correct order of fields when specifying OP_INT_RESIZE mapping "RESIZE" is the so-called event as returned from stfl (in the same way as regular key-presses are registered). So, "RESIZE" should be put in the `default_key` field. The code which handled OP_INT_RESIZE was never called (before this fix). Removing it in favor of a more generic approach when implementing the idea from https://github.com/newsboat/newsboat/issues/390.

view details

Dennis van der Schagt

commit sha 8b674f81aec5fc47aa716f11f6447f25d6ad9ffe

On RESIZE, recalculate widget dimensions and tell forms to redraw

view details

Dennis van der Schagt

commit sha 8871dbf16bd9b3c21fe8f1b34a5365323e7b5a0f

In {file,dir}browsers, redraw heading on RESIZE

view details

Dennis van der Schagt

commit sha 8fb30ebc824aed0a873a377f5eb48728ec398a0e

Update heading of SelectFormAction on RESIZE

view details

Dennis van der Schagt

commit sha fa0c1ac52174ec37faa286cc1c0a6ed7aed62c8d

Reuse `do_redraw` in DialogsFormAction (instead of `update_list`)

view details

Dennis van der Schagt

commit sha 011c3ae278ca75a5587eae64bbaab03a49b481b8

Update heading of DialogsFormAction on RESIZE

view details

Dennis van der Schagt

commit sha 9ae8ce1a40124e1809c0f205af0326f56b821526

Update heading of UrlViewFormAction on RESIZE

view details

Dennis van der Schagt

commit sha ff2e3210a823b468e0eceeefc399a0081af826da

podboat: Redraw downloads list on RESIZE This also introduced RESIZE handling for the help dialog but that form currently does not depend on the terminal dimensions.

view details

Dennis van der Schagt

commit sha 522df62a7693ccddeeb618f4790c9d761b507ad2

Merge pull request #1244 from dennisschagt/feature/handle-terminal-resize Redraw forms when terminal is resized

view details

Alexander Batischev

commit sha 547400f0a3d53765e45c37eac690b940b6c48477

Merge pull request #1240 from newsboat/feature/add-clang-11-to-ci Add Clang 11 to CI

view details

Dennis van der Schagt

commit sha 0df41e2928140f81c57a5cea4145da0832722206

Use REQUIRE_FALSE instead of REQUIRE with `== false`

view details

Dennis van der Schagt

commit sha a57f1beb744649a2dc314b9ef237a85ad9cb550b

opml::import(): Break out of loop when detecting an error

view details

Dennis van der Schagt

commit sha d09f9e3fd3ca978e0a20e63bdeb906c9592baf82

Document return value of FileUrlReader's reload() and write_config()

view details

Dennis van der Schagt

commit sha 7355f143d3d3c105bd4c49cd090cf921f76374bb

Merge pull request #1245 from dennisschagt/bugfix/issue-439 Show error message when a URL reader cannot open the urls file

view details

push time in 4 days

delete branch dennisschagt/newsboat

delete branch : bugfix/issue-439

delete time in 4 days

push eventnewsboat/newsboat

Dennis van der Schagt

commit sha e83ed2fb8776017dfaabce5933cae35fde756b93

Return error from UrlReader::reload() when file cannot be opened

view details

Dennis van der Schagt

commit sha 036c637f72ec873fc4a7986138684d9ccd4de12b

Return error from FileUrlReader::write_config() when file cannot be opened

view details

Dennis van der Schagt

commit sha f5eadf48e19e2b683d7ce1c9fa63be278b62b254

Test if FileUrlReader returns error message when failing to open file

view details

Dennis van der Schagt

commit sha 0df41e2928140f81c57a5cea4145da0832722206

Use REQUIRE_FALSE instead of REQUIRE with `== false`

view details

Dennis van der Schagt

commit sha a57f1beb744649a2dc314b9ef237a85ad9cb550b

opml::import(): Break out of loop when detecting an error

view details

Dennis van der Schagt

commit sha d09f9e3fd3ca978e0a20e63bdeb906c9592baf82

Document return value of FileUrlReader's reload() and write_config()

view details

Dennis van der Schagt

commit sha 7355f143d3d3c105bd4c49cd090cf921f76374bb

Merge pull request #1245 from dennisschagt/bugfix/issue-439 Show error message when a URL reader cannot open the urls file

view details

push time in 4 days

PR merged newsboat/newsboat

Show error message when a URL reader cannot open the urls file

Fixes https://github.com/newsboat/newsboat/issues/439.

Follow-up on https://github.com/newsboat/newsboat/pull/882#pullrequestreview-391894876.

+260 -111

3 comments

25 changed files

dennisschagt

pr closed time in 4 days

issue closednewsboat/newsboat

Wrong Error: no URLs configured

Newsboat

type \newsboat
newsboat is hashed (/snap/bin/newsboat)

$ newsboat -v
newsboat r2.14-dirty - https://newsboat.org/
Copyright (C) 2006-2015 Andreas Krennmair
Copyright (C) 2015-2018 Alexander Batischev
Copyright (C) 2006-2017 Newsbeuter contributors
Copyright (C) 2017-2018 Newsboat contributors

Newsboat is free software licensed under the MIT License. (Type `/snap/newsboat/679/usr/local/bin/newsboat -vv' to see the full text.)
It bundles JSON for Modern C++ library, licensed under the MIT License: https://github.com/nlohmann/json
It bundles an alphanum algorithm implementation licensed under the MIT license: http://www.davekoelle.com/alphanum.html

newsboat r2.14-dirty
System: Linux 4.15.0-45-generic (x86_64)
Compiler: g++ 5.4.0 20160609
ncurses: ncurses 6.0.20160213 (compiled with 6.0)
libcurl: libcurl/7.47.0 OpenSSL/1.0.2g zlib/1.2.8 libidn/1.32 librtmp/2.3 (compiled with 7.47.0)
SQLite: 3.11.0 (compiled with 3.11.0)
libxml2: compiled with 2.9.3

URL File

$ cat ~/.newsboat/Urls/GeneratedUrls/News.csv

http://swaminomics.org/?feed=rss2 Editorial ~Swaminomics News
https://www.youtube.com/feeds/videos.xml?playlist_id=PLfa0eRI2uIaSr47UhbEnVFArKa60qO8bu News ~PrintBarkha  YouTube

Following Doesn't Work

$ newsboat -u ~/.newsboat/Urls/GeneratedUrls/News.csv  -C ~/.newsboat/configStarting newsboat r2.14-dirty...
Loading configuration...done.
Opening cache...done.
Loading URLs from /home/nikhil/.newsboat/Urls/GeneratedUrls/News.csv...done.
Error: no URLs configured. Please fill the file /home/nikhil/.newsboat/Urls/GeneratedUrls/News.csvwith RSS feed URLs or import an OPML file.

Url file, when copied to the default location, works as follows.

$ newsboat -C ~/.newsboat/config
Starting newsboat r2.14-dirty...
Loading configuration...done.
Opening cache...done.
Loading URLs from /home/nikhil/snap/newsboat/679/.newsboat/urls...done.
Loading articles from cache...done.
Cleaning up cache...done.

closed time in 4 days

anishmittal2020

pull request commentnewsboat/newsboat

Show error message when a URL reader cannot open the urls file

Thank you for the review!

dennisschagt

comment created time in 4 days

Pull request review commentnewsboat/newsboat

Show error message when a URL reader cannot open the urls file

 TEST_CASE("Preserves URLs as-is", "[FileUrlReader][issue926]") 	REQUIRE(u.get_urls()[0] == 		R"_(exec:curl --silent https://feeds.metaebene.me/raumzeit/m4a  | sed 's#\(</guid>\|</id>\)#-M4A&#')_"); }++TEST_CASE("URL reader returns error message if file cannot be opened",+	"[FileUrlReader]")+{+	const std::string testDataPath("data/test-urls.txt");++	TestHelpers::TempFile urlsFile;+	FileUrlReader u(urlsFile.get_path());++	SECTION("reload() returns error message if file does not exist") {+		const auto error_message = u.reload();+		REQUIRE(error_message.has_value());++		SECTION("the error message contains the filename") {+			INFO("error_message: " + error_message.value());+			REQUIRE(error_message.value().find(urlsFile.get_path()) != std::string::npos);+		}+	}++	SECTION("write_config() works fine if file does not exist") {+		const auto error_message = u.write_config();+		REQUIRE(error_message.has_value() == false);

Done, thanks

dennisschagt

comment created time in 4 days

PullRequestReviewEvent

Pull request review commentnewsboat/newsboat

Show error message when a URL reader cannot open the urls file

 void rec_find_rss_outlines( 	} } -bool opml::import(+nonstd::optional<std::string> opml::import( 	const std::string& filename, 	FileUrlReader& urlcfg) { 	xmlDoc* doc = xmlReadFile(filename.c_str(), nullptr, 0); 	if (doc == nullptr) {-		return false;+		return strprintf::fmt(_("Error: Failed to parse OPML file \"%s\""), filename); 	} -	xmlNode* root = xmlDocGetRootElement(doc);+	nonstd::optional<std::string> error_message; +	xmlNode* root = xmlDocGetRootElement(doc); 	for (xmlNode* node = root->children; node != nullptr; 		node = node->next) { 		if (strcmp((const char*)node->name, "body") == 0) { 			LOG(Level::DEBUG, "opml::import: found body"); 			rec_find_rss_outlines(urlcfg, node->children, "");-			urlcfg.write_config();+			error_message =+				urlcfg.write_config(); // Only an error if optional string has a value

That indeed makes sense, thanks.

dennisschagt

comment created time in 4 days

PullRequestReviewEvent

Pull request review commentnewsboat/newsboat

Show error message when a URL reader cannot open the urls file

 class FileUrlReader : public UrlReader { public: 	explicit FileUrlReader(const std::string& file = ""); -	void reload() override;+	nonstd::optional<std::string> reload() override; 	std::string get_source() override;  	/// \brief Write URLs back to the input file. 	/// 	/// This method is used after importing feeds from OPML.-	void write_config();

Does https://github.com/newsboat/newsboat/pull/1245/commits/d09f9e3fd3ca978e0a20e63bdeb906c9592baf82 suffice?

dennisschagt

comment created time in 4 days

PullRequestReviewEvent

push eventdennisschagt/newsboat

Dennis van der Schagt

commit sha 0df41e2928140f81c57a5cea4145da0832722206

Use REQUIRE_FALSE instead of REQUIRE with `== false`

view details

Dennis van der Schagt

commit sha a57f1beb744649a2dc314b9ef237a85ad9cb550b

opml::import(): Break out of loop when detecting an error

view details

Dennis van der Schagt

commit sha d09f9e3fd3ca978e0a20e63bdeb906c9592baf82

Document return value of FileUrlReader's reload() and write_config()

view details

push time in 4 days

delete branch dennisschagt/newsboat

delete branch : feature/handle-terminal-resize

delete time in 5 days

pull request commentnewsboat/newsboat

Redraw forms when terminal is resized

Thank you for the review!

dennisschagt

comment created time in 5 days

push eventnewsboat/newsboat

Dennis van der Schagt

commit sha fee20da19a2592e7e360ea77f94e15fbd5291a1c

Use correct order of fields when specifying OP_INT_RESIZE mapping "RESIZE" is the so-called event as returned from stfl (in the same way as regular key-presses are registered). So, "RESIZE" should be put in the `default_key` field. The code which handled OP_INT_RESIZE was never called (before this fix). Removing it in favor of a more generic approach when implementing the idea from https://github.com/newsboat/newsboat/issues/390.

view details

Dennis van der Schagt

commit sha 8b674f81aec5fc47aa716f11f6447f25d6ad9ffe

On RESIZE, recalculate widget dimensions and tell forms to redraw

view details

Dennis van der Schagt

commit sha 8871dbf16bd9b3c21fe8f1b34a5365323e7b5a0f

In {file,dir}browsers, redraw heading on RESIZE

view details

Dennis van der Schagt

commit sha 8fb30ebc824aed0a873a377f5eb48728ec398a0e

Update heading of SelectFormAction on RESIZE

view details

Dennis van der Schagt

commit sha fa0c1ac52174ec37faa286cc1c0a6ed7aed62c8d

Reuse `do_redraw` in DialogsFormAction (instead of `update_list`)

view details

Dennis van der Schagt

commit sha 011c3ae278ca75a5587eae64bbaab03a49b481b8

Update heading of DialogsFormAction on RESIZE

view details

Dennis van der Schagt

commit sha 9ae8ce1a40124e1809c0f205af0326f56b821526

Update heading of UrlViewFormAction on RESIZE

view details

Dennis van der Schagt

commit sha ff2e3210a823b468e0eceeefc399a0081af826da

podboat: Redraw downloads list on RESIZE This also introduced RESIZE handling for the help dialog but that form currently does not depend on the terminal dimensions.

view details

Dennis van der Schagt

commit sha 522df62a7693ccddeeb618f4790c9d761b507ad2

Merge pull request #1244 from dennisschagt/feature/handle-terminal-resize Redraw forms when terminal is resized

view details

push time in 5 days

PR merged newsboat/newsboat

Redraw forms when terminal is resized

Fixes https://github.com/newsboat/newsboat/issues/389. Fixes https://github.com/newsboat/newsboat/issues/390.

+105 -53

3 comments

16 changed files

dennisschagt

pr closed time in 5 days

issue closednewsboat/newsboat

Handle terminal resizes

Our FormAction classes (feedlist, itemview etc.) should react to terminal resizes by redrawing their contents. Feedlist and itemlist already do this, and can be used as examples.

This is a tracking issue for the whole effort.

I think the best way to implement this is:

  1. introduce redraw() method for FormAction, provide empty implementations for all classes that inherit it;

  2. add case OP_INT_RESIZE to FormAction::process_op. It should call this->redraw();

  3. implement redraw() for all classes that inherit from FormAction:

    • [ ] DialogsFormAction
    • [ ] FeedListFormAction (just move these lines)
    • [ ] FileBrowserFormAction
    • [ ] HelpFormAction
    • [ ] ItemListFormAction (just move these lines)
    • [ ] ItemViewFormAction (fixes #389)
    • [ ] SelectFormAction
    • [ ] UrlViewFormAction

    ListFormAction is absent from this list because from the code in feedlistformaction.cpp and itemlistformaction.cpp it doesn't appear like resizing can be handled in generic way for all lists. Whoever works on this can re-evaluate, though.

closed time in 5 days

Minoru

issue closednewsboat/newsboat

Feeds are not correctly rendered when terminal window is resized

Hi,

It seems feeds are not completely displayed when terminal is resized. text lines can be outside of window. Maybe SIGWINCH(28) signal can trigger update of html rendering ?

BR.

closed time in 5 days

Busyvar
PullRequestReviewEvent

Pull request review commentnewsboat/newsboat

Redraw forms when terminal is resized

 void PbView::run(bool auto_download, bool wrap_scroll) 			continue; 		} +		if (strcmp(event, "RESIZE") == 0) {+			handle_resize();

Done

dennisschagt

comment created time in 5 days

push eventdennisschagt/newsboat

Dennis van der Schagt

commit sha 9336fc1ba81c634345180bf666df0d336a2ef130

Add help option to UrlViewFormAction

view details

jartigag

commit sha d38b71810f3682bcc261bbe9df519d16e4fbab8a

add contrib/exportOPMLWithTags.py

view details

Alexander Batischev

commit sha 9be947022414e317bb5f48237a6e6b9f4392cb2b

Merge pull request #1243 from jartigag/master Add contrib/exportOPMLWithTags.py

view details

Alexander Batischev

commit sha 637917fc93dbbbe93c8025071b13b13fdf65efd8

Merge pull request #1241 from dennisschagt/feature/help-dialog-for-urlview Add help option to UrlViewFormAction

view details

Dennis van der Schagt

commit sha fee20da19a2592e7e360ea77f94e15fbd5291a1c

Use correct order of fields when specifying OP_INT_RESIZE mapping "RESIZE" is the so-called event as returned from stfl (in the same way as regular key-presses are registered). So, "RESIZE" should be put in the `default_key` field. The code which handled OP_INT_RESIZE was never called (before this fix). Removing it in favor of a more generic approach when implementing the idea from https://github.com/newsboat/newsboat/issues/390.

view details

Dennis van der Schagt

commit sha 8b674f81aec5fc47aa716f11f6447f25d6ad9ffe

On RESIZE, recalculate widget dimensions and tell forms to redraw

view details

Dennis van der Schagt

commit sha 8871dbf16bd9b3c21fe8f1b34a5365323e7b5a0f

In {file,dir}browsers, redraw heading on RESIZE

view details

Dennis van der Schagt

commit sha 8fb30ebc824aed0a873a377f5eb48728ec398a0e

Update heading of SelectFormAction on RESIZE

view details

Dennis van der Schagt

commit sha fa0c1ac52174ec37faa286cc1c0a6ed7aed62c8d

Reuse `do_redraw` in DialogsFormAction (instead of `update_list`)

view details

Dennis van der Schagt

commit sha 011c3ae278ca75a5587eae64bbaab03a49b481b8

Update heading of DialogsFormAction on RESIZE

view details

Dennis van der Schagt

commit sha 9ae8ce1a40124e1809c0f205af0326f56b821526

Update heading of UrlViewFormAction on RESIZE

view details

Dennis van der Schagt

commit sha ff2e3210a823b468e0eceeefc399a0081af826da

podboat: Redraw downloads list on RESIZE This also introduced RESIZE handling for the help dialog but that form currently does not depend on the terminal dimensions.

view details

push time in 5 days

Pull request review commentnewsboat/newsboat

Redraw forms when terminal is resized

 void PbView::run_help() 			continue; 		} +		if (strcmp(event, "RESIZE") == 0) {+			handle_resize();

It is not strictly necessary but it is indeed good to add it for consistency.

dennisschagt

comment created time in 5 days

PullRequestReviewEvent

PR opened newsboat/newsboat

Show error message when a URL reader cannot open the urls file

Fixes https://github.com/newsboat/newsboat/issues/439.

Follow-up on https://github.com/newsboat/newsboat/pull/882#pullrequestreview-391894876.

+251 -109

0 comment

25 changed files

pr created time in 6 days

push eventdennisschagt/newsboat

Dennis van der Schagt

commit sha f5eadf48e19e2b683d7ce1c9fa63be278b62b254

Test if FileUrlReader returns error message when failing to open file

view details

push time in 6 days

push eventdennisschagt/newsboat

Dennis van der Schagt

commit sha e83ed2fb8776017dfaabce5933cae35fde756b93

Return error from UrlReader::reload() when file cannot be opened

view details

Dennis van der Schagt

commit sha 036c637f72ec873fc4a7986138684d9ccd4de12b

Return error from FileUrlReader::write_config() when file cannot be opened

view details

push time in 6 days

create barnchdennisschagt/newsboat

branch : bugfix/issue-439

created branch time in 6 days

push eventdennisschagt/newsboat

Dennis van der Schagt

commit sha 9336fc1ba81c634345180bf666df0d336a2ef130

Add help option to UrlViewFormAction

view details

jartigag

commit sha d38b71810f3682bcc261bbe9df519d16e4fbab8a

add contrib/exportOPMLWithTags.py

view details

Alexander Batischev

commit sha 9be947022414e317bb5f48237a6e6b9f4392cb2b

Merge pull request #1243 from jartigag/master Add contrib/exportOPMLWithTags.py

view details

Alexander Batischev

commit sha 637917fc93dbbbe93c8025071b13b13fdf65efd8

Merge pull request #1241 from dennisschagt/feature/help-dialog-for-urlview Add help option to UrlViewFormAction

view details

push time in 6 days

pull request commentnewsboat/newsboat

Feature/handle terminal resize

I tested the resize functionality with the following configuration:

articlelist-format "%4i %n%d %?n?unread&  read? %D %6L %?F?->%F<-?%>- %?T?|%-17T|  ?%t"
articlelist-title-format "%>- %N %V - Articles in feed '%T' (%u unread, %t total) - %U"
dialogs-title-format "%N %V %>- Dialogs"
dirbrowser-title-format "%N %V %>- %?O?Open Directory&Save File? - %f"
feedlist-format "%4i %?n?unread&  read? %11u %>. %t"
feedlist-title-format "%N %V - Showing %t (%u unread) feeds %>- Your feeds (%u unread, %t total)%?T? - tag `%T'&?"
filebrowser-title-format "%N %V %>- %?O?Open File&Save File? - %f"
help-title-format "%N %V %>- Help"
itemview-title-format "%N %V FEED_TITLE:%F %>- Article '%T' (%u unread, %t total)"
searchresult-title-format "%N %V %>- Search result (%u unread, %t total)"
selectfilter-title-format "%N %V %>- Select Filter"
selecttag-format "%4i %>- %T (%u)"
selecttag-title-format "%N %V %>- Select Tag"
urlview-title-format "%N %V %>- URLs"
podlist-format "%4i [%6dMB/%6tMB] [%5p %%] [%12K] %S %>. %u → %F"

This configuration makes it possible to see if the right-aligned text sticks to the side of the window (or, before applying the fixes, gets clipped).

dennisschagt

comment created time in 7 days

PR opened newsboat/newsboat

Feature/handle terminal resize

Fixes https://github.com/newsboat/newsboat/issues/389. Fixes https://github.com/newsboat/newsboat/issues/390.

+103 -53

0 comment

16 changed files

pr created time in 7 days

push eventdennisschagt/newsboat

Dennis van der Schagt

commit sha 025cd54476219fda189711ee9fdc60f40aa07b8c

podboat: Redraw downloads list on RESIZE This also introduced RESIZE handling for the help dialog but that form currently does not depend on the terminal dimensions.

view details

push time in 7 days

push eventdennisschagt/newsboat

Dennis van der Schagt

commit sha 1e9262b03c9d77bd939e095d6bc179d461aedb46

Update heading of UrlViewFormAction on RESIZE

view details

push time in 7 days

push eventdennisschagt/newsboat

Dennis van der Schagt

commit sha 679411158081dc93ef2399ad377aed13a71c5fe6

Update heading of DialogsFormAction on RESIZE

view details

push time in 7 days

push eventdennisschagt/newsboat

Dennis van der Schagt

commit sha 5731de5273f9ec90f4521be5c07f462189f969de

Reuse `do_redraw` in DialogsFormAction (instead of `update_list`)

view details

push time in 7 days

push eventdennisschagt/newsboat

Dennis van der Schagt

commit sha 254110725c388bb230f56657766713f214752009

Update heading of SelectFormAction on RESIZE

view details

push time in 7 days

push eventdennisschagt/newsboat

Dennis van der Schagt

commit sha 1dd2194e0058602863c8c00bc23965e9c363ab79

In {file,dir}browsers, redraw heading on RESIZE

view details

push time in 7 days

delete branch dennisschagt/newsboat

delete branch : feature/help-dialog-for-urlview

delete time in 7 days

push eventdennisschagt/newsboat

Dennis van der Schagt

commit sha 9f34adfe0263e3609b00c0edb5567d318209a525

On RESIZE, recalculate widget dimensions and tell forms to redraw

view details

push time in 7 days

push eventdennisschagt/newsboat

push time in 7 days

push eventdennisschagt/newsboat

Dennis van der Schagt

commit sha 3a8789bfa36e8fc60c84737f662ab935b1c4aa8a

Add placeholder `resize()` methods to each of the FormActions

view details

push time in 7 days

create barnchdennisschagt/newsboat

branch : feature/handle-terminal-resize

created branch time in 7 days

push eventdennisschagt/newsboat

Alexander Batischev

commit sha f906d338219c4b002b84a74f478a2fed6db115a1

Release 2.19

view details

Alexander Batischev

commit sha 1e87518f2c6cc02fa0a2de42c26815ff343b0d0b

Prepare CHANGELOG for the next release

view details

dennisschagt

commit sha b268ea14ce7e518abbce4b77c12fd7e14a0ed6a6

selecttag-format: Use correct field name when requesting field width from stfl Related to: https://github.com/newsboat/newsboat/issues/88

view details

dennisschagt

commit sha 87b463b419aa4dd83243c5ff7f5e94e714e9195b

FeedListFormAction: Use correct STFL attribute to determine screen width

view details

dennisschagt

commit sha 460d444749f0e260f7271c25e08f6ade4a10c481

Add a redraw function to all of the FormAction implementations

view details

dennisschagt

commit sha b47784944a0c83d7fd021c0d253ae1b1ab14f94f

Call FormAction::redraw() on terminal resize

view details

Dennis van der Schagt

commit sha 6900b41ea8ea0c14b6c4399e1efd235b05bb7d26

Fix OP_INT_RESIZE keymapping by putting key ("EVENT") in correct field Remove old usage of OP_INT_RESIZE as it was not getting hit anyway. Will be replaced by more generic implementation.

view details

push time in 7 days

PR opened newsboat/newsboat

Make reload non-blocking in feedlist

Partial fix for:

  • https://github.com/newsboat/newsboat/issues/75
  • https://github.com/akrennmair/newsbeuter/issues/606

It is probably possible to apply the same fix to make reload non-blocking in the ItemListFormAction. However, I still need to verify this does not have unintended consequences.

The current changes have the effect that single-feed reloads will also start sending notifications (related to notify-program, before, notifications were only sent when finishing a reload-all action). To reproduce, add the following to the config file:

notify-program "notify-send"
notify-always yes

I think that should not happen, do others agree?

Marking as draft as I need to verify there are no other unintended changes.

+3 -1

0 comment

1 changed file

pr created time in 8 days

create barnchdennisschagt/newsboat

branch : feature/nonblocking-reload-feedlist

created branch time in 8 days

PR opened newsboat/newsboat

Add help option to UrlViewFormAction

Fixes https://github.com/newsboat/newsboat/issues/1218.

+5 -1

0 comment

2 changed files

pr created time in 8 days

create barnchdennisschagt/newsboat

branch : feature/help-dialog-for-urlview

created branch time in 8 days

push eventdennisschagt/newsboat

panvicka

commit sha 0d80e9632ed2030e8c1fa81cd7687b63f18214b3

fix issue #1235 - In docs, always capitalize Newsboat and Podboat

view details

Dennis van der Schagt

commit sha 961642b6f9d0f00e846f05701768580de6e4f423

Remove duplicate whiespace from item titles

view details

panvicka

commit sha 9dbea9d602c8379fa59fdad8620fbd889949202e

issue1235 made requested changes to PR

view details

Alexander Batischev

commit sha 01bb544f8f3729d7be3ef581f852eb2fe24a78d9

Merge pull request #1236 from panvicka/master In docs, always capitalize Newsboat and Podboat (#1235)

view details

Nicholas Defranco

commit sha 2b83e9358bcd4a69a0441542683e47950e6fc3be

Added support info added in --help output Suggested by issue #1233

view details

Nicholas Defranco

commit sha e634e90c17a56b50df62b9e84b3171b8b903ae85

Added support info in Podboat's --help

view details

Alexander Batischev

commit sha a9dae740fc0bcc32740f41bfe1b235d2a890aa43

Merge pull request #1239 from nick-cd/iss1233 Added support info in --help output

view details

David Brito

commit sha 450af6f28eb905155e13cf8f54aec24a97606735

add const to newsboat::ConfigActionHandler::dump_config

view details

Alexander Batischev

commit sha f78b177a945f1214d5d6a94ab5ceb9e8cda6331a

Merge pull request #1238 from davbrito/issue1234 Constify ConfigActionHandler::dump_config Fixes #1234

view details

Dennis van der Schagt

commit sha d9ae8a3e6bdfcba1943cd6183f51c457ae1afc73

Verify that RssItem::set_title() removes superfluous whitespace

view details

Alexander Batischev

commit sha fba9376b2b89b2b4eb55078db510a07d5a01816e

Merge pull request #1237 from dennisschagt/feature/consolidate-title-whitespace Remove duplicate whiespace from item titles when displaying in list/head Fixes #1227.

view details

push time in 8 days

delete branch dennisschagt/newsboat

delete branch : feature/consolidate-title-whitespace

delete time in 8 days

push eventdennisschagt/newsboat

Dennis van der Schagt

commit sha d9ae8a3e6bdfcba1943cd6183f51c457ae1afc73

Verify that RssItem::set_title() removes superfluous whitespace

view details

push time in 8 days

pull request commentnewsboat/newsboat

Remove duplicate whiespace from item titles when displaying in list/head

Sure, I expect to have time later this week.

dennisschagt

comment created time in 10 days

push eventdennisschagt/newsboat

Dennis van der Schagt

commit sha 961642b6f9d0f00e846f05701768580de6e4f423

Remove duplicate whiespace from item titles

view details

push time in 11 days

PR opened newsboat/newsboat

Remove duplicate whiespace from item titles when displaying in list/head

Fixes https://github.com/newsboat/newsboat/issues/1227.

This only removes duplicate spaces when displaying titles. It might make sense to remove duplicate whitespaces on a lower level (e.g. in getters like title()/get_title() or even when retrieving titles in Cache) but I'm not sure it is a good idea.

+2 -2

0 comment

2 changed files

pr created time in 11 days

create barnchdennisschagt/newsboat

branch : feature/consolidate-title-whitespace

created branch time in 11 days

issue commentnewsboat/newsboat

Itemlist doesn't squash consecutive spaces into one

I admit I'm baffled by the difference in behaviour. ItemListFormAction::item2formatted_line doesn't look too different from ItemViewFormAction::prepare; both of them use the same functions to format strings.

The "ItemView" uses utils::consolidate_whitespace() to remove duplicate spaces. This can be seen in the following gdb backtrace: image

The "ItemList" does not call any such function when formatting the article titles.

linwaytin

comment created time in 12 days

push eventdennisschagt/newsboat

A1RO

commit sha 61229ca3583c1c1c92a7a6d222909c81bd85ae80

add "media content" chapter

view details

A1RO

commit sha 5c83a88a44511dca6449da66e3da1131101e3f17

fix operation name in "media content" chapter

view details

anton

commit sha 7b8d468f3b5ad4841f98024138328eba38bc10d8

docs: move macro chapter just before podcast.

view details

anton

commit sha 07e19df14f9fbdd4f806fdd621df759858b96285

docs: move media content chapter to podcast.

view details

anton

commit sha 6bd7b612047e1fc0e818b15d50b65a2609a40113

docs: move podboat enqueue macro to podcast chapter.

view details

anton

commit sha bb8e8ea187128729eaf5b977faee52aa8d4fff59

docs: separate macro prefix to own paragraph. create "open links with external commands" chapter.

view details

anton

commit sha e9b186caae6874e67efbdd1beb41e339e3bfeecc

update existing doc

view details

anton

commit sha bba85e09476c2042c138e89a392a423fc3a85142

add brand new chapter about opening links

view details

anton

commit sha dda77b21f67dc9abedf5bf9003e6a44803273ffd

rewrite new chapter about streaming audio content

view details

Alexander Batischev

commit sha 043e31a49e399845f92f8ebf90702fa8a050de8d

CI: fail on Asciidoctor warnings and errors

view details

anton

commit sha 59227762a7e33c1058289bc3b43c20dd92032431

small fixes for readability

view details

anton

commit sha b0677060f0eb891477a26667e0e695dd4b123086

update according to comments

view details

anton

commit sha 4f40921739d24ea47a2d8d5a3b8c0b6e5edb7fea

url's number

view details

Alexander Batischev

commit sha 32418bf8b191f0f5aa8a62c34a798877fa652405

Merge pull request #1220 from newsboat/feature/fail-ci-on-asciidoctor-warnings CI: fail on Asciidoctor warnings and errors

view details

Dennis van der Schagt

commit sha 66a45fbd889080d07bd6a186ef182705c7ebf7d6

Support tab-completion and ^U/^K/^G/^W for cmdline in modal forms

view details

Dennis van der Schagt

commit sha cd28e00d16353814c75a1a438f23e7081867b50d

Deduplicate shortcut handling for qna/cmdline

view details

Alexander Batischev

commit sha a819406e6dc9300c8d67cfcb7ef752aa739638b1

Merge pull request #1226 from dennisschagt/bugfix/issue-893 Support tab-completion and ^U/^K/^G/^W for cmdline in modal forms

view details

Dennis van der Schagt

commit sha 65fc6b5f1e787526a51b77e245c76a60fba5b7d5

Extract xml-related functions from RssParser

view details

Dennis van der Schagt

commit sha 242c5f52ccc3f1a98c69a810fb52e2e0bfdebebc

Handle tags from rss media specification

view details

Dennis van der Schagt

commit sha 4fccfaa3729a9fa81d4bd06aba9cc5dec2c5cc57

Determine description type (html or plaintext) from media:description

view details

push time in 12 days

delete branch dennisschagt/newsboat

delete branch : feature/rss-media-extension

delete time in 21 days

push eventnewsboat/newsboat

Dennis van der Schagt

commit sha 65fc6b5f1e787526a51b77e245c76a60fba5b7d5

Extract xml-related functions from RssParser

view details

Dennis van der Schagt

commit sha 242c5f52ccc3f1a98c69a810fb52e2e0bfdebebc

Handle tags from rss media specification

view details

Dennis van der Schagt

commit sha 4fccfaa3729a9fa81d4bd06aba9cc5dec2c5cc57

Determine description type (html or plaintext) from media:description

view details

Dennis van der Schagt

commit sha 3f57ac3de79b95614d7e2d29ae7777e452d0d3e2

Test media:<...> tag handling for atom feeds

view details

Dennis van der Schagt

commit sha 0713a19c594a380612675c694855909762170471

Verify: rss media values do not overwrite if values (e.g. title) exist

view details

Dennis van der Schagt

commit sha f6807dab82e2dc27a4437a59c378eb4aef63663a

Test media:<...> parsing for RSS 2.0 feeds

view details

Dennis van der Schagt

commit sha 52dae855642878dd32773db9b94c7b98a29475c0

Merge pull request #1224 from dennisschagt/feature/rss-media-extension Implement rss media extension

view details

push time in 21 days

PR merged newsboat/newsboat

Implement rss media extension

Fixes https://github.com/newsboat/newsboat/issues/595 Specification: https://www.rssboard.org/media-rss#media-description

+379 -131

1 comment

13 changed files

dennisschagt

pr closed time in 21 days

issue closednewsboat/newsboat

Parse "media" namespace tags in Atom feeds

In some Atom feeds, e.g. from Youtube, the media namespace is used. It contains important tags like /feed/entry/media:group/media:description. It would be helpful if these were parsed and shown, too.

Example: https://www.youtube.com/feeds/videos.xml?user=llelectronics

closed time in 21 days

Eucyon

push eventdennisschagt/newsboat

Alexander Batischev

commit sha 043e31a49e399845f92f8ebf90702fa8a050de8d

CI: fail on Asciidoctor warnings and errors

view details

Alexander Batischev

commit sha 32418bf8b191f0f5aa8a62c34a798877fa652405

Merge pull request #1220 from newsboat/feature/fail-ci-on-asciidoctor-warnings CI: fail on Asciidoctor warnings and errors

view details

Dennis van der Schagt

commit sha 66a45fbd889080d07bd6a186ef182705c7ebf7d6

Support tab-completion and ^U/^K/^G/^W for cmdline in modal forms

view details

Dennis van der Schagt

commit sha cd28e00d16353814c75a1a438f23e7081867b50d

Deduplicate shortcut handling for qna/cmdline

view details

Alexander Batischev

commit sha a819406e6dc9300c8d67cfcb7ef752aa739638b1

Merge pull request #1226 from dennisschagt/bugfix/issue-893 Support tab-completion and ^U/^K/^G/^W for cmdline in modal forms

view details

Dennis van der Schagt

commit sha 65fc6b5f1e787526a51b77e245c76a60fba5b7d5

Extract xml-related functions from RssParser

view details

Dennis van der Schagt

commit sha 242c5f52ccc3f1a98c69a810fb52e2e0bfdebebc

Handle tags from rss media specification

view details

Dennis van der Schagt

commit sha 4fccfaa3729a9fa81d4bd06aba9cc5dec2c5cc57

Determine description type (html or plaintext) from media:description

view details

Dennis van der Schagt

commit sha 3f57ac3de79b95614d7e2d29ae7777e452d0d3e2

Test media:<...> tag handling for atom feeds

view details

Dennis van der Schagt

commit sha 0713a19c594a380612675c694855909762170471

Verify: rss media values do not overwrite if values (e.g. title) exist

view details

Dennis van der Schagt

commit sha f6807dab82e2dc27a4437a59c378eb4aef63663a

Test media:<...> parsing for RSS 2.0 feeds

view details

push time in 21 days

delete branch dennisschagt/newsboat

delete branch : bugfix/issue-893

delete time in 21 days

PR opened newsboat/newsboat

Support tab-completion and ^U/^K/^G/^W for cmdline in modal forms

Fixes https://github.com/newsboat/newsboat/issues/893.

+34 -21

0 comment

2 changed files

pr created time in 21 days

push eventdennisschagt/newsboat

Dennis van der Schagt

commit sha cd28e00d16353814c75a1a438f23e7081867b50d

Deduplicate shortcut handling for qna/cmdline

view details

push time in 21 days

push eventdennisschagt/newsboat

Dennis van der Schagt

commit sha 74424d41c0649201d13526c97e136718f7937356

Deduplicate shortcut handling for qna/cmdline

view details

push time in 21 days

create barnchdennisschagt/newsboat

branch : bugfix/issue-893

created branch time in 21 days

push eventdennisschagt/newsboat

Alexander Batischev

commit sha 0da91a88b096ec29cd74a62a84efa11e10d3a3bb

Docs: move dangling paragraphs into relevant chapters After we turned tables of settings into lists, some chapters got visually split in two: there's a part of the chapter, then a huge, multi-screen list, then another part of the chapter. This commit rearranges the text such that it always precedes tables, hopefully making the documentation easier to read.

view details

Alexander Batischev

commit sha c712db8dc1391cd7b756e549cec6b81eb3bea16e

Docs: move settings and operations into appendices These lists are now so huge that having them in the middle of the text breaks the reading flow. They're also the most referenced parts of the docs, so it makes sense to give them their own entries in the ToC.

view details

Lyse

commit sha cb4a280b1badadc70893bb5cedd9cbd3d0f91a36

Merge pull request #1202 from newsboat/feature/config-commands-in-appendices Docs: move config settings and operations into appendicies

view details

dependabot[bot]

commit sha 9c5b199aedc035eef0b71a394e1e5b6f0f54aa52

Bump chrono from 0.4.15 to 0.4.18 Bumps [chrono](https://github.com/chronotope/chrono) from 0.4.15 to 0.4.18. - [Release notes](https://github.com/chronotope/chrono/releases) - [Changelog](https://github.com/chronotope/chrono/blob/main/CHANGELOG.md) - [Commits](https://github.com/chronotope/chrono/compare/v0.4.15...v0.4.18) Signed-off-by: dependabot[bot] <support@github.com>

view details

dependabot[bot]

commit sha 516057c69841747a7636b163a58ea4540e4762a5

Merge pull request #1204 from newsboat/dependabot/cargo/chrono-0.4.18

view details

dependabot[bot]

commit sha 227b26901adb08d08f3104732e1e840bfef2a928

Bump libc from 0.2.77 to 0.2.78 Bumps [libc](https://github.com/rust-lang/libc) from 0.2.77 to 0.2.78. - [Release notes](https://github.com/rust-lang/libc/releases) - [Commits](https://github.com/rust-lang/libc/compare/0.2.77...0.2.78) Signed-off-by: dependabot[bot] <support@github.com>

view details

dependabot[bot]

commit sha fdd44cd2351a6346d858887a49e6426e054a4783

Merge pull request #1206 from newsboat/dependabot/cargo/libc-0.2.78

view details

dependabot[bot]

commit sha 5e62e11565e99592ebcd9b01f48fdd63447f1df4

Bump chrono from 0.4.18 to 0.4.19 Bumps [chrono](https://github.com/chronotope/chrono) from 0.4.18 to 0.4.19. - [Release notes](https://github.com/chronotope/chrono/releases) - [Changelog](https://github.com/chronotope/chrono/blob/main/CHANGELOG.md) - [Commits](https://github.com/chronotope/chrono/compare/v0.4.18...v0.4.19) Signed-off-by: dependabot[bot] <support@github.com>

view details

dependabot[bot]

commit sha d799e89038e18d4984e78ad32a2d96c5e32ac235

Merge pull request #1207 from newsboat/dependabot/cargo/chrono-0.4.19

view details

Alexander Batischev

commit sha 40ab04083491dba02db92f5166fca38b87ac0c34

Improve docs for `save` and `save-all` This commit fixes a couple issues: 1. it doesn't use the name of the operation to describe it. This helps searchability, as there are now two keywords in the text ("save" and "export"); 2. it mentions that the output format is plain text. Commandline doc already hinted at that via ".txt" extension, but I made it clear in the text as well. Inspired by #1210.

view details

Lysander Trischler

commit sha 689d80cfc39a386ea18a54a26bf4643182919f55

Fix typo

view details

Lyse

commit sha 31fb2c92ec31b3c7f772b2316880ba7fa4e0c603

Merge pull request #1211 from newsboat/feature/improve-save-op-docs Improve docs for `save` and `save-all`

view details

anton

commit sha 002316d63e4e98e8e04b845c1af260a5a3b07657

docs: clarify open-in-browser operation. reorder open url 10.

view details

anton

commit sha c2fa0d57c9d8bc671c8c7a762703453c6f6dae74

docs: clarify the meaning of selection.

view details

Tarishi Jain

commit sha b918f2b642206838afaef16b8302dff3121c984e

#1214 Add setting to skip confirmation of marking feeds read

view details

Tarishi Jain

commit sha 45f008fd250a84b4a56666f9a457682a651440cd

#1214 Add setting to skip confirmation of marking feeds read

view details

Tarishi Jain

commit sha 4b8b77ea82b282b1ceb6cfda01ffed53ad97ec79

#1214 Add setting to skip confirmation of marking feeds read

view details

anton

commit sha a1d7641e16635e42058d0c278b8bd6df956d3a35

docs: update open-in-browser descriptions. fix article view -> list.

view details

anton

commit sha 874025a4c2282e5d7149fae231fbbc8e60e92bd8

docs: open-in-browser corrections.

view details

dependabot[bot]

commit sha 5143150a940cf52210421b1f290d8cd6e3cd30b5

Bump libc from 0.2.78 to 0.2.79 Bumps [libc](https://github.com/rust-lang/libc) from 0.2.78 to 0.2.79. - [Release notes](https://github.com/rust-lang/libc/releases) - [Commits](https://github.com/rust-lang/libc/compare/0.2.78...0.2.79) Signed-off-by: dependabot[bot] <support@github.com>

view details

push time in 21 days

Pull request review commentnewsboat/newsboat

Implement rss media extension

 #include "exception.h" #include "feed.h" #include "item.h"+#include "medianamespace.h" #include "rsspp_uris.h" #include "utils.h" #include "xmlutilities.h" +#define MEDIA_RSS_URI "http://search.yahoo.com/mrss/"

Yes, done

dennisschagt

comment created time in 21 days

PullRequestReviewEvent

Pull request review commentnewsboat/newsboat

Implement rss media extension

+#include "xmlutilities.h"++#include <cstring>++namespace rsspp {++std::string get_content(xmlNode* node)+{+	std::string retval;+	if (node) {+		xmlChar* content = xmlNodeGetContent(node);+		if (content) {+			retval = (const char*)content;+			xmlFree(content);+		}+	}+	return retval;+}++std::string get_xml_content(xmlNode* node, xmlDocPtr& doc)

Oops, fixed in "git fixup commit": https://github.com/newsboat/newsboat/pull/1224/commits/7183d43430cd4a4e3cf6c56963fe57e0cc53e289

dennisschagt

comment created time in 21 days

PullRequestReviewEvent

push eventdennisschagt/newsboat

Dennis van der Schagt

commit sha 369012e8d900642f25bba64b8d355b9a85158574

fixup! Handle tags from rss media specification

view details

Dennis van der Schagt

commit sha 7183d43430cd4a4e3cf6c56963fe57e0cc53e289

fixup! Extract xml-related functions from RssParser

view details

Dennis van der Schagt

commit sha 7d0c3886c06105e7e4bd009f6fd47821abd18123

fixup! Handle tags from rss media specification

view details

Dennis van der Schagt

commit sha 1bdf79bf25e095294e23052f1a9fc9716a10e7a5

Test media:<...> tag handling for atom feeds

view details

Dennis van der Schagt

commit sha d8b2f2c5e170a54760e93b1466b1759abcc0f8ab

Verify: rss media values do not overwrite if values (e.g. title) exist

view details

Dennis van der Schagt

commit sha 1c1e87d733ec0de8f3cff2830a707f180bcfbd9d

Test media:<...> parsing for RSS 2.0 feeds

view details

push time in 21 days

Pull request review commentnewsboat/newsboat

Implement rss media extension

 #include "feed.h" #include "item.h" #include "rsspp_uris.h"+#include "xmlutilities.h"

Also needed because of https://github.com/newsboat/newsboat/pull/1224/commits/1c26930f335a7aadc36680c12b91d57ce215955f.

dennisschagt

comment created time in 22 days

PullRequestReviewEvent
more