profile
viewpoint

apple/swift 53897

The Swift Programming Language

apple/swift-evolution 11546

This maintains proposals for changes and user-visible enhancements to the Swift Programming Language.

apple/swift-package-manager 8005

The Package Manager for the Swift Programming Language

apple/swift-corelibs-foundation 4029

The Foundation Project, providing core utilities, internationalization, and OS independence

apple/swift-corelibs-libdispatch 1894

The libdispatch Project, (a.k.a. Grand Central Dispatch), for concurrency on multicore hardware

apple/swift-corelibs-xctest 862

The XCTest Project, A Swift core library for providing unit test support

apple/swift-llbuild 797

A low-level build system, used by Xcode and the Swift Package Manager

apple/swift-lldb 645

This is the version of LLDB that supports the Swift programming language & REPL.

dberlin/llvm-gvn-rewrite 6

Rewriting LLVM GVN

push eventdcci/llvm-project

Davide Italiano

commit sha d3f5a5f87ffb13e90506423b9df4ce20605911a4

ODRTable, emit in the right section

view details

push time in a month

push eventdcci/llvm-project

Davide Italiano

commit sha af9754d09d1525e1dc99781b63ea8da7a7574294

Fix constructor.

view details

push time in a month

push eventdcci/llvm-project

Davide Italiano

commit sha c5354f9add1ec7b32146e5586fefe7f3c2dbd337

remove ODRTable reader stuffs.

view details

push time in a month

create barnchdcci/llvm-project

branch : odr

created branch time in a month

push eventllvm/llvm-test-suite

Davide Italiano

commit sha f95eba922b0a1b07e2c68734c9cc7d6c1754d744

[testsuite] Allow a (custom) linker to be specified. Differential Revision: https://reviews.llvm.org/D88061

view details

push time in a month

push eventllvm/llvm-project

Davide Italiano

commit sha 26c293c23d3b5cf4135fce0b1e61b70d6c4dd930

[BinaryFormat/MachO] Add a missing constant. Reference: https://opensource.apple.com/source/cctools/cctools-949.0.1/include/mach-o/loader.h.auto.html

view details

push time in a month

push eventdcci/dcci.github.io

Davide Italiano

commit sha 59b9658bf2941e2741b4843b5cb867367e5737a0

Remove an old (never finished) post.

view details

push time in a month

PullRequestReviewEvent

Pull request review commentapple/llvm-project

[lldb] Delete unused code

 RNBRunLoopMode RNBRunLoopGetStartModeFromRemote(RNBRemote *remote) {   return eRNBRunLoopModeExit; } +#if defined(WITH_FBS) || defined(WITH_BKS) || defined(WITH_SPRINGBOARD)

Jason should comment on this one.

kastiglione

comment created time in 2 months

Pull request review commentapple/llvm-project

[lldb] Delete unused code

 ValueObjectSP ABISysV_x86_64::GetReturnValueObjectImpl(         bool child_is_base_class = false;         int32_t child_byte_offset = 0; -        {

This looks like a mismerge to me.

kastiglione

comment created time in 2 months

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

pull request commentapple/swift

[benchmarks] Add an option to build with coverage info.

OK, updating.

dcci

comment created time in 2 months

pull request commentapple/swift

[benchmarks] Add an option to build with coverage info.

@swift-ci test

dcci

comment created time in 2 months

pull request commentapple/swift

[benchmarks] Add an option to build with coverage info.

To give people a little more context about this: I'm working on a script to test lldb and I'm using the benchmark suite executables as my corpora. Having coverage allows me to understand which lines are actually executed (or hot) and set breakpoints there accordingly.

dcci

comment created time in 2 months

PR opened apple/swift

Reviewers
[benchmarks] Add an option to build with coverage info.

<!-- What's in this pull request? --> Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

<!-- If this pull request resolves any bugs in the Swift bug tracker, provide a link: --> Resolves SR-NNNN.

<!-- Before merging this pull request, you must run the Swift continuous integration tests. For information about triggering CI builds via @swift-ci, see: https://github.com/apple/swift/blob/master/docs/ContinuousIntegration.md#swift-ci

Thank you for your contribution to Swift! -->

+16 -0

0 comment

3 changed files

pr created time in 2 months

create barnchdcci/swift

branch : bench-coverage

created branch time in 2 months

push eventapple/swift

Davide Italiano

commit sha b9c899a3906c21468fb9e15f4f8f5cdf0b31831c

[Package] Fix passing -gline-tables-only when building. We should do regardless of whether we run the tests or not. Also, clarify a comment while I'm here.

view details

Davide Italiano

commit sha e1d0ea2f80acf71780e4a0af20c247e4d15afcda

Merge pull request #33616 from dcci/the-piper-at-the-gates-of-dawn [Package] Fix passing -gline-tables-only when building.

view details

push time in 2 months

PR merged apple/swift

Reviewers
[Package] Fix passing -gline-tables-only when building.

We should do regardless of whether we run the tests or not. Also, clarify a comment while I'm here.

+7 -6

1 comment

1 changed file

dcci

pr closed time in 2 months

Pull request review commentapple/swift

[Package] Fix passing -gline-tables-only when building.

 verbose-build build-ninja build-swift-stdlib-unittest-extra -# When producing a package, don't copy the Swift Resource/ directory.-# This is mainly a space optimization.+# When building for an Xcode toolchain, don't copy the Swift Resource/ directory+# into the LLDB.framework. LLDB.framework will be installed alongside a Swift+# compiler, so LLDB should use its resource directory directly.+# Also, to reduce the size of the final toolchain, limit debug info to be+# line-tables only. extra-cmake-options=    -DLLDB_FRAMEWORK_COPY_SWIFT_RESOURCES=0+   -DCMAKE_C_FLAGS="-gline-tables-only"+   -DCMAKE_CXX_FLAGS="-gline-tables-only"

I guess this is resolved.

dcci

comment created time in 2 months

PullRequestReviewEvent

Pull request review commentapple/swift

[Package] Fix passing -gline-tables-only when building.

 verbose-build build-ninja build-swift-stdlib-unittest-extra -# When producing a package, don't copy the Swift Resource/ directory.-# This is mainly a space optimization.+# When building for an Xcode toolchain, don't copy the Swift Resource/ directory+# into the LLDB.framework. LLDB.framework will be installed alongside a Swift+# compiler, so LLDB should use its resource directory directly.+# Also, to reduce the size of the final toolchain, limit debug info to be+# line-tables only. extra-cmake-options=    -DLLDB_FRAMEWORK_COPY_SWIFT_RESOURCES=0+   -DCMAKE_C_FLAGS="-gline-tables-only"+   -DCMAKE_CXX_FLAGS="-gline-tables-only"

Also, I'm curious, what other toolchains you're talking about?

dcci

comment created time in 2 months

PullRequestReviewEvent

Pull request review commentapple/swift

[Package] Fix passing -gline-tables-only when building.

 verbose-build build-ninja build-swift-stdlib-unittest-extra -# When producing a package, don't copy the Swift Resource/ directory.-# This is mainly a space optimization.+# When building for an Xcode toolchain, don't copy the Swift Resource/ directory+# into the LLDB.framework. LLDB.framework will be installed alongside a Swift+# compiler, so LLDB should use its resource directory directly.+# Also, to reduce the size of the final toolchain, limit debug info to be+# line-tables only. extra-cmake-options=    -DLLDB_FRAMEWORK_COPY_SWIFT_RESOURCES=0+   -DCMAKE_C_FLAGS="-gline-tables-only"+   -DCMAKE_CXX_FLAGS="-gline-tables-only"

If we're uncertain, we should remove this. I can't picture in my mind the whole matrix of interactions with mixin et similia. It's just fundamentally odd this applies only when we don't run tests, so that's the attempt of unifying.

dcci

comment created time in 2 months

PullRequestReviewEvent

Pull request review commentapple/swift

[Package] Fix passing -gline-tables-only when building.

 verbose-build build-ninja build-swift-stdlib-unittest-extra -# When producing a package, don't copy the Swift Resource/ directory.-# This is mainly a space optimization.+# When building for an Xcode toolchain, don't copy the Swift Resource/ directory+# into the LLDB.framework. LLDB.framework will be installed alongside a Swift+# compiler, so LLDB should use its resource directory directly.+# Also, to reduce the size of the final toolchain, limit debug info to be+# line-tables only. extra-cmake-options=    -DLLDB_FRAMEWORK_COPY_SWIFT_RESOURCES=0+   -DCMAKE_C_FLAGS="-gline-tables-only"+   -DCMAKE_CXX_FLAGS="-gline-tables-only"

This is under

# OS X Package Builders
#===------------------------------------------------------------------------===#
[preset: mixin_osx_package_base]

Mishal, can you confirm it's safe?

dcci

comment created time in 2 months

PullRequestReviewEvent
PullRequestReviewEvent

pull request commentapple/swift

[Package] Fix passing -gline-tables-only when building.

@swift-ci test

dcci

comment created time in 2 months

pull request commentapple/swift

[Package] When building a toolchain, don't copy the Resource directory.

Comment fixed in: https://github.com/apple/swift/pull/33616

dcci

comment created time in 2 months

PR opened apple/swift

Reviewers
[Package] Fix passing -gline-tables-only when building.

We should do regardless of whether we run the tests or not. Also, clarify a comment while I'm here.

+7 -6

0 comment

1 changed file

pr created time in 2 months

create barnchdcci/swift

branch : the-piper-at-the-gates-of-dawn

created branch time in 2 months

push eventapple/swift

Davide Italiano

commit sha 8337f961d8c24bdbe333f38d826b414598c70ce0

[Package] When building a toolchain, don't copy the Resource directory. Should dramatically improve the size of the snapshost produced, as we don't have stdlib et similia included twice. Also, it helps when producing fat binaries, as we don't have to implement any mechanism for sandwiching all the slices together.

view details

Davide Italiano

commit sha ead41b4b0c34a8df8514177aefbf5616d18da6a8

Merge pull request #33598 from dcci/for-fox-sake-is-a-great-album [Package] When building a toolchain, don't copy the Resource directory.

view details

push time in 2 months

PR merged apple/swift

Reviewers
[Package] When building a toolchain, don't copy the Resource directory.

Should dramatically improve the size of the snapshost produced, as we don't have stdlib et similia included twice. Also, it helps when producing fat binaries, as we don't have to implement any mechanism for sandwiching all the slices together.

<!-- What's in this pull request? --> Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

<!-- If this pull request resolves any bugs in the Swift bug tracker, provide a link: --> Resolves SR-NNNN.

<!-- Before merging this pull request, you must run the Swift continuous integration tests. For information about triggering CI builds via @swift-ci, see: https://github.com/apple/swift/blob/master/docs/ContinuousIntegration.md#swift-ci

Thank you for your contribution to Swift! -->

+5 -0

7 comments

1 changed file

dcci

pr closed time in 2 months

Pull request review commentapple/swift

[Package] When building a toolchain, don't copy the Resource directory.

 verbose-build build-ninja build-swift-stdlib-unittest-extra +# When producing a package, don't copy the Swift Resource/ directory.+# This is mainly a space optimization.

I'll modify this before committing.

dcci

comment created time in 2 months

PullRequestReviewEvent

pull request commentapple/swift

[Package] When building a toolchain, don't copy the Resource directory.

(Incidentally, I noticed that we compile with -fdebug-info=line-tables-only (presumably, to reduce code size), but only when we don't run tests. This means that if the jobs producing the toolchains run tests, they won't benefit from this code size win. I'll file a separate PR for that, which should be a big net win in code size.

dcci

comment created time in 2 months

pull request commentapple/swift

[Package] When building a toolchain, don't copy the Resource directory.

I think this works, but I'll wait for Adrian or Mishal to take a look.

dcci

comment created time in 2 months

create barnchdcci/swift

branch : for-fox-sake-is-a-great-album

created branch time in 2 months

pull request commentapple/swift

[Package] When building a toolchain, don't copy the Resource directory.

@swift-ci build toolchain

dcci

comment created time in 2 months

PR opened apple/swift

Reviewers
[Package] When building a toolchain, don't copy the Resource directory.

Should dramatically improve the size of the snapshost produced, as we don't have stdlib et similia included twice. Also, it helps when producing fat binaries, as we don't have to implement any mechanism for sandwiching all the slices together.

<!-- What's in this pull request? --> Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

<!-- If this pull request resolves any bugs in the Swift bug tracker, provide a link: --> Resolves SR-NNNN.

<!-- Before merging this pull request, you must run the Swift continuous integration tests. For information about triggering CI builds via @swift-ci, see: https://github.com/apple/swift/blob/master/docs/ContinuousIntegration.md#swift-ci

Thank you for your contribution to Swift! -->

+5 -0

0 comment

1 changed file

pr created time in 2 months

push eventapple/llvm-project

Davide Italiano

commit sha 61591b93fa6f28b936db9e6beb6e057ffe2a860c

[Swift] Generalize a test so that it works on Apple Silicon.

view details

Davide Italiano

commit sha 41ac1ebffbffecf5438dcde4ed73c4e818262117

[TestSwiftExpressionObjCContext] Fix this test to run on device.

view details

push time in 2 months

PR opened apple/llvm-project

Cherry-pick commits from master-rebranch to master-next
+176348 -596

0 comment

1415 changed files

pr created time in 2 months

create barnchdcci/llvm-project

branch : patpat

created branch time in 2 months

push eventapple/llvm-project

Davide Italiano

commit sha 58b924525f05da675420eb23b676ee2d00dc8945

[TestSwiftExpressionObjCContext] Fix this test to run on device.

view details

Davide Italiano

commit sha 621c6b5eb60c1e0ffba99ea299ec30bbafab6935

Merge pull request #1663 from dcci/objc-test [TestSwiftExpressionObjCContext] Fix this test to run on device.

view details

push time in 2 months

push eventapple/llvm-project

Davide Italiano

commit sha cb77b0e8a427ada9f31d181026cacede1a22e85f

[Swift] Generalize a test so that it works on Apple Silicon.

view details

Davide Italiano

commit sha d30766f294d56162329b69a1f90e8622c05825ac

Merge pull request #1664 from dcci/got-me-wrong-by-alice-in-chains [Swift] Generalize a test so that it works on Apple Silicon.

view details

push time in 2 months

push eventapple/llvm-project

Davide Italiano

commit sha 10b04a1a51d5606e87019f1c006782775dc6a700

[TestPtrRefsObjC] Prefer `command script import`.

view details

Davide Italiano

commit sha 325564ccfa2442a774b3ffc84d7d8ce513b05ed0

[TestPtrRefs] Prefer `command script import`.

view details

Davide Italiano

commit sha c3dee48d1ff69735dd99dad08e9d327911f90dea

Merge pull request #1665 from dcci/cherry-me-patatino-patatino-i-mean-forever-sometimes Cherry-pick a couple of test fixes

view details

push time in 2 months

create barnchdcci/llvm-project

branch : objc-test

created branch time in 2 months

pull request commentapple/llvm-project

Cherry-pick a couple of test fixes

@swift-ci test

dcci

comment created time in 2 months

pull request commentapple/llvm-project

[Swift] Generalize a test so that it works on Apple Silicon.

@swift-ci test

dcci

comment created time in 2 months

create barnchdcci/llvm-project

branch : got-me-wrong-by-alice-in-chains

created branch time in 2 months

pull request commentapple/llvm-project

[TestSwiftExpressionObjCContext] Fix this test to run on device.

@swift-ci test

dcci

comment created time in 2 months

push eventllvm/llvm-project

Davide Italiano

commit sha 0cceb54366b406649fdfe7bb11b133ab96f3cd70

[TestPtrRefsObjC] Prefer `command script import`.

view details

push time in 2 months

push eventllvm/llvm-project

Davide Italiano

commit sha 8fcfe2862fd4fde4793e232cfeebe6c5540c80a5

[TestPtrRefs] Prefer `command script import`.

view details

push time in 2 months

Pull request review commentapple/llvm-project

Use new libReflection API when reading ELF files

 void llvm::format_provider<ObjectFile::Strata>::format(     break;   } }++llvm::StringRef ObjectFile::GetReflectionSectionIdentifier(+    swift::ReflectionSectionType section) {+  return "";

should this assert instead? It's always supposed to be overridden, no?

augusto2112

comment created time in 2 months

Pull request review commentapple/llvm-project

Make sure the Swift REPL is initialized with host OS availablity.

 Status TargetList::CreateTargetInternal(   ArchSpec platform_arch(arch);    bool prefer_platform_arch = false;+  auto update_platform_arch = [&](const ArchSpec &module_arch) {+    // If the OS or vendor weren't specified, then adopt the module's+    // architecture so that the platform matching can be more accurate.+    if (!platform_arch.TripleOSWasSpecified() ||+        !platform_arch.TripleVendorWasSpecified()) {

Is this check strict enough? I thought it should be only TripleOSWasSpecified -- what we can infer from the vendor?

adrian-prantl

comment created time in 3 months

push eventllvm/llvm-project

Davide Italiano

commit sha 57605758b5de3726eec1d6e587de1003af1ab5b7

[debugserver/Apple Silicon] Handoff connections when attaching to translated processes When we detect a process that the native debugserver cannot handle, handoff the connection fd to the translated debugserver.

view details

push time in 3 months

push eventapple/llvm-project

Davide Italiano

commit sha a9a054f5a5cbcf1581b6a56662a8bad49cf8e0a5

[Test] TSan tests work on Apple Silicon, skip them based on platform, not arch.

view details

Davide Italiano

commit sha e966de21c9ff9edcb098d508e1c206b3f5098373

Merge pull request #1516 from dcci/tsan-macos-arm64 [Test] TSan tests work on Apple Silicon, skip them based on platform,…

view details

push time in 3 months

push eventllvm/llvm-project

Davide Italiano

commit sha b1a6d373d5e0adbaa1ed70a9cadcfa84420a449f

[PlatformMacOSX] Remove unused variable. NFC.

view details

push time in 3 months

push eventllvm/llvm-project

Davide Italiano

commit sha cd05406b105334b01f0eae141e7e05d6fb4a2ecb

[testsuite] Adapt lldb-server base test helper to run on arm64

view details

push time in 3 months

pull request commentapple/llvm-project

[Test] TSan tests work on Apple Silicon, skip them based on platform,…

@swift-ci test

dcci

comment created time in 3 months

pull request commentapple/llvm-project

[Test] TSan tests work on Apple Silicon, skip them based on platform,…

@swift-ci test and merge

dcci

comment created time in 3 months

PR opened apple/llvm-project

Reviewers
[Test] TSan tests work on Apple Silicon, skip them based on platform,…

… not arch.

+2 -2

0 comment

2 changed files

pr created time in 3 months

create barnchdcci/llvm-project

branch : tsan-macos-arm64

created branch time in 3 months

push eventllvm/llvm-project

Davide Italiano

commit sha 001c8e1fd9f09d3de9ff6e64bdac4b8ca681dfb4

[PlatformDarwin] Add support for Apple Silicon. Gets another large chunk of the testsuite to pass.

view details

push time in 3 months

pull request commentapple/llvm-project

Implement TypeSystemSwiftTypeRef::getCanonicalType() (NFC)

That wouldn't hurt for sure.

adrian-prantl

comment created time in 3 months

Pull request review commentapple/llvm-project

Implement TypeSystemSwiftTypeRef::getCanonicalType() (NFC)

 SwiftASTContext::GetTypeInfo(opaque_compiler_type_t type,   return swift_flags; } -lldb::LanguageType-SwiftASTContext::GetMinimumLanguage(opaque_compiler_type_t type) {-  if (!type)-    return lldb::eLanguageTypeC;

This is a change in semantic that's pretty substantial -- probably for the best, but I wonder if we're always guaranteed that the type we receive is not null here?

adrian-prantl

comment created time in 3 months

more