Pull request review commentevless/yaspell

Added method removes ignored lines

+package checker++import (+	"math"+	"strings"+)++// IgnoreComment it's comment name+const IgnoreComment = "// ignore-spellcheck-next-line"

Думаю, что можно коммент над константой убрать. Плюс лучше использовать просто строку ignore-spellcheck-next-line, без //. Символы в разных файлах используются разные, а строка ignore-spellcheck-next-line вряд ли будет еще кто-то использоваться для каких-то других целей.

И, наверно, лучше сам коммент в стиле eslint исопльзовать toolname-disable-linetype, то есть yaspell-disable-next-line

evless

comment created time in 7 days

Pull request review commentevless/yaspell

Added method removes ignored lines

+// @flow

это не js-специфичный тул, не нужно в тесты закладывать js-файлы. Можно просто обычный файл со списком строк сделать:

Удобства и подробности
Описание
Мебель на\u00a0кухне
...
evless

comment created time in 7 days

startedvaleriansaliou/sonic

started time in 8 days

startedAssemblyScript/assemblyscript

started time in 22 days

startedveonim/veonim

started time in a month

startedonivim/oni2

started time in a month

PR opened nodules/vow-asker

update to asker 2.0.0

asker 2.0.0 has information about original error (^1.0.0 has no information about it)

+1 -1

0 comment

1 changed file

pr created time in 2 months

push eventdaynin/vow-asker

Sergey Golovin

commit sha d44ee83a3128268a34767660c76a7931da2e3693

update to asker 2.0.0 asker 2.0.0 has information about original error (^1.0.0 has no information about it)

view details

push time in 2 months

fork daynin/vow-asker

Vow promises wrapper on top of Asker API

fork in 2 months

startedgatsbyjs/gatsby

started time in 2 months

starteds4n7h0/xvwa

started time in 2 months

startedfastpack/fastpack

started time in 2 months

startedswc-project/swc

started time in 2 months

Pull request review commentdenoland/deno

Make integration tests standalone

 def integration_tests(deno_exe, test_filter = None):         print "... " + green_ok()  def main(argv):-    deno_exe = argv[1]+    parser = argparse.ArgumentParser()+    parser.add_argument("filter", help="Run specific tests")+    parser.add_argument("--release", help="Use release build of Deno",+                        action="store_true")+    parser.add_argument("--executable", help="Use external executable of Deno")+    args = parser.parse_args()++    target = None

[note] you can do it like this

target = "release" if args.release else "debug"
sh7dm

comment created time in 3 months

issue commentdenoland/deno

Space on website isn't distributed well

I think it's ok for 4k resolution (without any scaling). Even if we change the container's width, it'll change nothing because of the content length (sentences, charts, etc). Moreover, we'll get loooong sentences which will look strange

sh7dm

comment created time in 3 months

fork daynin/guide

A Guide to Deno Core (On design & For Contributors). Pretty much WIP

https://denolib.gitbook.io/guide

fork in 3 months

Pull request review commentdenoland/deno

Add emojis to permission prompts

 impl DenoPermissions {       return Ok(());     };     // TODO get location (where access occurred)-    let r = permission_prompt("Deno requests access to run a subprocess.");+    let r = permission_prompt(+      "👨‍👧  Deno requests access to run a subprocess.",

@sh7dm yes, of course

Subprocess: https://emojipedia.org/arrow-pointing-rightwards-then-curving-upwards/ Environment: https://emojipedia.org/personal-computer/ or https://emojipedia.org/desktop-computer/

sh7dm

comment created time in 3 months

Pull request review commentdenoland/deno

Add emojis to permission prompts

 impl DenoPermissions {       return Ok(());     };     // TODO get location (where access occurred)-    let r = permission_prompt("Deno requests access to run a subprocess.");+    let r = permission_prompt(+      "👨‍👧  Deno requests access to run a subprocess.",

It looks like processes swap some data or something else. I think, it may confuse users

sh7dm

comment created time in 3 months

Pull request review commentdenoland/deno

Don't insert final newline in .out files

 indent_style = space indent_size = 2 charset = utf-8 trim_trailing_whitespace = true++[*.out] # make editor neutral to .out files

We have to use newlines at the end of files because of https://stackoverflow.com/questions/729692/why-should-text-files-end-with-a-newline

I think there is no problem with it. We can just add newline in the test files or test cases

sh7dm

comment created time in 3 months

Pull request review commentdenoland/deno

Add emojis to permission prompts

 impl DenoPermissions {       return Ok(());     };     // TODO get location (where access occurred)-    let r = permission_prompt("Deno requests access to run a subprocess.");+    let r = permission_prompt(+      "👨‍👧  Deno requests access to run a subprocess.",

What do you think about this symbol ⤴️?

sh7dm

comment created time in 3 months

Pull request review commentdenoland/deno

Add emojis to permission prompts

 impl DenoPermissions {       return Ok(());     };     // TODO get location (where access occurred)-    let r =-      permission_prompt(&"Deno requests access to environment variables.");+    let r = permission_prompt(+      &"🧾  Deno requests access to environment variables.",

May be, it'll be better to use this one 💻 or this one 🖥️?

sh7dm

comment created time in 3 months

starteddenolib/awesome-deno

started time in 3 months

PR opened denoland/deno

Refactor markup of the site

<!-- https://github.com/denoland/deno/blob/master/.github/CONTRIBUTING.md -->

+114 -107

0 comment

1 changed file

pr created time in 3 months

push eventdaynin/deno

Sergey Golovin

commit sha 4aa3c79bd271ede5b9e377f7a112cc9762390ebc

Refactor markup of the site

view details

push time in 3 months

create barnchdaynin/deno

branch : refactor-markup

created branch time in 3 months

starteddenolib/animated-deno-logo

started time in 3 months

pull request commentdenoland/deno

Add console.table

@ry thank you! :)

daynin

comment created time in 3 months

push eventdaynin/deno

Sergey Golovin

commit sha 2f7177e6719afe08fd8f2358956abc1537503851

Add console.table - add console.table - add tests

view details

push time in 3 months

pull request commentdenoland/deno

Add console.table

@ry done

daynin

comment created time in 3 months

push eventdaynin/deno

Sergey Golovin

commit sha df2f93f8a8c7d24cb45707b9d45ffeccfd25eaa7

Add console.table - add console.table - add tests

view details

push time in 3 months

pull request commentdenoland/deno

Add console.table

@ry done

daynin

comment created time in 3 months

push eventdaynin/deno

Sergey Golovin

commit sha b4d01c0be34a9c2d2beacf658ba633655f3f14f7

Add console.table - add console.table - add tests

view details

push time in 3 months

push eventdaynin/deno

Sergey Golovin

commit sha dbc3692c8b520fd220852321cd1a9e99260c734d

Add console.table - add console.table - add tests

view details

push time in 3 months

PR opened denoland/deno

Add console.table
  • add console.table
  • add tests

Deno and Node outputs:

20190128234428

<!-- https://github.com/denoland/deno/blob/master/.github/CONTRIBUTING.md -->

+282 -1

0 comment

6 changed files

pr created time in 3 months

push eventdaynin/deno

Sergey Golovin

commit sha d9b52fe06f7a358a52f9e51610730425bc99eb15

Add console.table - add console.table - add tests

view details

push time in 3 months

push eventdaynin/deno

Sergey Golovin

commit sha 57bbd18419c4662bfc06415f15b1c4ae53c6f181

Add console.table - add console.table - add tests

view details

push time in 3 months

create barnchdaynin/deno

branch : add-console-table

created branch time in 3 months

issue commentdenoland/deno

Error on sync_third_party.py

Ok, I'll try

daynin

comment created time in 3 months

issue openeddenoland/deno

Error on running sync_third_party.py

Got this error when try to sync third party deps:

Installing collected packages: pypiwin32
Exception:
Traceback (most recent call last):
  File "/var/folders/9k/zcgn3n8d5k73n0r9w34g7rs40000gn/T/tmpN4npgM/lib/python/site-packages/pip/_internal/cli/base_command.py", line 176, in main
    status = self.run(options, args)
  File "/var/folders/9k/zcgn3n8d5k73n0r9w34g7rs40000gn/T/tmpN4npgM/lib/python/site-packages/pip/_internal/commands/install.py", line 393, in run
    use_user_site=options.use_user_site,
  File "/var/folders/9k/zcgn3n8d5k73n0r9w34g7rs40000gn/T/tmpN4npgM/lib/python/site-packages/pip/_internal/req/__init__.py", line 57, in install_given_reqs
    **kwargs
  File "/var/folders/9k/zcgn3n8d5k73n0r9w34g7rs40000gn/T/tmpN4npgM/lib/python/site-packages/pip/_internal/req/req_install.py", line 919, in install
    use_user_site=use_user_site, pycompile=pycompile,
  File "/var/folders/9k/zcgn3n8d5k73n0r9w34g7rs40000gn/T/tmpN4npgM/lib/python/site-packages/pip/_internal/req/req_install.py", line 445, in move_wheel_files
    warn_script_location=warn_script_location,
  File "/var/folders/9k/zcgn3n8d5k73n0r9w34g7rs40000gn/T/tmpN4npgM/lib/python/site-packages/pip/_internal/wheel.py", line 280, in move_wheel_files
    prefix=prefix,
  File "/var/folders/9k/zcgn3n8d5k73n0r9w34g7rs40000gn/T/tmpN4npgM/lib/python/site-packages/pip/_internal/locations.py", line 180, in distutils_scheme
    i.finalize_options()
  File "/usr/local/Cellar/python@2/2.7.15_2/Frameworks/Python.framework/Versions/2.7/lib/python2.7/distutils/command/install.py", line 264, in finalize_options
    "must supply either home or prefix/exec-prefix -- not both"
DistutilsOptionError: must supply either home or prefix/exec-prefix -- not both

created time in 3 months

delete branch daynin/deno

delete branch : refactor-files

delete time in 3 months

PR closed denoland/deno

Extract common code from "read" , "write" and "open"

<!-- https://github.com/denoland/deno/blob/master/.github/CONTRIBUTING.md -->

+62 -18

7 comments

1 changed file

daynin

pr closed time in 3 months

pull request commentdenoland/deno

Extract common code from "read" , "write" and "open"

@ry I think it can't be simplified another way, so I'll close the PR

daynin

comment created time in 3 months

pull request commentdenoland/deno

Extract common code from "read" , "write" and "open"

It seems to me, it's easier to support this code. @ry what do you think?

daynin

comment created time in 3 months

pull request commentdenoland/deno

Extract common code from "read" , "write" and "open"

Yes, but it removes copy-pasted code, and if we'll change something, for example, in getCommonBaseRes it'll applies to all functions

daynin

comment created time in 3 months

push eventdaynin/deno

Sergey Golovin

commit sha 7c785ea72f238b7af1d16709d0b2f01289f53256

Extract common code from "read" , "write" and "open"

view details

push time in 3 months

pull request commentdenoland/deno

Extract common code from "read" and "write" into "getBaseRes"

Can this generalize to all the other ops functions?

@hayd done

daynin

comment created time in 3 months

push eventdaynin/deno

Sergey Golovin

commit sha d40b50f0fcd32d95a2de4080c466599ba35a797e

Extract common code from "read" and "write" into "getBaseRes"

view details

push time in 3 months

pull request commentdenoland/deno

Extract common code from "read" and "write" into "getBaseRes"

@hayd I'll try to extract common code for "open"

daynin

comment created time in 3 months

push eventdaynin/deno

Sergey Golovin

commit sha 9b9bbdfdbeaaa7c33d2a953bab871095188397d9

Extract common code from "read" and "write" into "getBaseRes"

view details

push time in 3 months

starteddenoland/deno_std

started time in 3 months

PR opened denoland/deno

Extract common code from "read" and "write" into "getBaseRes"

<!-- https://github.com/denoland/deno/blob/master/.github/CONTRIBUTING.md -->

+40 -14

0 comment

1 changed file

pr created time in 3 months

push eventdaynin/deno

Sergey Golovin

commit sha a23e64a5a4b03496a95c367b09634f146a5db21a

Extract common code from "read" and "write" into "getBaseRes"

view details

push time in 3 months

create barnchdaynin/deno

branch : refactor-files

created branch time in 3 months

push eventdaynin/deno

Sergey Golovin

commit sha b8a7a89aea2c6e2b41085738abe03ae549b36a5a

Use functions for exit and printing help instead of "dot-commands"

view details

push time in 3 months

push eventdaynin/deno

Yoshiya Hinosawa

commit sha 77114fbda49382e397095d8214bd76996b0cfb57

chore: update license lines (#1557)

view details

Adam Conrad

commit sha e470f31d328884303e56f2f15a4121b8ffe097a6

Web API: CustomEvent (#1505)

view details

thefliik

commit sha 41cf82870b73d3a8254c518b27dc02dcbb5032f5

Minor optimization to repl.ts (#1561)

view details

jingweicai

commit sha 2547f0296fc77357b9c11f3bdc7414a68243e775

fix: set env,key for string and value for string (#1567)

view details

JaePil Jung

commit sha 7f88b5fff3fe8aed2073d4347d3ab847fc4c528a

Minor code cleanups (#1570)

view details

迷渡

commit sha 6904628aaa1c18e5438d0ec0564968094482b0c4

console output with format (#1565)

view details

binaryta

commit sha 4a0a47dcdeccdda03028a2753872c614b468e23a

Add console.clear() (#1562)

view details

Ryan Dahl

commit sha d0dc4deaad858babcb612b181986db254db64dfa

Upgrade tslint and friends (#1571)

view details

Dmitry Sharshakov

commit sha 34dbd315930b4c2544b587d1c0fbb16c3173bf45

Use shell installer in docs (#1574)

view details

push time in 3 months

pull request commentdenoland/deno

Use functions for exit and printing help instead of "dot-commands"

Using getters or proxy, we may be able to get it so that the parentheses don't need to be supplied

@ry done

daynin

comment created time in 3 months

push eventdaynin/deno

Sergey Golovin

commit sha e5c6f48fb64750db4f6d8c5a695c0c47a1dd3d71

Use functions for exit and printing help instead of "dot-commands"

view details

push time in 3 months

pull request commentdenoland/deno

Use functions for exit and printing help instead of "dot-commands"

@ry

@daynin Can you try to make these functions instead of specially parsed commands? done

daynin

comment created time in 3 months

push eventdaynin/deno

Sergey Golovin

commit sha 8c83063657d1738e55e4afc16effd2fe8b4c6813

Use functions for exit and printing help instead of "dot-commands"

view details

push time in 3 months

pull request commentdenoland/deno

Add .help command in repl

@ry ok, of course. But they will conflict with user space functions called same names. Is it ok?

daynin

comment created time in 3 months

pull request commentdenoland/deno

Add .help command in repl

@ry @kitsonk I removed .load command

daynin

comment created time in 3 months

push eventdaynin/deno

Sergey Golovin

commit sha 3dff5ab332068737a80c3bd8a3438da1ba14fe26

Add .help command in repl

view details

push time in 3 months

push eventdaynin/deno

Sergey Golovin

commit sha 3ddb1a7555e1083e9f8a6236a09e0e77ccb4276c

Add repl commands (.help and .load)

view details

push time in 3 months

more