profile
viewpoint
Dax McDonald daxmc99 @sourcegraph Phoenix, AZ https://daxmcdonald.dev/ What is the cat /proc/1/cgroup for life?

daxmc99/about 0

Sourcegraph blog, feature announcements, and website (about.sourcegraph.com)

daxmc99/AI_plays_snake 0

AI trained using Genetic Algorithm and Deep Learning to play the game of snake

daxmc99/autoscaler 0

Autoscaling components for Kubernetes

daxmc99/awesome-zoom-backgrounds 0

A community repo for humors

daxmc99/cases 0

for rancher support

daxmc99/challenges 0

Programming challenges I have done

daxmc99/chart-test 0

testing charts

delete branch sourcegraph/sourcegraph

delete branch : rfc196-ckpadding

delete time in a day

push eventsourcegraph/sourcegraph

Chayim

commit sha caa8f06f24bd0bd7a1ed727f881543fcdeb34c96

Rfc196 ckpadding (#12842) Co-authored-by: Chayim I. Kirshen <chayim@gnupower.net>

view details

push time in a day

PR merged sourcegraph/sourcegraph

Reviewers
Rfc196 ckpadding

The ability to check for the encoding of an object.

+19 -27

0 comment

3 changed files

chayim

pr closed time in a day

delete branch sourcegraph/sourcegraph

delete branch : rfc196/encrypt_all_things

delete time in a day

pull request commentsourcegraph/sourcegraph

Example of encryptColumns

Closing this for the steps outlined here https://docs.google.com/document/d/1e10UPwmI16VAQleBK81EQMMGTRBgihI1vwL5I6kicrA/edit#bookmark=id.abu4hz5jc1j3

daxmc99

comment created time in a day

Pull request review commentsourcegraph/sourcegraph

Rfc196 ckpadding

 type EncryptionError struct { 	Message string } +// NotEncodedError means we can test for whether or not a string is encoded, prior to attempting decryption+var NotEncodedError = errors.New("object is not encoded.")

This is used to determine if the string has been encoded at all. Use case of unencoded value to encoded test

chayim

comment created time in a day

pull request commentsourcegraph/sourcegraph

Example of encryptColumns

I think the best move here might be to bite the bullet and implement a function (or functions) per table that will encrypt the secrets in the background.

daxmc99

comment created time in 2 days

PR opened sourcegraph/sourcegraph

Initial commit for attempt at repo-updater refactor

<!-- Reminder: Have you updated the changelog and relevant docs (user docs, architecture diagram, etc) ? -->

+408 -13

0 comment

5 changed files

pr created time in 2 days

PR closed sourcegraph/sourcegraph

Repoupdater refactor

A very small attempt to move DB access code out of repoupdater.

<!-- Reminder: Have you updated the changelog and relevant docs (user docs, architecture diagram, etc) ? -->

+9045 -3761

0 comment

136 changed files

daxmc99

pr closed time in 2 days

create barnchsourcegraph/sourcegraph

branch : dax/repo-updaterRefactor

created branch time in 2 days

PR opened sourcegraph/sourcegraph

Repoupdater refactor

A very small attempt to move DB access code out of repoupdater.

<!-- Reminder: Have you updated the changelog and relevant docs (user docs, architecture diagram, etc) ? -->

+9045 -3761

0 comment

136 changed files

pr created time in 2 days

Pull request review commentsourcegraph/sourcegraph

Example of encryptColumns

 func (*userExternalAccounts) Delete(ctx context.Context, id int32) error { 	return nil } +// Encrypt uses the helper_secret to encrypt the denoted column(s)+// it first gets all the data in the current column and then performs the update+func (s *userExternalAccounts) Encrypt(ctx context.Context, id int32) error {++	account, err := s.Get(ctx, id)+	if err != nil {+		return err+	}++	maybeUserExtAcct, err := encryptColumns([]string{"auth_data"}, *account)

This perviously had encryptColumns([]string{"auth_data"}, s) That doesn't make sense here since s is an empty struct. https://medium.com/@matryer/cool-golang-trick-nil-structs-can-just-be-a-collection-of-methods-741ae57ab262 We seem to intentionally use the empty struct to provide compile time checking here. This really contradicts what we are trying to do with encryptColumns

daxmc99

comment created time in 2 days

create barnchsourcegraph/sourcegraph

branch : rfc196/encrypt_all_things

created branch time in 2 days

Pull request review commentsourcegraph/sourcegraph

external_services: use SQL to get distinct kinds

 func (e *ExternalServicesStore) List(ctx context.Context, opt ExternalServicesLi 	return e.list(ctx, opt.sqlConditions(), opt.LimitOffset) } +// DistinctKinds returns the distinct list of external services kinds that are stored in the database.+func (e *ExternalServicesStore) DistinctKinds(ctx context.Context) ([]string, error) {+	q := sqlf.Sprintf(`+SELECT ARRAY(+	SELECT DISTINCT(kind)::TEXT FROM external_services+)`)

How was this diagram created?

unknwon

comment created time in 2 days

startedhuytd/pomoday-v2

started time in 2 days

pull request commentsourcegraph/sourcegraph

monitoring: improve long-term provisioning alerts aggregation

Kicked CI, looks like npm was down for a bit so all of the yarn commands failed

bobheadxi

comment created time in 2 days

pull request commentsourcegraph/about

Add handbook section for exposing-service

😬 Thanks @unknwon, I am so used to go fmt.

daxmc99

comment created time in 3 days

push eventsourcegraph/about

Dax McDonald

commit sha d9596a1c5d081c3d0b24de93483d1341ff0f231e

Update handbook/engineering/languages/exposing-services.md Co-authored-by: ᴜɴᴋɴᴡᴏɴ <joe@sourcegraph.com>

view details

push time in 3 days

push eventsourcegraph/about

Dax McDonald

commit sha c527068680576bb271fa8ef1364c5a4882ad139c

Update handbook/engineering/languages/exposing-services.md Co-authored-by: ᴜɴᴋɴᴡᴏɴ <joe@sourcegraph.com>

view details

push time in 3 days

push eventsourcegraph/about

Dax McDonald

commit sha 6f5e11ea650224c6b8e64e4c18687751425063c2

Update handbook/engineering/languages/go.md Co-authored-by: ᴜɴᴋɴᴡᴏɴ <joe@sourcegraph.com>

view details

push time in 3 days

Pull request review commentsourcegraph/about

Add handbook section for exposing-service

++### Exposing services++In Go, that looks like this+```+http.ListenAndServe(":80", nil)+```+The above code will bind to all TCP interfaces. Since Kubernetes does support dual-stack IPv4 & IPv6 our services should bind to all interfaces (we do not currently have IPv6 services).++If you must specify an ip address to expose your service on, choosing `0.0.0.0:port` is typically a good choice. What this does can be OS and platform-specific.++Binding to `localhost:port` or `127.0.0.1:port` is binding to a local-only interface that constrained to the same "host". In Kubernetes, other containers within the Pod may still communicate with this service AND you may port-forward this container and associated service+[(Why?)](#How-can-I-port-forward-a-local-only-service?).++This may be preferred in a sidecar pattern where you do not want a container accessible outside a Pod or when you don't want expose your laptop to the cofeeshop wifi but generally, code should not be merged that binds to `localhost` or `127.0.0.1`.

Hmm... why did this not fail this PR then?... https://github.com/sourcegraph/sourcegraph/pull/12758/files#r466173773 .................. 🙈

daxmc99

comment created time in 3 days

Pull request review commentsourcegraph/sourcegraph

Revert "Revert "codeintel: Internal API proxy (#12691)" (#12728)"

 import ( 	"github.com/sourcegraph/sourcegraph/internal/env" ) +var HTTPAddrInternal = env.Get(+	"SRC_HTTP_ADDR_INTERNAL",+	"localhost:3090", // CI:LOCALHOST_OK

?

efritz

comment created time in 3 days

push eventsourcegraph/about

Dax McDonald

commit sha 25e302e1f9c12601c49cf32536bd56bafc176987

Update handbook/engineering/languages/exposing-services.md Co-authored-by: ᴜɴᴋɴᴡᴏɴ <joe@sourcegraph.com>

view details

push time in 3 days

push eventsourcegraph/about

Dax McDonald

commit sha 35debd3d10c23e16a196978ab156bddde874fc9f

Update handbook/engineering/languages/exposing-services.md Co-authored-by: ᴜɴᴋɴᴡᴏɴ <joe@sourcegraph.com>

view details

push time in 3 days

push eventsourcegraph/about

Dax McDonald

commit sha b458ec952575cf42bd80e8f6c0e5186ef1a17564

Update handbook/engineering/languages/exposing-services.md Co-authored-by: ᴜɴᴋɴᴡᴏɴ <joe@sourcegraph.com>

view details

push time in 3 days

push eventsourcegraph/about

Dax McDonald

commit sha 4788ee3cda6c945eb8f7d5db9f0bb7b6d3fbd2b0

fmt

view details

push time in 3 days

PR opened sourcegraph/about

Reviewers
Add handbook section for exposing-service
+38 -0

0 comment

4 changed files

pr created time in 3 days

create barnchsourcegraph/about

branch : dax/add_expose-service

created branch time in 3 days

push eventsourcegraph/deploy-sourcegraph

Dax McDonald

commit sha 38cba4461a14edf998ded7012c6830089e533937

Drop unneeded deployments from deploy-sourcegraph (#806)

view details

push time in 3 days

delete branch sourcegraph/deploy-sourcegraph

delete branch : dax/drop_unused

delete time in 3 days

PR merged sourcegraph/deploy-sourcegraph

Drop unneeded deployments from deploy-sourcegraph

<!-- Kubernetes and Docker Compose MUST be kept in sync. You should not merge a change here without a corresponding change in the other repository, unless it truly is specific to this repository. -->

Sister deploy-sourcegraph-docker change:

<!-- add link or explanation of why it is not needed here -->

+0 -33

3 comments

1 changed file

daxmc99

pr closed time in 3 days

Pull request review commentsourcegraph/about

cloud: Add Growth plan section

 Other:  - [Keegan Carruthers-Smith](../../../company/team/index.md#keegan-carruthers-smith) will not be isolating his work to a single team. Instead, he will serially choose tasks that he thinks are important to work on and he will post updates to the most relevant tracking issue on GitHub. This is an experiment for the next month and we will evaluate the outcome on 2020-08-17. Tomás will continue to be his manager during this experiment. -## Hiring status+## Growth plan -_Updated 2020-07-03_+We've validated that while having a team focus on Cloud is very important, there continues to be a need for work to happen on other areas of our backend infrastructure. To that end, we'll split this team into two, Cloud and [Backend Infrastructure](../backend-infrastructure/index.md), as soon as we hired enough that each of those teams could have a minimum of 3 engineers, but for the time being, the Cloud team will have to handle any emerging high priority backend infrastructure goals that aren't directly related to the ultimate goal of the team.

TIL about the backend infrastructure team

tsenart

comment created time in 3 days

Pull request review commentsourcegraph/about

cloud: Add Growth plan section

 Other:  - [Keegan Carruthers-Smith](../../../company/team/index.md#keegan-carruthers-smith) will not be isolating his work to a single team. Instead, he will serially choose tasks that he thinks are important to work on and he will post updates to the most relevant tracking issue on GitHub. This is an experiment for the next month and we will evaluate the outcome on 2020-08-17. Tomás will continue to be his manager during this experiment. -## Hiring status+## Growth plan -_Updated 2020-07-03_

TIL about the backend infrastructure team

tsenart

comment created time in 3 days

startedmunnerz/kube-plex

started time in 4 days

push eventsourcegraph/sourcegraph

Dax McDonald

commit sha 12b19de8e8752070590c8f4eba24a1b6b9e3ecba

Update Troubleshooting for nvm versions (#12687)

view details

push time in 4 days

delete branch sourcegraph/sourcegraph

delete branch : dax/update_troubleshooting

delete time in 4 days

PR merged sourcegraph/sourcegraph

Reviewers
Update Troubleshooting for nvm versions

Nvm version issues can be tricky if you haven't used nvm or node before.

<!-- Reminder: Have you updated the changelog and relevant docs (user docs, architecture diagram, etc) ? -->

+8 -0

0 comment

1 changed file

daxmc99

pr closed time in 4 days

push eventsourcegraph/sourcegraph

Dax McDonald

commit sha 7292502dcb17365c036042db5d8be4404da0f91b

Set env var for reviewdog (#12717)

view details

push time in 4 days

delete branch sourcegraph/sourcegraph

delete branch : dax/fix_reviewdog

delete time in 4 days

PR merged sourcegraph/sourcegraph

Reviewers
Set env var for reviewdog

This fixes golangci-lint for CI by setting this env var

https://github.com/reviewdog/reviewdog/blob/c9d205fb4143e6c35c77f8885a27e71d666f90fb/cienv/github_actions.go#L95

<!-- Reminder: Have you updated the changelog and relevant docs (user docs, architecture diagram, etc) ? -->

+2 -0

1 comment

1 changed file

daxmc99

pr closed time in 4 days

PR opened sourcegraph/sourcegraph

Reviewers
Set env var for reviewdog

This fixes golangci-lint for CI

<!-- Reminder: Have you updated the changelog and relevant docs (user docs, architecture diagram, etc) ? -->

+2 -0

0 comment

1 changed file

pr created time in 4 days

push eventsourcegraph/sourcegraph

Dax McDonald

commit sha ba8c1c0e0b15111edc60e161b87bc59b921b158f

Set env var for reviewdog

view details

push time in 4 days

create barnchsourcegraph/sourcegraph

branch : dax/fix_reviewdog

created branch time in 4 days

push eventsourcegraph/sourcegraph

Dax McDonald

commit sha a5ab5a45f243d39d63b41f63b56e4fdfb644ef26

Update Troubleshooting for nvm version Use nvm use command to install the correct node version for local development

view details

push time in 5 days

PR opened sourcegraph/sourcegraph

Reviewers
Update Troubleshooting for nvm versions

Nvm version issues can be tricky if you haven't used nvm or node before.

<!-- Reminder: Have you updated the changelog and relevant docs (user docs, architecture diagram, etc) ? -->

+8 -0

0 comment

1 changed file

pr created time in 5 days

create barnchsourcegraph/sourcegraph

branch : dax/update_troubleshooting

created branch time in 5 days

pull request commentmetallb/metallb

Add steps to cherry-pick a commit

@rata I will update this to specify that the cherry-pick should happen right after the merge (I performed the cherry-pick right after the merge btw).

I will wait to merge until we get @russellb's maintainer's PR in.

daxmc99

comment created time in 5 days

issue commentsourcegraph/sourcegraph

Cloud: 3.19 Tracking issue

Last Week Paired with @chayim on RFC 196 Deployed Cloud SQL into the dogfood cluster as a service.

This week Continue to pair with @chayim on RFC 196. Begin adding sidecars to cloud and dogfood deployments in preparation to migrate over.

tsenart

comment created time in 5 days

push eventsourcegraph/sourcegraph

Chayim I. Kirshen

commit sha fe58a8c30024f0175efa06541451f8ed98c960d3

token encryption with starting unit tests

view details

Chayim I. Kirshen

commit sha a5812eceafdb3bee0968c224f993c6e1df3839cd

Added a unit test to validate the negative side of decrytpion - that we cannot decrypt a key with an incorrect string. Also ensured rotate chagnes the key on the actual object.

view details

Chayim I. Kirshen

commit sha dfdee21d9e7f64a053e966aec41bc2ccc356cc3d

linter

view details

push time in 8 days

push eventsourcegraph/sourcegraph

push time in 8 days

pull request commentsourcegraph/deploy-sourcegraph

add app label for prometheus, alertmanager

Yup, looks good

bobheadxi

comment created time in 9 days

pull request commentsourcegraph/deploy-sourcegraph

add app label for prometheus, alertmanager

What are we using app labels for in Prometheus?

bobheadxi

comment created time in 9 days

push eventsourcegraph/sourcegraph

Dax McDonald

commit sha 48a4f25406b0e1469e24f73a980e9001304efa3e

Added support for external accounts and a byte encryption wrapper

view details

push time in 9 days

starteddramich/provider-detector

started time in 10 days

push eventsourcegraph/sourcegraph

Dax McDonald

commit sha 907182ea7cea592bf42d4fb2366834086f077f68

Add encryption and decryption to external service DB functions

view details

push time in 10 days

push eventsourcegraph/sourcegraph

Dax McDonald

commit sha 57815abd8a8865da17b5846293a7689540c71d54

Add EncryptIfPossible and DecryptIfPossible Also add test

view details

push time in 10 days

issue openedmarlonrichert/zsh-autocomplete

Master branch is currently failing

Describe the bug

<!-- A clear and concise description of what the bug is. -->

Seeing

/Users/dax/.oh-my-zsh/custom/plugins/zsh-autocomplete/zsh-autocomplete.zsh:22: defining function based on alias `_expand'
/Users/dax/.oh-my-zsh/custom/plugins/zsh-autocomplete/zsh-autocomplete.zsh:100: parse error near `()'

on startup

To Reproduce

Steps to reproduce the behavior:

Use the Oh My Zsh custom plugin option with the latest master branch. This is started occurring after I upgraded to the latest version.
The last working commit (for me) was 8fadcb8b7ed6ac1d586a1470880296ef1107e86f

Expected behavior

<!-- A clear and concise description of what you expected to happen. --> Autocomplete works on master

Actual behavior

<!-- If applicable, add screenshots or other output to help explain your problem. -->

Autocomplete does not work and I see zsh: _autocomplete.main.hook: function definition file not found on every attempt to autocomplete

Desktop

  • OS + distribution: OSX
  • Zsh version: 5.7.1
  • Plugin version: 75ca496d8fe989544aac9576b0b2b21e213eda93

created time in 11 days

issue commentmarlonrichert/zsh-autocomplete

Work better with history-substring-search-up/down

Thanks! I will take a look

jcassee

comment created time in 11 days

startedaylei/kubectl-debug

started time in 11 days

pull request commentsourcegraph/deploy-sourcegraph

Drop unneeded deployments from deploy-sourcegraph

Updated this PR to only drop the lsif-migration deployment

daxmc99

comment created time in 11 days

push eventsourcegraph/deploy-sourcegraph

Dax McDonald

commit sha 661a857e7a28902fb0287b451759a8ffe6b4203a

Drop unneeded deployments from deploy-sourcegraph

view details

push time in 11 days

create barnchsourcegraph/deploy-sourcegraph

branch : dax/drop_unused

created branch time in 11 days

PR opened sourcegraph/deploy-sourcegraph

Drop unneeded deployments from deploy-sourcegraph

<!-- Kubernetes and Docker Compose MUST be kept in sync. You should not merge a change here without a corresponding change in the other repository, unless it truly is specific to this repository. -->

Sister deploy-sourcegraph-docker change:

<!-- add link or explanation of why it is not needed here -->

+0 -140

0 comment

4 changed files

pr created time in 11 days

issue openedsourcegraph/sourcegraph

RFC 196: Mask tokens in the UI

All external services tokens should be masked in the UI

created time in 11 days

PR opened metallb/metallb

Add steps to cherry-pick a commit
+14 -1

0 comment

1 changed file

pr created time in 11 days

create barnchdaxmc99/metallb

branch : add_cherry_pick

created branch time in 11 days

push eventmetallb/metallb

Etienne Champetier

commit sha ecd09f14ad361929cd9be05961ab290ca40dd9ca

Rename handlers/watcher in nodeHandlers/nodeWatcher There is already {svc,ep,cm}Handlers / {svc,ep,cm}Watcher Signed-off-by: Etienne Champetier <echampetier@anevia.com> (cherry picked from commit f1f86ed658c1e8a6f90f967ed94881d61476b4c0)

view details

push time in 11 days

push eventmetallb/metallb

Etienne Champetier

commit sha da41dbe81e90a473957a3cd6b60e198474911f7b

Remove dead code Signed-off-by: Etienne Champetier <echampetier@anevia.com>

view details

Etienne Champetier

commit sha f1f86ed658c1e8a6f90f967ed94881d61476b4c0

Rename handlers/watcher in nodeHandlers/nodeWatcher There is already {svc,ep,cm}Handlers / {svc,ep,cm}Watcher Signed-off-by: Etienne Champetier <echampetier@anevia.com>

view details

push time in 11 days

PR merged metallb/metallb

Cleanups cleanup

To make #595 easier to digest, let's merge the easy ones first

+3 -5

6 comments

2 changed files

champtar

pr closed time in 11 days

pull request commentmetallb/metallb

Update github.com/mdlayher/{arp,ethernet,ndp}

@champtar Is there anything we can do to help you build & test this? This looks like a reasonable bump

champtar

comment created time in 12 days

pull request commentmetallb/metallb

Additional logging when no endpoints defined

This looks like a simple log addition. Looks good to merge

Matoch

comment created time in 12 days

startedgnzlbg/cargo-asm

started time in 15 days

pull request commentsourcegraph/sourcegraph

remove replacer

image Awesome!

rvantonder

comment created time in 15 days

push eventsourcegraph/about

Dax McDonald

commit sha 18a17562c8defb6101c65acb504cd4aef5e7628c

Update release tracking issue to ask product Going forward the release captain should be requesting blog posts updates from the product team

view details

push time in 15 days

Pull request review commentsourcegraph/sourcegraph

Add init

+package secrets++import (+	"fmt"+	"io/ioutil"+	"os"++	"github.com/sourcegraph/sourcegraph/internal/conf"+)++var CryptObject Encrypter++const (+	// #nosec G101+	sourcegraphSecretfileEnvvar = "SOURCEGRAPH_SECRET_FILE"+	sourcegraphCryptEnvvar      = "SOURCEGRAPH_CRYPT_KEY"+)++func init() {+	cryptKey, cryptOK := os.LookupEnv(sourcegraphCryptEnvvar)+	var encryptionKey []byte++	// set the default location if none exists+	secretFile := os.Getenv(sourcegraphSecretfileEnvvar)+	if secretFile == "" {+		// #nosec G101+		secretFile = "/var/lib/sourcegraph/token"+	}++	_, err := os.Stat(secretFile)++	// reading from a file is first order+	if err == nil {+		contents, readErr := ioutil.ReadFile(secretFile)+		if readErr != nil {+			panic(fmt.Sprintf("Couldn't read file %s", sourcegraphSecretfileEnvvar))+		}+		if len(contents) < validKeyLength {+			panic(fmt.Sprintf("Key length of %d characters is required.", validKeyLength))+		}+		encryptionKey = []byte(contents)+		CryptObject.EncryptionKey = encryptionKey+		return+	}++	// environment is second order+	if cryptOK {+		encryptionKey = []byte(cryptKey)+		CryptObject.EncryptionKey = encryptionKey+		return+	}++	// for the single docker case, we generate the secret+	deployType := conf.DeployType()+	if conf.IsDeployTypeSingleDockerContainer(deployType) {+		b, err := GenerateRandomAESKey()+		if err != nil {+			panic(fmt.Sprintf("Unable to read from random source: %v", err))+		}+		err = ioutil.WriteFile(secretFile, b, 0600)+		if err != nil {+			panic(err)+		}++		err = os.Chmod(secretFile, 0400)+		if err != nil {+			panic("Failed to secure secrets file.")+		}+		encryptionKey = b+	}++	// wrapping in deploytype check so that we can still compile and test locally+	if !(conf.IsDev(deployType) || os.Getenv("CI") == "") {

This stops a panic in CI or if we are running in dev mode

daxmc99

comment created time in 15 days

push eventsourcegraph/sourcegraph

Dax McDonald

commit sha 51d5fe617fc320fed1a9b74ef3ac1e9942d4cfb4

Remove unneeded err check

view details

Dax McDonald

commit sha a30e11a2c43459c1c715474fd3f3cd82b969d994

Update panic If we are in dev mode or CI, do not panic.

view details

push time in 15 days

issue commentsourcegraph/sourcegraph

Proposal: Move monitoring configuration closer to the service code, use TOML

I agree regarding a format that helps monitoring feel a bit closer to home (maybe if we spread the >current definitions into individual services?), but I'm hesitant to add more to our workload on this >front by supporting a variety of formats - I think that effort might be better put into helping teams > familiarize themselves with whatever format we finalize on

Ultimately, what Grafana & Prometheus read are basic json and yml files (I assume). Could someone manually write one of these?

slimsag

comment created time in 16 days

issue commentsourcegraph/sourcegraph

Proposal: Move monitoring configuration closer to the service code, use TOML

I would like to echo @bobheadxi's sentiment here. I don't think TOML will reduce the complexity or make the code more palatable to newcomers. On some level, I think we need to decide if our monitoring code should be mildly bespoke and not just a large amount of Prometheus + Grafana config files.

I do believe in having the monitoring configuration closer to the source code they monitoring makes sense though. This spreads the monitoring + observability concern across teams. If a team does not like the Go approach I think they should be able to write just the raw config files and distribution can be responsible for getting them into the monitoring system.

slimsag

comment created time in 16 days

push eventsourcegraph/about

Dax McDonald

commit sha 7ba0e37b222ddc2109c0c94fcc138518698098c6

Fix formatting

view details

push time in 16 days

issue closedsourcegraph/sourcegraph

Sourcegraph.com - add redis-store & precise-code-intel-bundle-manager snapshotting

  • precise-code-intel-bundle-manager contains LSIF upload data we ideally do not want to lose. It's not critical if lost, but we should avoid losing it if we can. Backups of this are ideal.
  • redis-store now contains user analytics/metrics data (from what I understand) so it is in a similar boat: not critical to keep, but ideal to keep.

We should add snapshotting for both on Sourcegraph.com.

closed time in 16 days

slimsag

push eventsourcegraph/sourcegraph

Dax McDonald

commit sha fb937a0bff397873b8128a89e8c8e6aa5e5de2fb

Add generated keys For non-k8s deployments, we generate the keys if none are provided. Keys are written to /var/lib/sourcegraph/token

view details

push time in 16 days

push eventsourcegraph/sourcegraph

Dax McDonald

commit sha 432c6524428c801ae9cc297e56fcc0984560b149

Refactor EncryptionStore to Encrypter

view details

push time in 16 days

push eventsourcegraph/sourcegraph

Chayim

commit sha 2bd78802fb52bfd6aedb2d0a97870510c0a214b0

Encrypting tokens (#12415) Adding token encryption, and the associated unit tests.

view details

Dax McDonald

commit sha 63ca7fefa4dce9b6719500abe76077655ae17f90

Merge remote-tracking branch 'origin/tracking-rfc196' into rfc196/dax-testing

view details

push time in 16 days

push eventsourcegraph/sourcegraph

Dax McDonald

commit sha eeeb3d12e2aa46e6488351fa0b3cc6dcef975b1b

Fmt

view details

push time in 16 days

push eventsourcegraph/sourcegraph

Dax McDonald

commit sha b121c919f613cc54cd78766ac6f691fe5a1b52c8

Handle path err & use const

view details

push time in 16 days

PR opened sourcegraph/sourcegraph

Add init

Adds an init function to read the encryption token from either from the SOURCEGRAPH_CRYPT_KEY env var or SOURCEGRAPH_SECRET_FILE location. Panics if no secret key is found.

+51 -1

0 comment

2 changed files

pr created time in 16 days

create barnchsourcegraph/sourcegraph

branch : rfc196/dax-testing

created branch time in 16 days

create barnchsourcegraph/sourcegraph

branch : dax/monitoring_fix

created branch time in 17 days

PR opened sourcegraph/sourcegraph

Reviewers
Add cleanup step to Grafana and Prometheus ignored files

This adds cleanup to the generated Grafana and Prometheus files located in docker-images/grafana/provisioning/dashboards/sourcegraph/ and docker-images/prometheus/config/

<!-- Reminder: Have you updated the changelog and relevant docs (user docs, architecture diagram, etc) ? -->

+50 -0

0 comment

1 changed file

pr created time in 17 days

issue commentsourcegraph/sourcegraph

Cloud: 3.19 Tracking issue

Goal 2 Update (2020-07-22)

@chayim and I paired on RFC 194 went over the first 3 issues. @chayim filed issues to scope out our work (https://github.com/sourcegraph/sourcegraph/labels/RFC-196). All of these issues can be tracked with under the Security tracking issue here: https://github.com/sourcegraph/sourcegraph/issues/12300

Next steps: We plan to pair the rest of the week and knock out the numbered RFC issues 1,2 and 3.

tsenart

comment created time in 17 days

issue commentsourcegraph/sourcegraph

3.18 release tracking issue

PR to update release tracking issue here

daxmc99

comment created time in 17 days

PR opened sourcegraph/about

Update release issue template

Updates to make the release more straightforward for future releases

+1 -0

0 comment

1 changed file

pr created time in 17 days

create barnchsourcegraph/about

branch : release-issue-template-updates

created branch time in 17 days

push eventsourcegraph/sourcegraph

Dax McDonald

commit sha d708886a9e5a8802f5e53e7642029e14e656d798

Update changelong for 3.18 (#12413)

view details

push time in 17 days

delete branch sourcegraph/sourcegraph

delete branch : dax/3.18_changelog

delete time in 17 days

PR merged sourcegraph/sourcegraph

Update changelong for 3.18

Update changelong for 3.18 and keep new changelog entries

<!-- Reminder: Have you updated the changelog and relevant docs (user docs, architecture diagram, etc) ? -->

+16 -4

0 comment

1 changed file

daxmc99

pr closed time in 17 days

push eventsourcegraph/sourcegraph

Dax McDonald

commit sha a250cf222d45b4191e01ae564c270c9e2799dea3

Prettier

view details

push time in 17 days

issue commentsourcegraph/sourcegraph

3.18 release tracking issue

Make CHANGELOG.md process clearly so that the 3.18 changelog notes are on the master branch before the release https://github.com/sourcegraph/sourcegraph/pull/12413/files

daxmc99

comment created time in 17 days

more