profile
viewpoint
David Mark Clements davidmarkclements Amsterdam Consultant, Principal Architect, Author of Node Cookbook, Technical Lead of OpenJS Certifications

davidmarkclements/0x 2306

🔥 single-command flamegraph profiling 🔥

davidmarkclements/atomic-sleep 44

⏱️Zero CPU overhead, zero dependency, true event-loop blocking sleep ⏱️

clinicjs/node-clinic-flame-demo 25

A Clinic Flame example

davidmarkclements/async-tracer 14

Trace all async operations, output as newline delimited JSON logs, with minimal overhead.

DamonOehlman/marked-ast-markdown 10

Given a marked-ast AST generate markdown output

davidmarkclements/bespoke-pdf 6

PDF generating for Bespoke.js

davidmarkclements/aquatap 5

fullstack TAP with a modern API

Concorda/seneca-facebook-auth 3

facebook auth plugin for seneca-auth

davidmarkclements/bespoke-synchro 3

Synchronize the slide index of bespoke presentation instances

push eventdavidmarkclements/brittle

David Mark Clements

commit sha ae44d029fbb88fee9244d9e37b52f9b390651e58

1.6.2

view details

push time in 4 hours

push eventdavidmarkclements/brittle

David Mark Clements

commit sha c132f3b5a3aedb373118dbac99bed12f8cb5c150

ci fixing

view details

push time in 4 hours

push eventdavidmarkclements/brittle

David Mark Clements

commit sha 16ffd2103ba4505490cde409ce6a15dadcf48a82

ci fixing

view details

push time in 4 hours

push eventdavidmarkclements/brittle

David Mark Clements

commit sha 93fcc382274893f2e53d01c24b3c7e4a47395464

ci fixing

view details

push time in 4 hours

push eventdavidmarkclements/brittle

David Mark Clements

commit sha 5c64307563872c6eec0277432a579c160cc5e50a

ci fixing

view details

push time in 5 hours

push eventdavidmarkclements/brittle

David Mark Clements

commit sha 05dab7e8dd3ea120ca77d45743c04ba989ef40d6

ci fixing

view details

push time in 5 hours

push eventdavidmarkclements/brittle

David Mark Clements

commit sha 62aca79f5e6a9b66b7f09c2cdbe35ff93fe1d86c

ci fixing

view details

push time in 6 hours

push eventdavidmarkclements/brittle

David Mark Clements

commit sha fd9c28c11f142368e46e166d046a988f04eca922

ci fixing

view details

push time in 6 hours

push eventdavidmarkclements/brittle

David Mark Clements

commit sha ec4ffdff2bdbce9c630491e324a772f4966a4de3

ci fixing

view details

push time in 7 hours

push eventdavidmarkclements/brittle

David Mark Clements

commit sha eb5cf2c1d47f66a31deb510886abd9143458680c

ci fixing

view details

push time in 7 hours

push eventdavidmarkclements/brittle

David Mark Clements

commit sha 39d72594178c7cd3d8dfcb2080bed14805f2491f

ci fixing

view details

push time in 7 hours

push eventdavidmarkclements/brittle

David Mark Clements

commit sha 6ccd712fb27f32cdbe97dd4e952df8809f2dd44b

ci fixing

view details

push time in 8 hours

push eventdavidmarkclements/brittle

David Mark Clements

commit sha 2f6ceb11163402d747e0057372364e4501945ac2

ci fixing

view details

push time in 8 hours

push eventdavidmarkclements/brittle

David Mark Clements

commit sha 86681674583a056d088e12fbb7ed2fb94b695ac5

ci fixing

view details

push time in 8 hours

push eventdavidmarkclements/brittle

David Mark Clements

commit sha dd6683c32cc6b416e459ecbf0eb6739498a97ad7

ci fixing

view details

push time in 9 hours

push eventdavidmarkclements/brittle

David Mark Clements

commit sha 50af732ac3a6af1ac4fc9bb04dac3799bd89cd31

ci fixing

view details

push time in 9 hours

push eventdavidmarkclements/brittle

David Mark Clements

commit sha 8b9ccec071fd72fc9d6e04b7646404e6aad55d2f

ci fixing

view details

push time in 9 hours

push eventdavidmarkclements/brittle

David Mark Clements

commit sha cfe08bbf9c973a19cfe23fa9624305a549182d67

cleanup

view details

push time in 9 hours

push eventdavidmarkclements/brittle

David Mark Clements

commit sha ed9dc7ceff394f6e10bb0c7a3e33af1d3333b3c0

ci tweak

view details

push time in 11 hours

push eventdavidmarkclements/brittle

David Mark Clements

commit sha 62d294e750db0483c72e2b9038e99a566e0dea2a

ci tweak

view details

push time in 11 hours

push eventdavidmarkclements/brittle

David Mark Clements

commit sha bb0d159c020d5dcfe013a69433c2c030e4e47ae8

adjacency bug fix

view details

push time in 11 hours

Pull request review commentpinojs/pino

Remove deprecated API and options in v7 option.

 const warning = require('fastify-warning')() module.exports = warning -const warnName = 'PinoWarning'

for me it's a loose end - maybe this whole concept should be a separate module or something

mcollina

comment created time in 2 days

PullRequestReviewEvent

Pull request review commentpinojs/pino

Remove deprecated API and options in v7 option.

 const warning = require('fastify-warning')() module.exports = warning -const warnName = 'PinoWarning'+// const warnName = 'PinoWarning' -warning.create(warnName, 'PINODEP008', 'prettyPrint is deprecated, look at https://github.com/pinojs/pino-pretty for alternatives.')--warning.create(warnName, 'PINODEP009', 'The use of pino.final is discouraged in Node.js v14+ and not required. It will be removed in the next major version')+// warning.create(warnName, 'PINODEP010', 'A new deprecation')

is the file needed? if not we should remove it - if we ever need it again it's in the commit history right?

mcollina

comment created time in 2 days

PullRequestReviewEvent

Pull request review commentpinojs/pino

Remove deprecated API and options in v7 option.

 test('flushSync', function (t) {     '_' + Math.random().toString(36).substr(2, 9)   )   const destination = pino.destination({ dest: tmp, sync: false, minLength: 4096 })-  const log = pino({ level: 'info' }, multistream([{ level: 'info', stream: destination }]))+  const stream = multistream([{ level: 'info', stream: destination }])

pino v8 side note: can we merge multistream and transport APIs in a way where the multistream same-thread logic is used based on available threads (or a force option)

mcollina

comment created time in 2 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentpinojs/pino

Remove deprecated API and options in v7 option.

 test('nestedKey should not be used for non-objects', async ({ strictSame }) => {     msg: message   }) })++test('throws if prettyPrint is passed in as an option', async (t) => {+  t.throws(() => {+    pino({+      prettyPrint: true+    })+  }, new Error('prettyPrint option is no longer supported, see the pino-pretty package.'))

include a link?

mcollina

comment created time in 2 days

Pull request review commentpinojs/pino

Remove deprecated API and options in v7 option.

 function buildFormatters (level, bindings, log) {   } } -function setMetadataProps (dest, that) {

love to see this go

mcollina

comment created time in 2 days

more