profile
viewpoint

startedvtex/react-jsonschema-table

started time in 3 days

issue closeddenoland/deno

Benchmark links do not work

The "recent" and "all" anchor links at the top of the Benchmark page don't work.

closed time in 14 days

davidjamesstone

issue commentdenoland/deno

Benchmark links do not work

Yes, this is fixed. Thank you.

davidjamesstone

comment created time in 14 days

Pull request review commentdenoland/deno

[website] add warning for adblockers

 <h1>Deno Continuous Benchmarks</h1>         <a href="https://github.com/denoland/deno">master branch</a>.       </p> +      <p style="font-size: 14px;font-style: italic;">Make sure your adblocker is disabled. Some blocks the plot rendering.</p>

block => block.

Alternatively:

Make sure your adblocker is disabled as some can block the chart rendering.

zekth

comment created time in 21 days

startedmilligram/milligram

started time in 22 days

pull request commentdenoland/deno

Fix anchor links and add spinner to the benchmarks page

Thanks!

davidjamesstone

comment created time in 25 days

pull request commentdenoland/

Fix anchor links and add spinner to the benchmarks page

benchmark

The spinner looks choppier in this gif than it appears IRL but hopefully this gives you the idea

davidjamesstone

comment created time in a month

pull request commentdenoland/

Fix anchor links and add spinner to the benchmarks page

benchmark

The spinner looks choppier in this gif than it appears IRL but hopefully this gives you the idea

davidjamesstone

comment created time in a month

push eventdavidjamesstone/deno

David Stone

commit sha 774a6c399ab7590ec539beb745357df048a99d53

Rename overlay

view details

push time in a month

Pull request review commentdenoland/deno

Fix anchor links and add spinner to the benchmarks page

 <h3 id="syscalls">Syscall count <a href="#syscalls">#</a></h3>     <script type="module">       import { drawCharts } from "./app.js";       window.chartWidth = 800;+      const busy = document.getElementById("busy")

Sure spinner-overlay sounds best to me.

davidjamesstone

comment created time in a month

Pull request review commentdenoland/deno

Fix anchor links and add spinner to the benchmarks page

 <h3 id="syscalls">Syscall count <a href="#syscalls">#</a></h3>     <script type="module">       import { drawCharts } from "./app.js";       window.chartWidth = 800;+      const busy = document.getElementById("busy") -      let u = window.location.hash.match("all") ? "./data.json" : "recent.json";+      function showSpinner () {+        busy.style.display = "block";+      } -      drawCharts(u);+      function hideSpinner () {+        busy.style.display = "none";+      }++      function updateCharts () {+        let u = window.location.hash.match("all") ? "./data.json" : "recent.json";

I agree (I didn't add that line).

I see a lot of js code using let where const could (should ?) be used.

I always favour using const and rarely use let but others may disagree.

I'll make the change.

davidjamesstone

comment created time in a month

pull request commentdenoland/deno

Fix anchor links and add spinner to the benchmarks page

I fixed the recent data and all data links so they redraw the charts via onhashchange. I initially tried to use a simple document.body.style.cursor = 'wait' toggle to indicate progress but it's buggy in several browsers. I opted for a simple CSS spinner instead.

A minor change was required to the app.js file to return a promise from the drawChartsFromBenchmarkData function, allowing us to know when the drawing was complete so we can hide the spinner.

davidjamesstone

comment created time in a month

PR opened denoland/deno

Fix anchor links and add spinner

Issue: https://github.com/denoland/deno/issues/2203

+51 -3

0 comment

3 changed files

pr created time in a month

push eventdavidjamesstone/deno

David Stone

commit sha 47e528129d1ac6d7658611947b2fa5c2b8476edf

Fix anchor links and add spinner

view details

push time in a month

fork davidjamesstone/deno

A secure JavaScript/TypeScript runtime built with V8, Rust, and Tokio

https://deno.land/

fork in a month

PR closed denoland/deno

Fix anchor links and add spinner

https://github.com/denoland/deno/issues/2203

+51 -3

1 comment

3 changed files

davidjamesstone

pr closed time in a month

push eventdavidjamesstone/deno

David Stone

commit sha c2c90a17f6a21ac6103a046861ca33a891053ddf

Use doublequotes for strings

view details

push time in a month

PR opened denoland/deno

Fix anchor links and add spinner

https://github.com/denoland/deno/issues/2203

+51 -3

0 comment

3 changed files

pr created time in a month

issue openeddenoland/deno

Benchmark links do not work

The "recent" and "all" anchor links at the top of the Benchmark page don't work.

created time in a month

push eventdavidjamesstone/deno

David Stone

commit sha 76dd56baf327e2b7fc52de8a0e3850c505da1464

Fix anchor links and add spinner

view details

push time in a month

fork davidjamesstone/deno

A secure JavaScript/TypeScript runtime built with V8, Rust, and Tokio

https://deno.land/

fork in a month

startedjamiebuilds/the-super-tiny-compiler

started time in a month

startedmaxogden/geojson-js-utils

started time in a month

PR opened hapijs/eslint-config

Fixed eslint tests
+48 -48

0 comment

2 changed files

pr created time in a month

create barnchdavidjamesstone/eslint-config

branch : fix-scoped-tests

created branch time in a month

fork davidjamesstone/eslint-config

Shareable ESLint config for the hapi ecosystem

fork in a month

starteddenolib/guide

started time in a month

startedclauderic/react-tiny-virtual-list

started time in a month

startedvip-git/react-jsonschema-form-material-ui

started time in a month

startedTwoAbove/jsonschema-form-for-material-ui

started time in a month

push eventdavidjamesstone/stoneware

David Stone

commit sha 9aa61e91ec4bcd0ffde0a4e03c369c33d25735e9

Update readme

view details

push time in 2 months

push eventdavidjamesstone/stoneware

davidjamesstone

commit sha a31626c28dccaec49b76a03064725fdd08a3ffae

Delete launch.json

view details

push time in 2 months

create barnchdavidjamesstone/stoneware

branch : master

created branch time in 2 months

created repositorydavidjamesstone/stoneware

ERP

created time in 2 months

startedbojand/json-schema-deref-sync

started time in 2 months

issue commentDEFRA/digital-form-builder

'pm2' is not recognized as an internal or external command

Use node index.js instead of using npm start. Alternatively, follow the 'Getting started' section of the README and use browser-refresh

SDnelML

comment created time in 2 months

startedsnabbdom/snabbdom

started time in 2 months

startedChalarangelo/mini.css

started time in 2 months

startedbookshelf/bookshelf

started time in 2 months

startedjoepuzzo/informed

started time in 2 months

startedTokenChingy/panoptes

started time in 2 months

startedSemantic-Org/Semantic-UI-React

started time in 2 months

startedseeden/react-form-controlled

started time in 2 months

startedkripken/sql.js

started time in 2 months

startedjulianshapiro/velocity

started time in 2 months

startedmontagejs/collections

started time in 2 months

push eventcdeno/web

David Stone

commit sha 928ac5b122a79ed07d253e237aa12c92c325ec19

React

view details

push time in 3 months

created tagcdeno/test

tag0.0.32

created time in 3 months

push eventcdeno/test

David Stone

commit sha a4247c4c9173415c4f36d01958ba3b08663cd0da

0.0.31

view details

push time in 3 months

created tagcdeno/test

tag0.0.31

created time in 3 months

created tagcdeno/test

tag0.0.30

created time in 3 months

push eventcdeno/test

David Stone

commit sha 5f2c93bb9e9d1288c660cba90c9e8bc554a8e47c

0.0.29

view details

David Stone

commit sha d316b68803aa4835c037de4d4fdd4df764638a0c

0.0.30

view details

push time in 3 months

created tagcdeno/test

tag0.0.29

created time in 3 months

push eventcdeno/test

David Stone

commit sha a23348c05365f5e9eb0efdb708bab660f91e320f

Update README.md

view details

push time in 3 months

created tagcdeno/test

tag0.0.28

created time in 3 months

created tagcdeno/test

tag0.0.27

created time in 3 months

release cdeno/test

0.0.27

released time in 3 months

push eventcdeno/test

davidjamesstone

commit sha 030a8fdde0f4a14e4687395e1d5da8945430d04f

Update README.md

view details

push time in 3 months

created tagcdeno/test

tag0.0.26

created time in 3 months

release cdeno/test

0.0.26

released time in 3 months

push eventcdeno/test

davidjamesstone

commit sha 56dc67254a4fcf2e0911aebcf7206e41c04d51ff

Update README.md

view details

push time in 3 months

created tagcdeno/test

tag0.0.25

created time in 3 months

release cdeno/test

0.0.25

released time in 3 months

push eventcdeno/test

davidjamesstone

commit sha 1c9ea8d808d25d85f4956646445e542ba14204b7

Update README.md

view details

push time in 3 months

created tagcdeno/test

tag0.0.24

created time in 3 months

release cdeno/test

0.0.24

released time in 3 months

push eventcdeno/test

davidjamesstone

commit sha 6e5c27237fa65a445755c0003aa3e0450f657863

Update README.md

view details

push time in 3 months

created tagcdeno/test

tag0.0.23

created time in 3 months

release cdeno/test

0.0.23

released time in 3 months

push eventcdeno/test

davidjamesstone

commit sha 3eab57a1e8988a26449ce596659bfaab3ea31500

Update README.md

view details

push time in 3 months

more