profile
viewpoint
Dave Wasmer davewasmer @discoverpraxis Colorado Springs, CO http://www.davewasmer.com Building an apprenticeship-driven engineering team at Praxis. Husband, father, follower of Christ.

davewasmer/devcert 601

Local HTTPS development made easy

davewasmer/devcert-cli 54

A CLI wrapper for devcert, to manage development SSL/TLS certificates and domains

davewasmer/biblejs 12

Normalize bible references, convert them to machine readable formats, query and manipulate them

davewasmer/broccoli-favicon 4

Takes a single favicon.png and outputs various sizes and file formats for favicons for different platforms and devices.

davewasmer/blackburn 3

Drop-in, ORM agnostic serializer support for Express/Connect Node apps.

davewasmer/asset-addons-example 2

An example of one approach to addons (the asset type) for the ember-cli

davewasmer/bootstrap 1

HTML, CSS, and JS toolkit from Twitter

startedbabel-blade/babel-blade

started time in 2 days

startedPostHog/posthog

started time in 2 months

pull request commentmuxinc/mux-node-sdk

Mark asset.master as optional

Just client.Video.Assets.get(assetId) for an asset that as never had a master requested.

davewasmer

comment created time in 3 months

PR opened muxinc/mux-node-sdk

Mark asset.master as optional

The API doesn't always return a master property, so the Asset interface should mark the property as optional to ensure that consumers of the library appropriately handle the case where the master property is not present.

+1 -1

0 comment

1 changed file

pr created time in 3 months

push eventdavewasmer/mux-node-sdk

Dave Wasmer

commit sha adfce703a3ab2df5b7c004d29cfcbb0f84e1ba4d

Mark asset.master as optional The API doesn't always return a `master` property, so the Asset interface should mark the property as optional to ensure that consumers of the library appropriately handle the case where the `master` property is not present.

view details

push time in 3 months

fork davewasmer/mux-node-sdk

Official Mux API wrapper for Node projects, supporting both Mux Data and Mux Video.

https://muxinc.github.io/mux-node-sdk/

fork in 3 months

issue commentmaildev/maildev

Don't quit process on SMTP errors

I understand that, but it seems that maildev still includes the following lines:

https://github.com/maildev/maildev/blob/master/lib/mailserver.js?rgh-link-date=2020-04-28T20%3A46%3A55Z#L232

https://github.com/maildev/maildev/blob/master/index.js?rgh-link-date=2020-04-28T20%3A46%3A55Z#L80

Both of those lines seem inappropriate - I can't think of any good reason why maildev should ever be emitting fake SIGTERM events or calling process.exit.

davewasmer

comment created time in 3 months

issue commentmaildev/maildev

Don't quit process on SMTP errors

I don't think so, unfortunately. I haven't tested that PR, but even if it happens to fix the error around a bad port number, it looks like maildev still calls process.exit() when other errors are encountered (see my links above).

So even if a misconfigured port no longer results in the process.exit() code running, I assume something else could, and that seems like the root problem to me: maildev shouldn't assume it's the only thing running in the process, and should instead simply close it's own servers/ports but not forcible quit the process.

davewasmer

comment created time in 3 months

more