profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/davesteinberg/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Dave Steinberg davesteinberg @IBM Toronto, Canada I am a Software Developer at the IBM Garage in Toronto.

my-covid-story/www 9

We are a group of concerned citizens who could no longer stand by as Ontario is led into a humanitarian crisis. We believe the power of storytelling is an effective means to drive government action.

davesteinberg/react-redux-counter 2

A simple React+Redux counter demonstrating unit tests for connected components.

fcaldera/craft 1

Create react application from template. Inspired in CRAFT http://bit.ly/2v9pSx3

davesteinberg/app-modernization-plants-by-websphere-jee6 0

Java Enterprise Edition 6 version of the Plants By Websphere Sample modified to run in a Liberty container

davesteinberg/carbon-tutorial 0

An app for the Carbon Design System tutorial

davesteinberg/dotbot 0

A tool that bootstraps your dotfiles ⚡️

davesteinberg/node-jwks-rsa 0

A library to retrieve RSA public keys from a JWKS (JSON Web Key Set) endpoint.

davesteinberg/pino-pretty 0

🌲Basic prettifier for Pino log lines

davesteinberg/react-router-scroll-demo 0

Demo of scroll restoration in a React Router app

pull request commentmy-covid-story/www

Update dependencies

Deployment was failing with Next 11 because we weren't using the ES Lint plugin. I've fixed that and force-pushed.

I've noticed one more problem: The back navigation from stories to / is broken again. I'll investigate that and update again once it's fixed.

davesteinberg

comment created time in a month

push eventmy-covid-story/www

Dave Steinberg

commit sha 250cdd330019509797d92186babad15cf725364c

Update to Next.js 11

view details

push time in a month

push eventmy-covid-story/www

Dave Steinberg

commit sha 8ae83046ad99033070cbb2b8f2ec48b0af4a521b

Update to Next.js 11

view details

push time in a month

push eventmy-covid-story/www

push time in a month

push eventmy-covid-story/www

Dave Steinberg

commit sha 151518c581dd949433962d9c548c7bf1f3df8955

Placeholder commit to force new deployment

view details

push time in a month

pull request commentmy-covid-story/www

Update dependencies

I've updated all the dependencies to the latest versions. Next.js updated from 10.x to 11.x, which required one small change to next.config.js, as webpack 5 is now the default.

davesteinberg

comment created time in a month

push eventmy-covid-story/www

Dave Steinberg

commit sha 89d40d70721b1213c03d356d4fc36c41c6bcb991

Update to Next.js 11

view details

push time in a month

push eventmy-covid-story/www

Dave Steinberg

commit sha 564d1d13c53497320e31461eacd876e5c0bb8ea0

Update dependencies

view details

push time in a month

PR opened my-covid-story/www

Update dependencies
+3538 -4270

0 comment

2 changed files

pr created time in a month

create barnchmy-covid-story/www

branch : ds.dependencies

created branch time in a month

PR merged my-covid-story/www

Reviewers
Use riding info, if available, to email a story to the correct MPP

This PR implements issue #92, completing the work involving postal code data.

For stories that can be mapped to a riding via postal code FSA (in Ontario only), they will be emailed to the correct MPP, with the default recipients (the Premier, Health Minister, etc.) on CC. A bit of the language in the email is also tweaked as per the template.

If available, the location, riding, and MPP are also shown for each story in the admin console, and hotspot postal codes are indicated by a fire emoji.

+220 -57

3 comments

6 changed files

davesteinberg

pr closed time in a month

push eventmy-covid-story/www

Dave Steinberg

commit sha 414339e6d21d6e4e540d5f8e456e3f60ac971986

Show postal code and riding details on the admin page

view details

Dave Steinberg

commit sha aba96bb743c0a85cc7dc2c6ed3d4f902afcbc931

Tidy up StoryCard.tsx and _admin/index.tsx: imports and page component name

view details

Dave Steinberg

commit sha b4ac6d5fe9f4849fd510f66ce3d9cddeef9e68d9

Use riding info, if available, to email a story to the correct MPP

view details

Dave Steinberg

commit sha 62462ac7c4c5106c3ac5c59c965dae4aa3df0666

Merge pull request #189 from my-covid-story/ds.postal-emailer Use riding info, if available, to email a story to the correct MPP

view details

push time in a month

delete branch my-covid-story/www

delete branch : ds.postal-emailer

delete time in a month

issue closedmy-covid-story/www

Map FSA Postal code to Elected Official

Ties into #76 in that we need to map the FSA to geo spacial data and perform actions accordingly

closed time in a month

JamiesonRoberts
PullRequestReviewEvent

issue openedmy-covid-story/www

Media page with links to our media coverage

From @natashabd on Slack:

Would we able to get the content from this page added as a new static page on the site? Curtis - Design/Product and I had mentioned maybe at some point we can embed the videos but for now, just getting the links up will be nice and could help with credibility and getting new people on board

https://docs.google.com/document/d/1Y9frczf3in2v5Es5ZA3ZK0viSa8PduA6ZoC4L5Lemng/edit?usp=sharing

The existing Media link in the nav bar should be updated with a link to this new page. The media list isn't being used currently, anyway (see the Slack thread).

created time in 2 months

Pull request review commentmy-covid-story/www

Use riding info, if available, to email a story to the correct MPP

 export function fixTitle(title = '') {     .replace(new RegExp(QUOTES.doubleLeft, 'g'), QUOTES.singleLeft)     .replace(new RegExp(QUOTES.doubleRight, 'g'), QUOTES.singleRight) }++export const ADMIN_INCLUDE = {+  postalCode: {+    include: {+      ridings: {+        include: {+          riding: true,+        },+      },+    },+  },+}++export type AdminStory = Prisma.StoryGetPayload<{ include: typeof ADMIN_INCLUDE }>

The queries for stories in the admin context need this include clause to follow relations through the postal code to the riding, so we also need a new AdminStory type that includes all that.

davesteinberg

comment created time in 2 months

PullRequestReviewEvent

Pull request review commentmy-covid-story/www

Use riding info, if available, to email a story to the correct MPP

 export async function send(story: Story): Promise<string | null> {   return null } -function createMessage({ postal, id, title, content }: Story) {-  const ontario = isOntario(postal)-  const to = CUSTOM_EMAILS || (ontario ? ONTARIO_EMAILS : CANADA_EMAILS)-  const subject = `A COVID-19 story${ontario ? ' from Ontario' : ''}`-  const addressee = ontario ? ONTARIO_ADDRESSEE : CANADA_ADDRESSEE-  const jurisdiction = ontario ? 'Ontario' : 'Canada'-  const url = `${process.env.BASE_URL}/story/${id}`-  const params = { addressee, postal, jurisdiction, url, title, content }

This logic got too complicated to do inline with nested ternaries, so I moved it into computeDetails(), where I can use early returns to keep things cleaner.

davesteinberg

comment created time in 2 months

PullRequestReviewEvent

push eventmy-covid-story/www

Dave Steinberg

commit sha 414339e6d21d6e4e540d5f8e456e3f60ac971986

Show postal code and riding details on the admin page

view details

Dave Steinberg

commit sha aba96bb743c0a85cc7dc2c6ed3d4f902afcbc931

Tidy up StoryCard.tsx and _admin/index.tsx: imports and page component name

view details

Dave Steinberg

commit sha b4ac6d5fe9f4849fd510f66ce3d9cddeef9e68d9

Use riding info, if available, to email a story to the correct MPP

view details

push time in 2 months

pull request commentmy-covid-story/www

Use riding info, if available, to email a story to the correct MPP

Whoops, I accidentally included a file that I was using to test something out. Removing it and force-pushing...

davesteinberg

comment created time in 2 months

PR opened my-covid-story/www

Reviewers
Use riding info, if available, to email a story to the correct MPP

This PR implements issue #92, completing the work involving postal code data.

For stories that can be mapped to a riding via postal code FSA (in Ontario only), they will be emailed to the correct MPP, with the default recipients (the Premier, Health Minister, etc.) on CC. A bit of the language in the email is also tweaked as per the template.

If available, the location, riding, and MPP are also shown for each story in the admin console, and hotspot postal codes are indicated by a fire emoji.

+225 -57

0 comment

7 changed files

pr created time in 2 months

create barnchmy-covid-story/www

branch : ds.postal-emailer

created branch time in 2 months

push eventmy-covid-story/www

Dave Steinberg

commit sha d65d647d5662c187c853ba10b56e42a7758e0e5c

Update the home page tagline

view details

Dave Steinberg

commit sha 36f300c7ce322f448ffbaefaee0bdf0fe3b056c7

Merge pull request #188 from my-covid-story/ds.tagline Update the home page tagline

view details

push time in 2 months

delete branch my-covid-story/www

delete branch : ds.tagline

delete time in 2 months

PR merged my-covid-story/www

Reviewers
Update the home page tagline

Whoops, seems that we missed this in #187.

+1 -1

1 comment

1 changed file

davesteinberg

pr closed time in 2 months

issue closedmy-covid-story/www

Replace current tagline on homepage

"Amplifying the stories of the pandemic throughout Canada"

closed time in 2 months

curtis-vdg
IssuesEvent

PR opened my-covid-story/www

Update the home page tagline

Whoops, seems that we missed this in #187.

+1 -1

0 comment

1 changed file

pr created time in 2 months