profile
viewpoint
Darosior darosior 590B 7292 695A FFA5 B672 CBB2 E13F C145 CD3F 4304 <darosior@protonmail.com>

darosior/bitcoineasy 5

Easy to use Bitcoin utility functions (mostly useful only for learning)

Crypto-lyon/smart-asso-frontend 4

A decentralized web application for associations

Crypto-lyon/INSAcoin 3

A coin forked from Litecoin, built and used for a lesson at INSA Lyon.

Crypto-lyon/insacoin-rpc-explorer 3

Simple, database-free, self-hosted INSAcoin blockchain explorer, via RPC. Built with Node.js, express, bootstrap-v4.

darosior/CLcoin 3

A coin forked from litecoin-0.8.7.4

darosior/BlockReader 2

Parse the Bitcoin Blockchain (blk*.dat files created by bitcoin-core)

Crypto-lyon/genesis-parser 1

An INSAcoin genesis bloc parser, commented in french

Crypto-lyon/insacoin_keys 0

Script to generate INSACOIN keys

Pull request review commentbitcoin/bitcoin

gitian-keys: Add signer aliases, some historical keys

 9D3CC86A72F8494342EA5FD10A41BDC3F4FAFF1C Aaron Clauson (sipsorcery) 617C90010B3BD370B0AC7D424BB42E31C79111B8 Akira Takizawa E944AE667CF960B1004BC32FCA662BE18B877A60 Andreas Schildbach-152812300785C96444D3334D17565732E08E5E41 Andrew Chow+152812300785C96444D3334D17565732E08E5E41 Andrew Chow (achow101) 590B7292695AFFA5B672CBB2E13FC145CD3F4304 Antoine Poinsot (darosior) 0AD83877C1F0CD1EE9BD660AD7CC770B81FD22A8 Ben Carman (benthecarman) 912FD3228387123DC97E0E57D5566241A0295FA9 BtcDrak C519EBCF3B926298946783EFF6430754120EC2F4 Christian Decker (cdecker)+18AE2F798E0D239755DA4FD24B79F986CBDF8736 Chun Kuan Le (ken2812221) F20F56EF6A067F70E8A5C99FFF95FAA971697405 centaur-C060A6635913D98A3587D7DB1C2491FFEB0EF770 Cory Fields+C060A6635913D98A3587D7DB1C2491FFEB0EF770 Cory Fields (cfields) BF6273FAEF7CC0BA1F562E50989F6B3048A116B5 Dev Random-6D3170C1DC2C6FD0AEEBCA6743811D1A26623924 Douglas Roark+6D3170C1DC2C6FD0AEEBCA6743811D1A26623924 Douglas Roark (droark)+1C6621605EC50319C463D56C7F81D87985D61612 Emanuele Cisbani (cisba) 9A1689B60D1B3CCE9262307A2F40A9BF167FBA47 Erik Mossberg (erkmos) D35176BE9264832E4ACA8986BF0792FBE95DC863 fivepiece+6F993B250557E7B016ADE5713BDCDA2D87A881D9 Fuzzbawls (Fuzzbawls) 01CDF4627A3B88AAE4A571C87588242FBE38D3A8 Gavin Andresen D1DBF2C4B96F2DEBF4C16654410108112E7EA81F Hennadii Stepanov (hebasto)+A2FD494D0021AA9B4FA58F759102B7AE654A4A5A Ilyas Ridhuan (IlyasRidhuan)+D3F22A3A4C366C2DCB66D3722DA9C5A7FA81EA35 Jarol Rodriguez (jarolrod)+7480909378D544EA6B6DCEB7535B12980BB8A4D3 Jeffri H Frontz (jhfrontz) D3CC177286005BB8FF673294C5242A1AB3936517 jl2012-82921A4B88FD454B7EB8CE3C796C4109063D4EAF Jon Atack-32EE5C4C3FA15CCADB46ABE529D4BCB6416F53EC Jonas Schnelli+82921A4B88FD454B7EB8CE3C796C4109063D4EAF Jon Atack (jonatack)+32EE5C4C3FA15CCADB46ABE529D4BCB6416F53EC Jonas Schnelli (jonasschnelli) 4B4E840451149DD7FB0D633477DFAB5C3108B9A8 Jorge Timon

ACK, assuming he used the same key back then

$ git ls-files|grep -i /jtimon/
0.13.2-linux/jtimon/bitcoin-linux-0.13-build.assert
0.13.2-linux/jtimon/bitcoin-linux-0.13-build.assert.sig
0.13.2-win-unsigned/jtimon/bitcoin-win-0.13-build.assert
0.13.2-win-unsigned/jtimon/bitcoin-win-0.13-build.assert.sig
laanwj

comment created time in a few seconds

Pull request review commentbitcoin/bitcoin

gitian-keys: Add signer aliases, some historical keys

 9D3CC86A72F8494342EA5FD10A41BDC3F4FAFF1C Aaron Clauson (sipsorcery) 617C90010B3BD370B0AC7D424BB42E31C79111B8 Akira Takizawa E944AE667CF960B1004BC32FCA662BE18B877A60 Andreas Schildbach-152812300785C96444D3334D17565732E08E5E41 Andrew Chow+152812300785C96444D3334D17565732E08E5E41 Andrew Chow (achow101) 590B7292695AFFA5B672CBB2E13FC145CD3F4304 Antoine Poinsot (darosior) 0AD83877C1F0CD1EE9BD660AD7CC770B81FD22A8 Ben Carman (benthecarman) 912FD3228387123DC97E0E57D5566241A0295FA9 BtcDrak C519EBCF3B926298946783EFF6430754120EC2F4 Christian Decker (cdecker)+18AE2F798E0D239755DA4FD24B79F986CBDF8736 Chun Kuan Le (ken2812221) F20F56EF6A067F70E8A5C99FFF95FAA971697405 centaur-C060A6635913D98A3587D7DB1C2491FFEB0EF770 Cory Fields+C060A6635913D98A3587D7DB1C2491FFEB0EF770 Cory Fields (cfields)
gitian.sigs$ git ls-files|grep -i /theuni/
[nothing]
laanwj

comment created time in a minute

Pull request review commentbitcoin/bitcoin

gitian-keys: Add signer aliases, some historical keys

 9D3CC86A72F8494342EA5FD10A41BDC3F4FAFF1C Aaron Clauson (sipsorcery) 617C90010B3BD370B0AC7D424BB42E31C79111B8 Akira Takizawa E944AE667CF960B1004BC32FCA662BE18B877A60 Andreas Schildbach-152812300785C96444D3334D17565732E08E5E41 Andrew Chow+152812300785C96444D3334D17565732E08E5E41 Andrew Chow (achow101) 590B7292695AFFA5B672CBB2E13FC145CD3F4304 Antoine Poinsot (darosior) 0AD83877C1F0CD1EE9BD660AD7CC770B81FD22A8 Ben Carman (benthecarman) 912FD3228387123DC97E0E57D5566241A0295FA9 BtcDrak C519EBCF3B926298946783EFF6430754120EC2F4 Christian Decker (cdecker)+18AE2F798E0D239755DA4FD24B79F986CBDF8736 Chun Kuan Le (ken2812221) F20F56EF6A067F70E8A5C99FFF95FAA971697405 centaur-C060A6635913D98A3587D7DB1C2491FFEB0EF770 Cory Fields+C060A6635913D98A3587D7DB1C2491FFEB0EF770 Cory Fields (cfields) BF6273FAEF7CC0BA1F562E50989F6B3048A116B5 Dev Random-6D3170C1DC2C6FD0AEEBCA6743811D1A26623924 Douglas Roark+6D3170C1DC2C6FD0AEEBCA6743811D1A26623924 Douglas Roark (droark)+1C6621605EC50319C463D56C7F81D87985D61612 Emanuele Cisbani (cisba) 9A1689B60D1B3CCE9262307A2F40A9BF167FBA47 Erik Mossberg (erkmos) D35176BE9264832E4ACA8986BF0792FBE95DC863 fivepiece+6F993B250557E7B016ADE5713BDCDA2D87A881D9 Fuzzbawls (Fuzzbawls) 01CDF4627A3B88AAE4A571C87588242FBE38D3A8 Gavin Andresen

Sure, but did he ever do a gitian build?

laanwj

comment created time in 3 minutes

Pull request review commentbitcoin/bitcoin

gitian-keys: Add signer aliases, some historical keys

 9D3CC86A72F8494342EA5FD10A41BDC3F4FAFF1C Aaron Clauson (sipsorcery) 617C90010B3BD370B0AC7D424BB42E31C79111B8 Akira Takizawa E944AE667CF960B1004BC32FCA662BE18B877A60 Andreas Schildbach-152812300785C96444D3334D17565732E08E5E41 Andrew Chow+152812300785C96444D3334D17565732E08E5E41 Andrew Chow (achow101) 590B7292695AFFA5B672CBB2E13FC145CD3F4304 Antoine Poinsot (darosior) 0AD83877C1F0CD1EE9BD660AD7CC770B81FD22A8 Ben Carman (benthecarman) 912FD3228387123DC97E0E57D5566241A0295FA9 BtcDrak C519EBCF3B926298946783EFF6430754120EC2F4 Christian Decker (cdecker)+18AE2F798E0D239755DA4FD24B79F986CBDF8736 Chun Kuan Le (ken2812221) F20F56EF6A067F70E8A5C99FFF95FAA971697405 centaur-C060A6635913D98A3587D7DB1C2491FFEB0EF770 Cory Fields+C060A6635913D98A3587D7DB1C2491FFEB0EF770 Cory Fields (cfields) BF6273FAEF7CC0BA1F562E50989F6B3048A116B5 Dev Random-6D3170C1DC2C6FD0AEEBCA6743811D1A26623924 Douglas Roark+6D3170C1DC2C6FD0AEEBCA6743811D1A26623924 Douglas Roark (droark)+1C6621605EC50319C463D56C7F81D87985D61612 Emanuele Cisbani (cisba) 9A1689B60D1B3CCE9262307A2F40A9BF167FBA47 Erik Mossberg (erkmos) D35176BE9264832E4ACA8986BF0792FBE95DC863 fivepiece+6F993B250557E7B016ADE5713BDCDA2D87A881D9 Fuzzbawls (Fuzzbawls) 01CDF4627A3B88AAE4A571C87588242FBE38D3A8 Gavin Andresen D1DBF2C4B96F2DEBF4C16654410108112E7EA81F Hennadii Stepanov (hebasto)+A2FD494D0021AA9B4FA58F759102B7AE654A4A5A Ilyas Ridhuan (IlyasRidhuan)+D3F22A3A4C366C2DCB66D3722DA9C5A7FA81EA35 Jarol Rodriguez (jarolrod)+7480909378D544EA6B6DCEB7535B12980BB8A4D3 Jeffri H Frontz (jhfrontz) D3CC177286005BB8FF673294C5242A1AB3936517 jl2012-82921A4B88FD454B7EB8CE3C796C4109063D4EAF Jon Atack-32EE5C4C3FA15CCADB46ABE529D4BCB6416F53EC Jonas Schnelli+82921A4B88FD454B7EB8CE3C796C4109063D4EAF Jon Atack (jonatack)+32EE5C4C3FA15CCADB46ABE529D4BCB6416F53EC Jonas Schnelli (jonasschnelli) 4B4E840451149DD7FB0D633477DFAB5C3108B9A8 Jorge Timon C42AFF7C61B3E44A1454CD3557AF762DB3353322 Karl-Johan Alm (kallewoof)-E463A93F5F3117EEDE6C7316BD02942421F4889F Luke Dashjr-B8B3F1C0E58C15DB6A81D30C3648A882F4316B9B Marco Falke+30DE693AE0DE9E37B3E7EB6BBFF0F67810C1EED1 Lisa Neigut (niftynei)+E463A93F5F3117EEDE6C7316BD02942421F4889F Luke Dashjr (luke-jr)+B8B3F1C0E58C15DB6A81D30C3648A882F4316B9B Marco Falke (marco) 07DF3E57A548CCFB7530709189BBB8663E2E65CE Matt Corallo (BlueMatt)

That would be if he used that as directory name in gitian.sigs, but he used BlueMatt. It's not the github name, it's the signer alias as used for gitian.

laanwj

comment created time in 4 minutes

Pull request review commentbitcoin/bitcoin

gitian-keys: Add signer aliases, some historical keys

 9D3CC86A72F8494342EA5FD10A41BDC3F4FAFF1C Aaron Clauson (sipsorcery) 617C90010B3BD370B0AC7D424BB42E31C79111B8 Akira Takizawa E944AE667CF960B1004BC32FCA662BE18B877A60 Andreas Schildbach-152812300785C96444D3334D17565732E08E5E41 Andrew Chow+152812300785C96444D3334D17565732E08E5E41 Andrew Chow (achow101) 590B7292695AFFA5B672CBB2E13FC145CD3F4304 Antoine Poinsot (darosior) 0AD83877C1F0CD1EE9BD660AD7CC770B81FD22A8 Ben Carman (benthecarman) 912FD3228387123DC97E0E57D5566241A0295FA9 BtcDrak C519EBCF3B926298946783EFF6430754120EC2F4 Christian Decker (cdecker)+18AE2F798E0D239755DA4FD24B79F986CBDF8736 Chun Kuan Le (ken2812221) F20F56EF6A067F70E8A5C99FFF95FAA971697405 centaur-C060A6635913D98A3587D7DB1C2491FFEB0EF770 Cory Fields+C060A6635913D98A3587D7DB1C2491FFEB0EF770 Cory Fields (cfields) BF6273FAEF7CC0BA1F562E50989F6B3048A116B5 Dev Random-6D3170C1DC2C6FD0AEEBCA6743811D1A26623924 Douglas Roark+6D3170C1DC2C6FD0AEEBCA6743811D1A26623924 Douglas Roark (droark)+1C6621605EC50319C463D56C7F81D87985D61612 Emanuele Cisbani (cisba) 9A1689B60D1B3CCE9262307A2F40A9BF167FBA47 Erik Mossberg (erkmos) D35176BE9264832E4ACA8986BF0792FBE95DC863 fivepiece+6F993B250557E7B016ADE5713BDCDA2D87A881D9 Fuzzbawls (Fuzzbawls)

It's not. The script ignores the "real name" (the first part) only looks at the aliases in parentheses.

laanwj

comment created time in 4 minutes

Pull request review commentbitcoin/bitcoin

Erlay: bandwidth-efficient transaction relay protocol

 static void ProcessGetCFCheckPt(CNode& peer, CDataStream& vRecv, const CChainPar     connman.PushMessage(&peer, std::move(msg)); } +/**+ * Announce transactions a peer is missing after reconciliation is done.+ * No need to add transactions to peer's filter or do checks+ * because it was already done when adding to the reconciliation set.+ */+void static AnnounceTxs(const std::vector<uint256>& remote_missing_wtxids, CNode& pto, const CNetMsgMaker& msgMaker, CConnman& connman)+{+    if (remote_missing_wtxids.size() != 0) {+        std::vector<CInv> remote_missing_invs;

I think this should be min, because the vector never exceeds MAX_INV_SIZE.

naumenkogs

comment created time in 18 minutes

PR closed bitcoin/bitcoin

doc: Add tracing.md, documenting eBPF tracing Docs

Add documentation for #19866.

+202 -0

3 comments

2 changed files

laanwj

pr closed time in 19 minutes

pull request commentbitcoin/bitcoin

doc: Add tracing.md, documenting eBPF tracing

The two needed commits adding the documented tracepoints would be 16ed9bc and ea608d9 from this branch laanwj:usdt-probes. Did you mean to merge them first?

No, that's not my work, it's @jb55's. I'm really confused here.

laanwj

comment created time in 19 minutes

push eventlightningd/plugins

Michael Schmoock

commit sha 92aafe7404863d13da7810fe01ca5292e5fc5dc9

chore: rename feeadjustertoggle to feeadjuster-toggle

view details

push time in 27 minutes

PR merged lightningd/plugins

chore: renames RPC feeadjusttoggle to feeadjust-toggle

After small chat with cdecker, using dash/minus in RPC name is good and will be translated to underscore in pyln on the fly.

+4 -4

4 comments

2 changed files

m-schmoock

pr closed time in 27 minutes

pull request commentlightningd/plugins

chore: renames RPC feeadjusttoggle to feeadjust-toggle

Also: do we want feeadjuster-toggle or feeadjust-toggle ? I tend to the first. Second one is only better if we rename the whole plugin, which I dont like.

I think the current feeadjuster-toggle is good in the code. Maybe the commit message could be more precise, but does not matter.

m-schmoock

comment created time in 33 minutes

push eventre-vault/revault-gui

edouard

commit sha 5af5779a546ffc65ce041aa1445281f693294a75

edit output

view details

push time in 34 minutes

Pull request review commentbitcoin/bitcoin

doc: Add developer documentation to isminetype

 class CWallet; class CScript; -/** IsMine() return codes */+/**+ * IsMine() return codes, which depend on ScriptPubKeyMan implementation.+ * Not every ScriptPubKeyMan covers all types, please refer to+ * doc/release-notes.md#ismine-semantics for better understanding.

This is https://github.com/bitcoin/bitcoin/blob/master/doc/release-notes/release-notes-0.21.0.md#ismine-semantics

fixed!

HAOYUatHZ

comment created time in 36 minutes

pull request commentlightningd/plugins

chore: renames RPC feeadjusttoggle to feeadjust-toggle

tACK fb05a96 Now I can call feeadjuster-toggle (with dash) from command line and feeadjuster_toggle (with underscore) from python RPC.

m-schmoock

comment created time in 38 minutes

pull request commentlightningd/plugins

chore: renames RPC feeadjusttoggle to feeadjust-toggle

Also: do we want feeadjuster-toggle or feeadjust-toggle ? I tend to the first. Second one is only better if we rename the whole plugin, which I dont like.

m-schmoock

comment created time in 38 minutes

pull request commentbitcoin/bitcoin

net: fix GetListenPort() to derive the proper port

d8c6dc0b6...70cd1eaef: address suggestion

vasild

comment created time in an hour

Pull request review commentbitcoin/bitcoin

net: fix GetListenPort() to derive the proper port

 void AddTimeData(const CNetAddr& ip, int64_t nOffsetSample)         }     } }++void ResetTimeData()

Renamed. I would have preferred to surround it in #ifdef UNIT_TESTS_ARE_ENABLED but couldn't find such a macro.

vasild

comment created time in an hour

pull request commentlightningd/plugins

chore: renames RPC feeadjusttoggle to feeadjust-toggle

@gallizoltan as mentioned earlier ...

m-schmoock

comment created time in an hour

PR opened lightningd/plugins

chore: renames RPC feeadjusttoggle to feeadjust-toggle

After small chat with cdecker, using dash/minus in RPC name is good and will be translated to underscore in pyln on the fly.

+4 -4

0 comment

2 changed files

pr created time in an hour

issue commentElementsProject/lightning

Multiple channels not supported

Thanks to @niftynei's efforts we have an experimental implementation of dual-funding (compile with EXPERIMENTAL_FEATURES=1). Once the specification is finalized we expect other implementations to implement the proposal as well.

peername

comment created time in an hour

pull request commentbitcoin/bitcoin

[refactor] [net] Clean up InactivityCheck()

I've pushed a small update to make the CNode& argument const now that the function isn't mutating it.

jnewbery

comment created time in an hour

Pull request review commentlightningd/plugins

rebalance: better feeadjuster integration

 def get_ideal_ratio(channels: list, enough_liquidity: Millisatoshi):   def feeadjust_would_be_nice(plugin: Plugin):-    try:+    commands = [c for c in plugin.rpc.help().get("help") if c["command"].split()[0] == "feeadjust"]

Update: doesn't seem to work, as rpc code generates method on the fly when getattr is called.

gallizoltan

comment created time in an hour

PR closed lightningd/plugins

rebalance: improve the feeadjust availability check

This can be done without invoking RPC help. Sorry I didnt get this earlier ;)

+2 -4

4 comments

1 changed file

m-schmoock

pr closed time in an hour

Pull request review commentbitcoin/bitcoin

net: fix GetListenPort() to derive the proper port

 BOOST_AUTO_TEST_CASE(addtimedata)     // not to fix this because it prevents possible attacks. See the comment in AddTimeData() or issue #4521     // for a more detailed explanation.     MultiAddTimeData(2, 100); // filter median is 100 now, but nTimeOffset will not change+    // We want this test to end with nTimeOffset==0, otherwise subsequent tests of the suite will fail.     BOOST_CHECK_EQUAL(GetTimeOffset(), 0); -    // We want this test to end with nTimeOffset==0, otherwise subsequent tests of the suite will fail.+    ResetTimeData();

I don't think so. The BOOST_CHECK_EQUAL(GetTimeOffset(), 0) check is to ensure that the net result from all the previous calls is 0. This is still true and better keep that check to ensure it remains so. Surely the check will also pass after ResetTimeData() not because the net result is 0, but because the reset obliterated the entire state.

vasild

comment created time in an hour

pull request commentlightningd/plugins

rebalance: improve the feeadjust availability check

print(callable(getattr(plugin.rpc, "this_function_does_not_exist")))

Hm, just tried and it gives me: plugin-rebalance.py: True Do you know why?

m-schmoock

comment created time in an hour

created repositoryCMTA/CMTA21

created time in an hour

pull request commentlightningd/plugins

rebalance: improve the feeadjust availability check

What happens if I call this?

print(callable(getattr(plugin.rpc, "this_function_does_not_exist")))
m-schmoock

comment created time in an hour

issue commentElementsProject/lightning

Change sqlite page_size to 4096 - massive performance improvement

Suggest separate thread, maybe link some of the relevant text in this thread. Some of the other SCAN TABLEs in the query plan might be worth pursuing but as per my analysis the expected speed increase would be significantly lower.

I could create a short document for tweaking parameters of your SQLITE based on the underlying filesystem characteristics.

mb300sd

comment created time in 2 hours

pull request commentlightningd/plugins

rebalance: improve the feeadjust availability check

Looks good to me, thanks! :)

m-schmoock

comment created time in 2 hours

PR opened bitcoin/bitcoin

Alter the ChaCha20Poly1305@Bitcoin AEAD to the new specification P2P

During discussions and reviews of BIP324 (p2p transport encryption), a more efficient AEAD was proposed.

The main difference is how the construct implements re-keying. Since both, the original and the new BIP324 AEAD will not repeat the key handshake over time (no re-keying on the ECDH level), a simpler form of direct re-keying has been proposed.

The new AEAD uses a ChaCha20 stream cipher where byte 4064 till byte 4096 (last 32 bytes in a 4096 window) are used to re-key the same instance. Re-keying in that context means re-setting the ChaCha20 key (thus setting the constant "expand 32-byte k" again, resetting the counter) to the last 32bytes of the current 4096 chunk. We never encrypt more than 4096bytes with the same key. On every re-key, we increase the IV by 1 (a sequence number). This should allow forward secrecy in the same way as the old (and slightly cumbersome) rekeying approach.

The AEAD is currently only used in tests. The serializer and deserializer for the V2 transport (#18242) will be rebased on top of this asap.

BIP324 proposal can be found here: https://gist.github.com/jonasschnelli/c530ea8421b8d0e80c51486325587c52 (soon in the BIP repository)

+182 -245

0 comment

5 changed files

pr created time in 2 hours

more