profile
viewpoint
Daniel Ye danyeh @Microsoft Redmond, WA

microsoft/vscode 106708

Visual Studio Code

danyeh/github-for-managers 1

GitHub for Managers Universe Workshop

danyeh/core-sdk 0

.NET Core SDK Setup

danyeh/core-setup 0

Installer packages for the .NET Core runtime and libraries

danyeh/docs 0

This repository contains .NET Documentation.

danyeh/sql-docs.zh-cn 0

public repo for SQL

danyeh/vs-mef 0

Managed Extensibility Framework (MEF) implementation used by Visual Studio

danyeh/vs-streamjsonrpc 0

The StreamJsonRpc library offers JSON-RPC 2.0 over any .NET Stream, WebSocket, or Pipe. With bonus support for request cancellation, client proxy generation, and more.

danyeh/vs-threading 0

The Microsoft.VisualStudio.Threading is a xplat library that provides many threading and synchronization primitives used in Visual Studio and other applications.

danyeh/vs-validation 0

Common input and integrity validation routines for Visual Studio and other applications

issue commentmicrosoft/appcenter

App uploading failed due to new app-store version

same here!! -

jayesh-hyperspace

comment created time in a few seconds

issue commentmicrosoft/vscode

Sandbox: provide a functional logger that does not depend on spdlog in renderer

I think by now we have more things running there, like settings sync. But yeah, you might not notice easily.

I am all for logging from a process that is rock solid but I am worried that this puts more pressure on the main side than needed. In the end this is the process that handles keyboard/mouse input and forwards to the window.

bpasero

comment created time in 2 minutes

issue commentmicrosoft/vscode

[rename on type] finalize OnTypeRenameProvider

What I liked about onTypeLinkedEditing is the fact that it indicates (like onTypeFormatting) that this request is send with high frequency.

In fact they are both different. OnType-formatting happens rarely and only when typing trigger characters - which you have listed beforehand. Linked editing happens on cursor move and should actually not happen when typing within a returned linked range. I'd say the frequency of linked editing ranges is similar to mark occurrences

aeschli

comment created time in 2 minutes

issue commentmicrosoft/vscode

Windows - Taskbar entry context menu is empty

We do it here:

https://github.com/microsoft/vscode/blob/ca4dd67abe11321dc977f8396616ff5e5714dfee/src/vs/platform/workspaces/electron-main/workspacesHistoryMainService.ts#L388-L388

NCC1701M

comment created time in 3 minutes

PR closed microsoft/vscode

update order of encodings alphabetically needs more info

<!-- Thank you for submitting a Pull Request. Please:

  • Read our Pull Request guidelines: https://github.com/microsoft/vscode/wiki/How-to-Contribute#pull-requests.
  • Associate an issue with the Pull Request.
  • Ensure that the code is up-to-date with the master branch.
  • Include a description of the proposed changes and how to test them. -->

This PR is a general improvement, not fixing any issue. Encodings are now sorted alphabetically. I've also changed some of the names according to references: https://docs.microsoft.com/en-us/dotnet/api/system.text.encoding https://docs.microsoft.com/en-us/dotnet/api/system.text.encodinginfo https://en.wikipedia.org/wiki/ISO/IEC_8859-15 https://en.wikipedia.org/wiki/Code_page

+116 -116

9 comments

1 changed file

iamCristYe

pr closed time in 4 minutes

issue commentmicrosoft/vscode

Search: target particular set of files

My colleague just said she'd move to vscode if there was a checkbox for Find in open files

I'd rather vote for a dropdown "Search in:" with options like "Workspace", "Open files", "Unstaged changes", "Staged changes" (but at least first two)

alvenchen

comment created time in 6 minutes

issue openedmicrosoft/vscode

Update issue

Issue Type: <b>Feature Request</b>

my version of vscode is 1.45. everytime i open vscode it always make me restart to update new version (1.51) but when i reopen vscode, it go back to version 1.45 and require update to version 1.51. really annoying. i dont know what wrong with my computer or my vcode sorry for my bad Eng =]]

VS Code version: Code 1.45.0 (d69a79b73808559a91206d73d7717ff5f798f23c, 2020-05-07T16:18:48.860Z) OS version: Windows_NT x64 10.0.18363

<!-- generated by issue reporter -->

created time in 6 minutes

issue commentmicrosoft/vscode

`new ThemeColor('errorForeground')` not working in status bar

Makes sense to me to have a 'error' property on the status bar entry. @bpasero is the owner of the status bar... (I can help out if needed)

dbaeumer

comment created time in 7 minutes

issue commentmicrosoft/vscode

Support for RTL languages

Hi, facing issue with Arabic numbers. When i paste array of Arabic numbers in vscode it get's modified and not able to get desired sequence.

Actual sequence needed - image

But when I paste it in vscode or even here in comment box, it updated as follows

var id = ['۰', '۱', '۲', '۳', '٤', '٥', '٦', '٧', '٨', '۹'];

HamzaAbdullahMoh

comment created time in 9 minutes

issue commentmicrosoft/vscode

Sandbox: provide a functional logger that does not depend on spdlog in renderer

No, when the shared process doesn't work you basically don't get extension searching/browsing. Everything pretty much works. It doesn't happen a lot, but it does happen.

bpasero

comment created time in 9 minutes

issue commentmicrosoft/vscode

Starting inspector on 127.0.0.1:9229 failed: address already in use with nodemon

Just put environment variable flag for debugging in nodemon.json config. For example for next.js users:

"env": {
    "NODE_OPTIONS": "--inspect"
  }

Worked for me without any issues

You can see example config to reference the structure. nodemon.json file should be at project root

basickarl

comment created time in 12 minutes

PR opened microsoft/VerifiableCredential-SDK-Android

Test performance of sign/verify primitives

Problem: Adding performance tests for the crypto primitives

Solution: Add special test so Logcat can show the performance with filter: PerfTest->

Validation: New unit tests

Type of change:

  • [ ] Feature work
  • [ ] Bug fix
  • [ ] Documentation
  • [ ] Engineering change
  • [x] Test
  • [ ] Logging/Telemetry

Risk:

  • [ ] High – Errors could cause MAJOR regression of many scenarios. (Example: new large features or high level infrastructure changes)
  • [ ] Medium – Errors could cause regression of 1 or more scenarios. (Example: somewhat complex bug fixes, small new features)
  • [x] Small – No issues are expected. (Example: Very small bug fixes, string changes, or configuration settings changes)
+123 -0

0 comment

1 changed file

pr created time in 16 minutes

issue commentmicrosoft/vscode

Windows - Taskbar entry context menu is empty

@bpasero As far as I understand this API call, you have to feed it with the categories (and additional entries?) Where is this happen? Where did you geht the entries/categories from? Are they hard coded? Are they from some kind of config file?

NCC1701M

comment created time in 17 minutes

pull request commentmicrosoft/vscode

update order of encodings alphabetically

so let's leave it as it is for now?

iamCristYe

comment created time in 18 minutes

issue commentmicrosoft/vscode

Sandbox: provide a functional logger that does not depend on spdlog in renderer

in case the shared process goes down or doesn't start.

Isn't that a case that pretty much makes VSCode unusable in many areas? Do we think this actually happens a lot?

Maybe we can try with shared process first always and have a fallback.

bpasero

comment created time in 20 minutes

PR opened microsoft/appcenter

Bump sample-apps/xamarin/appcenter-Xamarin.UITest-Demo from `c702180` to `017c2a9`

Bumps sample-apps/xamarin/appcenter-Xamarin.UITest-Demo from c702180 to 017c2a9. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/microsoft/appcenter-Xamarin.UITest-Demo/commit/017c2a9bf792ac08b94d779a6eaf116a948eec0d"><code>017c2a9</code></a> Update UITestDemo.iOS.csproj</li> <li><a href="https://github.com/microsoft/appcenter-Xamarin.UITest-Demo/commit/906e1bae100a0910d6714db21ebc2269131c661f"><code>906e1ba</code></a> Update UITestDemo.iOS.csproj</li> <li><a href="https://github.com/microsoft/appcenter-Xamarin.UITest-Demo/commit/cea669ab12f4192fb9872da39fa9aecf8ced9b2c"><code>cea669a</code></a> Update appcenter-post-build.sh</li> <li><a href="https://github.com/microsoft/appcenter-Xamarin.UITest-Demo/commit/b91c872948a675d86c17733009514effd2142b52"><code>b91c872</code></a> fix for latest packages</li> <li><a href="https://github.com/microsoft/appcenter-Xamarin.UITest-Demo/commit/66ed7f66656e5a502dab729e3566d232b9d1b452"><code>66ed7f6</code></a> general package updates</li> <li><a href="https://github.com/microsoft/appcenter-Xamarin.UITest-Demo/commit/ae4ce780556dc4971d2f6a873f1a9eb6f5bd1385"><code>ae4ce78</code></a> add missing Xamarin.AndroidX packages based on failures</li> <li><a href="https://github.com/microsoft/appcenter-Xamarin.UITest-Demo/commit/a6271d33530f5af1d263149653a4599a69b9bebb"><code>a6271d3</code></a> Android package retargeting</li> <li>See full diff in <a href="https://github.com/microsoft/appcenter-Xamarin.UITest-Demo/compare/c702180956c11f8f3c40e150b19855c2e41c8de1...017c2a9bf792ac08b94d779a6eaf116a948eec0d">compare view</a></li> </ul> </details> <br />

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

</details>

+1 -1

0 comment

1 changed file

pr created time in 21 minutes

issue commentmicrosoft/vscode

Windows - Taskbar entry context menu is empty

@NCC1701M we use Electron API for that, so even if it is still broken, I do not see how we can fix it. https://github.com/electron/electron/blob/7-0-x/docs/api/app.md#appsetjumplistcategories-windows

NCC1701M

comment created time in 21 minutes

issue commentmicrosoft/vscode

[rename on type] finalize OnTypeRenameProvider

What I liked about onTypeLinkedEditing is the fact that it indicates (like onTypeFormatting) that this request is send with high frequency. However this being said the same is true for completion :-). So I am fine going with @jrieken proposals.

@aeschli when do you plan to do the renaming. Then I will catchup with LSP

aeschli

comment created time in 24 minutes

issue commentmicrosoft/vscode

Support changing default Symbol icons based on symbol information.

This is IMO unrelated to LSP. VS Code itself has no API to change the icon of a symbol. Assigning to @jrieken

gayanper

comment created time in 28 minutes

issue commentmicrosoft/vscode

skipFiles has no effect on tslib.js

(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

oliversalzburg

comment created time in 31 minutes

issue openedmicrosoft/vscode

skipFiles has no effect on tslib.js

Issue Type: <b>Bug</b>

  1. Add tslib.js into the skipFiles of a debug configuration and start debugging.
  2. At some point you'll step right into tslib.js, even though it should be skipped.

This could be https://github.com/microsoft/vscode/issues/104421 in case it still hasn't been fixed. But the nightly has other major issues right now and is unusable.

VS Code version: Code 1.51.1 (e5a624b788d92b8d34d1392e4c4d9789406efe8f, 2020-11-10T23:34:32.027Z) OS version: Windows_NT x64 10.0.19042 Remote OS version: Linux x64 4.19.128-microsoft-standard Remote OS version: Linux x64 4.19.128-microsoft-standard Remote OS version: Linux x64 4.19.128-microsoft-standard

<details> <summary>System Info</summary>

Item Value
CPUs Intel(R) Core(TM) i7-6850K CPU @ 3.60GHz (12 x 3598)
GPU Status 2d_canvas: enabled<br>flash_3d: enabled<br>flash_stage3d: enabled<br>flash_stage3d_baseline: enabled<br>gpu_compositing: enabled<br>multiple_raster_threads: enabled_on<br>oop_rasterization: disabled_off<br>opengl: enabled_on<br>protected_video_decode: unavailable_off<br>rasterization: enabled<br>skia_renderer: disabled_off_ok<br>video_decode: enabled<br>vulkan: disabled_off<br>webgl: enabled<br>webgl2: enabled
Load (avg) undefined
Memory (System) 63.91GB (40.04GB free)
Process Argv --file-uri=vscode-remote://wsl+Ubuntu/home/oliver/fairmanager/fairmanager/core-web3/core.code-workspace --remote=wsl+Ubuntu --crash-reporter-id f825acfe-92fa-4526-a38a-f8815cf9f7ea
Screen Reader no
VM 0%
Item Value
Remote WSL: Ubuntu
OS Linux x64 4.19.128-microsoft-standard
CPUs Intel(R) Core(TM) i7-6850K CPU @ 3.60GHz (12 x 3597)
Memory (System) 50.14GB (38.30GB free)
VM 0%
Item Value
Remote WSL: Ubuntu
OS Linux x64 4.19.128-microsoft-standard
CPUs Intel(R) Core(TM) i7-6850K CPU @ 3.60GHz (12 x 3597)
Memory (System) 50.14GB (38.30GB free)
VM 0%
Item Value
Remote WSL: Ubuntu
OS Linux x64 4.19.128-microsoft-standard
CPUs Intel(R) Core(TM) i7-6850K CPU @ 3.60GHz (12 x 3597)
Memory (System) 50.14GB (38.30GB free)
VM 0%

</details><details><summary>Extensions (29)</summary>

Extension Author (truncated) Version
javascript-ejs-support Dig 1.3.1
eslint-disable-snippets drK 1.2.0
output-colorizer IBM 0.1.2
remote-containers ms- 0.148.1
remote-ssh ms- 0.56.0
remote-ssh-edit ms- 0.56.0
remote-wsl ms- 0.51.4
vscode-remote-extensionpack ms- 0.20.0
vscode-icons vsc 11.0.0
vscode-zipfs arc 2.2.2
better-toml bun 0.3.2
vscode-eslint dba 2.1.13
eslint-disable-snippets drK 1.2.0
gitlens eam 11.0.5
EditorConfig Edi 0.16.1
prettier-vscode esb 5.8.0
vs-code-xml-format fab 0.1.5
generateuuid Fir 0.0.5
shell-format fox 7.0.1
terraform has 2.3.0
vscode-esformatter how 1.6.0
template-string-converter meg 0.3.3
code-beautifier mic 2.3.3
vscode-docker ms- 1.8.1
vscode-js-profile-flame ms- 0.0.13
vscode-paste-image mus 1.0.4
vscode-xml red 0.14.0
vscode-yaml red 0.13.0
lit-plugin run 1.2.1

(2 theme extensions excluded)

</details> <!-- generated by issue reporter -->

created time in 31 minutes

issue commentmicrosoft/vscode

Windows - Taskbar entry context menu is empty

🤷‍♂️ This can only be answerd when insider becomes stable.

Maybe some settings are corrupt. Where does the "New Window" entry comes from? Is it set up in the registry or any config file?

NCC1701M

comment created time in 32 minutes

issue commentmicrosoft/vscode

Sandbox: provide a functional logger that does not depend on spdlog in renderer

Both approaches would block the JS thread at some point in time, so I don't see a clear winner from that standpoint.

I would prefer the renderer not depend on the shared process for logging since we wouldn't get any rendered logs in case the shared process goes down or doesn't start.

I'd much rather we have a channel implementation of the ILogService which forwards logging to the main process and have that call spdlog.

bpasero

comment created time in 33 minutes

pull request commentmicrosoft/vscode

update order of encodings alphabetically

Do you still want to make tweaks to the labels at least?

iamCristYe

comment created time in 34 minutes

push eventmicrosoft/vscode

João Moreno

commit sha 043c17ef7d320a47ef22ec80ca34e5b5afe1b75c

update azure cosmos :shrug:

view details

VSCode

commit sha 73fe08b636bca769975c28c239abd922f7e0178c

Merge remote-tracking branch 'origin/master' into HEAD

view details

push time in 38 minutes

issue commentmicrosoft/vscode

Windows - Taskbar entry context menu is empty

So it works in insiders but not in stable? Then I guess we fixed it?

NCC1701M

comment created time in 38 minutes

push eventmicrosoft/vscode

João Moreno

commit sha 043c17ef7d320a47ef22ec80ca34e5b5afe1b75c

update azure cosmos :shrug:

view details

push time in 39 minutes

more