danrice-square ( Daniel Rice )

Resolves #1859 by using WireOutput for the WireTask property and normalizing its path. I need to double check if String is valid for path normalizing though

+27 -7

1 commit in ZacSweers/wire/tree/z/cacheFix square/wire/tree/master

0 comment

3 changed files

pr created time in a day

issue openedsquare/wire

WireTask uses non-normalized paths and breaks Gradle build caching

After doing some simple local build caching tests with the same project in multiple locations, build scans revealed that WireTask is not up to date when it should be due to using non-normalized paths in its transforms property

Namely - outDirectory

Output from a simple snippet to print it

tasks.withType<WireTask>().configureEach {
  doFirst { println(transforms) }
}

KotlinTarget(includes=[*], excludes=[], exclusive=true, outDirectory=/Users/zsweers/dev/slack/slack-android-ng/telemetry-definitions/build/generated/source/wire, android=false, javaInterop=false, emitDeclaredOptions=true, emitAppliedOptions=false, rpcCallStyle=SUSPENDING, rpcRole=CLIENT, singleMethodServices=false)

created time in 2 days

issue commentsquare/wire

Drop oneof with sealed classes

@swankjesse isn't the same true for swift enum also though? I believe that exhaustiveness benefits are far too good to discard. Isn't having the compiler guard you against proto z changes and not relying on runtime checks the whole point of having a contract in the first place?

Egorand

comment created time in 6 days

issue openedsquare/wire

Relocating proto files

Thanks for open sourcing wire-schema, which allows us to parse the proto files, but when we try to use it along with Protobuf core library, we found similar resource file (having proto files) in both the jar. Is it possible to relocate the proto files ? Do we use them in the runtime ?

created time in 7 days

push eventsquare/wire

cgarrett-square

commit sha de48be92aba5aa3d72645f88c9173ebccad865dc

Fixing up comments, typos, and syntax based on feedback on PR 1842 (Add option for how Swift ProtoDecoder handles unknown enum values). (#1857)

view details

push time in 10 days

delete branch square/wire

delete branch : cgarrett/nil-unknown-enum-touchups

delete time in 10 days

PR merged square/wire

Fixing up comments, typos, and syntax based from Swift Unknown Enums PR

I was unable to address some nits in the following PR, but still got permission to merge: https://github.com/square/wire/pull/1842. This PR addresses those issues.

+6 -7

1 commit in square/wire/tree/cgarrett/nil-unknown-enum-touchups square/wire/tree/master

0 comment

2 changed files

cgarrett-square

pr closed time in 10 days

PR opened square/wire

Fixing up comments, typos, and syntax based from Swift Unknown Enums PR

I was unable to address some nits in the following PR, but still got permission to merge: https://github.com/square/wire/pull/1842. This PR addresses those issues.

+6 -7

1 commit in square/wire/tree/cgarrett/nil-unknown-enum-touchups square/wire/tree/master

0 comment

2 changed files

pr created time in 11 days

create barnchsquare/wire

branch : cgarrett/nil-unknown-enum-touchups

created branch time in 11 days

push eventsquare/wire

Benoit Quenaudon

commit sha d164bc4991e9ce96944adaa10618d165283729d2

Sample of new handling for OneOf's

view details

push time in 14 days

push eventsquare/wire

Benoit Quenaudon

commit sha c1ae1a97f7d840e433dab11d6fe22e9daddd35a8

Sample of new handling for OneOf's

view details

push time in 14 days

pull request commentsquare/wire

WIP: Sample of new handling for OneOf's

Very excited to see this, having some sort of "which field is active"-enum (rather than looking for a non-null field) is very interesting to me right now. ❤️

oldergod