profile
viewpoint
Daniel Husar danielhusar @intercom San Francisco https://www.danielhusar.sk Product Engineer @intercom

danielhusar/gatsby-theme-spring 8

Robust gatsby theme for your blog.

danielhusar/babel-plugin-react-add-a11y-props 6

Add onKeyUp, role and tabIndex props to react elements with onClick handler.

danielhusar/focus-trap 6

Add focus traps around elements.

danielhusar/from-now 5

Get relative time (ago) like 5 seconds, 12 hours, 3 months...

danielhusar/a11y-report 2

Run accessibility report on the provided urls via axe-core

danielhusar/a11y-static-report 2

Run accessibility report on static pages via axe-core

danielhusar/captcha 2

php captcha

danielhusar/csfd 2

Node.js api for the csfd.

danielhusar/exec-chainable 2

Exec shell command and return promise so you can chain commands

startedviewstools/yarn-workspaces-cra-crna

started time in 2 days

create barnchslovensko-digital/navody.digital

branch : dh/bugfix

created branch time in 3 days

startedQuramy/lerna-yarn-workspaces-example

started time in 3 days

push eventslovensko-digital/navody.digital

Daniel Husar

commit sha 6cba9378e9f6910d278a8054020728b35b2106c9

Add warning

view details

push time in 8 days

Pull request review commentslovensko-digital/navody.digital

Create current topic

       <%= @active_current_topic.body.html_safe %>     </div>     <div>-      <a href="#" data-key="<%= @active_current_topic.key %>">Skryť správu</a>+      <a href="#" class="js__active-topic-close">Skryť správu</a>     </div>   </div>   </div> </div>+<script src="https://cdn.jsdelivr.net/npm/js-cookie@rc/dist/js.cookie.min.js"></script>+<script>+  document.querySelector('.js__active-topic-close').addEventListener('click', function(e) {

Hodil som to do application.

danielhusar

comment created time in 8 days

PullRequestReviewEvent

push eventslovensko-digital/navody.digital

Daniel Husar

commit sha e28e7f6b86323d477b75e978229c260b53c905bd

Move js logic to application

view details

push time in 8 days

Pull request review commentslovensko-digital/navody.digital

Create current topic

       <%= @active_current_topic.body.html_safe %>     </div>     <div>-      <a href="#" data-key="<%= @active_current_topic.key %>">Skryť správu</a>+      <a href="#" class="js__active-topic-close">Skryť správu</a>     </div>   </div>   </div> </div>+<script src="https://cdn.jsdelivr.net/npm/js-cookie@rc/dist/js.cookie.min.js"></script>

hotovo :)

danielhusar

comment created time in 8 days

PullRequestReviewEvent

PR opened slovensko-digital/navody.digital

Add current topic migration

Run VERSION=20200919092214 rails db:migrate:up

+58 -1

0 comment

2 changed files

pr created time in 8 days

create barnchslovensko-digital/navody.digital

branch : dh/current_topic_migration

created branch time in 8 days

push eventslovensko-digital/navody.digital

Daniel Husar

commit sha c7ac36b9a75595f482078587e5b7617c26db2447

Inline jscookie

view details

push time in 8 days

Pull request review commentslovensko-digital/navody.digital

Create current topic

       <%= @active_current_topic.body.html_safe %>     </div>     <div>-      <a href="#" data-key="<%= @active_current_topic.key %>">Skryť správu</a>+      <a href="#" class="js__active-topic-close">Skryť správu</a>     </div>   </div>   </div> </div>+<script src="https://cdn.jsdelivr.net/npm/js-cookie@rc/dist/js.cookie.min.js"></script>+<script>+  document.querySelector('.js__active-topic-close').addEventListener('click', function(e) {

Hmm cojaviem ja som celkom fanusik mat to hned vedla template, takto mas tento cely "komponent" pokope. Ale kldune to hodim to application ak chces.

danielhusar

comment created time in 8 days

PullRequestReviewEvent

Pull request review commentslovensko-digital/navody.digital

Create current topic

       <%= @active_current_topic.body.html_safe %>     </div>     <div>-      <a href="#" data-key="<%= @active_current_topic.key %>">Skryť správu</a>+      <a href="#" class="js__active-topic-close">Skryť správu</a>     </div>   </div>   </div> </div>+<script src="https://cdn.jsdelivr.net/npm/js-cookie@rc/dist/js.cookie.min.js"></script>

oki hodim to localne niekam

danielhusar

comment created time in 8 days

PullRequestReviewEvent

push eventslovensko-digital/navody.digital

Daniel Husar

commit sha 5098ce697f5cdd839c2d9081e71a63d2225a5d6c

Add more styles

view details

push time in 8 days

push eventslovensko-digital/navody.digital

Daniel Husar

commit sha 6e69e42597ffd40f7f97510d55571a0106e0a717

Add some basic styles to active topic banner

view details

push time in 8 days

push eventslovensko-digital/navody.digital

Daniel Husar

commit sha 5a51dd6ee518aa338dcaf3809e44b8139aa5d998

Remove key and rename value to body

view details

push time in 8 days

push eventslovensko-digital/navody.digital

Daniel Husar

commit sha 86ce1a79fd46f551573e1e0a84c9efe47e6d9ada

Add spec

view details

push time in 8 days

push eventslovensko-digital/navody.digital

Daniel Husar

commit sha 4d45687c3286bc762b5eb7cb806e1270ed5292ff

Remove destroy from whitelist

view details

push time in 8 days

PR opened slovensko-digital/navody.digital

Create current topic

https://github.com/slovensko-digital/navody.digital/issues/288

Zatial len admin panel:

Screenshot 2020-09-19 at 12 27 40

Spravil som to prakticky skoro ako singleton, kde to stale hodi rovno na editaciu posledneho current topic.

Migration mozem odtial vyhodit do osobitne PR ak treba. Inac neviem ci structure.sql je vygenerovane spravne, kedze bolo tam aj par inych nesuvisiacich zmien. (ktore som manualne vyhodil, asi mam inu postress verziu)

+128 -1

0 comment

10 changed files

pr created time in 8 days

push eventslovensko-digital/navody.digital

Daniel Husar

commit sha d20cabf7f93377973ed4631cd57dc2dbb09631a4

Fix active class

view details

push time in 8 days

create barnchslovensko-digital/navody.digital

branch : dh/aktualna-tema

created branch time in 8 days

push eventslovensko-digital/navody.digital

Daniel Husar

commit sha 19f1053121123a5538869247d08d3a0fcf1bbd52

Add bundle to steps

view details

push time in 8 days

PR opened slovensko-digital/navody.digital

Add more instructions for setup

Robil som setup po dlhsej dobe, a toto nam chyba.

+5 -1

0 comment

2 changed files

pr created time in 8 days

create barnchslovensko-digital/navody.digital

branch : dh/instructions

created branch time in 8 days

issue commentfacebook/react-native

unable to scroll in scrollView in Android

I have similar issue. It only appear when ScrollView is in the tree that has position absolute.

johnneuland

comment created time in 16 days

startedtype-challenges/type-challenges

started time in 18 days

delete branch danielhusar/gatsby-theme-spring

delete branch : dependabot/npm_and_yarn/decompress-4.2.1

delete time in 22 days

push eventdanielhusar/gatsby-theme-spring

dependabot[bot]

commit sha cbb6a463422e6412ab828dbdd23a0e07e2e858a3

Bump decompress from 4.2.0 to 4.2.1 Bumps [decompress](https://github.com/kevva/decompress) from 4.2.0 to 4.2.1. - [Release notes](https://github.com/kevva/decompress/releases) - [Commits](https://github.com/kevva/decompress/compare/v4.2.0...v4.2.1) Signed-off-by: dependabot[bot] <support@github.com>

view details

Daniel Husar

commit sha 1591204bab0bf005ae13b0feb30637add5e05bf8

Merge pull request #28 from danielhusar/dependabot/npm_and_yarn/decompress-4.2.1 Bump decompress from 4.2.0 to 4.2.1

view details

push time in 22 days

PR merged danielhusar/gatsby-theme-spring

Bump decompress from 4.2.0 to 4.2.1 dependencies

Bumps decompress from 4.2.0 to 4.2.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/kevva/decompress/releases">decompress's releases</a>.</em></p> <blockquote> <h2>v4.2.1</h2> <ul> <li>Prevent directory traversal (<a href="https://github-redirect.dependabot.com/kevva/decompress/issues/73">#73</a>) 967146e</li> </ul> <p><a href="https://github.com/kevva/decompress/compare/v4.2.0...v4.2.1">https://github.com/kevva/decompress/compare/v4.2.0...v4.2.1</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/kevva/decompress/commit/84a8c1046946add1a6ae01c54dbebf312e4ffc85"><code>84a8c10</code></a> 4.2.1</li> <li><a href="https://github.com/kevva/decompress/commit/fafff47880cb5b47b022cd7be5542d576448603a"><code>fafff47</code></a> Meta tweaks</li> <li><a href="https://github.com/kevva/decompress/commit/967146e70f48be32ed1a69daa3941d681944d513"><code>967146e</code></a> Prevent directory traversal (<a href="https://github-redirect.dependabot.com/kevva/decompress/issues/73">#73</a>)</li> <li><a href="https://github.com/kevva/decompress/commit/74a462a139cc2561b6695e696266c8dc31562d3d"><code>74a462a</code></a> Meta tweaks</li> <li><a href="https://github.com/kevva/decompress/commit/7ddadd92139079e520cb822a03fe4260b7db7676"><code>7ddadd9</code></a> Add note about <code>filter</code> option</li> <li>See full diff in <a href="https://github.com/kevva/decompress/compare/v4.2.0...v4.2.1">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+61 -52

0 comment

1 changed file

dependabot[bot]

pr closed time in 22 days

startedfrancisrstokes/super-expressive

started time in a month

startedfczbkk/koderske-testy

started time in a month

pull request commentpriznanie-digital/priznanie-digital

Add prettier pre commit hook

Rebasol som to takze to kludne mergni ked vyhodis tie checks

danielhusar

comment created time in 3 months

pull request commentpriznanie-digital/priznanie-digital

Add prettier pre commit hook

@wormyy musis vyhodit tie required checks kym nie je github actions branch mergnuta :)

danielhusar

comment created time in 3 months

Pull request review commentpriznanie-digital/priznanie-digital

Add prettier pre commit hook

     "typescript": "^3.7.5",     "webpack": "4.42.0",     "xml2js": "^0.4.23"+  },+  "husky": {+    "hooks": {+      "pre-commit": "lint-staged"+    }+  },+  "lint-staged": {+    "*.{js,ts,tsx,css,json,md}": [+      "prettier --write",

Ja by som pouzil obe. Prettier na formatting, a eslint na logiku.

danielhusar

comment created time in 3 months

push eventpriznanie-digital/priznanie-digital

Daniel Husar

commit sha bd27e539edc980d0ae82988f759f264c8bce3f37

pin

view details

push time in 3 months

push eventpriznanie-digital/priznanie-digital

depfu[bot]

commit sha 774991e03d5e6149c578bdb28ac5f9942d402708

Update all npm dependencies (2020-07-02) (#188) Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>

view details

Július Retzer

commit sha 221a7c57e61b8b146684e8d75c747d2e0d326d13

Update travis

view details

Július Retzer

commit sha d698ab67a015c59624032e9b3c40da97e5d787f7

fix travis (#191)

view details

Július Retzer

commit sha b7e1f431fd11cc2b84494e406e5b3c1fe17743bb

Pin deps (#190)

view details

Július Retzer

commit sha 4363d17c7f7c45e304b6f5de7745033eb071f8a5

Add meta tags (#194)

view details

imgbot[bot]

commit sha 7c3ce763c57b4d4e9f381aebd3e9638e888641f3

[ImgBot] Optimize images (#195) *Total -- 189.65kb -> 146.96kb (22.51%) /public/assets/images/icon-dots.svg -- 1.22kb -> 0.74kb (39.95%) /public/assets/images/icon-check-black.svg -- 0.53kb -> 0.34kb (35.06%) /public/assets/images/icon-hourglass.svg -- 1.19kb -> 0.78kb (34.64%) /public/assets/images/icon-check.svg -- 0.87kb -> 0.60kb (30.82%) /public/assets/images/meta-img.png -- 161.30kb -> 121.88kb (24.44%) /public/assets/images/icon-pencil.svg -- 1.02kb -> 0.77kb (24.43%) /public/assets/images/icon-external-link-white.svg -- 2.06kb -> 1.63kb (20.65%) /public/assets/images/icon-external-link.svg -- 2.06kb -> 1.63kb (20.57%) /public/assets/images/icon-search.svg -- 0.75kb -> 0.60kb (20.13%) /public/assets/images/priznanie_logo.png -- 2.28kb -> 1.83kb (19.61%) /public/assets/images/arrow-pointing-to-right.svg -- 0.74kb -> 0.69kb (6.45%) /public/zeit.svg -- 0.75kb -> 0.71kb (5.21%) /public/assets/images/navody-logo.svg -- 5.54kb -> 5.47kb (1.41%) /public/assets/images/govuk-mask-icon.svg -- 3.01kb -> 2.98kb (1.14%) /public/assets/images/govuk-logotype-crown.png -- 0.93kb -> 0.92kb (0.95%) /public/assets/images/icon-facebook.svg -- 0.42kb -> 0.42kb (0.23%) /public/assets/images/icon-github.svg -- 2.57kb -> 2.57kb (0.15%) /public/assets/images/icon-youtube.svg -- 2.40kb -> 2.40kb (0.08%) Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com> Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>

view details

Daniel Husar

commit sha 72944c5ba36e96158b0541b65fff2c291a1d9f7c

Add prettier pre commit hook

view details

push time in 3 months

pull request commentpriznanie-digital/priznanie-digital

Pin deps

Nevyhody:

  • Nemozem nachval nieco pin, alebo dat len patch etc.. Co ak bude nejaka dependency kde mozem pouzit len urcitu verziu? Ak niekto nazrie do package.json tak neuvidi ziadny problem, kdezto ked mas len jeden pin tak je ocividne ze je to naschval. My v Intercom sme tento pripad uz mali (konkretne pri tomto: https://www.npmjs.com/package/css).
  • Nemozem napisat npm update next ale musim ist manualne do package.json :(
  • Falosny pocit security kedze jedine naco si dal pin su top level dependency, lenze inch dependency sa mozu menit - to riesi prave ten lockfile, len mat to na dvoch miestach mi pride divne

Necham to na teba :) nevadi mi to, len som ti chcel dat vediet ze to prinasa viac problemov ako benefitov.

wormyy

comment created time in 3 months

push eventpriznanie-digital/priznanie-digital

Július Retzer

commit sha 8fd7a3ffff1cb7a49df9a79127af65fcd9578a9e

Add meta tags (#194)

view details

Július Retzer

commit sha fd02d0a315a191f4dec288f5f8421942694a2209

Merge pull request #196 from priznanie-digital/meta-to-master

view details

Daniel Husar

commit sha 9a060829c79c5a05476aa83021f26bf41cf02e65

Add prettier pre commit hook

view details

push time in 3 months

pull request commentpriznanie-digital/priznanie-digital

Pin deps

No ale ty to uz mas explicitne prave cez ten lockfile.

To ze si to vsetko pinol si si len hodil polena pod nohy pretoze ma to viac nevyhod ako vyhod :)

Ale jasne nie je to az tak podstatne a predovsetkym to nie je kopec na ktorom chcem zomriet, len moj nazor :)

wormyy

comment created time in 3 months

pull request commentpriznanie-digital/priznanie-digital

Pin deps

Co ak chcem na nejaku dependency mat pin pernamentne, na inu len patch a na dalsiu minor?

wormyy

comment created time in 3 months

pull request commentpriznanie-digital/priznanie-digital

Pin deps

Lock file je podla mna dostatocne riesenie kedze je generovany automaticky. yarn.lock je trochu lepsi ale package-lock.json tiez staci.

Vyhoda je jednoduchy update. Teraz to musis vsetko manualnea nevies to ani nijak automatizovat :(

A ten pin ani tak vela neriesi pretoze kebyze vymazes lock file a zbehnes npm install teraz a potom o pol roka, nie je garantovane ze sa nainstaluju presne tie iste dependencies (ale to je problem npm). Lock file tento problem riesi.

To ze lock file nie je human readable je fajn, je to pre pocitac nie pre teba :) Ak chces vidiet verziu balicka staci napisat npm list <package>

wormyy

comment created time in 3 months

pull request commentpriznanie-digital/priznanie-digital

Pin deps

Jop, je to uplne zbytocne kedze je tu lock file.

wormyy

comment created time in 3 months

pull request commentpriznanie-digital/priznanie-digital

Pin deps

preco? 😄

wormyy

comment created time in 3 months

push eventpriznanie-digital/priznanie-digital

Július Retzer

commit sha 3d5fea5d7c2c3e25ab267808b1cfe2826a07d93d

Rounding - Bug report 3 (#176)

view details

Július Retzer

commit sha 9d2dac5a7b3ec166980404693171d3126c899ae5

add slovensko.digital favicon (#183)

view details

Július Retzer

commit sha c4bf8076b5f4caa799f87bb0a87e3a7e1bded506

remove public js (#182)

view details

Daniel Husar

commit sha 0e33cb49325fbafdf4a0fd7d36f3d9c7c59664f6

Merge branch 'master' into dh/prettier

view details

push time in 3 months

push eventpriznanie-digital/priznanie-digital

Daniel Husar

commit sha 648b73f45e3dae83e9df8364334e54ae8d7ac790

Add beforeEach

view details

push time in 3 months

pull request commentpriznanie-digital/priznanie-digital

Add prettier pre commit hook

Hmm my to pouzivame v robote vsade a nebol zatial problem v ovela vacsich codebases. Este mozme dat do ci prettier -l co v podstate zbehne prettier ale iba reportne ak nieco je nenaformatovane.

danielhusar

comment created time in 3 months

Pull request review commentpriznanie-digital/priznanie-digital

Rounding - Bug report 3

 import {   parseInputNumber, } from './utils' import Decimal from 'decimal.js'-import { sum } from './utils'+import { sum, ceilDecimal } from './utils';

https://github.com/priznanie-digital/priznanie-digital/pull/177

wormyy

comment created time in 3 months

PR opened priznanie-digital/priznanie-digital

Add prettier pre commit hook

https://github.com/priznanie-digital/priznanie-digital/pull/176#discussion_r448537606

Automaticky zbehne prettier na vsetky subory v staged area pred commitom

+848 -62

0 comment

2 changed files

pr created time in 3 months

create barnchpriznanie-digital/priznanie-digital

branch : dh/prettier

created branch time in 3 months

Pull request review commentpriznanie-digital/priznanie-digital

Rounding - Bug report 3

 import {   parseInputNumber, } from './utils' import Decimal from 'decimal.js'-import { sum } from './utils'+import { sum, ceilDecimal } from './utils';

bezi ti prettier? vyzera ze ; je extra

wormyy

comment created time in 3 months

Pull request review commentpriznanie-digital/priznanie-digital

Replace travis with github actions

+name: Github Test CI++on:+  pull_request:+    branches: [ master ]++jobs:+  lint:+    name: Lint+    runs-on: ubuntu-latest++    steps:+      - name: Checkout repository+        uses: actions/checkout@master+        with:+          submodules: 'recursive'++      - name: Read .nvmrc+        run: echo "##[set-output name=NVMRC;]$(cat .nvmrc)"+        id: nvm++      - name: Use Node.js (.nvmrc)+        uses: actions/setup-node@master+        with:+          node-version: "${{ steps.nvm.outputs.NVMRC }}"++      - name: Cache node modules

tak potom neviem 🤷‍♂️ mozme skusit yarn, ten je podla mna rychlejsi, aj ked asi to je jedno, tych par sekund co sa usetri podla mna zato nestoji

danielhusar

comment created time in 3 months

Pull request review commentpriznanie-digital/priznanie-digital

Replace travis with github actions

+name: Github Test CI++on:+  pull_request:+    branches: [ master ]++jobs:+  lint:+    name: Lint+    runs-on: ubuntu-latest++    steps:+      - name: Checkout repository+        uses: actions/checkout@master+        with:+          submodules: 'recursive'++      - name: Read .nvmrc+        run: echo "##[set-output name=NVMRC;]$(cat .nvmrc)"+        id: nvm++      - name: Use Node.js (.nvmrc)+        uses: actions/setup-node@master+        with:+          node-version: "${{ steps.nvm.outputs.NVMRC }}"++      - name: Cache node modules

Ja myslim ze by to malo fungovat aj bez toho, ale nie som si ulne isty. Ta cache len cachuje .npm priecinok, cize npm install moze pouzit packages z disku namiesto stahovania.

Tu to vidis ze cache bola restornuta https://github.com/priznanie-digital/priznanie-digital/pull/169/checks?check_run_id=826968457#step:5:15

Aspon v robote to mamte takto vsade :)

danielhusar

comment created time in 3 months

delete branch priznanie-digital/priznanie-digital

delete branch : dh/test

delete time in 3 months

push eventdanielhusar/releaseapp

Daniel Husar

commit sha bf7a9c3ae0a3f6e515f68e056ad24fd0f9981ccc

Make main bigger

view details

push time in 3 months

push eventpriznanie-digital/priznanie-digital

Daniel Husar

commit sha 9819be8a091e18f3c24f809ec6e81a0ba01aa3f9

Custom focus on `suhrn` and `vysledky` pages (#167) * Custom focus on `suhrn` and `vysledky` pages * data-focus => autofocus * Revert "data-focus => autofocus" This reverts commit a30423d40f986a537e02a2048fdccacd41854f08. * Remove custom focus logic

view details

push time in 3 months

delete branch priznanie-digital/priznanie-digital

delete branch : dh/focus

delete time in 3 months

PR merged priznanie-digital/priznanie-digital

Custom focus on `suhrn` and `vysledky` pages

https://trello.com/c/f6NlD8lQ/137-bug-accessibility-improvements

+0 -12

0 comment

1 changed file

danielhusar

pr closed time in 3 months

PR opened danielhusar/releaseapp

Change layout of the environments page
+156 -176

0 comment

10 changed files

pr created time in 3 months

create barnchdanielhusar/releaseapp

branch : redesign

created branch time in 3 months

PublicEvent

push eventdanielhusar/releaseapp

Daniel Husar

commit sha d50b1a2cbb340ecf65bbbb21b534121ccb051dca

Remove extra backslash from the readme

view details

push time in 3 months

push eventpriznanie-digital/priznanie-digital

Matej Lednicky

commit sha aa65df7e47d6319168050e54c39d113988c9ccb4

WIP: Replace Travis job with Github Actions TODO: Cache issues.

view details

Matej Lednicky

commit sha 96dbf52bb9e34139ecfbc37cd81b34f30aebc488

Remove cache? Travis is not working when installed from cache.

view details

Daniel Husar

commit sha 267aac1cd0745cb9b4a56f3c255b2ebdf7b2a1c0

Split test into multiple jobs

view details

Daniel Husar

commit sha af2eeb0005dbac0659b3d7cb28321e7305fbe9df

Rename jobs

view details

Daniel Husar

commit sha 86888bbc68bf000da30a3e7fc233d378ab781e99

Cache next dir

view details

Daniel Husar

commit sha 28706be52abc77fc4460ebb7da051e510ebc90e6

Add submodules

view details

Daniel Husar

commit sha b513847eae867f88f14cb6695b75e5e2be9b4fba

Fix cache

view details

push time in 3 months

push eventpriznanie-digital/priznanie-digital

Daniel Husar

commit sha dba5ae53c3e06a93b8ba0cca05114e1254ffa7b9

Change cache key

view details

push time in 3 months

push eventpriznanie-digital/priznanie-digital

Daniel Husar

commit sha 1040574d83c764d8901af15939d2075b2966cced

Fix cache

view details

push time in 3 months

push eventpriznanie-digital/priznanie-digital

Daniel Husar

commit sha c71d3d44a6a3618d167c4ba0a6b3104e4e9e06f4

Add submodules

view details

push time in 3 months

create barnchpriznanie-digital/priznanie-digital

branch : dh/test

created branch time in 3 months

push eventpriznanie-digital/priznanie-digital

Daniel Husar

commit sha 6f55318a3a528447d38f4d79228b03a3abf288ab

Cache next dir

view details

push time in 3 months

push eventpriznanie-digital/priznanie-digital

Daniel Husar

commit sha e457e46e2f8f395febe5f40d52c1e51a1a991d29

Rename jobs

view details

push time in 3 months

create barnchpriznanie-digital/priznanie-digital

branch : dh/github-actions

created branch time in 3 months

pull request commentpriznanie-digital/priznanie-digital

WIP: travis cache

Oh nvm, akurat vidim https://github.com/priznanie-digital/priznanie-digital/pull/166

mathio

comment created time in 3 months

pull request commentpriznanie-digital/priznanie-digital

WIP: travis cache

Co tak prehodit to an github actions? To je v dnesnej dobe lepsie riesenie ako travis. Mozem kludne pripravit PR.

mathio

comment created time in 3 months

Pull request review commentpriznanie-digital/priznanie-digital

Custom focus on `suhrn` and `vysledky` pages

 const MyApp: React.FC<MyAppProps> = ({ Component, pageProps }) => {   }, [router, nextRoute, taxForm, taxFormUserInput])    useEffect(() => {+    const defaultFocus = document.querySelector(+      '[data-focus]',

Moj jediny problem s autofocus je ze sa nto proste zabudne :( Ale chapem no ze totot tu sa uz zamotava :( Vyhodil som celu tu logiku a prehodim to neskor na autofocus

danielhusar

comment created time in 3 months

push eventpriznanie-digital/priznanie-digital

Daniel Husar

commit sha c3de0eedba5004e8fa32b9370493aaef88b6b67e

Remove custom focus logic

view details

push time in 3 months

push eventpriznanie-digital/priznanie-digital

Daniel Husar

commit sha 44a06ca634f2922834b99b6571d8d30623e362b2

Revert "data-focus => autofocus" This reverts commit a30423d40f986a537e02a2048fdccacd41854f08.

view details

push time in 3 months

push eventpriznanie-digital/priznanie-digital

Daniel Husar

commit sha a30423d40f986a537e02a2048fdccacd41854f08

data-focus => autofocus

view details

push time in 3 months

PR opened priznanie-digital/priznanie-digital

Custom focus on `suhrn` and `vysledky` pages

https://trello.com/c/f6NlD8lQ/137-bug-accessibility-improvements

+6 -3

0 comment

3 changed files

pr created time in 3 months

create barnchpriznanie-digital/priznanie-digital

branch : dh/focus

created branch time in 3 months

Pull request review commentpriznanie-digital/priznanie-digital

Bug Report 2

 export function calculate(input: TaxFormUserInput): TaxForm {     },     get r074_znizenie_partner() {       if (this.r032_uplatnujem_na_partnera) {+        debugger

✂️

wormyy

comment created time in 3 months

delete branch priznanie-digital/priznanie-digital

delete branch : dh/download

delete time in 3 months

push eventpriznanie-digital/priznanie-digital

Daniel Husar

commit sha 5702674c93702f7963a762c9fad0bef6b8b2d733

Generate and download xml and pdf server side (#160) * Generate and download xml and pdf serverside * Fix generating pdf and move pdf and xml to server side * Remove unused var * Fix email * add new Date() to setDate calls * Revert "add new Date() to setDate calls" This reverts commit 8133dcaeca5c3b0b651e1b58336eda01a594b5f6.

view details

push time in 3 months

PR merged priznanie-digital/priznanie-digital

Generate and download xml and pdf server side

Fixne tieto tri issues:

https://trello.com/c/Z3SmSHPQ/132-ked-je-nahoden%C3%BD-popup-blocker-nechce-stiahnu%C5%A5-s%C3%BAbory-po-pokuse-z-linku-otvori%C5%A5-v-novom-okne-vyhadzuje-chyby-detto-xml-ani-pdf

https://trello.com/c/i5PSzA35/124-testovanie-chyby-pdf-s%C3%BAbor-je-po%C5%A1koden%C3%BD-alebo-pr%C3%A1zdny

https://trello.com/c/B3UrdVyU/130-posielanie-mailu-v-screene-v%C3%BDpo%C4%8Det-dane-za-rok-2019-po-zadan%C3%AD-mailu-na-odoslanie-formul%C3%A1ra-nefunguje-e%C5%A1te-nekomunikuje-so-server

Problem bol v podstate spolocny, data type ked sme poslali request na server sa stratili. Vyriesil som to posielanim taxFormUserInput namiesto taxForm a prekonvertovanim to spat na taxForm na serveri.

JSON.parse 😬 ale zvolil som easy cestu namiesto separatneho inputu pre kazdu hodnotu.

+95 -56

1 comment

7 changed files

danielhusar

pr closed time in 3 months

Pull request review commentpriznanie-digital/priznanie-digital

Update tax calculation (r125_dan_na_uhradu)

 export function calculate(input: TaxFormUserInput): TaxForm {       return new Decimal(parseInputNumber(input?.r122 ?? '0'))     },     get r125_dan_na_uhradu() {-      return Decimal.max(+      const baseTax =+        this.r105_dan.gt(17) || this.r106.gt(0) || this.r112.gt(0)+          ? this.r105_dan+          : new Decimal(0)+      const tax = Decimal.max(         0,-        this.r105_dan.plus(this.r114).minus(this.r112).minus(tf.r106),+        baseTax+          .minus(this.r106)+          .plus(this.r108)+          .plus(this.r110)+          .minus(this.r112)+          .plus(this.r114)+          .minus(this.r120)+          .minus(this.r122),       )-      // // - tf.r106 +-      // tf.r108 +-      // tf.r110 --      // // tf.r112 +-      // // tf.r114 +-      // tf.r116 +-      // tf.r117 --      // tf.r118 --      // tf.r119 --      // tf.r120 --      // tf.r121 --      // tf.r122 --      // tf.r123 --      // tf.r124;+      return tax.gt(5) ? tax : new Decimal(0)+      // 'r. 125': má byť výsledkom Max(0,r.105-r.106+r.108+r.110-r.112+r.114+r.116+r.117-r.118-r.119-r.120-r.121-r.122-r.123-r.124) ak platí, r.105>17.00 alebo r.105<=17.00 a zároveň je r.106>0 alebo r.112>0.

😅

mathio

comment created time in 3 months

push eventpriznanie-digital/priznanie-digital

Daniel Husar

commit sha cd8394667f5837f93c32f9af81aba22a1e49daea

Make street optional with fallback to municipality (#157) * Make street optional with fallback to municipality * Fix tests * Remove fallback

view details

Matej Lednicky

commit sha 4f7ff501c945d296a0cfd5a5450a9dc55d5a7df1

Ask for partner data on spa page if data was not entered previously

view details

Július Retzer

commit sha d50958bc871516539b8308ee0f70fb53e45eb155

Fix date (#162)

view details

Daniel Husar

commit sha c8649d8609a69357a49594082e36eef150ddcd0f

Merge branch 'master' into dh/download

view details

push time in 3 months

push eventpriznanie-digital/priznanie-digital

Daniel Husar

commit sha 94a3a909bc2235c06c15c234e5880e8263fbccb1

Revert "add new Date() to setDate calls" This reverts commit 8133dcaeca5c3b0b651e1b58336eda01a594b5f6.

view details

push time in 3 months

Pull request review commentpriznanie-digital/priznanie-digital

Generate and download xml and pdf server side

+import { NextApiRequest, NextApiResponse } from 'next'+import { convertToXML } from '../../lib/xml/xmlConverter'+import { setDate } from '../../lib/utils'+import { calculate } from '../../lib/calculation'+import { TaxForm } from '../../types/TaxForm'+import { TaxFormUserInput } from '../../types/TaxFormUserInput'++export default async (+  req: NextApiRequest,+  res: NextApiResponse,+): Promise<void> => {+  if (!req.body.taxFormUserInput) {+    return res.status(500).json({ error: 'invalid data' })+  }++  const formInput: TaxFormUserInput = JSON.parse(req.body.taxFormUserInput)+  const form: TaxForm = calculate(setDate(formInput))

nevadi revertnem to :)

danielhusar

comment created time in 3 months

push eventpriznanie-digital/priznanie-digital

Daniel Husar

commit sha 8133dcaeca5c3b0b651e1b58336eda01a594b5f6

add new Date() to setDate calls

view details

push time in 3 months

Pull request review commentpriznanie-digital/priznanie-digital

Generate and download xml and pdf server side

+import { NextApiRequest, NextApiResponse } from 'next'+import { convertToXML } from '../../lib/xml/xmlConverter'+import { setDate } from '../../lib/utils'+import { calculate } from '../../lib/calculation'+import { TaxForm } from '../../types/TaxForm'+import { TaxFormUserInput } from '../../types/TaxFormUserInput'++export default async (+  req: NextApiRequest,+  res: NextApiResponse,+): Promise<void> => {+  if (!req.body.taxFormUserInput) {+    return res.status(500).json({ error: 'invalid data' })+  }++  const formInput: TaxFormUserInput = JSON.parse(req.body.taxFormUserInput)+  const form: TaxForm = calculate(setDate(formInput))

Nemali by sme potom to opravit aj tu?

https://github.com/priznanie-digital/priznanie-digital/blob/master/src/pages/_app.tsx#L44

danielhusar

comment created time in 3 months

push eventpriznanie-digital/priznanie-digital

Daniel Husar

commit sha e378d3ddfed73dd61c4a0964d67e0c8f33950c5e

Fix email

view details

push time in 3 months

Pull request review commentpriznanie-digital/priznanie-digital

Persist the progress in the sessionStorage

+12.16.1

Ta cookie ale neriesi aby ostali vsetky data ktore som zatial zadal ak refreshmen nie? Nie je to ale big deal a ten prod/dev rozdiel je valid point :)

danielhusar

comment created time in 3 months

push eventpriznanie-digital/priznanie-digital

Daniel Husar

commit sha 3ad0adcb5d39414ec878cb97f5e4ac31f2496ef1

Remove unused var

view details

push time in 3 months

delete branch priznanie-digital/priznanie-digital

delete branch : dh/street

delete time in 3 months

push eventpriznanie-digital/priznanie-digital

Daniel Husar

commit sha cd8394667f5837f93c32f9af81aba22a1e49daea

Make street optional with fallback to municipality (#157) * Make street optional with fallback to municipality * Fix tests * Remove fallback

view details

push time in 3 months

PR merged priznanie-digital/priznanie-digital

Make street optional with fallback to municipality

https://trello.com/c/pPLnu45M/122-testovanie-chyby-adresa-danovnika

+1 -18

0 comment

4 changed files

danielhusar

pr closed time in 3 months

more