profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/danibachar/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
danibachar LNS Technologies Denver

danibachar/StarscreamQOS 1

A lightweight simple wrapper around Starscream websockets to supply QOS

danibachar/AudioEngine 0

Simple iOS wrapper above AVAudioEngine

danibachar/Blockchain 0

Blockchain IDC Course

danibachar/CocoaDebug 0

iOS Debugging Tool 🚀

danibachar/dataset 0

Multi30k Dataset

danibachar/EddystoneScanner-iOS-SDK 0

Eddystone Scanner SDK for iOS written in Swift 4.0

danibachar/enhancements 0

This repository contains enhancement proposals for submariner-io projects

push eventdanibachar/kube-multi-cluster-managment

I

commit sha ae8599ab42a43f59a5e5aaeaf7a22d6bf9791bee

service fixes

view details

push time in 7 days

push eventdanibachar/kube-multi-cluster-managment

I

commit sha ea2a4b74540973dd971b427417956dd57d0b64d3

trying to fix export endpoint

view details

push time in 7 days

push eventdanibachar/kube-multi-cluster-managment

I

commit sha c3a68d6a2712111f62feb82e2f84013af6af5717

script fix

view details

push time in 8 days

push eventdanibachar/kube-multi-cluster-managment

I

commit sha 350350198e8a42b2bc797d28a85bdf1a62efc4ce

more updates to scripts and job

view details

push time in 8 days

push eventdanibachar/kube-multi-cluster-managment

I

commit sha e7a904e96c76487ba42ff69b3bff5674a9cd954c

script typo fix

view details

push time in 8 days

push eventdanibachar/kube-multi-cluster-managment

I

commit sha 6a4f84d5f507f29a45a9b657321a65f5de2ae6c7

new service + setup script

view details

push time in 8 days

fork danibachar/kubefed

Kubernetes Cluster Federation

fork in 8 days

fork danibachar/submariner-operator

Submariner's Operator installs and maintains your Submariner deployment.

fork in 8 days

startedsubmariner-io/submariner

started time in 8 days

push eventdanibachar/kube-multi-cluster-managment

I

commit sha 247c072f2356578d59e9d859fdc30e3f6bd8f21b

another response test

view details

push time in 9 days

push eventdanibachar/kube-multi-cluster-managment

I

commit sha f2a73b0f17ec3b1e224d8f4d7ff645532a968085

service name fix + response show app

view details

push time in 9 days

push eventdanibachar/kube-multi-cluster-managment

I

commit sha 1b2a0395aa5aec1b35712dece1ccc06b74274d53

update load path

view details

push time in 9 days

push eventdanibachar/kube-multi-cluster-managment

I

commit sha 93abb103cf85e784014645212f2a19c1a7da7368

update response mapping

view details

push time in 9 days

push eventdanibachar/kube-multi-cluster-managment

I

commit sha 8087787b12c693a0847c2193b90a5dff406325e4

updates to port 80

view details

push time in 9 days

push eventdanibachar/kube-multi-cluster-managment

I

commit sha e2de95d560cb43ee20e8d2af5458227ee552ba3a

reversed docker env var

view details

push time in 9 days

push eventdanibachar/kube-multi-cluster-managment

I

commit sha 35adb425ab0fb0aa41cae5c5f6cb238b5079041b

await fix

view details

push time in 9 days

push eventdanibachar/kube-multi-cluster-managment

I

commit sha 358b84d3854d962f439b92e71ad5bd656312107f

list fix

view details

push time in 9 days

push eventdanibachar/kube-multi-cluster-managment

I

commit sha ef69f23072bea5adc18f691373e7f591dea7ef0f

updating and fixing jsons

view details

push time in 9 days

push eventdanibachar/kube-multi-cluster-managment

I

commit sha 3938422afa9f02b6136f8a17af7aef735840ab79

fixes and updates

view details

push time in 9 days

push eventdanibachar/kube-multi-cluster-managment

I

commit sha dc05c9293989cf379dd66f0ed9e9f880753f6d25

updating ports

view details

push time in 9 days

push eventdanibachar/kube-multi-cluster-managment

I

commit sha 97979aeebc138ef2215c0676e25fc976392f36d4

added path type

view details

push time in 9 days

push eventdanibachar/kube-multi-cluster-managment

I

commit sha 0effff2d77daf70287fac90c6dbfb03ed38de022

modern ingress updates

view details

push time in 9 days

push eventdanibachar/kube-multi-cluster-managment

I

commit sha 3ecd04c56fbfd6b0a3cbaededd325caed6f504b3

fixes

view details

push time in 9 days

push eventdanibachar/kube-multi-cluster-managment

I

commit sha 8e81603207f79653491424ac270217e23aa0470c

update ports + ingress

view details

push time in 9 days

push eventdanibachar/kube-multi-cluster-managment

I

commit sha 2ac9091b9df5e3e3571277bc6ae8911bf12dfc7f

fixed ports

view details

push time in 9 days

push eventdanibachar/kube-multi-cluster-managment

I

commit sha de78c415db75ef796623d7038051be294dc29481

updates

view details

push time in 9 days

push eventdanibachar/kube-multi-cluster-managment

I

commit sha c4aebcbd60938cf2f288df2c26028b826eabf23f

koss application testing

view details

push time in 9 days

Pull request review commentsubmariner-io/lighthouse

DNS Query Counter

+/*+SPDX-License-Identifier: Apache-2.0++Copyright Contributors to the Submariner project.++Licensed under the Apache License, Version 2.0 (the "License");+you may not use this file except in compliance with the License.+You may obtain a copy of the License at++    http://www.apache.org/licenses/LICENSE-2.0++Unless required by applicable law or agreed to in writing, software+distributed under the License is distributed on an "AS IS" BASIS,+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.+See the License for the specific language governing permissions and+limitations under the License.+*/+package lighthouse++import (+	"github.com/prometheus/client_golang/prometheus"+	"k8s.io/klog"+)++const (+	srcClusterKey      = "source_cluster"+	dstClusterKey      = "destination_cluster"+	dstSvcNameKey      = "destination_service_name"+	dstSvcIPKey        = "destination_service_ip"+	dstSvcNamespaceKey = "destination_service_namespace"++	ServiceDiscoveryQueryCounterName = "submariner_service_discovery_query_counter"+)++var dnsQueryCounter *prometheus.GaugeVec++func initLighthouseMetrics() {+	klog.Infof("Initializing dns query counter")++	dnsQueryCounter = prometheus.NewGaugeVec(+		prometheus.GaugeOpts{+			Name: ServiceDiscoveryQueryCounterName,+			Help: "Count the numebr of dns queries",+		},+		[]string{srcClusterKey, dstClusterKey, dstSvcNameKey, dstSvcNamespaceKey, dstSvcIPKey},+	)++	if err := prometheus.Register(dnsQueryCounter); err != nil {+		klog.Errorf("Failed to register: %s with prometheus due to: %v", ServiceDiscoveryQueryCounterName, err)+	}+}++func incDNSQueryCounter(srcCluster, dstCluster, dstSvcName, dstSvcNamespace, dstSvcIP string) {+	if dnsQueryCounter == nil {+		initLighthouseMetrics()+	}

Fixed! Thanks for that, I'm still getting familiar with Go - after reading a bit on the init function it makes total sense to do so and not using lazy init...

danibachar

comment created time in 9 days

PullRequestReviewEvent

push eventdanibachar/lighthouse

Stephen Kitt

commit sha 044e8065a23246d65d0f181b7f9c36433a68459a

Avoid direct error comparisons See https://go.dev/blog/go1.13-errors Signed-off-by: Stephen Kitt <skitt@redhat.com>

view details

Stephen Kitt

commit sha 30b9f820059c650f541f17e9852fd8696794368f

Add Sridhar Gaddam as code owner ... since he is now a project administrator, as voted on the mailing list. Signed-off-by: Stephen Kitt <skitt@redhat.com>

view details

Submariner Bot

commit sha 3f232cffa290cbb7db8e5c4e4627cad03593bd53

Pin Shipyard to v0.11.0-rc0 (#618) Signed-off-by: Automated Release <release@submariner.io> Co-authored-by: Automated Release <release@submariner.io>

view details

Submariner Bot

commit sha 25c3102d1bb426009a47a5de314866c5e3575f56

Pin Admiral to v0.11.0-rc0 (#619) Signed-off-by: Automated Release <release@submariner.io> Co-authored-by: Automated Release <release@submariner.io>

view details

Aswin Suryanarayanan

commit sha 16b739f75dcdbf31a04b3967e11173b7b67c6521

Remove the LabelServiceImportName Label (#622) LabelServiceImportName is exceeding the label maximum length of 63 in certain scenarios. It is used to uniquely identify the endpointslice to be deleted. Now, this label is removed and we use the remaining three labels in the endpoint slice to uniquely identify it for deletion. Fixes: #593 Signed-off-by: Aswin Surayanarayanan <asuryana@redhat.com>

view details

Stephen Kitt

commit sha 0bcd4aa8e861a662a10a80b6e711e015a1ce6b27

Replace github.com/dgrijalva/jwt-go with golang-jwt This addresses CVE-2020-26160; see https://github.com/submariner-io/lighthouse/security/dependabot/go.sum/github.com%2Fdgrijalva%2Fjwt-go/open We can't replace with v3.2.2 because that's used elsewhere, and the build then fails with go: github.com/golang-jwt/jwt@v3.2.2+incompatible used for two different module paths (github.com/dgrijalva/jwt-go and github.com/golang-jwt/jwt) Signed-off-by: Stephen Kitt <skitt@redhat.com>

view details

Submariner Bot

commit sha 8cde6133cb705e9c9a828c42105377b82dc8886d

Pin Shipyard to v0.11.0-rc1 (#624) Signed-off-by: Automated Release <release@submariner.io> Co-authored-by: Automated Release <release@submariner.io>

view details

Submariner Bot

commit sha 1c9a14613cba0e6d3053b835b21e04801df98fda

Pin Admiral to v0.11.0-rc1 (#625) Signed-off-by: Automated Release <release@submariner.io> Co-authored-by: Automated Release <release@submariner.io>

view details

dependabot[bot]

commit sha 0c254c2414204b7d4e4f94b101c77fdd928f97af

Bump github.com/onsi/ginkgo from 1.16.4 to 1.16.5 Bumps [github.com/onsi/ginkgo](https://github.com/onsi/ginkgo) from 1.16.4 to 1.16.5. - [Release notes](https://github.com/onsi/ginkgo/releases) - [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md) - [Commits](https://github.com/onsi/ginkgo/compare/v1.16.4...v1.16.5) --- updated-dependencies: - dependency-name: github.com/onsi/ginkgo dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

view details

Tom Pantelis

commit sha 7632636b3ab25389f0640fe3c09c1251f61bfca1

Bump github.com/gorilla/websocket to v1.4.1 ...to address a security vulnerability outlined at: https://github.com/submariner-io/lighthouse/security/dependabot/go.sum/github.com%2Fgorilla%2Fwebsocket/open Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

view details

Stephen Kitt

commit sha 49d7220208ed8b58fefada87c6b9f95a10f3385f

Run full e2e on 1.22 This will help avoid future regressions on 1.22. Signed-off-by: Stephen Kitt <skitt@redhat.com>

view details

I

commit sha f01d4163ecf5d5038fdedc1061b4ef55035c0cea

DNS Query Counter Signed-off-by: I <danibachar89@gmail.com>

view details

I

commit sha 0921ab8a8777d328a6644f05897a48a6186a4bf7

PR fixes Signed-off-by: I <danibachar89@gmail.com>

view details

push time in 9 days