profile
viewpoint
Damien Tournoud damz Platform.sh CTO at @platformsh

damz/drupal-nodejs 9

Experiment NodeJS real-time comment refresh for Drupal.

damz/drupaltestbot-puppet 6

Puppet manifests for the Drupal test bot. Now hosted at https://drupal.org/sandbox/rfay/1089426

damz/drupaltestbot 5

Distribution package for the test bot. Now migrated to https://drupal.org/sandbox/rfay/1089408

damz/comment_highlight 1

A small Drupal 6 module to allow comments to be highlighted.

damz/commerce_dateprice 1

A date-based price field for Drupal Commerce.

damz/drupal-azure 1

Drupal Azure support modules.

damz/drupalcommerce 1

A next generation e-commerce system for Drupal targeting Drupal 7 and beyond.

damz/address 0

A component for managing postal addresses.

delete branch dgraph-io/badger

delete branch : bucanero/patch-1

delete time in 2 days

push eventdgraph-io/badger

Damián Parrino

commit sha 2d88aea98099cc021fe39a783629759c90d9e139

Remove link from index.md (#1607) Remove `Github issues` links

view details

push time in 2 days

PR merged dgraph-io/badger

Reviewers
docs (chore): Remove github issues link

Remove Github issues links

<!-- Reviewable:start -->

This change is <img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/> <!-- Reviewable:end -->

+2 -3

0 comment

1 changed file

bucanero

pr closed time in 2 days

Pull request review commentdgraph-io/badger

compaction: reset value pointer

 func (s *levelsController) subcompact(it y.Iterator, kr keyRange, cd compactDef, 				vp.Decode(vs.Value) 			} 			builder.Add(it.Key(), vs, vp.Len)+			vp.Fid, vp.Len, vp.Offset = 0, 0, 0

Hey, I am not able to push to your branch due to permission issues. Can you please make the following downscoping changes and then the PR should be good to go?

diff --git a/levels.go b/levels.go
index 76d282a..8c27e45 100644
--- a/levels.go
+++ b/levels.go
@@ -636,7 +636,6 @@ func (s *levelsController) subcompact(it y.Iterator, kr keyRange, cd compactDef,
 
        var lastKey, skipKey []byte
        var numBuilds, numVersions int
-       var vp valuePointer
 
        addKeys := func(builder *table.Builder) {
                timeStart := time.Now()
@@ -737,11 +736,11 @@ func (s *levelsController) subcompact(it y.Iterator, kr keyRange, cd compactDef,
                                }
                        }
                        numKeys++
+                       var vp valuePointer
                        if vs.Meta&bitValuePointer > 0 {
                                vp.Decode(vs.Value)
                        }
                        builder.Add(it.Key(), vs, vp.Len)
-                       vp.Fid, vp.Len, vp.Offset = 0, 0, 0
                }
                s.kv.opt.Debugf("LOG Compact. Added %d keys. Skipped %d keys. Iteration took: %v",
                        numKeys, numSkips, time.Since(timeStart).Round(time.Millisecond))

Thanks

raulk

comment created time in 2 days

create barnchdgraph-io/badger

branch : naman/reset-vp

created branch time in 2 days

delete branch dgraph-io/badger

delete branch : patch-1

delete time in 2 days

create barnchdgraph-io/badger

branch : patch-1

created branch time in 2 days

PR opened dgraph-io/badger

docs (chore): Remove github issues link

Remove Github issues links

+2 -3

0 comment

1 changed file

pr created time in 6 days

create barnchdgraph-io/badger

branch : bucanero/patch-1

created branch time in 6 days

push eventdgraph-io/badger

Manish R Jain

commit sha 3d225d79b515ba0bcd81c929dbb6822f03742526

Bug Fix: Create the right txn based on Badger mode

view details

push time in 6 days

delete branch dgraph-io/badger

delete branch : mrjn/stream-buffer

delete time in 6 days

push eventdgraph-io/badger

Manish R Jain

commit sha ab8b5d9ed1964c203a9c5cf0a46434f49c26995e

Opt(stream): Use z.Buffer to stream data (#1606) Stream.Send now sends out z.Buffer instead of pb.KVList. z.Buffer marshals each KV as a separate slice. This significantly reduces the memory requirement by the Stream framework. Stream no longer uses z.Allocator or tries to put pb.KV struct on the Allocator for memory safety reasons. Bring back the z.AllocatorPool for table.Builder. Changes: * Use z.Buffer for stream.Send * Only use 8 streams in write bench * Revert "Bug Fix: Fix up how we use z.Allocator" This reverts commit 5ff9e1dd1b89230b137154bd80ea03925710d7ab. * Bring allocator back. Use z.Buffer for send * Add BufferToKVList function * Print jemalloc while stream * Bring in latest Ristretto * Fix memory leak and benchmark read test Co-authored-by: Ibrahim Jarif <ibrahim@dgraph.io>

view details

push time in 6 days

PR merged dgraph-io/badger

Opt(stream): Use z.Buffer to stream data

Stream.Send now sends out z.Buffer instead of pb.KVList. z.Buffer marshals each KV as a separate slice. This significantly reduces the memory requirement by the Stream framework. Stream no longer uses z.Allocator or tries to put pb.KV struct on the Allocator for memory safety reasons.

Bring back the z.AllocatorPool for table.Builder.

<!-- Reviewable:start --> This change is <img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/> <!-- Reviewable:end -->

+259 -178

0 comment

18 changed files

manishrjain

pr closed time in 6 days

push eventdgraph-io/badger

Manish R Jain

commit sha 91465f02b944be94da869ad0f31b3bdf9e3f61db

Review

view details

push time in 6 days

push eventdgraph-io/badger

Manish R Jain

commit sha 38d0af09286a1063068f3f143d912ecd1afbd900

tidy

view details

push time in 6 days

push eventdgraph-io/badger

Manish R Jain

commit sha 384257fd9fc285e30c7ae3565fcbaf3623b2f20c

Fix memory leak and benchmark read test

view details

push time in 6 days

push eventdgraph-io/badger

Manish R Jain

commit sha b70d3663dfd3380c74836646052479757fd8f60b

Review

view details

push time in 6 days

push eventdgraph-io/badger

Manish R Jain

commit sha f189b3b1999aad64916827978035ca4d40af2754

Bring in latest Ristretto

view details

push time in 7 days

PR opened dgraph-io/badger

Use z.Buffer to stream
+263 -169

0 comment

17 changed files

pr created time in 7 days

push eventdgraph-io/badger

Ibrahim Jarif

commit sha f36daf538d71baed9d23c4b1c187c01115e73634

fix(stream): Stop produceKVs on error (#1604) The orchestrate function would get blocked forever if send function returned an error. The produceKv go routines would also get blocked since the size of the error chan was 1.

view details

Ibrahim Jarif

commit sha 925e15b8c467f8555dd08b9d4ce3ab9a513a1e1a

Fix race condition in L0StallMs variable (#1605) This fixes two issues - Atomic variable was not being accessed correctly - Atomic variable should be the first member of the struct to ensure proper alignment. Failure to do so will cause a segmentation fault. Fixes DGRAPH-2773

view details

Ibrahim Jarif

commit sha feb1f5f3ad2a96f5c7a33f6d34e00851db37f423

chore(iterators): Do not return error on missing vlog (#1602) Add debugging information in yieldItemValue function to find the root cause of missing vlog files error. Note: This commit should be reverted once the issue has been resolved.

view details

Manish R Jain

commit sha 224c4cc5f5986ccdb345a6acebff06479966ec8a

merge master

view details

push time in 7 days

delete branch dgraph-io/badger

delete branch : ibrahim/iterator-log-error

delete time in 7 days

push eventdgraph-io/badger

Ibrahim Jarif

commit sha feb1f5f3ad2a96f5c7a33f6d34e00851db37f423

chore(iterators): Do not return error on missing vlog (#1602) Add debugging information in yieldItemValue function to find the root cause of missing vlog files error. Note: This commit should be reverted once the issue has been resolved.

view details

push time in 7 days

push eventdgraph-io/badger

Ibrahim Jarif

commit sha 1095f479e09cd7d455d5b971e341b2002ae9bd09

prevent infinite loop

view details

push time in 7 days

Pull request review commentdgraph-io/badger

compaction: reset value pointer

 func (s *levelsController) subcompact(it y.Iterator, kr keyRange, cd compactDef, 				vp.Decode(vs.Value) 			} 			builder.Add(it.Key(), vs, vp.Len)+			vp.Fid, vp.Len, vp.Offset = 0, 0, 0

Feel free to push a commit on this PR if you'd like that downscoped.

raulk

comment created time in 7 days

push eventdgraph-io/badger

Ibrahim Jarif

commit sha f36daf538d71baed9d23c4b1c187c01115e73634

fix(stream): Stop produceKVs on error (#1604) The orchestrate function would get blocked forever if send function returned an error. The produceKv go routines would also get blocked since the size of the error chan was 1.

view details

Ibrahim Jarif

commit sha 925e15b8c467f8555dd08b9d4ce3ab9a513a1e1a

Fix race condition in L0StallMs variable (#1605) This fixes two issues - Atomic variable was not being accessed correctly - Atomic variable should be the first member of the struct to ensure proper alignment. Failure to do so will cause a segmentation fault. Fixes DGRAPH-2773

view details

Ibrahim Jarif

commit sha 524fec57e430b8a2f66439f8ce448c666ce6090a

Merge branch 'master' into ibrahim/iterator-log-error

view details

push time in 7 days

Pull request review commentdgraph-io/badger

compaction: reset value pointer

 func (s *levelsController) subcompact(it y.Iterator, kr keyRange, cd compactDef, 				vp.Decode(vs.Value) 			} 			builder.Add(it.Key(), vs, vp.Len)+			vp.Fid, vp.Len, vp.Offset = 0, 0, 0

It could, but it won't change the logic.

raulk

comment created time in 7 days

delete branch dgraph-io/badger

delete branch : ibrahim/stall-race

delete time in 7 days

push eventdgraph-io/badger

Ibrahim Jarif

commit sha 925e15b8c467f8555dd08b9d4ce3ab9a513a1e1a

Fix race condition in L0StallMs variable (#1605) This fixes two issues - Atomic variable was not being accessed correctly - Atomic variable should be the first member of the struct to ensure proper alignment. Failure to do so will cause a segmentation fault. Fixes DGRAPH-2773

view details

push time in 7 days

PR merged dgraph-io/badger

Reviewers
Fix race condition in L0StallMs variable

This fixes two issues

  • Atomic variable was not being accessed correctly
  • Atomic variable should be first member of the struct to ensure proper alignment. Failure to do so will cause a segmentation fault.

Fixes DGRAPH-2773 <!-- Reviewable:start -->

This change is <img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/> <!-- Reviewable:end -->

+3 -3

0 comment

2 changed files

jarifibrahim

pr closed time in 7 days

more