profile
viewpoint
Damian Green damiangreen London Freelance code monkey

damiangreen/isomorphic-react-fittext 4

React component that fits text on the screen.

damiangreen/react-live-clock 1

React clock with time-zones

damiangreen/Amazon.SimpleNotificationService.UtilExtensions 0

More parsing capabilities for SNS messages

damiangreen/angular-flower-expert-application 0

Practicing with Angularjs

damiangreen/angular-validator 0

Powerful, flexible and simple Angular validation!

damiangreen/ant-design 0

🐜 A UI Design Language

damiangreen/BiPartite 0

Create BiPartite visualization using D3

damiangreen/calendar 0

React Calendar

damiangreen/card 0

make your credit card form better in one line of code

damiangreen/clipper 0

An open source freeware polygon clipping library

issue commentfacebook/react

Bug: eslint-plugin-react-hooks "Cannot read property parent of null"

@LauraBeatris did you make the issue? if so can you mention it in this thread. as this is the top Google result..

travigd

comment created time in 9 hours

issue commentfacebook/react

Bug: eslint-plugin-react-hooks "Cannot read property parent of null"

I'm still seeing this with eslint-plugin-react-hooks@4.1.2, @typescript-eslint/parser": "^4.2.0, @typescript-eslint/eslint-plugin": "^4.2.0" eslint": "^7.9.0"

travigd

comment created time in 7 days

issue commentpmmmwh/react-refresh-webpack-plugin

How do i know if it's working?

yes, that's right, editing a file and waiting for the component to reload is slower than the existing react hot loader.. unfortunately

damiangreen

comment created time in 9 days

issue commentpmmmwh/react-refresh-webpack-plugin

How do i know if it's working?

the hot reloading. I did see there is another issue related to this in this repo, but it would be difficult to create a repo for.

damiangreen

comment created time in 10 days

issue commentpmmmwh/react-refresh-webpack-plugin

How do i know if it's working?

hi @pmmmwh I did, however it seems noticably slow than hot reloader so we havent adopted it yet

damiangreen

comment created time in 10 days

issue openedstephencookdev/speed-measure-webpack-plugin

Enabling `granularLoaderData` causese`rror: options/query provided without loader (use loader + options) in` error

Enabling granularLoaderData causeserror: options/query provided without loader (use loader + options) in error Is there somethign else i need to do?

Full console output:

Error: options/query provided without loader (use loader + options) in { "test": {}, "include": [ ... ], "options": { "cacheDirectory": true, "babelrc": false, "presets": [ [ "@babel/preset-env", { "targets": { "browsers": [ ">1%", "last 4 versions", "Firefox ESR", "not ie < 9" ] }, "forceAllTransforms": false, "modules": false, "useBuiltIns": false, "debug": false } ], "@babel/preset-typescript", [ "@babel/preset-react", { "development": true } ] ], "plugins": [ [ "@babel/plugin-syntax-dynamic-import" ], [ "@babel/plugin-syntax-import-meta" ], [ "@babel/plugin-proposal-class-properties" ], [ "@babel/plugin-proposal-json-strings" ], [ "react-intl", { "messagesDir": "D:\damian\datto-rmm-frontend\build\messages\extracted", "extractSourceLocation": true } ] ] }, "use": [ "speed-measure-webpack-plugin/loader", "babel-loader" ] }

created time in a month

issue openedpmmmwh/react-refresh-webpack-plugin

How do i know if it's working?

I've followed the instructions to install into an existing app that was already using webpack-hot-middleware + webpack-dev-middleware

i'm seeing no difference in the command line. I see [HMR] Update applied. as per usual.

Is there some way to know if this plugin is working?

created time in a month

startedapache/incubator-echarts

started time in a month

issue openedwebpack/webpack

[WebPack 5] fails to bundle default unnamed iterator functions

<!-- Please don't delete this template because we'll close your issue --> <!-- Before creating an issue please make sure you are using the latest version of webpack. -->

Bug report

What is the current behavior? Bundling of this code (from d3-hierarchy)

export default function*() {
  var node = this, current, next = [node], children, i, n;
  do {
    current = next.reverse(), next = [];
    while (node = current.pop()) {
      yield node;
      if (children = node.children) {
        for (i = 0, n = children.length; i < n; ++i) {
          next.push(children[i]);
        }
      }
    }
  } while (next.length);
}


generators code like this

/* harmony default export */ function __WEBPACK_DEFAULT_EXPORT__*() {
  var node = this, current, next = [node], children, i, n;

It fails to compile because of the * in __WEBPACK_DEFAULT_EXPORT__*

Naming the iterator function seems to fix it

webpack version: 5.0.0-beta.28 Node.js version: v13.12.0 Operating System: win 10 +mac Additional tools:Babel

created time in a month

pull request commentkonvajs/react-konva

Make React Konva compatible with React v17

ok cool, this is one of only 2 libraries that dont work in our large scale app with React 17, so maybe i can use your fork

alexkuz

comment created time in a month

issue openedreact-component/virtual-list

React 17: Cannot read property 'removeEventListener' of null

This error is thrown "React 17: Cannot read property 'removeEventListener' of null" when using React 17, unmounting

  217 | React.useEffect(function () {
  218 |   componentRef.current.addEventListener('wheel', onRawWheel);
  219 |   return function () {
> 220 |     componentRef.current.removeEventListener('wheel', onRawWheel);
      | ^  221 |   };
  222 | }, [inVirtual]); // ================================= Ref ==================================
  223 | 

created time in a month

pull request commentkonvajs/react-konva

Make React Konva compatible with React v17

@alexkuz will this PR fix this issue? https://github.com/konvajs/react-konva/issues/171

alexkuz

comment created time in a month

issue commentkonvajs/react-konva

react-reconciler.development.js:130 Uncaught TypeError: Cannot read property 'alternate' of undefined

I'm now seeing this after attempting to upgrade to React 17. Not sure if there is a react-konva fiddle i can try with to repro

PawelGIX

comment created time in a month

issue openedkonvajs/konva

Doesnt work in IE11 or Edge

The canvas is black in both edge and IE for the example e.g. https://konvajs.org/docs/react/index.html

However the docs here (https://konvajs.org/api/#toc2__anchor)says it works in modern browsers.

Should it work at all?

created time in a month

issue openedd3/d3-hierarchy

IE11 issue - Const must be initialized in each.js

in line for (const node of this) {

created time in a month

startedkonvajs/konva

started time in a month

startedkonvajs/react-konva

started time in a month

startedd3/d3

started time in 2 months

issue commentkonvajs/react-konva

TypeScript: Errors on react-konva refs

hey thanks for the super speedy response. I just bumped the package

const stageRef = useRef<Konva.Stage>(null)
...
      <Stage
        ref={stageRef}

but get

No overload matches this call. Overload 1 of 2, '(props: Readonly<StageProps & KonvaNodeEvents>): Stage', gave the following error. Type 'MutableRefObject<Stage>' is not assignable to type 'LegacyRef<Stage>'. Type 'MutableRefObject<Stage>' is not assignable to type 'RefObject<Stage>'. Types of property 'current' are incompatible. Type 'Stage' is missing the following properties from type 'Stage': context, setState, forceUpdate, render, and 3 more. Overload 2 of 2, '(props: StageProps & KonvaNodeEvents, context?: any): Stage', gave the following error. Type 'MutableRefObject<Stage>' is not assignable to type 'LegacyRef<Stage>'. Type 'MutableRefObject<Stage>' is not assignable to type 'RefObject<Stage>'.ts(2769)

is Konva.Stage the correct generic argument for useRef? 🙇

andytan0727

comment created time in 2 months

issue commentkonvajs/react-konva

TypeScript: Errors on react-konva refs

Should this approach work for stage? I tried it but get

const stageRef: React.RefObject<Konva.Stage> = createRef()
....
 <Stage
        ref={stageRef}
...

Type 'Stage' is missing the following properties from type 'Stage': context, setState, forceUpdate, render, and 3 more. Overload 2 of 2, '(props: StageProps & KonvaN

andytan0727

comment created time in 2 months

issue commentkonvajs/react-konva

Get stage

where are you declaring the ref here , and how, useRef/ createRef? I don't seem to be able to get this to work

hesamfarhang

comment created time in 2 months

issue commentyannickcr/eslint-plugin-react

'(react/prop-types): Missing in props validation' when props interface extends from another

do we know which version this will be released in?

ggd543

comment created time in 2 months

issue closedSTRML/react-grid-layout

Warning: React.createElement: type is invalid -- expected a string (for built-in components) or a class/function (for composite components) but got: object.

Upgrading to react-grid-layout@1.0.0 throws this error. I can't find anything in the release notes about this version or breaking changes

closed time in 2 months

damiangreen

issue openedSTRML/react-grid-layout

Warning: React.createElement: type is invalid -- expected a string (for built-in components) or a class/function (for composite components) but got: object.

Upgrading to react-grid-layout@1.0.0 throws this error. I can't find anything in the release notes about this version or breaking changes

created time in 2 months

issue commentant-design/ant-design

[Table Pagination Bug] when PageSize is larger than current data length, <Table /> will always show the first page data.

This still appears to be an issue in the latest version

sdli

comment created time in 3 months

issue commentlukechilds/merge-images

Is it possible to use this to combine 2 base64 images?

Update. I managed to get it owrk.. the trick is to ensure it has the following format:(begins with data:image/png;base64,)

export const onlineRing =
  'data:image/png;base64,iVBORw0KGgoAAA....
dkChase

comment created time in 3 months

more